@willcgage/module-schematic 0.69.0 → 0.71.0

package/dist/index.cjs

@@ -471,8 +471,12 @@ function moduleFootprint(input) {
   const widthA = endplateWidthFor(input.endplateWidths, "A");
   const widthB = endplateWidthFor(input.endplateWidths, "B");
   const authored = benchworkOutline(input);
-  const offA = input.endplateTrackOffsets?.["A"] ?? 0;
-  const offB = input.endplateTrackOffsets?.["B"] ?? 0;
+  const offOf = (i, id) => input.endplateTrackOffsets?.[id] ?? endplateCentreOffsetInches({
+    config: input.endplateConfigs?.[i],
+    main2Below: input.mainsSwapped === true
+  });
+  const offA = offOf(0, "A");
+  const offB = offOf(1, "B");
   const secs = input.sections ?? [];
   const sectionsOwnShape = secs.length > 1 || secs.some((s) => (s.outline?.length ?? 0) >= 3);
   const sectionOutlines = sectionsOwnShape ? sectionFootprints(input, {
@@ -485,9 +489,10 @@ function moduleFootprint(input) {
   return {
     centerline,
     band: benchworkBand(centerline, widthA, widthB, offA, offB),
-    // A loop's centre-line ends at the throat, not a far endplate — keep only
-    // endplate A's face (the far face would be a spurious plate at the throat).
-    endplateFaces: input.loop ? endplateFaceSegments(centerline, widthA, widthB, offA, offB).slice(0, 1) : endplateFaceSegments(centerline, widthA, widthB, offA, offB),
+    // Only emit a face where the module actually presents one. A loop's
+    // centre-line ends at the THROAT, and an end of the line / pocket simply
+    // stops — a far face there is a plate the module hasn't got (#191).
+    endplateFaces: hasNoFarEndplate(input) ? endplateFaceSegments(centerline, widthA, widthB, offA, offB).slice(0, 1) : endplateFaceSegments(centerline, widthA, widthB, offA, offB),
     outline: sectionOutlines.length || !authored ? null : sampleBenchworkOutline(authored),
     // The donut hole, arc-sampled — only when there's a solid outline to punch it
     // out of (a sectioned module isn't a donut). Renderers cut it from `outline`.
@@ -495,13 +500,19 @@ function moduleFootprint(input) {
     sectionOutlines
   };
 }
-function endplateTrackOffsetFor(config, authoredTrackOffset) {
-  const v = -endplateTrackOffsetInches(authoredTrackOffset, config);
+function endplateCentreOffsetInches(input) {
+  const v = -endplateTrackOffsetInches(
+    input.authoredTrackOffsetInches,
+    input.config ?? void 0,
+    input.main2Below
+  );
   return v === 0 ? 0 : v;
 }
-function endplateTrackOffsetInches(authored, config) {
+function endplateTrackOffsetInches(authored, config, main2Below = false) {
   if (typeof authored === "number" && Number.isFinite(authored)) return authored;
-  return config === "double" ? -FREEMO_TRACK_SPACING_INCHES / 2 : 0;
+  if (config !== "double") return 0;
+  const half = FREEMO_TRACK_SPACING_INCHES / 2;
+  return main2Below ? half : -half;
 }
 function checkEndplateWidth(input) {
   const width = endplateWidthInches(input);
@@ -513,8 +524,13 @@ function checkEndplateWidth(input) {
       requiredInches: FREEMO_ENDPLATE_WIDTH_MIN_INCHES
     });
   }
-  const off = endplateTrackOffsetInches(input.trackOffsetInches, input.config ?? void 0);
-  const centres = input.config === "double" ? [off, off + FREEMO_TRACK_SPACING_INCHES] : [off];
+  const off = endplateTrackOffsetInches(
+    input.trackOffsetInches,
+    input.config ?? void 0,
+    input.main2Below
+  );
+  const second = off + (input.main2Below ? -1 : 1) * FREEMO_TRACK_SPACING_INCHES;
+  const centres = input.config === "double" ? [off, second] : [off];
   const worst = Math.max(...centres.map((c) => Math.abs(c)));
   const clearance = width / 2 - worst;
   if (clearance < FREEMO_ENDPLATE_TRACK_FASCIA_CLEARANCE_INCHES) {
@@ -525,6 +541,18 @@ function checkEndplateWidth(input) {
       requiredInches: required
     });
   }
+  if (input.config === "double") {
+    const mid = (off + second) / 2;
+    if (Math.abs(mid) > 0.01) {
+      issues.push({
+        code: "offcentre",
+        message: `The two tracks sit ${round2(Math.abs(mid))}\u2033 off the centre of this endplate. The standard recommends they straddle it \u2014 Main 1 at ${round2((input.main2Below ? 1 : -1) * (FREEMO_TRACK_SPACING_INCHES / 2))}\u2033. Clear the offset to use that.`,
+        // Not a width problem — no wider plate fixes it — so hand back the
+        // width unchanged rather than imply one would.
+        requiredInches: width
+      });
+    }
+  }
   return issues;
 }
 var round2 = (n) => Math.round(n * 100) / 100;
@@ -533,6 +561,9 @@ function endplateWidthFor(widths, id) {
   const w = widths?.[id];
   return typeof w === "number" && w > 0 ? w : FREEMO_ENDPLATE_WIDTH_RECOMMENDED_INCHES;
 }
+function hasNoFarEndplate(input) {
+  return input.geometryType === "dead_end" || input.loop === true || input.endplateConfigs?.[1] === "none";
+}
 function isLoopDoc(doc) {
   return doc.loop === true;
 }
@@ -1993,7 +2024,7 @@ function deriveEndplatePoses(geo) {
       trackOffsets: offsetsFor(cfg(0), half)
     })
   );
-  const noB = geo.geometryType === "dead_end" || geo.loop === true || geo.endplateConfigs?.[1] === "none";
+  const noB = hasNoFarEndplate(geo);
   const end = sectionedEndPose({ sections: geo.sections });
   if (!noB && end) {
     poses.push(
@@ -2173,15 +2204,16 @@ exports.deriveEndplatePoses = deriveEndplatePoses;
 exports.divergeSideForHand = divergeSideForHand;
 exports.docToState = docToState;
 exports.emptyEditorState = emptyEditorState;
+exports.endplateCentreOffsetInches = endplateCentreOffsetInches;
 exports.endplateFaceSegments = endplateFaceSegments;
 exports.endplateLead = endplateLead;
-exports.endplateTrackOffsetFor = endplateTrackOffsetFor;
 exports.endplateTrackOffsetInches = endplateTrackOffsetInches;
 exports.endplateWidthInches = endplateWidthInches;
 exports.frogCasting = frogCasting;
 exports.frogNumberFromName = frogNumberFromName;
 exports.fromSectionRelative = fromSectionRelative;
 exports.geometryTurnDegrees = geometryTurnDegrees;
+exports.hasNoFarEndplate = hasNoFarEndplate;
 exports.importedPartToTrackPart = importedPartToTrackPart;
 exports.inchesToScaleFeet = inchesToScaleFeet;
 exports.isLoopDoc = isLoopDoc;