@willcgage/module-schematic 0.66.0 → 0.68.0

package/dist/index.d.cts

@@ -673,7 +673,21 @@ declare function checkEndplateWidth(input: {
     config?: TrackConfig | "none" | null;
     trackOffsetInches?: number | null;
 }): EndplateWidthIssue[];
-/** Whether a doc is a single-endplate turnback (explicit flag or one endplate). */
+/**
+ * Whether a doc is a balloon loop — **the authored flag, and only that**.
+ *
+ * ⚠️ This used to ALSO infer a loop from `endplates.length === 1`, which was
+ * safe only while the sole way to have one endplate was to be a turnback. #184
+ * ended that: an *end of the line* or a *pocket* presents one conforming face
+ * too, so every single-ended module was silently classified as a loop — drawn
+ * with a bulb, its endplate A relabelled "Entry", and positions past the throat
+ * read as being inside a balloon that doesn't exist (#191).
+ *
+ * A loop is now only ever a loop because someone said so: the Loop checkbox and
+ * the return-loop generator both set `loop: true`. Checked before removing the
+ * inference — no stored doc relied on it (no module in the catalogue has one
+ * endplate without the flag, and none is `category:"loop"` or `dead_end`).
+ */
 declare function isLoopDoc(doc: ModuleSchematicDoc): boolean;
 declare const MAIN_TRACK_ID = "main";
 /** The second main on double-track modules — a real track entity so turnouts
@@ -789,9 +803,11 @@ interface EditorBranch {
      * draws track to it; the plate is placed first, connected later). */
     trackId?: string | null;
 }
-/** Endplate B on a loop module: a standard endplate makes the balloon an
- * INTERCHANGE (a second route connects at the loop, e.g. Seaford); "none"
- * makes it a pure turnback. Non-loop modules always have a real B. */
+/** Endplate B's configuration — or `"none"`, meaning **the module has no far
+ * endplate**: an end of the line, a pocket, or a loop's pure turnback. On a
+ * loop, a standard endplate B instead makes the balloon an INTERCHANGE (a second
+ * route connects there, e.g. Seaford). A module presents one conforming face,
+ * or two, or more; the standard governs the faces it offers, not how many (#184). */
 type EndplateBConfig = TrackConfig | "none";
 interface EditorState {
     lengthInches: number;
@@ -1667,8 +1683,10 @@ interface ModuleGeometryInput {
     geometryType?: string | null;
     geometryDegrees?: number | null;
     geometryOffsetInches?: number | null;
-    /** Axial endplate configs (A first, then B). Missing → single. */
-    endplateConfigs?: ("single" | "double" | null | undefined)[];
+    /** Axial endplate configs (A first, then B). Missing → single. `"none"` at B
+     * means the module has no far endplate at all — an end of the line, a pocket,
+     * or a turnback (#184). */
+    endplateConfigs?: ("single" | "double" | "none" | null | undefined)[];
     /** Branch endplates (from the schematic doc, #170), positioned along the
      * mainline axis. */
     branches?: {

package/dist/index.d.ts

@@ -673,7 +673,21 @@ declare function checkEndplateWidth(input: {
     config?: TrackConfig | "none" | null;
     trackOffsetInches?: number | null;
 }): EndplateWidthIssue[];
-/** Whether a doc is a single-endplate turnback (explicit flag or one endplate). */
+/**
+ * Whether a doc is a balloon loop — **the authored flag, and only that**.
+ *
+ * ⚠️ This used to ALSO infer a loop from `endplates.length === 1`, which was
+ * safe only while the sole way to have one endplate was to be a turnback. #184
+ * ended that: an *end of the line* or a *pocket* presents one conforming face
+ * too, so every single-ended module was silently classified as a loop — drawn
+ * with a bulb, its endplate A relabelled "Entry", and positions past the throat
+ * read as being inside a balloon that doesn't exist (#191).
+ *
+ * A loop is now only ever a loop because someone said so: the Loop checkbox and
+ * the return-loop generator both set `loop: true`. Checked before removing the
+ * inference — no stored doc relied on it (no module in the catalogue has one
+ * endplate without the flag, and none is `category:"loop"` or `dead_end`).
+ */
 declare function isLoopDoc(doc: ModuleSchematicDoc): boolean;
 declare const MAIN_TRACK_ID = "main";
 /** The second main on double-track modules — a real track entity so turnouts
@@ -789,9 +803,11 @@ interface EditorBranch {
      * draws track to it; the plate is placed first, connected later). */
     trackId?: string | null;
 }
-/** Endplate B on a loop module: a standard endplate makes the balloon an
- * INTERCHANGE (a second route connects at the loop, e.g. Seaford); "none"
- * makes it a pure turnback. Non-loop modules always have a real B. */
+/** Endplate B's configuration — or `"none"`, meaning **the module has no far
+ * endplate**: an end of the line, a pocket, or a loop's pure turnback. On a
+ * loop, a standard endplate B instead makes the balloon an INTERCHANGE (a second
+ * route connects there, e.g. Seaford). A module presents one conforming face,
+ * or two, or more; the standard governs the faces it offers, not how many (#184). */
 type EndplateBConfig = TrackConfig | "none";
 interface EditorState {
     lengthInches: number;
@@ -1667,8 +1683,10 @@ interface ModuleGeometryInput {
     geometryType?: string | null;
     geometryDegrees?: number | null;
     geometryOffsetInches?: number | null;
-    /** Axial endplate configs (A first, then B). Missing → single. */
-    endplateConfigs?: ("single" | "double" | null | undefined)[];
+    /** Axial endplate configs (A first, then B). Missing → single. `"none"` at B
+     * means the module has no far endplate at all — an end of the line, a pocket,
+     * or a turnback (#184). */
+    endplateConfigs?: ("single" | "double" | "none" | null | undefined)[];
     /** Branch endplates (from the schematic doc, #170), positioned along the
      * mainline axis. */
     branches?: {

package/dist/index.js

@@ -532,7 +532,7 @@ function endplateWidthFor(widths, id) {
   return typeof w === "number" && w > 0 ? w : FREEMO_ENDPLATE_WIDTH_RECOMMENDED_INCHES;
 }
 function isLoopDoc(doc) {
-  return doc.loop === true || doc.endplates.length === 1;
+  return doc.loop === true;
 }
 var MAIN_TRACK_ID = "main";
 var MAIN2_TRACK_ID = "main2";
@@ -701,18 +701,20 @@ function stateToDoc(state, recordNumber) {
             ]
           ) : [
             { id: "A", label: "West", tracks: [{ trackId: MAIN_TRACK_ID, lane: 0, config: state.configA }] },
-            // Non-loop modules always have a real B ("none" never applies).
-            {
-              id: "B",
-              label: "East",
-              tracks: [
-                {
-                  trackId: MAIN_TRACK_ID,
-                  lane: 0,
-                  config: state.configB === "none" ? "single" : state.configB
-                }
-              ]
-            }
+            // ⚠️ `configB: "none"` means the module HAS NO FAR ENDPLATE, and
+            // that is not loop-only (#184). An *end of the line* or a *pocket*
+            // presents one conforming face and the track simply stops. The
+            // standard governs the ends a module offers for joining; it never
+            // required a module to offer two. This used to coerce "none" to
+            // "single" and emit a B regardless, so a single-ended module was
+            // impossible to author.
+            ...state.configB !== "none" ? [
+              {
+                id: "B",
+                label: "East",
+                tracks: [{ trackId: MAIN_TRACK_ID, lane: 0, config: state.configB }]
+              }
+            ] : []
           ],
           // Branch endplates C, D, … — junction connections at pos, off one side
           // (#170). A set can carry several (e.g. a second railroad through).
@@ -927,8 +929,14 @@ function docToState(doc, fallbackLength, moduleTracks = []) {
     loopReturn: loop && d.loopReturn === "main2" ? "main2" : "same",
     mainsSwapped: d.mainsSwapped === true,
     configA: configOf("A"),
-    // On a loop, a missing B means pure turnback; present = interchange loop.
-    configB: loop && !hasB ? "none" : configOf("B"),
+    // NO ENDPLATE B ⇒ "none", whatever kind of module this is. On a loop that
+    // reads as a pure turnback (a present B makes it an interchange); on an end
+    // of the line or a pocket it simply means the module has one face (#184).
+    // ⚠️ This used to be `loop && !hasB`, so "none" only survived a round trip on
+    // a loop — which passed its test yesterday ONLY because a single-endplate
+    // module was still being misclassified as one (#191). The absence of the
+    // plate is the fact; why it's absent doesn't change what to read.
+    configB: hasB ? configOf("B") : "none",
     branches: branchEps.map((ep) => ({
       label: ep.label ?? "Branch",
       pos: sc(ep.at.pos),
@@ -1982,7 +1990,7 @@ function deriveEndplatePoses(geo) {
       trackOffsets: offsetsFor(cfg(0), half)
     })
   );
-  const noB = geo.geometryType === "dead_end" || geo.loop === true;
+  const noB = geo.geometryType === "dead_end" || geo.loop === true || geo.endplateConfigs?.[1] === "none";
   const end = sectionedEndPose({ sections: geo.sections });
   if (!noB && end) {
     poses.push(