@willbooster/tree-sitter-c-sharp 1.0.4 → 1.0.6

package/README.md

@@ -76,9 +76,10 @@ parser.setLanguage(await Language.load(cSharp));
 
 The package also ships the node types in `src/node-types.json`.
 
-In Rust, depend on the [crate](https://crates.io/crates/willbooster-tree-sitter-c-sharp) and the
-[runtime](https://crates.io/crates/willbooster-tree-sitter), whose fixes keep incremental reparses consistent with
-fresh parses:
+In Rust, depend on the [crate](https://crates.io/crates/willbooster-tree-sitter-c-sharp) and on
+[willbooster-tree-sitter](https://crates.io/crates/willbooster-tree-sitter), the runtime this package is tested and
+fuzzed with, whose fixes keep incremental reparses consistent with fresh parses (the grammar also loads in the upstream
+`tree-sitter` crate 0.27, whose error recovery never ends on some malformed input):
 
 ```toml
 [dependencies]
@@ -122,7 +123,8 @@ cargo test
 `cargo test` also replays edits that `tree-sitter fuzz` found to break incremental parsing, with the
 willbooster-tree-sitter runtime that fixes them; `tree-sitter fuzz` itself runs the runtime built into tree-sitter-cli.
 
-CI also runs these tests on Linux arm64 and macOS, where the Rust binding compiles the parser natively, and fuzzes the parser with libFuzzer and sanitizers
+CI also runs these tests on Linux arm64 and macOS, where the Rust binding compiles the parser natively, and fuzzes the
+parser with libFuzzer and sanitizers on the willbooster-tree-sitter runtime locked in `Cargo.lock`
 (`.github/workflows/robustness.yml`).
 
 ### References

package/grammar.js

@@ -970,7 +970,7 @@ module.exports = grammar({
       ),
 
     // Uses '(' pattern ')' to create direct conflict with parenthesized_pattern
-    _parenthesized_pattern_with_designation: ($) => seq('(', $.pattern, ')', $._variable_designation),
+    _parenthesized_pattern_with_designation: ($) => seq('(', $.pattern, ')', $._simple_designation),
 
     constant_pattern: ($) =>
       choice(
@@ -1018,7 +1018,10 @@ module.exports = grammar({
 
     parenthesized_pattern: ($) => seq('(', $.pattern, ')'),
 
-    var_pattern: ($) => seq('var', $._variable_designation),
+    // `var x` parses as a declaration_pattern with an implicit_type. `var (x, y)` also reads as a positional pattern
+    // of type `var` or, after `is`, as an invocation of `o is var`; each of those carries the implicit_type's dynamic
+    // precedence of 1, so this needs more.
+    var_pattern: ($) => prec.dynamic(2, seq('var', $.parenthesized_variable_designation)),
 
     // No associativity: tree-sitter 0.27 resolves a precedence tie with a right-associative reduce as a shift, which
     // makes `case int when x:` and `x is A or nameof(y)` read `when` and `(y)` as a variable designation.
@@ -1033,7 +1036,7 @@ module.exports = grammar({
           '[',
           optional(seq(commaSep1(choice($.pattern, $.slice_pattern)), optional(','))),
           ']',
-          optional($._variable_designation)
+          optional($._simple_designation)
         )
       ),
 
@@ -1052,7 +1055,7 @@ module.exports = grammar({
               field('type', $._name),
               $.positional_pattern_clause,
               optional($.property_pattern_clause),
-              $._variable_designation
+              $._simple_designation
             )
           ),
           // name followed by positional pattern WITHOUT variable designation
@@ -1061,19 +1064,19 @@ module.exports = grammar({
             seq(field('type', $._name), $.positional_pattern_clause, optional($.property_pattern_clause))
           ),
           // positional pattern with variable designation (no type prefix)
-          prec.dynamic(1, seq($.positional_pattern_clause, $._variable_designation)),
+          prec.dynamic(1, seq($.positional_pattern_clause, $._simple_designation)),
           // positional pattern without variable designation (no type prefix)
           $.positional_pattern_clause,
           // other type followed by pattern clauses (type is required here to avoid ambiguity)
           seq(
             field('type', $.type),
             choice(seq($.positional_pattern_clause, optional($.property_pattern_clause)), $.property_pattern_clause),
-            optional($._variable_designation)
+            optional($._simple_designation)
           ),
           // no type, just pattern clauses (no variable designation to avoid conflict with above)
           seq(
             choice(seq($.positional_pattern_clause, $.property_pattern_clause), $.property_pattern_clause),
-            optional($._variable_designation)
+            optional($._simple_designation)
           )
         )
       ),
@@ -1095,10 +1098,13 @@ module.exports = grammar({
     or_pattern: ($) =>
       prec.left(PREC.OR, seq(field('left', $.pattern), field('operator', 'or'), field('right', $.pattern))),
 
-    declaration_pattern: ($) => seq(field('type', $.type), $._variable_designation),
+    declaration_pattern: ($) => seq(field('type', $.type), $._simple_designation),
 
-    _variable_designation: ($) =>
-      prec(1, choice($.discard, $.parenthesized_variable_designation, field('name', $.identifier))),
+    _variable_designation: ($) => choice($._simple_designation, $.parenthesized_variable_designation),
+
+    // C# admits a parenthesized designation in a pattern only after `var`; elsewhere `T (x)` and `nameof(x)` are
+    // positional patterns or invocations.
+    _simple_designation: ($) => prec(1, choice($.discard, field('name', $.identifier))),
 
     parenthesized_variable_designation: ($) => seq('(', commaSep($._variable_designation), ')'),
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@willbooster/tree-sitter-c-sharp",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "C# grammar for tree-sitter",
   "keywords": [
     "incremental",
@@ -46,7 +46,7 @@
     "@willbooster/oxfmt-config": "1.2.2",
     "@willbooster/oxlint-config": "1.4.8",
     "@willbooster/wb": "22.11.5",
-    "@willbooster/web-tree-sitter": "1.0.0",
+    "@willbooster/web-tree-sitter": "1.0.7",
     "conventional-changelog-conventionalcommits": "10.4.0",
     "lefthook": "2.1.14",
     "oxfmt": "0.70.0",

package/src/node-types.json

@@ -2137,10 +2137,6 @@
         {
           "type": "discard",
           "named": true
-        },
-        {
-          "type": "parenthesized_variable_designation",
-          "named": true
         }
       ]
     }
@@ -3735,10 +3731,6 @@
       "multiple": true,
       "required": false,
       "types": [
-        {
-          "type": "parenthesized_variable_designation",
-          "named": true
-        },
         {
           "type": "pattern",
           "named": true
@@ -5523,10 +5515,6 @@
       "multiple": true,
       "required": true,
       "types": [
-        {
-          "type": "parenthesized_variable_designation",
-          "named": true
-        },
         {
           "type": "pattern",
           "named": true
@@ -6390,26 +6378,11 @@
   {
     "type": "var_pattern",
     "named": true,
-    "fields": {
-      "name": {
-        "multiple": false,
-        "required": false,
-        "types": [
-          {
-            "type": "identifier",
-            "named": true
-          }
-        ]
-      }
-    },
+    "fields": {},
     "children": {
       "multiple": false,
-      "required": false,
+      "required": true,
       "types": [
-        {
-          "type": "discard",
-          "named": true
-        },
         {
           "type": "parenthesized_variable_designation",
           "named": true

package/tree-sitter.json

@@ -19,7 +19,7 @@
     }
   ],
   "metadata": {
-    "version": "1.0.4",
+    "version": "1.0.6",
     "license": "MIT",
     "description": "C# grammar for tree-sitter",
     "authors": [