@will-stone/eslint-config 5.0.2 → 6.0.0

package/_for_rule_checking.js

@@ -4,18 +4,20 @@
  */
 
 const tsRules = require('./rules/typescript')
+const jestRules = require('./rules/jest')
 
 module.exports = {
-  plugins: ['@typescript-eslint'],
+  plugins: ['@typescript-eslint', 'jest'],
   extends: [
     require.resolve('./javascript'),
     require.resolve('./react'),
     require.resolve('./node'),
-    require.resolve('./jest'),
     require.resolve('./prettier'),
   ],
   rules: {
     // Use the TS rules directly as eslint-find-rules cannot see `overrides`.
     ...tsRules,
+    // Use the TS rules directly as eslint-find-rules cannot see `overrides`.
+    ...jestRules,
   },
 }

package/jest.js

@@ -7,7 +7,10 @@ module.exports = {
 
   plugins: ['jest'],
 
-  extends: ['plugin:jest/recommended'],
-
-  rules: jestRules,
+  overrides: [
+    {
+      files: ['**/*.{test,spec}.{js,ts,jsx,tsx}'],
+      rules: jestRules,
+    },
+  ],
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@will-stone/eslint-config",
-  "version": "5.0.2",
+  "version": "6.0.0",
   "private": false,
   "description": "My ESLint config",
   "repository": {
@@ -9,7 +9,7 @@
   "license": "MIT",
   "author": "Will Stone",
   "scripts": {
-    "eslint-find-unused-rules": "eslint-find-rules --unused ./_for_rule_checking.js > ./unused-rules.txt",
+    "eslint-find-unused-rules": "npx eslint-find-rules --unused ./_for_rule_checking.js > ./unused-rules.txt",
     "eslint-print-rules": "eslint --no-eslintrc -c ./_for_rule_checking.js --print-config ./_for_rule_checking.js > rules.json"
   },
   "dependencies": {
@@ -17,22 +17,22 @@
     "eslint-config-prettier": "^8.3.0"
   },
   "devDependencies": {
-    "eslint-find-rules": "^3.6.1"
+    "eslint-find-rules": "^4.0.0"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.3.0",
-    "@typescript-eslint/parser": "^5.3.0",
-    "eslint": "^7.32.0",
-    "eslint-plugin-import": "^2.25.2",
-    "eslint-plugin-jest": "^25.2.2",
-    "eslint-plugin-jsx-a11y": "^6.4.1",
+    "@typescript-eslint/eslint-plugin": "^5.4.0",
+    "@typescript-eslint/parser": "^5.4.0",
+    "eslint": "^8.2.0",
+    "eslint-plugin-import": "^2.25.3",
+    "eslint-plugin-jest": "^25.2.4",
+    "eslint-plugin-jsx-a11y": "^6.5.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^4.0.0",
-    "eslint-plugin-react": "^7.26.1",
-    "eslint-plugin-react-hooks": "^4.2.0",
+    "eslint-plugin-react": "^7.27.1",
+    "eslint-plugin-react-hooks": "^4.3.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
     "eslint-plugin-switch-case": "^1.1.2",
-    "eslint-plugin-unicorn": "^38.0.0",
+    "eslint-plugin-unicorn": "^38.0.1",
     "typescript": "4.x"
   },
   "peerDependenciesMeta": {

package/rules/built-in.js

@@ -584,6 +584,8 @@ module.exports = {
   // likely an error due to incomplete refactoring.
   'no-unused-labels': 'warn',
 
+  'no-unused-private-class-members': 'error',
+
   // Variables must be used unless name starts with "ignored"
   'no-unused-vars': ['error', { varsIgnorePattern: '[iI]gnored' }],
 
@@ -658,6 +660,7 @@ module.exports = {
   'padding-line-between-statements': [
     'warn',
     { blankLine: 'always', prev: 'multiline-block-like', next: '*' },
+    { blankLine: 'always', prev: '*', next: 'multiline-block-like' },
   ],
 
   // Can cause issues when Prettier is enabled

package/rules/jest.js

@@ -4,29 +4,61 @@ module.exports = {
   // describe -> it
   'jest/consistent-test-it': ['error', { fn: 'test', withinDescribe: 'it' }],
 
+  // Enforce assertion to be made in a test body
+  'jest/expect-expect': 'error',
+
   'jest/max-nested-describe': 'off',
 
   // Consistent expect methods
   'jest/no-alias-methods': 'error',
 
+  'jest/no-commented-out-tests': 'error',
+
   // Prevent calling expect conditionally
   'jest/no-conditional-expect': 'error',
 
+  'jest/no-deprecated-functions': 'warn',
+
+  'jest/no-disabled-tests': 'warn',
+
+  // Avoid using a callback in asynchronous tests and hooks
+  'jest/no-done-callback': 'error',
+
   // Do not allow multiple beforeEach, for example
   'jest/no-duplicate-hooks': 'error',
 
+  // Disallow using exports in files containing tests
+  'jest/no-export': 'error',
+
+  'jest/no-focused-tests': 'error',
+
   'jest/no-hooks': 'off',
 
+  'jest/no-identical-title': 'error',
+
   // Conditional logic in tests is usually an indication that a test is attempting to cover too much
   'jest/no-if': 'error',
 
+  // Disallow string interpolation inside snapshots
+  'jest/no-interpolation-in-snapshots': 'error',
+
+  'jest/no-jasmine-globals': 'warn',
+
+  'jest/no-jest-import': 'error',
+
   'jest/no-large-snapshots': 'off',
 
+  // Disallow manually importing from __mocks__
+  'jest/no-mocks-import': 'error',
+
   'jest/no-restricted-matchers': 'off',
 
   // No standalone expect in a describe block
   'jest/no-standalone-expect': 'error',
 
+  // Use .only and .skip over f and x
+  'jest/no-test-prefixes': 'warn',
+
   // Tests shouldn't return anything
   'jest/no-test-return-statement': 'error',
 
@@ -69,6 +101,12 @@ module.exports = {
 
   'jest/require-top-level-describe': 'off',
 
+  'jest/valid-describe-callback': 'error',
+
+  'jest/valid-expect': 'error',
+
+  'jest/valid-expect-in-promise': 'error',
+
   // Titles are...
   // - not empty
   // - is a string

package/rules/typescript.js

@@ -37,7 +37,7 @@ module.exports = {
   // ts transpiles let/const to var, so no need for vars any more
   'no-var': 'error',
   // ts provides better types with const
-  'prefer-const': 'error',
+  'prefer-const': 'warn',
   // ts provides better types with rest args over arguments
   'prefer-rest-params': 'error',
   // ts transpiles spread to apply, so no need for manual apply
@@ -77,6 +77,7 @@ module.exports = {
    * These are for type checking which I don't use eslint for
    */
   '@typescript-eslint/await-thenable': 'off',
+  '@typescript-eslint/consistent-type-exports': 'off',
   '@typescript-eslint/dot-notation': 'off',
   '@typescript-eslint/naming-convention': 'off',
   '@typescript-eslint/no-base-to-string': 'off',