@will-stone/eslint-config 3.0.4 → 3.1.1

package/node.js

@@ -1,6 +1,5 @@
 const nodeRules = require('./rules/node')
 
-
 module.exports = {
   env: {
     node: true,
@@ -8,5 +7,5 @@ module.exports = {
 
   plugins: ['node'],
 
-  rules: nodeRules
+  rules: nodeRules,
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@will-stone/eslint-config",
-  "version": "3.0.4",
+  "version": "3.1.1",
   "private": false,
   "description": "My ESLint config",
   "repository": {
@@ -25,11 +25,11 @@
     "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
     "eslint-plugin-switch-case": "^1.1.2",
-    "eslint-plugin-unicorn": "^35.0.0"
+    "eslint-plugin-unicorn": "^36.0.0"
   },
   "peerDependencies": {
     "eslint": "^7.32.0",
-    "typescript": "4.x"
+    "typescript": "^4"
   },
   "peerDependenciesMeta": {
     "typescript": {

package/rules/unicorn.js

@@ -39,8 +39,9 @@ module.exports = {
   // https://github.com/sindresorhus/eslint-plugin-unicorn/issues/203
   'unicorn/filename-case': 'off',
 
-  // Enforces importing index file with . instead of ./, ./index or ./index.js
-  'unicorn/import-index': 'warn',
+  // Enforces requiring index file with . instead of ./, ./index or ./index.js
+  // Turned off for imports where this can mess with ESM.
+  'unicorn/import-index': ['warn', { ignoreImports: true }],
 
   // Not sure if this is useful yet
   'unicorn/import-style': 'off',
@@ -81,6 +82,10 @@ module.exports = {
   // Require Array.isArray() instead of instanceof Array
   'unicorn/no-instanceof-array': 'warn',
 
+  // The removeEventListener function must be called with a reference to the same
+  // function that was passed to addEventListener.
+  'unicorn/no-invalid-remove-event-listener': 'error',
+
   // Disallow identifiers (var names) starting with new.
   // Do not check properties and allow "class" so that "className" is allowed.
   'unicorn/no-keyword-prefix': [
@@ -115,6 +120,10 @@ module.exports = {
   // Disallow assigning this to a variable
   'unicorn/no-this-assignment': 'error',
 
+  // TS doesn't allow falsy values to be spread so fallbacks are required
+  // https://github.com/microsoft/TypeScript/issues/37491
+  'unicorn/no-useless-fallback-in-spread': 'off',
+
   // Disallow useless array length check
   'unicorn/no-useless-length-check': 'warn',
 
@@ -253,7 +262,7 @@ module.exports = {
   'unicorn/prefer-switch': 'off',
 
   // Prefer ternary expressions over simple if-else statements
-  'unicorn/prefer-ternary': 'warn',
+  'unicorn/prefer-ternary': ['warn', 'only-single-line'],
 
   // Prefer top-level await over top-level promises and async function calls
   'unicorn/prefer-top-level-await': 'error',