@will-stone/eslint-config 13.0.0 → 15.0.0

package/README.md

@@ -10,6 +10,19 @@ My personal [ESLint](https://eslint.org/) config.
 npm i -D eslint @will-stone/eslint-config
 ```
 
+### Optional Peer Dependencies
+
+If you are using any of the following packages, you will also need to install
+the corresponding plugin.
+
+| Package       | Plugin                                          |
+| ------------- | ----------------------------------------------- |
+| `astro`       | `astro-eslint-parser eslint-plugin-astro`       |
+| `jest`        | `eslint-plugin-jest`                            |
+| `react`       | `eslint-plugin-react eslint-plugin-react-hooks` |
+| `tailwindcss` | `eslint-plugin-tailwindcss`                     |
+| `vitest`      | `@vitest/eslint-plugin`                         |
+
 ### Create config file
 
 ```js
@@ -32,20 +45,6 @@ For example:
 }
 ```
 
-### VS Code support (auto fix)
-
-Install
-[VS Code ESLint extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint).
-
-Add the following settings to your `.vscode/settings.json`:
-
-```jsonc
-{
-  // Enable the ESlint flat config support
-  "eslint.experimental.useFlatConfig": true,
-}
-```
-
 ### Lint Staged
 
 If you would like to apply lint and auto-fix before every commit, you can add

package/dist/index.js

@@ -1,22 +1,35 @@
 // src/configs/astro.ts
 import parserTypescript from "@typescript-eslint/parser";
-import parserAstro from "astro-eslint-parser";
-import pluginAstro from "eslint-plugin-astro";
+
+// src/utils/interop-default.ts
+async function interopDefault(m) {
+  const resolved = await m;
+  return resolved.default || resolved;
+}
+
+// src/configs/astro.ts
 async function astro(_options) {
+  const [pluginAstro, parserAstro] = await Promise.all([
+    interopDefault(import("eslint-plugin-astro")),
+    interopDefault(import("astro-eslint-parser"))
+  ]);
   return [
     {
       files: ["**/*.astro"],
       languageOptions: {
+        globals: pluginAstro.environments.astro.globals,
         parser: parserAstro,
         parserOptions: {
           extraFileExtensions: [".astro"],
           parser: parserTypescript
-        }
+        },
+        sourceType: "module"
       },
       name: "will-stone/astro",
       plugins: {
         astro: pluginAstro
       },
+      processor: "astro/client-side-ts",
       rules: {
         // Astro passes Components to the view which this rule doesn't like.
         "no-useless-assignment": "off",
@@ -392,14 +405,12 @@ async function ignores() {
 
 // src/configs/imports.ts
 import * as pluginImport from "eslint-plugin-import-x";
-import pluginSimpleImport from "eslint-plugin-simple-import-sort";
 async function imports() {
   return [
     {
       name: "will-stone/imports",
       plugins: {
-        "import-x": pluginImport,
-        "simple-import-sort": pluginSimpleImport
+        "import-x": pluginImport
       },
       rules: {
         "import-x/consistent-type-specifier-style": [
@@ -413,8 +424,6 @@ async function imports() {
         "import-x/no-empty-named-blocks": "warn",
         "import-x/no-rename-default": "off",
         "import-x/prefer-default-export": "off",
-        "simple-import-sort/exports": "warn",
-        "simple-import-sort/imports": "warn",
         // The rest of the rules, off until required
         "import-x/default": "off",
         "import-x/dynamic-import-chunkname": "off",
@@ -451,7 +460,16 @@ async function imports() {
         "import-x/no-unused-modules": "off",
         "import-x/no-useless-path-segments": "off",
         "import-x/no-webpack-loader-syntax": "off",
-        "import-x/order": "off",
+        "import-x/order": [
+          "warn",
+          {
+            alphabetize: {
+              caseInsensitive: true,
+              order: "asc"
+            },
+            "newlines-between": "always"
+          }
+        ],
         "import-x/unambiguous": "off"
       }
     }
@@ -459,9 +477,9 @@ async function imports() {
 }
 
 // src/configs/jest.ts
-import pluginJest from "eslint-plugin-jest";
 import globals2 from "globals";
 async function jest(_options) {
+  const pluginJest = await interopDefault(import("eslint-plugin-jest"));
   return [
     {
       files: ["**/__mocks__/**/*", "**/*.{spec,test}.{js,cjs,mjs,jsx,ts,tsx}"],
@@ -612,12 +630,14 @@ async function node() {
 }
 
 // src/configs/react.ts
-import { fixupPluginRules } from "@eslint/compat";
-import pluginJsxA11y from "eslint-plugin-jsx-a11y";
-import pluginReact from "eslint-plugin-react";
-import pluginReactHooks from "eslint-plugin-react-hooks";
 import globals4 from "globals";
 async function react(_options) {
+  const [pluginJsxA11y, pluginReact, pluginReactHooks] = await Promise.all([
+    // @ts-expect-error -- no types
+    interopDefault(import("eslint-plugin-jsx-a11y")),
+    interopDefault(import("eslint-plugin-react")),
+    interopDefault(import("eslint-plugin-react-hooks"))
+  ]);
   return [
     {
       files: ["**/*.{jsx,tsx}"],
@@ -632,9 +652,8 @@ async function react(_options) {
       name: "will-stone/react",
       plugins: {
         "jsx-a11y": pluginJsxA11y,
-        // @ts-expect-error -- no idea why this is tripping.
         react: pluginReact,
-        "react-hooks": fixupPluginRules(pluginReactHooks)
+        "react-hooks": pluginReactHooks
       },
       rules: {
         "jsx-a11y/alt-text": "error",
@@ -952,10 +971,12 @@ async function tailwind(rawOptions) {
 }
 
 // src/configs/typescript.ts
-import pluginTypescript from "@typescript-eslint/eslint-plugin";
-import * as parserTypescript2 from "@typescript-eslint/parser";
 async function typescript(rawOptions) {
   const options = !rawOptions || typeof rawOptions === "boolean" ? {} : rawOptions;
+  const [pluginTypescript, parserTypescript2] = await Promise.all([
+    interopDefault(import("@typescript-eslint/eslint-plugin")),
+    interopDefault(import("@typescript-eslint/parser"))
+  ]);
   return [
     {
       files: ["**/*.{ts,tsx,astro}"],
@@ -1061,6 +1082,7 @@ async function typescript(rawOptions) {
           "@typescript-eslint/no-implied-eval": "off",
           "@typescript-eslint/no-meaningless-void-operator": "off",
           "@typescript-eslint/no-misused-promises": "off",
+          "@typescript-eslint/no-misused-spread": "off",
           "@typescript-eslint/no-mixed-enums": "off",
           "@typescript-eslint/no-redundant-type-constituents": "off",
           "@typescript-eslint/no-unnecessary-boolean-literal-compare": "off",
@@ -1206,6 +1228,8 @@ async function unicorn() {
         "no-nested-ternary": "off",
         "unicorn/better-regex": "warn",
         "unicorn/catch-error-name": "error",
+        "unicorn/consistent-assert": "warn",
+        "unicorn/consistent-date-clone": "warn",
         "unicorn/consistent-destructuring": "warn",
         "unicorn/consistent-empty-array-spread": "warn",
         "unicorn/consistent-existence-index-check": "warn",
@@ -1225,6 +1249,7 @@ async function unicorn() {
         "unicorn/import-style": "off",
         "unicorn/new-for-builtins": "warn",
         "unicorn/no-abusive-eslint-disable": "error",
+        "unicorn/no-accessor-recursion": "error",
         "unicorn/no-anonymous-default-export": "error",
         "unicorn/no-array-callback-reference": "off",
         "unicorn/no-array-for-each": "warn",
@@ -1241,6 +1266,7 @@ async function unicorn() {
         "unicorn/no-for-loop": "warn",
         "unicorn/no-hex-escape": "warn",
         "unicorn/no-instanceof-array": "warn",
+        "unicorn/no-instanceof-builtins": "warn",
         "unicorn/no-invalid-fetch-options": "error",
         "unicorn/no-invalid-remove-event-listener": "error",
         "unicorn/no-keyword-prefix": [
@@ -1255,6 +1281,7 @@ async function unicorn() {
         "unicorn/no-length-as-slice-end": "warn",
         "unicorn/no-lonely-if": "warn",
         "unicorn/no-magic-array-flat-depth": "error",
+        "unicorn/no-named-default": "warn",
         "unicorn/no-negated-condition": "warn",
         "unicorn/no-negation-in-equality-check": "error",
         "unicorn/no-nested-ternary": "off",
@@ -1357,14 +1384,13 @@ async function unicorn() {
 }
 
 // src/configs/vitest.ts
-import { fixupPluginRules as fixupPluginRules2 } from "@eslint/compat";
-import pluginVitest from "eslint-plugin-vitest";
 async function vitest(_options) {
+  const pluginVitest = await interopDefault(import("@vitest/eslint-plugin"));
   return [
     {
       files: ["**/*.{spec,test}.{js,cjs,mjs,jsx,ts,tsx}"],
       name: "will-stone/vitest",
-      plugins: { vitest: fixupPluginRules2(pluginVitest) },
+      plugins: { vitest: pluginVitest },
       rules: {
         "vitest/consistent-test-filename": "warn",
         "vitest/consistent-test-it": "warn",
@@ -1414,17 +1440,29 @@ async function vitest(_options) {
         "vitest/no-import-node-test": "warn",
         // Every test must have an expect, this is covered by expect-expect rule.
         "vitest/prefer-expect-assertions": "off",
+        "vitest/prefer-strict-boolean-matchers": "warn",
         // These two could be dangerous as you may actually want to ensure that
         // something is exactly `false` or `true`, and not something that
         // equates to that if run through Boolean().
         "vitest/prefer-to-be-falsy": "off",
         "vitest/prefer-to-be-truthy": "off",
         "vitest/require-local-test-context-for-concurrent-snapshots": "error",
+        "vitest/require-mock-type-parameters": "warn",
         // No need to nest everything in useless describe blocks:
         "vitest/require-top-level-describe": "off",
         "vitest/valid-describe-callback": "error",
         "vitest/valid-expect": "error",
-        "vitest/valid-title": "warn"
+        "vitest/valid-expect-in-promise": "error",
+        "vitest/valid-title": "warn",
+        "vitest/prefer-vi-mocked": "warn",
+        "vitest/padding-around-after-all-blocks": "warn",
+        "vitest/padding-around-after-each-blocks": "warn",
+        "vitest/padding-around-all": "warn",
+        "vitest/padding-around-before-all-blocks": "warn",
+        "vitest/padding-around-before-each-blocks": "warn",
+        "vitest/padding-around-describe-blocks": "warn",
+        "vitest/padding-around-expect-groups": "warn",
+        "vitest/padding-around-test-blocks": "warn"
       }
     }
   ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@will-stone/eslint-config",
-  "version": "13.0.0",
+  "version": "15.0.0",
   "description": "Will Stone's ESLint config",
   "keywords": [
     "eslint-config"
@@ -18,8 +18,9 @@
     "dist"
   ],
   "scripts": {
-    "build": "tsup src/index.ts --format esm --clean --dts",
-    "dev": "tsup src/index.ts --format esm --watch & config-inspector --config ./eslint-config-for-inspector.js",
+    "build": "tsup src/index.ts --format esm --clean --dts --shims",
+    "predev": "npm run build",
+    "dev": "tsup src/index.ts --format esm --shims --watch & config-inspector --config ./eslint-config-for-inspector.js",
     "lint": "npm run stub && eslint .",
     "prepare": "simple-git-hooks",
     "prepublishOnly": "npm run build",
@@ -41,49 +42,74 @@
   },
   "prettier": "@will-stone/prettier-config",
   "dependencies": {
-    "@eslint/compat": "^1.2.3",
-    "@typescript-eslint/eslint-plugin": "^8.16.0",
-    "@typescript-eslint/parser": "^8.16.0",
-    "astro-eslint-parser": "^1.1.0",
+    "@typescript-eslint/eslint-plugin": "^8.27.0",
+    "@typescript-eslint/parser": "^8.27.0",
     "confusing-browser-globals": "^1.0.11",
-    "eslint-config-flat-gitignore": "^0.3.0",
-    "eslint-plugin-astro": "^1.3.1",
-    "eslint-plugin-import-x": "^4.4.3",
-    "eslint-plugin-jest": "^28.9.0",
+    "eslint-config-flat-gitignore": "^2.1.0",
+    "eslint-plugin-import-x": "^4.9.1",
     "eslint-plugin-jsx-a11y": "^6.10.2",
-    "eslint-plugin-n": "^17.14.0",
-    "eslint-plugin-react": "^7.37.2",
-    "eslint-plugin-react-hooks": "^5.0.0",
-    "eslint-plugin-simple-import-sort": "^12.1.1",
-    "eslint-plugin-tailwindcss": "^3.17.5",
-    "eslint-plugin-unicorn": "^56.0.1",
-    "eslint-plugin-vitest": "^0.5.4",
-    "globals": "^15.12.0",
-    "globby": "^14.0.2",
-    "type-fest": "^4.28.1"
+    "eslint-plugin-n": "^17.16.2",
+    "eslint-plugin-unicorn": "^58.0.0",
+    "globals": "^16.0.0",
+    "globby": "^14.1.0",
+    "type-fest": "^4.38.0"
   },
   "devDependencies": {
-    "@commits-with-character/conventional-changelog-preset": "^1.0.0",
-    "@eslint/config-inspector": "^0.5.6",
-    "@release-it/conventional-changelog": "^9.0.3",
+    "@commits-with-character/conventional-changelog-preset": "^2.0.0",
+    "@eslint/config-inspector": "^1.0.2",
+    "@release-it/conventional-changelog": "^10.0.0",
     "@types/confusing-browser-globals": "^1.0.3",
     "@types/eslint": "^9.6.1",
-    "@types/node": "^22.10.0",
-    "@typescript-eslint/utils": "^8.16.0",
-    "@will-stone/prettier-config": "^8.0.1",
-    "lint-staged": "^15.2.10",
-    "memfs": "^4.14.0",
-    "prettier": "^3.4.1",
-    "release-it": "^17.10.0",
-    "simple-git-hooks": "^2.11.1",
-    "tsup": "^8.3.5",
-    "typescript": "^5.7.2",
-    "vitest": "^2.1.6"
+    "@types/node": "^22.13.13",
+    "@typescript-eslint/utils": "^8.27.0",
+    "@vitest/eslint-plugin": "^1.1.38",
+    "@will-stone/prettier-config": "^9.0.1",
+    "astro-eslint-parser": "^1.2.2",
+    "eslint-plugin-astro": "^1.3.1",
+    "eslint-plugin-jest": "^28.11.0",
+    "eslint-plugin-react": "^7.37.4",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-tailwindcss": "^3.18.0",
+    "lint-staged": "^15.5.0",
+    "memfs": "^4.17.0",
+    "prettier": "^3.5.3",
+    "release-it": "^18.1.2",
+    "simple-git-hooks": "^2.12.1",
+    "tsup": "^8.4.0",
+    "typescript": "^5.8.2",
+    "vitest": "^3.0.9"
   },
   "peerDependencies": {
-    "eslint": ">=9.15.0"
+    "@vitest/eslint-plugin": "^1.1.38",
+    "astro-eslint-parser": "^1.2.2",
+    "eslint": ">=9.23.0",
+    "eslint-plugin-astro": "^1.3.1",
+    "eslint-plugin-jest": "^28.11.0",
+    "eslint-plugin-react": "^7.37.4",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-tailwindcss": "^3.18.0"
   },
-  "overrides": {
-    "eslint": ">=9.15.0"
+  "peerDependenciesMeta": {
+    "@vitest/eslint-plugin": {
+      "optional": true
+    },
+    "astro-eslint-parser": {
+      "optional": true
+    },
+    "eslint-plugin-astro": {
+      "optional": true
+    },
+    "eslint-plugin-jest": {
+      "optional": true
+    },
+    "eslint-plugin-react": {
+      "optional": true
+    },
+    "eslint-plugin-react-hooks": {
+      "optional": true
+    },
+    "eslint-plugin-tailwindcss": {
+      "optional": true
+    }
   }
 }