@will-stone/eslint-config 0.6.0 → 0.7.0

package/dist/index.cjs

@@ -179,9 +179,7 @@ function base() {
         "camelcase": "error",
         // Write comments however you like
         "capitalized-comments": "off",
-        // If a class method does not use this,
-        // it can sometimes be made into a static function
-        "class-methods-use-this": "error",
+        "class-methods-use-this": "off",
         // Measures the number of linearly independent paths through a program's
         // source code. Rubbish. Use your own judgement on complexity.
         "complexity": "off",
@@ -478,6 +476,7 @@ function base() {
         "no-nonoctal-decimal-escape": "error",
         // This rule disallows calling the Math, JSON, Reflect and Atomics objects as functions.
         "no-obj-calls": "error",
+        "no-object-constructor": "error",
         // the leading zero which identifies an octal literal has been a source of
         // confusion and error in JavaScript code, ECMAScript 5 deprecates the use
         // of octal numeric literals.
@@ -774,13 +773,13 @@ function ignores() {
 }
 
 // src/configs/imports.ts
-var import_eslint_plugin_i = __toESM(require("eslint-plugin-i"), 1);
+var pluginImport = __toESM(require("eslint-plugin-i"), 1);
 var import_eslint_plugin_simple_import_sort = __toESM(require("eslint-plugin-simple-import-sort"), 1);
 function imports() {
   return [
     {
       plugins: {
-        "import": import_eslint_plugin_i.default,
+        "import": pluginImport,
         "simple-import-sort": import_eslint_plugin_simple_import_sort.default
       },
       rules: {
@@ -1246,26 +1245,9 @@ function react() {
         "react/jsx-props-no-multi-spaces": "off",
         "react/jsx-tag-spacing": "off",
         "react/jsx-wrap-multilines": "off",
-        // It is common to use these lifecycle methods without using "this".
-        "class-methods-use-this": [
-          "error",
-          {
-            exceptMethods: [
-              "render",
-              "getInitialState",
-              "getDefaultProps",
-              "getChildContext",
-              "componentWillMount",
-              "componentDidMount",
-              "componentWillReceiveProps",
-              "shouldComponentUpdate",
-              "componentWillUpdate",
-              "componentDidUpdate",
-              "componentWillUnmount",
-              "componentDidCatch"
-            ]
-          }
-        ],
+        /**
+         * React
+         */
         "react/boolean-prop-naming": "error",
         "react/button-has-type": "error",
         "react/default-props-match-prop-types": "error",
@@ -1381,6 +1363,9 @@ function react() {
         "react/static-property-placement": "error",
         "react/style-prop-object": "error",
         "react/void-dom-elements-no-children": "error",
+        /**
+         * Hooks
+         */
         // Checks effect dependencies
         "react-hooks/exhaustive-deps": "warn",
         // Checks rules of Hooks
@@ -1576,6 +1561,7 @@ function typescript() {
         /**
          * Superseded by TS rules below
          */
+        "class-methods-use-this": "off",
         "default-param-last": "off",
         "lines-between-class-members": "off",
         "no-duplicate-imports": "off",
@@ -1599,6 +1585,7 @@ function typescript() {
         "@typescript-eslint/ban-tslint-comment": "warn",
         // Ensures that literals on classes are exposed in a consistent style
         "@typescript-eslint/class-literal-property-style": "warn",
+        "@typescript-eslint/class-methods-use-this": "off",
         // https://typescript-eslint.io/rules/consistent-generic-constructors/
         "@typescript-eslint/consistent-generic-constructors": "warn",
         // Enforce the use of the record type

package/dist/index.js

@@ -143,9 +143,7 @@ function base() {
         "camelcase": "error",
         // Write comments however you like
         "capitalized-comments": "off",
-        // If a class method does not use this,
-        // it can sometimes be made into a static function
-        "class-methods-use-this": "error",
+        "class-methods-use-this": "off",
         // Measures the number of linearly independent paths through a program's
         // source code. Rubbish. Use your own judgement on complexity.
         "complexity": "off",
@@ -442,6 +440,7 @@ function base() {
         "no-nonoctal-decimal-escape": "error",
         // This rule disallows calling the Math, JSON, Reflect and Atomics objects as functions.
         "no-obj-calls": "error",
+        "no-object-constructor": "error",
         // the leading zero which identifies an octal literal has been a source of
         // confusion and error in JavaScript code, ECMAScript 5 deprecates the use
         // of octal numeric literals.
@@ -738,7 +737,7 @@ function ignores() {
 }
 
 // src/configs/imports.ts
-import pluginImport from "eslint-plugin-i";
+import * as pluginImport from "eslint-plugin-i";
 import pluginSimpleImport from "eslint-plugin-simple-import-sort";
 function imports() {
   return [
@@ -1210,26 +1209,9 @@ function react() {
         "react/jsx-props-no-multi-spaces": "off",
         "react/jsx-tag-spacing": "off",
         "react/jsx-wrap-multilines": "off",
-        // It is common to use these lifecycle methods without using "this".
-        "class-methods-use-this": [
-          "error",
-          {
-            exceptMethods: [
-              "render",
-              "getInitialState",
-              "getDefaultProps",
-              "getChildContext",
-              "componentWillMount",
-              "componentDidMount",
-              "componentWillReceiveProps",
-              "shouldComponentUpdate",
-              "componentWillUpdate",
-              "componentDidUpdate",
-              "componentWillUnmount",
-              "componentDidCatch"
-            ]
-          }
-        ],
+        /**
+         * React
+         */
         "react/boolean-prop-naming": "error",
         "react/button-has-type": "error",
         "react/default-props-match-prop-types": "error",
@@ -1345,6 +1327,9 @@ function react() {
         "react/static-property-placement": "error",
         "react/style-prop-object": "error",
         "react/void-dom-elements-no-children": "error",
+        /**
+         * Hooks
+         */
         // Checks effect dependencies
         "react-hooks/exhaustive-deps": "warn",
         // Checks rules of Hooks
@@ -1540,6 +1525,7 @@ function typescript() {
         /**
          * Superseded by TS rules below
          */
+        "class-methods-use-this": "off",
         "default-param-last": "off",
         "lines-between-class-members": "off",
         "no-duplicate-imports": "off",
@@ -1563,6 +1549,7 @@ function typescript() {
         "@typescript-eslint/ban-tslint-comment": "warn",
         // Ensures that literals on classes are exposed in a consistent style
         "@typescript-eslint/class-literal-property-style": "warn",
+        "@typescript-eslint/class-methods-use-this": "off",
         // https://typescript-eslint.io/rules/consistent-generic-constructors/
         "@typescript-eslint/consistent-generic-constructors": "warn",
         // Enforce the use of the record type

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@will-stone/eslint-config",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "description": "Will Stone's ESLint config",
   "keywords": [
     "eslint-config"
@@ -72,7 +72,7 @@
     "@types/node": "^20.8.2",
     "@will-stone/prettier-config": "^7.0.1",
     "eslint": "^8.50.0",
-    "eslint-flat-config-viewer": "^0.0.8",
+    "eslint-flat-config-viewer": "^0.0.9",
     "husky": "^8.0.3",
     "lint-staged": "^14.0.1",
     "prettier": "^3.0.3",