@wildwinter/expr-editor 0.8.0 → 0.10.0

package/dist/index.d.cts

@@ -214,6 +214,10 @@ interface EditCtx {
     apply(next: ExprNode | null): void;
     /** Open a popover anchored to `anchor`; `render(close)` builds the content. */
     openPopover(anchor: HTMLElement, render: (close: () => void) => Node): void;
+    /** Opener for the property right-click menu; falls back to openPopover. The
+     *  read-only preview sets this (a real popover) while leaving openPopover a
+     *  no-op, so property pills get their menu but left-click editing stays inert. */
+    openMenu?(anchor: HTMLElement, render: (close: () => void) => Node): void;
     /** Host-provided picker for a flow-node reference arg (e.g. `seen(...)` / `visits(...)`). When set,
      *  the node-ref arg renders as a pill that opens this instead of a free-text field; `onPick` receives
      *  the chosen node id. Absent in dialects / hosts that have no node catalogue. */
@@ -242,6 +246,11 @@ interface EditCtx {
         label: string;
         run: () => void;
     }>;
+    /** Read-only presentation hint: render more compactly than the editable tree.
+     *  Set by the preview (never the interactive editor). Currently collapses a
+     *  flag-delta call (e.g. `check_flags(@p, +a, -b)`) to `@p: +a -b`, dropping
+     *  the function name and parentheses. */
+    compact?: boolean;
 }
 
 interface ExpressionEditorOptions {
@@ -383,6 +392,18 @@ interface PreviewOptions {
     scopeOrder?: string[];
     /** Resolve a node id to a readable label for seen()/visits() node pills. */
     nodeLabel?: (id: string) => string;
+    /** Host actions for a property pill (e.g. "Go to definition"). When set, the
+     *  preview becomes right-click interactive on property pills (left-click still
+     *  falls through to the host); otherwise the preview is fully non-interactive. */
+    propertyActions?(ref: {
+        scope: string;
+        name: string;
+    }): Array<{
+        label: string;
+        run: () => void;
+    }>;
+    /** Where the property menu mounts (default document.body). */
+    popoverContainer?: HTMLElement;
 }
 /** Read-only pill strip for a condition (name-form). Empty/unparseable is the caller's concern; a
  *  non-empty unparseable string falls back to its raw text. */

package/dist/index.d.ts

@@ -214,6 +214,10 @@ interface EditCtx {
     apply(next: ExprNode | null): void;
     /** Open a popover anchored to `anchor`; `render(close)` builds the content. */
     openPopover(anchor: HTMLElement, render: (close: () => void) => Node): void;
+    /** Opener for the property right-click menu; falls back to openPopover. The
+     *  read-only preview sets this (a real popover) while leaving openPopover a
+     *  no-op, so property pills get their menu but left-click editing stays inert. */
+    openMenu?(anchor: HTMLElement, render: (close: () => void) => Node): void;
     /** Host-provided picker for a flow-node reference arg (e.g. `seen(...)` / `visits(...)`). When set,
      *  the node-ref arg renders as a pill that opens this instead of a free-text field; `onPick` receives
      *  the chosen node id. Absent in dialects / hosts that have no node catalogue. */
@@ -242,6 +246,11 @@ interface EditCtx {
         label: string;
         run: () => void;
     }>;
+    /** Read-only presentation hint: render more compactly than the editable tree.
+     *  Set by the preview (never the interactive editor). Currently collapses a
+     *  flag-delta call (e.g. `check_flags(@p, +a, -b)`) to `@p: +a -b`, dropping
+     *  the function name and parentheses. */
+    compact?: boolean;
 }
 
 interface ExpressionEditorOptions {
@@ -383,6 +392,18 @@ interface PreviewOptions {
     scopeOrder?: string[];
     /** Resolve a node id to a readable label for seen()/visits() node pills. */
     nodeLabel?: (id: string) => string;
+    /** Host actions for a property pill (e.g. "Go to definition"). When set, the
+     *  preview becomes right-click interactive on property pills (left-click still
+     *  falls through to the host); otherwise the preview is fully non-interactive. */
+    propertyActions?(ref: {
+        scope: string;
+        name: string;
+    }): Array<{
+        label: string;
+        run: () => void;
+    }>;
+    /** Where the property menu mounts (default document.body). */
+    popoverContainer?: HTMLElement;
 }
 /** Read-only pill strip for a condition (name-form). Empty/unparseable is the caller's concern; a
  *  non-empty unparseable string falls back to its raw text. */

package/dist/index.js

@@ -441,6 +441,13 @@ function renderNode(node, path, ctx, parentOp, side) {
     case "flagdelta":
       return pill(node.sign === "+" ? "flagpos" : "flagneg", `${node.sign}${node.name || "flag"}`, (b) => flagEditor(ctx, path, node, b), { issue, path });
     case "call": {
+      if (ctx.compact && ctx.dialect.functions[node.name]?.flagDeltaArgs && node.args.length >= 2 && node.args[0].kind === "scopedvar" && node.args.slice(1).every((a) => a.kind === "flagdelta")) {
+        const row2 = el("span", "exed-call exed-call-flags");
+        row2.append(renderNode(node.args[0], [...path, "args", 0], ctx));
+        row2.append(el("span", "exed-flagsep", [":"]));
+        for (let i = 1; i < node.args.length; i++) row2.append(renderNode(node.args[i], [...path, "args", i], ctx));
+        return row2;
+      }
       const row = el("span", "exed-call");
       row.append(pill("func", node.name, (b) => callEditor(ctx, path, node, b), { issue }));
       row.append(el("span", "exed-paren", ["("]));
@@ -490,9 +497,10 @@ function attachPropertyMenu(ctx, node, pillEl) {
   if (!ctx.propertyActions) return;
   const actions = ctx.propertyActions({ scope: node.scope, name: node.name });
   if (!actions.length) return;
+  const open = ctx.openMenu ?? ctx.openPopover;
   pillEl.addEventListener("contextmenu", (e) => {
     e.preventDefault();
-    ctx.openPopover(pillEl, (close) => {
+    open(pillEl, (close) => {
       const wrap = el("div", "exed-menu");
       for (const a of actions) wrap.append(button("exed-opt", a.label, () => {
         a.run();
@@ -1653,6 +1661,7 @@ function frozenCtx(src, o) {
     catalogue: o.catalogue,
     scopeOrder: o.scopeOrder ?? [],
     functions: [],
+    compact: true,
     byPath: v.byPath,
     getAst: () => v.ast,
     apply: () => {
@@ -1662,7 +1671,13 @@ function frozenCtx(src, o) {
     pickNode: () => {
     },
     // enables labelled node pills; never fires (preview is read-only)
-    ...o.nodeLabel ? { nodeLabel: o.nodeLabel } : {}
+    ...o.nodeLabel ? { nodeLabel: o.nodeLabel } : {},
+    ...o.propertyActions ? {
+      propertyActions: o.propertyActions,
+      openMenu: (anchor, render) => {
+        openPopover(anchor, render, { container: o.popoverContainer });
+      }
+    } : {}
   };
   return { ctx, ast: v.ast };
 }
@@ -1671,7 +1686,8 @@ function exprPills(src, o) {
   return ast ? renderNode(ast, [], ctx) : el("span", "exed-preview-raw", [src]);
 }
 function renderConditionPreview(src, o) {
-  return el("div", "exed-preview", [exprPills(src, o)]);
+  const cls = o.propertyActions ? "exed-preview exed-preview-interactive" : "exed-preview";
+  return el("div", cls, [exprPills(src, o)]);
 }
 function renderEffectsPreview(effects, o) {
   const wrap = el("div", "exed-preview exed-preview-effects");