@wildwinter/expr-editor 0.14.1 → 0.15.1

package/dist/index.cjs

@@ -98,6 +98,7 @@ var normaliseRef = (ref, defaultScope) => {
   const prefix = `@${defaultScope.toLowerCase()}.`;
   return low.startsWith(prefix) ? `@${low.slice(prefix.length)}` : low;
 };
+var flagChangeSrc = (targetRef, sign, flag) => `set_flags(${targetRef}, ${sign}${flag})`;
 function advancedRef(node, defaultScope) {
   if (node.kind !== "call" || node.name !== "advance" || node.args.length !== 1) return null;
   const arg = node.args[0];
@@ -296,6 +297,7 @@ var propertyTip = (e) => {
   return lines.length ? lines.join("\n") : void 0;
 };
 var refOf = (e, defaultScope) => e.scope === defaultScope ? `@${e.name}` : `@${e.scope}.${e.name}`;
+var targetRefOf = (e) => `@${e.scope}.${e.name}`;
 var displayName = (e, defaultScope) => e.scope === defaultScope ? e.name : `${e.scope}.${e.name}`;
 function filterCatalogue(entries, filter = {}) {
   return entries.filter(
@@ -383,8 +385,14 @@ function openPopover(anchor, render, opts = {}) {
   container.append(pop);
   const a = anchor.getBoundingClientRect();
   const ph = pop.getBoundingClientRect();
-  let top = a.bottom + 4;
-  if (top + ph.height > window.innerHeight - 8 && a.top - ph.height - 4 > 8) top = a.top - ph.height - 4;
+  const GAP = 4;
+  const EDGE = 8;
+  const below = window.innerHeight - EDGE - (a.bottom + GAP);
+  const above = a.top - GAP - EDGE;
+  const flip = ph.height > below && above > below;
+  const room = flip ? above : below;
+  const top = flip ? a.top - Math.min(ph.height, above) - GAP : a.bottom + GAP;
+  if (ph.height > room) pop.style.maxHeight = `${Math.max(96, Math.round(room))}px`;
   let left = a.left;
   if (left + ph.width > window.innerWidth - 8) left = Math.max(8, window.innerWidth - 8 - ph.width);
   if (container === document.body) {
@@ -1084,7 +1092,7 @@ function seedClause(ctx) {
 function clauseMenu(ctx, anchor, onPick) {
   ctx.openPopover(anchor, (close) => {
     const wrap = el("div", "exed-menu");
-    wrap.append(el("div", "exed-menu-head", ["Add a clause"]));
+    wrap.append(el("div", "exed-menu-head", ["Add a condition"]));
     const add = (label, hint, make, disabled = false) => {
       const b = button(`exed-opt${disabled ? " disabled" : ""}`, "", () => {
         if (disabled) return;
@@ -1383,7 +1391,9 @@ function valueWizard(opts) {
   host.append(body);
   const choices = opts.expectedChoices?.length ? opts.expectedChoices : opts.expectedEnumValues;
   const isStage = opts.expectedType === "quality";
-  let kind = opts.expectedType === "number" ? "number" : opts.expectedType === "string" ? "text" : opts.expectedType === "boolean" ? "bool" : (opts.expectedType === "enum" || opts.expectedType === "quality") && choices?.length ? "enum" : "menu";
+  const flagsReady = opts.expectedType === "flags" && opts.expectedRef !== void 0;
+  let kind = opts.expectedType === "number" ? "number" : opts.expectedType === "string" ? "text" : opts.expectedType === "boolean" ? "bool" : (opts.expectedType === "enum" || opts.expectedType === "quality") && choices?.length ? "enum" : flagsReady ? "flags" : "menu";
+  let flagSign = "+";
   const draw = () => {
     body.replaceChildren();
     const other = () => button("exed-vwiz-other", "\u21A9 a different kind", () => {
@@ -1392,6 +1402,10 @@ function valueWizard(opts) {
     });
     switch (kind) {
       case "menu":
+        if (flagsReady) body.append(optBtn("Set or clear a flag\u2026", () => {
+          kind = "flags";
+          draw();
+        }));
         body.append(optBtn("A property\u2026", () => {
           kind = "property";
           draw();
@@ -1413,6 +1427,33 @@ function valueWizard(opts) {
           draw();
         }));
         break;
+      case "flags": {
+        const flags = opts.expectedFlags ?? [];
+        if (!flags.length) body.append(el("div", "exed-hint", ["This property declares no flag values yet."]));
+        else {
+          const signRow = el("div", "exed-field-row");
+          signRow.append(
+            button(`exed-opt${flagSign === "+" ? " sel" : ""}`, "\uFF0B set", () => {
+              flagSign = "+";
+              draw();
+            }),
+            button(`exed-opt${flagSign === "-" ? " sel" : ""}`, "\uFF0D clear", () => {
+              flagSign = "-";
+              draw();
+            })
+          );
+          body.append(signRow);
+          body.append(el("div", "exed-vwiz-note", [flagSign === "+" ? "Set a flag:" : "Clear a flag:"]));
+          const list = el("div", "exed-picker-list");
+          for (const f of flags) list.append(optBtn(`${flagSign} ${f}`, () => opts.onCommit(flagChangeSrc(opts.expectedRef, flagSign, f))));
+          body.append(list);
+        }
+        body.append(button("exed-vwiz-other", "\u21A9 a different kind (replaces every flag)", () => {
+          kind = "menu";
+          draw();
+        }));
+        break;
+      }
       case "property":
         body.append(propertyPicker(pickCtx, { onPick: (e) => opts.onCommit(refOf(e, opts.defaultScope)) }));
         body.append(other());
@@ -1451,6 +1492,10 @@ function isSelfAdvance(eff, defaultScope, dialect) {
     return false;
   }
 }
+function entryForTarget(catalogue, target, defaultScope) {
+  const want = normaliseRef(target, defaultScope);
+  return catalogue.find((e) => normaliseRef(`@${e.scope}.${e.name}`, defaultScope) === want);
+}
 var clone = (list) => list.map((e) => e.kind === "set" ? { ...e } : { ...e, args: [...e.args] });
 var addSet = (list, target, value) => [...clone(list), { kind: "set", target, value }];
 var addEmit = (list, event) => [...clone(list), { kind: "emit", event, args: [] }];
@@ -1539,6 +1584,11 @@ function mountEffectsEditor(host, opts) {
       // choicesOf, never a raw field: a quality's ladder lives in `stages`, and reading `enumValues`
       // here told the wizard the type and withheld the values.
       ...choicesOf(expected) ? { expectedChoices: choicesOf(expected) } : {},
+      // The flags step needs the target itself: its declared flags, and the
+      // qualified ref its set_flags(...) is written against. choicesOf stays
+      // out of it deliberately - flags are not a pick-one list, and a pinned
+      // test holds it to that.
+      ...expected?.type === "flags" ? { expectedRef: targetRefOf(expected), expectedFlags: expected.enumValues ?? [] } : {},
       onCommit: (src) => {
         onCommit(src);
         close();
@@ -1546,7 +1596,7 @@ function mountEffectsEditor(host, opts) {
       onCancel: close
     }), { container: opts.popoverContainer });
   };
-  const targetType = (target) => opts.catalogue.find((e) => refOf(e, defaultScope) === target)?.type;
+  const targetType = (target) => entryForTarget(opts.catalogue, target, defaultScope)?.type;
   const valueDisplay = (value, onChange, type, selfAdvanceRef) => {
     const sub = el("div", "exed-effect-value");
     const addTerm = type === "number" ? "arithmetic" : type === "boolean" ? "boolean" : void 0;
@@ -1613,10 +1663,10 @@ function mountEffectsEditor(host, opts) {
     const row = el("div", "exed-effect exed-effect-set");
     const targetBtn = button("exed-pill exed-pill-prop", eff.target || "(pick property)", (e) => {
       pickTarget(e.currentTarget, void 0, (entry) => {
-        commit(updateAt(effects, i, { target: refOf(entry, defaultScope), value: initialValueFor(entry, defaultScope).src }));
+        commit(updateAt(effects, i, { target: targetRefOf(entry), value: initialValueFor(entry, defaultScope).src }));
       });
     }, "change the target property");
-    const targetEntry = opts.catalogue.find((e) => refOf(e, defaultScope) === eff.target);
+    const targetEntry = entryForTarget(opts.catalogue, eff.target, defaultScope);
     const tip = propertyTip(targetEntry);
     if (tip) targetBtn.title = tip;
     if (targetEntry && opts.propertyActions) {
@@ -1720,10 +1770,10 @@ function mountEffectsEditor(host, opts) {
       pickTarget(anchor, void 0, (entry) => {
         const { src, ask } = initialValueFor(entry, defaultScope);
         if (!ask) {
-          commit(addSet(effects, refOf(entry, defaultScope), src));
+          commit(addSet(effects, targetRefOf(entry), src));
           return;
         }
-        openValueWizard(anchor, entry, (chosen) => commit(addSet(effects, refOf(entry, defaultScope), chosen)));
+        openValueWizard(anchor, entry, (chosen) => commit(addSet(effects, targetRefOf(entry), chosen)));
       });
     }));
     if (opts.allowEmit !== false) {
@@ -1852,6 +1902,7 @@ exports.filterCatalogue = filterCatalogue;
 exports.findChoicePeer = findChoicePeer;
 exports.findEnumPeer = findEnumPeer;
 exports.firstEmptyLeafPath = firstEmptyLeafPath;
+exports.flagChangeSrc = flagChangeSrc;
 exports.flagDelta = flagDelta;
 exports.flipContainerOp = flipContainerOp;
 exports.formatNumber = formatNumber;
@@ -1889,6 +1940,7 @@ exports.seedValueSrc = seedValueSrc;
 exports.setArgAt = setArgAt;
 exports.setNodeAt = setNodeAt;
 exports.strLit = strLit;
+exports.targetRefOf = targetRefOf;
 exports.toggleContainerNot = toggleContainerNot;
 exports.toggleNotAt = toggleNotAt;
 exports.updateAt = updateAt;