@wildo-ai/saas-backend-lib 1.1.2 → 1.1.3

package/dist/esm/requests/service/websocket.service.js

@@ -20,7 +20,7 @@ import { AppConfigurationService } from '../../config/services/app-configuration
 import { RedisService } from '../../databases/services/redis.service.js';
 import { ErrorBuilderBackendService } from '../../errors/services/error-builder.backend.service.js';
 import { runInFreshRequestContextIfAbsent } from '../../runtime/models/request-context.als.backend.js';
-import { ErrorCustomMessageReference, ErrorType, ExecutionContext_ExecutionType, ResourcePrimaryScope, CoreResourceOperation, CoreResourceType, ARRAY_RESPONSE_OPERATIONS, DataMode, ResourcesConfigOperationsDtosBuilderUtils, ResourcesConfig_OperationPathUtils, ResourceOperationsUtils, WildoHeaderKeys, ResourceOperationVariantType, isWildoBackendError, } from '@wildo-ai/saas-models';
+import { ErrorCustomMessageReference, ErrorType, ExecutionContext_ExecutionType, ResourcePrimaryScope, isSupportedNotificationBadgeScope, CoreResourceOperation, CoreResourceType, ARRAY_RESPONSE_OPERATIONS, DataMode, ResourcesConfigOperationsDtosBuilderUtils, ResourcesConfig_OperationPathUtils, ResourceOperationsUtils, WildoHeaderKeys, ResourceOperationVariantType, isWildoBackendError, } from '@wildo-ai/saas-models';
 import { ExecutionContextCreatorBackendService, } from '../../runtime/services/execution-context-creator.backend.service.js';
 import { AuthorizationsBackendService } from '../../security/authorizations/services/authorizations.backend.service.js';
 import { ResourcesRegistryBackendService } from '../../resources/services/resources-registry.backend.service.js';
@@ -2154,8 +2154,20 @@ let WebSocketService = class WebSocketService {
                 return;
             try {
                 const auth = this.getSocketAuth(socket);
+                /**
+                 * `payload.scope` is CLIENT-supplied. It used to be cast (`as ResourcePrimaryScope`) and
+                 * handed straight to the access check and the badge service, so a scope no resource type
+                 * backs — `application`, dropped by the polymorphism refactor — reached both and was
+                 * answered with a silent zero. Parse it instead: an unsupported scope is refused here, and
+                 * what continues is a value the badge service's own two-scope contract can accept.
+                 */
+                if (!isSupportedNotificationBadgeScope(payload.scope)) {
+                    callback({ count: 0 });
+                    return;
+                }
+                const badgeScope = payload.scope;
                 // Verify user has access to this scope
-                if (!this.verifyBadgeScopeAccess(auth, payload.scope, payload.scopeId)) {
+                if (!this.verifyBadgeScopeAccess(auth, badgeScope, payload.scopeId)) {
                     callback({ count: 0 });
                     return;
                 }
@@ -2166,7 +2178,7 @@ let WebSocketService = class WebSocketService {
                     return;
                 }
                 const executionContext = await this.executionContextCreator.buildContextFromSocketAuth(auth, appReadOp, {});
-                const count = await this.getBadgeService().getBadgeCount(executionContext, payload.scope, payload.scopeId, payload.identifier);
+                const count = await this.getBadgeService().getBadgeCount(executionContext, badgeScope, payload.scopeId, payload.identifier);
                 callback({ count });
             }
             catch (error) {
@@ -2182,8 +2194,14 @@ let WebSocketService = class WebSocketService {
                 return;
             try {
                 const auth = this.getSocketAuth(socket);
+                // Same parse-don't-cast as `badge:get` above — see the comment there.
+                if (!isSupportedNotificationBadgeScope(payload.scope)) {
+                    callback([]);
+                    return;
+                }
+                const badgeScope = payload.scope;
                 // Verify user has access to this scope
-                if (!this.verifyBadgeScopeAccess(auth, payload.scope, payload.scopeId)) {
+                if (!this.verifyBadgeScopeAccess(auth, badgeScope, payload.scopeId)) {
                     callback([]);
                     return;
                 }
@@ -2194,7 +2212,7 @@ let WebSocketService = class WebSocketService {
                     return;
                 }
                 const executionContext = await this.executionContextCreator.buildContextFromSocketAuth(auth, appReadOp, {});
-                const badges = await this.getBadgeService().getAllBadges(executionContext, payload.scope, payload.scopeId);
+                const badges = await this.getBadgeService().getAllBadges(executionContext, badgeScope, payload.scopeId);
                 callback(badges);
             }
             catch (error) {
@@ -2208,6 +2226,15 @@ let WebSocketService = class WebSocketService {
     /**
      * Verify user has access to a badge scope
      */
+    /**
+     * May this socket read badges at `(scope, scopeId)`?
+     *
+     * Typed `NotificationScope` rather than `ResourcePrimaryScope` because only two scopes have a
+     * badge resource behind them. The removed third arm granted access to "application-level badges"
+     * on the strength of holding any application role — a survivor of the polymorphism refactor that
+     * dropped the APPLICATION variant, so it authorized reads of badges that cannot exist. Callers
+     * now refuse an unsupported scope before they get here.
+     */
     verifyBadgeScopeAccess(auth, scope, scopeId) {
         // Public users cannot access badges
         if (auth.executionType === ExecutionContext_ExecutionType.PUBLIC_EXECUTION) {
@@ -2221,9 +2248,6 @@ let WebSocketService = class WebSocketService {
                 // User must be member of the organization
                 return auth.initiatorRoles.some(r => r.relatedPrimaryScope === ResourcePrimaryScope.ORGANIZATIONS &&
                     r.relatedResourceId === scopeId);
-            case ResourcePrimaryScope.APPLICATION:
-                // Application-level badges - check if user has any app roles
-                return auth.initiatorRoles.some(r => r.relatedPrimaryScope === ResourcePrimaryScope.APPLICATION);
             default:
                 return false;
         }