@wichayutdew/pi-workflows 2.0.0 → 2.1.0

package/src/engine/run-reconciliation.ts

@@ -110,6 +110,7 @@ export const reconcileRun = (
           pausedFrom: 'running',
           failedStepId: undefined,
           pauseReason: `Configuration changed; restarted step "${restartedStep}"`,
+          gateArtifact: '',
           gateFeedback: '',
         },
         now,
@@ -127,6 +128,7 @@ export const reconcileRun = (
         pausedFrom: 'running',
         failedStepId: undefined,
         pauseReason: `Configuration changed; restarted step "${run.currentStepId}"`,
+        gateArtifact: '',
         gateFeedback: '',
       }
     : {};

package/src/engine/run-validation.ts

@@ -1,5 +1,6 @@
 import { isAbsolute, resolve } from 'node:path';
 import {
+  MAX_GATE_FEEDBACK_CHARS,
   MAX_RESUME_INPUT_CHARS,
   MAX_STEP_TRACE_ARTIFACT_CHARS,
   MAX_STEP_TRACE_ATTEMPTS,
@@ -40,6 +41,7 @@ const isGateApproval = (value: unknown): value is GateApproval =>
   typeof value.artifact === 'string' &&
   value.artifact.trim().length > 0 &&
   typeof value.feedback === 'string' &&
+  value.feedback.length <= MAX_GATE_FEEDBACK_CHARS &&
   typeof value.stepStructuralDigest === 'string' &&
   value.stepStructuralDigest.length > 0;
 
@@ -221,6 +223,7 @@ const isGateResolution = (value: unknown): value is GateResolution =>
   isRecord(value) &&
   typeof value.approved === 'boolean' &&
   typeof value.feedback === 'string' &&
+  value.feedback.length <= MAX_GATE_FEEDBACK_CHARS &&
   typeof value.resolvedAt === 'number';
 
 const isPendingGate = (value: unknown): value is PendingGate =>
@@ -333,13 +336,17 @@ export const isWorkflowRun = (value: unknown): value is WorkflowRun => {
     typeof value.startedAt === 'number' &&
     typeof value.updatedAt === 'number' &&
     typeof value.lastSummary === 'string' &&
-    typeof value.gateFeedback === 'string';
+    typeof value.gateFeedback === 'string' &&
+    value.gateFeedback.length <= MAX_GATE_FEEDBACK_CHARS;
   if (!hasValidRequiredFields) return false;
 
   const hasValidOptionalFields =
     isOptionalString(value.reviewedArtifact) &&
     isOptionalString(value.reviewedFeedback) &&
+    (typeof value.reviewedFeedback !== 'string' ||
+      value.reviewedFeedback.length <= MAX_GATE_FEEDBACK_CHARS) &&
     isOptionalString(value.stepHandoff) &&
+    isOptionalString(value.gateArtifact) &&
     isOptionalResumeInput(value.resumeInput) &&
     isOptionalString(value.pauseReason) &&
     isOptionalString(value.failedStepId) &&

package/src/engine/state-types.ts

@@ -1,4 +1,5 @@
 export const RUN_STATE_VERSION = 1 as const;
+export const MAX_GATE_FEEDBACK_CHARS = 50_000;
 export const MAX_RESUME_INPUT_CHARS = 16_000;
 export const MAX_STEP_TRACE_TASK_CHARS = 64_000;
 export const MAX_STEP_TRACE_ATTEMPTS = 16;
@@ -158,6 +159,8 @@ export type WorkflowRun = {
    */
   readonly stepHandoff?: string | undefined;
   readonly lastSummary: string;
+  /** Opaque artifact returned by the latest rejected or failed gate. */
+  readonly gateArtifact?: string | undefined;
   readonly gateFeedback: string;
   /** User-authored guidance supplied for the current resume attempt. */
   readonly resumeInput?: string | undefined;

package/src/engine/state.ts

@@ -1,6 +1,7 @@
 export { createRun } from './create-run.ts';
 export { isWorkflowRun } from './run-validation.ts';
 export {
+  MAX_GATE_FEEDBACK_CHARS,
   MAX_RESUME_INPUT_CHARS,
   MAX_STEP_TRACE_ATTEMPTS,
   MAX_STEP_TRACE_LOG_CHARS,

package/src/prompt/template.ts

@@ -7,8 +7,8 @@ import type { WorkflowRun } from '../engine/state.ts';
 export type TemplateValues = Readonly<Record<string, string>>;
 
 /**
- * Combines the incoming handoff with the latest paused-attempt
- * summary without duplicating identical content.
+ * Combines the incoming handoff with the latest current-step summary without
+ * duplicating identical content.
  *
  * @param run - Current workflow run.
  * @returns The handoff text for the active step.
@@ -27,7 +27,7 @@ export function currentStepHandoff(run: WorkflowRun): string {
     'Incoming previous-step handoff:',
     incomingHandoff,
     '',
-    'Latest paused attempt:',
+    'Latest current-step summary:',
     run.lastSummary,
   ].join('\n');
 }
@@ -78,6 +78,7 @@ export function createTemplateValues({
     'last.summary': currentStepHandoff(run),
     'reviewed.artifact': run.reviewedArtifact ?? '',
     'reviewed.feedback': run.reviewedFeedback ?? '',
+    'gate.artifact': run.gateArtifact ?? '',
     'gate.feedback': run.gateFeedback,
     'resume.input': run.resumeInput ?? '',
   };

package/src/workflow-doctor.ts

@@ -235,7 +235,7 @@ export function formatWorkflowDoctor(
       '',
       `Result: ${errors.length > 0 ? 'ERROR' : warnings.length > 0 ? 'WARNING' : 'PASS'}`,
       '',
-      `Runtime loop guard: each step executes at most ${report.maxStepVisits} time${report.maxStepVisits === 1 ? '' : 's'} before the next attempted entry pauses an uninterrupted run. This bounds graph cycling; it does not guarantee $done or bound time spent inside a step or gate.`,
+      `Runtime loop guard: automatic graph advancement enters each step at most ${report.maxStepVisits} time${report.maxStepVisits === 1 ? '' : 's'} before the next attempted entry pauses the run. An explicit human rejection back to the same gated step bypasses that check for its transition because every revision awaits another decision; the visit is still recorded. This bounds unattended cycling; it does not guarantee $done or bound time spent inside a step or gate.`,
       '',
     );
     if (report.issues.length === 0) {

package/src/workflow-status/view.ts

@@ -135,6 +135,7 @@ function nextScrollOffset(state: ViewportState, value: number): number {
 export class WorkflowStatusView implements Component {
   private timer: RefreshTimer | undefined;
   private state = initialViewportState();
+  private pendingDetailTopKey = false;
   private readonly statusShortcutLabel: string;
   private readonly dependencies: WorkflowStatusViewDependencies;
   private readonly transcriptCache = new Map<string, StepTranscriptViewState>();
@@ -180,11 +181,15 @@ export class WorkflowStatusView implements Component {
 
   /** Handle close and scrolling key input. */
   handleInput(data: string): void {
+    const isDetailHalfPageDown =
+      this.state.mode === 'detail' && matchesKey(data, Key.ctrl('d'));
+    const isDetailHalfPageUp =
+      this.state.mode === 'detail' && matchesKey(data, Key.ctrl('u'));
     if (
       data === 'q' ||
       data === 'Q' ||
       matchesKey(data, 'ctrl+c') ||
-      matchesKey(data, 'ctrl+d') ||
+      (this.state.mode !== 'detail' && matchesKey(data, 'ctrl+d')) ||
       matchesKey(data, this.statusShortcut)
     ) {
       this.close();
@@ -199,13 +204,31 @@ export class WorkflowStatusView implements Component {
       return;
     }
     const pageSize = Math.max(1, this.state.viewportRows - 2);
+    const contentHeight = Math.max(1, this.state.viewportRows - 1);
+    const halfPageSize = Math.max(1, Math.floor(contentHeight / 2));
     if (this.state.mode === 'detail') {
-      if (matchesKey(data, Key.left) || data === 'h') {
+      if (data === 'gg' || (data === 'g' && this.pendingDetailTopKey)) {
+        this.pendingDetailTopKey = false;
+        this.setScrollOffset(0);
+        return;
+      }
+      if (data === 'g') {
+        this.pendingDetailTopKey = true;
+        return;
+      }
+      this.pendingDetailTopKey = false;
+      if (data === 'G') {
+        this.setScrollOffset(Number.MAX_SAFE_INTEGER);
+      } else if (matchesKey(data, Key.left) || data === 'h') {
         this.showBoard();
       } else if (matchesKey(data, Key.down) || data === 'j') {
         this.setScrollOffset(this.state.scrollOffset + 1);
       } else if (matchesKey(data, Key.up) || data === 'k') {
         this.setScrollOffset(this.state.scrollOffset - 1);
+      } else if (isDetailHalfPageDown) {
+        this.setScrollOffset(this.state.scrollOffset + halfPageSize);
+      } else if (isDetailHalfPageUp) {
+        this.setScrollOffset(this.state.scrollOffset - halfPageSize);
       } else if (matchesKey(data, Key.pageDown)) {
         this.setScrollOffset(this.state.scrollOffset + pageSize);
       } else if (matchesKey(data, Key.pageUp)) {
@@ -217,6 +240,7 @@ export class WorkflowStatusView implements Component {
       }
       return;
     }
+    this.pendingDetailTopKey = false;
     if (matchesKey(data, Key.down) || data === 'j') {
       this.moveSelection(1);
     } else if (matchesKey(data, Key.up) || data === 'k') {
@@ -287,7 +311,7 @@ export class WorkflowStatusView implements Component {
       this.statusShortcutLabel,
       this.theme,
       this.state.mode === 'detail'
-        ? '↑/↓ or j/k scroll · PgUp/PgDn · ←/h/Esc back'
+        ? '↑↓/jk · Ctrl+D/U half-page · gg/G top/bottom · PgUp/PgDn · ←/h/Esc'
         : '↑/↓ or j/k select · Enter/→/l inspect · PgUp/PgDn',
     );
     this.state = page.state;
@@ -339,6 +363,7 @@ export class WorkflowStatusView implements Component {
     if (!snapshot) return;
     this.normalizeSelection(snapshot);
     if (!selectedStepDetail(snapshot, this.state.selectedIndex)) return;
+    this.pendingDetailTopKey = false;
     this.state = { ...this.state, mode: 'detail', scrollOffset: 0 };
     this.ensureSelectedTranscripts(snapshot);
     this.tui.requestRender(true);
@@ -346,6 +371,7 @@ export class WorkflowStatusView implements Component {
 
   private showBoard(): void {
     if (this.state.mode === 'board') return;
+    this.pendingDetailTopKey = false;
     this.state = { ...this.state, mode: 'board', scrollOffset: 0 };
     this.tui.requestRender(true);
   }