@wiajs/request 3.0.0 → 3.0.1

package/tests/test-errors.js

@@ -0,0 +1,108 @@
+'use strict'
+
+var request = require('../index')
+var tape = require('tape')
+
+var local = 'http://localhost:0/asdf'
+
+tape('without uri', function (t) {
+  t.throws(function () {
+    request({})
+  }, /^Error: options\.uri is a required argument$/)
+  t.end()
+})
+
+tape('invalid uri 1', function (t) {
+  t.throws(function () {
+    request({
+      uri: 'this-is-not-a-valid-uri'
+    })
+  }, /^Error: Invalid URI/)
+  t.end()
+})
+
+tape('invalid uri 2', function (t) {
+  t.throws(function () {
+    request({
+      uri: 'github.com/uri-is-not-valid-without-protocol'
+    })
+  }, /^Error: Invalid URI/)
+  t.end()
+})
+
+tape('invalid uri + NO_PROXY', function (t) {
+  process.env.NO_PROXY = 'google.com'
+  t.throws(function () {
+    request({
+      uri: 'invalid'
+    })
+  }, /^Error: Invalid URI/)
+  delete process.env.NO_PROXY
+  t.end()
+})
+
+tape('deprecated unix URL', function (t) {
+  t.throws(function () {
+    request({
+      uri: 'unix://path/to/socket/and/then/request/path'
+    })
+  }, /^Error: `unix:\/\/` URL scheme is no longer supported/)
+  t.end()
+})
+
+tape('invalid body', function (t) {
+  t.throws(function () {
+    request({
+      uri: local, body: {}
+    })
+  }, /^Error: Argument error, options\.body\.$/)
+  t.end()
+})
+
+tape('invalid multipart', function (t) {
+  t.throws(function () {
+    request({
+      uri: local,
+      multipart: 'foo'
+    })
+  }, /^Error: Argument error, options\.multipart\.$/)
+  t.end()
+})
+
+tape('multipart without body 1', function (t) {
+  t.throws(function () {
+    request({
+      uri: local,
+      multipart: [ {} ]
+    })
+  }, /^Error: Body attribute missing in multipart\.$/)
+  t.end()
+})
+
+tape('multipart without body 2', function (t) {
+  t.throws(function () {
+    request(local, {
+      multipart: [ {} ]
+    })
+  }, /^Error: Body attribute missing in multipart\.$/)
+  t.end()
+})
+
+tape('head method with a body', function (t) {
+  t.throws(function () {
+    request(local, {
+      method: 'HEAD',
+      body: 'foo'
+    })
+  }, /HTTP HEAD requests MUST NOT include a request body/)
+  t.end()
+})
+
+tape('head method with a body 2', function (t) {
+  t.throws(function () {
+    request.head(local, {
+      body: 'foo'
+    })
+  }, /HTTP HEAD requests MUST NOT include a request body/)
+  t.end()
+})

package/tests/test-event-forwarding.js

@@ -0,0 +1,39 @@
+'use strict'
+
+var server = require('./server')
+var request = require('../index')
+var tape = require('tape')
+
+var s = server.createServer()
+
+tape('setup', function (t) {
+  s.listen(0, function () {
+    s.on('/', function (req, res) {
+      res.writeHead(200, { 'content-type': 'text/plain' })
+      res.write('waited')
+      res.end()
+    })
+    t.end()
+  })
+})
+
+tape('should emit socket event', function (t) {
+  t.plan(4)
+
+  var req = request(s.url, function (err, res, body) {
+    t.equal(err, null)
+    t.equal(res.statusCode, 200)
+    t.equal(body, 'waited')
+  })
+
+  req.on('socket', function (socket) {
+    var requestSocket = req.req.socket
+    t.equal(requestSocket, socket)
+  })
+})
+
+tape('cleanup', function (t) {
+  s.close(function () {
+    t.end()
+  })
+})

package/tests/test-follow-all-303.js

@@ -0,0 +1,45 @@
+'use strict'
+
+var http = require('http')
+var request = require('../index')
+var tape = require('tape')
+
+var server = http.createServer(function (req, res) {
+  if (req.method === 'POST') {
+    res.setHeader('location', req.url)
+    res.statusCode = 303
+    res.end('try again')
+  } else {
+    res.end('ok')
+  }
+})
+
+tape('setup', function (t) {
+  server.listen(0, function () {
+    server.url = 'http://localhost:' + this.address().port
+    t.end()
+  })
+})
+
+tape('followAllRedirects with 303', function (t) {
+  var redirects = 0
+
+  request.post({
+    url: server.url + '/foo',
+    followAllRedirects: true,
+    form: { foo: 'bar' }
+  }, function (err, res, body) {
+    t.equal(err, null)
+    t.equal(body, 'ok')
+    t.equal(redirects, 1)
+    t.end()
+  }).on('redirect', function () {
+    redirects++
+  })
+})
+
+tape('cleanup', function (t) {
+  server.close(function () {
+    t.end()
+  })
+})

package/tests/test-follow-all.js

@@ -0,0 +1,57 @@
+'use strict'
+
+var http = require('http')
+var request = require('../index')
+var tape = require('tape')
+
+var server = http.createServer(function (req, res) {
+  // redirect everything 3 times, no matter what.
+  var c = req.headers.cookie
+
+  if (!c) {
+    c = 0
+  } else {
+    c = +c.split('=')[1] || 0
+  }
+
+  if (c > 3) {
+    res.end('ok')
+    return
+  }
+
+  res.setHeader('set-cookie', 'c=' + (c + 1))
+  res.setHeader('location', req.url)
+  res.statusCode = 302
+  res.end('try again')
+})
+
+tape('setup', function (t) {
+  server.listen(0, function () {
+    server.url = 'http://localhost:' + this.address().port
+    t.end()
+  })
+})
+
+tape('followAllRedirects', function (t) {
+  var redirects = 0
+
+  request.post({
+    url: server.url + '/foo',
+    followAllRedirects: true,
+    jar: true,
+    form: { foo: 'bar' }
+  }, function (err, res, body) {
+    t.equal(err, null)
+    t.equal(body, 'ok')
+    t.equal(redirects, 4)
+    t.end()
+  }).on('redirect', function () {
+    redirects++
+  })
+})
+
+tape('cleanup', function (t) {
+  server.close(function () {
+    t.end()
+  })
+})

package/tests/test-form-data-error.js

@@ -0,0 +1,85 @@
+'use strict'
+
+var request = require('../index')
+var server = require('./server')
+var tape = require('tape')
+
+var s = server.createServer()
+
+tape('setup', function (t) {
+  s.listen(0, function () {
+    t.end()
+  })
+})
+
+tape('re-emit formData errors', function (t) {
+  s.on('/', function (req, res) {
+    res.writeHead(400)
+    res.end()
+    t.fail('The form-data error did not abort the request.')
+  })
+
+  request.post(s.url, function (err, res, body) {
+    t.equal(err.message, 'form-data: Arrays are not supported.')
+    setTimeout(function () {
+      t.end()
+    }, 10)
+  }).form().append('field', ['value1', 'value2'])
+})
+
+tape('omit content-length header if the value is set to NaN', function (t) {
+  // returns chunked HTTP response which is streamed to the 2nd HTTP request in the form data
+  s.on('/chunky', server.createChunkResponse(
+    ['some string',
+      'some other string'
+    ]))
+
+  // accepts form data request
+  s.on('/stream', function (req, resp) {
+    req.on('data', function (chunk) {
+      // consume the request body
+    })
+    req.on('end', function () {
+      resp.writeHead(200)
+      resp.end()
+    })
+  })
+
+  var sendStreamRequest = function (stream) {
+    request.post({
+      uri: s.url + '/stream',
+      formData: {
+        param: stream
+      }
+    }, function (err, res) {
+      t.error(err, 'request failed')
+      t.end()
+    })
+  }
+
+  request.get({
+    uri: s.url + '/chunky'
+  }).on('response', function (res) {
+    sendStreamRequest(res)
+  })
+})
+
+// TODO: remove this test after form-data@2.0 starts stringifying null values
+tape('form-data should throw on null value', function (t) {
+  t.throws(function () {
+    request({
+      method: 'POST',
+      url: s.url,
+      formData: {
+        key: null
+      }
+    })
+  }, TypeError)
+  t.end()
+})
+
+tape('cleanup', function (t) {
+  s.close(function () {
+    t.end()
+  })
+})

package/tests/test-form-data.js

@@ -0,0 +1,133 @@
+'use strict'
+
+var http = require('http')
+var path = require('path')
+var mime = require('mime-types')
+var request = require('../index')
+var fs = require('fs')
+var tape = require('tape')
+
+function runTest (t, options) {
+  var remoteFile = path.join(__dirname, 'googledoodle.jpg')
+  var localFile = path.join(__dirname, 'unicycle.jpg')
+  var multipartFormData = {}
+
+  var server = http.createServer(function (req, res) {
+    if (req.url === '/file') {
+      res.writeHead(200, {'content-type': 'image/jpg', 'content-length': 7187})
+      res.end(fs.readFileSync(remoteFile), 'binary')
+      return
+    }
+
+    if (options.auth) {
+      if (!req.headers.authorization) {
+        res.writeHead(401, {'www-authenticate': 'Basic realm="Private"'})
+        res.end()
+        return
+      } else {
+        t.ok(req.headers.authorization === 'Basic ' + Buffer.from('user:pass').toString('base64'))
+      }
+    }
+
+    t.ok(/multipart\/form-data; boundary=--------------------------\d+/
+      .test(req.headers['content-type']))
+
+    // temp workaround
+    var data = ''
+    req.setEncoding('utf8')
+
+    req.on('data', function (d) {
+      data += d
+    })
+
+    req.on('end', function () {
+      // check for the fields' traces
+
+      // 1st field : my_field
+      t.ok(data.indexOf('form-data; name="my_field"') !== -1)
+      t.ok(data.indexOf(multipartFormData.my_field) !== -1)
+
+      // 2nd field : my_buffer
+      t.ok(data.indexOf('form-data; name="my_buffer"') !== -1)
+      t.ok(data.indexOf(multipartFormData.my_buffer) !== -1)
+
+      // 3rd field : my_file
+      t.ok(data.indexOf('form-data; name="my_file"') !== -1)
+      t.ok(data.indexOf('; filename="' + path.basename(multipartFormData.my_file.path) + '"') !== -1)
+      // check for unicycle.jpg traces
+      t.ok(data.indexOf('2005:06:21 01:44:12') !== -1)
+      t.ok(data.indexOf('Content-Type: ' + mime.lookup(multipartFormData.my_file.path)) !== -1)
+
+      // 4th field : remote_file
+      t.ok(data.indexOf('form-data; name="remote_file"') !== -1)
+      t.ok(data.indexOf('; filename="' + path.basename(multipartFormData.remote_file.path) + '"') !== -1)
+
+      // 5th field : file with metadata
+      t.ok(data.indexOf('form-data; name="secret_file"') !== -1)
+      t.ok(data.indexOf('Content-Disposition: form-data; name="secret_file"; filename="topsecret.jpg"') !== -1)
+      t.ok(data.indexOf('Content-Type: image/custom') !== -1)
+
+      // 6th field : batch of files
+      t.ok(data.indexOf('form-data; name="batch"') !== -1)
+      t.ok(data.match(/form-data; name="batch"/g).length === 2)
+
+      // check for http://localhost:nnnn/file traces
+      t.ok(data.indexOf('Photoshop ICC') !== -1)
+      t.ok(data.indexOf('Content-Type: ' + mime.lookup(remoteFile)) !== -1)
+
+      res.writeHead(200)
+      res.end(options.json ? JSON.stringify({status: 'done'}) : 'done')
+    })
+  })
+
+  server.listen(0, function () {
+    var url = 'http://localhost:' + this.address().port
+    // @NOTE: multipartFormData properties must be set here so that my_file read stream does not leak in node v0.8
+    multipartFormData.my_field = 'my_value'
+    multipartFormData.my_buffer = Buffer.from([1, 2, 3])
+    multipartFormData.my_file = fs.createReadStream(localFile)
+    multipartFormData.remote_file = request(url + '/file')
+    multipartFormData.secret_file = {
+      value: fs.createReadStream(localFile),
+      options: {
+        filename: 'topsecret.jpg',
+        contentType: 'image/custom'
+      }
+    }
+    multipartFormData.batch = [
+      fs.createReadStream(localFile),
+      fs.createReadStream(localFile)
+    ]
+
+    var reqOptions = {
+      url: url + '/upload',
+      formData: multipartFormData
+    }
+    if (options.json) {
+      reqOptions.json = true
+    }
+    if (options.auth) {
+      reqOptions.auth = {user: 'user', pass: 'pass', sendImmediately: false}
+    }
+    request.post(reqOptions, function (err, res, body) {
+      t.equal(err, null)
+      t.equal(res.statusCode, 200)
+      t.deepEqual(body, options.json ? {status: 'done'} : 'done')
+      server.close(function () {
+        t.end()
+      })
+    })
+  })
+}
+
+tape('multipart formData', function (t) {
+  runTest(t, {json: false})
+})
+
+tape('multipart formData + JSON', function (t) {
+  runTest(t, {json: true})
+})
+
+tape('multipart formData + basic auth', function (t) {
+  runTest(t, {json: false, auth: true})
+})

package/tests/test-form-urlencoded.js

@@ -0,0 +1,73 @@
+'use strict'
+
+var http = require('http')
+var request = require('../index')
+var tape = require('tape')
+
+function runTest (t, options, index) {
+  var server = http.createServer(function (req, res) {
+    if (index === 0 || index === 3) {
+      t.equal(req.headers['content-type'], 'application/x-www-form-urlencoded')
+    } else {
+      t.equal(req.headers['content-type'], 'application/x-www-form-urlencoded; charset=UTF-8')
+    }
+    t.equal(req.headers['content-length'], '21')
+    t.equal(req.headers.accept, 'application/json')
+
+    var data = ''
+    req.setEncoding('utf8')
+
+    req.on('data', function (d) {
+      data += d
+    })
+
+    req.on('end', function () {
+      t.equal(data, 'some=url&encoded=data')
+
+      res.writeHead(200)
+      res.end('done')
+    })
+  })
+
+  server.listen(0, function () {
+    var url = 'http://localhost:' + this.address().port
+    var r = request.post(url, options, function (err, res, body) {
+      t.equal(err, null)
+      t.equal(res.statusCode, 200)
+      t.equal(body, 'done')
+      server.close(function () {
+        t.end()
+      })
+    })
+    if (!options.form && !options.body) {
+      r.form({some: 'url', encoded: 'data'})
+    }
+  })
+}
+
+var cases = [
+  {
+    form: {some: 'url', encoded: 'data'},
+    json: true
+  },
+  {
+    headers: {'content-type': 'application/x-www-form-urlencoded; charset=UTF-8'},
+    form: {some: 'url', encoded: 'data'},
+    json: true
+  },
+  {
+    headers: {'content-type': 'application/x-www-form-urlencoded; charset=UTF-8'},
+    body: 'some=url&encoded=data',
+    json: true
+  },
+  {
+    // body set via .form() method
+    json: true
+  }
+]
+
+cases.forEach(function (options, index) {
+  tape('application/x-www-form-urlencoded ' + index, function (t) {
+    runTest(t, options, index)
+  })
+})

package/tests/test-form.js

@@ -0,0 +1,101 @@
+'use strict'
+
+var http = require('http')
+var path = require('path')
+var mime = require('mime-types')
+var request = require('../index')
+var fs = require('fs')
+var tape = require('tape')
+
+tape('multipart form append', function (t) {
+  var remoteFile = path.join(__dirname, 'googledoodle.jpg')
+  var localFile = path.join(__dirname, 'unicycle.jpg')
+  var totalLength = null
+  var FIELDS = []
+
+  var server = http.createServer(function (req, res) {
+    if (req.url === '/file') {
+      res.writeHead(200, {'content-type': 'image/jpg', 'content-length': 7187})
+      res.end(fs.readFileSync(remoteFile), 'binary')
+      return
+    }
+
+    t.ok(/multipart\/form-data; boundary=--------------------------\d+/
+      .test(req.headers['content-type']))
+
+    // temp workaround
+    var data = ''
+    req.setEncoding('utf8')
+
+    req.on('data', function (d) {
+      data += d
+    })
+
+    req.on('end', function () {
+      var field
+      // check for the fields' traces
+
+      // 1st field : my_field
+      field = FIELDS.shift()
+      t.ok(data.indexOf('form-data; name="' + field.name + '"') !== -1)
+      t.ok(data.indexOf(field.value) !== -1)
+
+      // 2nd field : my_buffer
+      field = FIELDS.shift()
+      t.ok(data.indexOf('form-data; name="' + field.name + '"') !== -1)
+      t.ok(data.indexOf(field.value) !== -1)
+
+      // 3rd field : my_file
+      field = FIELDS.shift()
+      t.ok(data.indexOf('form-data; name="' + field.name + '"') !== -1)
+      t.ok(data.indexOf('; filename="' + path.basename(field.value.path) + '"') !== -1)
+      // check for unicycle.jpg traces
+      t.ok(data.indexOf('2005:06:21 01:44:12') !== -1)
+      t.ok(data.indexOf('Content-Type: ' + mime.lookup(field.value.path)) !== -1)
+
+      // 4th field : remote_file
+      field = FIELDS.shift()
+      t.ok(data.indexOf('form-data; name="' + field.name + '"') !== -1)
+      t.ok(data.indexOf('; filename="' + path.basename(field.value.path) + '"') !== -1)
+      // check for http://localhost:nnnn/file traces
+      t.ok(data.indexOf('Photoshop ICC') !== -1)
+      t.ok(data.indexOf('Content-Type: ' + mime.lookup(remoteFile)) !== -1)
+
+      t.ok(+req.headers['content-length'] === totalLength)
+
+      res.writeHead(200)
+      res.end('done')
+
+      t.equal(FIELDS.length, 0)
+    })
+  })
+
+  server.listen(0, function () {
+    var url = 'http://localhost:' + this.address().port
+    FIELDS = [
+      { name: 'my_field', value: 'my_value' },
+      { name: 'my_buffer', value: Buffer.from([1, 2, 3]) },
+      { name: 'my_file', value: fs.createReadStream(localFile) },
+      { name: 'remote_file', value: request(url + '/file') }
+    ]
+
+    var req = request.post(url + '/upload', function (err, res, body) {
+      t.equal(err, null)
+      t.equal(res.statusCode, 200)
+      t.equal(body, 'done')
+      server.close(function () {
+        t.end()
+      })
+    })
+    var form = req.form()
+
+    FIELDS.forEach(function (field) {
+      form.append(field.name, field.value)
+    })
+
+    form.getLength(function (err, length) {
+      t.equal(err, null)
+      totalLength = length
+    })
+  })
+})