@whittlelabs/sifter 0.30.17 → 0.30.18

package/README.md

@@ -134,6 +134,8 @@ Sixteen checks over everything the Sifter needs before it can review anything: a
 
 `init` and `run` run the relevant subset themselves, so `doctor` is for when the Sifter looks healthy and nothing is happening.
 
+The login check asks the CLI itself (`claude auth status`), so a login kept in the macOS Keychain counts, and it asks with the settings a review loads. A signed-out CLI fails it with the remedy `claude auth login`; a signed-in one passes as, for example, `signed in (claude.ai, max; not verified)`, because only `--deep` proves the login works. It never prints the email or organization the CLI reports. A `claude` too old to have `auth status` is checked the old way, by looking for its credentials file.
+
 ```bash
 whittle-sifter doctor --deep     # also spend one real turn proving the claude login works
 whittle-sifter doctor --json     # the verdicts as JSON, and nothing else

package/bin.js

@@ -12475,6 +12475,12 @@ var require_checks = __commonJS({
       const defaults = (0, environment_1.executorDefaultsFor)(subject.brand, config.auth.jobsApiUrl)?.[WORKSPACE_EXECUTOR] ?? {};
       return { ...defaults, ...user };
     }
+    function claudeSettingsOf(config) {
+      return config.executors[WORKSPACE_EXECUTOR]?.claudeSettings;
+    }
+    function describeLogin(status) {
+      return [status.authMethod ?? "unknown method", status.subscriptionType].filter((part) => part !== null).join(", ");
+    }
     function runRoot(config, subject, osTmpDir) {
       const settings = claudeCodeSettings(config, subject);
       const tmpDir = settings?.tmpDir;
@@ -12769,6 +12775,14 @@ var require_checks = __commonJS({
           if (probes.ambientAnthropicKey()) {
             return warn("claude-auth", "ANTHROPIC_API_KEY is set and will bill that account, shadowing any interactive login", "unset ANTHROPIC_API_KEY if you meant to use your Claude Code login");
           }
+          const settingSources = claudeSettingsOf(config) === "user" ? "user" : "";
+          const status = await probes.claudeAuthStatus(settingSources);
+          if (status !== null) {
+            if (!status.loggedIn) {
+              return fail("claude-auth", "the claude CLI is not signed in", settingSources === "" ? "run `claude auth login`; if your login or provider is configured in Claude Code settings (apiKeyHelper, or an env block), set `claudeSettings: user` on the claude-code executor instead" : "run `claude auth login`");
+            }
+            return pass("claude-auth", `signed in (${describeLogin(status)}; not verified)`);
+          }
           const store = await probes.claudeCredentialStore();
           if (store === null) {
             return warn("claude-auth", "no credential store found for the claude CLI (a macOS login may live in the Keychain, which this cannot read)", "run `claude` once and sign in, or run doctor --deep to spend one turn proving it");
@@ -21382,6 +21396,7 @@ var require_probes = __commonJS({
     };
     Object.defineProperty(exports2, "__esModule", { value: true });
     exports2.createProbes = createProbes;
+    exports2.parseClaudeAuthStatus = parseClaudeAuthStatus;
     var child_process_1 = require("child_process");
     var fs_1 = require("fs");
     var promises_1 = require("fs/promises");
@@ -21600,6 +21615,10 @@ var require_probes = __commonJS({
           const candidate = path_1.default.join(configDir, ".credentials.json");
           return (0, fs_1.existsSync)(candidate) ? candidate : null;
         },
+        async claudeAuthStatus(settingSources) {
+          const outcome = await runForAnyExit("claude", ["--setting-sources", settingSources, "auth", "status", "--json"], VERSION_TIMEOUT_MS);
+          return outcome === null ? null : parseClaudeAuthStatus(outcome);
+        },
         ambientAnthropicKey: () => (process.env.ANTHROPIC_API_KEY ?? "").length > 0,
         async claudeRoundTrip() {
           const output = await runForOutput(
@@ -21620,13 +21639,37 @@ var require_probes = __commonJS({
       const outcome = await runCapturing(bin, args, timeoutMs);
       return outcome.ok ? outcome.stdout : null;
     }
+    async function runForAnyExit(bin, args, timeoutMs) {
+      const outcome = await runCapturing(bin, args, timeoutMs);
+      if (outcome.ok)
+        return outcome.stdout;
+      return outcome.exited ? outcome.stdout : null;
+    }
+    function parseClaudeAuthStatus(stdout) {
+      let parsed;
+      try {
+        parsed = JSON.parse(stdout);
+      } catch {
+        return null;
+      }
+      if (parsed === null || typeof parsed !== "object")
+        return null;
+      const { loggedIn, authMethod, subscriptionType } = parsed;
+      if (typeof loggedIn !== "boolean")
+        return null;
+      return {
+        loggedIn,
+        authMethod: typeof authMethod === "string" && authMethod.length > 0 ? authMethod : null,
+        subscriptionType: typeof subscriptionType === "string" && subscriptionType.length > 0 ? subscriptionType : null
+      };
+    }
     function runCapturing(bin, args, timeoutMs) {
       return new Promise((resolve) => {
         let child;
         try {
           child = (0, child_process_1.spawn)(bin, args, { stdio: ["ignore", "pipe", "pipe"] });
         } catch (err) {
-          resolve({ ok: false, reason: describe(err) });
+          resolve({ ok: false, reason: describe(err), exited: false });
           return;
         }
         let stdout = "";
@@ -21640,7 +21683,7 @@ var require_probes = __commonJS({
         };
         const timer = setTimeout(() => {
           child.kill("SIGKILL");
-          settle({ ok: false, reason: `did not finish within ${Math.round(timeoutMs / 1e3)}s` });
+          settle({ ok: false, reason: `did not finish within ${Math.round(timeoutMs / 1e3)}s`, exited: false });
         }, timeoutMs);
         child.stdout?.on("data", (chunk) => {
           stdout += chunk.toString("utf8");
@@ -21650,7 +21693,7 @@ var require_probes = __commonJS({
         });
         child.on("error", (err) => {
           clearTimeout(timer);
-          settle({ ok: false, reason: describe(err) });
+          settle({ ok: false, reason: describe(err), exited: false });
         });
         child.on("close", (code, signal) => {
           clearTimeout(timer);
@@ -21660,7 +21703,8 @@ var require_probes = __commonJS({
           }
           const status = code === null ? `was killed by ${signal ?? "a signal"}` : `exited ${code}`;
           const said = stderr.split("\n").map((line) => line.trim()).find((line) => line.length > 0);
-          settle({ ok: false, reason: said ? `${status}: ${said}` : status });
+          const reason = said ? `${status}: ${said}` : status;
+          settle(code === null ? { ok: false, reason, exited: false } : { ok: false, reason, exited: true, stdout: stdout.trim() });
         });
       });
     }
@@ -26966,7 +27010,7 @@ var import_path = require("path");
 var import_promises = require("fs/promises");
 var import_yaml = __toESM(require_dist3());
 var import_shuttle = __toESM(require_dist5());
-var buildVersion = true ? "0.30.17" : pkg.version;
+var buildVersion = true ? "0.30.18" : pkg.version;
 var sifterBrand = {
   product: {
     id: "sifter",