@whittlelabs/sifter 0.30.15 → 0.30.17

package/README.md

@@ -12,7 +12,7 @@ It needs three things on the machine first:
 |---|---|---|
 | Node.js | 20 or newer | [nodejs.org](https://nodejs.org), or a version manager such as [nvm](https://github.com/nvm-sh/nvm) or [fnm](https://github.com/Schniz/fnm) |
 | git | 2.20 or newer | macOS: `xcode-select --install` (or Homebrew). Linux and WSL: your package manager, e.g. `sudo apt install git` |
-| Claude Code | 2.0 or newer, signed in | `npm install -g @anthropic-ai/claude-code`, then run `claude` once and sign in |
+| Claude Code | 2.0.45 or newer, signed in | `npm install -g @anthropic-ai/claude-code`, then run `claude` once and sign in |
 
 On a Mac without the Command Line Tools, `/usr/bin/git` is only a placeholder that asks for them. The Sifter treats that as git not working, so install them first.
 
@@ -69,6 +69,22 @@ Once the backend answers, one more line names the page it sent you to, which is
 
 Pairing writes credentials to `~/.sifter/<profile>/config.json` (mode 0600), or `~/.sifter/config.json` for the default profile.
 
+The environment also decides where a review may fetch your standards documents from: that environment's Sift API and nowhere else. A Sifter paired with production allows `https://api.sift.whittlelabs.com`; `stage` and `test` allow their own `api.sift` host, and `studio` allows `http://localhost:3008`. The Sifter finds its environment from the Jobs URL in its `sifter.yaml`, so an existing pairing needs nothing re-run. `run` and `doctor` print the list in use on their `overlay-hosts` line:
+
+```
+PASS  overlay-hosts        https://api.sift.whittlelabs.com
+```
+
+A backend this build does not know gets no default, and `overlay-hosts` warns that reviews would run without standards. Name the origin that backend signs standards URLs with under the `claude-code` executor in `sifter.yaml`. Your own list always replaces the environment's:
+
+```yaml
+executors:
+  claude-code:
+    type: claude-code
+    overlayAllowedHosts:
+      - http://box.local:3008
+```
+
 ## Run
 
 ```bash
@@ -77,6 +93,24 @@ whittle-sifter run
 
 The Sifter subscribes to your job pool and waits for review jobs. Leave it running in a terminal or wrap it in your favorite process supervisor.
 
+### What a review can do
+
+A review checks out the pull request and runs Claude Code on it. The pull request is someone else's code, so the review is held to reading:
+
+- It is offered three tools, Read, Grep and Glob, and nothing else: no shell, no edits, no network tools, no subagents.
+- It loads no Claude Code settings file, neither the repository's nor yours. Your allow rules, permission mode, hooks and plugins do not apply to reviews, and no MCP server starts.
+
+Your login still works: Claude Code keeps it in your keychain or credentials file, or reads `ANTHROPIC_API_KEY`. If instead your login or provider is configured in your Claude Code settings (an `apiKeyHelper`, or an `env` block naming Bedrock, Vertex or a custom base URL), reviews will fail as signed out. Tell the Sifter to load your user settings in its `sifter.yaml` (`~/.sifter/sifter.yaml`, or `~/.sifter/<profile>/sifter.yaml` for a named profile):
+
+```yaml
+executors:
+  claude-code:
+    type: claude-code
+    claudeSettings: user
+```
+
+With it, your allow rules apply to reviews too, so a review can read whatever they let it read. The three tools, the default permission mode and the hooks staying off still hold.
+
 ### When something goes away
 
 A running Sifter deals with Sift or `claude` going away on its own, and says what it is doing:

package/bin.js

@@ -10048,17 +10048,19 @@ var require_claude_code = __commonJS({
     var apply_1 = require_apply();
     var DEFAULT_TIMEOUT = 6e5;
     var REVIEW_TOOLS = ["Read", "Grep", "Glob"];
-    var REVIEW_RUN_ARGS = [
-      "--setting-sources",
-      "user",
-      "--strict-mcp-config",
-      "--tools",
-      REVIEW_TOOLS.join(","),
-      "--permission-mode",
-      "default",
-      "--settings",
-      JSON.stringify({ disableAllHooks: true })
-    ];
+    function reviewRunArgs(settingSources) {
+      return [
+        "--setting-sources",
+        settingSources,
+        "--strict-mcp-config",
+        "--tools",
+        REVIEW_TOOLS.join(","),
+        "--permission-mode",
+        "default",
+        "--settings",
+        JSON.stringify({ disableAllHooks: true })
+      ];
+    }
     var RETIRED_READ_TOOLS = ["LS"];
     var HOSTED_ENV_PASSTHROUGH = [
       "PATH",
@@ -10091,7 +10093,7 @@ var require_claude_code = __commonJS({
     var READINESS_TIMEOUT_MS = 12e4;
     var STDERR_LIMIT = 4e3;
     var INSTALL_REMEDY = "install Claude Code (npm install -g @anthropic-ai/claude-code) where this process can find it on PATH";
-    var LOGIN_REMEDY = "run `claude` once and sign in (or set a valid ANTHROPIC_API_KEY)";
+    var LOGIN_REMEDY = "run `claude` once and sign in (or set a valid ANTHROPIC_API_KEY); if your login or provider is configured in Claude Code settings (apiKeyHelper, or an env block), set `claudeSettings: user` on the claude-code executor, since a review loads no settings file without it";
     var LIMIT_REMEDY = "wait for the plan's usage limit to reset, or raise it";
     var SIGNED_OUT = /invalid api key|please run \/login|not (?:logged|signed) in|oauth token (?:has )?expired|authentication_error|invalid x-api-key/i;
     var OUT_OF_USAGE = /usage limit|credit balance is too low|out of (?:extra )?usage|hit your (?:\w+ )?(?:usage |spend )?limit|5-hour limit/i;
@@ -10341,8 +10343,12 @@ var require_claude_code = __commonJS({
         const outputLabel = spec.outputLabel;
         const model = modelOverride ?? this.config.model;
         const allowedTools = local ? this.config.allowedTools : checkoutScopedTools(this.config.allowedTools);
+        if (!local && this.config.claudeSettings === "user") {
+          throw new Error("claude-code: `claudeSettings: user` is for an installed Sifter whose login lives in Claude Code settings; a hosted run authenticates with the key it is handed and loads no settings");
+        }
+        const settingSources = local && this.config.claudeSettings === "user" ? "user" : "";
         return new Promise((resolve, reject) => {
-          const args = ["--print", "--output-format", "stream-json", "--verbose", ...REVIEW_RUN_ARGS];
+          const args = ["--print", "--output-format", "stream-json", "--verbose", ...reviewRunArgs(settingSources)];
           if (resumeSessionId)
             args.push("--resume", resumeSessionId);
           if (spec.outputSchema && typeof spec.outputSchema === "object" && Object.keys(spec.outputSchema).length > 0) {
@@ -10542,6 +10548,12 @@ var require_claude_code = __commonJS({
         }
         validated.keepTranscripts = config.keepTranscripts;
       }
+      if (config.claudeSettings !== void 0) {
+        if (config.claudeSettings !== "user") {
+          throw new Error('"claudeSettings" may only be "user" (leave it unset to load no settings file)');
+        }
+        validated.claudeSettings = "user";
+      }
       if (config.overlayAllowedHosts !== void 0) {
         if (!Array.isArray(config.overlayAllowedHosts) || !config.overlayAllowedHosts.every((h) => typeof h === "string")) {
           throw new Error('"overlayAllowedHosts" must be an array of strings');
@@ -12249,6 +12261,8 @@ var require_environment = __commonJS({
     Object.defineProperty(exports2, "__esModule", { value: true });
     exports2.resolveEnvironment = resolveEnvironment;
     exports2.applyEnvironment = applyEnvironment;
+    exports2.environmentPolledBy = environmentPolledBy;
+    exports2.executorDefaultsFor = executorDefaultsFor;
     exports2.isWorthReporting = isWorthReporting;
     exports2.renderEnvironmentReport = renderEnvironmentReport;
     exports2.renderVerificationLine = renderVerificationLine;
@@ -12289,6 +12303,28 @@ var require_environment = __commonJS({
         }
       };
     }
+    function environmentPolledBy(brand, jobsApiUrl) {
+      const wanted = normalizeUrl(jobsApiUrl);
+      for (const [name, entry] of Object.entries(brand.environments ?? {})) {
+        if (normalizeUrl(entry.jobsApiUrl) === wanted)
+          return name;
+      }
+      return null;
+    }
+    function executorDefaultsFor(brand, jobsApiUrl) {
+      const name = environmentPolledBy(brand, jobsApiUrl);
+      const tier = name === null ? void 0 : brand.environments?.[name]?.executorDefaults;
+      if (!tier)
+        return brand.executorDefaults;
+      const merged = { ...brand.executorDefaults ?? {} };
+      for (const [executor, settings] of Object.entries(tier)) {
+        merged[executor] = { ...merged[executor] ?? {}, ...settings };
+      }
+      return merged;
+    }
+    function normalizeUrl(url) {
+      return url.replace(/\/+$/, "").toLowerCase();
+    }
     function isWorthReporting(resolved) {
       return resolved.environment !== null || resolved.keep.source === "flag" || resolved.jobs.source === "flag";
     }
@@ -12436,7 +12472,7 @@ var require_checks = __commonJS({
       const user = config.executors[WORKSPACE_EXECUTOR];
       if (user === void 0)
         return null;
-      const defaults = subject.brand.executorDefaults?.[WORKSPACE_EXECUTOR] ?? {};
+      const defaults = (0, environment_1.executorDefaultsFor)(subject.brand, config.auth.jobsApiUrl)?.[WORKSPACE_EXECUTOR] ?? {};
       return { ...defaults, ...user };
     }
     function runRoot(config, subject, osTmpDir) {
@@ -12473,7 +12509,7 @@ var require_checks = __commonJS({
         return (0, apply_1.expandHome)(subject.requestedTmpDir);
       }
       const settings = {
-        ...subject.brand.executorDefaults?.[WORKSPACE_EXECUTOR] ?? {},
+        ...(0, environment_1.executorDefaultsFor)(subject.brand, subject.brand.keepRegistration.jobsApiUrl)?.[WORKSPACE_EXECUTOR] ?? {},
         ...plan.keptBlock ?? {}
       };
       const tmpDir = settings.tmpDir;
@@ -12811,7 +12847,8 @@ var require_checks = __commonJS({
           const hosts = settings.overlayAllowedHosts;
           const origins = Array.isArray(hosts) ? hosts.filter((h) => typeof h === "string") : [];
           if (origins.length === 0) {
-            return warn("overlay-hosts", "the overlay allowlist is empty, so every review will run standards-blind", `add overlayAllowedHosts to the ${WORKSPACE_EXECUTOR} executor, or re-run init to restore the defaults`);
+            const fallback = (0, environment_1.executorDefaultsFor)(subject.brand, config.auth.jobsApiUrl)?.[WORKSPACE_EXECUTOR]?.overlayAllowedHosts;
+            return warn("overlay-hosts", "the overlay allowlist is empty, so every review will run standards-blind", Array.isArray(fallback) && fallback.length > 0 ? `remove overlayAllowedHosts from the ${WORKSPACE_EXECUTOR} executor to use this tier's default` : `add overlayAllowedHosts to the ${WORKSPACE_EXECUTOR} executor, naming the origin your backend signs standards URLs with (this build names none for Jobs at ${(0, environment_1.hostOf)(config.auth.jobsApiUrl)})`);
           }
           return pass("overlay-hosts", origins.join(", "));
         });
@@ -12892,7 +12929,7 @@ var require_checks = __commonJS({
     };
     function mergedExecutorConfigs(config, subject) {
       const user = config.executors;
-      const defaults = subject.brand.executorDefaults;
+      const defaults = (0, environment_1.executorDefaultsFor)(subject.brand, config.auth.jobsApiUrl);
       if (!defaults)
         return user;
       const merged = {};
@@ -25738,6 +25775,7 @@ var require_shuttle = __commonJS({
     var output_gates_1 = require_output_gates();
     var keep_1 = require_dist2();
     var apply_1 = require_apply();
+    var environment_1 = require_environment();
     var version_check_1 = require_version_check();
     var typed_exit_1 = require_typed_exit();
     var logger_1 = require_logger();
@@ -25939,7 +25977,7 @@ var require_shuttle = __commonJS({
         });
         const registry = new registry_1.ExecutorRegistry(this.brand.executorAllowlist);
         registerBuiltInExecutors(registry, this.brand.executorAllowlist);
-        const executors = registry.build(mergeExecutorDefaults(this.brand.executorDefaults, this.config.executors));
+        const executors = registry.build(mergeExecutorDefaults((0, environment_1.executorDefaultsFor)(this.brand, this.config.auth.jobsApiUrl), this.config.executors));
         const byStrategy = /* @__PURE__ */ new Map();
         for (const executor of executors) {
           for (const strategy of executor.strategies)
@@ -26722,8 +26760,8 @@ var require_dist5 = __commonJS({
   "../../packages/shuttle/dist/index.js"(exports2) {
     "use strict";
     Object.defineProperty(exports2, "__esModule", { value: true });
-    exports2.scaffoldedConfigPath = exports2.planScaffold = exports2.DEFAULT_REFUSAL_MESSAGE = exports2.DEFAULT_MONTHLY_PERIOD = exports2.DEFAULT_DAILY_PERIOD = exports2.SUBSTRATE_BRAND = exports2.verificationJson = exports2.resolveEnvironment = exports2.renderVerificationLine = exports2.renderEnvironmentReport = exports2.isWorthReporting = exports2.hostOf = exports2.environmentReportJson = exports2.applyEnvironment = exports2.renderTemplate = exports2.expandHome = exports2.resolvePaths = exports2.SpendStore = exports2.AuditLogStore = exports2.createSpendTrackerObserver = exports2.createAuditLogObserver = exports2.createLoggerObserver = exports2.SpendCapExceeded = exports2.ObserverChain = exports2.createCustomScriptExecutor = exports2.createWebhookExecutor = exports2.createHttpApiExecutor = exports2.createClaudeCodeExecutor = exports2.ExecutorEnvironmentError = exports2.ExecutorRegistry = exports2.AgentCredentialRevokedError = exports2.runPreflight = exports2.renderLines = exports2.renderJson = exports2.printReport = exports2.hasFailure = exports2.createProbes = exports2.checksFor = exports2.PREFLIGHT_FLOORS = exports2.PREFLIGHT_EXIT_CODE = exports2.CHECKS = exports2.readResponseLatestVersion = exports2.checkResponseMinVersion = exports2.compareSemver = exports2.UpgradeRequiredError = exports2.LATEST_VERSION_HEADER = exports2.MIN_VERSION_HEADER = exports2.loadConfig = exports2.Shuttle = exports2.createCli = void 0;
-    exports2.revokePairing = exports2.listPairings = exports2.PairingConfigStore = exports2.pair = void 0;
+    exports2.DEFAULT_REFUSAL_MESSAGE = exports2.DEFAULT_MONTHLY_PERIOD = exports2.DEFAULT_DAILY_PERIOD = exports2.SUBSTRATE_BRAND = exports2.verificationJson = exports2.resolveEnvironment = exports2.renderVerificationLine = exports2.renderEnvironmentReport = exports2.isWorthReporting = exports2.hostOf = exports2.executorDefaultsFor = exports2.environmentReportJson = exports2.environmentPolledBy = exports2.applyEnvironment = exports2.renderTemplate = exports2.expandHome = exports2.resolvePaths = exports2.SpendStore = exports2.AuditLogStore = exports2.createSpendTrackerObserver = exports2.createAuditLogObserver = exports2.createLoggerObserver = exports2.SpendCapExceeded = exports2.ObserverChain = exports2.createCustomScriptExecutor = exports2.createWebhookExecutor = exports2.createHttpApiExecutor = exports2.createClaudeCodeExecutor = exports2.ExecutorEnvironmentError = exports2.ExecutorRegistry = exports2.AgentCredentialRevokedError = exports2.runPreflight = exports2.renderLines = exports2.renderJson = exports2.printReport = exports2.hasFailure = exports2.createProbes = exports2.checksFor = exports2.PREFLIGHT_FLOORS = exports2.PREFLIGHT_EXIT_CODE = exports2.CHECKS = exports2.readResponseLatestVersion = exports2.checkResponseMinVersion = exports2.compareSemver = exports2.UpgradeRequiredError = exports2.LATEST_VERSION_HEADER = exports2.MIN_VERSION_HEADER = exports2.loadConfig = exports2.Shuttle = exports2.createCli = void 0;
+    exports2.revokePairing = exports2.listPairings = exports2.PairingConfigStore = exports2.pair = exports2.scaffoldedConfigPath = exports2.planScaffold = void 0;
     var cli_1 = require_cli();
     Object.defineProperty(exports2, "createCli", { enumerable: true, get: function() {
       return cli_1.createCli;
@@ -26855,9 +26893,15 @@ var require_dist5 = __commonJS({
     Object.defineProperty(exports2, "applyEnvironment", { enumerable: true, get: function() {
       return environment_1.applyEnvironment;
     } });
+    Object.defineProperty(exports2, "environmentPolledBy", { enumerable: true, get: function() {
+      return environment_1.environmentPolledBy;
+    } });
     Object.defineProperty(exports2, "environmentReportJson", { enumerable: true, get: function() {
       return environment_1.environmentReportJson;
     } });
+    Object.defineProperty(exports2, "executorDefaultsFor", { enumerable: true, get: function() {
+      return environment_1.executorDefaultsFor;
+    } });
     Object.defineProperty(exports2, "hostOf", { enumerable: true, get: function() {
       return environment_1.hostOf;
     } });
@@ -26922,7 +26966,7 @@ var import_path = require("path");
 var import_promises = require("fs/promises");
 var import_yaml = __toESM(require_dist3());
 var import_shuttle = __toESM(require_dist5());
-var buildVersion = true ? "0.30.15" : pkg.version;
+var buildVersion = true ? "0.30.17" : pkg.version;
 var sifterBrand = {
   product: {
     id: "sifter",
@@ -26963,24 +27007,12 @@ var sifterBrand = {
     git: "2.20.0",
     claude: "2.0.45"
   },
-  // Overlay-fetch origins for the signed standards-content URLs each Sift
-  // tier signs (SIFT_PUBLIC_API_URL). Without these, the executor's SSRF
-  // guard silently skips the standards overlay and every review runs
-  // standards-blind (2026-07-13). User config overrides per key.
+  // The overlay-fetch allowlist is NOT here: each tier signs its standards
+  // URLs with its own Sift origin (SIFT_PUBLIC_API_URL), so the origin is a
+  // property of the tier and lives on its `environments` entry below. A
+  // Sifter paired to production allows production's origin and nothing else.
   executorDefaults: {
     "claude-code": {
-      overlayAllowedHosts: [
-        "https://api.sift.whittlelabs.com",
-        "https://api.sift.stage.whittlelabs.com",
-        // The test tier signs overlay URLs too, and a Sifter the E2E suite
-        // runs on the runner reaches Sift by this host rather than by the
-        // in-cluster service name the hosted worker uses. Without it that
-        // Sifter passes its own preflight — the check asks only that the list
-        // is non-empty — and then runs every review standards-blind, which is
-        // the exact silence of 2026-07-13.
-        "https://api.sift.test.whittlelabs.com",
-        "http://localhost:3008"
-      ],
       // Transcript retention is a diagnostic switch a person flips for one
       // session, so it rides the environment rather than a file they would
       // have to remember to unset. The shared package reads no env of its
@@ -27004,22 +27036,40 @@ var sifterBrand = {
   // `studio` is the local dev fleet on this machine, reachable over Tailscale
   // at the `studio.whittlelabs.com` hostname rather than `localhost`, because
   // a pairing made from a phone or a second machine has to resolve too.
+  //
+  // Each entry also carries the origin that tier signs overlay URLs with.
+  // A run matches its tier by the Jobs URL its config polls (written from the
+  // pairing, and held equal to it by `pairing-environment`), so an existing
+  // pairing picks up its own tier's origin without re-pairing, and a user's
+  // own `overlayAllowedHosts` still wins. Without the right origin the
+  // executor's SSRF guard silently skips the standards overlay and every
+  // review runs standards-blind (2026-07-13); tests/overlay-hosts.test.ts
+  // holds every tier to naming its own.
   environments: {
     prod: {
       keepApiUrl: "https://keep.whittlelabs.com",
-      jobsApiUrl: "https://jobs.whittlelabs.com"
+      jobsApiUrl: "https://jobs.whittlelabs.com",
+      executorDefaults: overlayOrigin("https://api.sift.whittlelabs.com")
     },
     stage: {
       keepApiUrl: "https://keep.stage.whittlelabs.com",
-      jobsApiUrl: "https://jobs.stage.whittlelabs.com"
+      jobsApiUrl: "https://jobs.stage.whittlelabs.com",
+      executorDefaults: overlayOrigin("https://api.sift.stage.whittlelabs.com")
     },
     test: {
       keepApiUrl: "https://keep.test.whittlelabs.com",
-      jobsApiUrl: "https://jobs.test.whittlelabs.com"
+      jobsApiUrl: "https://jobs.test.whittlelabs.com",
+      // The public host, because a Sifter the E2E suite runs on the runner
+      // reaches Sift by it rather than by the in-cluster service name the
+      // test tier's hosted worker uses (that worker sets its own list).
+      executorDefaults: overlayOrigin("https://api.sift.test.whittlelabs.com")
     },
     studio: {
       keepApiUrl: "http://studio.whittlelabs.com:3007",
-      jobsApiUrl: "http://studio.whittlelabs.com:3005"
+      jobsApiUrl: "http://studio.whittlelabs.com:3005",
+      // The dev fleet's Sift signs with SIFT_PUBLIC_API_URL from its .env,
+      // which is localhost.
+      executorDefaults: overlayOrigin("http://localhost:3008")
     }
   },
   keepRegistration: {
@@ -27107,6 +27157,9 @@ var sifterBrand = {
     }
   ]
 };
+function overlayOrigin(origin) {
+  return { "claude-code": { overlayAllowedHosts: [origin] } };
+}
 async function buildExecutorBlock(executor, ctx) {
   switch (executor) {
     case "claude-code": {