@whereby.com/media 8.2.1 → 8.2.3

package/dist/index.cjs

@@ -544,25 +544,22 @@ class Session {
             this.pc.addTrack(track, stream);
         });
     }
-    addTrack(track, stream) {
+    addTrack(track) {
         var _a;
         if (track.kind === "video" && ((_a = this._mediaPrefs) === null || _a === void 0 ? void 0 : _a.wantsVideo) === false) {
             return;
         }
-        if (!stream) {
-            stream = this.streams[0];
-        }
+        const stream = this.streams[0];
+        this._incrementAnalyticMetric("P2PSessionAddTrack");
+        rtcStats.sendEvent("P2PSessionAddTrack", {
+            trackId: track.id,
+            kind: track.kind,
+            hasSessionStream: !!stream,
+            trackOfSameKindInStream: !!(stream === null || stream === void 0 ? void 0 : stream.getTracks().filter((t) => t.kind === track.kind && t.id !== track.id).length),
+        });
         stream === null || stream === void 0 ? void 0 : stream.addTrack(track);
         this.pc.addTrack(track, stream);
     }
-    removeTrack(track) {
-        const stream = this.streams[0];
-        stream.removeTrack(track);
-        const sender = this.pc.getSenders().find((sender) => sender.track === track);
-        if (sender) {
-            this.pc.removeTrack(sender);
-        }
-    }
     removeStream(stream) {
         const streamIdIndex = this.streamIds.indexOf(stream.id);
         if (streamIdIndex !== -1) {
@@ -2543,6 +2540,8 @@ class P2pRtcManager {
             P2PMicNotWorking: 0,
             P2PLocalNetworkFailed: 0,
             P2PRelayedIceCandidate: 0,
+            P2PSessionAddTrack: 0,
+            P2PAddTrackToPeerConnections: 0,
         };
     }
     numberOfPeerconnections() {
@@ -2836,7 +2835,6 @@ class P2pRtcManager {
         return this.peerConnections[clientId];
     }
     _createSession({ clientId, initialBandwidth, isOfferer }) {
-        var _a, _b;
         if (!clientId) {
             throw new Error("clientId is missing");
         }
@@ -3099,8 +3097,8 @@ class P2pRtcManager {
         if (this._features.increaseIncomingMediaBufferOn) {
             this._setJitterBufferTarget(pc);
         }
-        if (((_b = (_a = this._localCameraStream) === null || _a === void 0 ? void 0 : _a.getVideoTracks()) === null || _b === void 0 ? void 0 : _b.length) && this._stoppedVideoTrack) {
-            session.addTrack(this._stoppedVideoTrack, this._localCameraStream);
+        if (this._localCameraStream && !this._localCameraStream.getVideoTracks().length && this._stoppedVideoTrack) {
+            pc.addTrack(this._stoppedVideoTrack, this._localCameraStream);
         }
         return session;
     }
@@ -3124,9 +3122,15 @@ class P2pRtcManager {
             this._withForcedRenegotiation(session, () => session.addStream(stream));
         });
     }
-    _addTrackToPeerConnections(track, stream) {
+    _addTrackToPeerConnections(track) {
+        this.analytics.P2PAddTrackToPeerConnections++;
+        rtcStats.sendEvent("P2PAddTrackToPeerConnections", {
+            trackId: track.id,
+            kind: track.kind,
+            readyState: track.readyState,
+        });
         this._forEachPeerConnection((session) => {
-            this._withForcedRenegotiation(session, () => session.addTrack(track, stream));
+            this._withForcedRenegotiation(session, () => session.addTrack(track));
         });
     }
     _replaceTrackToPeerConnections(oldTrack, newTrack) {
@@ -3162,11 +3166,6 @@ class P2pRtcManager {
             this._withForcedRenegotiation(session, () => session.removeStream(stream));
         });
     }
-    _removeTrackFromPeerConnections(track) {
-        this._forEachPeerConnection((session) => {
-            this._withForcedRenegotiation(session, () => session.removeTrack(track));
-        });
-    }
     _updateAndScheduleMediaServersRefresh({ iceServers, turnServers, mediaserverConfigTtlSeconds, }) {
         this._iceServers = iceServers;
         this._turnServers = turnServers;

package/dist/index.d.cts

@@ -1294,8 +1294,7 @@ declare class Session {
     pendingReplaceTrackActions: (() => Promise<void>)[];
     constructor({ clientId, bandwidth, peerConnectionConfig, deprioritizeH264Encoding, incrementAnalyticMetric, mediaPrefs, }: P2PSessionOptions);
     addStream(stream: MediaStream): void;
-    addTrack(track: MediaStreamTrack, stream?: MediaStream): void;
-    removeTrack(track: MediaStreamTrack): void;
+    addTrack(track: MediaStreamTrack): void;
     removeStream(stream: MediaStream): void;
     _setRemoteDescription(desc: SignalRTCSessionDescription): Promise<void>;
     handleOffer(offer: SignalRTCSessionDescription): Promise<SignalRTCSessionDescription>;
@@ -1345,6 +1344,8 @@ type P2PAnalytics = {
     P2PMicNotWorking: number;
     P2PLocalNetworkFailed: number;
     P2PRelayedIceCandidate: number;
+    P2PSessionAddTrack: number;
+    P2PAddTrackToPeerConnections: number;
 };
 type P2PAnalyticMetric = keyof P2PAnalytics;
 type P2PIncrementAnalyticMetric = (metric: P2PAnalyticMetric) => void;
@@ -1416,10 +1417,9 @@ declare class P2pRtcManager implements RtcManager {
     _cleanup(clientId: string): void;
     _forEachPeerConnection(func: any): void;
     _addStreamToPeerConnections(stream: MediaStream): void;
-    _addTrackToPeerConnections(track: MediaStreamTrack, stream?: MediaStream): void;
+    _addTrackToPeerConnections(track: MediaStreamTrack): void;
     _replaceTrackToPeerConnections(oldTrack: any, newTrack: any): Promise<void | any[]>;
     _removeStreamFromPeerConnections(stream: MediaStream): void;
-    _removeTrackFromPeerConnections(track: MediaStreamTrack): void;
     _updateAndScheduleMediaServersRefresh({ iceServers, turnServers, mediaserverConfigTtlSeconds, }: SignalMediaServerConfig): void;
     _clearMediaServersRefresh(): void;
     _monitorAudioTrack(track: MediaStreamTrack): void;

package/dist/index.d.mts

@@ -1294,8 +1294,7 @@ declare class Session {
     pendingReplaceTrackActions: (() => Promise<void>)[];
     constructor({ clientId, bandwidth, peerConnectionConfig, deprioritizeH264Encoding, incrementAnalyticMetric, mediaPrefs, }: P2PSessionOptions);
     addStream(stream: MediaStream): void;
-    addTrack(track: MediaStreamTrack, stream?: MediaStream): void;
-    removeTrack(track: MediaStreamTrack): void;
+    addTrack(track: MediaStreamTrack): void;
     removeStream(stream: MediaStream): void;
     _setRemoteDescription(desc: SignalRTCSessionDescription): Promise<void>;
     handleOffer(offer: SignalRTCSessionDescription): Promise<SignalRTCSessionDescription>;
@@ -1345,6 +1344,8 @@ type P2PAnalytics = {
     P2PMicNotWorking: number;
     P2PLocalNetworkFailed: number;
     P2PRelayedIceCandidate: number;
+    P2PSessionAddTrack: number;
+    P2PAddTrackToPeerConnections: number;
 };
 type P2PAnalyticMetric = keyof P2PAnalytics;
 type P2PIncrementAnalyticMetric = (metric: P2PAnalyticMetric) => void;
@@ -1416,10 +1417,9 @@ declare class P2pRtcManager implements RtcManager {
     _cleanup(clientId: string): void;
     _forEachPeerConnection(func: any): void;
     _addStreamToPeerConnections(stream: MediaStream): void;
-    _addTrackToPeerConnections(track: MediaStreamTrack, stream?: MediaStream): void;
+    _addTrackToPeerConnections(track: MediaStreamTrack): void;
     _replaceTrackToPeerConnections(oldTrack: any, newTrack: any): Promise<void | any[]>;
     _removeStreamFromPeerConnections(stream: MediaStream): void;
-    _removeTrackFromPeerConnections(track: MediaStreamTrack): void;
     _updateAndScheduleMediaServersRefresh({ iceServers, turnServers, mediaserverConfigTtlSeconds, }: SignalMediaServerConfig): void;
     _clearMediaServersRefresh(): void;
     _monitorAudioTrack(track: MediaStreamTrack): void;

package/dist/index.d.ts

@@ -1294,8 +1294,7 @@ declare class Session {
     pendingReplaceTrackActions: (() => Promise<void>)[];
     constructor({ clientId, bandwidth, peerConnectionConfig, deprioritizeH264Encoding, incrementAnalyticMetric, mediaPrefs, }: P2PSessionOptions);
     addStream(stream: MediaStream): void;
-    addTrack(track: MediaStreamTrack, stream?: MediaStream): void;
-    removeTrack(track: MediaStreamTrack): void;
+    addTrack(track: MediaStreamTrack): void;
     removeStream(stream: MediaStream): void;
     _setRemoteDescription(desc: SignalRTCSessionDescription): Promise<void>;
     handleOffer(offer: SignalRTCSessionDescription): Promise<SignalRTCSessionDescription>;
@@ -1345,6 +1344,8 @@ type P2PAnalytics = {
     P2PMicNotWorking: number;
     P2PLocalNetworkFailed: number;
     P2PRelayedIceCandidate: number;
+    P2PSessionAddTrack: number;
+    P2PAddTrackToPeerConnections: number;
 };
 type P2PAnalyticMetric = keyof P2PAnalytics;
 type P2PIncrementAnalyticMetric = (metric: P2PAnalyticMetric) => void;
@@ -1416,10 +1417,9 @@ declare class P2pRtcManager implements RtcManager {
     _cleanup(clientId: string): void;
     _forEachPeerConnection(func: any): void;
     _addStreamToPeerConnections(stream: MediaStream): void;
-    _addTrackToPeerConnections(track: MediaStreamTrack, stream?: MediaStream): void;
+    _addTrackToPeerConnections(track: MediaStreamTrack): void;
     _replaceTrackToPeerConnections(oldTrack: any, newTrack: any): Promise<void | any[]>;
     _removeStreamFromPeerConnections(stream: MediaStream): void;
-    _removeTrackFromPeerConnections(track: MediaStreamTrack): void;
     _updateAndScheduleMediaServersRefresh({ iceServers, turnServers, mediaserverConfigTtlSeconds, }: SignalMediaServerConfig): void;
     _clearMediaServersRefresh(): void;
     _monitorAudioTrack(track: MediaStreamTrack): void;

package/dist/index.mjs

@@ -523,25 +523,22 @@ class Session {
             this.pc.addTrack(track, stream);
         });
     }
-    addTrack(track, stream) {
+    addTrack(track) {
         var _a;
         if (track.kind === "video" && ((_a = this._mediaPrefs) === null || _a === void 0 ? void 0 : _a.wantsVideo) === false) {
             return;
         }
-        if (!stream) {
-            stream = this.streams[0];
-        }
+        const stream = this.streams[0];
+        this._incrementAnalyticMetric("P2PSessionAddTrack");
+        rtcStats.sendEvent("P2PSessionAddTrack", {
+            trackId: track.id,
+            kind: track.kind,
+            hasSessionStream: !!stream,
+            trackOfSameKindInStream: !!(stream === null || stream === void 0 ? void 0 : stream.getTracks().filter((t) => t.kind === track.kind && t.id !== track.id).length),
+        });
         stream === null || stream === void 0 ? void 0 : stream.addTrack(track);
         this.pc.addTrack(track, stream);
     }
-    removeTrack(track) {
-        const stream = this.streams[0];
-        stream.removeTrack(track);
-        const sender = this.pc.getSenders().find((sender) => sender.track === track);
-        if (sender) {
-            this.pc.removeTrack(sender);
-        }
-    }
     removeStream(stream) {
         const streamIdIndex = this.streamIds.indexOf(stream.id);
         if (streamIdIndex !== -1) {
@@ -2522,6 +2519,8 @@ class P2pRtcManager {
             P2PMicNotWorking: 0,
             P2PLocalNetworkFailed: 0,
             P2PRelayedIceCandidate: 0,
+            P2PSessionAddTrack: 0,
+            P2PAddTrackToPeerConnections: 0,
         };
     }
     numberOfPeerconnections() {
@@ -2815,7 +2814,6 @@ class P2pRtcManager {
         return this.peerConnections[clientId];
     }
     _createSession({ clientId, initialBandwidth, isOfferer }) {
-        var _a, _b;
         if (!clientId) {
             throw new Error("clientId is missing");
         }
@@ -3078,8 +3076,8 @@ class P2pRtcManager {
         if (this._features.increaseIncomingMediaBufferOn) {
             this._setJitterBufferTarget(pc);
         }
-        if (((_b = (_a = this._localCameraStream) === null || _a === void 0 ? void 0 : _a.getVideoTracks()) === null || _b === void 0 ? void 0 : _b.length) && this._stoppedVideoTrack) {
-            session.addTrack(this._stoppedVideoTrack, this._localCameraStream);
+        if (this._localCameraStream && !this._localCameraStream.getVideoTracks().length && this._stoppedVideoTrack) {
+            pc.addTrack(this._stoppedVideoTrack, this._localCameraStream);
         }
         return session;
     }
@@ -3103,9 +3101,15 @@ class P2pRtcManager {
             this._withForcedRenegotiation(session, () => session.addStream(stream));
         });
     }
-    _addTrackToPeerConnections(track, stream) {
+    _addTrackToPeerConnections(track) {
+        this.analytics.P2PAddTrackToPeerConnections++;
+        rtcStats.sendEvent("P2PAddTrackToPeerConnections", {
+            trackId: track.id,
+            kind: track.kind,
+            readyState: track.readyState,
+        });
         this._forEachPeerConnection((session) => {
-            this._withForcedRenegotiation(session, () => session.addTrack(track, stream));
+            this._withForcedRenegotiation(session, () => session.addTrack(track));
         });
     }
     _replaceTrackToPeerConnections(oldTrack, newTrack) {
@@ -3141,11 +3145,6 @@ class P2pRtcManager {
             this._withForcedRenegotiation(session, () => session.removeStream(stream));
         });
     }
-    _removeTrackFromPeerConnections(track) {
-        this._forEachPeerConnection((session) => {
-            this._withForcedRenegotiation(session, () => session.removeTrack(track));
-        });
-    }
     _updateAndScheduleMediaServersRefresh({ iceServers, turnServers, mediaserverConfigTtlSeconds, }) {
         this._iceServers = iceServers;
         this._turnServers = turnServers;

package/dist/legacy-esm.js

@@ -523,25 +523,22 @@ class Session {
             this.pc.addTrack(track, stream);
         });
     }
-    addTrack(track, stream) {
+    addTrack(track) {
         var _a;
         if (track.kind === "video" && ((_a = this._mediaPrefs) === null || _a === void 0 ? void 0 : _a.wantsVideo) === false) {
             return;
         }
-        if (!stream) {
-            stream = this.streams[0];
-        }
+        const stream = this.streams[0];
+        this._incrementAnalyticMetric("P2PSessionAddTrack");
+        rtcStats.sendEvent("P2PSessionAddTrack", {
+            trackId: track.id,
+            kind: track.kind,
+            hasSessionStream: !!stream,
+            trackOfSameKindInStream: !!(stream === null || stream === void 0 ? void 0 : stream.getTracks().filter((t) => t.kind === track.kind && t.id !== track.id).length),
+        });
         stream === null || stream === void 0 ? void 0 : stream.addTrack(track);
         this.pc.addTrack(track, stream);
     }
-    removeTrack(track) {
-        const stream = this.streams[0];
-        stream.removeTrack(track);
-        const sender = this.pc.getSenders().find((sender) => sender.track === track);
-        if (sender) {
-            this.pc.removeTrack(sender);
-        }
-    }
     removeStream(stream) {
         const streamIdIndex = this.streamIds.indexOf(stream.id);
         if (streamIdIndex !== -1) {
@@ -2522,6 +2519,8 @@ class P2pRtcManager {
             P2PMicNotWorking: 0,
             P2PLocalNetworkFailed: 0,
             P2PRelayedIceCandidate: 0,
+            P2PSessionAddTrack: 0,
+            P2PAddTrackToPeerConnections: 0,
         };
     }
     numberOfPeerconnections() {
@@ -2815,7 +2814,6 @@ class P2pRtcManager {
         return this.peerConnections[clientId];
     }
     _createSession({ clientId, initialBandwidth, isOfferer }) {
-        var _a, _b;
         if (!clientId) {
             throw new Error("clientId is missing");
         }
@@ -3078,8 +3076,8 @@ class P2pRtcManager {
         if (this._features.increaseIncomingMediaBufferOn) {
             this._setJitterBufferTarget(pc);
         }
-        if (((_b = (_a = this._localCameraStream) === null || _a === void 0 ? void 0 : _a.getVideoTracks()) === null || _b === void 0 ? void 0 : _b.length) && this._stoppedVideoTrack) {
-            session.addTrack(this._stoppedVideoTrack, this._localCameraStream);
+        if (this._localCameraStream && !this._localCameraStream.getVideoTracks().length && this._stoppedVideoTrack) {
+            pc.addTrack(this._stoppedVideoTrack, this._localCameraStream);
         }
         return session;
     }
@@ -3103,9 +3101,15 @@ class P2pRtcManager {
             this._withForcedRenegotiation(session, () => session.addStream(stream));
         });
     }
-    _addTrackToPeerConnections(track, stream) {
+    _addTrackToPeerConnections(track) {
+        this.analytics.P2PAddTrackToPeerConnections++;
+        rtcStats.sendEvent("P2PAddTrackToPeerConnections", {
+            trackId: track.id,
+            kind: track.kind,
+            readyState: track.readyState,
+        });
         this._forEachPeerConnection((session) => {
-            this._withForcedRenegotiation(session, () => session.addTrack(track, stream));
+            this._withForcedRenegotiation(session, () => session.addTrack(track));
         });
     }
     _replaceTrackToPeerConnections(oldTrack, newTrack) {
@@ -3141,11 +3145,6 @@ class P2pRtcManager {
             this._withForcedRenegotiation(session, () => session.removeStream(stream));
         });
     }
-    _removeTrackFromPeerConnections(track) {
-        this._forEachPeerConnection((session) => {
-            this._withForcedRenegotiation(session, () => session.removeTrack(track));
-        });
-    }
     _updateAndScheduleMediaServersRefresh({ iceServers, turnServers, mediaserverConfigTtlSeconds, }) {
         this._iceServers = iceServers;
         this._turnServers = turnServers;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@whereby.com/media",
   "description": "Media library for Whereby",
-  "version": "8.2.1",
+  "version": "8.2.3",
   "license": "MIT",
   "homepage": "https://github.com/whereby/sdk",
   "repository": {