@whereby.com/media 2.8.4 → 2.8.6

package/dist/index.cjs

@@ -2019,7 +2019,7 @@ const adapter$5 = (_a$5 = adapterRaw.default) !== null && _a$5 !== void 0 ? _a$5
 const logger$8 = new Logger();
 const browserName$2 = (_b$2 = adapter$5.browserDetails) === null || _b$2 === void 0 ? void 0 : _b$2.browser;
 const browserVersion$1 = adapter$5.browserDetails.version;
-function setCodecPreferenceSDP(sdp, redOn) {
+function setCodecPreferenceSDP({ sdp, redOn, incrementAnalyticMetric }) {
     var _a, _b;
     try {
         const sdpObject = sdpTransform__namespace.parse(sdp);
@@ -2057,7 +2057,10 @@ function setCodecPreferenceSDP(sdp, redOn) {
         return newSdp;
     }
     catch (error) {
+        incrementAnalyticMetric("P2PSetCodecPreferenceError");
+        rtcStats.sendEvent("P2PSetCodecPreferenceError", { error });
         logger$8.error("setCodecPreferenceSDP error:", error);
+        return sdp;
     }
 }
 function cleanSdp(sdp) {
@@ -2345,25 +2348,36 @@ class Session {
             this.earlyIceCandidates = [];
         });
     }
-    handleOffer(message) {
+    handleOffer(offer) {
         if (!this.canModifyPeerConnection()) {
             return new Promise((resolve) => {
-                this.pending.push(() => this.handleOffer(message).then(resolve));
+                this.pending.push(() => this.handleOffer(offer).then(resolve));
             });
         }
         this.isOperationPending = true;
-        let sdp = message.sdp;
+        let sdp = offer.sdp;
         sdp = filterMidExtension(sdp);
         sdp = filterMsidSemantic(sdp);
-        const desc = { type: message.type, sdp };
+        const desc = { type: offer.type, sdp };
         let answerToSignal;
         return this._setRemoteDescription(desc)
             .then(() => {
             return this.pc.createAnswer();
         })
             .then((answer) => {
-            answerToSignal = answer;
-            return this.pc.setLocalDescription(answer);
+            if (!answer.sdp) {
+                this._incrementAnalyticMetric("P2PCreateAnswerNoSDP");
+                rtcStats.sendEvent("P2PCreateAnswerNoSDP", {});
+                throw new Error("SDP undefined while creating answer");
+            }
+            else {
+                answerToSignal = {
+                    sdp: answer.sdp,
+                    sdpU: answer.sdp,
+                    type: answer.type,
+                };
+                return this.pc.setLocalDescription(answer);
+            }
         })
             .then(() => {
             return setVideoBandwidthUsingSetParameters(this.pc, this.bandwidth);
@@ -2683,6 +2697,9 @@ class P2pRtcManager {
             P2PReplaceTrackSourceKindNotFound: 0,
             P2PRemoveStreamNoPC: 0,
             P2POnTrackNoStream: 0,
+            P2PSetCodecPreferenceError: 0,
+            P2PCreateOfferNoSDP: 0,
+            P2PCreateAnswerNoSDP: 0,
         };
     }
     numberOfPeerconnections() {
@@ -2803,13 +2820,16 @@ class P2pRtcManager {
                     logger$6.warn("No RTCPeerConnection on SDP_OFFER", data);
                     return;
                 }
-                const offer = this._transformIncomingSdp(data.message);
+                const sdp = {
+                    sdp: data.message.sdp || data.message.sdpU,
+                    type: data.message.type,
+                };
                 (_b = (_a = session
-                    .handleOffer(offer)
+                    .handleOffer(sdp)
                     .then((answer) => {
                     this._emitServerEvent(RELAY_MESSAGES.SDP_ANSWER, {
                         receiverId: data.clientId,
-                        message: this._transformOutgoingSdp(answer),
+                        message: answer,
                     });
                 })).catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
                     this.analytics.numPcOnOfferFailure++;
@@ -2822,8 +2842,11 @@ class P2pRtcManager {
                     logger$6.warn("No RTCPeerConnection on SDP_ANSWER", data);
                     return;
                 }
-                const answer = this._transformIncomingSdp(data.message);
-                (_b = (_a = session.handleAnswer(answer)) === null || _a === void 0 ? void 0 : _a.catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
+                const sdp = {
+                    sdp: data.message.sdp || data.message.sdpU,
+                    type: data.message.type,
+                };
+                (_b = (_a = session.handleAnswer(sdp)) === null || _a === void 0 ? void 0 : _a.catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
                     logger$6.warn("Could not set remote description from remote answer: ", e);
                     this.analytics.numPcOnAnswerFailure++;
                 });
@@ -3002,13 +3025,6 @@ class P2pRtcManager {
         const streamIds = this._getNonLocalCameraStreamIds();
         return streamIds.length === 0 ? null : this.localStreams[streamIds[0]];
     }
-    _transformIncomingSdp(original) {
-        const sdp = original.sdp ? original.sdp : original.sdpU;
-        return { type: original.type, sdp };
-    }
-    _transformOutgoingSdp(original) {
-        return { type: original.type, sdpU: original.sdp, sdp: original.sdp };
-    }
     _createSession({ clientId, initialBandwidth, isOfferer, peerConnectionId, }) {
         if (!peerConnectionId) {
             throw new Error("peerConnectionId is missing");
@@ -3373,10 +3389,19 @@ class P2pRtcManager {
         this._setCodecPreferences(pc).then(() => pc
             .createOffer(constraints || this.offerOptions)
             .then((offer) => {
+            if (!offer.sdp) {
+                this.analytics.P2PCreateOfferNoSDP++;
+                rtcStats.sendEvent("P2PCreateOfferNoSDP", {});
+                throw new Error("SDP undefined while creating offer");
+            }
             if (rtpAbsCaptureTimeOn)
                 offer.sdp = addAbsCaptureTimeExtMap(offer.sdp);
             if (browserName$1 === "firefox") {
-                offer.sdp = setCodecPreferenceSDP(offer.sdp, redOn);
+                offer.sdp = setCodecPreferenceSDP({
+                    sdp: offer.sdp,
+                    redOn,
+                    incrementAnalyticMetric: (metric) => this.analytics[metric]++,
+                });
             }
             if (cleanSdpOn)
                 offer.sdp = cleanSdp(offer.sdp);
@@ -3387,9 +3412,14 @@ class P2pRtcManager {
                 throw e;
             })
                 .then(() => {
+                const message = {
+                    sdp: offer.sdp,
+                    sdpU: offer.sdp,
+                    type: offer.type,
+                };
                 this._emitServerEvent(RELAY_MESSAGES.SDP_OFFER, {
                     receiverId: clientId,
-                    message: this._transformOutgoingSdp(offer),
+                    message,
                 });
             });
         })

package/dist/index.d.cts

@@ -1015,14 +1015,14 @@ type RtcEvents = {
     remote_stream_track_added: void;
     remote_stream_track_removed: void;
 };
-type UnifiedPlanSDP = {
-    sdp: string;
-    sdpU: string;
+type RTCSessionDescription = {
+    sdp?: string;
+    sdpU?: string;
     type: RTCSdpType;
 };
 type SDPRelayMessage = {
     clientId: string;
-    message: UnifiedPlanSDP;
+    message: RTCSessionDescription;
 };
 type GetMediaConstraintsOptions = {
     disableAEC: boolean;
@@ -1204,9 +1204,9 @@ declare class Session {
     addTrack(track: MediaStreamTrack, stream?: MediaStream): void;
     removeTrack(track: MediaStreamTrack): void;
     removeStream(stream: MediaStream): void;
-    _setRemoteDescription(desc: any): any;
-    handleOffer(message: RTCSessionDescription): any;
-    handleAnswer(message: RTCSessionDescription): any;
+    _setRemoteDescription(desc: RTCSessionDescription): Promise<void>;
+    handleOffer(offer: RTCSessionDescription): Promise<RTCSessionDescription>;
+    handleAnswer(message: RTCSessionDescription): Promise<void>;
     addIceCandidate(candidate: any): void;
     canModifyPeerConnection(): boolean;
     close(): void;
@@ -1252,6 +1252,9 @@ type P2PAnalytics = {
     P2PReplaceTrackSourceKindNotFound: number;
     P2PRemoveStreamNoPC: number;
     P2POnTrackNoStream: number;
+    P2PSetCodecPreferenceError: number;
+    P2PCreateOfferNoSDP: number;
+    P2PCreateAnswerNoSDP: number;
 };
 type P2PAnalyticMetric = keyof P2PAnalytics;
 type P2PIncrementAnalyticMetric = (metric: P2PAnalyticMetric) => void;
@@ -1324,8 +1327,6 @@ declare class P2pRtcManager implements RtcManager {
     _getNonLocalCameraStreamIds(): string[];
     _isScreensharingLocally(): boolean;
     _getFirstLocalNonCameraStream(): any;
-    _transformIncomingSdp(original: UnifiedPlanSDP): RTCSessionDescription;
-    _transformOutgoingSdp(original: RTCSessionDescription): UnifiedPlanSDP;
     _createSession({ clientId, initialBandwidth, isOfferer, peerConnectionId, }: {
         clientId: string;
         initialBandwidth: any;
@@ -1348,7 +1349,7 @@ declare class P2pRtcManager implements RtcManager {
     _connect(clientId: string): Promise<Session>;
     _maybeRestartIce(clientId: string, session: any): void;
     _setCodecPreferences(pc: RTCPeerConnection): Promise<void>;
-    _negotiatePeerConnection(clientId: string, session: any, constraints?: any): void;
+    _negotiatePeerConnection(clientId: string, session: Session, constraints?: any): void;
     _withForcedRenegotiation(session: Session, action: any): void;
     _changeBandwidthForAllClients(isJoining: boolean): number;
     _createP2pSession({ clientId, initialBandwidth, isOfferer, }: {
@@ -1402,7 +1403,7 @@ declare const _default: {
     DOMINANT_SPEAKER: string;
 };
 
-declare function setVideoBandwidthUsingSetParameters(pc: any, bandwidth: any, logger?: any): any;
+declare function setVideoBandwidthUsingSetParameters(pc: RTCPeerConnection, bandwidth: number, logger?: any): Promise<void>;
 
 declare const rtcStats: {
     sendEvent: (type: any, value: any) => void;
@@ -1417,7 +1418,12 @@ declare const rtcStats: {
     };
 };
 
-declare function setCodecPreferenceSDP(sdp: any, redOn?: boolean): string | undefined;
+interface SetCodecPreferenceSDPOptions {
+    sdp: string;
+    redOn: boolean;
+    incrementAnalyticMetric: P2PIncrementAnalyticMetric;
+}
+declare function setCodecPreferenceSDP({ sdp, redOn, incrementAnalyticMetric }: SetCodecPreferenceSDPOptions): string;
 declare function cleanSdp(sdp: string): string;
 declare function maybeRejectNoH264(sdp: any): any;
 declare function deprioritizeH264(sdp: any): string;
@@ -1924,4 +1930,4 @@ declare const STREAM_TYPES: {
 };
 
 export { ADDITIONAL_SCREEN_SHARE_SETTINGS, AUDIO_SETTINGS, BandwidthTester, CAMERA_STREAM_ID, EVENTS, KNOCK_MESSAGES, KalmanFilter, Logger, MEDIA_JITTER_BUFFER_TARGET, NoDevicesError, P2pRtcManager, PROTOCOL_ERRORS, PROTOCOL_EVENTS, PROTOCOL_REQUESTS, PROTOCOL_RESPONSES, RELAY_MESSAGES, ReconnectManager, RtcEventNames, RtcManagerDispatcher, SCREEN_SHARE_SETTINGS, SCREEN_SHARE_SIMULCAST_SETTINGS, STREAM_TYPES, ServerSocket, Session, SfuV2Parser, TYPES, VIDEO_SETTINGS_HD, VIDEO_SETTINGS_SD, VIDEO_SETTINGS_VP9, VIDEO_SETTINGS_VP9_LOW_BANDWIDTH, VegaConnection, VegaMediaQualityMonitor, VegaRtcManager, addAbsCaptureTimeExtMap, addExtMap, assert, buildDeviceList, calculateStd, captureAudioSsrcMetrics, captureCandidatePairInfoMetrics, captureCommonSsrcMetrics, captureSsrcInfo, captureVideoSsrcMetrics, changeMediaDirection, cleanSdp, compareLocalDevices, createACFCalculator, createMicAnalyser, createWorker, deprioritizeH264, detectMicrophoneNotWorking, enumerate, external_stun_servers, filterMidExtension, filterMsidSemantic, fromLocation, generateByteString, getConstraints, getCurrentPeerConnections, getDeviceData, getDisplayMedia, getIssuesAndMetrics, getMediaConstraints, getMediaSettings, getMediasoupDeviceAsync, getNumFailedStatsReports, getNumFailedTrackSsrcLookups, getNumMissingTrackSsrcLookups, getPeerConnectionIndex, getStats, getStream, getUpdatedDevices, getUpdatedStats, getUserMedia, hasGetDisplayMedia, ipRegex, isMobile, issueDetectorOrMetricEnabled, maybeRejectNoH264, maybeTurnOnly, modifyMediaCapabilities, removePeerConnection, replaceTracksInStream, _default as rtcManagerEvents, rtcStats, setClientProvider, setCodecPreferenceSDP, setPeerConnectionsForTests, setVideoBandwidthUsingSetParameters, sortCodecs, standardDeviation, startPerformanceMonitor, stopStreamTracks, subscribeIssues, subscribeStats, trackAnnotations, turnServerOverride, variance };
-export type { AddSpotlightRequest, AudioEnableRequest, AudioEnableRequestedEvent, AudioEnabledEvent, BreakoutConfig, BreakoutGroupJoinedEvent, BreakoutSessionUpdatedEvent, CannotJoinUnclaimedRoomError, ChatMessage, ClientKickedEvent, ClientLeftEvent, ClientMetadataPayload, ClientMetadataReceivedEvent, ClientRole, ClientUnableToJoinEvent, CloudRecordingStartedEvent, Codec, Credentials, CustomMediaStreamTrack, ForbiddenError, ForbiddenErrorNames, GetConstraintsOptions, GetDeviceDataResult, GetMediaConstraintsOptions, GetStreamOptions, GetStreamResult, GetUpdatedDevicesResult, HostPresenceControlsError, IdentifyDeviceRequest, InternalServerError, InvalidAssistantKeyError, IssuesAndMetricsByView, JoinRoomRequest, KnockAcceptedEvent, KnockRejectedEvent, KnockRoomRequest, KnockerLeftEvent, LiveTranscriptionStartedEvent, LiveTranscriptionStoppedEvent, MaxViewerLimitReachedError, Metric, NewClientEvent, OrganizationAssistantNotEnabledError, OrganizationAssistantNotFoundError, OrganizationPlanExhaustedError, RemoveSpotlightRequest, RoleName, RoomConcurrencyControlsError, RoomFullError, RoomJoinedErrors, RoomJoinedEvent, RoomJoinedSuccess, RoomKnockedEvent, RoomLockedError, RoomLockedEvent, RoomMeetingTimeExhaustedError, RoomMode, RoomSessionEndedEvent, RtcClientConnectionStatusChangedPayload, RtcEventEmitter, RtcEvents, RtcLocalStreamTrackAddedPayload, RtcLocalStreamTrackRemovedPayload, RtcManager, RtcManagerCreatedPayload, RtcManagerOptions, RtcStreamAddedPayload, SDPRelayMessage, ScreenshareStartedEvent, ScreenshareStoppedEvent, SendClientMetadataRequest, SignalClient, SignalEvents, SignalIceServer, SignalKnocker, SignalMediaServerConfig, SignalRequests, SignalRoom, SignalSFUServer, SignalTurnServer, SocketConf, SocketManager, Spotlight, SpotlightAddedEvent, SpotlightRemovedEvent, StatsMonitorOptions, StatsMonitorState, StatsSubscription, TurnTransportProtocol, UnifiedPlanSDP, UpdatedDeviceInfo, UpdatedDevicesInfo, VegaRtcManagerOptions, VideoEnableRequest, VideoEnableRequestedEvent, VideoEnabledEvent };
+export type { AddSpotlightRequest, AudioEnableRequest, AudioEnableRequestedEvent, AudioEnabledEvent, BreakoutConfig, BreakoutGroupJoinedEvent, BreakoutSessionUpdatedEvent, CannotJoinUnclaimedRoomError, ChatMessage, ClientKickedEvent, ClientLeftEvent, ClientMetadataPayload, ClientMetadataReceivedEvent, ClientRole, ClientUnableToJoinEvent, CloudRecordingStartedEvent, Codec, Credentials, CustomMediaStreamTrack, ForbiddenError, ForbiddenErrorNames, GetConstraintsOptions, GetDeviceDataResult, GetMediaConstraintsOptions, GetStreamOptions, GetStreamResult, GetUpdatedDevicesResult, HostPresenceControlsError, IdentifyDeviceRequest, InternalServerError, InvalidAssistantKeyError, IssuesAndMetricsByView, JoinRoomRequest, KnockAcceptedEvent, KnockRejectedEvent, KnockRoomRequest, KnockerLeftEvent, LiveTranscriptionStartedEvent, LiveTranscriptionStoppedEvent, MaxViewerLimitReachedError, Metric, NewClientEvent, OrganizationAssistantNotEnabledError, OrganizationAssistantNotFoundError, OrganizationPlanExhaustedError, RTCSessionDescription, RemoveSpotlightRequest, RoleName, RoomConcurrencyControlsError, RoomFullError, RoomJoinedErrors, RoomJoinedEvent, RoomJoinedSuccess, RoomKnockedEvent, RoomLockedError, RoomLockedEvent, RoomMeetingTimeExhaustedError, RoomMode, RoomSessionEndedEvent, RtcClientConnectionStatusChangedPayload, RtcEventEmitter, RtcEvents, RtcLocalStreamTrackAddedPayload, RtcLocalStreamTrackRemovedPayload, RtcManager, RtcManagerCreatedPayload, RtcManagerOptions, RtcStreamAddedPayload, SDPRelayMessage, ScreenshareStartedEvent, ScreenshareStoppedEvent, SendClientMetadataRequest, SignalClient, SignalEvents, SignalIceServer, SignalKnocker, SignalMediaServerConfig, SignalRequests, SignalRoom, SignalSFUServer, SignalTurnServer, SocketConf, SocketManager, Spotlight, SpotlightAddedEvent, SpotlightRemovedEvent, StatsMonitorOptions, StatsMonitorState, StatsSubscription, TurnTransportProtocol, UpdatedDeviceInfo, UpdatedDevicesInfo, VegaRtcManagerOptions, VideoEnableRequest, VideoEnableRequestedEvent, VideoEnabledEvent };

package/dist/index.d.mts

@@ -1015,14 +1015,14 @@ type RtcEvents = {
     remote_stream_track_added: void;
     remote_stream_track_removed: void;
 };
-type UnifiedPlanSDP = {
-    sdp: string;
-    sdpU: string;
+type RTCSessionDescription = {
+    sdp?: string;
+    sdpU?: string;
     type: RTCSdpType;
 };
 type SDPRelayMessage = {
     clientId: string;
-    message: UnifiedPlanSDP;
+    message: RTCSessionDescription;
 };
 type GetMediaConstraintsOptions = {
     disableAEC: boolean;
@@ -1204,9 +1204,9 @@ declare class Session {
     addTrack(track: MediaStreamTrack, stream?: MediaStream): void;
     removeTrack(track: MediaStreamTrack): void;
     removeStream(stream: MediaStream): void;
-    _setRemoteDescription(desc: any): any;
-    handleOffer(message: RTCSessionDescription): any;
-    handleAnswer(message: RTCSessionDescription): any;
+    _setRemoteDescription(desc: RTCSessionDescription): Promise<void>;
+    handleOffer(offer: RTCSessionDescription): Promise<RTCSessionDescription>;
+    handleAnswer(message: RTCSessionDescription): Promise<void>;
     addIceCandidate(candidate: any): void;
     canModifyPeerConnection(): boolean;
     close(): void;
@@ -1252,6 +1252,9 @@ type P2PAnalytics = {
     P2PReplaceTrackSourceKindNotFound: number;
     P2PRemoveStreamNoPC: number;
     P2POnTrackNoStream: number;
+    P2PSetCodecPreferenceError: number;
+    P2PCreateOfferNoSDP: number;
+    P2PCreateAnswerNoSDP: number;
 };
 type P2PAnalyticMetric = keyof P2PAnalytics;
 type P2PIncrementAnalyticMetric = (metric: P2PAnalyticMetric) => void;
@@ -1324,8 +1327,6 @@ declare class P2pRtcManager implements RtcManager {
     _getNonLocalCameraStreamIds(): string[];
     _isScreensharingLocally(): boolean;
     _getFirstLocalNonCameraStream(): any;
-    _transformIncomingSdp(original: UnifiedPlanSDP): RTCSessionDescription;
-    _transformOutgoingSdp(original: RTCSessionDescription): UnifiedPlanSDP;
     _createSession({ clientId, initialBandwidth, isOfferer, peerConnectionId, }: {
         clientId: string;
         initialBandwidth: any;
@@ -1348,7 +1349,7 @@ declare class P2pRtcManager implements RtcManager {
     _connect(clientId: string): Promise<Session>;
     _maybeRestartIce(clientId: string, session: any): void;
     _setCodecPreferences(pc: RTCPeerConnection): Promise<void>;
-    _negotiatePeerConnection(clientId: string, session: any, constraints?: any): void;
+    _negotiatePeerConnection(clientId: string, session: Session, constraints?: any): void;
     _withForcedRenegotiation(session: Session, action: any): void;
     _changeBandwidthForAllClients(isJoining: boolean): number;
     _createP2pSession({ clientId, initialBandwidth, isOfferer, }: {
@@ -1402,7 +1403,7 @@ declare const _default: {
     DOMINANT_SPEAKER: string;
 };
 
-declare function setVideoBandwidthUsingSetParameters(pc: any, bandwidth: any, logger?: any): any;
+declare function setVideoBandwidthUsingSetParameters(pc: RTCPeerConnection, bandwidth: number, logger?: any): Promise<void>;
 
 declare const rtcStats: {
     sendEvent: (type: any, value: any) => void;
@@ -1417,7 +1418,12 @@ declare const rtcStats: {
     };
 };
 
-declare function setCodecPreferenceSDP(sdp: any, redOn?: boolean): string | undefined;
+interface SetCodecPreferenceSDPOptions {
+    sdp: string;
+    redOn: boolean;
+    incrementAnalyticMetric: P2PIncrementAnalyticMetric;
+}
+declare function setCodecPreferenceSDP({ sdp, redOn, incrementAnalyticMetric }: SetCodecPreferenceSDPOptions): string;
 declare function cleanSdp(sdp: string): string;
 declare function maybeRejectNoH264(sdp: any): any;
 declare function deprioritizeH264(sdp: any): string;
@@ -1924,4 +1930,4 @@ declare const STREAM_TYPES: {
 };
 
 export { ADDITIONAL_SCREEN_SHARE_SETTINGS, AUDIO_SETTINGS, BandwidthTester, CAMERA_STREAM_ID, EVENTS, KNOCK_MESSAGES, KalmanFilter, Logger, MEDIA_JITTER_BUFFER_TARGET, NoDevicesError, P2pRtcManager, PROTOCOL_ERRORS, PROTOCOL_EVENTS, PROTOCOL_REQUESTS, PROTOCOL_RESPONSES, RELAY_MESSAGES, ReconnectManager, RtcEventNames, RtcManagerDispatcher, SCREEN_SHARE_SETTINGS, SCREEN_SHARE_SIMULCAST_SETTINGS, STREAM_TYPES, ServerSocket, Session, SfuV2Parser, TYPES, VIDEO_SETTINGS_HD, VIDEO_SETTINGS_SD, VIDEO_SETTINGS_VP9, VIDEO_SETTINGS_VP9_LOW_BANDWIDTH, VegaConnection, VegaMediaQualityMonitor, VegaRtcManager, addAbsCaptureTimeExtMap, addExtMap, assert, buildDeviceList, calculateStd, captureAudioSsrcMetrics, captureCandidatePairInfoMetrics, captureCommonSsrcMetrics, captureSsrcInfo, captureVideoSsrcMetrics, changeMediaDirection, cleanSdp, compareLocalDevices, createACFCalculator, createMicAnalyser, createWorker, deprioritizeH264, detectMicrophoneNotWorking, enumerate, external_stun_servers, filterMidExtension, filterMsidSemantic, fromLocation, generateByteString, getConstraints, getCurrentPeerConnections, getDeviceData, getDisplayMedia, getIssuesAndMetrics, getMediaConstraints, getMediaSettings, getMediasoupDeviceAsync, getNumFailedStatsReports, getNumFailedTrackSsrcLookups, getNumMissingTrackSsrcLookups, getPeerConnectionIndex, getStats, getStream, getUpdatedDevices, getUpdatedStats, getUserMedia, hasGetDisplayMedia, ipRegex, isMobile, issueDetectorOrMetricEnabled, maybeRejectNoH264, maybeTurnOnly, modifyMediaCapabilities, removePeerConnection, replaceTracksInStream, _default as rtcManagerEvents, rtcStats, setClientProvider, setCodecPreferenceSDP, setPeerConnectionsForTests, setVideoBandwidthUsingSetParameters, sortCodecs, standardDeviation, startPerformanceMonitor, stopStreamTracks, subscribeIssues, subscribeStats, trackAnnotations, turnServerOverride, variance };
-export type { AddSpotlightRequest, AudioEnableRequest, AudioEnableRequestedEvent, AudioEnabledEvent, BreakoutConfig, BreakoutGroupJoinedEvent, BreakoutSessionUpdatedEvent, CannotJoinUnclaimedRoomError, ChatMessage, ClientKickedEvent, ClientLeftEvent, ClientMetadataPayload, ClientMetadataReceivedEvent, ClientRole, ClientUnableToJoinEvent, CloudRecordingStartedEvent, Codec, Credentials, CustomMediaStreamTrack, ForbiddenError, ForbiddenErrorNames, GetConstraintsOptions, GetDeviceDataResult, GetMediaConstraintsOptions, GetStreamOptions, GetStreamResult, GetUpdatedDevicesResult, HostPresenceControlsError, IdentifyDeviceRequest, InternalServerError, InvalidAssistantKeyError, IssuesAndMetricsByView, JoinRoomRequest, KnockAcceptedEvent, KnockRejectedEvent, KnockRoomRequest, KnockerLeftEvent, LiveTranscriptionStartedEvent, LiveTranscriptionStoppedEvent, MaxViewerLimitReachedError, Metric, NewClientEvent, OrganizationAssistantNotEnabledError, OrganizationAssistantNotFoundError, OrganizationPlanExhaustedError, RemoveSpotlightRequest, RoleName, RoomConcurrencyControlsError, RoomFullError, RoomJoinedErrors, RoomJoinedEvent, RoomJoinedSuccess, RoomKnockedEvent, RoomLockedError, RoomLockedEvent, RoomMeetingTimeExhaustedError, RoomMode, RoomSessionEndedEvent, RtcClientConnectionStatusChangedPayload, RtcEventEmitter, RtcEvents, RtcLocalStreamTrackAddedPayload, RtcLocalStreamTrackRemovedPayload, RtcManager, RtcManagerCreatedPayload, RtcManagerOptions, RtcStreamAddedPayload, SDPRelayMessage, ScreenshareStartedEvent, ScreenshareStoppedEvent, SendClientMetadataRequest, SignalClient, SignalEvents, SignalIceServer, SignalKnocker, SignalMediaServerConfig, SignalRequests, SignalRoom, SignalSFUServer, SignalTurnServer, SocketConf, SocketManager, Spotlight, SpotlightAddedEvent, SpotlightRemovedEvent, StatsMonitorOptions, StatsMonitorState, StatsSubscription, TurnTransportProtocol, UnifiedPlanSDP, UpdatedDeviceInfo, UpdatedDevicesInfo, VegaRtcManagerOptions, VideoEnableRequest, VideoEnableRequestedEvent, VideoEnabledEvent };
+export type { AddSpotlightRequest, AudioEnableRequest, AudioEnableRequestedEvent, AudioEnabledEvent, BreakoutConfig, BreakoutGroupJoinedEvent, BreakoutSessionUpdatedEvent, CannotJoinUnclaimedRoomError, ChatMessage, ClientKickedEvent, ClientLeftEvent, ClientMetadataPayload, ClientMetadataReceivedEvent, ClientRole, ClientUnableToJoinEvent, CloudRecordingStartedEvent, Codec, Credentials, CustomMediaStreamTrack, ForbiddenError, ForbiddenErrorNames, GetConstraintsOptions, GetDeviceDataResult, GetMediaConstraintsOptions, GetStreamOptions, GetStreamResult, GetUpdatedDevicesResult, HostPresenceControlsError, IdentifyDeviceRequest, InternalServerError, InvalidAssistantKeyError, IssuesAndMetricsByView, JoinRoomRequest, KnockAcceptedEvent, KnockRejectedEvent, KnockRoomRequest, KnockerLeftEvent, LiveTranscriptionStartedEvent, LiveTranscriptionStoppedEvent, MaxViewerLimitReachedError, Metric, NewClientEvent, OrganizationAssistantNotEnabledError, OrganizationAssistantNotFoundError, OrganizationPlanExhaustedError, RTCSessionDescription, RemoveSpotlightRequest, RoleName, RoomConcurrencyControlsError, RoomFullError, RoomJoinedErrors, RoomJoinedEvent, RoomJoinedSuccess, RoomKnockedEvent, RoomLockedError, RoomLockedEvent, RoomMeetingTimeExhaustedError, RoomMode, RoomSessionEndedEvent, RtcClientConnectionStatusChangedPayload, RtcEventEmitter, RtcEvents, RtcLocalStreamTrackAddedPayload, RtcLocalStreamTrackRemovedPayload, RtcManager, RtcManagerCreatedPayload, RtcManagerOptions, RtcStreamAddedPayload, SDPRelayMessage, ScreenshareStartedEvent, ScreenshareStoppedEvent, SendClientMetadataRequest, SignalClient, SignalEvents, SignalIceServer, SignalKnocker, SignalMediaServerConfig, SignalRequests, SignalRoom, SignalSFUServer, SignalTurnServer, SocketConf, SocketManager, Spotlight, SpotlightAddedEvent, SpotlightRemovedEvent, StatsMonitorOptions, StatsMonitorState, StatsSubscription, TurnTransportProtocol, UpdatedDeviceInfo, UpdatedDevicesInfo, VegaRtcManagerOptions, VideoEnableRequest, VideoEnableRequestedEvent, VideoEnabledEvent };

package/dist/index.d.ts

@@ -1015,14 +1015,14 @@ type RtcEvents = {
     remote_stream_track_added: void;
     remote_stream_track_removed: void;
 };
-type UnifiedPlanSDP = {
-    sdp: string;
-    sdpU: string;
+type RTCSessionDescription = {
+    sdp?: string;
+    sdpU?: string;
     type: RTCSdpType;
 };
 type SDPRelayMessage = {
     clientId: string;
-    message: UnifiedPlanSDP;
+    message: RTCSessionDescription;
 };
 type GetMediaConstraintsOptions = {
     disableAEC: boolean;
@@ -1204,9 +1204,9 @@ declare class Session {
     addTrack(track: MediaStreamTrack, stream?: MediaStream): void;
     removeTrack(track: MediaStreamTrack): void;
     removeStream(stream: MediaStream): void;
-    _setRemoteDescription(desc: any): any;
-    handleOffer(message: RTCSessionDescription): any;
-    handleAnswer(message: RTCSessionDescription): any;
+    _setRemoteDescription(desc: RTCSessionDescription): Promise<void>;
+    handleOffer(offer: RTCSessionDescription): Promise<RTCSessionDescription>;
+    handleAnswer(message: RTCSessionDescription): Promise<void>;
     addIceCandidate(candidate: any): void;
     canModifyPeerConnection(): boolean;
     close(): void;
@@ -1252,6 +1252,9 @@ type P2PAnalytics = {
     P2PReplaceTrackSourceKindNotFound: number;
     P2PRemoveStreamNoPC: number;
     P2POnTrackNoStream: number;
+    P2PSetCodecPreferenceError: number;
+    P2PCreateOfferNoSDP: number;
+    P2PCreateAnswerNoSDP: number;
 };
 type P2PAnalyticMetric = keyof P2PAnalytics;
 type P2PIncrementAnalyticMetric = (metric: P2PAnalyticMetric) => void;
@@ -1324,8 +1327,6 @@ declare class P2pRtcManager implements RtcManager {
     _getNonLocalCameraStreamIds(): string[];
     _isScreensharingLocally(): boolean;
     _getFirstLocalNonCameraStream(): any;
-    _transformIncomingSdp(original: UnifiedPlanSDP): RTCSessionDescription;
-    _transformOutgoingSdp(original: RTCSessionDescription): UnifiedPlanSDP;
     _createSession({ clientId, initialBandwidth, isOfferer, peerConnectionId, }: {
         clientId: string;
         initialBandwidth: any;
@@ -1348,7 +1349,7 @@ declare class P2pRtcManager implements RtcManager {
     _connect(clientId: string): Promise<Session>;
     _maybeRestartIce(clientId: string, session: any): void;
     _setCodecPreferences(pc: RTCPeerConnection): Promise<void>;
-    _negotiatePeerConnection(clientId: string, session: any, constraints?: any): void;
+    _negotiatePeerConnection(clientId: string, session: Session, constraints?: any): void;
     _withForcedRenegotiation(session: Session, action: any): void;
     _changeBandwidthForAllClients(isJoining: boolean): number;
     _createP2pSession({ clientId, initialBandwidth, isOfferer, }: {
@@ -1402,7 +1403,7 @@ declare const _default: {
     DOMINANT_SPEAKER: string;
 };
 
-declare function setVideoBandwidthUsingSetParameters(pc: any, bandwidth: any, logger?: any): any;
+declare function setVideoBandwidthUsingSetParameters(pc: RTCPeerConnection, bandwidth: number, logger?: any): Promise<void>;
 
 declare const rtcStats: {
     sendEvent: (type: any, value: any) => void;
@@ -1417,7 +1418,12 @@ declare const rtcStats: {
     };
 };
 
-declare function setCodecPreferenceSDP(sdp: any, redOn?: boolean): string | undefined;
+interface SetCodecPreferenceSDPOptions {
+    sdp: string;
+    redOn: boolean;
+    incrementAnalyticMetric: P2PIncrementAnalyticMetric;
+}
+declare function setCodecPreferenceSDP({ sdp, redOn, incrementAnalyticMetric }: SetCodecPreferenceSDPOptions): string;
 declare function cleanSdp(sdp: string): string;
 declare function maybeRejectNoH264(sdp: any): any;
 declare function deprioritizeH264(sdp: any): string;
@@ -1924,4 +1930,4 @@ declare const STREAM_TYPES: {
 };
 
 export { ADDITIONAL_SCREEN_SHARE_SETTINGS, AUDIO_SETTINGS, BandwidthTester, CAMERA_STREAM_ID, EVENTS, KNOCK_MESSAGES, KalmanFilter, Logger, MEDIA_JITTER_BUFFER_TARGET, NoDevicesError, P2pRtcManager, PROTOCOL_ERRORS, PROTOCOL_EVENTS, PROTOCOL_REQUESTS, PROTOCOL_RESPONSES, RELAY_MESSAGES, ReconnectManager, RtcEventNames, RtcManagerDispatcher, SCREEN_SHARE_SETTINGS, SCREEN_SHARE_SIMULCAST_SETTINGS, STREAM_TYPES, ServerSocket, Session, SfuV2Parser, TYPES, VIDEO_SETTINGS_HD, VIDEO_SETTINGS_SD, VIDEO_SETTINGS_VP9, VIDEO_SETTINGS_VP9_LOW_BANDWIDTH, VegaConnection, VegaMediaQualityMonitor, VegaRtcManager, addAbsCaptureTimeExtMap, addExtMap, assert, buildDeviceList, calculateStd, captureAudioSsrcMetrics, captureCandidatePairInfoMetrics, captureCommonSsrcMetrics, captureSsrcInfo, captureVideoSsrcMetrics, changeMediaDirection, cleanSdp, compareLocalDevices, createACFCalculator, createMicAnalyser, createWorker, deprioritizeH264, detectMicrophoneNotWorking, enumerate, external_stun_servers, filterMidExtension, filterMsidSemantic, fromLocation, generateByteString, getConstraints, getCurrentPeerConnections, getDeviceData, getDisplayMedia, getIssuesAndMetrics, getMediaConstraints, getMediaSettings, getMediasoupDeviceAsync, getNumFailedStatsReports, getNumFailedTrackSsrcLookups, getNumMissingTrackSsrcLookups, getPeerConnectionIndex, getStats, getStream, getUpdatedDevices, getUpdatedStats, getUserMedia, hasGetDisplayMedia, ipRegex, isMobile, issueDetectorOrMetricEnabled, maybeRejectNoH264, maybeTurnOnly, modifyMediaCapabilities, removePeerConnection, replaceTracksInStream, _default as rtcManagerEvents, rtcStats, setClientProvider, setCodecPreferenceSDP, setPeerConnectionsForTests, setVideoBandwidthUsingSetParameters, sortCodecs, standardDeviation, startPerformanceMonitor, stopStreamTracks, subscribeIssues, subscribeStats, trackAnnotations, turnServerOverride, variance };
-export type { AddSpotlightRequest, AudioEnableRequest, AudioEnableRequestedEvent, AudioEnabledEvent, BreakoutConfig, BreakoutGroupJoinedEvent, BreakoutSessionUpdatedEvent, CannotJoinUnclaimedRoomError, ChatMessage, ClientKickedEvent, ClientLeftEvent, ClientMetadataPayload, ClientMetadataReceivedEvent, ClientRole, ClientUnableToJoinEvent, CloudRecordingStartedEvent, Codec, Credentials, CustomMediaStreamTrack, ForbiddenError, ForbiddenErrorNames, GetConstraintsOptions, GetDeviceDataResult, GetMediaConstraintsOptions, GetStreamOptions, GetStreamResult, GetUpdatedDevicesResult, HostPresenceControlsError, IdentifyDeviceRequest, InternalServerError, InvalidAssistantKeyError, IssuesAndMetricsByView, JoinRoomRequest, KnockAcceptedEvent, KnockRejectedEvent, KnockRoomRequest, KnockerLeftEvent, LiveTranscriptionStartedEvent, LiveTranscriptionStoppedEvent, MaxViewerLimitReachedError, Metric, NewClientEvent, OrganizationAssistantNotEnabledError, OrganizationAssistantNotFoundError, OrganizationPlanExhaustedError, RemoveSpotlightRequest, RoleName, RoomConcurrencyControlsError, RoomFullError, RoomJoinedErrors, RoomJoinedEvent, RoomJoinedSuccess, RoomKnockedEvent, RoomLockedError, RoomLockedEvent, RoomMeetingTimeExhaustedError, RoomMode, RoomSessionEndedEvent, RtcClientConnectionStatusChangedPayload, RtcEventEmitter, RtcEvents, RtcLocalStreamTrackAddedPayload, RtcLocalStreamTrackRemovedPayload, RtcManager, RtcManagerCreatedPayload, RtcManagerOptions, RtcStreamAddedPayload, SDPRelayMessage, ScreenshareStartedEvent, ScreenshareStoppedEvent, SendClientMetadataRequest, SignalClient, SignalEvents, SignalIceServer, SignalKnocker, SignalMediaServerConfig, SignalRequests, SignalRoom, SignalSFUServer, SignalTurnServer, SocketConf, SocketManager, Spotlight, SpotlightAddedEvent, SpotlightRemovedEvent, StatsMonitorOptions, StatsMonitorState, StatsSubscription, TurnTransportProtocol, UnifiedPlanSDP, UpdatedDeviceInfo, UpdatedDevicesInfo, VegaRtcManagerOptions, VideoEnableRequest, VideoEnableRequestedEvent, VideoEnabledEvent };
+export type { AddSpotlightRequest, AudioEnableRequest, AudioEnableRequestedEvent, AudioEnabledEvent, BreakoutConfig, BreakoutGroupJoinedEvent, BreakoutSessionUpdatedEvent, CannotJoinUnclaimedRoomError, ChatMessage, ClientKickedEvent, ClientLeftEvent, ClientMetadataPayload, ClientMetadataReceivedEvent, ClientRole, ClientUnableToJoinEvent, CloudRecordingStartedEvent, Codec, Credentials, CustomMediaStreamTrack, ForbiddenError, ForbiddenErrorNames, GetConstraintsOptions, GetDeviceDataResult, GetMediaConstraintsOptions, GetStreamOptions, GetStreamResult, GetUpdatedDevicesResult, HostPresenceControlsError, IdentifyDeviceRequest, InternalServerError, InvalidAssistantKeyError, IssuesAndMetricsByView, JoinRoomRequest, KnockAcceptedEvent, KnockRejectedEvent, KnockRoomRequest, KnockerLeftEvent, LiveTranscriptionStartedEvent, LiveTranscriptionStoppedEvent, MaxViewerLimitReachedError, Metric, NewClientEvent, OrganizationAssistantNotEnabledError, OrganizationAssistantNotFoundError, OrganizationPlanExhaustedError, RTCSessionDescription, RemoveSpotlightRequest, RoleName, RoomConcurrencyControlsError, RoomFullError, RoomJoinedErrors, RoomJoinedEvent, RoomJoinedSuccess, RoomKnockedEvent, RoomLockedError, RoomLockedEvent, RoomMeetingTimeExhaustedError, RoomMode, RoomSessionEndedEvent, RtcClientConnectionStatusChangedPayload, RtcEventEmitter, RtcEvents, RtcLocalStreamTrackAddedPayload, RtcLocalStreamTrackRemovedPayload, RtcManager, RtcManagerCreatedPayload, RtcManagerOptions, RtcStreamAddedPayload, SDPRelayMessage, ScreenshareStartedEvent, ScreenshareStoppedEvent, SendClientMetadataRequest, SignalClient, SignalEvents, SignalIceServer, SignalKnocker, SignalMediaServerConfig, SignalRequests, SignalRoom, SignalSFUServer, SignalTurnServer, SocketConf, SocketManager, Spotlight, SpotlightAddedEvent, SpotlightRemovedEvent, StatsMonitorOptions, StatsMonitorState, StatsSubscription, TurnTransportProtocol, UpdatedDeviceInfo, UpdatedDevicesInfo, VegaRtcManagerOptions, VideoEnableRequest, VideoEnableRequestedEvent, VideoEnabledEvent };

package/dist/index.mjs

@@ -1998,7 +1998,7 @@ const adapter$5 = (_a$5 = adapterRaw.default) !== null && _a$5 !== void 0 ? _a$5
 const logger$8 = new Logger();
 const browserName$2 = (_b$2 = adapter$5.browserDetails) === null || _b$2 === void 0 ? void 0 : _b$2.browser;
 const browserVersion$1 = adapter$5.browserDetails.version;
-function setCodecPreferenceSDP(sdp, redOn) {
+function setCodecPreferenceSDP({ sdp, redOn, incrementAnalyticMetric }) {
     var _a, _b;
     try {
         const sdpObject = sdpTransform.parse(sdp);
@@ -2036,7 +2036,10 @@ function setCodecPreferenceSDP(sdp, redOn) {
         return newSdp;
     }
     catch (error) {
+        incrementAnalyticMetric("P2PSetCodecPreferenceError");
+        rtcStats.sendEvent("P2PSetCodecPreferenceError", { error });
         logger$8.error("setCodecPreferenceSDP error:", error);
+        return sdp;
     }
 }
 function cleanSdp(sdp) {
@@ -2324,25 +2327,36 @@ class Session {
             this.earlyIceCandidates = [];
         });
     }
-    handleOffer(message) {
+    handleOffer(offer) {
         if (!this.canModifyPeerConnection()) {
             return new Promise((resolve) => {
-                this.pending.push(() => this.handleOffer(message).then(resolve));
+                this.pending.push(() => this.handleOffer(offer).then(resolve));
             });
         }
         this.isOperationPending = true;
-        let sdp = message.sdp;
+        let sdp = offer.sdp;
         sdp = filterMidExtension(sdp);
         sdp = filterMsidSemantic(sdp);
-        const desc = { type: message.type, sdp };
+        const desc = { type: offer.type, sdp };
         let answerToSignal;
         return this._setRemoteDescription(desc)
             .then(() => {
             return this.pc.createAnswer();
         })
             .then((answer) => {
-            answerToSignal = answer;
-            return this.pc.setLocalDescription(answer);
+            if (!answer.sdp) {
+                this._incrementAnalyticMetric("P2PCreateAnswerNoSDP");
+                rtcStats.sendEvent("P2PCreateAnswerNoSDP", {});
+                throw new Error("SDP undefined while creating answer");
+            }
+            else {
+                answerToSignal = {
+                    sdp: answer.sdp,
+                    sdpU: answer.sdp,
+                    type: answer.type,
+                };
+                return this.pc.setLocalDescription(answer);
+            }
         })
             .then(() => {
             return setVideoBandwidthUsingSetParameters(this.pc, this.bandwidth);
@@ -2662,6 +2676,9 @@ class P2pRtcManager {
             P2PReplaceTrackSourceKindNotFound: 0,
             P2PRemoveStreamNoPC: 0,
             P2POnTrackNoStream: 0,
+            P2PSetCodecPreferenceError: 0,
+            P2PCreateOfferNoSDP: 0,
+            P2PCreateAnswerNoSDP: 0,
         };
     }
     numberOfPeerconnections() {
@@ -2782,13 +2799,16 @@ class P2pRtcManager {
                     logger$6.warn("No RTCPeerConnection on SDP_OFFER", data);
                     return;
                 }
-                const offer = this._transformIncomingSdp(data.message);
+                const sdp = {
+                    sdp: data.message.sdp || data.message.sdpU,
+                    type: data.message.type,
+                };
                 (_b = (_a = session
-                    .handleOffer(offer)
+                    .handleOffer(sdp)
                     .then((answer) => {
                     this._emitServerEvent(RELAY_MESSAGES.SDP_ANSWER, {
                         receiverId: data.clientId,
-                        message: this._transformOutgoingSdp(answer),
+                        message: answer,
                     });
                 })).catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
                     this.analytics.numPcOnOfferFailure++;
@@ -2801,8 +2821,11 @@ class P2pRtcManager {
                     logger$6.warn("No RTCPeerConnection on SDP_ANSWER", data);
                     return;
                 }
-                const answer = this._transformIncomingSdp(data.message);
-                (_b = (_a = session.handleAnswer(answer)) === null || _a === void 0 ? void 0 : _a.catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
+                const sdp = {
+                    sdp: data.message.sdp || data.message.sdpU,
+                    type: data.message.type,
+                };
+                (_b = (_a = session.handleAnswer(sdp)) === null || _a === void 0 ? void 0 : _a.catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
                     logger$6.warn("Could not set remote description from remote answer: ", e);
                     this.analytics.numPcOnAnswerFailure++;
                 });
@@ -2981,13 +3004,6 @@ class P2pRtcManager {
         const streamIds = this._getNonLocalCameraStreamIds();
         return streamIds.length === 0 ? null : this.localStreams[streamIds[0]];
     }
-    _transformIncomingSdp(original) {
-        const sdp = original.sdp ? original.sdp : original.sdpU;
-        return { type: original.type, sdp };
-    }
-    _transformOutgoingSdp(original) {
-        return { type: original.type, sdpU: original.sdp, sdp: original.sdp };
-    }
     _createSession({ clientId, initialBandwidth, isOfferer, peerConnectionId, }) {
         if (!peerConnectionId) {
             throw new Error("peerConnectionId is missing");
@@ -3352,10 +3368,19 @@ class P2pRtcManager {
         this._setCodecPreferences(pc).then(() => pc
             .createOffer(constraints || this.offerOptions)
             .then((offer) => {
+            if (!offer.sdp) {
+                this.analytics.P2PCreateOfferNoSDP++;
+                rtcStats.sendEvent("P2PCreateOfferNoSDP", {});
+                throw new Error("SDP undefined while creating offer");
+            }
             if (rtpAbsCaptureTimeOn)
                 offer.sdp = addAbsCaptureTimeExtMap(offer.sdp);
             if (browserName$1 === "firefox") {
-                offer.sdp = setCodecPreferenceSDP(offer.sdp, redOn);
+                offer.sdp = setCodecPreferenceSDP({
+                    sdp: offer.sdp,
+                    redOn,
+                    incrementAnalyticMetric: (metric) => this.analytics[metric]++,
+                });
             }
             if (cleanSdpOn)
                 offer.sdp = cleanSdp(offer.sdp);
@@ -3366,9 +3391,14 @@ class P2pRtcManager {
                 throw e;
             })
                 .then(() => {
+                const message = {
+                    sdp: offer.sdp,
+                    sdpU: offer.sdp,
+                    type: offer.type,
+                };
                 this._emitServerEvent(RELAY_MESSAGES.SDP_OFFER, {
                     receiverId: clientId,
-                    message: this._transformOutgoingSdp(offer),
+                    message,
                 });
             });
         })

package/dist/legacy-esm.js

@@ -1998,7 +1998,7 @@ const adapter$5 = (_a$5 = adapterRaw.default) !== null && _a$5 !== void 0 ? _a$5
 const logger$8 = new Logger();
 const browserName$2 = (_b$2 = adapter$5.browserDetails) === null || _b$2 === void 0 ? void 0 : _b$2.browser;
 const browserVersion$1 = adapter$5.browserDetails.version;
-function setCodecPreferenceSDP(sdp, redOn) {
+function setCodecPreferenceSDP({ sdp, redOn, incrementAnalyticMetric }) {
     var _a, _b;
     try {
         const sdpObject = sdpTransform.parse(sdp);
@@ -2036,7 +2036,10 @@ function setCodecPreferenceSDP(sdp, redOn) {
         return newSdp;
     }
     catch (error) {
+        incrementAnalyticMetric("P2PSetCodecPreferenceError");
+        rtcStats.sendEvent("P2PSetCodecPreferenceError", { error });
         logger$8.error("setCodecPreferenceSDP error:", error);
+        return sdp;
     }
 }
 function cleanSdp(sdp) {
@@ -2324,25 +2327,36 @@ class Session {
             this.earlyIceCandidates = [];
         });
     }
-    handleOffer(message) {
+    handleOffer(offer) {
         if (!this.canModifyPeerConnection()) {
             return new Promise((resolve) => {
-                this.pending.push(() => this.handleOffer(message).then(resolve));
+                this.pending.push(() => this.handleOffer(offer).then(resolve));
             });
         }
         this.isOperationPending = true;
-        let sdp = message.sdp;
+        let sdp = offer.sdp;
         sdp = filterMidExtension(sdp);
         sdp = filterMsidSemantic(sdp);
-        const desc = { type: message.type, sdp };
+        const desc = { type: offer.type, sdp };
         let answerToSignal;
         return this._setRemoteDescription(desc)
             .then(() => {
             return this.pc.createAnswer();
         })
             .then((answer) => {
-            answerToSignal = answer;
-            return this.pc.setLocalDescription(answer);
+            if (!answer.sdp) {
+                this._incrementAnalyticMetric("P2PCreateAnswerNoSDP");
+                rtcStats.sendEvent("P2PCreateAnswerNoSDP", {});
+                throw new Error("SDP undefined while creating answer");
+            }
+            else {
+                answerToSignal = {
+                    sdp: answer.sdp,
+                    sdpU: answer.sdp,
+                    type: answer.type,
+                };
+                return this.pc.setLocalDescription(answer);
+            }
         })
             .then(() => {
             return setVideoBandwidthUsingSetParameters(this.pc, this.bandwidth);
@@ -2662,6 +2676,9 @@ class P2pRtcManager {
             P2PReplaceTrackSourceKindNotFound: 0,
             P2PRemoveStreamNoPC: 0,
             P2POnTrackNoStream: 0,
+            P2PSetCodecPreferenceError: 0,
+            P2PCreateOfferNoSDP: 0,
+            P2PCreateAnswerNoSDP: 0,
         };
     }
     numberOfPeerconnections() {
@@ -2782,13 +2799,16 @@ class P2pRtcManager {
                     logger$6.warn("No RTCPeerConnection on SDP_OFFER", data);
                     return;
                 }
-                const offer = this._transformIncomingSdp(data.message);
+                const sdp = {
+                    sdp: data.message.sdp || data.message.sdpU,
+                    type: data.message.type,
+                };
                 (_b = (_a = session
-                    .handleOffer(offer)
+                    .handleOffer(sdp)
                     .then((answer) => {
                     this._emitServerEvent(RELAY_MESSAGES.SDP_ANSWER, {
                         receiverId: data.clientId,
-                        message: this._transformOutgoingSdp(answer),
+                        message: answer,
                     });
                 })).catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
                     this.analytics.numPcOnOfferFailure++;
@@ -2801,8 +2821,11 @@ class P2pRtcManager {
                     logger$6.warn("No RTCPeerConnection on SDP_ANSWER", data);
                     return;
                 }
-                const answer = this._transformIncomingSdp(data.message);
-                (_b = (_a = session.handleAnswer(answer)) === null || _a === void 0 ? void 0 : _a.catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
+                const sdp = {
+                    sdp: data.message.sdp || data.message.sdpU,
+                    type: data.message.type,
+                };
+                (_b = (_a = session.handleAnswer(sdp)) === null || _a === void 0 ? void 0 : _a.catch) === null || _b === void 0 ? void 0 : _b.call(_a, (e) => {
                     logger$6.warn("Could not set remote description from remote answer: ", e);
                     this.analytics.numPcOnAnswerFailure++;
                 });
@@ -2981,13 +3004,6 @@ class P2pRtcManager {
         const streamIds = this._getNonLocalCameraStreamIds();
         return streamIds.length === 0 ? null : this.localStreams[streamIds[0]];
     }
-    _transformIncomingSdp(original) {
-        const sdp = original.sdp ? original.sdp : original.sdpU;
-        return { type: original.type, sdp };
-    }
-    _transformOutgoingSdp(original) {
-        return { type: original.type, sdpU: original.sdp, sdp: original.sdp };
-    }
     _createSession({ clientId, initialBandwidth, isOfferer, peerConnectionId, }) {
         if (!peerConnectionId) {
             throw new Error("peerConnectionId is missing");
@@ -3352,10 +3368,19 @@ class P2pRtcManager {
         this._setCodecPreferences(pc).then(() => pc
             .createOffer(constraints || this.offerOptions)
             .then((offer) => {
+            if (!offer.sdp) {
+                this.analytics.P2PCreateOfferNoSDP++;
+                rtcStats.sendEvent("P2PCreateOfferNoSDP", {});
+                throw new Error("SDP undefined while creating offer");
+            }
             if (rtpAbsCaptureTimeOn)
                 offer.sdp = addAbsCaptureTimeExtMap(offer.sdp);
             if (browserName$1 === "firefox") {
-                offer.sdp = setCodecPreferenceSDP(offer.sdp, redOn);
+                offer.sdp = setCodecPreferenceSDP({
+                    sdp: offer.sdp,
+                    redOn,
+                    incrementAnalyticMetric: (metric) => this.analytics[metric]++,
+                });
             }
             if (cleanSdpOn)
                 offer.sdp = cleanSdp(offer.sdp);
@@ -3366,9 +3391,14 @@ class P2pRtcManager {
                 throw e;
             })
                 .then(() => {
+                const message = {
+                    sdp: offer.sdp,
+                    sdpU: offer.sdp,
+                    type: offer.type,
+                };
                 this._emitServerEvent(RELAY_MESSAGES.SDP_OFFER, {
                     receiverId: clientId,
-                    message: this._transformOutgoingSdp(offer),
+                    message,
                 });
             });
         })

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@whereby.com/media",
   "description": "Media library for Whereby",
-  "version": "2.8.4",
+  "version": "2.8.6",
   "license": "MIT",
   "homepage": "https://github.com/whereby/sdk",
   "repository": {