@whatwg-node/fetch 0.4.4 → 0.4.5-alpha-20220925233002-c4d7b92

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @whatwg-node/fetch
 
+## 0.4.5-alpha-20220925233002-c4d7b92
+
+### Patch Changes
+
+- [#140](https://github.com/ardatan/whatwg-node/pull/140) [`77b4592`](https://github.com/ardatan/whatwg-node/commit/77b4592a6ee5aa35ff92c4f8a76c2f93127d8045) Thanks [@ardatan](https://github.com/ardatan)! - Fix Request.formData method
+
 ## 0.4.4
 
 ### Patch Changes

package/dist/getFormDataMethod.js

@@ -16,13 +16,13 @@ module.exports = function getFormDataMethod(File, limits) {
         reject(new Error(`File size limit exceeded: ${limits.fileSize} bytes`));
       })
       fileStream.on('data', (chunk) => {
-        chunks.push(chunk);
+        chunks.push(...chunk);
       })
       fileStream.on('close', () => {
         if (fileStream.truncated) {
           reject(new Error(`File size limit exceeded: ${limits.fileSize} bytes`));
         }
-        const file = new File(chunks, filename, { type: mimeType });
+        const file = new File([new Uint8Array(chunks)], filename, { type: mimeType });
         formData.set(name, file);
         resolve(file);
       });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@whatwg-node/fetch",
-  "version": "0.4.4",
+  "version": "0.4.5-alpha-20220925233002-c4d7b92",
   "description": "Cross Platform Smart Fetch Ponyfill",
   "author": "Arda TANRIKULU <ardatanrikulu@gmail.com>",
   "repository": {

package/tests/getFormDataMethod.spec.ts

@@ -0,0 +1,43 @@
+import { createFetch } from '@whatwg-node/fetch';
+
+describe('getFormDataMethod', () => {
+  ['fieldsFirst:true', 'fieldsFirst:false'].forEach(fieldsFirstFlag => {
+    const fetchAPI = createFetch({
+      formDataLimits: {
+        fieldsFirst: fieldsFirstFlag === 'fieldsFirst:true',
+      },
+    });
+    describe(fieldsFirstFlag, () => {
+      it('should parse fields correctly', async () => {
+        const formData = new fetchAPI.FormData();
+        formData.append('greetings', 'Hello world!');
+        formData.append('bye', 'Goodbye world!');
+        const request = new fetchAPI.Request('http://localhost:8080', {
+          method: 'POST',
+          body: formData,
+        });
+        const formdata = await request.formData();
+        expect(formdata.get('greetings')).toBe('Hello world!');
+        expect(formdata.get('bye')).toBe('Goodbye world!');
+      });
+      it('should parse and receive text files correctly', async () => {
+        const formData = new fetchAPI.FormData();
+        const greetingsFile = new fetchAPI.File(['Hello world!'], 'greetings.txt', { type: 'text/plain' });
+        const byeFile = new fetchAPI.File(['Goodbye world!'], 'bye.txt', { type: 'text/plain' });
+        formData.append('greetings', greetingsFile);
+        formData.append('bye', byeFile);
+        const request = new fetchAPI.Request('http://localhost:8080', {
+          method: 'POST',
+          body: formData,
+        });
+        const formdata = await request.formData();
+        const receivedGreetingsFile = formdata.get('greetings') as File;
+        const receivedGreetingsText = await receivedGreetingsFile.text();
+        expect(receivedGreetingsText).toBe('Hello world!');
+        const receivedByeFile = formdata.get('bye') as File;
+        const receivedByeText = await receivedByeFile.text();
+        expect(receivedByeText).toBe('Goodbye world!');
+      });
+    });
+  });
+});