@wenaixi/dsh-superpower 7.4.1 → 7.5.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +110 -105
- package/README.zh.md +216 -0
- package/lib/catalog.d.ts +8 -2
- package/lib/catalog.d.ts.map +1 -1
- package/lib/catalog.js +64 -9
- package/lib/catalog.js.map +1 -1
- package/lib/client.js +68 -21
- package/lib/document.d.ts +8 -2
- package/lib/document.d.ts.map +1 -1
- package/lib/document.js +14 -4
- package/lib/document.js.map +1 -1
- package/lib/superpowers.d.ts +2 -0
- package/lib/superpowers.d.ts.map +1 -1
- package/lib/superpowers.js +8 -0
- package/lib/superpowers.js.map +1 -1
- package/lib/switches.d.ts +2 -10
- package/lib/switches.d.ts.map +1 -1
- package/lib/switches.js +29 -5
- package/lib/switches.js.map +1 -1
- package/package.json +3 -3
- package/skills/brainstorming/SKILL.md +235 -171
- package/skills/brainstorming/spec-document-reviewer-prompt.md +27 -25
- package/skills/brainstorming/visual-companion.md +65 -69
- package/skills/diagnosing-superpowers/SKILL.md +107 -43
- package/skills/diagnosing-superpowers/prompts/analyst-common.md +32 -18
- package/skills/diagnosing-superpowers/prompts/cost-and-time.md +25 -9
- package/skills/diagnosing-superpowers/prompts/plan-adherence.md +26 -12
- package/skills/diagnosing-superpowers/prompts/quality-evidence.md +23 -8
- package/skills/diagnosing-superpowers/prompts/repeated-work.md +25 -14
- package/skills/diagnosing-superpowers/prompts/request-conflicts.md +18 -9
- package/skills/diagnosing-superpowers/prompts/scrub-audit.md +23 -10
- package/skills/diagnosing-superpowers/prompts/scrub.md +25 -12
- package/skills/diagnosing-superpowers/prompts/similar-session.md +30 -22
- package/skills/diagnosing-superpowers/prompts/skill-timeline.md +26 -12
- package/skills/diagnosing-superpowers/prompts/stumbles.md +24 -12
- package/skills/diagnosing-superpowers/references/context-safety.md +15 -7
- package/skills/diagnosing-superpowers/references/github-issues.md +17 -9
- package/skills/diagnosing-superpowers/references/redaction-policy.md +27 -15
- package/skills/diagnosing-superpowers/references/session-discovery.md +31 -20
- package/skills/diagnosing-superpowers/templates/bundle-README.md +66 -40
- package/skills/diagnosing-superpowers/templates/case.md +49 -42
- package/skills/diagnosing-superpowers/templates/issue.md +32 -26
- package/skills/diagnosing-superpowers/templates/report.md +54 -48
- package/skills/dispatching-parallel-agents/SKILL.md +92 -90
- package/skills/executing-plans/SKILL.md +345 -197
- package/skills/finishing-a-development-branch/SKILL.md +107 -82
- package/skills/receiving-code-review/SKILL.md +129 -127
- package/skills/requesting-code-review/SKILL.md +52 -50
- package/skills/requesting-code-review/code-reviewer.md +132 -111
- package/skills/subagent-driven-development/SKILL.md +521 -298
- package/skills/subagent-driven-development/implementer-prompt.md +138 -117
- package/skills/subagent-driven-development/re-review-prompt.md +80 -48
- package/skills/subagent-driven-development/task-reviewer-prompt.md +189 -110
- package/skills/systematic-debugging/CREATION-LOG.md +85 -85
- package/skills/systematic-debugging/SKILL.md +221 -219
- package/skills/systematic-debugging/condition-based-waiting.md +48 -49
- package/skills/systematic-debugging/defense-in-depth.md +46 -46
- package/skills/systematic-debugging/root-cause-tracing.md +63 -63
- package/skills/systematic-debugging/test-academic.md +10 -10
- package/skills/systematic-debugging/test-pressure-1.md +40 -40
- package/skills/systematic-debugging/test-pressure-2.md +58 -58
- package/skills/systematic-debugging/test-pressure-3.md +48 -48
- package/skills/test-driven-development/SKILL.md +161 -153
- package/skills/test-driven-development/writing-good-tests.md +137 -84
- package/skills/using-git-worktrees/SKILL.md +74 -72
- package/skills/using-superpowers/SKILL.md +40 -39
- package/skills/using-superpowers/references/dsh-tools.md +36 -36
- package/skills/verification-before-completion/SKILL.md +85 -83
- package/skills/writing-plans/SKILL.md +123 -84
- package/skills/writing-skills/SKILL.md +419 -417
- package/skills/writing-skills/persuasion-principles.md +118 -118
- package/skills/writing-skills/testing-skills-with-subagents.md +190 -190
|
@@ -1,82 +1,91 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: finishing-a-development-branch
|
|
3
|
-
description: "Superpower Skill
|
|
3
|
+
description: "Superpower Skill: Use when implementation is complete, all tests pass, and you need to decide how to integrate the work"
|
|
4
|
+
description_zh: "Superpower Skill:实现完成且全部测试通过后,用于决定分支集成方式,支持本地合并、创建 PR 或保留分支等完整收尾流程。"
|
|
4
5
|
---
|
|
5
6
|
|
|
6
|
-
# 完成开发分支
|
|
7
7
|
|
|
8
|
-
|
|
8
|
+
# Finishing a Development Branch
|
|
9
9
|
|
|
10
|
-
|
|
10
|
+
## Overview
|
|
11
11
|
|
|
12
|
-
|
|
12
|
+
**Core principle:** Verify tests → Detect environment → Present options → Execute choice → Clean up.
|
|
13
13
|
|
|
14
|
-
|
|
14
|
+
**Announce at start:** "I'm using the finishing-a-development-branch skill to complete this work."
|
|
15
15
|
|
|
16
|
-
|
|
16
|
+
## Step 1: Verify Tests
|
|
17
17
|
|
|
18
|
-
|
|
18
|
+
Run the project's full test suite (`npm test` / `cargo test` / `pytest` / `go test ./...`).
|
|
19
|
+
|
|
20
|
+
**If tests fail**, report the failures and stop — the menu comes after a green suite:
|
|
19
21
|
|
|
20
22
|
```
|
|
21
|
-
|
|
23
|
+
Tests failing (<N> failures). Must fix before completing:
|
|
22
24
|
|
|
23
|
-
[
|
|
25
|
+
[Show failures]
|
|
24
26
|
```
|
|
25
27
|
|
|
26
|
-
|
|
28
|
+
**If tests pass:** continue to Step 2.
|
|
27
29
|
|
|
28
|
-
##
|
|
30
|
+
## Step 2: Detect Environment
|
|
29
31
|
|
|
30
32
|
```bash
|
|
31
33
|
GIT_DIR=$(cd "$(git rev-parse --git-dir)" 2>/dev/null && pwd -P)
|
|
32
34
|
GIT_COMMON=$(cd "$(git rev-parse --git-common-dir)" 2>/dev/null && pwd -P)
|
|
33
|
-
#
|
|
34
|
-
#
|
|
35
|
+
# Capture now, while still inside the workspace — Step 5 changes directory
|
|
36
|
+
# before cleanup (Step 6) needs this value
|
|
35
37
|
WORKTREE_PATH=$(git rev-parse --show-toplevel)
|
|
36
38
|
```
|
|
37
39
|
|
|
38
|
-
|
|
40
|
+
This determines which menu to show and how cleanup works:
|
|
39
41
|
|
|
40
|
-
|
|
|
42
|
+
| State | Menu | Cleanup |
|
|
41
43
|
|-------|------|---------|
|
|
42
|
-
| `GIT_DIR == GIT_COMMON
|
|
43
|
-
| `GIT_DIR != GIT_COMMON
|
|
44
|
-
| `GIT_DIR != GIT_COMMON
|
|
44
|
+
| `GIT_DIR == GIT_COMMON` (normal repo) | Standard 3 options | No worktree to clean up |
|
|
45
|
+
| `GIT_DIR != GIT_COMMON`, named branch | Standard 3 options | Provenance-based (see Step 6) |
|
|
46
|
+
| `GIT_DIR != GIT_COMMON`, detached HEAD | Reduced 2 options (no merge) | Externally managed — leave in place |
|
|
45
47
|
|
|
46
|
-
##
|
|
48
|
+
## Step 3: Determine Base Branch
|
|
47
49
|
|
|
48
|
-
|
|
50
|
+
The base branch is whatever this work forked from — usually named in the
|
|
51
|
+
plan, the conversation, or the branch's upstream. If it is not already
|
|
52
|
+
known, ask: "This branch split from <your best guess> - is that correct?"
|
|
53
|
+
Confirm before merging: merging into the wrong base is expensive to undo.
|
|
49
54
|
|
|
50
|
-
##
|
|
55
|
+
## Step 4: Present Options
|
|
51
56
|
|
|
52
|
-
|
|
57
|
+
**Normal repo and named-branch worktree — present exactly these 3 options:**
|
|
53
58
|
|
|
54
59
|
```
|
|
55
|
-
|
|
60
|
+
Implementation complete. What would you like to do?
|
|
56
61
|
|
|
57
|
-
1.
|
|
58
|
-
2.
|
|
59
|
-
3.
|
|
62
|
+
1. Merge back to <base-branch> locally
|
|
63
|
+
2. Push and create a Pull Request
|
|
64
|
+
3. Keep the branch as-is (I'll handle it later)
|
|
60
65
|
|
|
61
|
-
|
|
66
|
+
Which option?
|
|
62
67
|
```
|
|
63
68
|
|
|
64
|
-
|
|
69
|
+
**Detached HEAD — present exactly these 2 options:**
|
|
65
70
|
|
|
66
71
|
```
|
|
67
|
-
|
|
72
|
+
Implementation complete. You're on a detached HEAD (externally managed workspace).
|
|
68
73
|
|
|
69
|
-
1.
|
|
70
|
-
2.
|
|
74
|
+
1. Push as new branch and create a Pull Request
|
|
75
|
+
2. Keep as-is (I'll handle it later)
|
|
71
76
|
|
|
72
|
-
|
|
77
|
+
Which option?
|
|
73
78
|
```
|
|
74
79
|
|
|
75
|
-
|
|
80
|
+
Present the menu exactly as written — concise, with every option coming
|
|
81
|
+
from the list above. Discarding the work happens only in response to your
|
|
82
|
+
human partner explicitly asking for it (see "If your human partner asks to
|
|
83
|
+
discard the work" below). Wait for their answer; the integration decision
|
|
84
|
+
is theirs.
|
|
76
85
|
|
|
77
|
-
##
|
|
86
|
+
## Step 5: Execute Choice
|
|
78
87
|
|
|
79
|
-
###
|
|
88
|
+
### Option 1: Merge Locally
|
|
80
89
|
|
|
81
90
|
```bash
|
|
82
91
|
# Get main repo root for CWD safety
|
|
@@ -92,15 +101,18 @@ git merge <feature-branch>
|
|
|
92
101
|
<test command>
|
|
93
102
|
```
|
|
94
103
|
|
|
95
|
-
|
|
104
|
+
If tests fail on the merged result: stop, leave the worktree and branch in
|
|
105
|
+
place, and investigate — nothing has been pushed, so the merge is local
|
|
106
|
+
and recoverable.
|
|
96
107
|
|
|
97
|
-
|
|
108
|
+
Once the merged result is green: clean up the worktree (Step 6), then
|
|
109
|
+
delete the branch:
|
|
98
110
|
|
|
99
111
|
```bash
|
|
100
112
|
git branch -d <feature-branch>
|
|
101
113
|
```
|
|
102
114
|
|
|
103
|
-
###
|
|
115
|
+
### Option 2: Push and Create PR
|
|
104
116
|
|
|
105
117
|
```bash
|
|
106
118
|
git push -u origin <feature-branch>
|
|
@@ -108,95 +120,108 @@ git push -u origin <feature-branch>
|
|
|
108
120
|
# git push origin HEAD:refs/heads/<new-branch>
|
|
109
121
|
```
|
|
110
122
|
|
|
111
|
-
|
|
123
|
+
Then create the pull/merge request against <base-branch> with the forge's
|
|
124
|
+
tooling — its CLI if one is available, or the creation URL most forges
|
|
125
|
+
print when you push — following the repo's PR template and conventions if
|
|
126
|
+
present, and report the URL to your human partner.
|
|
112
127
|
|
|
113
|
-
|
|
128
|
+
Keep the worktree — your human partner iterates on PR feedback there.
|
|
114
129
|
|
|
115
|
-
###
|
|
130
|
+
### Option 3: Keep As-Is
|
|
116
131
|
|
|
117
|
-
|
|
132
|
+
Report: "Keeping branch <name>. Worktree preserved at <path>."
|
|
118
133
|
|
|
119
|
-
###
|
|
134
|
+
### If your human partner asks to discard the work
|
|
120
135
|
|
|
121
|
-
|
|
136
|
+
This path exists only as a response to an explicit request to throw the
|
|
137
|
+
work away. Confirm first:
|
|
122
138
|
|
|
123
139
|
```
|
|
124
|
-
|
|
125
|
-
-
|
|
126
|
-
-
|
|
127
|
-
-
|
|
140
|
+
This will permanently delete:
|
|
141
|
+
- Branch <name>
|
|
142
|
+
- All commits: <commit-list>
|
|
143
|
+
- Worktree at <path>
|
|
128
144
|
|
|
129
|
-
|
|
145
|
+
Type 'discard' to confirm.
|
|
130
146
|
```
|
|
131
147
|
|
|
132
|
-
|
|
148
|
+
Wait for that exact confirmation. When it arrives:
|
|
133
149
|
|
|
134
150
|
```bash
|
|
135
151
|
MAIN_ROOT=$(git -C "$(git rev-parse --git-common-dir)/.." rev-parse --show-toplevel)
|
|
136
152
|
cd "$MAIN_ROOT"
|
|
137
153
|
```
|
|
138
154
|
|
|
139
|
-
|
|
155
|
+
Then clean up the worktree (Step 6) and force-delete the branch:
|
|
140
156
|
|
|
141
157
|
```bash
|
|
142
158
|
git branch -D <feature-branch>
|
|
143
159
|
```
|
|
144
160
|
|
|
145
|
-
##
|
|
161
|
+
## Step 6: Cleanup Workspace
|
|
146
162
|
|
|
147
|
-
|
|
163
|
+
**Runs for Option 1 and confirmed discards.** Options 2 and 3 always
|
|
164
|
+
preserve the worktree. Both callers have already changed directory to the
|
|
165
|
+
main repo root — worktree removal must run from outside the worktree —
|
|
166
|
+
and use the `GIT_DIR`/`GIT_COMMON`/`WORKTREE_PATH` values captured in
|
|
167
|
+
Step 2, from before that directory change.
|
|
148
168
|
|
|
149
|
-
|
|
169
|
+
**If `GIT_DIR == GIT_COMMON`:** Normal repo, no worktree to clean up. Done.
|
|
150
170
|
|
|
151
|
-
|
|
171
|
+
**If `WORKTREE_PATH` is under `.worktrees/` or `worktrees/`:** Superpowers
|
|
172
|
+
created this worktree — we own cleanup:
|
|
152
173
|
|
|
153
174
|
```bash
|
|
154
175
|
git worktree remove "$WORKTREE_PATH"
|
|
155
176
|
git worktree prune # Self-healing: clean up any stale registrations
|
|
156
177
|
```
|
|
157
178
|
|
|
158
|
-
|
|
179
|
+
**If removal is refused** (`contains modified or untracked files`): the
|
|
180
|
+
worktree holds files that exist nowhere else — uncommitted plans, notes,
|
|
181
|
+
or scratch work. Never `--force` on your own initiative. Show your human
|
|
182
|
+
partner what is at stake and ask:
|
|
159
183
|
|
|
160
184
|
```bash
|
|
161
185
|
git -C "$WORKTREE_PATH" status --porcelain -uall
|
|
162
186
|
```
|
|
163
187
|
|
|
164
188
|
```
|
|
165
|
-
|
|
189
|
+
Worktree removal refused — these files were never committed:
|
|
166
190
|
|
|
167
191
|
<file list>
|
|
168
192
|
|
|
169
|
-
1.
|
|
170
|
-
2.
|
|
171
|
-
3.
|
|
193
|
+
1. Commit them to <branch> before cleanup
|
|
194
|
+
2. Move them into <main repo root>
|
|
195
|
+
3. Delete them (unrecoverable)
|
|
172
196
|
|
|
173
|
-
|
|
197
|
+
Which?
|
|
174
198
|
```
|
|
175
199
|
|
|
176
|
-
|
|
200
|
+
Carry out the choice, then remove the worktree.
|
|
177
201
|
|
|
178
|
-
|
|
202
|
+
**Otherwise:** The host environment owns this workspace — leave it in
|
|
203
|
+
place. If your platform provides a workspace-exit tool, use it.
|
|
179
204
|
|
|
180
|
-
##
|
|
205
|
+
## Quick Reference
|
|
181
206
|
|
|
182
|
-
|
|
|
207
|
+
| Option | Merge | Push | Keep Worktree | Cleanup Branch |
|
|
183
208
|
|--------|-------|------|---------------|----------------|
|
|
184
|
-
| 1.
|
|
185
|
-
| 2.
|
|
186
|
-
| 3.
|
|
187
|
-
|
|
|
209
|
+
| 1. Merge locally | yes | - | - | yes |
|
|
210
|
+
| 2. Create PR | - | yes | yes | - |
|
|
211
|
+
| 3. Keep as-is | - | - | yes | - |
|
|
212
|
+
| Discard (explicit request only) | - | - | - | yes (force) |
|
|
188
213
|
|
|
189
|
-
##
|
|
214
|
+
## Common Rationalizations
|
|
190
215
|
|
|
191
|
-
|
|
|
216
|
+
| Excuse | Reality |
|
|
192
217
|
|--------|---------|
|
|
193
|
-
|
|
|
194
|
-
|
|
|
195
|
-
|
|
|
196
|
-
|
|
|
197
|
-
|
|
|
198
|
-
|
|
|
199
|
-
|
|
|
200
|
-
|
|
|
201
|
-
|
|
|
202
|
-
|
|
|
218
|
+
| "Tests passed earlier this session" | Run the suite on the tree you are about to integrate. A green run only proves the tree it ran on. |
|
|
219
|
+
| "They obviously want it merged" | Integration is your human partner's decision. Present the menu and wait. |
|
|
220
|
+
| "They seem done with this feature — I'll offer to discard it" | The menu is complete as written. Discard happens only when your human partner asks for it in so many words. |
|
|
221
|
+
| "'Yeah, get rid of it' counts as confirmation" | Only the typed word `discard` authorizes deletion. |
|
|
222
|
+
| "The PR is up, so the worktree is clutter now" | PR feedback gets fixed in that worktree. It stays until the work lands. |
|
|
223
|
+
| "This other worktree looks stale — I'll clean it too" | Clean up only worktrees under `.worktrees/` or `worktrees/`. Everything else belongs to the host. |
|
|
224
|
+
| "Removal refused — `--force` is just finishing the cleanup" | The refusal means files exist only in that worktree. `--force` destroys them permanently. Show your human partner and ask. |
|
|
225
|
+
| "The merged-result failure is probably flaky" | A failing merged result stops everything. Branch and worktree stay put while you investigate. |
|
|
226
|
+
| "The base branch is obviously main" | Confirm the fork point or ask. Merging into the wrong base is expensive to undo. |
|
|
227
|
+
| "The push was rejected — force-push will fix it" | A rejected push means the remote moved. Investigate; force-push only on your human partner's explicit request. |
|
|
@@ -1,205 +1,207 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: receiving-code-review
|
|
3
|
-
description: "Superpower Skill
|
|
3
|
+
description: "Superpower Skill: Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation"
|
|
4
|
+
description_zh: "Superpower Skill:收到代码评审意见时使用,实施建议前需技术验证与澄清,适用于反馈模糊或存疑场景,强调严谨核实而非盲从。"
|
|
4
5
|
---
|
|
5
6
|
|
|
6
|
-
# 接收代码评审
|
|
7
7
|
|
|
8
|
-
|
|
8
|
+
# Code Review Reception
|
|
9
9
|
|
|
10
|
-
|
|
10
|
+
## Overview
|
|
11
11
|
|
|
12
|
-
|
|
12
|
+
Code review requires technical evaluation, not emotional performance.
|
|
13
13
|
|
|
14
|
-
|
|
14
|
+
**Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
|
|
15
|
+
|
|
16
|
+
## The Response Pattern
|
|
15
17
|
|
|
16
18
|
```
|
|
17
|
-
WHEN
|
|
19
|
+
WHEN receiving code review feedback:
|
|
18
20
|
|
|
19
|
-
1.
|
|
20
|
-
2.
|
|
21
|
-
3.
|
|
22
|
-
4.
|
|
23
|
-
5.
|
|
24
|
-
6.
|
|
21
|
+
1. READ: Complete feedback without reacting
|
|
22
|
+
2. UNDERSTAND: Restate requirement in own words (or ask)
|
|
23
|
+
3. VERIFY: Check against codebase reality
|
|
24
|
+
4. EVALUATE: Technically sound for THIS codebase?
|
|
25
|
+
5. RESPOND: Technical acknowledgment or reasoned pushback
|
|
26
|
+
6. IMPLEMENT: One item at a time, test each
|
|
25
27
|
```
|
|
26
28
|
|
|
27
|
-
##
|
|
29
|
+
## Forbidden Responses
|
|
28
30
|
|
|
29
|
-
|
|
30
|
-
- "
|
|
31
|
-
- "
|
|
32
|
-
- "
|
|
31
|
+
**NEVER:**
|
|
32
|
+
- "You're absolutely right!" (explicit instruction-file violation)
|
|
33
|
+
- "Great point!" / "Excellent feedback!" (performative)
|
|
34
|
+
- "Let me implement that now" (before verification)
|
|
33
35
|
|
|
34
|
-
|
|
35
|
-
-
|
|
36
|
-
-
|
|
37
|
-
-
|
|
38
|
-
-
|
|
36
|
+
**INSTEAD:**
|
|
37
|
+
- Restate the technical requirement
|
|
38
|
+
- Ask clarifying questions
|
|
39
|
+
- Push back with technical reasoning if wrong
|
|
40
|
+
- Just start working (actions > words)
|
|
39
41
|
|
|
40
|
-
##
|
|
42
|
+
## Handling Unclear Feedback
|
|
41
43
|
|
|
42
44
|
```
|
|
43
|
-
IF
|
|
44
|
-
|
|
45
|
-
|
|
45
|
+
IF any item is unclear:
|
|
46
|
+
STOP - do not implement anything yet
|
|
47
|
+
ASK for clarification on unclear items
|
|
46
48
|
|
|
47
|
-
|
|
49
|
+
WHY: Items may be related. Partial understanding = wrong implementation.
|
|
48
50
|
```
|
|
49
51
|
|
|
50
|
-
|
|
52
|
+
**Example:**
|
|
51
53
|
```
|
|
52
|
-
|
|
53
|
-
|
|
54
|
+
your human partner: "Fix 1-6"
|
|
55
|
+
You understand 1,2,3,6. Unclear on 4,5.
|
|
54
56
|
|
|
55
|
-
[FAIL]
|
|
56
|
-
[OK]
|
|
57
|
+
[FAIL] WRONG: Implement 1,2,3,6 now, ask about 4,5 later
|
|
58
|
+
[OK] RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
|
|
57
59
|
```
|
|
58
60
|
|
|
59
|
-
##
|
|
61
|
+
## Source-Specific Handling
|
|
60
62
|
|
|
61
|
-
###
|
|
62
|
-
-
|
|
63
|
-
-
|
|
64
|
-
-
|
|
65
|
-
-
|
|
63
|
+
### From your human partner
|
|
64
|
+
- **Trusted** - implement after understanding
|
|
65
|
+
- **Still ask** if scope unclear
|
|
66
|
+
- **No performative agreement**
|
|
67
|
+
- **Skip to action** or technical acknowledgment
|
|
66
68
|
|
|
67
|
-
###
|
|
69
|
+
### From External Reviewers
|
|
68
70
|
```
|
|
69
|
-
|
|
70
|
-
1.
|
|
71
|
-
2.
|
|
72
|
-
3.
|
|
73
|
-
4.
|
|
74
|
-
5.
|
|
71
|
+
BEFORE implementing:
|
|
72
|
+
1. Check: Technically correct for THIS codebase?
|
|
73
|
+
2. Check: Breaks existing functionality?
|
|
74
|
+
3. Check: Reason for current implementation?
|
|
75
|
+
4. Check: Works on all platforms/versions?
|
|
76
|
+
5. Check: Does reviewer understand full context?
|
|
75
77
|
|
|
76
|
-
IF
|
|
77
|
-
|
|
78
|
+
IF suggestion seems wrong:
|
|
79
|
+
Push back with technical reasoning
|
|
78
80
|
|
|
79
|
-
IF
|
|
80
|
-
|
|
81
|
+
IF can't easily verify:
|
|
82
|
+
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
|
|
81
83
|
|
|
82
|
-
IF
|
|
83
|
-
|
|
84
|
+
IF conflicts with your human partner's prior decisions:
|
|
85
|
+
Stop and discuss with your human partner first
|
|
84
86
|
```
|
|
85
87
|
|
|
86
|
-
|
|
88
|
+
**your human partner's rule:** "External feedback - be skeptical, but check carefully"
|
|
87
89
|
|
|
88
|
-
##
|
|
90
|
+
## YAGNI Check for "Professional" Features
|
|
89
91
|
|
|
90
92
|
```
|
|
91
|
-
IF reviewer
|
|
92
|
-
grep
|
|
93
|
+
IF reviewer suggests "implementing properly":
|
|
94
|
+
grep codebase for actual usage
|
|
93
95
|
|
|
94
|
-
IF
|
|
95
|
-
IF
|
|
96
|
+
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
|
|
97
|
+
IF used: Then implement properly
|
|
96
98
|
```
|
|
97
99
|
|
|
98
|
-
|
|
100
|
+
**your human partner's rule:** "You and reviewer both report to me. If we don't need this feature, don't add it."
|
|
99
101
|
|
|
100
|
-
##
|
|
102
|
+
## Implementation Order
|
|
101
103
|
|
|
102
104
|
```
|
|
103
|
-
FOR
|
|
104
|
-
1.
|
|
105
|
-
2.
|
|
106
|
-
|
|
107
|
-
|
|
108
|
-
|
|
109
|
-
3.
|
|
110
|
-
4.
|
|
105
|
+
FOR multi-item feedback:
|
|
106
|
+
1. Clarify anything unclear FIRST
|
|
107
|
+
2. Then implement in this order:
|
|
108
|
+
- Blocking issues (breaks, security)
|
|
109
|
+
- Simple fixes (typos, imports)
|
|
110
|
+
- Complex fixes (refactoring, logic)
|
|
111
|
+
3. Test each fix individually
|
|
112
|
+
4. Verify no regressions
|
|
111
113
|
```
|
|
112
114
|
|
|
113
|
-
##
|
|
115
|
+
## When To Push Back
|
|
114
116
|
|
|
115
|
-
|
|
116
|
-
-
|
|
117
|
-
-
|
|
118
|
-
-
|
|
119
|
-
-
|
|
120
|
-
-
|
|
121
|
-
-
|
|
117
|
+
Push back when:
|
|
118
|
+
- Suggestion breaks existing functionality
|
|
119
|
+
- Reviewer lacks full context
|
|
120
|
+
- Violates YAGNI (unused feature)
|
|
121
|
+
- Technically incorrect for this stack
|
|
122
|
+
- Legacy/compatibility reasons exist
|
|
123
|
+
- Conflicts with your human partner's architectural decisions
|
|
122
124
|
|
|
123
|
-
|
|
124
|
-
-
|
|
125
|
-
-
|
|
126
|
-
-
|
|
127
|
-
-
|
|
125
|
+
**How to push back:**
|
|
126
|
+
- Use technical reasoning, not defensiveness
|
|
127
|
+
- Ask specific questions
|
|
128
|
+
- Reference working tests/code
|
|
129
|
+
- Involve your human partner if architectural
|
|
128
130
|
|
|
129
|
-
|
|
131
|
+
**If you're uncomfortable pushing back out loud:** Name that tension, then tell your partner about the issue you've seen. They'll appreciate your honesty.
|
|
130
132
|
|
|
131
|
-
##
|
|
133
|
+
## Acknowledging Correct Feedback
|
|
132
134
|
|
|
133
|
-
|
|
135
|
+
When feedback IS correct:
|
|
134
136
|
```
|
|
135
|
-
[OK] "
|
|
136
|
-
[OK] "
|
|
137
|
-
[OK] [
|
|
137
|
+
[OK] "Fixed. [Brief description of what changed]"
|
|
138
|
+
[OK] "Good catch - [specific issue]. Fixed in [location]."
|
|
139
|
+
[OK] [Just fix it and show in the code]
|
|
138
140
|
|
|
139
|
-
[FAIL] "
|
|
140
|
-
[FAIL] "
|
|
141
|
-
[FAIL] "
|
|
142
|
-
[FAIL] "
|
|
143
|
-
[FAIL]
|
|
141
|
+
[FAIL] "You're absolutely right!"
|
|
142
|
+
[FAIL] "Great point!"
|
|
143
|
+
[FAIL] "Thanks for catching that!"
|
|
144
|
+
[FAIL] "Thanks for [anything]"
|
|
145
|
+
[FAIL] ANY gratitude expression
|
|
144
146
|
```
|
|
145
147
|
|
|
146
|
-
|
|
148
|
+
**Why no thanks:** Actions speak. Just fix it. The code itself shows you heard the feedback.
|
|
147
149
|
|
|
148
|
-
|
|
150
|
+
**If you catch yourself about to write "Thanks":** DELETE IT. State the fix instead.
|
|
149
151
|
|
|
150
|
-
##
|
|
152
|
+
## Gracefully Correcting Your Pushback
|
|
151
153
|
|
|
152
|
-
|
|
154
|
+
If you pushed back and were wrong:
|
|
153
155
|
```
|
|
154
|
-
[OK] "
|
|
155
|
-
[OK] "
|
|
156
|
+
[OK] "You were right - I checked [X] and it does [Y]. Implementing now."
|
|
157
|
+
[OK] "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
|
|
156
158
|
|
|
157
|
-
[FAIL]
|
|
158
|
-
[FAIL]
|
|
159
|
-
[FAIL]
|
|
159
|
+
[FAIL] Long apology
|
|
160
|
+
[FAIL] Defending why you pushed back
|
|
161
|
+
[FAIL] Over-explaining
|
|
160
162
|
```
|
|
161
163
|
|
|
162
|
-
|
|
164
|
+
State the correction factually and move on.
|
|
163
165
|
|
|
164
|
-
##
|
|
166
|
+
## Common Mistakes
|
|
165
167
|
|
|
166
|
-
|
|
|
168
|
+
| Mistake | Fix |
|
|
167
169
|
|---------|-----|
|
|
168
|
-
|
|
|
169
|
-
|
|
|
170
|
-
|
|
|
171
|
-
|
|
|
172
|
-
|
|
|
173
|
-
|
|
|
174
|
-
|
|
|
170
|
+
| Performative agreement | State requirement or just act |
|
|
171
|
+
| Blind implementation | Verify against codebase first |
|
|
172
|
+
| Batch without testing | One at a time, test each |
|
|
173
|
+
| Assuming reviewer is right | Check if breaks things |
|
|
174
|
+
| Avoiding pushback | Technical correctness > comfort |
|
|
175
|
+
| Partial implementation | Clarify all items first |
|
|
176
|
+
| Can't verify, proceed anyway | State limitation, ask for direction |
|
|
175
177
|
|
|
176
|
-
##
|
|
178
|
+
## Real Examples
|
|
177
179
|
|
|
178
|
-
|
|
180
|
+
**Performative Agreement (Bad):**
|
|
179
181
|
```
|
|
180
|
-
|
|
181
|
-
[FAIL] "
|
|
182
|
+
Reviewer: "Remove legacy code"
|
|
183
|
+
[FAIL] "You're absolutely right! Let me remove that..."
|
|
182
184
|
```
|
|
183
185
|
|
|
184
|
-
|
|
186
|
+
**Technical Verification (Good):**
|
|
185
187
|
```
|
|
186
|
-
|
|
187
|
-
[OK] "
|
|
188
|
+
Reviewer: "Remove legacy code"
|
|
189
|
+
[OK] "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
|
|
188
190
|
```
|
|
189
191
|
|
|
190
|
-
**YAGNI
|
|
192
|
+
**YAGNI (Good):**
|
|
191
193
|
```
|
|
192
|
-
|
|
193
|
-
[OK] "
|
|
194
|
+
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
|
|
195
|
+
[OK] "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
|
|
194
196
|
```
|
|
195
197
|
|
|
196
|
-
|
|
198
|
+
**Unclear Item (Good):**
|
|
197
199
|
```
|
|
198
|
-
|
|
199
|
-
|
|
200
|
-
[OK] "
|
|
200
|
+
your human partner: "Fix items 1-6"
|
|
201
|
+
You understand 1,2,3,6. Unclear on 4,5.
|
|
202
|
+
[OK] "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
|
|
201
203
|
```
|
|
202
204
|
|
|
203
|
-
## GitHub
|
|
205
|
+
## GitHub Thread Replies
|
|
204
206
|
|
|
205
|
-
|
|
207
|
+
When replying to inline review comments on GitHub, reply in the comment thread (`gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies`), not as a top-level PR comment.
|