@wemap/positioning 2.4.5 → 2.4.6

package/package.json

@@ -8,10 +8,10 @@
     "Guillaume Pannetier <guillaume.pannetier@getwemap.com>"
   ],
   "dependencies": {
-    "@wemap/geo": "^0.3.6",
+    "@wemap/geo": "^0.3.7",
     "@wemap/logger": "^0.1.6",
     "@wemap/maths": "^0.2.1",
-    "@wemap/osm": "^0.2.8",
+    "@wemap/osm": "^0.2.9",
     "@wemap/utils": "^0.1.2",
     "geomagnetism": "^0.1.0",
     "lodash.isempty": "^4.4.0",
@@ -80,5 +80,5 @@
     "lint": "eslint --ext .js,.jsx --quiet src",
     "test": "mocha -r esm \"src/**/*.spec.js\""
   },
-  "version": "2.4.5"
+  "version": "2.4.6"
 }

package/src/providers/pose/pdr/helpers/Smoother.js

@@ -1,6 +1,5 @@
-/* eslint-disable max-statements */
+/* eslint max-statements: ["error", 27]*/
 import { WGS84UserPosition } from '@wemap/geo';
-import { rad2deg } from '@wemap/maths';
 
 // Generated positions by second
 const GEN_FREQUENCY = 60;
@@ -18,49 +17,50 @@ class Smoother {
     /**
      * Calculate smoothed positions for the next milliseconds given a new position
      */
-    generateNextPositions(newPosition, flyby = false) {
+    generateNextPositions(_newPosition, flyby = false) {
 
-        if (!(newPosition instanceof WGS84UserPosition)) {
+        if (!(_newPosition instanceof WGS84UserPosition)) {
             throw new TypeError('newPosition is not instance of WGS84UserPosition');
         }
 
+        const newPosition = _newPosition.clone();
         if (!newPosition.hasOwnProperty('time')) {
             throw new Error('newPosition does not have time property');
         }
 
-        if (this.previousPosition) {
+        if (!this.previousPosition) {
+            this.previousPosition = newPosition;
+            this.positionsQueue.push(this.previousPosition);
+            return;
+        }
 
-            const distance = this.previousPosition.distanceTo(newPosition);
-            const azimuth = this.previousPosition.bearingTo(newPosition);
+        const distance = this.previousPosition.distanceTo(newPosition);
+        const azimuth = this.previousPosition.bearingTo(newPosition);
 
-            let refTimestamp = newPosition.time;
+        let refTimestamp = newPosition.time;
 
-            const queueLength = this.positionsQueue.length;
-            if (queueLength) {
-                refTimestamp = Math.max(refTimestamp, this.positionsQueue[queueLength - 1].time);
-            }
+        const queueLength = this.positionsQueue.length;
+        if (queueLength) {
+            refTimestamp = Math.max(refTimestamp, this.positionsQueue[queueLength - 1].time);
+        }
 
-            let diffTime = newPosition.time - this.previousPosition.time;
+        let diffTime = newPosition.time - this.previousPosition.time;
 
-            if (flyby) {
-                diffTime = MAX_FLYBY_TIME;
-            }
+        if (flyby) {
+            diffTime = MAX_FLYBY_TIME;
+        }
 
-            const nSamples = GEN_FREQUENCY * Math.min(Math.max(MIN_FLYBY_TIME, diffTime), MAX_FLYBY_TIME);
+        const nSamples = GEN_FREQUENCY * Math.min(Math.max(MIN_FLYBY_TIME, diffTime), MAX_FLYBY_TIME);
 
-            let i = 1;
-            while (i < nSamples) {
-                i = Math.min(i, nSamples);
-                const smoothedPosition = this.previousPosition.destinationPoint(distance * i / nSamples, azimuth);
-                smoothedPosition.time = refTimestamp + (i - 1) / GEN_FREQUENCY;
-                smoothedPosition.bearing = rad2deg(azimuth);
-                this.positionsQueue.push(smoothedPosition);
-                i++;
-            }
-            newPosition.bearing = rad2deg(azimuth);
+        let i = 1;
+        while (i < nSamples + 1) {
+            i = Math.min(i, nSamples);
+            const smoothedPosition = this.previousPosition.destinationPoint(distance * i / nSamples, azimuth);
+            smoothedPosition.time = refTimestamp + (i - 1) / GEN_FREQUENCY;
+            this.positionsQueue.push(smoothedPosition);
+            i++;
         }
 
-        this.positionsQueue.push(newPosition);
         this.previousPosition = newPosition;
     }