@wemap/osm 3.0.0 → 3.1.0

package/package.json

@@ -11,7 +11,7 @@
         "directory": "packages/osm"
     },
     "name": "@wemap/osm",
-    "version": "3.0.0",
+    "version": "3.1.0",
     "bugs": {
         "url": "https://github.com/wemap/wemap-modules-js/issues"
     },
@@ -32,5 +32,5 @@
         "lodash.isnumber": "^3.0.3",
         "sax": "^1.2.4"
     },
-    "gitHead": "2bbb4840a99b90eaae989291cb728ac87cebade8"
+    "gitHead": "65aa989226647982201e95ecafae68e2e48e85ae"
 }

package/src/network/OsmRouter.spec.js

@@ -87,8 +87,9 @@ describe('OsmRouter - Multi-level itinerary', () => {
     it('do not use stairs', () => {
         const itineraryWithoutStairs = router.getShortestPath(itineraryStart, itineraryEnd, { useStairs: false });
         expect(itineraryWithoutStairs.nodes.length).equal(11);
-        expect(itineraryWithoutStairs.nodes[6].data.tags.highway).equal('elevator');
-        expect(itineraryWithoutStairs.nodes[7].data.tags.highway).equal('elevator');
+        expect(itineraryWithoutStairs.nodes[6].data.isElevator).is.true;
+        expect(itineraryWithoutStairs.nodes[7].data.isElevator).is.true;
+        expect(itineraryWithoutStairs.edges[6].data.isElevator).is.true;
     });
 
 });

package/src/osrm/OsrmUtils.js

@@ -25,7 +25,7 @@ class OsrmUtils {
 
             const {
                 nodes, length, nextEdgeData, nextBearing, previousBearing, angle, node,
-                duration, levelChange
+                duration, levelChange, edges
             } = itinerarySteps[i];
 
             const edgeData = i !== lastStepId ? nextEdgeData : itinerary.edges[lastStepId];
@@ -66,10 +66,17 @@ class OsrmUtils {
             }
 
             if (i !== lastStepId) {
-                osrmStep.wemap.nextWay = {
+                osrmStep.wemap.nextEdgeData = {
                     id: nextEdgeData.id,
                     tags: nextEdgeData.tags
                 };
+                if (edges[0].data instanceof OsmNode) {
+                    osrmStep.wemap.nextEdgeData.type = 'node';
+                    osrmStep.wemap.nextEdgeData.coords = OsrmUtils.coordinatesToJson(edges[0].data.coords);
+                }
+                if (edges[0].data instanceof OsmWay) {
+                    osrmStep.wemap.nextEdgeData.type = 'way';
+                }
             }
 
             // The first modifier is not mandatory by OSRM.
@@ -225,12 +232,18 @@ class OsrmUtils {
                 }
 
                 const firstEdge = step.edges[0];
-                if (jsonStep.wemap.nextWay && firstEdge) {
+                if (jsonStep.wemap.nextEdgeData && firstEdge) {
                     const {
-                        id, tags
-                    } = jsonStep.wemap.nextWay;
-                    firstEdge.data = new OsmWay(id, tags);
-                    firstEdge.data.level = firstEdge.level;
+                        coords, id, tags, type
+                    } = jsonStep.wemap.nextEdgeData;
+                    if (type === 'node') {
+                        firstEdge.data = new OsmNode(id, OsrmUtils.jsonToCoordinates(coords), tags);
+                    } else if (type === 'way') {
+                        firstEdge.data = new OsmWay(id, tags);
+                    }
+                    if (firstEdge.data) {
+                        firstEdge.data.level = firstEdge.level;
+                    }
                 }
             }
 

package/src/osrm/OsrmUtils.spec.js

@@ -11,6 +11,7 @@ import OsmParser from '../model/OsmParser';
 import OsmRouter from '../network/OsmRouter';
 import OsmNetwork from '../network/OsmNetwork';
 import OsrmUtils from './OsrmUtils';
+import OsmNode from '../model/OsmNode';
 
 
 const load = fileName => {
@@ -297,6 +298,26 @@ describe('OsrmUtils - createItineraryFromJson', () => {
 
 });
 
+describe('OsrmUtils - itineraryToOsrmJson - createItineraryFromJson - elevator', () => {
+
+    it('With levels (Bureaux Wemap)', () => {
+
+        const { router } = load('bureaux-wemap-montpellier-network.osm');
+
+        const start = new Coordinates(43.6092754, 3.8842306, null, new Level(2));
+        const end = new Coordinates(43.60949854, 3.88452048, null, new Level(0));
+        const itinerary = router.getShortestPath(start, end);
+
+        const osrmJson = OsrmUtils.itineraryToOsrmJson(itinerary);
+        const jsonSteps = osrmJson.routes[0].legs[0].steps;
+
+        expect(jsonSteps[4].wemap.nextEdgeData.type).equals('node');
+
+        const itineraryBis = OsrmUtils.createItineraryFromJson(osrmJson, start, end);
+        expect(itineraryBis.steps[4].edges[0].data).instanceOf(OsmNode);
+    });
+});
+
 describe('OsrmUtils - Output JSON', () => {
 
     it('noRouteFoundJson', () => {