@wemap/osm 2.7.5 → 2.7.7

package/assets/itinerary-montpellier-outdoor-errored.json

@@ -0,0 +1 @@
+{"code":"Ok","routes":[{"geometry":{"coordinates":[[3.875607,43.600777],[3.875723,43.600109],[3.875766,43.600086],[3.876247,43.599974],[3.876341,43.599956],[3.876396,43.599881],[3.876234,43.599853],[3.875869,43.599787],[3.875829,43.599781],[3.875671,43.599759],[3.875643,43.599755],[3.875606,43.599749],[3.875578,43.599746],[3.875498,43.599734],[3.87536,43.599707],[3.875169,43.599674],[3.874655,43.599577],[3.874623,43.599063],[3.873865,43.59906]],"type":"LineString"},"legs":[{"steps":[{"intersections":[{"out":0,"entry":[true],"bearings":[173],"location":[3.875607,43.600777]}],"driving_side":"right","geometry":{"coordinates":[[3.875607,43.600777],[3.875723,43.600109],[3.875766,43.600086],[3.876247,43.599974],[3.876341,43.599956],[3.876396,43.599881]],"type":"LineString"},"mode":"walking","duration":98.7,"maneuver":{"bearing_after":173,"type":"depart","modifier":"left","bearing_before":0,"location":[3.875607,43.600777]},"weight":98.7,"distance":137.2,"name":""},{"intersections":[{"out":1,"location":[3.876396,43.599881],"bearings":[75,255,330],"entry":[true,true,false],"in":2},{"out":2,"location":[3.876234,43.599853],"bearings":[75,180,255],"entry":[false,true,true],"in":0},{"out":2,"location":[3.875829,43.599781],"bearings":[75,195,255],"entry":[false,true,true],"in":0},{"out":2,"location":[3.875643,43.599755],"bearings":[75,135,255],"entry":[false,true,true],"in":0},{"out":2,"location":[3.875498,43.599734],"bearings":[75,165,255,345],"entry":[false,true,true,true],"in":0},{"out":2,"location":[3.875169,43.599674],"bearings":[75,180,255],"entry":[false,true,true],"in":0}],"driving_side":"right","geometry":{"coordinates":[[3.876396,43.599881],[3.876234,43.599853],[3.875869,43.599787],[3.875829,43.599781],[3.875671,43.599759],[4.875643,43.599755],[3.875606,43.599749],[3.875578,43.599746],[3.875498,43.599734],[3.87536,43.599707],[3.875169,43.599674],[3.874655,43.599577]],"type":"LineString"},"mode":"walking","duration":103.9,"maneuver":{"bearing_after":255,"type":"turn","modifier":"right","bearing_before":149,"location":[3.876396,43.599881]},"weight":103.9,"distance":144.3,"name":"Boulevard Vieussens"},{"intersections":[{"out":1,"location":[3.874655,43.599577],"bearings":[75,180,255],"entry":[false,true,true],"in":0}],"driving_side":"right","geometry":{"coordinates":[[3.874655,43.599577],[3.874623,43.599063]],"type":"LineString"},"mode":"walking","duration":41.2,"maneuver":{"bearing_after":181,"type":"turn","modifier":"left","bearing_before":254,"location":[3.874655,43.599577]},"weight":41.2,"distance":57.2,"name":"Impasse Bizeray"},{"intersections":[{"out":2,"location":[3.874623,43.599063],"bearings":[0,90,270],"entry":[false,true,true],"in":0}],"driving_side":"right","geometry":{"coordinates":[[3.874623,43.599063],[3.873865,43.59906]],"type":"LineString"},"mode":"walking","duration":44,"maneuver":{"bearing_after":268,"type":"turn","modifier":"right","bearing_before":181,"location":[3.874623,43.599063]},"weight":44,"distance":61.1,"name":"Rue du Docteur Louis Perrier"},{"intersections":[{"in":0,"entry":[true],"bearings":[90],"location":[3.873865,43.59906]}],"driving_side":"right","geometry":{"coordinates":[[3.873865,43.59906],[3.873865,43.59906]],"type":"LineString"},"mode":"walking","duration":0,"maneuver":{"bearing_after":0,"type":"arrive","modifier":"left","bearing_before":270,"location":[3.873865,43.59906]},"weight":0,"distance":0,"name":"Rue du Docteur Louis Perrier"}],"distance":399.7,"duration":287.8,"summary":"Boulevard Vieussens, Boulevard Berthelot","weight":287.8}],"distance":399.7,"duration":287.8,"weight_name":"duration","weight":287.8}],"waypoints":[{"hint":"d89TgaHPU4GmAQAAGwIAAB0AAADAAQAApgEAABsCAAAdAAAAwAEAAAIAAAAXIzsAiUuZAoojOwCTS5kCAQDPCg61bn8=","name":"","location":[3.875607,43.600777]},{"hint":"dNRTgZbUU4FHAAAAuAEAAIMAAAAAAAAARwAAALgBAACDAAAAAAAAAAIAAABJHDsA1ESZAkocOwAdRJkCAwCfBQ61bn8=","name":"Rue du Docteur Louis Perrier","location":[3.873865,43.59906]}]}

package/assets/itinerary-montpellier-outdoor-without-steps.json

@@ -0,0 +1 @@
+{"code":"Ok","routes":[{"geometry":{"coordinates":[[3.875607,43.600777],[3.875723,43.600109],[3.875766,43.600086],[3.876247,43.599974],[3.876341,43.599956],[3.876396,43.599881],[3.876234,43.599853],[3.875869,43.599787],[3.875829,43.599781],[3.875671,43.599759],[3.875643,43.599755],[3.875606,43.599749],[3.875578,43.599746],[3.875498,43.599734],[3.87536,43.599707],[3.875169,43.599674],[3.874655,43.599577],[3.874623,43.599063],[3.873865,43.59906]],"type":"LineString"},"distance":399.7,"duration":287.8,"weight_name":"duration","weight":287.8}],"waypoints":[{"hint":"d89TgaHPU4GmAQAAGwIAAB0AAADAAQAApgEAABsCAAAdAAAAwAEAAAIAAAAXIzsAiUuZAoojOwCTS5kCAQDPCg61bn8=","name":"","location":[3.875607,43.600777]},{"hint":"dNRTgZbUU4FHAAAAuAEAAIMAAAAAAAAARwAAALgBAACDAAAAAAAAAAIAAABJHDsA1ESZAkocOwAdRJkCAwCfBQ61bn8=","name":"Rue du Docteur Louis Perrier","location":[3.873865,43.59906]}]}

package/assets/network-conveying-backward.osm

@@ -0,0 +1,74 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<osm version='0.6' generator='JOSM'>
+  <node id='-519157' action='modify' visible='true' lat='48.84445412307' lon='2.37216128192'>
+    <tag k='name' v='p6' />
+  </node>
+  <node id='-519158' action='modify' visible='true' lat='48.84456231196' lon='2.37194113366'>
+    <tag k='name' v='p11' />
+  </node>
+  <node id='-519161' action='modify' visible='true' lat='48.84459094139' lon='2.37200629832'>
+    <tag k='name' v='p13' />
+  </node>
+  <node id='-519164' action='modify' visible='true' lat='48.8445706698' lon='2.3719601573'>
+    <tag k='name' v='p12' />
+  </node>
+  <node id='1395307661' action='modify' timestamp='2019-09-19T15:44:48Z' uid='439947' user='StephaneP' visible='true' version='11' changeset='74681133' lat='48.8444657' lon='2.3720493'>
+    <tag k='name' v='p7' />
+  </node>
+  <node id='1395307662' action='modify' timestamp='2019-09-19T15:44:48Z' uid='439947' user='StephaneP' visible='true' version='3' changeset='74681133' lat='48.8445534' lon='2.3719505'>
+    <tag k='name' v='p10' />
+  </node>
+  <node id='4086374112' action='modify' timestamp='2019-09-19T16:18:40Z' uid='439947' user='StephaneP' visible='true' version='3' changeset='74683089' lat='48.8444961' lon='2.3720441'>
+    <tag k='name' v='p8' />
+  </node>
+  <node id='4086374115' action='modify' timestamp='2019-09-19T15:44:48Z' uid='439947' user='StephaneP' visible='true' version='2' changeset='74681133' lat='48.844562' lon='2.3719702'>
+    <tag k='name' v='p9' />
+  </node>
+  <node id='4086374120' action='delete' timestamp='2019-09-19T16:18:40Z' uid='439947' user='StephaneP' visible='true' version='3' changeset='74683089' lat='48.8446803' lon='2.3718155'>
+    <tag k='level' v='-1' />
+    <tag k='name' v='p1' />
+    <tag k='railway' v='subway_entrance' />
+    <tag k='ref' v='13' />
+    <tag k='source' v='cadastre-dgi-fr source : Direction Générale des Impôts - Cadastre. Mise à jour : 2011' />
+    <tag k='wheelchair' v='no' />
+  </node>
+  <way id='-519165' action='modify' visible='true'>
+    <nd ref='-519164' />
+    <nd ref='4086374115' />
+    <tag k='highway' v='footway' />
+    <tag k='level' v='0' />
+  </way>
+  <way id='-519168' action='modify' visible='true'>
+    <nd ref='1395307662' />
+    <nd ref='-519158' />
+    <nd ref='-519164' />
+    <nd ref='-519161' />
+    <tag k='highway' v='footway' />
+    <tag k='level' v='0' />
+  </way>
+  <way id='-519174' action='modify' visible='true'>
+    <nd ref='-519157' />
+    <nd ref='4086374112' />
+    <tag k='highway' v='footway' />
+    <tag k='level' v='-1' />
+  </way>
+  <way id='-519225' action='modify' visible='true'>
+    <nd ref='1395307661' />
+    <nd ref='-519157' />
+    <tag k='highway' v='footway' />
+    <tag k='level' v='-1' />
+  </way>
+  <way id='125679471' action='modify' timestamp='2016-04-15T07:37:33Z' uid='1908665' user='naomap' visible='true' version='4' changeset='38579747'>
+    <nd ref='1395307661' />
+    <nd ref='1395307662' />
+    <tag k='highway' v='steps' />
+    <tag k='level' v='-1;0' />
+  </way>
+  <way id='406582305' action='modify' timestamp='2016-04-15T07:37:40Z' uid='1908665' user='naomap' visible='true' version='2' changeset='38579747'>
+    <nd ref='4086374112' />
+    <nd ref='4086374115' />
+    <tag k='conveying' v='backward' />
+    <tag k='highway' v='steps' />
+    <tag k='level' v='-1;0' />
+  </way>
+</osm>

package/assets/network-elevator.osm

@@ -0,0 +1,48 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<osm>
+  <node id='1' lat='43.60933232537' lon='3.88424831515'>
+    <tag k='highway' v='elevator' />
+    <tag k='level' v='1;3' />
+    <tag k='name' v='p2' />
+  </node>
+  <node id='2' lat='43.60932786117' lon='3.88427765877'>
+    <tag k='name' v='p1' />
+  </node>
+  <node id='3' lat='43.60932786111' lon='3.8842776591'>
+    <tag k='name' v='p3' />
+  </node>
+  <node id='4' lat='43.60932198746' lon='3.8843159771'>
+    <tag k='name' v='p4' />
+  </node>
+  <node id='5' lat='43.60932198746' lon='3.8843159771'>
+    <tag k='name' v='p5' />
+  </node>
+  <way id='101'>
+    <nd ref='1' />
+    <nd ref='2' />
+    <tag k='highway' v='footway'>
+    <tag k='level' v='1' />
+    <tag k='name' v='w1' />
+  </way>
+  <way id='102'>
+    <nd ref='1' />
+    <nd ref='3' />
+    <tag k='highway' v='footway'>
+    <tag k='level' v='2' />
+    <tag k='name' v='w2' />
+  </way>
+  <way id='103'>
+    <nd ref='1' />
+    <nd ref='4' />
+    <tag k='highway' v='footway'>
+    <tag k='level' v='3' />
+    <tag k='name' v='w3' />
+  </way>
+  <way id='104'>
+    <nd ref='1' />
+    <nd ref='5' />
+    <tag k='highway' v='footway'>
+    <tag k='level' v='3' />
+    <tag k='name' v='w3-2' />
+  </way>
+</osm>

package/assets/network-simple.osm

@@ -0,0 +1,27 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<osm>
+  <node id='1' lat='43.6093335' lon='3.88428'>
+    <tag k='name' v='p1' />
+  </node>
+  <node id='2' lat='43.60933232537' lon='3.88424831515'>
+    <tag k='name' v='p2' />
+  </node>
+  <node id='3' lat='43.60932786111' lon='3.8842776591'>
+    <tag k='name' v='p3' />
+  </node>
+  <node id='4' lat='43.60932198746' lon='3.8843159771'>
+    <tag k='name' v='p4' />
+  </node>
+  <way id='101'>
+    <nd ref='1' />
+    <nd ref='2' />
+    <nd ref='3' />
+    <tag k='name' v='w1' />
+    <tag k='highway' v='footway' />
+  </way>
+  <way id='102'>
+    <nd ref='3' />
+    <nd ref='4' />
+    <tag k='name' v='w2' />
+  </way>
+</osm>

package/assets/network-with-modifiers.osm

@@ -0,0 +1,39 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<osm version='0.6' generator='JOSM'>
+  <node id='-519658' action='modify' visible='true' lat='48.84421815274' lon='2.37214171465'>
+    <tag k='name' v='start' />
+  </node>
+  <node id='-519659' action='modify' visible='true' lat='48.84493822092' lon='2.37214171465' />
+  <node id='-519661' action='modify' visible='true' lat='48.84431552103' lon='2.37268800579' />
+  <node id='-519663' action='modify' visible='true' lat='48.84395581937' lon='2.37174132231' />
+  <node id='-519665' action='modify' visible='true' lat='48.84395581937' lon='2.37064538259' />
+  <node id='-519667' action='modify' visible='true' lat='48.84395581937' lon='2.36955122674' />
+  <node id='-519669' action='modify' visible='true' lat='48.84359604217' lon='2.36860435126' />
+  <node id='-519671' action='modify' visible='true' lat='48.84297192036' lon='2.36915187515' />
+  <node id='-519673' action='modify' visible='true' lat='48.84368879871' lon='2.36915187515'>
+    <tag k='name' v='end' />
+  </node>
+  <way id='-519660' action='modify' visible='true'>
+    <nd ref='-519658' />
+    <nd ref='-519659' />
+    <nd ref='-519661' />
+    <nd ref='-519663' />
+    <nd ref='-519665' />
+    <tag k='highway' v='footway' />
+    <tag k='level' v='0' />
+  </way>
+  <way id='-519746' action='modify' visible='true'>
+    <nd ref='-519665' />
+    <nd ref='-519667' />
+    <tag k='highway' v='steps' />
+    <tag k='level' v='0;1' />
+  </way>
+  <way id='-519747' action='modify' visible='true'>
+    <nd ref='-519667' />
+    <nd ref='-519669' />
+    <nd ref='-519671' />
+    <nd ref='-519673' />
+    <tag k='highway' v='footway' />
+    <tag k='level' v='1' />
+  </way>
+</osm>

package/assets/simple.osm

@@ -0,0 +1,31 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<osm version='0.6'>
+  <node id='-1' action='modify' visible='true' lat='43.60942861314' lon='3.88420107589'>
+    <tag k='name' v='p1' />
+  </node>
+  <node id='-2' action='modify' visible='true' lat='43.60938929783' lon='3.8841913836'>
+    <tag k='name' v='p2' />
+  </node>
+  <node id='-3' action='modify' visible='true' lat='43.60940277907' lon='3.88421907562'>
+    <tag k='name' v='p3' />
+  </node>
+  <node id='-4' action='modify' visible='true' lat='43.60937924953' lon='3.88418893318'>
+    <tag k='name' v='p4' />
+  </node>
+  <node id='-5' action='delete' visible='true' lat='43.6094255609' lon='3.88422469196'>
+    <tag k='name' v='p5' />
+  </node>
+  <way id='-101' action='modify' visible='true'>
+    <nd ref='-1' />
+    <nd ref='-2' />
+    <nd ref='-3' />
+  </way>
+  <way id='-102' action='modify' visible='true'>
+    <nd ref='-3' />
+    <nd ref='-4' />
+  </way>
+  <way id='-103' action='delete' visible='true'>
+    <nd ref='-4' />
+    <nd ref='-5' />
+  </way>
+</osm>

package/package.json

@@ -11,7 +11,7 @@
         "directory": "packages/osm"
     },
     "name": "@wemap/osm",
-    "version": "2.7.5",
+    "version": "2.7.7",
     "bugs": {
         "url": "https://github.com/wemap/wemap-modules-js/issues"
     },
@@ -26,11 +26,11 @@
     ],
     "license": "ISC",
     "dependencies": {
-        "@wemap/geo": "^2.7.4",
-        "@wemap/graph": "^2.7.4",
-        "@wemap/logger": "^2.7.0",
+        "@wemap/geo": "^2.7.7",
+        "@wemap/graph": "^2.7.7",
+        "@wemap/logger": "^2.7.7",
         "lodash.isnumber": "^3.0.3",
         "sax": "^1.2.4"
     },
-    "gitHead": "5d60aa9ae789520ef5adeb34a8e4d3e5973ed0b2"
+    "gitHead": "988e0675759932cfc6b64df7768c6e6e573df1d9"
 }

package/src/model/OsmElement.js

@@ -1,8 +1,11 @@
 class OsmElement {
 
-    constructor(id) {
+    id = null;
+    tags;
+
+    constructor(id, tags = {}) {
         this.id = id;
-        this.tags = {};
+        this.tags = tags;
     }
 }
 

package/src/model/OsmElement.spec.js

@@ -0,0 +1,11 @@
+import { expect } from 'chai';
+
+import OsmElement from './OsmElement';
+
+describe('OsmElement', () => {
+
+    it('creation', () => {
+        expect(() => new OsmElement(1)).not.throw(Error);
+    });
+
+});

package/src/model/OsmModel.js

@@ -1,24 +1,26 @@
-import OsmParser from './OsmParser';
-
 class OsmModel {
 
-    constructor() {
-        this.nodes = [];
-        this.ways = [];
+    constructor(nodes, ways) {
+        this.nodes = nodes || [];
+        this.ways = ways || [];
     }
 
     getNodeById(id) {
-        return this.nodes.find(node => node.id === id);
+        return this.nodes.find(node => node.id === id) || null;
     }
 
     getNodeByName(name) {
-        return this.nodes.find(node => node.tags.name === name);
+        return this.nodes.find(node => node.tags.name === name) || null;
     }
 
-    static fromXmlString(xmlString) {
-        return OsmParser.parseOsmXmlString(xmlString);
+
+    getWayById(id) {
+        return this.ways.find(way => way.id === id) || null;
     }
 
+    getWayByName(name) {
+        return this.ways.find(way => way.tags.name === name) || null;
+    }
 }
 
 export default OsmModel;

package/src/model/OsmModel.spec.js

@@ -0,0 +1,57 @@
+import { expect } from 'chai';
+
+import { WGS84 } from '@wemap/geo';
+import Logger from '@wemap/logger';
+
+import OsmModel from './OsmModel';
+import OsmNode from './OsmNode';
+import OsmWay from './OsmWay';
+
+Logger.enable(false);
+
+describe('OsmModel', () => {
+
+    const nodes = [
+        new OsmNode(1, new WGS84(45, 5), {name: 'p1'}),
+        new OsmNode(2, new WGS84(46, 5.5), {name: 'p2'}),
+        new OsmNode(3, new WGS84(46.1, 5.3), {name: 'p3'}),
+        new OsmNode(4, new WGS84(46, 5.6), {name: 'p4'})
+    ];
+
+    const ways = [
+        new OsmWay(101, {name: 'w1'}),
+        new OsmWay(102, {name: 'w2'})
+    ];
+
+    ways[0].nodes = [nodes[0], nodes[1], nodes[2]];
+
+
+    it('creation', () => {
+        expect(() => new OsmModel()).not.throw(Error);
+        expect(() => new OsmModel([], [])).not.throw(Error);
+        expect(() => new OsmModel(nodes, ways)).not.throw(Error);
+    });
+
+
+    it('find nodes', () => {
+        const model = new OsmModel(nodes, ways);
+        expect(model.getNodeById(1)).equals(nodes[0]);
+        expect(model.getNodeById(5)).is.null;
+        expect(model.getNodeById(101)).is.null;
+
+        expect(model.getNodeByName('p2')).equals(nodes[1]);
+        expect(model.getNodeByName('p5')).is.null;
+    });
+
+
+    it('find ways', () => {
+        const model = new OsmModel(nodes, ways);
+        expect(model.getWayById(1)).is.null;
+        expect(model.getWayById(5)).is.null;
+        expect(model.getWayById(101)).equals(ways[0]);
+
+        expect(model.getWayByName('w2')).equals(ways[1]);
+        expect(model.getWayByName('w5')).is.null;
+    });
+
+});

package/src/model/OsmNode.js

@@ -1,21 +1,13 @@
-import { WGS84 } from '@wemap/geo';
-
 import OsmElement from './OsmElement';
 
 class OsmNode extends OsmElement {
 
-    constructor(id, coords) {
-        super(id);
-        this.ways = [];
-        this.coords = coords;
-    }
+    coords = null;
+    ways = [];
 
-    static fromSax(attr) {
-        const node = new OsmNode(
-            Number(attr.id),
-            new WGS84(Number(attr.lat), Number(attr.lon)));
-        node.action = attr.action;
-        return node;
+    constructor(id, coords, tags) {
+        super(id, tags);
+        this.coords = coords;
     }
 }
 

package/src/model/OsmNode.spec.js

@@ -0,0 +1,14 @@
+import { expect } from 'chai';
+
+import { WGS84 } from '@wemap/geo';
+
+import OsmNode from './OsmNode';
+
+describe('OsmNode', () => {
+
+    it('creation', () => {
+        expect(() => new OsmNode(0)).not.throw(Error);
+        expect(() => new OsmNode(0, new WGS84(0, 0))).not.throw(Error);
+    });
+
+});

package/src/model/OsmParser.js

@@ -1,8 +1,9 @@
 /* eslint-disable max-statements */
 import sax from 'sax';
 
-import { Level } from '@wemap/geo';
-import Logger from '@wemap/logger';
+import {
+    Level, WGS84
+} from '@wemap/geo';
 
 import OsmModel from './OsmModel';
 import OsmNode from './OsmNode';
@@ -24,18 +25,20 @@ class OsmParser {
             switch (node.name) {
             case 'node': {
                 if (isDeleted(node)) {
+                    buffer = null;
                     break;
                 }
-                const osmNode = OsmNode.fromSax(node.attributes);
+                const osmNode = this.parseNode(node.attributes);
                 buffer = osmNode;
                 model.nodes.push(osmNode);
                 break;
             }
             case 'way': {
                 if (isDeleted(node)) {
+                    buffer = null;
                     break;
                 }
-                const osmWay = OsmWay.fromSax(node.attributes);
+                const osmWay = this.parseWay(node.attributes);
                 buffer = osmWay;
                 model.ways.push(osmWay);
                 break;
@@ -57,8 +60,7 @@ class OsmParser {
                 const nodeId = Number(node.attributes.ref);
                 const refNode = model.getNodeById(nodeId);
                 if (!refNode) {
-                    Logger.warn('Node: ' + nodeId + ' in way ' + buffer.id + ' not found');
-                    return;
+                    throw Error('Node: ' + nodeId + ' in way ' + buffer.id + ' not found');
                 }
 
                 buffer.nodes.push(refNode);
@@ -80,6 +82,16 @@ class OsmParser {
         return model;
     }
 
+
+    static parseNode(attr) {
+        return new OsmNode(
+            Number(attr.id),
+            new WGS84(Number(attr.lat), Number(attr.lon)));
+    }
+
+    static parseWay(attr) {
+        return new OsmWay(Number(attr.id));
+    }
 }
 
 export default OsmParser;

package/src/model/OsmParser.spec.js

@@ -0,0 +1,49 @@
+import { expect } from 'chai';
+import fs from 'fs';
+import path from 'path';
+
+import { Level } from '@wemap/geo';
+
+import OsmParser from './OsmParser';
+
+describe('OsmParser', () => {
+
+
+    it('parseOsmXmlString', () => {
+
+        const filePath = path.resolve(__dirname, '../../assets/simple.osm');
+        const osmXmlString = fs.readFileSync(filePath, 'utf8');
+
+        const model = OsmParser.parseOsmXmlString(osmXmlString);
+
+        expect(model.nodes.length).equals(4);
+        expect(model.ways.length).equals(2);
+
+    });
+
+
+    it('parseOsmXmlString - Unknown node ref', () => {
+        expect(() => OsmParser.parseOsmXmlString(`
+        <osm>
+            <way id='1'>
+                <nd ref='2' />
+            </way>
+        </osm>
+        `)).throw(Error);
+    });
+
+    it('parseOsmXmlString - parse level', () => {
+
+        const model = OsmParser.parseOsmXmlString(`
+        <osm>
+            <node id='1' lat='0' lon ='0' />
+            <way id='2'>
+                <nd ref='1' />
+                <tag k='level' v='0' />
+            </way>
+        </osm>
+        `);
+        expect(Level.equalsTo(model.ways[0].level, new Level(0))).true;
+    });
+
+});

package/src/model/OsmWay.js

@@ -2,15 +2,11 @@ import OsmElement from './OsmElement';
 
 class OsmWay extends OsmElement {
 
-    constructor(id) {
-        super(id);
-        this.nodes = [];
-    }
+    nodes = [];
+    level = null;
 
-    static fromSax(attr) {
-        const way = new OsmWay(Number(attr.id));
-        way.action = attr.action;
-        return way;
+    constructor(id, tags) {
+        super(id, tags);
     }
 
 }

package/src/network/OsmNetwork.js

@@ -2,8 +2,6 @@ import { Level } from '@wemap/geo';
 import {
     Edge, Node, Network
 } from '@wemap/graph';
-import Logger from '@wemap/logger';
-
 
 const HIGHWAYS_PEDESTRIANS = ['footway', 'steps'];
 const DEFAULT_WAY_SELECTOR = way => HIGHWAYS_PEDESTRIANS.includes(way.tags.highway);
@@ -62,13 +60,14 @@ class OsmNetwork extends Network {
     static createNodesAndEdgesFromElevator(networkModel, node) {
 
         const createdNodes = [];
-        const isLevelAlreadyCreated = level => createdNodes.some(createdNode => Level.equalsTo(level, createdNode.coords.level));
+        const isLevelAlreadyCreated = level => createdNodes.some(
+            createdNode => Level.equalsTo(level, createdNode.coords.level)
+        );
 
         // Create nodes from node.edges
         node.edges.forEach(edge => {
             if (edge.level.isRange) {
-                Logger.error('Cannot handle this elevator edge due to ambiguity');
-                return;
+                throw new Error('Cannot handle this elevator edge due to ambiguity');
             }
 
             if (isLevelAlreadyCreated(edge.level)) {
@@ -77,7 +76,7 @@ class OsmNetwork extends Network {
 
             const newNode = node.clone();
             newNode.coords = node.coords.clone();
-            newNode.coords.level = edge.level ? edge.level.clone() : null;
+            newNode.coords.level = edge.level.clone();
 
             const otherNode = edge.node1 === node ? edge.node2 : edge.node1;
             otherNode.edges = otherNode.edges.filter(_edge => _edge !== edge);
@@ -119,8 +118,8 @@ class OsmNetwork extends Network {
         return this.nodes.find(node => node.data.tags.name === name);
     }
 
-    getEdgeById(id) {
-        return this.edges.find(edge => edge.data.id === id);
+    getEdgesById(id) {
+        return this.edges.filter(edge => edge.data.id === id);
     }
 
     toDetailedString() {