@webtides/element-js 1.2.1 → 1.2.4

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@webtides/element-js",
-    "version": "1.2.1",
+    "version": "1.2.4",
     "module": "index.js",
     "main": "index.js",
     "type": "module",

package/src/BaseElement.js

@@ -191,6 +191,18 @@ class BaseElement extends HTMLElement {
             }
         });
 
+        // release dom references
+        this.$refs = {};
+
+        // clear state
+        this._state = {};
+
+        // cancel pending updates
+        if (this._batchUpdate) {
+            cancelAnimationFrame(this._batchUpdate);
+            this._requestedUpdates = [];
+        }
+
         this.triggerHook('disconnected');
     }
 
@@ -297,16 +309,16 @@ class BaseElement extends HTMLElement {
      * Will trigger update() when a property was changed
      * @param {string} property
      * @param {any} value
-     * @param {boolean} reflectAttribute
+     * @param {boolean} isAttribute
      */
-    defineProperty(property, value, reflectAttribute = false) {
+    defineProperty(property, value, isAttribute = false) {
         if (this._state.hasOwnProperty(property)) {
             // property has already been defined as an attribute nothing to do here
             return;
         }
 
         // if property did not come from an attribute but has the option to reflect // enabled or custom fn
-        if (!reflectAttribute && this._options.propertyOptions[property]?.reflect) {
+        if (!isAttribute && this._options.propertyOptions[property]?.reflect) {
             this.reflectProperty({ property: property, newValue: value });
         }
 
@@ -325,6 +337,10 @@ class BaseElement extends HTMLElement {
             this._state[property].subscribe(this);
         }
 
+        if (Object.getOwnPropertyDescriptor(this, property)) {
+            // instance already has a defined property
+            return;
+        }
         Object.defineProperty(this, property, {
             get: () => {
                 return this._state[property];
@@ -341,7 +357,7 @@ class BaseElement extends HTMLElement {
                         newValue.subscribe(this);
                     }
 
-                    if (reflectAttribute || this._options.propertyOptions[property]?.reflect) {
+                    if (isAttribute || this._options.propertyOptions[property]?.reflect) {
                         this.reflectProperty({ property, newValue, newValueString });
                     }
 
@@ -587,8 +603,10 @@ class BaseElement extends HTMLElement {
      */
     removeEvents() {
         this._registeredEvents.forEach(({ eventTarget, eventName, callback }) => {
-            if (eventTarget === window || eventTarget === document || this.getRoot().contains(eventTarget)) {
+            try {
                 eventTarget.removeEventListener(eventName, callback);
+            } catch (e) {
+                console.error('Unable to remove event listener', e);
             }
         });
         this._registeredEvents = [];

package/src/dom-parts/ChildNodePart.js

@@ -21,6 +21,9 @@ export const insertNodesBetweenComments = (commentNode, nodes) => {
 export const replaceNodesBetweenComments = (commentNode, nodes) => {
     removeNodesBetweenComments(commentNode);
     for (const node of nodes) {
+        if (!commentNode.parentNode) {
+            console.error(`--- no parent comment ---`);
+        }
         commentNode.parentNode.insertBefore(node, commentNode);
     }
 };