npm - @webtides/element-js - Versions diffs - 1.2.1 → 1.2.3 - Mend

@webtides/element-js 1.2.1 → 1.2.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/package.json +1 -1
package/src/BaseElement.js +3 -1
package/src/dom-parts/ChildNodePart.js +3 -0

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
     "name": "@webtides/element-js",
-    "version": "1.2.1",
+    "version": "1.2.3",
     "module": "index.js",
     "main": "index.js",
     "type": "module",

package/src/BaseElement.js CHANGED Viewed

@@ -587,8 +587,10 @@ class BaseElement extends HTMLElement {
      */
     removeEvents() {
         this._registeredEvents.forEach(({ eventTarget, eventName, callback }) => {
-            if (eventTarget === window || eventTarget === document || this.getRoot().contains(eventTarget)) {
+            try {
                 eventTarget.removeEventListener(eventName, callback);
+            } catch (e) {
+                console.error('Unable to remove event listener', e);
             }
         });
         this._registeredEvents = [];

package/src/dom-parts/ChildNodePart.js CHANGED Viewed

@@ -21,6 +21,9 @@ export const insertNodesBetweenComments = (commentNode, nodes) => {
 export const replaceNodesBetweenComments = (commentNode, nodes) => {
     removeNodesBetweenComments(commentNode);
     for (const node of nodes) {
+        if (!commentNode.parentNode) {
+            console.error(`--- no parent comment ---`);
+        }
         commentNode.parentNode.insertBefore(node, commentNode);
     }
 };