@webspatial/core-sdk 1.1.0 → 1.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webspatial/core-sdk",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "this is the core js API for webspatial",
   "main": "dist/index.js",
   "module": "dist/index.js",

package/src/JSBCommand.ts

@@ -539,7 +539,7 @@ export class DestroyCommand extends JSBCommand {
 export class CheckWebViewCanCreateCommand extends JSBCommand {
   commandType = 'CheckWebViewCanCreate'
 
-  constructor(readonly id: string = "") {
+  constructor(readonly id: string = '') {
     super()
   }
 

package/src/SpatialScene.ts

@@ -2,7 +2,7 @@ import {
   SpatialSceneCreationOptions,
   SpatialSceneProperties,
 } from './types/types'
-import { SpatialSceneCreationOptionsInternal } from "./types/internal"
+import { SpatialSceneCreationOptionsInternal } from './types/internal'
 import {
   AddSpatializedElementToSpatialScene,
   GetSpatialSceneState,
@@ -72,4 +72,4 @@ export class SpatialScene extends SpatialObject {
   async getState(): Promise<SpatialSceneState> {
     return (await new GetSpatialSceneState().execute()).data.name
   }
-}
+}

package/src/SpatialSession.ts

@@ -80,7 +80,7 @@ export class SpatialSession {
    * This is a reference to the initScene function from scene-polyfill.
    */
   initScene = initScene
-  
+
   /**
    * Creates a new dynamic 3D element that can be manipulated at runtime.
    * Dynamic 3D elements allow for programmatic creation and modification of 3D content.
@@ -96,7 +96,7 @@ export class SpatialSession {
    * @param name Optional name for the entity
    * @returns Promise resolving to a new SpatialEntity instance
    */
-  createEntity(userData?: SpatialEntityUserData,): Promise<SpatialEntity> {
+  createEntity(userData?: SpatialEntityUserData): Promise<SpatialEntity> {
     return createSpatialEntity(userData)
   }
 
@@ -164,7 +164,7 @@ export class SpatialSession {
   createUnlitMaterial(options: SpatialUnlitMaterialOptions) {
     return createSpatialUnlitMaterial(options)
   }
-  
+
   /**
    * Creates a model asset with the specified configuration.
    * Model assets represent 3D model resources that can be used by entities.
@@ -181,7 +181,10 @@ export class SpatialSession {
    * @param options Configuration options for the spatial model entity
    * @returns Promise resolving to a new SpatialModelEntity instance
    */
-  createSpatialModelEntity(options: SpatialModelEntityCreationOptions, userData?: SpatialEntityUserData) {
+  createSpatialModelEntity(
+    options: SpatialModelEntityCreationOptions,
+    userData?: SpatialEntityUserData,
+  ) {
     return createSpatialModelEntity(options, userData)
   }
 }

package/src/SpatializedElement.ts

@@ -7,6 +7,7 @@ import {
   CubeInfo,
   SpatialDragEndEvent,
   SpatialDragEvent,
+  SpatialDragStartEvent,
   SpatializedElementProperties,
   SpatialMagnifyEndEvent,
   SpatialMagnifyEvent,
@@ -19,6 +20,7 @@ import {
   ObjectDestroyMsg,
   SpatialDragEndMsg,
   SpatialDragMsg,
+  SpatialDragStartMsg,
   SpatialMagnifyEndMsg,
   SpatialMagnifyMsg,
   SpatialRotateEndMsg,
@@ -116,6 +118,7 @@ export abstract class SpatializedElement extends SpatialObject {
       | CubeInfoMsg
       | TransformMsg
       | SpatialTapMsg
+      | SpatialDragStartMsg
       | SpatialDragMsg
       | SpatialDragEndMsg
       | SpatialRotateMsg
@@ -157,65 +160,43 @@ export abstract class SpatializedElement extends SpatialObject {
         (data as SpatialTapMsg).detail,
       )
       this._onSpatialTap?.(event)
+    } else if (type === SpatialWebMsgType.spatialdragstart) {
+      const dragStartEvent = createSpatialEvent(
+        SpatialWebMsgType.spatialdragstart,
+        (data as SpatialDragStartMsg).detail,
+      )
+      this._onSpatialDragStart?.(dragStartEvent)
     } else if (type === SpatialWebMsgType.spatialdrag) {
-      // Handle drag gestures, with special handling for drag start
-      if (!this._isDragging) {
-        const dragStartEvent = createSpatialEvent(
-          SpatialWebMsgType.spatialdragstart,
-          (data as SpatialDragMsg).detail,
-        )
-        this._onSpatialDragStart?.(dragStartEvent)
-      }
-      this._isDragging = true
       const event = createSpatialEvent(
         SpatialWebMsgType.spatialdrag,
         (data as SpatialDragMsg).detail,
       )
       this._onSpatialDrag?.(event)
     } else if (type === SpatialWebMsgType.spatialdragend) {
-      this._isDragging = false
       const event = createSpatialEvent(
         SpatialWebMsgType.spatialdragend,
         (data as SpatialDragEndMsg).detail,
       )
       this._onSpatialDragEnd?.(event)
     } else if (type === SpatialWebMsgType.spatialrotate) {
-      if (!this._isRotating) {
-        const rotationStartEvent = createSpatialEvent(
-          SpatialWebMsgType.spatialrotatestart,
-          (data as SpatialRotateMsg).detail,
-        )
-        this._onSpatialRotateStart?.(rotationStartEvent)
-      }
-      this._isRotating = true
       const event = createSpatialEvent(
         SpatialWebMsgType.spatialrotate,
         (data as SpatialRotateMsg).detail,
       )
       this._onSpatialRotate?.(event)
     } else if (type === SpatialWebMsgType.spatialrotateend) {
-      this._isRotating = false
       const event = createSpatialEvent(
         SpatialWebMsgType.spatialrotateend,
         (data as SpatialRotateEndMsg).detail,
       )
       this._onSpatialRotateEnd?.(event)
     } else if (type === SpatialWebMsgType.spatialmagnify) {
-      if (!this._isMagnify) {
-        const magnifyStartEvent = createSpatialEvent(
-          SpatialWebMsgType.spatialmagnifystart,
-          (data as SpatialMagnifyMsg).detail,
-        )
-        this._onSpatialMagnifyStart?.(magnifyStartEvent)
-      }
-      this._isMagnify = true
       const event = createSpatialEvent(
         SpatialWebMsgType.spatialmagnify,
         (data as SpatialMagnifyMsg).detail,
       )
       this._onSpatialMagnify?.(event)
     } else if (type === SpatialWebMsgType.spatialmagnifyend) {
-      this._isMagnify = false
       const event = createSpatialEvent(
         SpatialWebMsgType.spatialmagnifyend,
         (data as SpatialMagnifyEndMsg).detail,
@@ -232,9 +213,10 @@ export abstract class SpatializedElement extends SpatialObject {
     })
   }
 
-  private _isDragging = false
-  private _onSpatialDragStart?: (event: SpatialDragEvent) => void
-  set onSpatialDragStart(value: (event: SpatialDragEvent) => void | undefined) {
+  private _onSpatialDragStart?: (event: SpatialDragStartEvent) => void
+  set onSpatialDragStart(
+    value: (event: SpatialDragStartEvent) => void | undefined,
+  ) {
     this._onSpatialDragStart = value
     this.updateProperties({
       enableDragStartGesture: this._onSpatialDragStart !== undefined,
@@ -259,17 +241,6 @@ export abstract class SpatializedElement extends SpatialObject {
     })
   }
 
-  private _isRotating = false
-  private _onSpatialRotateStart?: (event: SpatialRotateEvent) => void
-  set onSpatialRotateStart(
-    value: ((event: SpatialRotateEvent) => void) | undefined,
-  ) {
-    this._onSpatialRotateStart = value
-    this.updateProperties({
-      enableRotateStartGesture: this._onSpatialRotateStart !== undefined,
-    })
-  }
-
   private _onSpatialRotate?: (event: SpatialRotateEvent) => void
   set onSpatialRotate(
     value: ((event: SpatialRotateEvent) => void) | undefined,
@@ -290,17 +261,6 @@ export abstract class SpatializedElement extends SpatialObject {
     })
   }
 
-  private _isMagnify = false
-  private _onSpatialMagnifyStart?: (event: SpatialMagnifyEvent) => void
-  set onSpatialMagnifyStart(
-    value: ((event: SpatialMagnifyEvent) => void) | undefined,
-  ) {
-    this._onSpatialMagnifyStart = value
-    this.updateProperties({
-      enableMagnifyStartGesture: value !== undefined,
-    })
-  }
-
   private _onSpatialMagnify?: (event: SpatialMagnifyEvent) => void
   set onSpatialMagnify(
     value: ((event: SpatialMagnifyEvent) => void) | undefined,

package/src/SpatializedStatic3DElement.ts

@@ -104,7 +104,7 @@ export class SpatializedStatic3DElement extends SpatializedElement {
     this._onLoadFailureCallback = callback
   }
 
-  updateModelTransform(transform: DOMMatrix) {
+  updateModelTransform(transform: DOMMatrixReadOnly) {
     const modelTransform = Array.from(transform.toFloat64Array())
     this.updateProperties({ modelTransform })
   }

package/src/WebMsgCommand.ts

@@ -5,6 +5,8 @@ import {
   SpatialTapEventDetail,
   SpatialRotateEventDetail,
   SpatialMagnifyEventDetail,
+  SpatialDragStartEventDetail,
+  SpatialDragEndEventDetail,
 } from './types/types'
 
 export enum SpatialWebMsgType {
@@ -16,10 +18,8 @@ export enum SpatialWebMsgType {
   spatialdragstart = 'spatialdragstart',
   spatialdrag = 'spatialdrag',
   spatialdragend = 'spatialdragend',
-  spatialrotatestart = 'spatialrotatestart',
   spatialrotate = 'spatialrotate',
   spatialrotateend = 'spatialrotateend',
-  spatialmagnifystart = 'spatialmagnifystart',
   spatialmagnify = 'spatialmagnify',
   spatialmagnifyend = 'spatialmagnifyend',
 
@@ -57,6 +57,11 @@ export interface SpatialTapMsg {
   detail: SpatialTapEventDetail
 }
 
+export interface SpatialDragStartMsg {
+  type: SpatialWebMsgType.spatialdragstart
+  detail: SpatialDragStartEventDetail
+}
+
 export interface SpatialDragMsg {
   type: SpatialWebMsgType.spatialdrag
   detail: SpatialDragEventDetail
@@ -64,7 +69,7 @@ export interface SpatialDragMsg {
 
 export interface SpatialDragEndMsg {
   type: SpatialWebMsgType.spatialdragend
-  detail: SpatialDragEventDetail
+  detail: SpatialDragEndEventDetail
 }
 
 export interface SpatialRotateMsg {