@websolutespa/eslint-config 3.0.0 → 3.1.0

package/CHANGELOG.md

@@ -1,49 +1,64 @@
-# @websolutespa/eslint-config
-
-## 3.0.0
-
-### Major Changes
-
-- Release: Bom 3.0
-
-## 0.1.2
-
-### Patch Changes
-
-- Fixing: downgrading eslint to v8.56.0
-
-## 0.1.1
-
-### Patch Changes
-
-- Updating: dependencies
-
-## 0.1.0
-
-### Minor Changes
-
-- Updating: next 13.
-
-## 0.0.5
-
-### Patch Changes
-
-- Added: mdx files.
-
-## 0.0.4
-
-### Patch Changes
-
-- Added: mdx support.
-
-## 0.0.3
-
-### Patch Changes
-
-- Added: no-unreachable error.
-
-## 0.0.2
-
-### Patch Changes
-
-- Added: first release.
+# @websolutespa/eslint-config
+
+## 3.1.0
+
+### Minor Changes
+
+- 044732e: - ESLint 10 (@eslint/js 10, typescript-eslint 8.72, react-hooks 7, @stylistic 5.10, globals 17)
+  - core formatting rules replaced by their `@stylistic/*` equivalents
+  - eslint-plugin-react wrapped with `@eslint/compat` `fixupPluginRules` (it uses context methods removed in ESLint 10)
+  - plugin config: no typescript project service (no type-aware rules are enabled)
+  - `no-restricted-imports` for `next/headers` outside `src/app`, handlers and tests (as on the bom-next branch)
+  - ignore patterns (`dist`, `build`, `.next`, `.turbo`, `.rollup.cache`) match at any depth: ESLint 10 resolves the config from each file's directory, so a parent config no longer ignored nested `dist` folders
+- 3f7c21b: - Payload 3.91.0 and Next.js 16.4.2 (React 19.2.9): peer dependencies are now ranges, `payload` / `@payloadcms/*` `^3.91.0`, `next` `^16.3.3`, `react` / `react-dom` `^19.2.1`
+  - payload-plugin-bowl: the mixer context is built only for reads by an authenticated user (payload 3.90+ resolves the jwt user with the request query, populating tenants before `req.user` is set); email options typed with payload `SendEmailOptions`, no direct nodemailer dependency
+  - payload-plugin-storage: `AZURE_STORAGE_CONTAINER_ACCESS` (`private` default since payload 3.90, `blob`, `container`) for containers created by the plugin
+  - mixer web: `images.qualities` includes `IMAGE_QUALITY` (next 16 defaults to `[75]`)
+
+## 3.0.0
+
+### Major Changes
+
+- Release: Bom 3.0
+
+## 0.1.2
+
+### Patch Changes
+
+- Fixing: downgrading eslint to v8.56.0
+
+## 0.1.1
+
+### Patch Changes
+
+- Updating: dependencies
+
+## 0.1.0
+
+### Minor Changes
+
+- Updating: next 13.
+
+## 0.0.5
+
+### Patch Changes
+
+- Added: mdx files.
+
+## 0.0.4
+
+### Patch Changes
+
+- Added: mdx support.
+
+## 0.0.3
+
+### Patch Changes
+
+- Added: no-unreachable error.
+
+## 0.0.2
+
+### Patch Changes
+
+- Added: first release.

package/base.js

@@ -1,93 +1,115 @@
-import js from '@eslint/js';
-import stylistic from '@stylistic/eslint-plugin';
-import prettier from 'eslint-config-prettier';
-import onlyWarn from 'eslint-plugin-only-warn';
-import turbo from 'eslint-plugin-turbo';
-import typescript from 'typescript-eslint';
-
-/**
- * A shared ESLint configuration for the repository.
- *
- * @type {import("eslint").Linter.Config[]}
- * */
-export const base = [
-  js.configs.recommended,
-  prettier,
-  ...typescript.configs.recommended,
-  /*
-  {
-    rules: [
-      ...typescript.configs.recommended.rules,
-      ...typescript.configs['recommended-requiring-type-checking'].rules,
-    ]
-  },
-  */
-  {
-    plugins: {
-      turbo,
-    },
-    rules: {
-      'turbo/no-undeclared-env-vars': 'warn',
-    },
-  },
-  {
-    plugins: {
-      onlyWarn,
-    },
-  },
-  {
-    ignores: [
-      '.next/**',
-      '.turbo/**',
-      'build/**',
-      'dist/**',
-      'src/app/(payload)/**',
-    ],
-  },
-  {
-    plugins: { '@stylistic': stylistic },
-    rules: {
-      '@stylistic/quotes': ['error', 'single'],
-      'comma-dangle': ['warn', {
-        'arrays': 'always-multiline',
-        'objects': 'always-multiline',
-        'imports': 'never',
-        'exports': 'never',
-        'functions': 'never',
-      }],
-      'for-direction': 'off',
-      'indent': ['error', 2, {
-        'SwitchCase': 1,
-      }],
-      'jsx-quotes': ['error', 'prefer-double'],
-      'no-cond-assign': ['error', 'always'],
-      'no-empty-function': 'off',
-      'no-empty': 'warn',
-      'no-extra-semi': 'error',
-      'no-multi-spaces': 'error',
-      'no-unreachable': 'error',
-      'no-unused-vars': 'off',
-      'quotes': ['error', 'single'],
-      'semi': 'error',
-    },
-  }, {
-    files: [
-      '*.{ts,tsx}',
-    ],
-    rules: {
-      '@typescript-eslint/ban-types': 'off',
-      '@typescript-eslint/explicit-module-boundary-types': 'off',
-      '@typescript-eslint/no-empty-function': 'off',
-      '@typescript-eslint/no-empty-interface': 'off',
-      '@typescript-eslint/no-explicit-any': 'warn',
-      '@typescript-eslint/no-inferrable-types': 'off',
-      '@typescript-eslint/no-unused-vars': 'warn',
-      '@typescript-eslint/no-use-before-define': ['error', {
-        'functions': false,
-        'classes': false,
-        'variables': true,
-        'allowNamedExports': false,
-      }],
-    },
-  },
-];
+import js from '@eslint/js';
+import stylistic from '@stylistic/eslint-plugin';
+import prettier from 'eslint-config-prettier';
+import onlyWarn from 'eslint-plugin-only-warn';
+import turbo from 'eslint-plugin-turbo';
+import typescript from 'typescript-eslint';
+
+/**
+ * A shared ESLint configuration for the repository.
+ *
+ * @type {import("eslint").Linter.Config[]}
+ * */
+export const base = [
+  js.configs.recommended,
+  prettier,
+  ...typescript.configs.recommended,
+  /*
+  {
+    rules: [
+      ...typescript.configs.recommended.rules,
+      ...typescript.configs['recommended-requiring-type-checking'].rules,
+    ]
+  },
+  */
+  {
+    plugins: {
+      turbo,
+    },
+    rules: {
+      'turbo/no-undeclared-env-vars': 'warn',
+    },
+  },
+  {
+    plugins: {
+      onlyWarn,
+    },
+  },
+  {
+    // Helpers must not read request data: only the template (page, layout,
+    // route handler) reads headers()/cookies()/draftMode() and passes it down.
+    rules: {
+      'no-restricted-imports': ['warn', {
+        paths: [{
+          name: 'next/headers',
+          message: 'Read request data (headers, cookies, draftMode) in the template under src/app and pass it down as an argument.',
+        }],
+      }],
+    },
+  },
+  {
+    files: [
+      'src/app/**',
+      '**/handlers/**',
+      '**/*.test.{ts,tsx}',
+    ],
+    rules: {
+      'no-restricted-imports': 'off',
+    },
+  },
+  {
+    ignores: [
+      '**/.next/**',
+      '**/.rollup.cache/**',
+      '**/.turbo/**',
+      '**/build/**',
+      '**/dist/**',
+      'src/app/(payload)/**',
+    ],
+  },
+  {
+    plugins: { '@stylistic': stylistic },
+    rules: {
+      '@stylistic/quotes': ['error', 'single'],
+      '@stylistic/comma-dangle': ['warn', {
+        'arrays': 'always-multiline',
+        'objects': 'always-multiline',
+        'imports': 'never',
+        'exports': 'never',
+        'functions': 'never',
+      }],
+      'for-direction': 'off',
+      '@stylistic/indent': ['error', 2, {
+        'SwitchCase': 1,
+      }],
+      '@stylistic/jsx-quotes': ['error', 'prefer-double'],
+      'no-cond-assign': ['error', 'always'],
+      'no-empty-function': 'off',
+      'no-empty': 'warn',
+      '@stylistic/no-extra-semi': 'error',
+      '@stylistic/no-multi-spaces': 'error',
+      'no-unreachable': 'error',
+      'no-unused-vars': 'off',
+      '@stylistic/semi': 'error',
+    },
+  }, {
+    files: [
+      '*.{ts,tsx}',
+    ],
+    rules: {
+      '@typescript-eslint/ban-types': 'off',
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/no-empty-function': 'off',
+      '@typescript-eslint/no-empty-interface': 'off',
+      '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-inferrable-types': 'off',
+      '@typescript-eslint/no-unused-vars': 'warn',
+      '@typescript-eslint/no-use-before-define': ['error', {
+        'functions': false,
+        'classes': false,
+        'variables': true,
+        'allowNamedExports': false,
+      }],
+    },
+  },
+];

package/next.js

@@ -1,71 +1,79 @@
-import nextPlugin from '@next/eslint-plugin-next';
-import reactPlugin from 'eslint-plugin-react';
-import reactHooks from 'eslint-plugin-react-hooks';
-import globals from 'globals';
-import { base } from './base.js';
-
-/**
- * A custom ESLint configuration for libraries that use Next.js.
- *
- * @type {import("eslint").Linter.Config[]}
- * */
-export const next = [
-  ...base,
-  {
-    ...reactPlugin.configs.flat.recommended,
-    languageOptions: {
-      ...reactPlugin.configs.flat.recommended.languageOptions,
-      globals: {
-        ...globals.serviceworker,
-      },
-    },
-  },
-  {
-    plugins: {
-      '@next/next': nextPlugin,
-    },
-    rules: {
-      ...nextPlugin.configs.recommended.rules,
-      ...nextPlugin.configs['core-web-vitals'].rules,
-    },
-  },
-  {
-    plugins: {
-      'react-hooks': reactHooks,
-    },
-    settings: { react: { version: 'detect' } },
-    rules: {
-      ...reactHooks.configs.recommended.rules,
-      // React scope no longer necessary with new JSX transform.
-      'react/react-in-jsx-scope': 'off',
-    },
-  },
-  {
-    files: [
-      '*.{ts,tsx}',
-    ],
-    rules: {
-      '@typescript-eslint/ban-ts-comment': 'warn',
-      '@typescript-eslint/no-empty-object-type': 'warn',
-      '@typescript-eslint/no-explicit-any': 'warn',
-      '@typescript-eslint/no-unused-vars': 'warn',
-      /*
-      '@typescript-eslint/no-unused-vars': [
-        'warn',
-        {
-          vars: 'all',
-          args: 'after-used',
-          ignoreRestSiblings: false,
-          argsIgnorePattern: '^_',
-          varsIgnorePattern: '^_',
-          destructuredArrayIgnorePattern: '^_',
-          caughtErrorsIgnorePattern: '^(_|ignore)',
-        },
-      ],
-      */
-    },
-  },
-  {
-    ignores: ['.next/'],
-  },
-];
+import nextPlugin from '@next/eslint-plugin-next';
+import { fixupPluginRules } from '@eslint/compat';
+import reactPluginSource from 'eslint-plugin-react';
+import reactHooks from 'eslint-plugin-react-hooks';
+import globals from 'globals';
+import { base } from './base.js';
+
+// eslint-plugin-react uses context methods removed in eslint 10
+const reactPlugin = fixupPluginRules(reactPluginSource);
+const reactRecommended = {
+  ...reactPluginSource.configs.flat.recommended,
+  plugins: { react: reactPlugin },
+};
+
+/**
+ * A custom ESLint configuration for libraries that use Next.js.
+ *
+ * @type {import("eslint").Linter.Config[]}
+ * */
+export const next = [
+  ...base,
+  {
+    ...reactRecommended,
+    languageOptions: {
+      ...reactRecommended.languageOptions,
+      globals: {
+        ...globals.serviceworker,
+      },
+    },
+  },
+  {
+    plugins: {
+      '@next/next': nextPlugin,
+    },
+    rules: {
+      ...nextPlugin.configs.recommended.rules,
+      ...nextPlugin.configs['core-web-vitals'].rules,
+    },
+  },
+  {
+    plugins: {
+      'react-hooks': reactHooks,
+    },
+    settings: { react: { version: 'detect' } },
+    rules: {
+      ...reactHooks.configs.recommended.rules,
+      // React scope no longer necessary with new JSX transform.
+      'react/react-in-jsx-scope': 'off',
+    },
+  },
+  {
+    files: [
+      '*.{ts,tsx}',
+    ],
+    rules: {
+      '@typescript-eslint/ban-ts-comment': 'warn',
+      '@typescript-eslint/no-empty-object-type': 'warn',
+      '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-unused-vars': 'warn',
+      /*
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        {
+          vars: 'all',
+          args: 'after-used',
+          ignoreRestSiblings: false,
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          destructuredArrayIgnorePattern: '^_',
+          caughtErrorsIgnorePattern: '^(_|ignore)',
+        },
+      ],
+      */
+    },
+  },
+  {
+    ignores: ['.next/'],
+  },
+];

package/package.json

@@ -1,41 +1,42 @@
-{
-  "name": "@websolutespa/eslint-config",
-  "version": "3.0.0",
-  "description": "Eslint shared config of the BOM Repository",
-  "keywords": [
-    "bom",
-    "eslint",
-    "config",
-    "websolute"
-  ],
-  "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "git://github.com/websolutespa/bom.git"
-  },
-  "type": "module",
-  "dependencies": {
-    "@eslint/js": "9.31.0",
-    "@next/eslint-plugin-next": "16.1.6",
-    "@stylistic/eslint-plugin": "5.2.3",
-    "eslint": "9.31.0",
-    "eslint-config-prettier": "10.1.1",
-    "eslint-plugin-only-warn": "1.1.0",
-    "eslint-plugin-react": "7.37.5",
-    "eslint-plugin-react-hooks": "5.2.0",
-    "eslint-plugin-turbo": "2.5.0",
-    "globals": "16.3.0",
-    "typescript-eslint": "8.36.0"
-  },
-  "devDependencies": {
-    "typescript": "5.8.3"
-  },
-  "main": "./base.js",
-  "exports": {
-    ".": "./base.js",
-    "./base": "./base.js",
-    "./next": "./next.js",
-    "./plugin": "./plugin.js",
-    "./react": "./react.js"
-  }
-}
+{
+  "name": "@websolutespa/eslint-config",
+  "version": "3.1.0",
+  "description": "Eslint shared config of the BOM Repository",
+  "keywords": [
+    "bom",
+    "eslint",
+    "config",
+    "websolute"
+  ],
+  "license": "MIT",
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/websolutespa/bom.git"
+  },
+  "type": "module",
+  "dependencies": {
+    "@eslint/compat": "2.1.1",
+    "@eslint/js": "10.0.1",
+    "@next/eslint-plugin-next": "16.4.2",
+    "@stylistic/eslint-plugin": "5.10.0",
+    "eslint": "10.13.0",
+    "eslint-config-prettier": "10.1.8",
+    "eslint-plugin-only-warn": "1.2.1",
+    "eslint-plugin-react": "7.37.5",
+    "eslint-plugin-react-hooks": "7.1.1",
+    "eslint-plugin-turbo": "2.11.10",
+    "globals": "17.13.0",
+    "typescript-eslint": "8.72.0"
+  },
+  "devDependencies": {
+    "typescript": "6.0.3"
+  },
+  "main": "./base.js",
+  "exports": {
+    ".": "./base.js",
+    "./base": "./base.js",
+    "./next": "./next.js",
+    "./plugin": "./plugin.js",
+    "./react": "./react.js"
+  }
+}

package/plugin.js

@@ -1,28 +1,24 @@
-import { react } from './react.js';
-
-/**
- * A custom ESLint configuration for plugins.
- *
- * @type {import("eslint").Linter.Config[]} */
-export const plugin = [
-  ...react,
-  {
-    rules: {
-      'no-restricted-exports': 'off',
-    },
-  },
-  {
-    languageOptions: {
-      parserOptions: {
-        sourceType: 'module',
-        ecmaVersion: 'latest',
-        projectService: {
-          maximumDefaultProjectFileMatchCount_THIS_WILL_SLOW_DOWN_LINTING: 40,
-          allowDefaultProject: ['scripts/*.ts', '*.js', '*.mjs', '*.spec.ts', '*.d.ts'],
-        },
-        // projectService: true,
-        tsconfigRootDir: import.meta.dirname,
-      },
-    },
-  },
-];
+import { react } from './react.js';
+
+/**
+ * A custom ESLint configuration for plugins.
+ *
+ * @type {import("eslint").Linter.Config[]} */
+export const plugin = [
+  ...react,
+  {
+    rules: {
+      'no-restricted-exports': 'off',
+    },
+  },
+  {
+    languageOptions: {
+      // no type-aware rules are enabled, so no typescript project service is needed
+      // (it failed on files outside the tsconfig, e.g. tests and eslint.config.js)
+      parserOptions: {
+        sourceType: 'module',
+        ecmaVersion: 'latest',
+      },
+    },
+  },
+];

package/react.js

@@ -1,32 +1,40 @@
-import reactPlugin from 'eslint-plugin-react';
-import reactHooksPlugin from 'eslint-plugin-react-hooks';
-import globals from 'globals';
-import { base } from './base.js';
-
-/**
- * A custom ESLint configuration for libraries that use React.
- *
- * @type {import("eslint").Linter.Config[]} */
-export const react = [
-  ...base,
-  reactPlugin.configs.flat.recommended,
-  {
-    languageOptions: {
-      ...reactPlugin.configs.flat.recommended.languageOptions,
-      globals: {
-        ...globals.serviceworker,
-        ...globals.browser,
-      },
-    },
-  },
-  {
-    plugins: {
-      'react-hooks': reactHooksPlugin,
-    },
-    settings: { react: { version: 'detect' } },
-    rules: {
-      ...reactHooksPlugin.configs.recommended.rules,
-      'react/react-in-jsx-scope': 'off',
-    },
-  },
-];
+import { fixupPluginRules } from '@eslint/compat';
+import reactPluginSource from 'eslint-plugin-react';
+import reactHooksPlugin from 'eslint-plugin-react-hooks';
+import globals from 'globals';
+import { base } from './base.js';
+
+// eslint-plugin-react uses context methods removed in eslint 10
+const reactPlugin = fixupPluginRules(reactPluginSource);
+const reactRecommended = {
+  ...reactPluginSource.configs.flat.recommended,
+  plugins: { react: reactPlugin },
+};
+
+/**
+ * A custom ESLint configuration for libraries that use React.
+ *
+ * @type {import("eslint").Linter.Config[]} */
+export const react = [
+  ...base,
+  reactRecommended,
+  {
+    languageOptions: {
+      ...reactRecommended.languageOptions,
+      globals: {
+        ...globals.serviceworker,
+        ...globals.browser,
+      },
+    },
+  },
+  {
+    plugins: {
+      'react-hooks': reactHooksPlugin,
+    },
+    settings: { react: { version: 'detect' } },
+    rules: {
+      ...reactHooksPlugin.configs.recommended.rules,
+      'react/react-in-jsx-scope': 'off',
+    },
+  },
+];