@websline/cms-view-utils 1.10.0 → 1.10.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@websline/cms-view-utils",
-  "version": "1.10.0",
+  "version": "1.10.1",
   "type": "module",
   "files": [
     "src",

package/src/ads/triggers.js

@@ -39,30 +39,30 @@ const afterDelay = (seconds, fire, timers) => {
 	return () => timers.clearTimeout(id);
 };
 
-/**
- * How far down the visitor is, in percent of what the page can scroll. A page
- * that fits the window cannot be scrolled and so never reaches any share.
- */
-const scrolledPercent = (target, doc) => {
-	const scrollable =
-		(doc?.documentElement?.scrollHeight ?? 0) - (target.innerHeight ?? 0);
-
-	return scrollable > 0 ? (target.scrollY / scrollable) * 100 : 0;
-};
+/** How far the page can scroll at all; zero for a page that fits the window. */
+const scrollableHeight = (target, doc) =>
+	Math.max((doc?.documentElement?.scrollHeight ?? 0) - (target.innerHeight ?? 0), 0);
 
 /**
- * Fixed rather than set per ad: far enough to mean interest, early enough that
- * most visitors get there. Not offered in the CMS, since no editor tunes it.
+ * Fixed rather than set per ad, and in pixels rather than a share of the page: a
+ * share of a long page lies far down, so the ad would come late or not at all.
  */
-const SCROLL_SHARE_PERCENT = 30;
+const SCROLL_DISTANCE_PX = 300;
 
 /**
- * Keeps listening until the share is reached: `once` would drop the listener on
- * an overscroll bounce back at the top and lose the ad for that visit.
+ * Keeps listening until the distance is reached: `once` would drop the listener
+ * on an overscroll bounce back at the top and lose the ad for that visit. A page
+ * shorter than the distance counts once scrolled to its end.
  */
 const onScrolledPast = (fire, target, doc) => {
-	const reached = () =>
-		target.scrollY > 0 && scrolledPercent(target, doc) >= SCROLL_SHARE_PERCENT;
+	const reached = () => {
+		const scrollable = scrollableHeight(target, doc);
+
+		// A pixel of slack: at the very end, zoomed pages report a fractional scrollY.
+		return (
+			scrollable > 0 && target.scrollY >= Math.min(SCROLL_DISTANCE_PX, scrollable) - 1
+		);
+	};
 
 	// Already that far when the ad arrived — no further event may come.
 	if (reached()) {
@@ -156,4 +156,4 @@ const watchTrigger = (trigger, onFire, env = {}) => {
 	}
 };
 
-export { countPageView, PAGE_VIEWS_KEY, SCROLL_SHARE_PERCENT, watchTrigger };
+export { countPageView, PAGE_VIEWS_KEY, SCROLL_DISTANCE_PX, watchTrigger };