@webround/editor 0.3.12 → 0.3.13

package/dist/check/producer-dom.d.ts

@@ -6,6 +6,8 @@ export interface DomNode {
     tag: string;
     attrs: Record<string, string>;
     text: string;
+    /** The element's own `id` (what `aria-labelledby` points at), not its `data-wr-id`. */
+    htmlId?: string;
     /** A form field that has a `<label>`: it sits inside one, or one points at it (`for`). */
     labelled?: true;
     children: DomNode[];

package/dist/check/producer-dom.js

@@ -23,6 +23,7 @@ export function serializeDom(root) {
         const labelled = fields.includes(tag) && (el.closest?.('label') != null || (fieldId !== null && pointedAt.has(fieldId)));
         return {
             ...(id ? { id } : {}),
+            ...(fieldId ? { htmlId: fieldId } : {}),
             wrType: el.getAttribute('data-wr-type'),
             tag,
             attrs,
@@ -44,7 +45,11 @@ function toCheckNode(node) {
 }
 /** The tree a rule sees, from what `serializeDom` read (wherever it ran). */
 export function checkPageFromSerialized(name, nodes) {
-    return { name, source: 'dom', nodes: nodes.map(toCheckNode) };
+    const elementIds = [];
+    const collect = (list) => list.forEach(node => { if (node.htmlId)
+        elementIds.push(node.htmlId); collect(node.children); });
+    collect(nodes);
+    return { name, source: 'dom', nodes: nodes.map(toCheckNode), elementIds };
 }
 export function checkPageFromDom(name, root) {
     return checkPageFromSerialized(name, serializeDom(root));

package/dist/check/rules.js

@@ -222,7 +222,8 @@ export const RULES = [
                 if (n.kind !== 'input')
                     continue;
                 const written = Object.values(n.values?.label ?? {}).some(text => text.trim() !== '');
-                if (!written && !n.attrs['aria-label']?.trim())
+                // A drawn page has no JSON: there the label is the `<label>` the field sits in or the one that points at it (`insideLabel`, as `form-label` reads it)
+                if (!written && !n.attrs['aria-label']?.trim() && !n.insideLabel)
                     report(n, 'A form field has no label: a placeholder is not one, and the owner reads this name in the email.');
             }
         },
@@ -304,7 +305,8 @@ export const RULES = [
         name: 'aria-reference',
         severity: 'warning',
         run(page, report) {
-            const ids = new Set(everyNode(page).map(n => n.id).filter((id) => !!id));
+            // The Wr elements' ids, and (a drawn page) every `id` of the HTML: a plain element can be pointed at too
+            const ids = new Set([...everyNode(page).map(n => n.id).filter((id) => !!id), ...(page.elementIds ?? [])]);
             for (const n of everyNode(page)) {
                 for (const attribute of ['aria-labelledby', 'aria-describedby']) {
                     const value = n.attrs[attribute];

package/dist/check/types.d.ts

@@ -53,6 +53,8 @@ export interface CheckPage {
     project?: CheckProject;
     /** The ids of the form fields some `<label htmlFor>` of the code points at. */
     labelledIds?: string[];
+    /** Every `id` the HTML of the page has (only the DOM producer knows them: in the code a plain element's id can be computed). */
+    elementIds?: string[];
     /** What the page tells search engines (only the code producer knows it: the DOM has no `config`): text by language key, `default` first. */
     seo?: {
         title: Record<string, string>;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@webround/editor",
-    "version": "0.3.12",
+    "version": "0.3.13",
     "type": "module",
     "main": "./dist/index.js",
     "module": "./dist/index.js",
@@ -75,7 +75,7 @@
         "@lexical/selection": "^0.51.0",
         "@lexical/utils": "^0.51.0",
         "@monaco-editor/react": "^4.7.0",
-        "@webround/core": "^0.3.12",
+        "@webround/core": "^0.3.13",
         "highlight.js": "^11.12.0",
         "hls.js": "^1.5.0",
         "lexical": "^0.51.0",