@webpieces/rules-config 0.4.786 → 0.4.788

package/src/spec-temp-dirs.js

@@ -0,0 +1,112 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.specTempDirs = exports.SpecTempDirs = void 0;
+const tslib_1 = require("tslib");
+const fs = tslib_1.__importStar(require("fs"));
+const os = tslib_1.__importStar(require("os"));
+const path = tslib_1.__importStar(require("path"));
+const to_error_1 = require("./to-error");
+// ---------------------------------------------------------------------------
+// ONE OWNER FOR EVERY `$TMPDIR` SCRATCH TREE THE TOOLING CREATES.
+//
+// THE DEFECT. Every `packages/tooling/**` spec builds its fixture with
+// `specTempDirs.make('wp-<something>-')` and NONE of them removed it afterwards.
+// Measured on one developer machine: 270,200 abandoned `wp-*` directories out of 286,270 total entries
+// in `$TMPDIR` — 64,828 of them from `vitest.setup.mts` alone, which mints one isolated `$HOME` per test
+// FILE per run. The cost is not disk (every `wp-*` prefix together is under 1 GiB; the `$HOME` dirs are
+// empty by design) — it is INODES and the fact that `$TMPDIR` stops being inspectable: `ls` takes ~30s
+// and `du` takes minutes, which is how this went unnoticed for as long as it did.
+//
+// WHY `$TMPDIR` AND NOT `.webpieces/`, WHICH IS WHERE EVERYTHING ELSE GOES. Because for a TEST fixture
+// the whole point is to be outside the repo, and two separate mechanisms depend on that:
+//   - `vitest.setup.mts` mints a throwaway `$HOME` so a spec cannot read the developer's real
+//     `~/.webpieces/config.json`. A fake HOME inside the repo defeats its own isolation.
+//   - The fixtures `git init` and `git worktree add` INSIDE themselves. A nested git repo under the real
+//     repo root is what breaks the nx graph — the same hazard that makes `.claude/worktrees/` a
+//     mandatory gitignore entry.
+// So the location was never the bug. The missing cleanup was.
+//
+// WHO ACTUALLY CALLS `reapAll`, AND WHY IT IS NOT A LINE IN EACH SPEC. An `afterAll` written into each
+// of the 212 call sites is a line somebody has to remember, forever, in every new spec — precisely the
+// discipline already demonstrated not to hold here. Instead `vitest.setup.mts` calls `reapAll()` in ONE
+// global `afterAll`, so a call site swaps `fs.mkdtempSync(...)` for `specTempDirs.make(...)` and there
+// is no other half to forget.
+//
+// THE `exit` REAPER BELOW IS THE SECONDARY BELT, NOT THE PRIMARY ONE — and the first cut of this file
+// had that backwards. It relied on `process.on('exit')` alone, and a 145-file tooling run then left
+// exactly 145 `wp-vitest-home-` directories behind: a 100% miss. The cause is `pool: 'forks'` (see
+// vitest.config.mts) — vitest KILLS its workers rather than letting them exit, and a killed process runs
+// no exit handler. The handler stays because it costs one listener and does fire for the non-vitest
+// callers (testkits driven from plain node scripts), but nothing here should depend on it.
+//
+// SO CLEANUP IS BEST-EFFORT BY CONSTRUCTION, at two levels: a worker killed mid-file skips the
+// `afterAll` too. That residue is why `CleanTmp` sweeps aged `wp-*` out of `$TMPDIR` via
+// `TmpScratchSweeper` — belt, braces, and a sweep for what both of them miss.
+// ---------------------------------------------------------------------------
+/**
+ * Creates `$TMPDIR` scratch directories for specs and testkits, and reaps every one of them when the
+ * process exits.
+ *
+ * Use the shared `specTempDirs` instance — the reaper is registered per-instance, so a caller that
+ * constructs its own gets a second `exit` listener and no benefit.
+ */
+class SpecTempDirs {
+    created = [];
+    reaperRegistered = false;
+    /**
+     * `fs.mkdtempSync` under `os.tmpdir()`, with the path remembered for cleanup.
+     *
+     * `prefix` keeps the existing `wp-<area>-` convention so a leaked tree still names its creator; the
+     * trailing dash matters because mkdtemp appends six random characters directly onto it.
+     */
+    make(prefix) {
+        this.registerReaper();
+        const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
+        this.created.push(dir);
+        return dir;
+    }
+    /**
+     * `make`, with symlinks resolved.
+     *
+     * macOS hands back `/var/folders/...` from `os.tmpdir()` while `/var` is a symlink to `/private/var`,
+     * so a fixture that compares a path it was given against one the code under test computed sees two
+     * different strings for the same directory. Specs that do that comparison call this instead.
+     */
+    makeReal(prefix) {
+        return fs.realpathSync(this.make(prefix));
+    }
+    /**
+     * Removes every directory this instance created, then forgets them.
+     *
+     * Deliberately never throws: it runs from an `exit` handler where a throw would replace a passing
+     * test run's exit code with a crash, and a scratch directory that cannot be removed is a leak, not a
+     * failure. Callers may also invoke it directly — a long suite that wants its fixtures gone before the
+     * end of the run.
+     */
+    reapAll() {
+        const dirs = this.created.splice(0, this.created.length);
+        for (const dir of dirs) {
+            // webpieces-disable no-unmanaged-exceptions -- chokepoint: this runs from vitest's afterAll and
+            // from an exit handler, where a throw would turn a passing run into a crash over a scratch dir
+            // eslint-disable-next-line @webpieces/no-unmanaged-exceptions
+            try {
+                fs.rmSync(dir, { recursive: true, force: true });
+            }
+            catch (err) {
+                const error = (0, to_error_1.toError)(err);
+                process.stderr.write(`SpecTempDirs: could not remove ${dir}: ${error.message}\n`);
+            }
+        }
+    }
+    // One listener per instance, added lazily so a process that never makes a fixture never registers.
+    registerReaper() {
+        if (this.reaperRegistered)
+            return;
+        this.reaperRegistered = true;
+        process.on('exit', () => this.reapAll());
+    }
+}
+exports.SpecTempDirs = SpecTempDirs;
+// The shared instance — the reaper and the created-list are per-instance, so every caller must use this.
+exports.specTempDirs = new SpecTempDirs();
+//# sourceMappingURL=spec-temp-dirs.js.map

package/src/spec-temp-dirs.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"spec-temp-dirs.js","sourceRoot":"","sources":["../../../../../packages/tooling/rules-config/src/spec-temp-dirs.ts"],"names":[],"mappings":";;;;AAAA,+CAAyB;AACzB,+CAAyB;AACzB,mDAA6B;AAC7B,yCAAqC;AAErC,8EAA8E;AAC9E,kEAAkE;AAClE,EAAE;AACF,uEAAuE;AACvE,iFAAiF;AACjF,uGAAuG;AACvG,yGAAyG;AACzG,wGAAwG;AACxG,uGAAuG;AACvG,kFAAkF;AAClF,EAAE;AACF,uGAAuG;AACvG,yFAAyF;AACzF,8FAA8F;AAC9F,yFAAyF;AACzF,yGAAyG;AACzG,gGAAgG;AAChG,iCAAiC;AACjC,8DAA8D;AAC9D,EAAE;AACF,uGAAuG;AACvG,uGAAuG;AACvG,wGAAwG;AACxG,uGAAuG;AACvG,8BAA8B;AAC9B,EAAE;AACF,sGAAsG;AACtG,oGAAoG;AACpG,mGAAmG;AACnG,yGAAyG;AACzG,oGAAoG;AACpG,2FAA2F;AAC3F,EAAE;AACF,+FAA+F;AAC/F,yFAAyF;AACzF,8EAA8E;AAC9E,8EAA8E;AAE9E;;;;;;GAMG;AACH,MAAa,YAAY;IACJ,OAAO,GAAa,EAAE,CAAC;IAChC,gBAAgB,GAAG,KAAK,CAAC;IAEjC;;;;;OAKG;IACH,IAAI,CAAC,MAAc;QACf,IAAI,CAAC,cAAc,EAAE,CAAC;QACtB,MAAM,GAAG,GAAG,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,MAAM,CAAC,CAAC,CAAC;QAC3D,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACvB,OAAO,GAAG,CAAC;IACf,CAAC;IAED;;;;;;OAMG;IACH,QAAQ,CAAC,MAAc;QACnB,OAAO,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC;IAC9C,CAAC;IAED;;;;;;;OAOG;IACH,OAAO;QACH,MAAM,IAAI,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;QACzD,KAAK,MAAM,GAAG,IAAI,IAAI,EAAE,CAAC;YACrB,gGAAgG;YAChG,+FAA+F;YAC/F,8DAA8D;YAC9D,IAAI,CAAC;gBACD,EAAE,CAAC,MAAM,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;YACrD,CAAC;YAAC,OAAO,GAAY,EAAE,CAAC;gBACpB,MAAM,KAAK,GAAG,IAAA,kBAAO,EAAC,GAAG,CAAC,CAAC;gBAC3B,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,kCAAkC,GAAG,KAAK,KAAK,CAAC,OAAO,IAAI,CAAC,CAAC;YACtF,CAAC;QACL,CAAC;IACL,CAAC;IAED,mGAAmG;IAC3F,cAAc;QAClB,IAAI,IAAI,CAAC,gBAAgB;YAAE,OAAO;QAClC,IAAI,CAAC,gBAAgB,GAAG,IAAI,CAAC;QAC7B,OAAO,CAAC,EAAE,CAAC,MAAM,EAAE,GAAS,EAAE,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC;IACnD,CAAC;CACJ;AAzDD,oCAyDC;AAED,yGAAyG;AAC5F,QAAA,YAAY,GAAG,IAAI,YAAY,EAAE,CAAC","sourcesContent":["import * as fs from 'fs';\nimport * as os from 'os';\nimport * as path from 'path';\nimport { toError } from './to-error';\n\n// ---------------------------------------------------------------------------\n// ONE OWNER FOR EVERY `$TMPDIR` SCRATCH TREE THE TOOLING CREATES.\n//\n// THE DEFECT. Every `packages/tooling/**` spec builds its fixture with\n// `specTempDirs.make('wp-<something>-')` and NONE of them removed it afterwards.\n// Measured on one developer machine: 270,200 abandoned `wp-*` directories out of 286,270 total entries\n// in `$TMPDIR` — 64,828 of them from `vitest.setup.mts` alone, which mints one isolated `$HOME` per test\n// FILE per run. The cost is not disk (every `wp-*` prefix together is under 1 GiB; the `$HOME` dirs are\n// empty by design) — it is INODES and the fact that `$TMPDIR` stops being inspectable: `ls` takes ~30s\n// and `du` takes minutes, which is how this went unnoticed for as long as it did.\n//\n// WHY `$TMPDIR` AND NOT `.webpieces/`, WHICH IS WHERE EVERYTHING ELSE GOES. Because for a TEST fixture\n// the whole point is to be outside the repo, and two separate mechanisms depend on that:\n//   - `vitest.setup.mts` mints a throwaway `$HOME` so a spec cannot read the developer's real\n//     `~/.webpieces/config.json`. A fake HOME inside the repo defeats its own isolation.\n//   - The fixtures `git init` and `git worktree add` INSIDE themselves. A nested git repo under the real\n//     repo root is what breaks the nx graph — the same hazard that makes `.claude/worktrees/` a\n//     mandatory gitignore entry.\n// So the location was never the bug. The missing cleanup was.\n//\n// WHO ACTUALLY CALLS `reapAll`, AND WHY IT IS NOT A LINE IN EACH SPEC. An `afterAll` written into each\n// of the 212 call sites is a line somebody has to remember, forever, in every new spec — precisely the\n// discipline already demonstrated not to hold here. Instead `vitest.setup.mts` calls `reapAll()` in ONE\n// global `afterAll`, so a call site swaps `fs.mkdtempSync(...)` for `specTempDirs.make(...)` and there\n// is no other half to forget.\n//\n// THE `exit` REAPER BELOW IS THE SECONDARY BELT, NOT THE PRIMARY ONE — and the first cut of this file\n// had that backwards. It relied on `process.on('exit')` alone, and a 145-file tooling run then left\n// exactly 145 `wp-vitest-home-` directories behind: a 100% miss. The cause is `pool: 'forks'` (see\n// vitest.config.mts) — vitest KILLS its workers rather than letting them exit, and a killed process runs\n// no exit handler. The handler stays because it costs one listener and does fire for the non-vitest\n// callers (testkits driven from plain node scripts), but nothing here should depend on it.\n//\n// SO CLEANUP IS BEST-EFFORT BY CONSTRUCTION, at two levels: a worker killed mid-file skips the\n// `afterAll` too. That residue is why `CleanTmp` sweeps aged `wp-*` out of `$TMPDIR` via\n// `TmpScratchSweeper` — belt, braces, and a sweep for what both of them miss.\n// ---------------------------------------------------------------------------\n\n/**\n * Creates `$TMPDIR` scratch directories for specs and testkits, and reaps every one of them when the\n * process exits.\n *\n * Use the shared `specTempDirs` instance — the reaper is registered per-instance, so a caller that\n * constructs its own gets a second `exit` listener and no benefit.\n */\nexport class SpecTempDirs {\n    private readonly created: string[] = [];\n    private reaperRegistered = false;\n\n    /**\n     * `fs.mkdtempSync` under `os.tmpdir()`, with the path remembered for cleanup.\n     *\n     * `prefix` keeps the existing `wp-<area>-` convention so a leaked tree still names its creator; the\n     * trailing dash matters because mkdtemp appends six random characters directly onto it.\n     */\n    make(prefix: string): string {\n        this.registerReaper();\n        const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));\n        this.created.push(dir);\n        return dir;\n    }\n\n    /**\n     * `make`, with symlinks resolved.\n     *\n     * macOS hands back `/var/folders/...` from `os.tmpdir()` while `/var` is a symlink to `/private/var`,\n     * so a fixture that compares a path it was given against one the code under test computed sees two\n     * different strings for the same directory. Specs that do that comparison call this instead.\n     */\n    makeReal(prefix: string): string {\n        return fs.realpathSync(this.make(prefix));\n    }\n\n    /**\n     * Removes every directory this instance created, then forgets them.\n     *\n     * Deliberately never throws: it runs from an `exit` handler where a throw would replace a passing\n     * test run's exit code with a crash, and a scratch directory that cannot be removed is a leak, not a\n     * failure. Callers may also invoke it directly — a long suite that wants its fixtures gone before the\n     * end of the run.\n     */\n    reapAll(): void {\n        const dirs = this.created.splice(0, this.created.length);\n        for (const dir of dirs) {\n            // webpieces-disable no-unmanaged-exceptions -- chokepoint: this runs from vitest's afterAll and\n            // from an exit handler, where a throw would turn a passing run into a crash over a scratch dir\n            // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n            try {\n                fs.rmSync(dir, { recursive: true, force: true });\n            } catch (err: unknown) {\n                const error = toError(err);\n                process.stderr.write(`SpecTempDirs: could not remove ${dir}: ${error.message}\\n`);\n            }\n        }\n    }\n\n    // One listener per instance, added lazily so a process that never makes a fixture never registers.\n    private registerReaper(): void {\n        if (this.reaperRegistered) return;\n        this.reaperRegistered = true;\n        process.on('exit', (): void => this.reapAll());\n    }\n}\n\n// The shared instance — the reaper and the created-list are per-instance, so every caller must use this.\nexport const specTempDirs = new SpecTempDirs();\n"]}

package/src/subagent-provenance.d.ts

@@ -113,11 +113,16 @@ export declare class ReviewerContext {
     constructor(branch: string, diffDir?: string, docPaths?: Record<string, string>, verdictPaths?: Record<string, string>);
 }
 /**
- * One checklist that must be credited to a reviewer run, and the agent type that run must carry. Data-only.
+ * One checklist that must be credited to a reviewer run, plus the agent type the BRIEFING named. Data-only.
  *
  * The two used to be one string — a checklist's id WAS its agent type — and provenance keyed everything by
  * it. Now every checklist is reviewed by the same repo-wide agent type, so the id and the type are
- * separate facts and a run is matched on the type but credited to the id.
+ * separate facts.
+ *
+ * `agentType` is NOT a provenance input: nothing here matches a run on it (issue #964, see
+ * {@link SubagentProvenanceService.isReviewerRun}). It is carried because it is what the BRIEFING told
+ * the agent to spawn and what {@link ReviewerEvidence} reports, which are both worth recording even
+ * though neither is worth gating on.
  */
 export declare class ExpectedReviewer {
     checklistId: string;
@@ -126,16 +131,18 @@ export declare class ExpectedReviewer {
 }
 /**
  * Verifies — from the Claude Code harness's OWN artifacts, never from anything the model asserts — that
- * a subagent of a given `agentType` actually ran during the current session on the current branch. Used
- * to enforce that every checklist was reviewed by a subagent of the repo reviewer-agent type: that an INDEPENDENT
- * reviewer looked, rather than the coding agent self-certifying.
+ * a real SUBAGENT actually ran on the current branch and did this checklist's work. Used to enforce that
+ * every checklist was reviewed by an INDEPENDENT reviewer, rather than by the coding agent
+ * self-certifying.
  *
  * The harness writes, beside each subagent transcript:
- *   ~/.claude/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.meta.json  → { agentType, spawnDepth, … }
- *   ~/.claude/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.jsonl      → record 0 { isSidechain, gitBranch, … }
- * `agentType`/`spawnDepth`/`isSidechain` are written by Claude Code, not by the model. We locate the dir
- * by the unique sessionId (globbing `projects/&#42;/<sessionId>/subagents`), so the cwd-slug never has to be
- * derived/guessed.
+ *   <config>/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.meta.json  → { agentType, spawnDepth, … }
+ *   <config>/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.jsonl      → record 0 { isSidechain, gitBranch, … }
+ * `spawnDepth`/`isSidechain` are written by Claude Code, not by the model, and they are what carries the
+ * anti-self-certification property. `agentType` is written there too and is deliberately NOT checked —
+ * see {@link SubagentProvenanceService.isReviewerRun}. `<config>` is `$CLAUDE_CONFIG_DIR` when set, else
+ * `~/.claude`; see {@link ClaudeConfigDir}, and never re-derive it here. Dirs are found by walking
+ * every session, so the cwd-slug never has to be derived/guessed.
  *
  * IMPORTANT — this is NOT tamper-proof. A determined agent can `cat >` a fake agent-*.meta.json. This
  * raises the bar from "trust the model's word" to "deliberate, auditable forgery outside the repo"; it
@@ -201,8 +208,40 @@ export declare class SubagentProvenanceService {
     private inClaudeSession;
     private skipped;
     private findMatchingAgentId;
+    /**
+     * A harness-written meta for a REAL SUBAGENT — `spawnDepth >= 1`, and nothing about its NAME.
+     *
+     * The agent TYPE used to be compared against the configured reviewer agent, and that check is
+     * gone (issue #964). It proved nothing: `agentType` is a label on a prompt, and it does not show
+     * the agent read the checklist, opened the diff, or looked at the right branch. The gates that DO
+     * show those are untouched — `spawnDepth >= 1` plus `isSidechain === true` (see
+     * {@link sidechainOnBranch}) are harness-written, so the main loop still cannot self-certify;
+     * {@link creditedByWhatItTouched} proves the branch and the actual work; `requireDiffEvidence`
+     * proves the diff was opened.
+     *
+     * It was also the ONLY gate with an unfixable failure mode. Claude Code snapshots agent
+     * definitions per session and the refresh does not reach an already-running subagent, so a repo
+     * that renames its reviewer agent mid-session leaves that subagent's registry offering only the
+     * OLD names: the spawn is rejected, the agent falls back to `general-purpose`, does the real
+     * review, writes every verdict — and is refused as unattributable, with no cwd, branch or respawn
+     * able to change it. Measured: six checklists, six verdict files on disk, PR blocked.
+     *
+     * Accepted trade-off: without the name check the implementer's own subagent could in principle be
+     * credited, since it touches the diff dir while running the gate. That is deliberate. The rule is
+     * "if the verdict file is there, a subagent wrote it", and this gate's job is to catch "no
+     * subagent ran at all" — not to adjudicate which subagent it was.
+     */
     private isReviewerRun;
     private namedVerdict;
+    /**
+     * Every `<config>/projects/&#42;/<session>/subagents` dir that exists — matching by the recorded
+     * gitBranch (not by session id) is what makes provenance survive across sessions.
+     *
+     * `<config>` comes from {@link ClaudeConfigDir.projectsRoots}, which is BOTH the configured
+     * `$CLAUDE_CONFIG_DIR` tree and `~/.claude`. This used to be a hardcoded `~/.claude`, and on a
+     * machine with a relocated config dir that found nothing at all — so every PR was refused with a
+     * message about the reviewers' cwd, which is not what was wrong and which no agent could act on.
+     */
     private allSubagentsDirs;
     private metaFiles;
     private agentIdOf;

package/src/subagent-provenance.js

@@ -5,8 +5,8 @@ const tslib_1 = require("tslib");
 const child_process_1 = require("child_process");
 const fs = tslib_1.__importStar(require("fs"));
 const path = tslib_1.__importStar(require("path"));
-const os = tslib_1.__importStar(require("os"));
 const inversify_1 = require("inversify");
+const claude_config_dir_1 = require("./claude-config-dir");
 const to_error_1 = require("./to-error");
 const state_dir_1 = require("./state-dir");
 // Outcome of a provenance check.
@@ -162,11 +162,16 @@ class ReviewerContext {
 }
 exports.ReviewerContext = ReviewerContext;
 /**
- * One checklist that must be credited to a reviewer run, and the agent type that run must carry. Data-only.
+ * One checklist that must be credited to a reviewer run, plus the agent type the BRIEFING named. Data-only.
  *
  * The two used to be one string — a checklist's id WAS its agent type — and provenance keyed everything by
  * it. Now every checklist is reviewed by the same repo-wide agent type, so the id and the type are
- * separate facts and a run is matched on the type but credited to the id.
+ * separate facts.
+ *
+ * `agentType` is NOT a provenance input: nothing here matches a run on it (issue #964, see
+ * {@link SubagentProvenanceService.isReviewerRun}). It is carried because it is what the BRIEFING told
+ * the agent to spawn and what {@link ReviewerEvidence} reports, which are both worth recording even
+ * though neither is worth gating on.
  */
 class ExpectedReviewer {
     checklistId;
@@ -179,16 +184,18 @@ class ExpectedReviewer {
 exports.ExpectedReviewer = ExpectedReviewer;
 /**
  * Verifies — from the Claude Code harness's OWN artifacts, never from anything the model asserts — that
- * a subagent of a given `agentType` actually ran during the current session on the current branch. Used
- * to enforce that every checklist was reviewed by a subagent of the repo reviewer-agent type: that an INDEPENDENT
- * reviewer looked, rather than the coding agent self-certifying.
+ * a real SUBAGENT actually ran on the current branch and did this checklist's work. Used to enforce that
+ * every checklist was reviewed by an INDEPENDENT reviewer, rather than by the coding agent
+ * self-certifying.
  *
  * The harness writes, beside each subagent transcript:
- *   ~/.claude/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.meta.json  → { agentType, spawnDepth, … }
- *   ~/.claude/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.jsonl      → record 0 { isSidechain, gitBranch, … }
- * `agentType`/`spawnDepth`/`isSidechain` are written by Claude Code, not by the model. We locate the dir
- * by the unique sessionId (globbing `projects/&#42;/<sessionId>/subagents`), so the cwd-slug never has to be
- * derived/guessed.
+ *   <config>/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.meta.json  → { agentType, spawnDepth, … }
+ *   <config>/projects/<cwd-slug>/<sessionId>/subagents/agent-<id>.jsonl      → record 0 { isSidechain, gitBranch, … }
+ * `spawnDepth`/`isSidechain` are written by Claude Code, not by the model, and they are what carries the
+ * anti-self-certification property. `agentType` is written there too and is deliberately NOT checked —
+ * see {@link SubagentProvenanceService.isReviewerRun}. `<config>` is `$CLAUDE_CONFIG_DIR` when set, else
+ * `~/.claude`; see {@link ClaudeConfigDir}, and never re-derive it here. Dirs are found by walking
+ * every session, so the cwd-slug never has to be derived/guessed.
  *
  * IMPORTANT — this is NOT tamper-proof. A determined agent can `cat >` a fake agent-*.meta.json. This
  * raises the bar from "trust the model's word" to "deliberate, auditable forgery outside the repo"; it
@@ -388,19 +395,20 @@ let SubagentProvenanceService = class SubagentProvenanceService {
     skipped(what) {
         return new ProvenanceResult(exports.PROVENANCE_SKIPPED, `CLAUDE_CODE_SESSION_ID not set — cannot verify ${what} ran (plain terminal / CI). Skipping the provenance check.`, {}, []);
     }
-    // The agentId of a matching subagent run for `want.agentType` on `branch`, searched across ALL sessions'
-    // subagent dirs (branch-scoped, so a run from a prior session still counts). '' if none. `exclude`
-    // skips agentIds already credited to another checklist so one run can't satisfy two.
+    // The agentId of a subagent run on `branch`, searched across ALL sessions' subagent dirs
+    // (branch-scoped, so a run from a prior session still counts). '' if none. `exclude` skips agentIds
+    // already credited to another checklist so one run can't satisfy two.
     //
-    // Now that every checklist shares ONE agent type, several runs match, so the one that NAMED this
-    // checklist's verdict file wins; the first branch-matching run is the fallback, as before.
+    // The run is NOT matched on its agent type — see isReviewerRun for why that check was removed — so
+    // several runs match and the one that NAMED this checklist's verdict file wins; the first
+    // branch-matching run is the fallback, as before.
     // eslint-disable-next-line @typescript-eslint/max-params
     findMatchingAgentId(dirs, want, context, exclude) {
         let fallback = '';
         for (const dir of dirs) {
             for (const metaFile of this.metaFiles(dir)) {
                 const agentId = this.agentIdOf(metaFile);
-                if (exclude.has(agentId) || !this.isReviewerRun(dir, metaFile, want.agentType))
+                if (exclude.has(agentId) || !this.isReviewerRun(dir, metaFile))
                     continue;
                 if (!this.sidechainOnBranch(dir, agentId, want.checklistId, context))
                     continue;
@@ -412,10 +420,32 @@ let SubagentProvenanceService = class SubagentProvenanceService {
         }
         return fallback;
     }
-    // A harness-written meta for a real subagent (spawnDepth >= 1) of the wanted type.
-    isReviewerRun(dir, metaFile, agentType) {
+    /**
+     * A harness-written meta for a REAL SUBAGENT — `spawnDepth >= 1`, and nothing about its NAME.
+     *
+     * The agent TYPE used to be compared against the configured reviewer agent, and that check is
+     * gone (issue #964). It proved nothing: `agentType` is a label on a prompt, and it does not show
+     * the agent read the checklist, opened the diff, or looked at the right branch. The gates that DO
+     * show those are untouched — `spawnDepth >= 1` plus `isSidechain === true` (see
+     * {@link sidechainOnBranch}) are harness-written, so the main loop still cannot self-certify;
+     * {@link creditedByWhatItTouched} proves the branch and the actual work; `requireDiffEvidence`
+     * proves the diff was opened.
+     *
+     * It was also the ONLY gate with an unfixable failure mode. Claude Code snapshots agent
+     * definitions per session and the refresh does not reach an already-running subagent, so a repo
+     * that renames its reviewer agent mid-session leaves that subagent's registry offering only the
+     * OLD names: the spawn is rejected, the agent falls back to `general-purpose`, does the real
+     * review, writes every verdict — and is refused as unattributable, with no cwd, branch or respawn
+     * able to change it. Measured: six checklists, six verdict files on disk, PR blocked.
+     *
+     * Accepted trade-off: without the name check the implementer's own subagent could in principle be
+     * credited, since it touches the diff dir while running the gate. That is deliberate. The rule is
+     * "if the verdict file is there, a subagent wrote it", and this gate's job is to catch "no
+     * subagent ran at all" — not to adjudicate which subagent it was.
+     */
+    isReviewerRun(dir, metaFile) {
         const meta = this.readJson(path.join(dir, metaFile));
-        if (!meta || meta['agentType'] !== agentType)
+        if (!meta)
             return false;
         const spawnDepth = meta['spawnDepth'];
         return typeof spawnDepth === 'number' && spawnDepth >= 1;
@@ -429,19 +459,25 @@ let SubagentProvenanceService = class SubagentProvenanceService {
             return false;
         return this.mentions(this.scanTranscript(jsonl).inputs, verdictPath);
     }
-    // Every `projects/*/<session>/subagents` dir that exists — matching by the recorded gitBranch (not by
-    // session id) is what makes provenance survive across sessions.
+    /**
+     * Every `<config>/projects/&#42;/<session>/subagents` dir that exists — matching by the recorded
+     * gitBranch (not by session id) is what makes provenance survive across sessions.
+     *
+     * `<config>` comes from {@link ClaudeConfigDir.projectsRoots}, which is BOTH the configured
+     * `$CLAUDE_CONFIG_DIR` tree and `~/.claude`. This used to be a hardcoded `~/.claude`, and on a
+     * machine with a relocated config dir that found nothing at all — so every PR was refused with a
+     * message about the reviewers' cwd, which is not what was wrong and which no agent could act on.
+     */
     allSubagentsDirs() {
-        const projects = path.join(os.homedir(), '.claude', 'projects');
-        if (!fs.existsSync(projects))
-            return [];
         const out = [];
-        for (const proj of this.readDir(projects)) {
-            const projDir = path.join(projects, proj);
-            for (const session of this.readDir(projDir)) {
-                const candidate = path.join(projDir, session, 'subagents');
-                if (fs.existsSync(candidate))
-                    out.push(candidate);
+        for (const projects of claude_config_dir_1.claudeConfigDir.projectsRoots()) {
+            for (const proj of this.readDir(projects)) {
+                const projDir = path.join(projects, proj);
+                for (const session of this.readDir(projDir)) {
+                    const candidate = path.join(projDir, session, 'subagents');
+                    if (fs.existsSync(candidate))
+                        out.push(candidate);
+                }
             }
         }
         return out;