@webpieces/rules-config 0.4.537 → 0.4.539

package/src/reviewer-instructions.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ReviewerInstructionsService = exports.ReviewerBriefing = exports.BriefedFile = exports.ContextEntry = void 0;
+exports.ReviewerInstructionsService = exports.ALL_DIFF_ONE_READ_LINES = exports.READ_TRUNCATION_LINES = exports.ReviewerBriefing = exports.BriefedFile = exports.ContextEntry = void 0;
 const tslib_1 = require("tslib");
 const path = tslib_1.__importStar(require("path"));
 const inversify_1 = require("inversify");
@@ -17,13 +17,29 @@ class ContextEntry {
     }
 }
 exports.ContextEntry = ContextEntry;
-/** One reviewer's matched file and the extracted diff for it. Data-only. */
+/**
+ * One reviewer's matched file, the extracted diff for it, AND the absolute path of the file itself.
+ *
+ * `sourcePath` exists because of a measured 0/4: four reviewers on one PR read the diff and not one opened a
+ * single full source file. The instructions handed them an absolute path per diff and only a parent DIRECTORY
+ * per source, so reading the diff was a paste and reading the source was "join this dir to that filename
+ * yourself". Identical affordance, or the cheaper one wins every time. Data-only.
+ */
 class BriefedFile {
     file; // repo-relative source path
     diffPath; // ABSOLUTE path of the extracted .diff
-    constructor(file, diffPath) {
+    sourcePath; // ABSOLUTE path of the file itself; '' for a deleted file, which has no after-state
+    status; // 'M' | 'A' | 'D' | 'U' (untracked) | 'X' (excluded by config)
+    diffBytes;
+    truncated;
+    // eslint-disable-next-line @typescript-eslint/max-params
+    constructor(file, diffPath, sourcePath = '', status = 'M', diffBytes = 0, truncated = false) {
         this.file = file;
         this.diffPath = diffPath;
+        this.sourcePath = sourcePath;
+        this.status = status;
+        this.diffBytes = diffBytes;
+        this.truncated = truncated;
     }
 }
 exports.BriefedFile = BriefedFile;
@@ -49,6 +65,18 @@ class ReviewerBriefing {
     checklistId;
     fileDiffCommand;
     dirty;
+    // Facts ABOUT the manifest, surfaced inline so a reviewer learns the diff is complete without opening it.
+    changedFileCount;
+    truncatedCount;
+    excludedCount;
+    allDiffLines;
+    allDiffBytes;
+    // The three shas, by the names DiffManifest already uses. Printing two bare shas told a reviewer nothing
+    // about WHAT the diff is taken against; C beside A makes "main has moved since the fork" self-evident.
+    hashForkPoint;
+    hashFeatureHead;
+    hashMainHead;
+    ownAgentFileInDiff; // ABSOLUTE path when this diff edits THIS reviewer's own agent file; '' otherwise
     // eslint-disable-next-line @typescript-eslint/max-params
     constructor(subagent, checklistId, repoRoot) {
         this.subagent = subagent;
@@ -65,9 +93,25 @@ class ReviewerBriefing {
         this.verdictPath = '';
         this.fileDiffCommand = '';
         this.dirty = false;
+        this.changedFileCount = 0;
+        this.truncatedCount = 0;
+        this.excludedCount = 0;
+        this.allDiffLines = 0;
+        this.allDiffBytes = 0;
+        this.hashForkPoint = '';
+        this.hashFeatureHead = '';
+        this.hashMainHead = '';
+        this.ownAgentFileInDiff = '';
     }
 }
 exports.ReviewerBriefing = ReviewerBriefing;
+/**
+ * The Read tool truncates at roughly this many lines, silently. Any path this file prints alongside a bigger
+ * line count has to say so, or a reviewer reviews a fraction of a change and reports on all of it.
+ */
+exports.READ_TRUNCATION_LINES = 2000;
+/** Comfortably under {@link READ_TRUNCATION_LINES} — the size at which ALL.diff really is one clean Read. */
+exports.ALL_DIFF_ONE_READ_LINES = 1500;
 /**
  * Renders the per-reviewer instructions file that `wp-review-upsert-pr` writes to
  * `.webpieces/pr-review/<feature>/instructions/<subagent>.instructions.md`.
@@ -117,13 +161,32 @@ let ReviewerInstructionsService = class ReviewerInstructionsService {
             `# You are \`${b.subagent}\``,
             '',
             'Review as YOURSELF, against your own checklist — not as a general code reviewer.',
-            'You may not review your own authorship, and you may not write another reviewer\'s verdict file.',
+            'You may not write another reviewer\'s verdict file.',
+            '',
+            '"You may not review your own authorship" means: you did not write this diff, so review it — but if',
+            'the diff CHANGES YOU, say so in `output` rather than pretending the conflict is not there.',
+            ...this.selfEditWarning(b),
             '',
             '_Generated per run by `wp-review-upsert-pr`. Everything below is already resolved for you; the',
             'paths are absolute because your working directory is not guaranteed to be the repo root._',
             '',
         ];
     }
+    /**
+     * Every PR that edits the review gate hits this: on the measured run, 5 of 8 changed files were the
+     * reviewer agent files themselves, two reviewers reviewed their OWN definition, and neither flagged it —
+     * neither had any guidance to. Detected by the tooling rather than left to the reviewer to notice.
+     */
+    selfEditWarning(b) {
+        if (b.ownAgentFileInDiff === '')
+            return [];
+        return [
+            '',
+            `⚠️  THIS DIFF MODIFIES YOUR OWN AGENT FILE: \`${b.ownAgentFileInDiff}\``,
+            'You are reviewing a change to your own definition. Review it anyway — and state that fact in',
+            '`output`, so a human reading your verdict knows the reviewer and the reviewed were the same thing.',
+        ];
+    }
     checklistSection(b) {
         if (b.docPath === '') {
             return ['## Your checklist', '', 'This checklist has no guidance doc — judge the diff on your own standards.', ''];
@@ -131,8 +194,14 @@ let ReviewerInstructionsService = class ReviewerInstructionsService {
         return ['## Your checklist', '', `Read this FIRST: \`${b.docPath}\``, ''];
     }
     /**
-     * The change itself. The materialized diff leads because it is ONE Read instead of a shell-out per file,
-     * and because a hand-assembled range can come back empty (it did — see DiffBasis).
+     * The change itself. The MANIFEST leads, and the per-file table with it; `ALL.diff` is demoted to one
+     * option among several, recommended only where it is actually the right read.
+     *
+     * That ordering is the fix for a measured 4/4 failure. `ALL.diff` used to be bolded, first, and framed as
+     * "everything", with the manifest one unbolded line below it called a "path map" — which reads like a
+     * lookup aid, not something to open. All four reviewers on that PR read `ALL.diff`, none opened the
+     * manifest, and none could therefore have established that the combined view was complete. Reviewers did
+     * exactly what the emphasis told them to; so the emphasis moved.
      */
     diffSection(b) {
         const lines = ['## The change you are reviewing', ''];
@@ -141,15 +210,7 @@ let ReviewerInstructionsService = class ReviewerInstructionsService {
             lines.push('> commit-to-commit range would show. Judge it anyway — it is what your checklist matched.');
             lines.push('');
         }
-        if (b.allDiffPath !== '') {
-            lines.push(`**Everything on this branch, already extracted:** \`${b.allDiffPath}\``);
-            lines.push('');
-        }
-        lines.push(...this.myFilesTable(b));
-        if (b.manifestPath !== '') {
-            lines.push(`Path map (authoritative; records truncated + excluded files): \`${b.manifestPath}\``);
-            lines.push('');
-        }
+        lines.push(...this.manifestLines(b), ...this.basisLines(b), ...this.myFilesTable(b), ...this.allDiffLines(b));
         if (b.fileDiffCommand !== '') {
             lines.push(`Reproduce any single file: \`${b.fileDiffCommand}\``);
             lines.push('');
@@ -159,26 +220,119 @@ let ReviewerInstructionsService = class ReviewerInstructionsService {
         lines.push('');
         return lines;
     }
+    /**
+     * The manifest, named as the authority AND with its own headline facts inlined. Inlining them is the
+     * point: a reviewer that never opens the manifest still learns whether anything was truncated or
+     * excluded, which is the one thing it could not otherwise have known it was missing.
+     */
+    manifestLines(b) {
+        if (b.manifestPath === '')
+            return [];
+        const warn = b.truncatedCount + b.excludedCount > 0 ? '  ⚠️ NOT everything is materialized — see the table.' : '';
+        return [
+            `**Path map — AUTHORITATIVE. Read this first:** \`${b.manifestPath}\``,
+            `  ${b.changedFileCount} file(s) · ${b.truncatedCount} truncated · ${b.excludedCount} excluded${warn}`,
+            '  Per file it carries: `status` (M/A/D/U/X), `bytes`, `file`/`fileAbs`, `diffFile`/`diffAbs`, and the',
+            '  three shas below. It is the only place that records what was truncated or left out.',
+            '',
+        ];
+    }
+    /**
+     * What the diff is taken AGAINST. Two bare shas in a `git diff` command said nothing about this, so a
+     * reviewer could not tell a fork-point diff from a diff against main's current tip — and therefore could
+     * not tell that anything merged to main since the fork is simply absent from what it is judging.
+     * Rendering C beside A makes "main has moved" self-evident exactly when it has.
+     */
+    basisLines(b) {
+        if (b.hashForkPoint === '')
+            return [];
+        const sameAsFork = b.hashMainHead === b.hashForkPoint;
+        const cNote = b.hashMainHead === '' ? '(unresolved)'
+            : sameAsFork ? `${b.hashMainHead}   ← same as A, so main has not moved since the fork`
+                : `${b.hashMainHead}   ← main HAS MOVED since the fork`;
+        return [
+            'This diff is **fork-point → feature-head**, NOT a diff against main\'s current tip:',
+            '```',
+            `fork point   (A)  ${b.hashForkPoint}`,
+            `feature head (B)  ${b.hashFeatureHead}`,
+            `main head    (C)  ${cNote}`,
+            '```',
+            'Anything merged to main after A is NOT in this diff.',
+            '',
+        ];
+    }
+    /**
+     * Source and diff get IDENTICAL affordance — an absolute path each, in adjacent columns. The previous
+     * table gave an absolute path for the diff and nothing for the source, and the source went unread 4/4.
+     */
     myFilesTable(b) {
         if (b.myFiles.length === 0)
             return ['_No files matched your patterns._', ''];
         const why = b.matchedPatterns.length === 0
             ? `**In scope: ALL ${b.myFiles.length} changed file(s)** — your checklist has no \`patterns\`, so the whole diff is yours.`
             : `**In scope: ${b.myFiles.length} file(s)** matching ${b.matchedPatterns.map((p) => `\`${p}\``).join(', ')}:`;
-        const rows = b.myFiles.map((f) => `| \`${f.file}\` | \`${f.diffPath}\` |`);
-        return [why, '', '| file | its diff |', '|---|---|', ...rows, ''];
+        const rows = b.myFiles.map((f) => this.fileRow(f));
+        return [why, '', '| file | status | its diff | full source |', '|---|---|---|---|', ...rows, ''];
+    }
+    /**
+     * One row. A truncated or excluded diff is flagged HERE, in the row, not left as a field inside a file the
+     * reviewer has to think to open — and an oversized diff states the line count that makes a single Read
+     * come back silently incomplete.
+     */
+    fileRow(f) {
+        const flags = [];
+        if (f.truncated)
+            flags.push('⚠️ diff TRUNCATED — read the source');
+        if (f.status === 'X')
+            flags.push('⚠️ EXCLUDED, not materialized — read the source');
+        const status = [`\`${f.status}\``, ...flags].join(' ');
+        const source = f.sourcePath === '' ? '_deleted — no file on disk_' : `\`${f.sourcePath}\``;
+        return `| \`${f.file}\` | ${status} | \`${f.diffPath}\` (${f.diffBytes} bytes) | ${source} |`;
+    }
+    /**
+     * `ALL.diff`, recommended ONLY where it is the right read. It is kept — for a patternless reviewer on a
+     * small diff it is genuinely one Read instead of N, which is why all four used it — but the blanket
+     * "everything on this branch" line was wrong in two different ways at once: it invited a pattern-scoped
+     * reviewer to spend its budget on files it was explicitly not asked about, and it pointed a reviewer on a
+     * large PR at a file that cannot survive one Read.
+     */
+    allDiffLines(b) {
+        if (b.allDiffPath === '')
+            return [];
+        const size = b.allDiffLines === 0 ? '' : ` — ${b.allDiffLines} lines / ${b.allDiffBytes} bytes`;
+        if (b.matchedPatterns.length > 0) {
+            return [`The whole branch${size}, for CROSS-FILE CONTEXT if you need it: \`${b.allDiffPath}\``,
+                'Your own files above are what you are reviewing; the rest of the branch is someone else\'s checklist.', ''];
+        }
+        if (b.allDiffLines > exports.ALL_DIFF_ONE_READ_LINES) {
+            return [`⚠️ The combined diff is ${b.allDiffLines} lines and will NOT survive a single Read (the Read tool`,
+                `truncates at ~${exports.READ_TRUNCATION_LINES} lines, silently). Read the per-file diffs above instead, or page it:`,
+                `\`${b.allDiffPath}\``, ''];
+        }
+        return [`Whole-branch diff${size} — convenient at this size, but the per-file table above is authoritative:`,
+            `\`${b.allDiffPath}\``, ''];
     }
+    /**
+     * The rule that used to say "when you need to", and lost 4/4 to the more emphatic budget section 40 lines
+     * later. "When you need to" delegates the judgment to a reviewer that, by construction, does not yet know
+     * what it is missing. It has no opt-out now.
+     */
     sourceSection(b) {
-        const lines = ['## Where the source lives', '', `Repo root: \`${b.repoRoot}\``, ''];
+        const lines = ['## Read the full source — every file, every time', '', `Repo root: \`${b.repoRoot}\``, ''];
+        lines.push('**READ THE FULL SOURCE OF EVERY FILE IN YOUR TABLE.** Not "if you need to" — every time.');
+        lines.push('A hunk shows what changed; only the whole file shows what it changed INTO, and a change that');
+        lines.push('looks fine in isolation can still be wrong in place.');
+        lines.push('');
+        lines.push('The `full source` column above is the path. For files marked `A` (added) you have already done');
+        lines.push('this: an add-diff IS the complete file, byte for byte, so its diff and its source are the same');
+        lines.push('text. For `M` (modified) and `D` (deleted) files the diff is a fragment — open the file.');
+        lines.push('');
         if (b.sourceDirs.length > 0) {
-            lines.push('Your matched files live under:');
+            lines.push('The neighbouring code lives under:');
             for (const dir of b.sourceDirs)
                 lines.push(`- \`${dir}\``);
             lines.push('');
         }
-        lines.push('Read whole files around the diff when you need to. The diff is the SUBJECT; the surrounding');
-        lines.push('code is the CONTEXT — a change that looks fine in isolation can still be wrong in place.');
-        lines.push('');
         return lines;
     }
     /**
@@ -187,8 +341,14 @@ let ReviewerInstructionsService = class ReviewerInstructionsService {
      * installed to, and it must never drop an entry silently: a missing path is stated as missing.
      */
     contextSection(b) {
-        if (b.contextEntries.length === 0)
-            return [];
+        // Emitting NOTHING made the section this class exists for look like a feature that does not exist.
+        // One line naming the config keys costs nothing and is the only hint a repo will ever get.
+        if (b.contextEntries.length === 0) {
+            return ['## Pre-resolved context', '',
+                '_None configured for this repo. If you find yourself hunting for the same path on every review,',
+                'it belongs in `pr-gate.reviewContext` / `pr-gate.reviewContextPackages` in `webpieces.config.json`._',
+                ''];
+        }
         const lines = ['## Pre-resolved context (do not go hunting for these)', ''];
         for (const entry of b.contextEntries) {
             const suffix = entry.note === '' ? '' : `  ${entry.note}`;
@@ -213,18 +373,32 @@ let ReviewerInstructionsService = class ReviewerInstructionsService {
             '',
         ];
     }
+    /**
+     * The anti-hunting rule, with the changed files carved out explicitly.
+     *
+     * It used to read as "stay inside what you were given" and, being the LAST thing in the file, it beat
+     * the source-reading instruction 4 times out of 4. It never distinguished HUNTING — greps into
+     * `node_modules`, re-deriving the dependency graph — from OPENING A FILE IT WAS EXPLICITLY HANDED. The
+     * distinction is now stated, because where two instructions conflict the later and more emphatic one wins.
+     */
     budgetSection() {
         return [
             '## Budget',
             '',
-            'Everything you need is listed above. Do NOT search `node_modules`, do NOT re-derive the dependency',
-            'graph, and do NOT hunt the repo for infrastructure config — those paths are either given above or',
-            'were not configured. If something you genuinely need is missing, name it in `output` and give your',
-            'verdict on what you could actually see. A reviewer that spends its budget searching produces a',
-            'thinner review than one that spends it reading.',
+            'Do NOT search `node_modules`, do NOT re-derive the dependency graph, and do NOT hunt the repo for',
+            'infrastructure config. That is hunting, and it is what wastes a review budget — those paths are',
+            'either given above or were not configured.',
+            '',
+            'Reading the full text of a file that is IN your table is NOT hunting — it is the review. Budget for',
+            'it: read the diff to see what changed, and the source to judge whether it is right in place.',
+            '',
+            'If something you genuinely need is missing, name it in `output` and give your verdict on what you',
+            'could actually see.',
             '',
             'Open your diff files before writing a verdict. `wp-finish-upsert-pr` reads your own transcript and',
-            'reports a verdict written without opening the diff.',
+            'reports a verdict written without opening the diff. It also records the path of that transcript,',
+            'beside what you were offered and what you read, in `provenance.json` next to your verdict file —',
+            'so the review is auditable after the fact. You do not write that file; the tooling does.',
         ];
     }
 };

package/src/reviewer-instructions.js.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-instructions.js","sourceRoot":"","sources":["../../../../../packages/tooling/rules-config/src/reviewer-instructions.ts"],"names":[],"mappings":";;;;AAAA,mDAA6B;AAC7B,yCAA2D;AAC3D,+CAAkD;AAElD,2GAA2G;AAC3G,MAAa,YAAY;IACrB,KAAK,CAAS;IACd,IAAI,CAAS,CAAK,gDAAgD;IAClE,IAAI,CAAS,CAAK,0EAA0E;IAE5F,YAAY,KAAa,EAAE,SAAiB,EAAE,IAAI,GAAG,EAAE;QACnD,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,IAAI,GAAG,SAAS,CAAC;QACtB,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;IACrB,CAAC;CACJ;AAVD,oCAUC;AAED,4EAA4E;AAC5E,MAAa,WAAW;IACpB,IAAI,CAAS,CAAM,4BAA4B;IAC/C,QAAQ,CAAS,CAAE,uCAAuC;IAE1D,YAAY,IAAY,EAAE,QAAgB;QACtC,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;IAC7B,CAAC;CACJ;AARD,kCAQC;AAED;;;;;;GAMG;AACH,MAAa,gBAAgB;IACzB,QAAQ,CAAS;IACjB,OAAO,CAAS,CAAc,gEAAgE;IAC9F,QAAQ,CAAS;IACjB,OAAO,CAAS,CAAc,mCAAmC;IACjE,WAAW,CAAS;IACpB,YAAY,CAAS;IACrB,OAAO,CAAgB,CAAO,qCAAqC;IACnE,eAAe,CAAW,CAAI,+CAA+C;IAC7E,UAAU,CAAW,CAAS,0CAA0C;IACxE,cAAc,CAAiB;IAC/B,WAAW,CAAS,CAAU,4BAA4B;IAC1D,WAAW,CAAS;IACpB,eAAe,CAAS;IACxB,KAAK,CAAU;IAEf,yDAAyD;IACzD,YAAY,QAAgB,EAAE,WAAmB,EAAE,QAAgB;QAC/D,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAC/B,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;QAClB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;QAClB,IAAI,CAAC,WAAW,GAAG,EAAE,CAAC;QACtB,IAAI,CAAC,YAAY,GAAG,EAAE,CAAC;QACvB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;QAClB,IAAI,CAAC,eAAe,GAAG,EAAE,CAAC;QAC1B,IAAI,CAAC,UAAU,GAAG,EAAE,CAAC;QACrB,IAAI,CAAC,cAAc,GAAG,EAAE,CAAC;QACzB,IAAI,CAAC,WAAW,GAAG,EAAE,CAAC;QACtB,IAAI,CAAC,eAAe,GAAG,EAAE,CAAC;QAC1B,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;IACvB,CAAC;CACJ;AAjCD,4CAiCC;AAED;;;;;;;;;;;;;;;GAeG;AAEI,IAAM,2BAA2B,GAAjC,MAAM,2BAA2B;IACP;IAA7B,YAA6B,iBAAoC;QAApC,sBAAiB,GAAjB,iBAAiB,CAAmB;IAAG,CAAC;IAErE,oFAAoF;IACpF,kBAAkB,CAAC,QAAgB,EAAE,WAAmB;QACpD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,iBAAiB,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,cAAc,CAAC,CAAC;IAC7F,CAAC;IAED,6DAA6D;IAC7D,WAAW,CAAC,QAAgB;QACxB,OAAO,GAAG,QAAQ,kBAAkB,CAAC;IACzC,CAAC;IAED,mEAAmE;IACnE,OAAO,CAAC,QAAgB,EAAE,WAAmB,EAAE,QAAgB;QAC3D,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC,CAAC;IACjG,CAAC;IAED,MAAM,CAAC,QAA0B;QAC7B,OAAO;YACH,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC;YAC1B,GAAG,IAAI,CAAC,gBAAgB,CAAC,QAAQ,CAAC;YAClC,GAAG,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC;YAC7B,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,CAAC;YAC/B,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC;YAChC,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC;YAChC,GAAG,IAAI,CAAC,aAAa,EAAE;SAC1B,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC;IACxB,CAAC;IAEO,QAAQ,CAAC,CAAmB;QAChC,OAAO;YACH,eAAe,CAAC,CAAC,QAAQ,IAAI;YAC7B,EAAE;YACF,kFAAkF;YAClF,iGAAiG;YACjG,EAAE;YACF,gGAAgG;YAChG,2FAA2F;YAC3F,EAAE;SACL,CAAC;IACN,CAAC;IAEO,gBAAgB,CAAC,CAAmB;QACxC,IAAI,CAAC,CAAC,OAAO,KAAK,EAAE,EAAE,CAAC;YACnB,OAAO,CAAC,mBAAmB,EAAE,EAAE,EAAE,4EAA4E,EAAE,EAAE,CAAC,CAAC;QACvH,CAAC;QACD,OAAO,CAAC,mBAAmB,EAAE,EAAE,EAAE,sBAAsB,CAAC,CAAC,OAAO,IAAI,EAAE,EAAE,CAAC,CAAC;IAC9E,CAAC;IAED;;;OAGG;IACK,WAAW,CAAC,CAAmB;QACnC,MAAM,KAAK,GAAG,CAAC,iCAAiC,EAAE,EAAE,CAAC,CAAC;QACtD,IAAI,CAAC,CAAC,KAAK,EAAE,CAAC;YACV,KAAK,CAAC,IAAI,CAAC,6EAA6E,CAAC,CAAC;YAC1F,KAAK,CAAC,IAAI,CAAC,2FAA2F,CAAC,CAAC;YACxG,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,IAAI,CAAC,CAAC,WAAW,KAAK,EAAE,EAAE,CAAC;YACvB,KAAK,CAAC,IAAI,CAAC,uDAAuD,CAAC,CAAC,WAAW,IAAI,CAAC,CAAC;YACrF,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,CAAC;QACpC,IAAI,CAAC,CAAC,YAAY,KAAK,EAAE,EAAE,CAAC;YACxB,KAAK,CAAC,IAAI,CAAC,mEAAmE,CAAC,CAAC,YAAY,IAAI,CAAC,CAAC;YAClG,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,IAAI,CAAC,CAAC,eAAe,KAAK,EAAE,EAAE,CAAC;YAC3B,KAAK,CAAC,IAAI,CAAC,gCAAgC,CAAC,CAAC,eAAe,IAAI,CAAC,CAAC;YAClE,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,6FAA6F,CAAC,CAAC;QAC1G,KAAK,CAAC,IAAI,CAAC,mEAAmE,CAAC,CAAC;QAChF,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC;IACjB,CAAC;IAEO,YAAY,CAAC,CAAmB;QACpC,IAAI,CAAC,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,CAAC,mCAAmC,EAAE,EAAE,CAAC,CAAC;QAC7E,MAAM,GAAG,GAAG,CAAC,CAAC,eAAe,CAAC,MAAM,KAAK,CAAC;YACtC,CAAC,CAAC,mBAAmB,CAAC,CAAC,OAAO,CAAC,MAAM,sFAAsF;YAC3H,CAAC,CAAC,eAAe,CAAC,CAAC,OAAO,CAAC,MAAM,uBAAuB,CAAC,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC;QACnI,MAAM,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAc,EAAU,EAAE,CAAC,OAAO,CAAC,CAAC,IAAI,UAAU,CAAC,CAAC,QAAQ,MAAM,CAAC,CAAC;QAChG,OAAO,CAAC,GAAG,EAAE,EAAE,EAAE,qBAAqB,EAAE,WAAW,EAAE,GAAG,IAAI,EAAE,EAAE,CAAC,CAAC;IACtE,CAAC;IAEO,aAAa,CAAC,CAAmB;QACrC,MAAM,KAAK,GAAG,CAAC,2BAA2B,EAAE,EAAE,EAAE,gBAAgB,CAAC,CAAC,QAAQ,IAAI,EAAE,EAAE,CAAC,CAAC;QACpF,IAAI,CAAC,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC1B,KAAK,CAAC,IAAI,CAAC,gCAAgC,CAAC,CAAC;YAC7C,KAAK,MAAM,GAAG,IAAI,CAAC,CAAC,UAAU;gBAAE,KAAK,CAAC,IAAI,CAAC,OAAO,GAAG,IAAI,CAAC,CAAC;YAC3D,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,6FAA6F,CAAC,CAAC;QAC1G,KAAK,CAAC,IAAI,CAAC,0FAA0F,CAAC,CAAC;QACvG,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC;IACjB,CAAC;IAED;;;;OAIG;IACK,cAAc,CAAC,CAAmB;QACtC,IAAI,CAAC,CAAC,cAAc,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAC7C,MAAM,KAAK,GAAG,CAAC,uDAAuD,EAAE,EAAE,CAAC,CAAC;QAC5E,KAAK,MAAM,KAAK,IAAI,CAAC,CAAC,cAAc,EAAE,CAAC;YACnC,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,CAAC,IAAI,EAAE,CAAC;YAC1D,KAAK,CAAC,IAAI,CAAC,OAAO,KAAK,CAAC,KAAK,UAAU,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC;QAC9H,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC;IACjB,CAAC;IAED;;;OAGG;IACK,cAAc,CAAC,CAAmB;QACtC,OAAO;YACH,uBAAuB;YACvB,EAAE;YACF,qDAAqD,CAAC,CAAC,WAAW,IAAI;YACtE,EAAE;YACF,KAAK;YACL,IAAI,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,CAAC,CAAC,WAAW,EAAE,EAAE,EAAE,EAAE,CAAC;YAC9D,KAAK;YACL,EAAE;SACL,CAAC;IACN,CAAC;IAEO,aAAa;QACjB,OAAO;YACH,WAAW;YACX,EAAE;YACF,oGAAoG;YACpG,mGAAmG;YACnG,oGAAoG;YACpG,gGAAgG;YAChG,iDAAiD;YACjD,EAAE;YACF,oGAAoG;YACpG,qDAAqD;SACxD,CAAC;IACN,CAAC;CACJ,CAAA;AArJY,kEAA2B;sCAA3B,2BAA2B;IADvC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAEW,+BAAiB;GADxD,2BAA2B,CAqJvC","sourcesContent":["import * as path from 'path';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { ReviewJsonService } from './review-json';\n\n/** One pre-resolved place a reviewer would otherwise have to go hunting for. Data-only (per CLAUDE.md). */\nexport class ContextEntry {\n    label: string;\n    path: string;     // ABSOLUTE, or '' when it could not be resolved\n    note: string;     // '(not installed)' / '(configured but missing)' — never silently dropped\n\n    constructor(label: string, entryPath: string, note = '') {\n        this.label = label;\n        this.path = entryPath;\n        this.note = note;\n    }\n}\n\n/** One reviewer's matched file and the extracted diff for it. Data-only. */\nexport class BriefedFile {\n    file: string;      // repo-relative source path\n    diffPath: string;  // ABSOLUTE path of the extracted .diff\n\n    constructor(file: string, diffPath: string) {\n        this.file = file;\n        this.diffPath = diffPath;\n    }\n}\n\n/**\n * Everything ONE reviewer needs, with every path already resolved to an ABSOLUTE one.\n *\n * Absolute is not fussiness: a subagent's working directory is not guaranteed to be the repo root, and a\n * relative path that fails to resolve turns into a search, which is the cost this whole class exists to\n * remove. Data-only.\n */\nexport class ReviewerBriefing {\n    subagent: string;\n    docPath: string;              // the checklist's guidance doc ('' when the checklist has none)\n    repoRoot: string;\n    diffDir: string;              // '' when nothing was materialized\n    allDiffPath: string;\n    manifestPath: string;\n    myFiles: BriefedFile[];       // ONLY this reviewer's matched files\n    matchedPatterns: string[];    // [] ⇒ patternless: the whole diff is in scope\n    sourceDirs: string[];         // deduped ABSOLUTE parent dirs of myFiles\n    contextEntries: ContextEntry[];\n    verdictPath: string;          // ABSOLUTE review-<id>.json\n    checklistId: string;\n    fileDiffCommand: string;\n    dirty: boolean;\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(subagent: string, checklistId: string, repoRoot: string) {\n        this.subagent = subagent;\n        this.checklistId = checklistId;\n        this.repoRoot = repoRoot;\n        this.docPath = '';\n        this.diffDir = '';\n        this.allDiffPath = '';\n        this.manifestPath = '';\n        this.myFiles = [];\n        this.matchedPatterns = [];\n        this.sourceDirs = [];\n        this.contextEntries = [];\n        this.verdictPath = '';\n        this.fileDiffCommand = '';\n        this.dirty = false;\n    }\n}\n\n/**\n * Renders the per-reviewer instructions file that `wp-review-upsert-pr` writes to\n * `.webpieces/pr-review/<feature>/instructions/<subagent>.instructions.md`.\n *\n * WHY this file exists, measured rather than assumed: a reviewer subagent on monorepo-nx2 spent **14 of its\n * 26 tool calls** rediscovering context the tooling already had — three separate greps into\n * `node_modules/@webpieces` to locate a scanner, a hunt through terraform for queue names, and a\n * re-derivation of the dependency graph. It did not over-review; it was under-supplied. Everything below is\n * chosen to delete a specific one of those calls.\n *\n * It is GENERATED per run, and the registered `.claude/agents/<subagent>.md` is a thin stub that points\n * here, because content a human maintains goes stale and a reviewer follows the stale copy. The verdict\n * schema in particular comes from {@link ReviewJsonService.verdictSchemaFor}.\n *\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewerInstructionsService {\n    constructor(private readonly reviewJsonService: ReviewJsonService) {}\n\n    /** The dir holding this branch's generated instructions, beside its review.json. */\n    instructionsDirFor(repoRoot: string, featureName: string): string {\n        return path.join(this.reviewJsonService.prDirFor(repoRoot, featureName), 'instructions');\n    }\n\n    /** The file name for a reviewer's generated instructions. */\n    fileNameFor(subagent: string): string {\n        return `${subagent}.instructions.md`;\n    }\n\n    /** Absolute path of one reviewer's generated instructions file. */\n    pathFor(repoRoot: string, featureName: string, subagent: string): string {\n        return path.join(this.instructionsDirFor(repoRoot, featureName), this.fileNameFor(subagent));\n    }\n\n    render(briefing: ReviewerBriefing): string {\n        return [\n            ...this.identity(briefing),\n            ...this.checklistSection(briefing),\n            ...this.diffSection(briefing),\n            ...this.sourceSection(briefing),\n            ...this.contextSection(briefing),\n            ...this.verdictSection(briefing),\n            ...this.budgetSection(),\n        ].join('\\n') + '\\n';\n    }\n\n    private identity(b: ReviewerBriefing): string[] {\n        return [\n            `# You are \\`${b.subagent}\\``,\n            '',\n            'Review as YOURSELF, against your own checklist — not as a general code reviewer.',\n            'You may not review your own authorship, and you may not write another reviewer\\'s verdict file.',\n            '',\n            '_Generated per run by `wp-review-upsert-pr`. Everything below is already resolved for you; the',\n            'paths are absolute because your working directory is not guaranteed to be the repo root._',\n            '',\n        ];\n    }\n\n    private checklistSection(b: ReviewerBriefing): string[] {\n        if (b.docPath === '') {\n            return ['## Your checklist', '', 'This checklist has no guidance doc — judge the diff on your own standards.', ''];\n        }\n        return ['## Your checklist', '', `Read this FIRST: \\`${b.docPath}\\``, ''];\n    }\n\n    /**\n     * The change itself. The materialized diff leads because it is ONE Read instead of a shell-out per file,\n     * and because a hand-assembled range can come back empty (it did — see DiffBasis).\n     */\n    private diffSection(b: ReviewerBriefing): string[] {\n        const lines = ['## The change you are reviewing', ''];\n        if (b.dirty) {\n            lines.push('> ⚠️ This diff INCLUDES uncommitted and untracked work, so it is not what a');\n            lines.push('> commit-to-commit range would show. Judge it anyway — it is what your checklist matched.');\n            lines.push('');\n        }\n        if (b.allDiffPath !== '') {\n            lines.push(`**Everything on this branch, already extracted:** \\`${b.allDiffPath}\\``);\n            lines.push('');\n        }\n        lines.push(...this.myFilesTable(b));\n        if (b.manifestPath !== '') {\n            lines.push(`Path map (authoritative; records truncated + excluded files): \\`${b.manifestPath}\\``);\n            lines.push('');\n        }\n        if (b.fileDiffCommand !== '') {\n            lines.push(`Reproduce any single file: \\`${b.fileDiffCommand}\\``);\n            lines.push('');\n        }\n        lines.push('Path matching is COARSE. Judge the change, not the path — if a matched file turns out to be');\n        lines.push('irrelevant to your checklist, say so in one sentence and move on.');\n        lines.push('');\n        return lines;\n    }\n\n    private myFilesTable(b: ReviewerBriefing): string[] {\n        if (b.myFiles.length === 0) return ['_No files matched your patterns._', ''];\n        const why = b.matchedPatterns.length === 0\n            ? `**In scope: ALL ${b.myFiles.length} changed file(s)** — your checklist has no \\`patterns\\`, so the whole diff is yours.`\n            : `**In scope: ${b.myFiles.length} file(s)** matching ${b.matchedPatterns.map((p: string): string => `\\`${p}\\``).join(', ')}:`;\n        const rows = b.myFiles.map((f: BriefedFile): string => `| \\`${f.file}\\` | \\`${f.diffPath}\\` |`);\n        return [why, '', '| file | its diff |', '|---|---|', ...rows, ''];\n    }\n\n    private sourceSection(b: ReviewerBriefing): string[] {\n        const lines = ['## Where the source lives', '', `Repo root: \\`${b.repoRoot}\\``, ''];\n        if (b.sourceDirs.length > 0) {\n            lines.push('Your matched files live under:');\n            for (const dir of b.sourceDirs) lines.push(`- \\`${dir}\\``);\n            lines.push('');\n        }\n        lines.push('Read whole files around the diff when you need to. The diff is the SUBJECT; the surrounding');\n        lines.push('code is the CONTEXT — a change that looks fine in isolation can still be wrong in place.');\n        lines.push('');\n        return lines;\n    }\n\n    /**\n     * The section that deletes the `node_modules` greps. Entries come from config, because the tooling\n     * cannot guess that a repo keeps its queue names in terraform — but it CAN resolve where a package\n     * installed to, and it must never drop an entry silently: a missing path is stated as missing.\n     */\n    private contextSection(b: ReviewerBriefing): string[] {\n        if (b.contextEntries.length === 0) return [];\n        const lines = ['## Pre-resolved context (do not go hunting for these)', ''];\n        for (const entry of b.contextEntries) {\n            const suffix = entry.note === '' ? '' : `  ${entry.note}`;\n            lines.push(`- **${entry.label}** — \\`${entry.path === '' ? entry.note : entry.path}\\`${entry.path === '' ? '' : suffix}`);\n        }\n        lines.push('');\n        return lines;\n    }\n\n    /**\n     * The verdict shape, GENERATED — never restated in a hand-maintained file. `id` is pre-filled with this\n     * reviewer's own checklist id so there is nothing to substitute and nothing to get wrong.\n     */\n    private verdictSection(b: ReviewerBriefing): string[] {\n        return [\n            '## Write your verdict',\n            '',\n            `Write EXACTLY this shape, to EXACTLY this file: \\`${b.verdictPath}\\``,\n            '',\n            '```',\n            this.reviewJsonService.verdictSchemaFor(b.checklistId, '', ''),\n            '```',\n            '',\n        ];\n    }\n\n    private budgetSection(): string[] {\n        return [\n            '## Budget',\n            '',\n            'Everything you need is listed above. Do NOT search `node_modules`, do NOT re-derive the dependency',\n            'graph, and do NOT hunt the repo for infrastructure config — those paths are either given above or',\n            'were not configured. If something you genuinely need is missing, name it in `output` and give your',\n            'verdict on what you could actually see. A reviewer that spends its budget searching produces a',\n            'thinner review than one that spends it reading.',\n            '',\n            'Open your diff files before writing a verdict. `wp-finish-upsert-pr` reads your own transcript and',\n            'reports a verdict written without opening the diff.',\n        ];\n    }\n}\n"]}
+{"version":3,"file":"reviewer-instructions.js","sourceRoot":"","sources":["../../../../../packages/tooling/rules-config/src/reviewer-instructions.ts"],"names":[],"mappings":";;;;AAAA,mDAA6B;AAC7B,yCAA2D;AAC3D,+CAAkD;AAElD,2GAA2G;AAC3G,MAAa,YAAY;IACrB,KAAK,CAAS;IACd,IAAI,CAAS,CAAK,gDAAgD;IAClE,IAAI,CAAS,CAAK,0EAA0E;IAE5F,YAAY,KAAa,EAAE,SAAiB,EAAE,IAAI,GAAG,EAAE;QACnD,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,IAAI,GAAG,SAAS,CAAC;QACtB,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;IACrB,CAAC;CACJ;AAVD,oCAUC;AAED;;;;;;;GAOG;AACH,MAAa,WAAW;IACpB,IAAI,CAAS,CAAQ,4BAA4B;IACjD,QAAQ,CAAS,CAAI,uCAAuC;IAC5D,UAAU,CAAS,CAAE,oFAAoF;IACzG,MAAM,CAAS,CAAM,+DAA+D;IACpF,SAAS,CAAS;IAClB,SAAS,CAAU;IAEnB,yDAAyD;IACzD,YAAY,IAAY,EAAE,QAAgB,EAAE,UAAU,GAAG,EAAE,EAAE,MAAM,GAAG,GAAG,EAAE,SAAS,GAAG,CAAC,EAAE,SAAS,GAAG,KAAK;QACvG,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,UAAU,GAAG,UAAU,CAAC;QAC7B,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;IAC/B,CAAC;CACJ;AAjBD,kCAiBC;AAED;;;;;;GAMG;AACH,MAAa,gBAAgB;IACzB,QAAQ,CAAS;IACjB,OAAO,CAAS,CAAc,gEAAgE;IAC9F,QAAQ,CAAS;IACjB,OAAO,CAAS,CAAc,mCAAmC;IACjE,WAAW,CAAS;IACpB,YAAY,CAAS;IACrB,OAAO,CAAgB,CAAO,qCAAqC;IACnE,eAAe,CAAW,CAAI,+CAA+C;IAC7E,UAAU,CAAW,CAAS,0CAA0C;IACxE,cAAc,CAAiB;IAC/B,WAAW,CAAS,CAAU,4BAA4B;IAC1D,WAAW,CAAS;IACpB,eAAe,CAAS;IACxB,KAAK,CAAU;IACf,0GAA0G;IAC1G,gBAAgB,CAAS;IACzB,cAAc,CAAS;IACvB,aAAa,CAAS;IACtB,YAAY,CAAS;IACrB,YAAY,CAAS;IACrB,yGAAyG;IACzG,uGAAuG;IACvG,aAAa,CAAS;IACtB,eAAe,CAAS;IACxB,YAAY,CAAS;IACrB,kBAAkB,CAAS,CAAG,kFAAkF;IAEhH,yDAAyD;IACzD,YAAY,QAAgB,EAAE,WAAmB,EAAE,QAAgB;QAC/D,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAC/B,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;QAClB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;QAClB,IAAI,CAAC,WAAW,GAAG,EAAE,CAAC;QACtB,IAAI,CAAC,YAAY,GAAG,EAAE,CAAC;QACvB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;QAClB,IAAI,CAAC,eAAe,GAAG,EAAE,CAAC;QAC1B,IAAI,CAAC,UAAU,GAAG,EAAE,CAAC;QACrB,IAAI,CAAC,cAAc,GAAG,EAAE,CAAC;QACzB,IAAI,CAAC,WAAW,GAAG,EAAE,CAAC;QACtB,IAAI,CAAC,eAAe,GAAG,EAAE,CAAC;QAC1B,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,gBAAgB,GAAG,CAAC,CAAC;QAC1B,IAAI,CAAC,cAAc,GAAG,CAAC,CAAC;QACxB,IAAI,CAAC,aAAa,GAAG,CAAC,CAAC;QACvB,IAAI,CAAC,YAAY,GAAG,CAAC,CAAC;QACtB,IAAI,CAAC,YAAY,GAAG,CAAC,CAAC;QACtB,IAAI,CAAC,aAAa,GAAG,EAAE,CAAC;QACxB,IAAI,CAAC,eAAe,GAAG,EAAE,CAAC;QAC1B,IAAI,CAAC,YAAY,GAAG,EAAE,CAAC;QACvB,IAAI,CAAC,kBAAkB,GAAG,EAAE,CAAC;IACjC,CAAC;CACJ;AAtDD,4CAsDC;AAED;;;GAGG;AACU,QAAA,qBAAqB,GAAG,IAAI,CAAC;AAE1C,6GAA6G;AAChG,QAAA,uBAAuB,GAAG,IAAI,CAAC;AAE5C;;;;;;;;;;;;;;;GAeG;AAEI,IAAM,2BAA2B,GAAjC,MAAM,2BAA2B;IACP;IAA7B,YAA6B,iBAAoC;QAApC,sBAAiB,GAAjB,iBAAiB,CAAmB;IAAG,CAAC;IAErE,oFAAoF;IACpF,kBAAkB,CAAC,QAAgB,EAAE,WAAmB;QACpD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,iBAAiB,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,cAAc,CAAC,CAAC;IAC7F,CAAC;IAED,6DAA6D;IAC7D,WAAW,CAAC,QAAgB;QACxB,OAAO,GAAG,QAAQ,kBAAkB,CAAC;IACzC,CAAC;IAED,mEAAmE;IACnE,OAAO,CAAC,QAAgB,EAAE,WAAmB,EAAE,QAAgB;QAC3D,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC,CAAC;IACjG,CAAC;IAED,MAAM,CAAC,QAA0B;QAC7B,OAAO;YACH,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC;YAC1B,GAAG,IAAI,CAAC,gBAAgB,CAAC,QAAQ,CAAC;YAClC,GAAG,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC;YAC7B,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,CAAC;YAC/B,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC;YAChC,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC;YAChC,GAAG,IAAI,CAAC,aAAa,EAAE;SAC1B,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC;IACxB,CAAC;IAEO,QAAQ,CAAC,CAAmB;QAChC,OAAO;YACH,eAAe,CAAC,CAAC,QAAQ,IAAI;YAC7B,EAAE;YACF,kFAAkF;YAClF,qDAAqD;YACrD,EAAE;YACF,oGAAoG;YACpG,4FAA4F;YAC5F,GAAG,IAAI,CAAC,eAAe,CAAC,CAAC,CAAC;YAC1B,EAAE;YACF,gGAAgG;YAChG,2FAA2F;YAC3F,EAAE;SACL,CAAC;IACN,CAAC;IAED;;;;OAIG;IACK,eAAe,CAAC,CAAmB;QACvC,IAAI,CAAC,CAAC,kBAAkB,KAAK,EAAE;YAAE,OAAO,EAAE,CAAC;QAC3C,OAAO;YACH,EAAE;YACF,iDAAiD,CAAC,CAAC,kBAAkB,IAAI;YACzE,8FAA8F;YAC9F,oGAAoG;SACvG,CAAC;IACN,CAAC;IAEO,gBAAgB,CAAC,CAAmB;QACxC,IAAI,CAAC,CAAC,OAAO,KAAK,EAAE,EAAE,CAAC;YACnB,OAAO,CAAC,mBAAmB,EAAE,EAAE,EAAE,4EAA4E,EAAE,EAAE,CAAC,CAAC;QACvH,CAAC;QACD,OAAO,CAAC,mBAAmB,EAAE,EAAE,EAAE,sBAAsB,CAAC,CAAC,OAAO,IAAI,EAAE,EAAE,CAAC,CAAC;IAC9E,CAAC;IAED;;;;;;;;;OASG;IACK,WAAW,CAAC,CAAmB;QACnC,MAAM,KAAK,GAAG,CAAC,iCAAiC,EAAE,EAAE,CAAC,CAAC;QACtD,IAAI,CAAC,CAAC,KAAK,EAAE,CAAC;YACV,KAAK,CAAC,IAAI,CAAC,6EAA6E,CAAC,CAAC;YAC1F,KAAK,CAAC,IAAI,CAAC,2FAA2F,CAAC,CAAC;YACxG,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,CAAC,CAAC,EAAE,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,CAAC;QAC9G,IAAI,CAAC,CAAC,eAAe,KAAK,EAAE,EAAE,CAAC;YAC3B,KAAK,CAAC,IAAI,CAAC,gCAAgC,CAAC,CAAC,eAAe,IAAI,CAAC,CAAC;YAClE,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,6FAA6F,CAAC,CAAC;QAC1G,KAAK,CAAC,IAAI,CAAC,mEAAmE,CAAC,CAAC;QAChF,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC;IACjB,CAAC;IAED;;;;OAIG;IACK,aAAa,CAAC,CAAmB;QACrC,IAAI,CAAC,CAAC,YAAY,KAAK,EAAE;YAAE,OAAO,EAAE,CAAC;QACrC,MAAM,IAAI,GAAG,CAAC,CAAC,cAAc,GAAG,CAAC,CAAC,aAAa,GAAG,CAAC,CAAC,CAAC,CAAC,sDAAsD,CAAC,CAAC,CAAC,EAAE,CAAC;QAClH,OAAO;YACH,oDAAoD,CAAC,CAAC,YAAY,IAAI;YACtE,KAAK,CAAC,CAAC,gBAAgB,cAAc,CAAC,CAAC,cAAc,gBAAgB,CAAC,CAAC,aAAa,YAAY,IAAI,EAAE;YACtG,uGAAuG;YACvG,uFAAuF;YACvF,EAAE;SACL,CAAC;IACN,CAAC;IAED;;;;;OAKG;IACK,UAAU,CAAC,CAAmB;QAClC,IAAI,CAAC,CAAC,aAAa,KAAK,EAAE;YAAE,OAAO,EAAE,CAAC;QACtC,MAAM,UAAU,GAAG,CAAC,CAAC,YAAY,KAAK,CAAC,CAAC,aAAa,CAAC;QACtD,MAAM,KAAK,GAAG,CAAC,CAAC,YAAY,KAAK,EAAE,CAAC,CAAC,CAAC,cAAc;YAChD,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,YAAY,sDAAsD;gBACtF,CAAC,CAAC,GAAG,CAAC,CAAC,YAAY,oCAAoC,CAAC;QAC5D,OAAO;YACH,qFAAqF;YACrF,KAAK;YACL,qBAAqB,CAAC,CAAC,aAAa,EAAE;YACtC,qBAAqB,CAAC,CAAC,eAAe,EAAE;YACxC,qBAAqB,KAAK,EAAE;YAC5B,KAAK;YACL,sDAAsD;YACtD,EAAE;SACL,CAAC;IACN,CAAC;IAED;;;OAGG;IACK,YAAY,CAAC,CAAmB;QACpC,IAAI,CAAC,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,CAAC,mCAAmC,EAAE,EAAE,CAAC,CAAC;QAC7E,MAAM,GAAG,GAAG,CAAC,CAAC,eAAe,CAAC,MAAM,KAAK,CAAC;YACtC,CAAC,CAAC,mBAAmB,CAAC,CAAC,OAAO,CAAC,MAAM,sFAAsF;YAC3H,CAAC,CAAC,eAAe,CAAC,CAAC,OAAO,CAAC,MAAM,uBAAuB,CAAC,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC;QACnI,MAAM,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAc,EAAU,EAAE,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC;QACxE,OAAO,CAAC,GAAG,EAAE,EAAE,EAAE,4CAA4C,EAAE,mBAAmB,EAAE,GAAG,IAAI,EAAE,EAAE,CAAC,CAAC;IACrG,CAAC;IAED;;;;OAIG;IACK,OAAO,CAAC,CAAc;QAC1B,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,IAAI,CAAC,CAAC,SAAS;YAAE,KAAK,CAAC,IAAI,CAAC,qCAAqC,CAAC,CAAC;QACnE,IAAI,CAAC,CAAC,MAAM,KAAK,GAAG;YAAE,KAAK,CAAC,IAAI,CAAC,iDAAiD,CAAC,CAAC;QACpF,MAAM,MAAM,GAAG,CAAC,KAAK,CAAC,CAAC,MAAM,IAAI,EAAE,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QACvD,MAAM,MAAM,GAAG,CAAC,CAAC,UAAU,KAAK,EAAE,CAAC,CAAC,CAAC,6BAA6B,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,UAAU,IAAI,CAAC;QAC3F,OAAO,OAAO,CAAC,CAAC,IAAI,QAAQ,MAAM,QAAQ,CAAC,CAAC,QAAQ,OAAO,CAAC,CAAC,SAAS,aAAa,MAAM,IAAI,CAAC;IAClG,CAAC;IAED;;;;;;OAMG;IACK,YAAY,CAAC,CAAmB;QACpC,IAAI,CAAC,CAAC,WAAW,KAAK,EAAE;YAAE,OAAO,EAAE,CAAC;QACpC,MAAM,IAAI,GAAG,CAAC,CAAC,YAAY,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,YAAY,YAAY,CAAC,CAAC,YAAY,QAAQ,CAAC;QAChG,IAAI,CAAC,CAAC,eAAe,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC/B,OAAO,CAAC,mBAAmB,IAAI,8CAA8C,CAAC,CAAC,WAAW,IAAI;gBAC1F,uGAAuG,EAAE,EAAE,CAAC,CAAC;QACrH,CAAC;QACD,IAAI,CAAC,CAAC,YAAY,GAAG,+BAAuB,EAAE,CAAC;YAC3C,OAAO,CAAC,2BAA2B,CAAC,CAAC,YAAY,0DAA0D;gBACvG,iBAAiB,6BAAqB,uEAAuE;gBAC7G,KAAK,CAAC,CAAC,WAAW,IAAI,EAAE,EAAE,CAAC,CAAC;QACpC,CAAC;QACD,OAAO,CAAC,oBAAoB,IAAI,4EAA4E;YACxG,KAAK,CAAC,CAAC,WAAW,IAAI,EAAE,EAAE,CAAC,CAAC;IACpC,CAAC;IAED;;;;OAIG;IACK,aAAa,CAAC,CAAmB;QACrC,MAAM,KAAK,GAAG,CAAC,kDAAkD,EAAE,EAAE,EAAE,gBAAgB,CAAC,CAAC,QAAQ,IAAI,EAAE,EAAE,CAAC,CAAC;QAC3G,KAAK,CAAC,IAAI,CAAC,0FAA0F,CAAC,CAAC;QACvG,KAAK,CAAC,IAAI,CAAC,8FAA8F,CAAC,CAAC;QAC3G,KAAK,CAAC,IAAI,CAAC,sDAAsD,CAAC,CAAC;QACnE,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,KAAK,CAAC,IAAI,CAAC,gGAAgG,CAAC,CAAC;QAC7G,KAAK,CAAC,IAAI,CAAC,gGAAgG,CAAC,CAAC;QAC7G,KAAK,CAAC,IAAI,CAAC,0FAA0F,CAAC,CAAC;QACvG,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,IAAI,CAAC,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC1B,KAAK,CAAC,IAAI,CAAC,oCAAoC,CAAC,CAAC;YACjD,KAAK,MAAM,GAAG,IAAI,CAAC,CAAC,UAAU;gBAAE,KAAK,CAAC,IAAI,CAAC,OAAO,GAAG,IAAI,CAAC,CAAC;YAC3D,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;QACD,OAAO,KAAK,CAAC;IACjB,CAAC;IAED;;;;OAIG;IACK,cAAc,CAAC,CAAmB;QACtC,mGAAmG;QACnG,2FAA2F;QAC3F,IAAI,CAAC,CAAC,cAAc,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAChC,OAAO,CAAC,yBAAyB,EAAE,EAAE;gBACjC,iGAAiG;gBACjG,sGAAsG;gBACtG,EAAE,CAAC,CAAC;QACZ,CAAC;QACD,MAAM,KAAK,GAAG,CAAC,uDAAuD,EAAE,EAAE,CAAC,CAAC;QAC5E,KAAK,MAAM,KAAK,IAAI,CAAC,CAAC,cAAc,EAAE,CAAC;YACnC,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,CAAC,IAAI,EAAE,CAAC;YAC1D,KAAK,CAAC,IAAI,CAAC,OAAO,KAAK,CAAC,KAAK,UAAU,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC;QAC9H,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC;IACjB,CAAC;IAED;;;OAGG;IACK,cAAc,CAAC,CAAmB;QACtC,OAAO;YACH,uBAAuB;YACvB,EAAE;YACF,qDAAqD,CAAC,CAAC,WAAW,IAAI;YACtE,EAAE;YACF,KAAK;YACL,IAAI,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,CAAC,CAAC,WAAW,EAAE,EAAE,EAAE,EAAE,CAAC;YAC9D,KAAK;YACL,EAAE;SACL,CAAC;IACN,CAAC;IAED;;;;;;;OAOG;IACK,aAAa;QACjB,OAAO;YACH,WAAW;YACX,EAAE;YACF,mGAAmG;YACnG,iGAAiG;YACjG,4CAA4C;YAC5C,EAAE;YACF,qGAAqG;YACrG,8FAA8F;YAC9F,EAAE;YACF,mGAAmG;YACnG,qBAAqB;YACrB,EAAE;YACF,oGAAoG;YACpG,kGAAkG;YAClG,kGAAkG;YAClG,0FAA0F;SAC7F,CAAC;IACN,CAAC;CACJ,CAAA;AAvRY,kEAA2B;sCAA3B,2BAA2B;IADvC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAEW,+BAAiB;GADxD,2BAA2B,CAuRvC","sourcesContent":["import * as path from 'path';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { ReviewJsonService } from './review-json';\n\n/** One pre-resolved place a reviewer would otherwise have to go hunting for. Data-only (per CLAUDE.md). */\nexport class ContextEntry {\n    label: string;\n    path: string;     // ABSOLUTE, or '' when it could not be resolved\n    note: string;     // '(not installed)' / '(configured but missing)' — never silently dropped\n\n    constructor(label: string, entryPath: string, note = '') {\n        this.label = label;\n        this.path = entryPath;\n        this.note = note;\n    }\n}\n\n/**\n * One reviewer's matched file, the extracted diff for it, AND the absolute path of the file itself.\n *\n * `sourcePath` exists because of a measured 0/4: four reviewers on one PR read the diff and not one opened a\n * single full source file. The instructions handed them an absolute path per diff and only a parent DIRECTORY\n * per source, so reading the diff was a paste and reading the source was \"join this dir to that filename\n * yourself\". Identical affordance, or the cheaper one wins every time. Data-only.\n */\nexport class BriefedFile {\n    file: string;        // repo-relative source path\n    diffPath: string;    // ABSOLUTE path of the extracted .diff\n    sourcePath: string;  // ABSOLUTE path of the file itself; '' for a deleted file, which has no after-state\n    status: string;      // 'M' | 'A' | 'D' | 'U' (untracked) | 'X' (excluded by config)\n    diffBytes: number;\n    truncated: boolean;\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(file: string, diffPath: string, sourcePath = '', status = 'M', diffBytes = 0, truncated = false) {\n        this.file = file;\n        this.diffPath = diffPath;\n        this.sourcePath = sourcePath;\n        this.status = status;\n        this.diffBytes = diffBytes;\n        this.truncated = truncated;\n    }\n}\n\n/**\n * Everything ONE reviewer needs, with every path already resolved to an ABSOLUTE one.\n *\n * Absolute is not fussiness: a subagent's working directory is not guaranteed to be the repo root, and a\n * relative path that fails to resolve turns into a search, which is the cost this whole class exists to\n * remove. Data-only.\n */\nexport class ReviewerBriefing {\n    subagent: string;\n    docPath: string;              // the checklist's guidance doc ('' when the checklist has none)\n    repoRoot: string;\n    diffDir: string;              // '' when nothing was materialized\n    allDiffPath: string;\n    manifestPath: string;\n    myFiles: BriefedFile[];       // ONLY this reviewer's matched files\n    matchedPatterns: string[];    // [] ⇒ patternless: the whole diff is in scope\n    sourceDirs: string[];         // deduped ABSOLUTE parent dirs of myFiles\n    contextEntries: ContextEntry[];\n    verdictPath: string;          // ABSOLUTE review-<id>.json\n    checklistId: string;\n    fileDiffCommand: string;\n    dirty: boolean;\n    // Facts ABOUT the manifest, surfaced inline so a reviewer learns the diff is complete without opening it.\n    changedFileCount: number;\n    truncatedCount: number;\n    excludedCount: number;\n    allDiffLines: number;\n    allDiffBytes: number;\n    // The three shas, by the names DiffManifest already uses. Printing two bare shas told a reviewer nothing\n    // about WHAT the diff is taken against; C beside A makes \"main has moved since the fork\" self-evident.\n    hashForkPoint: string;\n    hashFeatureHead: string;\n    hashMainHead: string;\n    ownAgentFileInDiff: string;   // ABSOLUTE path when this diff edits THIS reviewer's own agent file; '' otherwise\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(subagent: string, checklistId: string, repoRoot: string) {\n        this.subagent = subagent;\n        this.checklistId = checklistId;\n        this.repoRoot = repoRoot;\n        this.docPath = '';\n        this.diffDir = '';\n        this.allDiffPath = '';\n        this.manifestPath = '';\n        this.myFiles = [];\n        this.matchedPatterns = [];\n        this.sourceDirs = [];\n        this.contextEntries = [];\n        this.verdictPath = '';\n        this.fileDiffCommand = '';\n        this.dirty = false;\n        this.changedFileCount = 0;\n        this.truncatedCount = 0;\n        this.excludedCount = 0;\n        this.allDiffLines = 0;\n        this.allDiffBytes = 0;\n        this.hashForkPoint = '';\n        this.hashFeatureHead = '';\n        this.hashMainHead = '';\n        this.ownAgentFileInDiff = '';\n    }\n}\n\n/**\n * The Read tool truncates at roughly this many lines, silently. Any path this file prints alongside a bigger\n * line count has to say so, or a reviewer reviews a fraction of a change and reports on all of it.\n */\nexport const READ_TRUNCATION_LINES = 2000;\n\n/** Comfortably under {@link READ_TRUNCATION_LINES} — the size at which ALL.diff really is one clean Read. */\nexport const ALL_DIFF_ONE_READ_LINES = 1500;\n\n/**\n * Renders the per-reviewer instructions file that `wp-review-upsert-pr` writes to\n * `.webpieces/pr-review/<feature>/instructions/<subagent>.instructions.md`.\n *\n * WHY this file exists, measured rather than assumed: a reviewer subagent on monorepo-nx2 spent **14 of its\n * 26 tool calls** rediscovering context the tooling already had — three separate greps into\n * `node_modules/@webpieces` to locate a scanner, a hunt through terraform for queue names, and a\n * re-derivation of the dependency graph. It did not over-review; it was under-supplied. Everything below is\n * chosen to delete a specific one of those calls.\n *\n * It is GENERATED per run, and the registered `.claude/agents/<subagent>.md` is a thin stub that points\n * here, because content a human maintains goes stale and a reviewer follows the stale copy. The verdict\n * schema in particular comes from {@link ReviewJsonService.verdictSchemaFor}.\n *\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewerInstructionsService {\n    constructor(private readonly reviewJsonService: ReviewJsonService) {}\n\n    /** The dir holding this branch's generated instructions, beside its review.json. */\n    instructionsDirFor(repoRoot: string, featureName: string): string {\n        return path.join(this.reviewJsonService.prDirFor(repoRoot, featureName), 'instructions');\n    }\n\n    /** The file name for a reviewer's generated instructions. */\n    fileNameFor(subagent: string): string {\n        return `${subagent}.instructions.md`;\n    }\n\n    /** Absolute path of one reviewer's generated instructions file. */\n    pathFor(repoRoot: string, featureName: string, subagent: string): string {\n        return path.join(this.instructionsDirFor(repoRoot, featureName), this.fileNameFor(subagent));\n    }\n\n    render(briefing: ReviewerBriefing): string {\n        return [\n            ...this.identity(briefing),\n            ...this.checklistSection(briefing),\n            ...this.diffSection(briefing),\n            ...this.sourceSection(briefing),\n            ...this.contextSection(briefing),\n            ...this.verdictSection(briefing),\n            ...this.budgetSection(),\n        ].join('\\n') + '\\n';\n    }\n\n    private identity(b: ReviewerBriefing): string[] {\n        return [\n            `# You are \\`${b.subagent}\\``,\n            '',\n            'Review as YOURSELF, against your own checklist — not as a general code reviewer.',\n            'You may not write another reviewer\\'s verdict file.',\n            '',\n            '\"You may not review your own authorship\" means: you did not write this diff, so review it — but if',\n            'the diff CHANGES YOU, say so in `output` rather than pretending the conflict is not there.',\n            ...this.selfEditWarning(b),\n            '',\n            '_Generated per run by `wp-review-upsert-pr`. Everything below is already resolved for you; the',\n            'paths are absolute because your working directory is not guaranteed to be the repo root._',\n            '',\n        ];\n    }\n\n    /**\n     * Every PR that edits the review gate hits this: on the measured run, 5 of 8 changed files were the\n     * reviewer agent files themselves, two reviewers reviewed their OWN definition, and neither flagged it —\n     * neither had any guidance to. Detected by the tooling rather than left to the reviewer to notice.\n     */\n    private selfEditWarning(b: ReviewerBriefing): string[] {\n        if (b.ownAgentFileInDiff === '') return [];\n        return [\n            '',\n            `⚠️  THIS DIFF MODIFIES YOUR OWN AGENT FILE: \\`${b.ownAgentFileInDiff}\\``,\n            'You are reviewing a change to your own definition. Review it anyway — and state that fact in',\n            '`output`, so a human reading your verdict knows the reviewer and the reviewed were the same thing.',\n        ];\n    }\n\n    private checklistSection(b: ReviewerBriefing): string[] {\n        if (b.docPath === '') {\n            return ['## Your checklist', '', 'This checklist has no guidance doc — judge the diff on your own standards.', ''];\n        }\n        return ['## Your checklist', '', `Read this FIRST: \\`${b.docPath}\\``, ''];\n    }\n\n    /**\n     * The change itself. The MANIFEST leads, and the per-file table with it; `ALL.diff` is demoted to one\n     * option among several, recommended only where it is actually the right read.\n     *\n     * That ordering is the fix for a measured 4/4 failure. `ALL.diff` used to be bolded, first, and framed as\n     * \"everything\", with the manifest one unbolded line below it called a \"path map\" — which reads like a\n     * lookup aid, not something to open. All four reviewers on that PR read `ALL.diff`, none opened the\n     * manifest, and none could therefore have established that the combined view was complete. Reviewers did\n     * exactly what the emphasis told them to; so the emphasis moved.\n     */\n    private diffSection(b: ReviewerBriefing): string[] {\n        const lines = ['## The change you are reviewing', ''];\n        if (b.dirty) {\n            lines.push('> ⚠️ This diff INCLUDES uncommitted and untracked work, so it is not what a');\n            lines.push('> commit-to-commit range would show. Judge it anyway — it is what your checklist matched.');\n            lines.push('');\n        }\n        lines.push(...this.manifestLines(b), ...this.basisLines(b), ...this.myFilesTable(b), ...this.allDiffLines(b));\n        if (b.fileDiffCommand !== '') {\n            lines.push(`Reproduce any single file: \\`${b.fileDiffCommand}\\``);\n            lines.push('');\n        }\n        lines.push('Path matching is COARSE. Judge the change, not the path — if a matched file turns out to be');\n        lines.push('irrelevant to your checklist, say so in one sentence and move on.');\n        lines.push('');\n        return lines;\n    }\n\n    /**\n     * The manifest, named as the authority AND with its own headline facts inlined. Inlining them is the\n     * point: a reviewer that never opens the manifest still learns whether anything was truncated or\n     * excluded, which is the one thing it could not otherwise have known it was missing.\n     */\n    private manifestLines(b: ReviewerBriefing): string[] {\n        if (b.manifestPath === '') return [];\n        const warn = b.truncatedCount + b.excludedCount > 0 ? '  ⚠️ NOT everything is materialized — see the table.' : '';\n        return [\n            `**Path map — AUTHORITATIVE. Read this first:** \\`${b.manifestPath}\\``,\n            `  ${b.changedFileCount} file(s) · ${b.truncatedCount} truncated · ${b.excludedCount} excluded${warn}`,\n            '  Per file it carries: `status` (M/A/D/U/X), `bytes`, `file`/`fileAbs`, `diffFile`/`diffAbs`, and the',\n            '  three shas below. It is the only place that records what was truncated or left out.',\n            '',\n        ];\n    }\n\n    /**\n     * What the diff is taken AGAINST. Two bare shas in a `git diff` command said nothing about this, so a\n     * reviewer could not tell a fork-point diff from a diff against main's current tip — and therefore could\n     * not tell that anything merged to main since the fork is simply absent from what it is judging.\n     * Rendering C beside A makes \"main has moved\" self-evident exactly when it has.\n     */\n    private basisLines(b: ReviewerBriefing): string[] {\n        if (b.hashForkPoint === '') return [];\n        const sameAsFork = b.hashMainHead === b.hashForkPoint;\n        const cNote = b.hashMainHead === '' ? '(unresolved)'\n            : sameAsFork ? `${b.hashMainHead}   ← same as A, so main has not moved since the fork`\n            : `${b.hashMainHead}   ← main HAS MOVED since the fork`;\n        return [\n            'This diff is **fork-point → feature-head**, NOT a diff against main\\'s current tip:',\n            '```',\n            `fork point   (A)  ${b.hashForkPoint}`,\n            `feature head (B)  ${b.hashFeatureHead}`,\n            `main head    (C)  ${cNote}`,\n            '```',\n            'Anything merged to main after A is NOT in this diff.',\n            '',\n        ];\n    }\n\n    /**\n     * Source and diff get IDENTICAL affordance — an absolute path each, in adjacent columns. The previous\n     * table gave an absolute path for the diff and nothing for the source, and the source went unread 4/4.\n     */\n    private myFilesTable(b: ReviewerBriefing): string[] {\n        if (b.myFiles.length === 0) return ['_No files matched your patterns._', ''];\n        const why = b.matchedPatterns.length === 0\n            ? `**In scope: ALL ${b.myFiles.length} changed file(s)** — your checklist has no \\`patterns\\`, so the whole diff is yours.`\n            : `**In scope: ${b.myFiles.length} file(s)** matching ${b.matchedPatterns.map((p: string): string => `\\`${p}\\``).join(', ')}:`;\n        const rows = b.myFiles.map((f: BriefedFile): string => this.fileRow(f));\n        return [why, '', '| file | status | its diff | full source |', '|---|---|---|---|', ...rows, ''];\n    }\n\n    /**\n     * One row. A truncated or excluded diff is flagged HERE, in the row, not left as a field inside a file the\n     * reviewer has to think to open — and an oversized diff states the line count that makes a single Read\n     * come back silently incomplete.\n     */\n    private fileRow(f: BriefedFile): string {\n        const flags: string[] = [];\n        if (f.truncated) flags.push('⚠️ diff TRUNCATED — read the source');\n        if (f.status === 'X') flags.push('⚠️ EXCLUDED, not materialized — read the source');\n        const status = [`\\`${f.status}\\``, ...flags].join(' ');\n        const source = f.sourcePath === '' ? '_deleted — no file on disk_' : `\\`${f.sourcePath}\\``;\n        return `| \\`${f.file}\\` | ${status} | \\`${f.diffPath}\\` (${f.diffBytes} bytes) | ${source} |`;\n    }\n\n    /**\n     * `ALL.diff`, recommended ONLY where it is the right read. It is kept — for a patternless reviewer on a\n     * small diff it is genuinely one Read instead of N, which is why all four used it — but the blanket\n     * \"everything on this branch\" line was wrong in two different ways at once: it invited a pattern-scoped\n     * reviewer to spend its budget on files it was explicitly not asked about, and it pointed a reviewer on a\n     * large PR at a file that cannot survive one Read.\n     */\n    private allDiffLines(b: ReviewerBriefing): string[] {\n        if (b.allDiffPath === '') return [];\n        const size = b.allDiffLines === 0 ? '' : ` — ${b.allDiffLines} lines / ${b.allDiffBytes} bytes`;\n        if (b.matchedPatterns.length > 0) {\n            return [`The whole branch${size}, for CROSS-FILE CONTEXT if you need it: \\`${b.allDiffPath}\\``,\n                'Your own files above are what you are reviewing; the rest of the branch is someone else\\'s checklist.', ''];\n        }\n        if (b.allDiffLines > ALL_DIFF_ONE_READ_LINES) {\n            return [`⚠️ The combined diff is ${b.allDiffLines} lines and will NOT survive a single Read (the Read tool`,\n                `truncates at ~${READ_TRUNCATION_LINES} lines, silently). Read the per-file diffs above instead, or page it:`,\n                `\\`${b.allDiffPath}\\``, ''];\n        }\n        return [`Whole-branch diff${size} — convenient at this size, but the per-file table above is authoritative:`,\n            `\\`${b.allDiffPath}\\``, ''];\n    }\n\n    /**\n     * The rule that used to say \"when you need to\", and lost 4/4 to the more emphatic budget section 40 lines\n     * later. \"When you need to\" delegates the judgment to a reviewer that, by construction, does not yet know\n     * what it is missing. It has no opt-out now.\n     */\n    private sourceSection(b: ReviewerBriefing): string[] {\n        const lines = ['## Read the full source — every file, every time', '', `Repo root: \\`${b.repoRoot}\\``, ''];\n        lines.push('**READ THE FULL SOURCE OF EVERY FILE IN YOUR TABLE.** Not \"if you need to\" — every time.');\n        lines.push('A hunk shows what changed; only the whole file shows what it changed INTO, and a change that');\n        lines.push('looks fine in isolation can still be wrong in place.');\n        lines.push('');\n        lines.push('The `full source` column above is the path. For files marked `A` (added) you have already done');\n        lines.push('this: an add-diff IS the complete file, byte for byte, so its diff and its source are the same');\n        lines.push('text. For `M` (modified) and `D` (deleted) files the diff is a fragment — open the file.');\n        lines.push('');\n        if (b.sourceDirs.length > 0) {\n            lines.push('The neighbouring code lives under:');\n            for (const dir of b.sourceDirs) lines.push(`- \\`${dir}\\``);\n            lines.push('');\n        }\n        return lines;\n    }\n\n    /**\n     * The section that deletes the `node_modules` greps. Entries come from config, because the tooling\n     * cannot guess that a repo keeps its queue names in terraform — but it CAN resolve where a package\n     * installed to, and it must never drop an entry silently: a missing path is stated as missing.\n     */\n    private contextSection(b: ReviewerBriefing): string[] {\n        // Emitting NOTHING made the section this class exists for look like a feature that does not exist.\n        // One line naming the config keys costs nothing and is the only hint a repo will ever get.\n        if (b.contextEntries.length === 0) {\n            return ['## Pre-resolved context', '',\n                '_None configured for this repo. If you find yourself hunting for the same path on every review,',\n                'it belongs in `pr-gate.reviewContext` / `pr-gate.reviewContextPackages` in `webpieces.config.json`._',\n                ''];\n        }\n        const lines = ['## Pre-resolved context (do not go hunting for these)', ''];\n        for (const entry of b.contextEntries) {\n            const suffix = entry.note === '' ? '' : `  ${entry.note}`;\n            lines.push(`- **${entry.label}** — \\`${entry.path === '' ? entry.note : entry.path}\\`${entry.path === '' ? '' : suffix}`);\n        }\n        lines.push('');\n        return lines;\n    }\n\n    /**\n     * The verdict shape, GENERATED — never restated in a hand-maintained file. `id` is pre-filled with this\n     * reviewer's own checklist id so there is nothing to substitute and nothing to get wrong.\n     */\n    private verdictSection(b: ReviewerBriefing): string[] {\n        return [\n            '## Write your verdict',\n            '',\n            `Write EXACTLY this shape, to EXACTLY this file: \\`${b.verdictPath}\\``,\n            '',\n            '```',\n            this.reviewJsonService.verdictSchemaFor(b.checklistId, '', ''),\n            '```',\n            '',\n        ];\n    }\n\n    /**\n     * The anti-hunting rule, with the changed files carved out explicitly.\n     *\n     * It used to read as \"stay inside what you were given\" and, being the LAST thing in the file, it beat\n     * the source-reading instruction 4 times out of 4. It never distinguished HUNTING — greps into\n     * `node_modules`, re-deriving the dependency graph — from OPENING A FILE IT WAS EXPLICITLY HANDED. The\n     * distinction is now stated, because where two instructions conflict the later and more emphatic one wins.\n     */\n    private budgetSection(): string[] {\n        return [\n            '## Budget',\n            '',\n            'Do NOT search `node_modules`, do NOT re-derive the dependency graph, and do NOT hunt the repo for',\n            'infrastructure config. That is hunting, and it is what wastes a review budget — those paths are',\n            'either given above or were not configured.',\n            '',\n            'Reading the full text of a file that is IN your table is NOT hunting — it is the review. Budget for',\n            'it: read the diff to see what changed, and the source to judge whether it is right in place.',\n            '',\n            'If something you genuinely need is missing, name it in `output` and give your verdict on what you',\n            'could actually see.',\n            '',\n            'Open your diff files before writing a verdict. `wp-finish-upsert-pr` reads your own transcript and',\n            'reports a verdict written without opening the diff. It also records the path of that transcript,',\n            'beside what you were offered and what you read, in `provenance.json` next to your verdict file —',\n            'so the review is auditable after the fact. You do not write that file; the tooling does.',\n        ];\n    }\n}\n"]}

package/src/subagent-provenance.d.ts

@@ -21,7 +21,8 @@ export declare class ReviewerEvidence {
     readDoc: boolean;
     toolCallCount: number;
     offRepoSearches: number;
-    constructor(agentType: string, agentId: string, readDiff?: boolean, readDoc?: boolean, toolCallCount?: number, offRepoSearches?: number);
+    transcriptPath: string;
+    constructor(agentType: string, agentId: string, readDiff?: boolean, readDoc?: boolean, toolCallCount?: number, offRepoSearches?: number, transcriptPath?: string);
 }
 /** What to look for when reading reviewer transcripts. Data-only — avoids a 5-param method. */
 export declare class EvidenceRequest {

package/src/subagent-provenance.js

@@ -37,14 +37,20 @@ class ReviewerEvidence {
     readDoc; // opened its checklist's guidance doc
     toolCallCount;
     offRepoSearches; // tool calls that reached into node_modules — the archaeology signal
+    // Absolute path of the transcript these counters were read out of, '' when it could not be resolved.
+    // Carried out rather than recomputed because a reviewer subagent cannot learn its own transcript path
+    // (the environment exposes the PARENT session id and no agent id), so this is the only place it is
+    // known — see ReviewProvenanceService, which records it as the audit link for the verdict.
+    transcriptPath;
     // eslint-disable-next-line @typescript-eslint/max-params
-    constructor(agentType, agentId, readDiff = false, readDoc = false, toolCallCount = 0, offRepoSearches = 0) {
+    constructor(agentType, agentId, readDiff = false, readDoc = false, toolCallCount = 0, offRepoSearches = 0, transcriptPath = '') {
         this.agentType = agentType;
         this.agentId = agentId;
         this.readDiff = readDiff;
         this.readDoc = readDoc;
         this.toolCallCount = toolCallCount;
         this.offRepoSearches = offRepoSearches;
+        this.transcriptPath = transcriptPath;
     }
 }
 exports.ReviewerEvidence = ReviewerEvidence;
@@ -166,7 +172,7 @@ let SubagentProvenanceService = class SubagentProvenanceService {
         // the reviewer is told to open first, and it inlines the diff paths. A reviewer that opened it and
         // then its own diff files is the intended path; treating only the diff dir as proof would flag it.
         const readDiff = request.diffDir !== '' && this.mentions(inputs, request.diffDir);
-        return new ReviewerEvidence(agentType, agentId, readDiff, docPath !== '' && this.mentions(inputs, docPath), inputs.length, inputs.filter((i) => i.includes('node_modules')).length);
+        return new ReviewerEvidence(agentType, agentId, readDiff, docPath !== '' && this.mentions(inputs, docPath), inputs.length, inputs.filter((i) => i.includes('node_modules')).length, jsonl);
     }
     // The absolute path of agent-<id>.jsonl across all session dirs, or '' if it is not there.
     transcriptPath(dirs, agentId) {