@webpieces/rules-config 0.4.488 → 0.4.490

package/src/review-json.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ReviewJsonService = exports.PrContext = exports.ChecklistVerdict = exports.CK_MISSING = exports.CK_FAIL = exports.CK_OVERRIDDEN = exports.CK_PASS = exports.ReviewJson = exports.ChecklistReviewContext = exports.RequiredChecklist = exports.ChecklistResult = void 0;
+exports.ReviewJsonService = exports.PrContext = exports.ChecklistVerdict = exports.CK_BAD_FORMAT = exports.CK_MISSING = exports.CK_FAIL = exports.CK_OVERRIDDEN = exports.CK_WARN = exports.CK_PASS = exports.ReviewJson = exports.ChecklistReviewContext = exports.RequiredChecklist = exports.ChecklistResult = exports.VERDICT_STATUSES = exports.VERDICT_RED = exports.VERDICT_YELLOW = exports.VERDICT_GREEN = void 0;
 exports.prDirFor = prDirFor;
 exports.reviewJsonPath = reviewJsonPath;
 exports.reviewJsonSchemaHint = reviewJsonSchemaHint;
@@ -12,24 +12,40 @@ const inversify_1 = require("inversify");
 const constants_1 = require("./constants");
 const inform_ai_error_1 = require("./inform-ai-error");
 const to_error_1 = require("./to-error");
+// The three colors a reviewer subagent may report in `review-<id>.json`. A TRI-state, not a boolean,
+// because the boolean it replaced gave a reviewer no way to say "this passes, but a human should look at
+// X" — the only way to raise a concern was to FAIL the PR and then override your own failure, which reads
+// on the dashboard as a deliberately-accepted defect rather than as a note.
+exports.VERDICT_GREEN = 'green';
+exports.VERDICT_YELLOW = 'yellow';
+exports.VERDICT_RED = 'red';
+exports.VERDICT_STATUSES = [exports.VERDICT_GREEN, exports.VERDICT_YELLOW, exports.VERDICT_RED];
 // The verdict a reviewer SUBAGENT writes into `.webpieces/pr-review/<branch>/review-<id>.json`, one per
 // matched checklist. One file per checklist so N concurrent reviewer subagents never clobber a shared
 // file. It records the OUTCOME:
-//   success:true                       → PASS
-//   success:false + override non-empty → OVERRIDDEN (pass; the free-text justification reaches the PR)
-//   success:false + no override        → FAIL (refuse; `output` is printed verbatim)
+//   status:'green'                  → PASS
+//   status:'yellow'                 → WARN (passes; the concern is published on the PR, nothing is blocked)
+//   status:'red' + override non-empty → OVERRIDDEN (pass; the free-text justification reaches the PR)
+//   status:'red' + no override      → FAIL (refuse; `output` is printed verbatim)
 // `override` is deliberately free text, not a boolean — it forces the ship-anyway decision to be stated
 // in words and surfaces it on the dashboard, where a human sees it. Data-only (per CLAUDE.md).
 class ChecklistResult {
     id;
-    success;
+    status; // one of VERDICT_STATUSES; anything else is reported via `problem`
     output; // what the reviewer found; printed verbatim when the checklist fails
-    override; // '' = no override; non-empty = ship-anyway justification (renders 🟡 overridden)
-    constructor(id, success, output, override) {
+    override; // '' = no override; non-empty = ship-anyway justification (renders 🟠 overridden)
+    // '' = a well-formed verdict. Non-empty = the file exists and parses but its verdict cannot be READ
+    // (most often: it still uses the removed `success` field). Carried as data rather than thrown so the
+    // complaint can be reported by BOTH wp-checklist and wp-finish-upsert-pr in identical words, and so a
+    // legacy file is never silently mistaken for a missing one.
+    problem;
+    // eslint-disable-next-line @typescript-eslint/max-params
+    constructor(id, status, output, override, problem = '') {
         this.id = id;
-        this.success = success;
+        this.status = status;
         this.output = output;
         this.override = override;
+        this.problem = problem;
     }
 }
 exports.ChecklistResult = ChecklistResult;
@@ -98,14 +114,17 @@ class ReviewJson {
 }
 exports.ReviewJson = ReviewJson;
 // A checklist's resolved outcome, shared by review.json enforcement and the dashboard so both agree.
-exports.CK_PASS = 'pass'; // review-<id>.json success:true
-exports.CK_OVERRIDDEN = 'overridden'; // review-<id>.json success:false + non-empty override → 🟡
-exports.CK_FAIL = 'fail'; // review-<id>.json success:false + no override → refuse
+// PASS, WARN and OVERRIDDEN all ship; FAIL, MISSING and BAD_FORMAT all refuse the PR.
+exports.CK_PASS = 'pass'; // review-<id>.json status:'green'
+exports.CK_WARN = 'warn'; // review-<id>.json status:'yellow' → 🟡 passes WITH concerns
+exports.CK_OVERRIDDEN = 'overridden'; // review-<id>.json status:'red' + non-empty override → 🟠
+exports.CK_FAIL = 'fail'; // review-<id>.json status:'red' + no override → refuse
 exports.CK_MISSING = 'missing'; // no review-<id>.json written → refuse
+exports.CK_BAD_FORMAT = 'bad-format'; // written, but its verdict is unreadable (e.g. legacy `success`)
 class ChecklistVerdict {
     id;
-    status; // one of CK_PASS | CK_OVERRIDDEN | CK_FAIL | CK_MISSING
-    detail; // reviewer output / override justification (for the dashboard + errors)
+    status; // one of CK_PASS | CK_WARN | CK_OVERRIDDEN | CK_FAIL | CK_MISSING | CK_BAD_FORMAT
+    detail; // reviewer output / override justification / format complaint (dashboard + errors)
     constructor(id, status, detail) {
         this.id = id;
         this.status = status;
@@ -250,7 +269,10 @@ let ReviewJsonService = class ReviewJsonService {
     pendingChecklists(required, results) {
         return required.filter((req) => {
             const status = this.resolveVerdict(req, results).status;
-            return status !== exports.CK_PASS && status !== exports.CK_OVERRIDDEN;
+            // CK_WARN must be listed here beside PASS/OVERRIDDEN. A yellow verdict SHIPS — leaving it out
+            // would mark the checklist owed forever, so `outstanding` never empties and the PR is refused
+            // permanently no matter how many times the reviewer runs.
+            return status !== exports.CK_PASS && status !== exports.CK_WARN && status !== exports.CK_OVERRIDDEN;
         });
     }
     // Read the per-checklist verdict files `review-<id>.json` beside review.json — one per matched checklist.
@@ -269,32 +291,57 @@ let ReviewJsonService = class ReviewJsonService {
         return results;
     }
     // Resolve ONE checklist's verdict from its review-<id>.json. Central so review.json enforcement AND the
-    // finish-command dashboard agree on the outcome.
+    // finish-command dashboard agree on the outcome. `problem` is checked FIRST: a file whose verdict cannot
+    // be read must not fall through to any shipping outcome.
     resolveVerdict(req, results) {
         const result = results.find((r) => r.id === req.id);
         if (!result)
             return new ChecklistVerdict(req.id, exports.CK_MISSING, '');
-        if (result.success)
+        if (result.problem !== '')
+            return new ChecklistVerdict(req.id, exports.CK_BAD_FORMAT, result.problem);
+        if (result.status === exports.VERDICT_GREEN)
             return new ChecklistVerdict(req.id, exports.CK_PASS, result.output);
+        if (result.status === exports.VERDICT_YELLOW)
+            return new ChecklistVerdict(req.id, exports.CK_WARN, result.output);
         if (result.override.trim() !== '')
             return new ChecklistVerdict(req.id, exports.CK_OVERRIDDEN, result.override.trim());
         return new ChecklistVerdict(req.id, exports.CK_FAIL, result.output);
     }
+    /**
+     * One loud complaint per checklist whose verdict file EXISTS but cannot be read as a verdict — almost
+     * always one still using the removed `success` field. Public and separate from
+     * {@link requiredChecklistErrors} because `wp-finish-upsert-pr` refuses on missing reviewers BEFORE it
+     * parses review.json: without this, a legacy file would surface as the generic "no verdict yet" block
+     * and the AI would re-run a reviewer that already ran instead of fixing four characters of JSON.
+     */
+    checklistFormatErrors(required, results) {
+        const errors = [];
+        for (const req of required) {
+            const verdict = this.resolveVerdict(req, results);
+            if (verdict.status === exports.CK_BAD_FORMAT)
+                errors.push(verdict.detail);
+        }
+        return errors;
+    }
     // Every matched checklist whose verdict is FAIL (reviewed, found a problem, no override) or MISSING (no
     // review-<id>.json written) → one error each, printing the reviewer's `output` verbatim.
     requiredChecklistErrors(required, results) {
-        const errors = [];
+        // Format complaints come from the ONE renderer, so wp-checklist and wp-finish word them identically.
+        const errors = this.checklistFormatErrors(required, results);
         for (const req of required) {
             const verdict = this.resolveVerdict(req, results);
+            // CK_WARN ('yellow' — passed with concerns) is deliberately absent from this chain: it SHIPS.
+            // The concern still reaches the PR, published in the checklist comment. Do not "fix" this.
             if (verdict.status === exports.CK_FAIL) {
-                errors.push(`Checklist "${req.id}" FAILED review. The reviewer (${req.subagent}) wrote:\n      ` +
+                errors.push(`Checklist "${req.id}" FAILED review (status:"${exports.VERDICT_RED}"). The reviewer (${req.subagent}) wrote:\n      ` +
                     `${verdict.detail.split('\n').join('\n      ')}\n` +
                     `      Fix it, then re-run; or set a non-empty "override" in ${this.checklistFileName(req.id)} to ship anyway with a stated justification.`);
             }
             else if (verdict.status === exports.CK_MISSING) {
                 const doc = req.doc.trim() !== '' ? ` Read: ${req.doc}.` : '';
                 errors.push(`Checklist "${req.id}" MATCHED this diff but has no verdict. Spawn the "${req.subagent}" subagent to review it, ` +
-                    `then write ${this.checklistFileName(req.id)} with {"id":"${req.id}","success":true,"output":"…"}.${doc}`);
+                    `then write ${this.checklistFileName(req.id)} with ` +
+                    `{"id":"${req.id}","status":"${exports.VERDICT_GREEN}","output":"…","override":""}.${doc}`);
             }
         }
         return errors;
@@ -302,21 +349,28 @@ let ReviewJsonService = class ReviewJsonService {
     checklistFileName(checklistId) {
         return `review-${checklistId}.json`;
     }
-    // Parse one review-<id>.json into a ChecklistResult, or null when malformed. Tolerant: missing
-    // `success` counts as false (fail-closed), `output`/`override` default to ''.
+    /**
+     * Parse one review-<id>.json into a ChecklistResult. `null` ONLY when the bytes do not parse as a JSON
+     * object at all — that tolerance is why a half-written file never wedges a branch, and it degrades to
+     * the same "no verdict yet" message as an absent file, which is honest (nothing readable is there).
+     *
+     * A file that DOES parse always yields a result, even when its verdict is unreadable, carrying the
+     * complaint in `problem`. Returning `null` for those instead would collapse "wrote a verdict in the old
+     * format" into "never wrote a verdict" and send the AI off to re-run a reviewer that already ran.
+     */
     // webpieces-disable no-any-unknown -- opaque parsed JSON, narrowed field-by-field
     parseChecklistResult(filePath, id) {
-        // webpieces-disable no-unmanaged-exceptions -- chokepoint: a malformed per-checklist file is skipped, not fatal
+        // webpieces-disable no-unmanaged-exceptions -- chokepoint: an unparseable per-checklist file is skipped, not fatal
         // eslint-disable-next-line @webpieces/no-unmanaged-exceptions
         try {
             // webpieces-disable no-any-unknown -- parsed JSON is opaque until narrowed below
             const raw = JSON.parse(fs.readFileSync(filePath, 'utf8'));
             if (typeof raw !== 'object' || raw === null || Array.isArray(raw))
                 return null;
-            const success = raw['success'] === true;
             const output = typeof raw['output'] === 'string' ? raw['output'] : '';
             const override = typeof raw['override'] === 'string' ? raw['override'] : '';
-            return new ChecklistResult(id, success, output, override);
+            const status = typeof raw['status'] === 'string' ? raw['status'].trim().toLowerCase() : '';
+            return new ChecklistResult(id, status, output, override, this.statusProblem(filePath, id, status, raw));
         }
         catch (err) {
             const error = (0, to_error_1.toError)(err);
@@ -324,6 +378,30 @@ let ReviewJsonService = class ReviewJsonService {
             return null;
         }
     }
+    /**
+     * '' when `status` is one of the three colors. Otherwise the complaint to show the AI verbatim. The
+     * legacy-`success` case gets its OWN message: `success` was removed outright (no compatibility mode),
+     * and a reviewer told only "status must be green|yellow|red" cannot tell whether it wrote the wrong
+     * value or is using a field that no longer exists.
+     */
+    // webpieces-disable no-any-unknown -- opaque parsed JSON; only tested for key presence here
+    statusProblem(filePath, id, status, raw) {
+        // webpieces-disable no-any-unknown -- comparing against the readonly literal tuple of valid colors
+        if (exports.VERDICT_STATUSES.includes(status))
+            return '';
+        const shape = `      { "id": "${id}", "status": "${exports.VERDICT_GREEN} | ${exports.VERDICT_YELLOW} | ${exports.VERDICT_RED}", ` +
+            `"output": "what you checked / found", "override": "" }\n` +
+            `        ${exports.VERDICT_GREEN}  → passes\n` +
+            `        ${exports.VERDICT_YELLOW} → passes WITH CONCERNS; nothing is blocked and the concern is published on the PR\n` +
+            `        ${exports.VERDICT_RED}    → REFUSES the PR (set a non-empty "override" to ship anyway with a stated justification)\n` +
+            `      File: ${filePath}`;
+        if ('success' in raw) {
+            return `Checklist "${id}" wrote its verdict with the REMOVED "success" field. It is now a tri-state ` +
+                `"status" — there is no compatibility mode. Rewrite the file as:\n${shape}`;
+        }
+        return `Checklist "${id}" wrote a verdict with no valid "status" (got ${JSON.stringify(status)}). ` +
+            `It must be exactly one of ${exports.VERDICT_STATUSES.join(', ')}:\n${shape}`;
+    }
     // webpieces-disable no-any-unknown -- opaque parsed JSON value, narrowed to string[] here
     asStringArray(value) {
         if (!Array.isArray(value))

package/src/review-json.js.map

@@ -1 +1 @@
-{"version":3,"file":"review-json.js","sourceRoot":"","sources":["../../../../../packages/tooling/rules-config/src/review-json.ts"],"names":[],"mappings":";;;AA+YA,4BAEC;AAGD,wCAEC;AAGD,oDAEC;AAGD,wCAEC;;AAhaD,+CAAyB;AACzB,mDAA6B;AAC7B,yCAA2D;AAC3D,2CAA+D;AAC/D,uDAAkD;AAClD,yCAAqC;AAErC,wGAAwG;AACxG,sGAAsG;AACtG,gCAAgC;AAChC,8CAA8C;AAC9C,uGAAuG;AACvG,qFAAqF;AACrF,wGAAwG;AACxG,+FAA+F;AAC/F,MAAa,eAAe;IACxB,EAAE,CAAS;IACX,OAAO,CAAU;IACjB,MAAM,CAAS,CAAG,qEAAqE;IACvF,QAAQ,CAAS,CAAE,kFAAkF;IAErG,YAAY,EAAU,EAAE,OAAgB,EAAE,MAAc,EAAE,QAAgB;QACtE,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC;QACb,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;QACvB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;IAC7B,CAAC;CACJ;AAZD,0CAYC;AAED,yGAAyG;AACzG,wGAAwG;AACxG,sCAAsC;AACtC,MAAa,iBAAiB;IAC1B,EAAE,CAAS,CAAa,yCAAyC;IACjE,QAAQ,CAAS,CAAO,8DAA8D;IACtF,GAAG,CAAS,CAAY,8EAA8E;IACtG,YAAY,CAAW,CAAC,+DAA+D;IACvF,oGAAoG;IACpG,uGAAuG;IACvG,sGAAsG;IACtG,eAAe,CAAW;IAE1B,yDAAyD;IACzD,YAAY,EAAU,EAAE,QAAgB,EAAE,GAAW,EAAE,YAAsB,EAAE,kBAA4B,EAAE;QACzG,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC;QACb,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,GAAG,GAAG,GAAG,CAAC;QACf,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;QACjC,IAAI,CAAC,eAAe,GAAG,eAAe,CAAC;IAC3C,CAAC;CACJ;AAlBD,8CAkBC;AAED;;;;;GAKG;AACH,MAAa,sBAAsB;IAC/B,OAAO,CAAS,CAAQ,kEAAkE;IAC1F,aAAa,CAAS,CAAE,oEAAoE;IAE5F,YAAY,OAAO,GAAG,EAAE,EAAE,aAAa,GAAG,EAAE;QACxC,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;QACvB,IAAI,CAAC,aAAa,GAAG,aAAa,CAAC;IACvC,CAAC;CACJ;AARD,wDAQC;AAED,wGAAwG;AACxG,4GAA4G;AAC5G,qDAAqD;AACrD,MAAa,UAAU;IACnB,KAAK,CAAS,CAAC,8FAA8F;IAC7G,SAAS,CAAS,CAAC,6BAA6B;IAChD,SAAS,CAAS,CAAC,6BAA6B;IAChD,SAAS,CAAS,CAAC,2DAA2D;IAC9E,OAAO,CAAS,CAAC,4CAA4C;IAC7D,UAAU,CAAW,CAAC,yEAAyE;IAC/F,KAAK,CAAW;IAChB,aAAa,CAAW;IACxB,OAAO,CAAoB,CAAC,wEAAwE;IAEpG,yDAAyD;IACzD,YACI,KAAa,EACb,SAAiB,EACjB,SAAiB,EACjB,SAAiB,EACjB,OAAe,EACf,UAAoB,EACpB,KAAe,EACf,aAAuB,EACvB,UAA6B,EAAE;QAE/B,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;QACvB,IAAI,CAAC,UAAU,GAAG,UAAU,CAAC;QAC7B,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,aAAa,GAAG,aAAa,CAAC;QACnC,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;IAC3B,CAAC;CACJ;AAjCD,gCAiCC;AAED,qGAAqG;AACxF,QAAA,OAAO,GAAG,MAAM,CAAC,CAAe,gCAAgC;AAChE,QAAA,aAAa,GAAG,YAAY,CAAC,CAAG,2DAA2D;AAC3F,QAAA,OAAO,GAAG,MAAM,CAAC,CAAe,wDAAwD;AACxF,QAAA,UAAU,GAAG,SAAS,CAAC,CAAS,uCAAuC;AAEpF,MAAa,gBAAgB;IACzB,EAAE,CAAS;IACX,MAAM,CAAS,CAAC,wDAAwD;IACxE,MAAM,CAAS,CAAC,wEAAwE;IAExF,YAAY,EAAU,EAAE,MAAc,EAAE,MAAc;QAClD,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC;QACb,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;IACzB,CAAC;CACJ;AAVD,4CAUC;AAED,4GAA4G;AAC5G,yGAAyG;AACzG,0GAA0G;AAC1G,yGAAyG;AACzG,MAAa,SAAS;IAClB,IAAI,CAAS,CAAU,oDAAoD;IAC3E,IAAI,CAAS,CAAU,WAAW;IAClC,YAAY,CAAW,CAAC,+EAA+E;IAEvG,YAAY,IAAY,EAAE,IAAY,EAAE,YAAsB;QAC1D,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;IACrC,CAAC;CACJ;AAVD,8BAUC;AAED,MAAM,WAAW,GAAG,CAAC,OAAO,EAAE,QAAQ,EAAE,KAAK,CAAU,CAAC;AACxD,MAAM,eAAe,GAA2B,EAAE,KAAK,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC;AAEzF,sIAAsI;AAE/H,IAAM,iBAAiB,GAAvB,MAAM,iBAAiB;IAC1B,oEAAoE;IACpE,QAAQ,CAAC,QAAgB,EAAE,WAAmB;QAC1C,OAAO,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,6BAAiB,EAAE,yBAAa,EAAE,WAAW,CAAC,CAAC;IAC9E,CAAC;IAED,4FAA4F;IAC5F,cAAc,CAAC,QAAgB,EAAE,WAAmB;QAChD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,aAAa,CAAC,CAAC;IAC1E,CAAC;IAED,2FAA2F;IAC3F,aAAa,CAAC,QAAgB,EAAE,WAAmB;QAC/C,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,iBAAiB,CAAC,CAAC;IAC9E,CAAC;IAED,qGAAqG;IACrG,0FAA0F;IAC1F,cAAc,CAAC,QAAgB,EAAE,WAAmB,EAAE,OAAkB;QACpE,MAAM,GAAG,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACjD,EAAE,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACvC,MAAM,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACpD,EAAE,CAAC,aAAa,CAAC,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,GAAG,IAAI,CAAC,CAAC;QAC7D,OAAO,CAAC,CAAC;IACb,CAAC;IAED;;;;;OAKG;IACH,gBAAgB,CAAC,QAAgB,EAAE,WAAmB;QAClD,MAAM,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACpD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC;YAAE,OAAO,IAAI,sBAAsB,EAAE,CAAC;QAC3D,qIAAqI;QACrI,8DAA8D;QAC9D,IAAI,CAAC;YACD,4FAA4F;YAC5F,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,YAAY,CAAC,CAAC,EAAE,MAAM,CAAC,CAA4B,CAAC;YAC9E,MAAM,IAAI,GAAG,OAAO,GAAG,CAAC,MAAM,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,MAAM,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5E,OAAO,IAAI,sBAAsB,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAC/C,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,kBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,KAAK,KAAK,CAAC;YACX,OAAO,IAAI,sBAAsB,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC;QAC7C,CAAC;IACL,CAAC;IAED,qGAAqG;IACrG,kGAAkG;IAClG,sEAAsE;IACtE,oBAAoB,CAAC,QAAgB;QACjC,OAAO,CACH,+BAA+B,QAAQ,MAAM;YAC7C,+EAA+E;YAC/E,KAAK;YACL,sFAAsF;YACtF,+EAA+E;YAC/E,0CAA0C;YAC1C,gDAAgD;YAChD,wFAAwF;YACxF,uDAAuD;YACvD,6EAA6E;YAC7E,GAAG,CACN,CAAC;IACN,CAAC;IAED,qFAAqF;IACrF,mBAAmB,CAAC,kBAA0B,EAAE,WAAmB;QAC/D,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,kBAAkB,CAAC,EAAE,UAAU,WAAW,OAAO,CAAC,CAAC;IACrF,CAAC;IAED;;;;;OAKG;IACH,oGAAoG;IACpG,cAAc,CAAC,QAAgB,EAAE,WAAyC,EAAE;QACxE,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC3B,MAAM,IAAI,+BAAa,CACnB,sCAAsC,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,MAAM;gBAC/E,uCAAuC,CAC1C,CAAC;QACN,CAAC;QAED,MAAM,GAAG,GAAG,IAAI,CAAC,eAAe,CAAC,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,MAAM,CAAC,EAAE,QAAQ,CAAC,CAAC;QAC9E,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,GAAG,KAAK,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC;YAChE,MAAM,IAAI,+BAAa,CAAC,yCAAyC,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;QAC5G,CAAC;QAED,MAAM,MAAM,GAAa,EAAE,CAAC;QAE5B,MAAM,SAAS,GAAG,GAAG,CAAC,WAAW,CAAC,CAAC;QACnC,IAAI,OAAO,SAAS,KAAK,QAAQ,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,SAAS,GAAG,CAAC,IAAI,SAAS,GAAG,GAAG,EAAE,CAAC;YACnG,MAAM,CAAC,IAAI,CAAC,2CAA2C,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC;QACzF,CAAC;QAED,MAAM,SAAS,GAAG,GAAG,CAAC,WAAW,CAAC,CAAC;QACnC,IAAI,OAAO,SAAS,KAAK,QAAQ,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC,SAAuC,CAAC,EAAE,CAAC;YAClG,MAAM,CAAC,IAAI,CAAC,+BAA+B,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAC1E,CAAC;QAED,MAAM,KAAK,GAAG,OAAO,GAAG,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,OAAO,CAAY,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QACtF,IAAI,KAAK,KAAK,EAAE,EAAE,CAAC;YACf,MAAM,CAAC,IAAI,CAAC,2FAA2F,CAAC,CAAC;QAC7G,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,CAAC,oBAAoB,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;QAC9D,KAAK,MAAM,GAAG,IAAI,IAAI,CAAC,uBAAuB,CAAC,QAAQ,EAAE,OAAO,CAAC;YAAE,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAEpF,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACpB,MAAM,IAAI,+BAAa,CACnB,mBAAmB,MAAM,CAAC,MAAM,gEAAgE;gBAChG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;gBACxD,OAAO,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAC/C,CAAC;QACN,CAAC;QAED,MAAM,KAAK,GAAG,SAAmB,CAAC;QAClC,MAAM,KAAK,GAAG,OAAO,GAAG,CAAC,WAAW,CAAC,KAAK,QAAQ,IAAI,GAAG,CAAC,WAAW,CAAC,KAAK,EAAE;YACzE,CAAC,CAAE,GAAG,CAAC,WAAW,CAAY;YAC9B,CAAC,CAAC,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,IAAI,CAAC,CAAC;QACvC,MAAM,OAAO,GAAG,OAAO,GAAG,CAAC,SAAS,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,SAAS,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;QAErF,OAAO,IAAI,UAAU,CACjB,KAAK,EACL,SAAmB,EACnB,KAAK,EACL,KAAK,EACL,OAAO,EACP,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,EACrC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,EAChC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC,EACxC,OAAO,CACV,CAAC;IACN,CAAC;IAED;;;;;OAKG;IACH,iBAAiB,CAAC,QAAsC,EAAE,OAAmC;QACzF,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,GAAsB,EAAW,EAAE;YACvD,MAAM,MAAM,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC,MAAM,CAAC;YACxD,OAAO,MAAM,KAAK,eAAO,IAAI,MAAM,KAAK,qBAAa,CAAC;QAC1D,CAAC,CAAC,CAAC;IACP,CAAC;IAED,0GAA0G;IAC1G,wGAAwG;IACxG,qEAAqE;IACrE,oBAAoB,CAAC,kBAA0B,EAAE,QAAsC;QACnF,MAAM,OAAO,GAAsB,EAAE,CAAC;QACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;YACzB,MAAM,CAAC,GAAG,IAAI,CAAC,mBAAmB,CAAC,kBAAkB,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC;YAC/D,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC;gBAAE,SAAS;YAChC,MAAM,MAAM,GAAG,IAAI,CAAC,oBAAoB,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC;YACpD,IAAI,MAAM;gBAAE,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACrC,CAAC;QACD,OAAO,OAAO,CAAC;IACnB,CAAC;IAED,wGAAwG;IACxG,iDAAiD;IACjD,cAAc,CAAC,GAAsB,EAAE,OAAmC;QACtE,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAkB,EAAW,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,GAAG,CAAC,EAAE,CAAC,CAAC;QAC9E,IAAI,CAAC,MAAM;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,kBAAU,EAAE,EAAE,CAAC,CAAC;QACjE,IAAI,MAAM,CAAC,OAAO;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,eAAO,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC;QAChF,IAAI,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,qBAAa,EAAE,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,CAAC;QAC9G,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,eAAO,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC;IAChE,CAAC;IAED,wGAAwG;IACxG,yFAAyF;IACjF,uBAAuB,CAAC,QAAsC,EAAE,OAAmC;QACvG,MAAM,MAAM,GAAa,EAAE,CAAC;QAC5B,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;YACzB,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;YAClD,IAAI,OAAO,CAAC,MAAM,KAAK,eAAO,EAAE,CAAC;gBAC7B,MAAM,CAAC,IAAI,CACP,cAAc,GAAG,CAAC,EAAE,kCAAkC,GAAG,CAAC,QAAQ,kBAAkB;oBACpF,GAAG,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI;oBAClD,+DAA+D,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC,EAAE,CAAC,8CAA8C,CAC9I,CAAC;YACN,CAAC;iBAAM,IAAI,OAAO,CAAC,MAAM,KAAK,kBAAU,EAAE,CAAC;gBACvC,MAAM,GAAG,GAAG,GAAG,CAAC,GAAG,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,UAAU,GAAG,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;gBAC9D,MAAM,CAAC,IAAI,CACP,cAAc,GAAG,CAAC,EAAE,sDAAsD,GAAG,CAAC,QAAQ,2BAA2B;oBACjH,cAAc,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC,EAAE,CAAC,gBAAgB,GAAG,CAAC,EAAE,kCAAkC,GAAG,EAAE,CAC5G,CAAC;YACN,CAAC;QACL,CAAC;QACD,OAAO,MAAM,CAAC;IAClB,CAAC;IAEO,iBAAiB,CAAC,WAAmB;QACzC,OAAO,UAAU,WAAW,OAAO,CAAC;IACxC,CAAC;IAED,+FAA+F;IAC/F,8EAA8E;IAC9E,kFAAkF;IAC1E,oBAAoB,CAAC,QAAgB,EAAE,EAAU;QACrD,gHAAgH;QAChH,8DAA8D;QAC9D,IAAI,CAAC;YACD,iFAAiF;YACjF,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,MAAM,CAAC,CAA4B,CAAC;YACrF,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,GAAG,KAAK,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;gBAAE,OAAO,IAAI,CAAC;YAC/E,MAAM,OAAO,GAAG,GAAG,CAAC,SAAS,CAAC,KAAK,IAAI,CAAC;YACxC,MAAM,MAAM,GAAG,OAAO,GAAG,CAAC,QAAQ,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,QAAQ,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YAClF,MAAM,QAAQ,GAAG,OAAO,GAAG,CAAC,UAAU,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,UAAU,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YACxF,OAAO,IAAI,eAAe,CAAC,EAAE,EAAE,OAAO,EAAE,MAAM,EAAE,QAAQ,CAAC,CAAC;QAC9D,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,kBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,KAAK,KAAK,CAAC;YACX,OAAO,IAAI,CAAC;QAChB,CAAC;IACL,CAAC;IAED,0FAA0F;IAClF,aAAa,CAAC,KAAc;QAChC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,kGAAkG;QAClG,OAAO,KAAK,CAAC,MAAM,CAAC,CAAC,CAAU,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC;IAC5E,CAAC;IAED,yFAAyF;IACzF,0GAA0G;IAClG,eAAe,CAAC,GAAW,EAAE,QAAgB;QACjD,yHAAyH;QACzH,8DAA8D;QAC9D,IAAI,CAAC;YACD,yFAAyF;YACzF,OAAO,IAAI,CAAC,KAAK,CAAC,GAAG,CAA4B,CAAC;QACtD,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,kBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,MAAM,IAAI,+BAAa,CACnB,kCAAkC,KAAK,CAAC,OAAO,SAAS,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,MAAM;gBACjG,uCAAuC,CAC1C,CAAC;QACN,CAAC;IACL,CAAC;CACJ,CAAA;AAxPY,8CAAiB;4BAAjB,iBAAiB;IAD7B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;GAC5B,iBAAiB,CAwP7B;AAED,0FAA0F;AAC1F,MAAM,aAAa,GAAG,IAAI,iBAAiB,EAAE,CAAC;AAE9C,wIAAwI;AACxI,SAAgB,QAAQ,CAAC,QAAgB,EAAE,WAAmB;IAC1D,OAAO,aAAa,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;AACzD,CAAC;AAED,wIAAwI;AACxI,SAAgB,cAAc,CAAC,QAAgB,EAAE,WAAmB;IAChE,OAAO,aAAa,CAAC,cAAc,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;AAC/D,CAAC;AAED,wIAAwI;AACxI,SAAgB,oBAAoB,CAAC,QAAgB;IACjD,OAAO,aAAa,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;AACxD,CAAC;AAED,wIAAwI;AACxI,SAAgB,cAAc,CAAC,QAAgB,EAAE,WAAyC,EAAE;IACxF,OAAO,aAAa,CAAC,cAAc,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;AAC5D,CAAC","sourcesContent":["import * as fs from 'fs';\nimport * as path from 'path';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { WEBPIECES_TMP_DIR, PR_REVIEW_DIR } from './constants';\nimport { InformAiError } from './inform-ai-error';\nimport { toError } from './to-error';\n\n// The verdict a reviewer SUBAGENT writes into `.webpieces/pr-review/<branch>/review-<id>.json`, one per\n// matched checklist. One file per checklist so N concurrent reviewer subagents never clobber a shared\n// file. It records the OUTCOME:\n//   success:true                       → PASS\n//   success:false + override non-empty → OVERRIDDEN (pass; the free-text justification reaches the PR)\n//   success:false + no override        → FAIL (refuse; `output` is printed verbatim)\n// `override` is deliberately free text, not a boolean — it forces the ship-anyway decision to be stated\n// in words and surfaces it on the dashboard, where a human sees it. Data-only (per CLAUDE.md).\nexport class ChecklistResult {\n    id: string;\n    success: boolean;\n    output: string;   // what the reviewer found; printed verbatim when the checklist fails\n    override: string;  // '' = no override; non-empty = ship-anyway justification (renders 🟡 overridden)\n\n    constructor(id: string, success: boolean, output: string, override: string) {\n        this.id = id;\n        this.success = success;\n        this.output = output;\n        this.override = override;\n    }\n}\n\n// What the pr-gate command computed from the diff: a checklist this branch MATCHED (its patterns hit the\n// diff, so its reviewer subagent must run). Drives review-<id>.json enforcement, provenance, the schema\n// hint, and the dashboard. Data-only.\nexport class RequiredChecklist {\n    id: string;             // = subagent name; keys review-<id>.json\n    subagent: string;       // reviewer agent that must run (agentType the harness stamps)\n    doc: string;            // REPO-RELATIVE guidance doc the reviewer reads ('' → it just reads the diff)\n    matchedFiles: string[]; // the changed files that matched it (for the dashboard + hint)\n    // Which of the checklist's OWN globs actually fired. Printed so a reviewer can judge how coarse the\n    // match was — a precise `db/migrations/**` hit means something different from a blanket `**` — and the\n    // template tells reviewers that matching IS deliberately coarse. [] = no patterns (matches every PR).\n    matchedPatterns: string[];\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(id: string, subagent: string, doc: string, matchedFiles: string[], matchedPatterns: string[] = []) {\n        this.id = id;\n        this.subagent = subagent;\n        this.doc = doc;\n        this.matchedFiles = matchedFiles;\n        this.matchedPatterns = matchedPatterns;\n    }\n}\n\n/**\n * The per-PR facts every reviewer subagent needs GIVEN to it, alongside its own checklist: the exact base\n * sha the gate diffs against and the file holding the complete changed-file set. Both used to live only in\n * a doc the printed instruction told the AI to go read, one indirection away from the instruction to hand\n * them over — so the printed block could not stand on its own. Data-only; empty = omit those lines.\n */\nexport class ChecklistReviewContext {\n    baseSha: string;        // the 3-point merge-base sha; `git diff <baseSha> HEAD -- <file>`\n    prContextPath: string;  // path of pr-context.json — the AUTHORITATIVE full changed-file set\n\n    constructor(baseSha = '', prContextPath = '') {\n        this.baseSha = baseSha;\n        this.prContextPath = prContextPath;\n    }\n}\n\n// The AI-authored review for a PR. The AI writes review.json itself between `wp-start-upsert-pr` (which\n// prints the schema) and `wp-finish-upsert-pr` (which reads it); reviewer subagents write the per-checklist\n// review-<id>.json files. Data-only (per CLAUDE.md).\nexport class ReviewJson {\n    title: string; // human PR title describing the change; used as the `gh pr` title (empty → caller falls back)\n    riskScore: number; // 0–100, drives the risk bar\n    riskLevel: string; // 'green' | 'yellow' | 'red'\n    riskEmoji: string; // '🟢' | '🟡' | '🔴' — derived from riskLevel when omitted\n    summary: string; // rendered in the dashboard Summary section\n    violations: string[]; // pattern/architecture violations; length = the Pattern Violations count\n    risks: string[];\n    filesToReview: string[];\n    results: ChecklistResult[]; // resolved per-checklist verdicts (from review-<id>.json); [] when none\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(\n        title: string,\n        riskScore: number,\n        riskLevel: string,\n        riskEmoji: string,\n        summary: string,\n        violations: string[],\n        risks: string[],\n        filesToReview: string[],\n        results: ChecklistResult[] = [],\n    ) {\n        this.title = title;\n        this.riskScore = riskScore;\n        this.riskLevel = riskLevel;\n        this.riskEmoji = riskEmoji;\n        this.summary = summary;\n        this.violations = violations;\n        this.risks = risks;\n        this.filesToReview = filesToReview;\n        this.results = results;\n    }\n}\n\n// A checklist's resolved outcome, shared by review.json enforcement and the dashboard so both agree.\nexport const CK_PASS = 'pass';               // review-<id>.json success:true\nexport const CK_OVERRIDDEN = 'overridden';   // review-<id>.json success:false + non-empty override → 🟡\nexport const CK_FAIL = 'fail';               // review-<id>.json success:false + no override → refuse\nexport const CK_MISSING = 'missing';         // no review-<id>.json written → refuse\n\nexport class ChecklistVerdict {\n    id: string;\n    status: string; // one of CK_PASS | CK_OVERRIDDEN | CK_FAIL | CK_MISSING\n    detail: string; // reviewer output / override justification (for the dashboard + errors)\n\n    constructor(id: string, status: string, detail: string) {\n        this.id = id;\n        this.status = status;\n        this.detail = detail;\n    }\n}\n\n// The PR's diff context, written by wp-start-upsert-pr into `.webpieces/pr-review/<branch>/pr-context.json`\n// so a reviewer subagent knows the exact 3-point base the gate used and the full changed-file set — then\n// reads any file's actual diff with `git diff <base> HEAD -- <file>`. This is what lets a checklist match\n// coarsely by path (in the config) while the subagent makes the fine, content-level judgment. Data-only.\nexport class PrContext {\n    base: string;          // the 3-point merge-base sha the gate diffs against\n    head: string;          // HEAD sha\n    changedFiles: string[]; // every file changed base..head (NOT tsOnly — includes .sql/.gql/Dockerfile/…)\n\n    constructor(base: string, head: string, changedFiles: string[]) {\n        this.base = base;\n        this.head = head;\n        this.changedFiles = changedFiles;\n    }\n}\n\nconst RISK_LEVELS = ['green', 'yellow', 'red'] as const;\nconst EMOJI_FOR_LEVEL: Record<string, string> = { green: '🟢', yellow: '🟡', red: '🔴' };\n\n/** Locates + loads/validates the AI-authored review.json. `@injectable(bindingScopeValues.Singleton)` so it's drawn in the design. */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewJsonService {\n    // The per-feature PR working dir: `.webpieces/pr-review/<feature>`.\n    prDirFor(repoRoot: string, featureName: string): string {\n        return path.join(repoRoot, WEBPIECES_TMP_DIR, PR_REVIEW_DIR, featureName);\n    }\n\n    // Absolute path of the review.json for a feature — beside pr-body.md, keyed by branch name.\n    reviewJsonPath(repoRoot: string, featureName: string): string {\n        return path.join(this.prDirFor(repoRoot, featureName), 'review.json');\n    }\n\n    // Absolute path of the pr-context.json for a feature (the diff base/head + changed files).\n    prContextPath(repoRoot: string, featureName: string): string {\n        return path.join(this.prDirFor(repoRoot, featureName), 'pr-context.json');\n    }\n\n    // Persist the PR's diff context so reviewer subagents can read the changed-file set + the exact base\n    // sha (then `git diff <base> HEAD -- <file>` for content). Returns the file path written.\n    writePrContext(repoRoot: string, featureName: string, context: PrContext): string {\n        const dir = this.prDirFor(repoRoot, featureName);\n        fs.mkdirSync(dir, { recursive: true });\n        const p = this.prContextPath(repoRoot, featureName);\n        fs.writeFileSync(p, JSON.stringify(context, null, 2) + '\\n');\n        return p;\n    }\n\n    /**\n     * The review context for a feature, recovered from the pr-context.json wp-start-upsert-pr already wrote.\n     * Lets wp-finish-upsert-pr's \"you still owe me review-<id>.json\" message inline the SAME self-sufficient\n     * per-reviewer block start printed, instead of a checklist name and an indirection. Empty when the file\n     * is absent or unreadable — the block then just omits those lines.\n     */\n    reviewContextFor(repoRoot: string, featureName: string): ChecklistReviewContext {\n        const p = this.prContextPath(repoRoot, featureName);\n        if (!fs.existsSync(p)) return new ChecklistReviewContext();\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: an unreadable context file degrades to fewer printed lines, never a crash\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            // webpieces-disable no-any-unknown -- parsed JSON is opaque until narrowed on the next line\n            const raw = JSON.parse(fs.readFileSync(p, 'utf8')) as Record<string, unknown>;\n            const base = typeof raw['base'] === 'string' ? (raw['base'] as string) : '';\n            return new ChecklistReviewContext(base, p);\n        } catch (err: unknown) {\n            const error = toError(err);\n            void error;\n            return new ChecklistReviewContext('', p);\n        }\n    }\n\n    // Copy-paste schema both commands print. `required` is the set of checklists the diff MATCHED; empty\n    // ⇒ output identical to a repo with no checklists. Non-empty ⇒ appends per-checklist instructions\n    // naming the reviewer subagent + doc + the review-<id>.json to write.\n    reviewJsonSchemaHint(filePath: string): string {\n        return (\n            `Write your PR review to:\\n  ${filePath}\\n\\n` +\n            `with this exact JSON shape (riskEmoji optional — derived from riskLevel):\\n\\n` +\n            `{\\n` +\n            `  \"title\": \"concise PR title describing the change (imperative, no branch names)\",\\n` +\n            `  \"riskScore\": 0,                       // integer 0–100 (higher = riskier)\\n` +\n            `  \"riskLevel\": \"green | yellow | red\",\\n` +\n            `  \"summary\": \"5–10 sentence review summary\",\\n` +\n            `  \"violations\": [\"pattern/architecture violations you found (empty array if none)\"],\\n` +\n            `  \"risks\": [\"notable risks (empty array if none)\"],\\n` +\n            `  \"filesToReview\": [\"paths a human should look at (empty array if none)\"]\\n` +\n            `}`\n        );\n    }\n\n    // The per-checklist review file path that sits beside review.json: review-<id>.json.\n    checklistResultPath(reviewJsonFilePath: string, checklistId: string): string {\n        return path.join(path.dirname(reviewJsonFilePath), `review-${checklistId}.json`);\n    }\n\n    /**\n     * Load + validate the AI-authored review.json. Throws InformAiError (with the schema) when missing,\n     * unparseable, or structurally wrong. `required` is the set of checklists the diff matched: every one\n     * must have a well-formed, passing (or overridden) review-<id>.json or a validation error is raised\n     * alongside the usual ones so the AI gets ONE message.\n     */\n    // webpieces-disable max-lines-new-methods -- one cohesive load+validate pass over the review fields\n    loadReviewJson(filePath: string, required: readonly RequiredChecklist[] = []): ReviewJson {\n        if (!fs.existsSync(filePath)) {\n            throw new InformAiError(\n                `Required review.json not found.\\n\\n${this.reviewJsonSchemaHint(filePath)}\\n\\n` +\n                `Then re-run: pnpm wp-finish-upsert-pr`,\n            );\n        }\n\n        const raw = this.parseReviewJson(fs.readFileSync(filePath, 'utf8'), filePath);\n        if (typeof raw !== 'object' || raw === null || Array.isArray(raw)) {\n            throw new InformAiError(`review.json must be a JSON object.\\n\\n${this.reviewJsonSchemaHint(filePath)}`);\n        }\n\n        const errors: string[] = [];\n\n        const riskScore = raw['riskScore'];\n        if (typeof riskScore !== 'number' || !Number.isFinite(riskScore) || riskScore < 0 || riskScore > 100) {\n            errors.push(`\"riskScore\" must be a number 0–100, got ${JSON.stringify(riskScore)}.`);\n        }\n\n        const riskLevel = raw['riskLevel'];\n        if (typeof riskLevel !== 'string' || !RISK_LEVELS.includes(riskLevel as typeof RISK_LEVELS[number])) {\n            errors.push(`\"riskLevel\" must be one of: ${RISK_LEVELS.join(', ')}.`);\n        }\n\n        const title = typeof raw['title'] === 'string' ? (raw['title'] as string).trim() : '';\n        if (title === '') {\n            errors.push('\"title\" must be a non-empty, imperative PR title describing the change (no branch names).');\n        }\n\n        const results = this.loadChecklistResults(filePath, required);\n        for (const err of this.requiredChecklistErrors(required, results)) errors.push(err);\n\n        if (errors.length > 0) {\n            throw new InformAiError(\n                `review.json has ${errors.length} error(s) — fix ALL, then re-run pnpm wp-finish-upsert-pr:\\n\\n` +\n                errors.map((e: string): string => `  • ${e}`).join('\\n') +\n                `\\n\\n${this.reviewJsonSchemaHint(filePath)}`,\n            );\n        }\n\n        const level = riskLevel as string;\n        const emoji = typeof raw['riskEmoji'] === 'string' && raw['riskEmoji'] !== ''\n            ? (raw['riskEmoji'] as string)\n            : (EMOJI_FOR_LEVEL[level] ?? '🟡');\n        const summary = typeof raw['summary'] === 'string' ? (raw['summary'] as string) : '';\n\n        return new ReviewJson(\n            title,\n            riskScore as number,\n            level,\n            emoji,\n            summary,\n            this.asStringArray(raw['violations']),\n            this.asStringArray(raw['risks']),\n            this.asStringArray(raw['filesToReview']),\n            results,\n        );\n    }\n\n    /**\n     * The checklists that still OWE a verdict: no review-<id>.json at all, a malformed one, or one whose\n     * verdict is an un-overridden FAIL. This is the set every message lists — a checklist already PASSed or\n     * OVERRIDDEN on this branch is deliberately NOT re-listed, because re-instructing it invites a redundant\n     * second run and reads as though the earlier verdict did not count.\n     */\n    pendingChecklists(required: readonly RequiredChecklist[], results: readonly ChecklistResult[]): RequiredChecklist[] {\n        return required.filter((req: RequiredChecklist): boolean => {\n            const status = this.resolveVerdict(req, results).status;\n            return status !== CK_PASS && status !== CK_OVERRIDDEN;\n        });\n    }\n\n    // Read the per-checklist verdict files `review-<id>.json` beside review.json — one per matched checklist.\n    // A missing file is simply absent from the result (→ counts as MISSING for that checklist); a malformed\n    // one is skipped (a stale review-<id>.json never wedges the branch).\n    loadChecklistResults(reviewJsonFilePath: string, required: readonly RequiredChecklist[]): ChecklistResult[] {\n        const results: ChecklistResult[] = [];\n        for (const req of required) {\n            const p = this.checklistResultPath(reviewJsonFilePath, req.id);\n            if (!fs.existsSync(p)) continue;\n            const parsed = this.parseChecklistResult(p, req.id);\n            if (parsed) results.push(parsed);\n        }\n        return results;\n    }\n\n    // Resolve ONE checklist's verdict from its review-<id>.json. Central so review.json enforcement AND the\n    // finish-command dashboard agree on the outcome.\n    resolveVerdict(req: RequiredChecklist, results: readonly ChecklistResult[]): ChecklistVerdict {\n        const result = results.find((r: ChecklistResult): boolean => r.id === req.id);\n        if (!result) return new ChecklistVerdict(req.id, CK_MISSING, '');\n        if (result.success) return new ChecklistVerdict(req.id, CK_PASS, result.output);\n        if (result.override.trim() !== '') return new ChecklistVerdict(req.id, CK_OVERRIDDEN, result.override.trim());\n        return new ChecklistVerdict(req.id, CK_FAIL, result.output);\n    }\n\n    // Every matched checklist whose verdict is FAIL (reviewed, found a problem, no override) or MISSING (no\n    // review-<id>.json written) → one error each, printing the reviewer's `output` verbatim.\n    private requiredChecklistErrors(required: readonly RequiredChecklist[], results: readonly ChecklistResult[]): string[] {\n        const errors: string[] = [];\n        for (const req of required) {\n            const verdict = this.resolveVerdict(req, results);\n            if (verdict.status === CK_FAIL) {\n                errors.push(\n                    `Checklist \"${req.id}\" FAILED review. The reviewer (${req.subagent}) wrote:\\n      ` +\n                    `${verdict.detail.split('\\n').join('\\n      ')}\\n` +\n                    `      Fix it, then re-run; or set a non-empty \"override\" in ${this.checklistFileName(req.id)} to ship anyway with a stated justification.`,\n                );\n            } else if (verdict.status === CK_MISSING) {\n                const doc = req.doc.trim() !== '' ? ` Read: ${req.doc}.` : '';\n                errors.push(\n                    `Checklist \"${req.id}\" MATCHED this diff but has no verdict. Spawn the \"${req.subagent}\" subagent to review it, ` +\n                    `then write ${this.checklistFileName(req.id)} with {\"id\":\"${req.id}\",\"success\":true,\"output\":\"…\"}.${doc}`,\n                );\n            }\n        }\n        return errors;\n    }\n\n    private checklistFileName(checklistId: string): string {\n        return `review-${checklistId}.json`;\n    }\n\n    // Parse one review-<id>.json into a ChecklistResult, or null when malformed. Tolerant: missing\n    // `success` counts as false (fail-closed), `output`/`override` default to ''.\n    // webpieces-disable no-any-unknown -- opaque parsed JSON, narrowed field-by-field\n    private parseChecklistResult(filePath: string, id: string): ChecklistResult | null {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: a malformed per-checklist file is skipped, not fatal\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            // webpieces-disable no-any-unknown -- parsed JSON is opaque until narrowed below\n            const raw = JSON.parse(fs.readFileSync(filePath, 'utf8')) as Record<string, unknown>;\n            if (typeof raw !== 'object' || raw === null || Array.isArray(raw)) return null;\n            const success = raw['success'] === true;\n            const output = typeof raw['output'] === 'string' ? (raw['output'] as string) : '';\n            const override = typeof raw['override'] === 'string' ? (raw['override'] as string) : '';\n            return new ChecklistResult(id, success, output, override);\n        } catch (err: unknown) {\n            const error = toError(err);\n            void error;\n            return null;\n        }\n    }\n\n    // webpieces-disable no-any-unknown -- opaque parsed JSON value, narrowed to string[] here\n    private asStringArray(value: unknown): string[] {\n        if (!Array.isArray(value)) return [];\n        // webpieces-disable no-any-unknown -- element of an opaque JSON array, narrowed by the type guard\n        return value.filter((v: unknown): v is string => typeof v === 'string');\n    }\n\n    // Parse opaque AI-authored JSON, converting a SyntaxError into a readable InformAiError.\n    // webpieces-disable no-any-unknown -- returns the opaque parsed object; loadReviewJson narrows each field\n    private parseReviewJson(raw: string, filePath: string): Record<string, unknown> {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: convert JSON.parse SyntaxError to an InformAiError for the AI\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            // webpieces-disable no-any-unknown -- parsed JSON is opaque until narrowed by the caller\n            return JSON.parse(raw) as Record<string, unknown>;\n        } catch (err: unknown) {\n            const error = toError(err);\n            throw new InformAiError(\n                `review.json is not valid JSON (${error.message}).\\n\\n${this.reviewJsonSchemaHint(filePath)}\\n\\n` +\n                `Then re-run: pnpm wp-finish-upsert-pr`,\n            );\n        }\n    }\n}\n\n// Temporary migration delegators to ReviewJsonService — removed once consumers inject it.\nconst reviewJsonSvc = new ReviewJsonService();\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function prDirFor(repoRoot: string, featureName: string): string {\n    return reviewJsonSvc.prDirFor(repoRoot, featureName);\n}\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function reviewJsonPath(repoRoot: string, featureName: string): string {\n    return reviewJsonSvc.reviewJsonPath(repoRoot, featureName);\n}\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function reviewJsonSchemaHint(filePath: string): string {\n    return reviewJsonSvc.reviewJsonSchemaHint(filePath);\n}\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function loadReviewJson(filePath: string, required: readonly RequiredChecklist[] = []): ReviewJson {\n    return reviewJsonSvc.loadReviewJson(filePath, required);\n}\n"]}
+{"version":3,"file":"review-json.js","sourceRoot":"","sources":["../../../../../packages/tooling/rules-config/src/review-json.ts"],"names":[],"mappings":";;;AA6dA,4BAEC;AAGD,wCAEC;AAGD,oDAEC;AAGD,wCAEC;;AA9eD,+CAAyB;AACzB,mDAA6B;AAC7B,yCAA2D;AAC3D,2CAA+D;AAC/D,uDAAkD;AAClD,yCAAqC;AAErC,qGAAqG;AACrG,yGAAyG;AACzG,0GAA0G;AAC1G,4EAA4E;AAC/D,QAAA,aAAa,GAAG,OAAO,CAAC;AACxB,QAAA,cAAc,GAAG,QAAQ,CAAC;AAC1B,QAAA,WAAW,GAAG,KAAK,CAAC;AACpB,QAAA,gBAAgB,GAAG,CAAC,qBAAa,EAAE,sBAAc,EAAE,mBAAW,CAAU,CAAC;AAEtF,wGAAwG;AACxG,sGAAsG;AACtG,gCAAgC;AAChC,2CAA2C;AAC3C,4GAA4G;AAC5G,sGAAsG;AACtG,kFAAkF;AAClF,wGAAwG;AACxG,+FAA+F;AAC/F,MAAa,eAAe;IACxB,EAAE,CAAS;IACX,MAAM,CAAS,CAAI,mEAAmE;IACtF,MAAM,CAAS,CAAI,qEAAqE;IACxF,QAAQ,CAAS,CAAE,kFAAkF;IACrG,oGAAoG;IACpG,qGAAqG;IACrG,sGAAsG;IACtG,4DAA4D;IAC5D,OAAO,CAAS;IAEhB,yDAAyD;IACzD,YAAY,EAAU,EAAE,MAAc,EAAE,MAAc,EAAE,QAAgB,EAAE,OAAO,GAAG,EAAE;QAClF,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC;QACb,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;IAC3B,CAAC;CACJ;AAnBD,0CAmBC;AAED,yGAAyG;AACzG,wGAAwG;AACxG,sCAAsC;AACtC,MAAa,iBAAiB;IAC1B,EAAE,CAAS,CAAa,yCAAyC;IACjE,QAAQ,CAAS,CAAO,8DAA8D;IACtF,GAAG,CAAS,CAAY,8EAA8E;IACtG,YAAY,CAAW,CAAC,+DAA+D;IACvF,oGAAoG;IACpG,uGAAuG;IACvG,sGAAsG;IACtG,eAAe,CAAW;IAE1B,yDAAyD;IACzD,YAAY,EAAU,EAAE,QAAgB,EAAE,GAAW,EAAE,YAAsB,EAAE,kBAA4B,EAAE;QACzG,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC;QACb,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,GAAG,GAAG,GAAG,CAAC;QACf,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;QACjC,IAAI,CAAC,eAAe,GAAG,eAAe,CAAC;IAC3C,CAAC;CACJ;AAlBD,8CAkBC;AAED;;;;;GAKG;AACH,MAAa,sBAAsB;IAC/B,OAAO,CAAS,CAAQ,kEAAkE;IAC1F,aAAa,CAAS,CAAE,oEAAoE;IAE5F,YAAY,OAAO,GAAG,EAAE,EAAE,aAAa,GAAG,EAAE;QACxC,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;QACvB,IAAI,CAAC,aAAa,GAAG,aAAa,CAAC;IACvC,CAAC;CACJ;AARD,wDAQC;AAED,wGAAwG;AACxG,4GAA4G;AAC5G,qDAAqD;AACrD,MAAa,UAAU;IACnB,KAAK,CAAS,CAAC,8FAA8F;IAC7G,SAAS,CAAS,CAAC,6BAA6B;IAChD,SAAS,CAAS,CAAC,6BAA6B;IAChD,SAAS,CAAS,CAAC,2DAA2D;IAC9E,OAAO,CAAS,CAAC,4CAA4C;IAC7D,UAAU,CAAW,CAAC,yEAAyE;IAC/F,KAAK,CAAW;IAChB,aAAa,CAAW;IACxB,OAAO,CAAoB,CAAC,wEAAwE;IAEpG,yDAAyD;IACzD,YACI,KAAa,EACb,SAAiB,EACjB,SAAiB,EACjB,SAAiB,EACjB,OAAe,EACf,UAAoB,EACpB,KAAe,EACf,aAAuB,EACvB,UAA6B,EAAE;QAE/B,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;QACvB,IAAI,CAAC,UAAU,GAAG,UAAU,CAAC;QAC7B,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,aAAa,GAAG,aAAa,CAAC;QACnC,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;IAC3B,CAAC;CACJ;AAjCD,gCAiCC;AAED,qGAAqG;AACrG,sFAAsF;AACzE,QAAA,OAAO,GAAG,MAAM,CAAC,CAAe,kCAAkC;AAClE,QAAA,OAAO,GAAG,MAAM,CAAC,CAAe,6DAA6D;AAC7F,QAAA,aAAa,GAAG,YAAY,CAAC,CAAG,0DAA0D;AAC1F,QAAA,OAAO,GAAG,MAAM,CAAC,CAAe,uDAAuD;AACvF,QAAA,UAAU,GAAG,SAAS,CAAC,CAAS,uCAAuC;AACvE,QAAA,aAAa,GAAG,YAAY,CAAC,CAAG,iEAAiE;AAE9G,MAAa,gBAAgB;IACzB,EAAE,CAAS;IACX,MAAM,CAAS,CAAC,kFAAkF;IAClG,MAAM,CAAS,CAAC,mFAAmF;IAEnG,YAAY,EAAU,EAAE,MAAc,EAAE,MAAc;QAClD,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC;QACb,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;IACzB,CAAC;CACJ;AAVD,4CAUC;AAED,4GAA4G;AAC5G,yGAAyG;AACzG,0GAA0G;AAC1G,yGAAyG;AACzG,MAAa,SAAS;IAClB,IAAI,CAAS,CAAU,oDAAoD;IAC3E,IAAI,CAAS,CAAU,WAAW;IAClC,YAAY,CAAW,CAAC,+EAA+E;IAEvG,YAAY,IAAY,EAAE,IAAY,EAAE,YAAsB;QAC1D,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;IACrC,CAAC;CACJ;AAVD,8BAUC;AAED,MAAM,WAAW,GAAG,CAAC,OAAO,EAAE,QAAQ,EAAE,KAAK,CAAU,CAAC;AACxD,MAAM,eAAe,GAA2B,EAAE,KAAK,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC;AAEzF,sIAAsI;AAE/H,IAAM,iBAAiB,GAAvB,MAAM,iBAAiB;IAC1B,oEAAoE;IACpE,QAAQ,CAAC,QAAgB,EAAE,WAAmB;QAC1C,OAAO,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,6BAAiB,EAAE,yBAAa,EAAE,WAAW,CAAC,CAAC;IAC9E,CAAC;IAED,4FAA4F;IAC5F,cAAc,CAAC,QAAgB,EAAE,WAAmB;QAChD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,aAAa,CAAC,CAAC;IAC1E,CAAC;IAED,2FAA2F;IAC3F,aAAa,CAAC,QAAgB,EAAE,WAAmB;QAC/C,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,iBAAiB,CAAC,CAAC;IAC9E,CAAC;IAED,qGAAqG;IACrG,0FAA0F;IAC1F,cAAc,CAAC,QAAgB,EAAE,WAAmB,EAAE,OAAkB;QACpE,MAAM,GAAG,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACjD,EAAE,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACvC,MAAM,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACpD,EAAE,CAAC,aAAa,CAAC,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,GAAG,IAAI,CAAC,CAAC;QAC7D,OAAO,CAAC,CAAC;IACb,CAAC;IAED;;;;;OAKG;IACH,gBAAgB,CAAC,QAAgB,EAAE,WAAmB;QAClD,MAAM,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACpD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC;YAAE,OAAO,IAAI,sBAAsB,EAAE,CAAC;QAC3D,qIAAqI;QACrI,8DAA8D;QAC9D,IAAI,CAAC;YACD,4FAA4F;YAC5F,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,YAAY,CAAC,CAAC,EAAE,MAAM,CAAC,CAA4B,CAAC;YAC9E,MAAM,IAAI,GAAG,OAAO,GAAG,CAAC,MAAM,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,MAAM,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5E,OAAO,IAAI,sBAAsB,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAC/C,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,kBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,KAAK,KAAK,CAAC;YACX,OAAO,IAAI,sBAAsB,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC;QAC7C,CAAC;IACL,CAAC;IAED,qGAAqG;IACrG,kGAAkG;IAClG,sEAAsE;IACtE,oBAAoB,CAAC,QAAgB;QACjC,OAAO,CACH,+BAA+B,QAAQ,MAAM;YAC7C,+EAA+E;YAC/E,KAAK;YACL,sFAAsF;YACtF,+EAA+E;YAC/E,0CAA0C;YAC1C,gDAAgD;YAChD,wFAAwF;YACxF,uDAAuD;YACvD,6EAA6E;YAC7E,GAAG,CACN,CAAC;IACN,CAAC;IAED,qFAAqF;IACrF,mBAAmB,CAAC,kBAA0B,EAAE,WAAmB;QAC/D,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,kBAAkB,CAAC,EAAE,UAAU,WAAW,OAAO,CAAC,CAAC;IACrF,CAAC;IAED;;;;;OAKG;IACH,oGAAoG;IACpG,cAAc,CAAC,QAAgB,EAAE,WAAyC,EAAE;QACxE,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC3B,MAAM,IAAI,+BAAa,CACnB,sCAAsC,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,MAAM;gBAC/E,uCAAuC,CAC1C,CAAC;QACN,CAAC;QAED,MAAM,GAAG,GAAG,IAAI,CAAC,eAAe,CAAC,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,MAAM,CAAC,EAAE,QAAQ,CAAC,CAAC;QAC9E,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,GAAG,KAAK,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC;YAChE,MAAM,IAAI,+BAAa,CAAC,yCAAyC,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;QAC5G,CAAC;QAED,MAAM,MAAM,GAAa,EAAE,CAAC;QAE5B,MAAM,SAAS,GAAG,GAAG,CAAC,WAAW,CAAC,CAAC;QACnC,IAAI,OAAO,SAAS,KAAK,QAAQ,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,SAAS,GAAG,CAAC,IAAI,SAAS,GAAG,GAAG,EAAE,CAAC;YACnG,MAAM,CAAC,IAAI,CAAC,2CAA2C,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC;QACzF,CAAC;QAED,MAAM,SAAS,GAAG,GAAG,CAAC,WAAW,CAAC,CAAC;QACnC,IAAI,OAAO,SAAS,KAAK,QAAQ,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC,SAAuC,CAAC,EAAE,CAAC;YAClG,MAAM,CAAC,IAAI,CAAC,+BAA+B,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAC1E,CAAC;QAED,MAAM,KAAK,GAAG,OAAO,GAAG,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,OAAO,CAAY,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QACtF,IAAI,KAAK,KAAK,EAAE,EAAE,CAAC;YACf,MAAM,CAAC,IAAI,CAAC,2FAA2F,CAAC,CAAC;QAC7G,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,CAAC,oBAAoB,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;QAC9D,KAAK,MAAM,GAAG,IAAI,IAAI,CAAC,uBAAuB,CAAC,QAAQ,EAAE,OAAO,CAAC;YAAE,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAEpF,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACpB,MAAM,IAAI,+BAAa,CACnB,mBAAmB,MAAM,CAAC,MAAM,gEAAgE;gBAChG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;gBACxD,OAAO,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAC/C,CAAC;QACN,CAAC;QAED,MAAM,KAAK,GAAG,SAAmB,CAAC;QAClC,MAAM,KAAK,GAAG,OAAO,GAAG,CAAC,WAAW,CAAC,KAAK,QAAQ,IAAI,GAAG,CAAC,WAAW,CAAC,KAAK,EAAE;YACzE,CAAC,CAAE,GAAG,CAAC,WAAW,CAAY;YAC9B,CAAC,CAAC,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,IAAI,CAAC,CAAC;QACvC,MAAM,OAAO,GAAG,OAAO,GAAG,CAAC,SAAS,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,SAAS,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;QAErF,OAAO,IAAI,UAAU,CACjB,KAAK,EACL,SAAmB,EACnB,KAAK,EACL,KAAK,EACL,OAAO,EACP,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,EACrC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,EAChC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC,EACxC,OAAO,CACV,CAAC;IACN,CAAC;IAED;;;;;OAKG;IACH,iBAAiB,CAAC,QAAsC,EAAE,OAAmC;QACzF,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,GAAsB,EAAW,EAAE;YACvD,MAAM,MAAM,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC,MAAM,CAAC;YACxD,8FAA8F;YAC9F,8FAA8F;YAC9F,0DAA0D;YAC1D,OAAO,MAAM,KAAK,eAAO,IAAI,MAAM,KAAK,eAAO,IAAI,MAAM,KAAK,qBAAa,CAAC;QAChF,CAAC,CAAC,CAAC;IACP,CAAC;IAED,0GAA0G;IAC1G,wGAAwG;IACxG,qEAAqE;IACrE,oBAAoB,CAAC,kBAA0B,EAAE,QAAsC;QACnF,MAAM,OAAO,GAAsB,EAAE,CAAC;QACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;YACzB,MAAM,CAAC,GAAG,IAAI,CAAC,mBAAmB,CAAC,kBAAkB,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC;YAC/D,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC;gBAAE,SAAS;YAChC,MAAM,MAAM,GAAG,IAAI,CAAC,oBAAoB,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC;YACpD,IAAI,MAAM;gBAAE,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACrC,CAAC;QACD,OAAO,OAAO,CAAC;IACnB,CAAC;IAED,wGAAwG;IACxG,yGAAyG;IACzG,yDAAyD;IACzD,cAAc,CAAC,GAAsB,EAAE,OAAmC;QACtE,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAkB,EAAW,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,GAAG,CAAC,EAAE,CAAC,CAAC;QAC9E,IAAI,CAAC,MAAM;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,kBAAU,EAAE,EAAE,CAAC,CAAC;QACjE,IAAI,MAAM,CAAC,OAAO,KAAK,EAAE;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,qBAAa,EAAE,MAAM,CAAC,OAAO,CAAC,CAAC;QAC9F,IAAI,MAAM,CAAC,MAAM,KAAK,qBAAa;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,eAAO,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC;QACjG,IAAI,MAAM,CAAC,MAAM,KAAK,sBAAc;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,eAAO,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC;QAClG,IAAI,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,qBAAa,EAAE,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,CAAC;QAC9G,OAAO,IAAI,gBAAgB,CAAC,GAAG,CAAC,EAAE,EAAE,eAAO,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC;IAChE,CAAC;IAED;;;;;;OAMG;IACH,qBAAqB,CAAC,QAAsC,EAAE,OAAmC;QAC7F,MAAM,MAAM,GAAa,EAAE,CAAC;QAC5B,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;YACzB,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;YAClD,IAAI,OAAO,CAAC,MAAM,KAAK,qBAAa;gBAAE,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;QACtE,CAAC;QACD,OAAO,MAAM,CAAC;IAClB,CAAC;IAED,wGAAwG;IACxG,yFAAyF;IACjF,uBAAuB,CAAC,QAAsC,EAAE,OAAmC;QACvG,qGAAqG;QACrG,MAAM,MAAM,GAAa,IAAI,CAAC,qBAAqB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QACvE,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;YACzB,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;YAClD,8FAA8F;YAC9F,2FAA2F;YAC3F,IAAI,OAAO,CAAC,MAAM,KAAK,eAAO,EAAE,CAAC;gBAC7B,MAAM,CAAC,IAAI,CACP,cAAc,GAAG,CAAC,EAAE,4BAA4B,mBAAW,qBAAqB,GAAG,CAAC,QAAQ,kBAAkB;oBAC9G,GAAG,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI;oBAClD,+DAA+D,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC,EAAE,CAAC,8CAA8C,CAC9I,CAAC;YACN,CAAC;iBAAM,IAAI,OAAO,CAAC,MAAM,KAAK,kBAAU,EAAE,CAAC;gBACvC,MAAM,GAAG,GAAG,GAAG,CAAC,GAAG,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,UAAU,GAAG,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;gBAC9D,MAAM,CAAC,IAAI,CACP,cAAc,GAAG,CAAC,EAAE,sDAAsD,GAAG,CAAC,QAAQ,2BAA2B;oBACjH,cAAc,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC,EAAE,CAAC,QAAQ;oBACpD,UAAU,GAAG,CAAC,EAAE,eAAe,qBAAa,iCAAiC,GAAG,EAAE,CACrF,CAAC;YACN,CAAC;QACL,CAAC;QACD,OAAO,MAAM,CAAC;IAClB,CAAC;IAEO,iBAAiB,CAAC,WAAmB;QACzC,OAAO,UAAU,WAAW,OAAO,CAAC;IACxC,CAAC;IAED;;;;;;;;OAQG;IACH,kFAAkF;IAC1E,oBAAoB,CAAC,QAAgB,EAAE,EAAU;QACrD,mHAAmH;QACnH,8DAA8D;QAC9D,IAAI,CAAC;YACD,iFAAiF;YACjF,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,MAAM,CAAC,CAA4B,CAAC;YACrF,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,GAAG,KAAK,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;gBAAE,OAAO,IAAI,CAAC;YAC/E,MAAM,MAAM,GAAG,OAAO,GAAG,CAAC,QAAQ,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,QAAQ,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YAClF,MAAM,QAAQ,GAAG,OAAO,GAAG,CAAC,UAAU,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,UAAU,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YACxF,MAAM,MAAM,GAAG,OAAO,GAAG,CAAC,QAAQ,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,GAAG,CAAC,QAAQ,CAAY,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YACvG,OAAO,IAAI,eAAe,CAAC,EAAE,EAAE,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC;QAC5G,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,kBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,KAAK,KAAK,CAAC;YACX,OAAO,IAAI,CAAC;QAChB,CAAC;IACL,CAAC;IAED;;;;;OAKG;IACH,4FAA4F;IACpF,aAAa,CAAC,QAAgB,EAAE,EAAU,EAAE,MAAc,EAAE,GAA4B;QAC5F,mGAAmG;QACnG,IAAK,wBAAsC,CAAC,QAAQ,CAAC,MAAM,CAAC;YAAE,OAAO,EAAE,CAAC;QACxE,MAAM,KAAK,GACP,kBAAkB,EAAE,iBAAiB,qBAAa,MAAM,sBAAc,MAAM,mBAAW,KAAK;YAC5F,0DAA0D;YAC1D,WAAW,qBAAa,cAAc;YACtC,WAAW,sBAAc,sFAAsF;YAC/G,WAAW,mBAAW,gGAAgG;YACtH,eAAe,QAAQ,EAAE,CAAC;QAC9B,IAAI,SAAS,IAAI,GAAG,EAAE,CAAC;YACnB,OAAO,cAAc,EAAE,8EAA8E;gBACjG,oEAAoE,KAAK,EAAE,CAAC;QACpF,CAAC;QACD,OAAO,cAAc,EAAE,iDAAiD,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,KAAK;YAC/F,6BAA6B,wBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,EAAE,CAAC;IAC9E,CAAC;IAED,0FAA0F;IAClF,aAAa,CAAC,KAAc;QAChC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,kGAAkG;QAClG,OAAO,KAAK,CAAC,MAAM,CAAC,CAAC,CAAU,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC;IAC5E,CAAC;IAED,yFAAyF;IACzF,0GAA0G;IAClG,eAAe,CAAC,GAAW,EAAE,QAAgB;QACjD,yHAAyH;QACzH,8DAA8D;QAC9D,IAAI,CAAC;YACD,yFAAyF;YACzF,OAAO,IAAI,CAAC,KAAK,CAAC,GAAG,CAA4B,CAAC;QACtD,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,kBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,MAAM,IAAI,+BAAa,CACnB,kCAAkC,KAAK,CAAC,OAAO,SAAS,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,MAAM;gBACjG,uCAAuC,CAC1C,CAAC;QACN,CAAC;IACL,CAAC;CACJ,CAAA;AAlTY,8CAAiB;4BAAjB,iBAAiB;IAD7B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;GAC5B,iBAAiB,CAkT7B;AAED,0FAA0F;AAC1F,MAAM,aAAa,GAAG,IAAI,iBAAiB,EAAE,CAAC;AAE9C,wIAAwI;AACxI,SAAgB,QAAQ,CAAC,QAAgB,EAAE,WAAmB;IAC1D,OAAO,aAAa,CAAC,QAAQ,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;AACzD,CAAC;AAED,wIAAwI;AACxI,SAAgB,cAAc,CAAC,QAAgB,EAAE,WAAmB;IAChE,OAAO,aAAa,CAAC,cAAc,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;AAC/D,CAAC;AAED,wIAAwI;AACxI,SAAgB,oBAAoB,CAAC,QAAgB;IACjD,OAAO,aAAa,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;AACxD,CAAC;AAED,wIAAwI;AACxI,SAAgB,cAAc,CAAC,QAAgB,EAAE,WAAyC,EAAE;IACxF,OAAO,aAAa,CAAC,cAAc,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;AAC5D,CAAC","sourcesContent":["import * as fs from 'fs';\nimport * as path from 'path';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { WEBPIECES_TMP_DIR, PR_REVIEW_DIR } from './constants';\nimport { InformAiError } from './inform-ai-error';\nimport { toError } from './to-error';\n\n// The three colors a reviewer subagent may report in `review-<id>.json`. A TRI-state, not a boolean,\n// because the boolean it replaced gave a reviewer no way to say \"this passes, but a human should look at\n// X\" — the only way to raise a concern was to FAIL the PR and then override your own failure, which reads\n// on the dashboard as a deliberately-accepted defect rather than as a note.\nexport const VERDICT_GREEN = 'green';\nexport const VERDICT_YELLOW = 'yellow';\nexport const VERDICT_RED = 'red';\nexport const VERDICT_STATUSES = [VERDICT_GREEN, VERDICT_YELLOW, VERDICT_RED] as const;\n\n// The verdict a reviewer SUBAGENT writes into `.webpieces/pr-review/<branch>/review-<id>.json`, one per\n// matched checklist. One file per checklist so N concurrent reviewer subagents never clobber a shared\n// file. It records the OUTCOME:\n//   status:'green'                  → PASS\n//   status:'yellow'                 → WARN (passes; the concern is published on the PR, nothing is blocked)\n//   status:'red' + override non-empty → OVERRIDDEN (pass; the free-text justification reaches the PR)\n//   status:'red' + no override      → FAIL (refuse; `output` is printed verbatim)\n// `override` is deliberately free text, not a boolean — it forces the ship-anyway decision to be stated\n// in words and surfaces it on the dashboard, where a human sees it. Data-only (per CLAUDE.md).\nexport class ChecklistResult {\n    id: string;\n    status: string;    // one of VERDICT_STATUSES; anything else is reported via `problem`\n    output: string;    // what the reviewer found; printed verbatim when the checklist fails\n    override: string;  // '' = no override; non-empty = ship-anyway justification (renders 🟠 overridden)\n    // '' = a well-formed verdict. Non-empty = the file exists and parses but its verdict cannot be READ\n    // (most often: it still uses the removed `success` field). Carried as data rather than thrown so the\n    // complaint can be reported by BOTH wp-checklist and wp-finish-upsert-pr in identical words, and so a\n    // legacy file is never silently mistaken for a missing one.\n    problem: string;\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(id: string, status: string, output: string, override: string, problem = '') {\n        this.id = id;\n        this.status = status;\n        this.output = output;\n        this.override = override;\n        this.problem = problem;\n    }\n}\n\n// What the pr-gate command computed from the diff: a checklist this branch MATCHED (its patterns hit the\n// diff, so its reviewer subagent must run). Drives review-<id>.json enforcement, provenance, the schema\n// hint, and the dashboard. Data-only.\nexport class RequiredChecklist {\n    id: string;             // = subagent name; keys review-<id>.json\n    subagent: string;       // reviewer agent that must run (agentType the harness stamps)\n    doc: string;            // REPO-RELATIVE guidance doc the reviewer reads ('' → it just reads the diff)\n    matchedFiles: string[]; // the changed files that matched it (for the dashboard + hint)\n    // Which of the checklist's OWN globs actually fired. Printed so a reviewer can judge how coarse the\n    // match was — a precise `db/migrations/**` hit means something different from a blanket `**` — and the\n    // template tells reviewers that matching IS deliberately coarse. [] = no patterns (matches every PR).\n    matchedPatterns: string[];\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(id: string, subagent: string, doc: string, matchedFiles: string[], matchedPatterns: string[] = []) {\n        this.id = id;\n        this.subagent = subagent;\n        this.doc = doc;\n        this.matchedFiles = matchedFiles;\n        this.matchedPatterns = matchedPatterns;\n    }\n}\n\n/**\n * The per-PR facts every reviewer subagent needs GIVEN to it, alongside its own checklist: the exact base\n * sha the gate diffs against and the file holding the complete changed-file set. Both used to live only in\n * a doc the printed instruction told the AI to go read, one indirection away from the instruction to hand\n * them over — so the printed block could not stand on its own. Data-only; empty = omit those lines.\n */\nexport class ChecklistReviewContext {\n    baseSha: string;        // the 3-point merge-base sha; `git diff <baseSha> HEAD -- <file>`\n    prContextPath: string;  // path of pr-context.json — the AUTHORITATIVE full changed-file set\n\n    constructor(baseSha = '', prContextPath = '') {\n        this.baseSha = baseSha;\n        this.prContextPath = prContextPath;\n    }\n}\n\n// The AI-authored review for a PR. The AI writes review.json itself between `wp-start-upsert-pr` (which\n// prints the schema) and `wp-finish-upsert-pr` (which reads it); reviewer subagents write the per-checklist\n// review-<id>.json files. Data-only (per CLAUDE.md).\nexport class ReviewJson {\n    title: string; // human PR title describing the change; used as the `gh pr` title (empty → caller falls back)\n    riskScore: number; // 0–100, drives the risk bar\n    riskLevel: string; // 'green' | 'yellow' | 'red'\n    riskEmoji: string; // '🟢' | '🟡' | '🔴' — derived from riskLevel when omitted\n    summary: string; // rendered in the dashboard Summary section\n    violations: string[]; // pattern/architecture violations; length = the Pattern Violations count\n    risks: string[];\n    filesToReview: string[];\n    results: ChecklistResult[]; // resolved per-checklist verdicts (from review-<id>.json); [] when none\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(\n        title: string,\n        riskScore: number,\n        riskLevel: string,\n        riskEmoji: string,\n        summary: string,\n        violations: string[],\n        risks: string[],\n        filesToReview: string[],\n        results: ChecklistResult[] = [],\n    ) {\n        this.title = title;\n        this.riskScore = riskScore;\n        this.riskLevel = riskLevel;\n        this.riskEmoji = riskEmoji;\n        this.summary = summary;\n        this.violations = violations;\n        this.risks = risks;\n        this.filesToReview = filesToReview;\n        this.results = results;\n    }\n}\n\n// A checklist's resolved outcome, shared by review.json enforcement and the dashboard so both agree.\n// PASS, WARN and OVERRIDDEN all ship; FAIL, MISSING and BAD_FORMAT all refuse the PR.\nexport const CK_PASS = 'pass';               // review-<id>.json status:'green'\nexport const CK_WARN = 'warn';               // review-<id>.json status:'yellow' → 🟡 passes WITH concerns\nexport const CK_OVERRIDDEN = 'overridden';   // review-<id>.json status:'red' + non-empty override → 🟠\nexport const CK_FAIL = 'fail';               // review-<id>.json status:'red' + no override → refuse\nexport const CK_MISSING = 'missing';         // no review-<id>.json written → refuse\nexport const CK_BAD_FORMAT = 'bad-format';   // written, but its verdict is unreadable (e.g. legacy `success`)\n\nexport class ChecklistVerdict {\n    id: string;\n    status: string; // one of CK_PASS | CK_WARN | CK_OVERRIDDEN | CK_FAIL | CK_MISSING | CK_BAD_FORMAT\n    detail: string; // reviewer output / override justification / format complaint (dashboard + errors)\n\n    constructor(id: string, status: string, detail: string) {\n        this.id = id;\n        this.status = status;\n        this.detail = detail;\n    }\n}\n\n// The PR's diff context, written by wp-start-upsert-pr into `.webpieces/pr-review/<branch>/pr-context.json`\n// so a reviewer subagent knows the exact 3-point base the gate used and the full changed-file set — then\n// reads any file's actual diff with `git diff <base> HEAD -- <file>`. This is what lets a checklist match\n// coarsely by path (in the config) while the subagent makes the fine, content-level judgment. Data-only.\nexport class PrContext {\n    base: string;          // the 3-point merge-base sha the gate diffs against\n    head: string;          // HEAD sha\n    changedFiles: string[]; // every file changed base..head (NOT tsOnly — includes .sql/.gql/Dockerfile/…)\n\n    constructor(base: string, head: string, changedFiles: string[]) {\n        this.base = base;\n        this.head = head;\n        this.changedFiles = changedFiles;\n    }\n}\n\nconst RISK_LEVELS = ['green', 'yellow', 'red'] as const;\nconst EMOJI_FOR_LEVEL: Record<string, string> = { green: '🟢', yellow: '🟡', red: '🔴' };\n\n/** Locates + loads/validates the AI-authored review.json. `@injectable(bindingScopeValues.Singleton)` so it's drawn in the design. */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewJsonService {\n    // The per-feature PR working dir: `.webpieces/pr-review/<feature>`.\n    prDirFor(repoRoot: string, featureName: string): string {\n        return path.join(repoRoot, WEBPIECES_TMP_DIR, PR_REVIEW_DIR, featureName);\n    }\n\n    // Absolute path of the review.json for a feature — beside pr-body.md, keyed by branch name.\n    reviewJsonPath(repoRoot: string, featureName: string): string {\n        return path.join(this.prDirFor(repoRoot, featureName), 'review.json');\n    }\n\n    // Absolute path of the pr-context.json for a feature (the diff base/head + changed files).\n    prContextPath(repoRoot: string, featureName: string): string {\n        return path.join(this.prDirFor(repoRoot, featureName), 'pr-context.json');\n    }\n\n    // Persist the PR's diff context so reviewer subagents can read the changed-file set + the exact base\n    // sha (then `git diff <base> HEAD -- <file>` for content). Returns the file path written.\n    writePrContext(repoRoot: string, featureName: string, context: PrContext): string {\n        const dir = this.prDirFor(repoRoot, featureName);\n        fs.mkdirSync(dir, { recursive: true });\n        const p = this.prContextPath(repoRoot, featureName);\n        fs.writeFileSync(p, JSON.stringify(context, null, 2) + '\\n');\n        return p;\n    }\n\n    /**\n     * The review context for a feature, recovered from the pr-context.json wp-start-upsert-pr already wrote.\n     * Lets wp-finish-upsert-pr's \"you still owe me review-<id>.json\" message inline the SAME self-sufficient\n     * per-reviewer block start printed, instead of a checklist name and an indirection. Empty when the file\n     * is absent or unreadable — the block then just omits those lines.\n     */\n    reviewContextFor(repoRoot: string, featureName: string): ChecklistReviewContext {\n        const p = this.prContextPath(repoRoot, featureName);\n        if (!fs.existsSync(p)) return new ChecklistReviewContext();\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: an unreadable context file degrades to fewer printed lines, never a crash\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            // webpieces-disable no-any-unknown -- parsed JSON is opaque until narrowed on the next line\n            const raw = JSON.parse(fs.readFileSync(p, 'utf8')) as Record<string, unknown>;\n            const base = typeof raw['base'] === 'string' ? (raw['base'] as string) : '';\n            return new ChecklistReviewContext(base, p);\n        } catch (err: unknown) {\n            const error = toError(err);\n            void error;\n            return new ChecklistReviewContext('', p);\n        }\n    }\n\n    // Copy-paste schema both commands print. `required` is the set of checklists the diff MATCHED; empty\n    // ⇒ output identical to a repo with no checklists. Non-empty ⇒ appends per-checklist instructions\n    // naming the reviewer subagent + doc + the review-<id>.json to write.\n    reviewJsonSchemaHint(filePath: string): string {\n        return (\n            `Write your PR review to:\\n  ${filePath}\\n\\n` +\n            `with this exact JSON shape (riskEmoji optional — derived from riskLevel):\\n\\n` +\n            `{\\n` +\n            `  \"title\": \"concise PR title describing the change (imperative, no branch names)\",\\n` +\n            `  \"riskScore\": 0,                       // integer 0–100 (higher = riskier)\\n` +\n            `  \"riskLevel\": \"green | yellow | red\",\\n` +\n            `  \"summary\": \"5–10 sentence review summary\",\\n` +\n            `  \"violations\": [\"pattern/architecture violations you found (empty array if none)\"],\\n` +\n            `  \"risks\": [\"notable risks (empty array if none)\"],\\n` +\n            `  \"filesToReview\": [\"paths a human should look at (empty array if none)\"]\\n` +\n            `}`\n        );\n    }\n\n    // The per-checklist review file path that sits beside review.json: review-<id>.json.\n    checklistResultPath(reviewJsonFilePath: string, checklistId: string): string {\n        return path.join(path.dirname(reviewJsonFilePath), `review-${checklistId}.json`);\n    }\n\n    /**\n     * Load + validate the AI-authored review.json. Throws InformAiError (with the schema) when missing,\n     * unparseable, or structurally wrong. `required` is the set of checklists the diff matched: every one\n     * must have a well-formed, passing (or overridden) review-<id>.json or a validation error is raised\n     * alongside the usual ones so the AI gets ONE message.\n     */\n    // webpieces-disable max-lines-new-methods -- one cohesive load+validate pass over the review fields\n    loadReviewJson(filePath: string, required: readonly RequiredChecklist[] = []): ReviewJson {\n        if (!fs.existsSync(filePath)) {\n            throw new InformAiError(\n                `Required review.json not found.\\n\\n${this.reviewJsonSchemaHint(filePath)}\\n\\n` +\n                `Then re-run: pnpm wp-finish-upsert-pr`,\n            );\n        }\n\n        const raw = this.parseReviewJson(fs.readFileSync(filePath, 'utf8'), filePath);\n        if (typeof raw !== 'object' || raw === null || Array.isArray(raw)) {\n            throw new InformAiError(`review.json must be a JSON object.\\n\\n${this.reviewJsonSchemaHint(filePath)}`);\n        }\n\n        const errors: string[] = [];\n\n        const riskScore = raw['riskScore'];\n        if (typeof riskScore !== 'number' || !Number.isFinite(riskScore) || riskScore < 0 || riskScore > 100) {\n            errors.push(`\"riskScore\" must be a number 0–100, got ${JSON.stringify(riskScore)}.`);\n        }\n\n        const riskLevel = raw['riskLevel'];\n        if (typeof riskLevel !== 'string' || !RISK_LEVELS.includes(riskLevel as typeof RISK_LEVELS[number])) {\n            errors.push(`\"riskLevel\" must be one of: ${RISK_LEVELS.join(', ')}.`);\n        }\n\n        const title = typeof raw['title'] === 'string' ? (raw['title'] as string).trim() : '';\n        if (title === '') {\n            errors.push('\"title\" must be a non-empty, imperative PR title describing the change (no branch names).');\n        }\n\n        const results = this.loadChecklistResults(filePath, required);\n        for (const err of this.requiredChecklistErrors(required, results)) errors.push(err);\n\n        if (errors.length > 0) {\n            throw new InformAiError(\n                `review.json has ${errors.length} error(s) — fix ALL, then re-run pnpm wp-finish-upsert-pr:\\n\\n` +\n                errors.map((e: string): string => `  • ${e}`).join('\\n') +\n                `\\n\\n${this.reviewJsonSchemaHint(filePath)}`,\n            );\n        }\n\n        const level = riskLevel as string;\n        const emoji = typeof raw['riskEmoji'] === 'string' && raw['riskEmoji'] !== ''\n            ? (raw['riskEmoji'] as string)\n            : (EMOJI_FOR_LEVEL[level] ?? '🟡');\n        const summary = typeof raw['summary'] === 'string' ? (raw['summary'] as string) : '';\n\n        return new ReviewJson(\n            title,\n            riskScore as number,\n            level,\n            emoji,\n            summary,\n            this.asStringArray(raw['violations']),\n            this.asStringArray(raw['risks']),\n            this.asStringArray(raw['filesToReview']),\n            results,\n        );\n    }\n\n    /**\n     * The checklists that still OWE a verdict: no review-<id>.json at all, a malformed one, or one whose\n     * verdict is an un-overridden FAIL. This is the set every message lists — a checklist already PASSed or\n     * OVERRIDDEN on this branch is deliberately NOT re-listed, because re-instructing it invites a redundant\n     * second run and reads as though the earlier verdict did not count.\n     */\n    pendingChecklists(required: readonly RequiredChecklist[], results: readonly ChecklistResult[]): RequiredChecklist[] {\n        return required.filter((req: RequiredChecklist): boolean => {\n            const status = this.resolveVerdict(req, results).status;\n            // CK_WARN must be listed here beside PASS/OVERRIDDEN. A yellow verdict SHIPS — leaving it out\n            // would mark the checklist owed forever, so `outstanding` never empties and the PR is refused\n            // permanently no matter how many times the reviewer runs.\n            return status !== CK_PASS && status !== CK_WARN && status !== CK_OVERRIDDEN;\n        });\n    }\n\n    // Read the per-checklist verdict files `review-<id>.json` beside review.json — one per matched checklist.\n    // A missing file is simply absent from the result (→ counts as MISSING for that checklist); a malformed\n    // one is skipped (a stale review-<id>.json never wedges the branch).\n    loadChecklistResults(reviewJsonFilePath: string, required: readonly RequiredChecklist[]): ChecklistResult[] {\n        const results: ChecklistResult[] = [];\n        for (const req of required) {\n            const p = this.checklistResultPath(reviewJsonFilePath, req.id);\n            if (!fs.existsSync(p)) continue;\n            const parsed = this.parseChecklistResult(p, req.id);\n            if (parsed) results.push(parsed);\n        }\n        return results;\n    }\n\n    // Resolve ONE checklist's verdict from its review-<id>.json. Central so review.json enforcement AND the\n    // finish-command dashboard agree on the outcome. `problem` is checked FIRST: a file whose verdict cannot\n    // be read must not fall through to any shipping outcome.\n    resolveVerdict(req: RequiredChecklist, results: readonly ChecklistResult[]): ChecklistVerdict {\n        const result = results.find((r: ChecklistResult): boolean => r.id === req.id);\n        if (!result) return new ChecklistVerdict(req.id, CK_MISSING, '');\n        if (result.problem !== '') return new ChecklistVerdict(req.id, CK_BAD_FORMAT, result.problem);\n        if (result.status === VERDICT_GREEN) return new ChecklistVerdict(req.id, CK_PASS, result.output);\n        if (result.status === VERDICT_YELLOW) return new ChecklistVerdict(req.id, CK_WARN, result.output);\n        if (result.override.trim() !== '') return new ChecklistVerdict(req.id, CK_OVERRIDDEN, result.override.trim());\n        return new ChecklistVerdict(req.id, CK_FAIL, result.output);\n    }\n\n    /**\n     * One loud complaint per checklist whose verdict file EXISTS but cannot be read as a verdict — almost\n     * always one still using the removed `success` field. Public and separate from\n     * {@link requiredChecklistErrors} because `wp-finish-upsert-pr` refuses on missing reviewers BEFORE it\n     * parses review.json: without this, a legacy file would surface as the generic \"no verdict yet\" block\n     * and the AI would re-run a reviewer that already ran instead of fixing four characters of JSON.\n     */\n    checklistFormatErrors(required: readonly RequiredChecklist[], results: readonly ChecklistResult[]): string[] {\n        const errors: string[] = [];\n        for (const req of required) {\n            const verdict = this.resolveVerdict(req, results);\n            if (verdict.status === CK_BAD_FORMAT) errors.push(verdict.detail);\n        }\n        return errors;\n    }\n\n    // Every matched checklist whose verdict is FAIL (reviewed, found a problem, no override) or MISSING (no\n    // review-<id>.json written) → one error each, printing the reviewer's `output` verbatim.\n    private requiredChecklistErrors(required: readonly RequiredChecklist[], results: readonly ChecklistResult[]): string[] {\n        // Format complaints come from the ONE renderer, so wp-checklist and wp-finish word them identically.\n        const errors: string[] = this.checklistFormatErrors(required, results);\n        for (const req of required) {\n            const verdict = this.resolveVerdict(req, results);\n            // CK_WARN ('yellow' — passed with concerns) is deliberately absent from this chain: it SHIPS.\n            // The concern still reaches the PR, published in the checklist comment. Do not \"fix\" this.\n            if (verdict.status === CK_FAIL) {\n                errors.push(\n                    `Checklist \"${req.id}\" FAILED review (status:\"${VERDICT_RED}\"). The reviewer (${req.subagent}) wrote:\\n      ` +\n                    `${verdict.detail.split('\\n').join('\\n      ')}\\n` +\n                    `      Fix it, then re-run; or set a non-empty \"override\" in ${this.checklistFileName(req.id)} to ship anyway with a stated justification.`,\n                );\n            } else if (verdict.status === CK_MISSING) {\n                const doc = req.doc.trim() !== '' ? ` Read: ${req.doc}.` : '';\n                errors.push(\n                    `Checklist \"${req.id}\" MATCHED this diff but has no verdict. Spawn the \"${req.subagent}\" subagent to review it, ` +\n                    `then write ${this.checklistFileName(req.id)} with ` +\n                    `{\"id\":\"${req.id}\",\"status\":\"${VERDICT_GREEN}\",\"output\":\"…\",\"override\":\"\"}.${doc}`,\n                );\n            }\n        }\n        return errors;\n    }\n\n    private checklistFileName(checklistId: string): string {\n        return `review-${checklistId}.json`;\n    }\n\n    /**\n     * Parse one review-<id>.json into a ChecklistResult. `null` ONLY when the bytes do not parse as a JSON\n     * object at all — that tolerance is why a half-written file never wedges a branch, and it degrades to\n     * the same \"no verdict yet\" message as an absent file, which is honest (nothing readable is there).\n     *\n     * A file that DOES parse always yields a result, even when its verdict is unreadable, carrying the\n     * complaint in `problem`. Returning `null` for those instead would collapse \"wrote a verdict in the old\n     * format\" into \"never wrote a verdict\" and send the AI off to re-run a reviewer that already ran.\n     */\n    // webpieces-disable no-any-unknown -- opaque parsed JSON, narrowed field-by-field\n    private parseChecklistResult(filePath: string, id: string): ChecklistResult | null {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: an unparseable per-checklist file is skipped, not fatal\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            // webpieces-disable no-any-unknown -- parsed JSON is opaque until narrowed below\n            const raw = JSON.parse(fs.readFileSync(filePath, 'utf8')) as Record<string, unknown>;\n            if (typeof raw !== 'object' || raw === null || Array.isArray(raw)) return null;\n            const output = typeof raw['output'] === 'string' ? (raw['output'] as string) : '';\n            const override = typeof raw['override'] === 'string' ? (raw['override'] as string) : '';\n            const status = typeof raw['status'] === 'string' ? (raw['status'] as string).trim().toLowerCase() : '';\n            return new ChecklistResult(id, status, output, override, this.statusProblem(filePath, id, status, raw));\n        } catch (err: unknown) {\n            const error = toError(err);\n            void error;\n            return null;\n        }\n    }\n\n    /**\n     * '' when `status` is one of the three colors. Otherwise the complaint to show the AI verbatim. The\n     * legacy-`success` case gets its OWN message: `success` was removed outright (no compatibility mode),\n     * and a reviewer told only \"status must be green|yellow|red\" cannot tell whether it wrote the wrong\n     * value or is using a field that no longer exists.\n     */\n    // webpieces-disable no-any-unknown -- opaque parsed JSON; only tested for key presence here\n    private statusProblem(filePath: string, id: string, status: string, raw: Record<string, unknown>): string {\n        // webpieces-disable no-any-unknown -- comparing against the readonly literal tuple of valid colors\n        if ((VERDICT_STATUSES as readonly string[]).includes(status)) return '';\n        const shape =\n            `      { \"id\": \"${id}\", \"status\": \"${VERDICT_GREEN} | ${VERDICT_YELLOW} | ${VERDICT_RED}\", ` +\n            `\"output\": \"what you checked / found\", \"override\": \"\" }\\n` +\n            `        ${VERDICT_GREEN}  → passes\\n` +\n            `        ${VERDICT_YELLOW} → passes WITH CONCERNS; nothing is blocked and the concern is published on the PR\\n` +\n            `        ${VERDICT_RED}    → REFUSES the PR (set a non-empty \"override\" to ship anyway with a stated justification)\\n` +\n            `      File: ${filePath}`;\n        if ('success' in raw) {\n            return `Checklist \"${id}\" wrote its verdict with the REMOVED \"success\" field. It is now a tri-state ` +\n                `\"status\" — there is no compatibility mode. Rewrite the file as:\\n${shape}`;\n        }\n        return `Checklist \"${id}\" wrote a verdict with no valid \"status\" (got ${JSON.stringify(status)}). ` +\n            `It must be exactly one of ${VERDICT_STATUSES.join(', ')}:\\n${shape}`;\n    }\n\n    // webpieces-disable no-any-unknown -- opaque parsed JSON value, narrowed to string[] here\n    private asStringArray(value: unknown): string[] {\n        if (!Array.isArray(value)) return [];\n        // webpieces-disable no-any-unknown -- element of an opaque JSON array, narrowed by the type guard\n        return value.filter((v: unknown): v is string => typeof v === 'string');\n    }\n\n    // Parse opaque AI-authored JSON, converting a SyntaxError into a readable InformAiError.\n    // webpieces-disable no-any-unknown -- returns the opaque parsed object; loadReviewJson narrows each field\n    private parseReviewJson(raw: string, filePath: string): Record<string, unknown> {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: convert JSON.parse SyntaxError to an InformAiError for the AI\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            // webpieces-disable no-any-unknown -- parsed JSON is opaque until narrowed by the caller\n            return JSON.parse(raw) as Record<string, unknown>;\n        } catch (err: unknown) {\n            const error = toError(err);\n            throw new InformAiError(\n                `review.json is not valid JSON (${error.message}).\\n\\n${this.reviewJsonSchemaHint(filePath)}\\n\\n` +\n                `Then re-run: pnpm wp-finish-upsert-pr`,\n            );\n        }\n    }\n}\n\n// Temporary migration delegators to ReviewJsonService — removed once consumers inject it.\nconst reviewJsonSvc = new ReviewJsonService();\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function prDirFor(repoRoot: string, featureName: string): string {\n    return reviewJsonSvc.prDirFor(repoRoot, featureName);\n}\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function reviewJsonPath(repoRoot: string, featureName: string): string {\n    return reviewJsonSvc.reviewJsonPath(repoRoot, featureName);\n}\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function reviewJsonSchemaHint(filePath: string): string {\n    return reviewJsonSvc.reviewJsonSchemaHint(filePath);\n}\n\n// webpieces-disable no-function-outside-class -- temporary back-compat delegator to ReviewJsonService; removed once consumers inject it\nexport function loadReviewJson(filePath: string, required: readonly RequiredChecklist[] = []): ReviewJson {\n    return reviewJsonSvc.loadReviewJson(filePath, required);\n}\n"]}

package/src/rule-configs.d.ts

@@ -31,10 +31,14 @@ export declare abstract class BaseRuleConfig {
     mode?: string;
     ignoreModifiedUntilEpoch?: number;
     ignoreRuleWhileOnBranch?: string;
+    turnOffRuleUntilEpoch?: number;
+    turnOffRuleWhileOnBranch?: string;
 }
 export declare const BASE_RULE_SCHEMA: {
     ignoreModifiedUntilEpoch: FieldDef;
     ignoreRuleWhileOnBranch: FieldDef;
+    turnOffRuleUntilEpoch: FieldDef;
+    turnOffRuleWhileOnBranch: FieldDef;
 };
 export declare class MaxMethodLinesConfig extends BaseRuleConfig {
     mode?: MethodLimitMode;

package/src/rule-configs.js

@@ -36,32 +36,47 @@ exports.VALIDATE_TS_MODES = ['OFF', 'NEW_AND_MODIFIED_FILES'];
 exports.STRUCTURAL_MODES = ['OFF', 'RUN_EVERY_TIME'];
 // ---------------------------------------------------------------------------
 // Universal escape hatches — EVERY rule supports temporarily disabling itself
-// either while on a named git branch (ignoreRuleWhileOnBranch) or until an
-// epoch passes (ignoreModifiedUntilEpoch). They live on a shared base class so
-// the two fields (and their schema entries) are declared once instead of
-// repeated per rule. `mode` stays per-rule because its allowed values vary
-// (ON/OFF vs NEW_AND_MODIFIED_CODE vs NEW_AND_MODIFIED_METHODS, etc).
+// either while on a named git branch (turnOffRuleWhileOnBranch) or until an
+// epoch passes (turnOffRuleUntilEpoch). They live on a shared base class so the
+// fields (and their schema entries) are declared once instead of repeated per
+// rule. `mode` stays per-rule because its allowed values vary (ON/OFF vs
+// NEW_AND_MODIFIED_CODE vs NEW_AND_MODIFIED_METHODS, etc).
 //
-// `ignoreModifiedUntilEpoch` is REQUIRED on every rule so the time-box escape
-// hatch is always present and a rule can be turned off with a one-value edit.
-// Convention: 0 = rule active (epoch is in the past, never skipped); a future
-// unix epoch IN SECONDS = rule temporarily disabled until that moment.
-// `ignoreRuleWhileOnBranch` stays optional.
+// TWO NAMES per hatch, and BOTH are accepted (see normalizeTurnOffAliases):
+//   turnOffRuleUntilEpoch   — new, self-describing name. Supersedes ignoreModifiedUntilEpoch.
+//   turnOffRuleWhileOnBranch — new, self-describing name. Supersedes ignoreRuleWhileOnBranch.
+// The original `ignoreModifiedUntilEpoch` / `ignoreRuleWhileOnBranch` keep working so a config can
+// migrate a rule at a time. When both names are present on one rule, the new name wins.
+//
+// Convention (unchanged): 0 = rule active (epoch is in the past, never skipped); a future unix epoch
+// IN SECONDS = rule temporarily disabled until that moment. All four fields are OPTIONAL — a rule may
+// carry the branch hatch alone (turnOffRuleWhileOnBranch) with no epoch, which is the intended
+// end-state once callers stop writing turnOffRuleUntilEpoch.
 // ---------------------------------------------------------------------------
 class BaseRuleConfig {
     // `mode` is declared here (loosely typed) so the shared AbstractRule base can read it for
     // on/off. Each concrete *Config narrows it to its own union (e.g. `mode?: ModifiedCodeMode`),
     // which is an assignable (covariant) override.
     mode;
-    // TS-optional, but schema-REQUIRED (see BASE_RULE_SCHEMA) — same split as `mode`.
+    // Original names — still accepted. normalizeTurnOffAliases canonicalizes the new names ONTO these,
+    // so every reader in both packages keeps reading exactly this pair.
     ignoreModifiedUntilEpoch;
     ignoreRuleWhileOnBranch;
+    // New, self-describing names. A config using these is normalized onto the pair above at load time.
+    turnOffRuleUntilEpoch;
+    turnOffRuleWhileOnBranch;
 }
 exports.BaseRuleConfig = BaseRuleConfig;
 exports.BASE_RULE_SCHEMA = {
-    ignoreModifiedUntilEpoch: new field_def_1.FieldDef('number'),
+    ignoreModifiedUntilEpoch: field_def_1.FieldDef.optional('number'),
     ignoreRuleWhileOnBranch: field_def_1.FieldDef.optional('string'),
+    turnOffRuleUntilEpoch: field_def_1.FieldDef.optional('number'),
+    turnOffRuleWhileOnBranch: field_def_1.FieldDef.optional('string'),
 };
+// The new names are canonicalized onto the original pair at the load boundary by
+// ConfigLoader.normalizeTurnOffAliases (load-config.ts), sibling to normalizeDeprecatedKeys — so every
+// downstream reader (AbstractRule.shouldRun, RuleGate, the match-rules engine) reads one name and
+// needs no change. new name wins when both are present.
 class MaxMethodLinesConfig extends BaseRuleConfig {
     limit;
     disableAllowed;
@@ -476,22 +491,18 @@ class NoJsFilesConfig extends BaseRuleConfig {
 exports.NoJsFilesConfig = NoJsFilesConfig;
 // ---------------------------------------------------------------------------
 // The five Nx infrastructure validators (architecture-unchanged, no-architecture-cycles,
-// packagejson, versions-locked, eslint-sync). They hardcoded their behavior until now — the ONLY
-// rules in the system that could not be turned off or time-boxed. Each is whole-graph / whole-repo
-// by nature (a cycle, a drifted dependencies.json, an unlocked version can be introduced by a file
-// nobody in this diff touched), so the only honest mode set is STRUCTURAL_MODES: RUN_EVERY_TIME
-// (the default) or OFF.
+// packagejson, versions-locked, eslint-sync). Each is whole-graph / whole-repo by nature (a cycle, a
+// drifted dependencies.json, an unlocked version can be introduced by a file nobody in this diff
+// touched), so the only honest mode set is STRUCTURAL_MODES: RUN_EVERY_TIME (the default) or OFF.
 //
-// Epoch gating splits the five in two, and the split is deliberate:
-//  - architecture-unchanged / no-architecture-cycles compare against a BLESSED baseline, so
-//    "grandfather today's drift until <epoch>" is a coherent request — those two honor
-//    ignoreModifiedUntilEpoch (and ignoreRuleWhileOnBranch) via shouldSkipRule.
-//  - packagejson / versions-locked / eslint-sync have no baseline to grandfather against; they are
-//    all-or-nothing, so their executors read `mode` ONLY. ignoreModifiedUntilEpoch is still present
-//    (it is schema-required on EVERY rule by BASE_RULE_SCHEMA) but is NOT honored by those three —
-//    set "mode": "OFF" to turn them off.
+// All five now honor the universal escape hatches (turnOffRuleUntilEpoch / turnOffRuleWhileOnBranch,
+// and their ignore* aliases) via shouldSkipRule — the RuleGate is called with honorEpoch:true from
+// every executor. This lets a repo time-box or branch-scope a failing infrastructure check (e.g. hold
+// validate-packagejson off until an upgrade PR lands) with a one-value edit, instead of only the
+// blunt "mode": "OFF". Originally packagejson/versions-locked/eslint-sync were all-or-nothing on the
+// theory that "no blessed baseline" made grandfathering meaningless, but a time-box is a schedule, not
+// a baseline: "do not enforce this until <epoch>/off <branch>" is coherent for any rule.
 // ---------------------------------------------------------------------------
-// Epoch-gateable: the current graph is compared to the blessed architecture/dependencies.json.
 class ValidateArchitectureUnchangedConfig extends BaseRuleConfig {
     static SCHEMA = {
         mode: new field_def_1.FieldDef('string', exports.STRUCTURAL_MODES),
@@ -499,7 +510,6 @@ class ValidateArchitectureUnchangedConfig extends BaseRuleConfig {
     };
 }
 exports.ValidateArchitectureUnchangedConfig = ValidateArchitectureUnchangedConfig;
-// Epoch-gateable: the set of project-level cycles can be grandfathered while a refactor lands.
 class ValidateNoArchitectureCyclesConfig extends BaseRuleConfig {
     static SCHEMA = {
         mode: new field_def_1.FieldDef('string', exports.STRUCTURAL_MODES),
@@ -507,7 +517,6 @@ class ValidateNoArchitectureCyclesConfig extends BaseRuleConfig {
     };
 }
 exports.ValidateNoArchitectureCyclesConfig = ValidateNoArchitectureCyclesConfig;
-// All-or-nothing (no baseline to grandfather): ignoreModifiedUntilEpoch is NOT honored.
 class ValidatePackageJsonConfig extends BaseRuleConfig {
     static SCHEMA = {
         mode: new field_def_1.FieldDef('string', exports.STRUCTURAL_MODES),
@@ -515,7 +524,6 @@ class ValidatePackageJsonConfig extends BaseRuleConfig {
     };
 }
 exports.ValidatePackageJsonConfig = ValidatePackageJsonConfig;
-// All-or-nothing (no baseline to grandfather): ignoreModifiedUntilEpoch is NOT honored.
 class ValidateVersionsLockedConfig extends BaseRuleConfig {
     static SCHEMA = {
         mode: new field_def_1.FieldDef('string', exports.STRUCTURAL_MODES),
@@ -523,7 +531,6 @@ class ValidateVersionsLockedConfig extends BaseRuleConfig {
     };
 }
 exports.ValidateVersionsLockedConfig = ValidateVersionsLockedConfig;
-// All-or-nothing (no baseline to grandfather): ignoreModifiedUntilEpoch is NOT honored.
 class ValidateEslintSyncConfig extends BaseRuleConfig {
     static SCHEMA = {
         mode: new field_def_1.FieldDef('string', exports.STRUCTURAL_MODES),