@webpieces/rules-config 0.4.472 → 0.4.473

package/src/pr-gate-config.js

@@ -8,7 +8,6 @@ exports.PrGateConfig = exports.MERGE_MODES = exports.MERGE_MODE_NONE = exports.M
 exports.defaultGates = defaultGates;
 exports.defaultPrGateConfig = defaultPrGateConfig;
 exports.buildPrGateConfig = buildPrGateConfig;
-const checklist_config_1 = require("./checklist-config");
 class GateDefinition {
     name;
     patterns;
@@ -55,9 +54,9 @@ class PrGateConfig {
      *   commits land as the internal "Squash merge of <branch>" subject.
      */
     mergeMode;
-    // Diff-triggered company review checklists (the extension point). Defaults to [] — an absent
-    // `checklists` key produces byte-identical behavior to before this field existed.
-    checklists;
+    // Repo-relative path of the ONE doc carrying the checklist manifest (a <!-- webpieces:checklists [...] -->
+    // JSON block). '' = no checklists. The checklist SET lives in that doc (content), never here (config).
+    checklistDoc;
     /**
      * Shared secret used to mint the server-verifiable gate token. `wp-finish-upsert-pr` writes
      * `HMAC(gateSalt, HEAD_sha)` as a hidden marker into the PR body (and REFUSES to mint it unless
@@ -72,12 +71,12 @@ class PrGateConfig {
      */
     gateSalt;
     // eslint-disable-next-line @typescript-eslint/max-params
-    constructor(mode, buildCommand, gates, mergeMode, checklists = [], gateSalt = '') {
+    constructor(mode, buildCommand, gates, mergeMode, checklistDoc = '', gateSalt = '') {
         this.mode = mode;
         this.buildCommand = buildCommand;
         this.gates = gates;
         this.mergeMode = mergeMode;
-        this.checklists = checklists;
+        this.checklistDoc = checklistDoc;
         this.gateSalt = gateSalt;
     }
 }
@@ -93,8 +92,8 @@ function defaultGates() {
     ];
 }
 function defaultPrGateConfig() {
-    // No default checklists — the extension point is opt-in; the default monorepo ships none.
-    return new PrGateConfig('ON', '', defaultGates(), exports.MERGE_MODE_AUTO, []);
+    // No default checklist doc — the extension point is opt-in; the default monorepo ships none.
+    return new PrGateConfig('ON', '', defaultGates(), exports.MERGE_MODE_AUTO, '');
 }
 function toGate(raw) {
     return new GateDefinition(raw.name ?? '', raw.patterns ?? [], raw.warningColor ?? 'yellow', raw.disabled ?? false);
@@ -117,10 +116,10 @@ function buildPrGateConfig(section) {
     // REQUIRED — validatePrGateSection rejects an omitted/unknown value, so this fallback only ever
     // applies to the no-config-file path that defaultPrGateConfig() serves.
     const mergeMode = raw.mergeMode ?? defaults.mergeMode;
-    // Optional extension point — omitted ⇒ [] ⇒ no checklists computed anywhere downstream.
-    const checklists = raw.checklists !== undefined ? raw.checklists.map(checklist_config_1.toChecklist) : defaults.checklists;
+    // Optional extension point — omitted ⇒ '' ⇒ no checklists computed anywhere downstream.
+    const checklistDoc = raw.checklists?.doc ?? defaults.checklistDoc;
     // Optional — omitted ⇒ '' ⇒ no gate token minted and CI enforcement is a no-op (back-compat).
     const gateSalt = raw.gateSalt ?? defaults.gateSalt;
-    return new PrGateConfig(mode, buildCommand, gates, mergeMode, checklists, gateSalt);
+    return new PrGateConfig(mode, buildCommand, gates, mergeMode, checklistDoc, gateSalt);
 }
 //# sourceMappingURL=pr-gate-config.js.map

package/src/pr-gate-config.js.map

@@ -1 +1 @@
-{"version":3,"file":"pr-gate-config.js","sourceRoot":"","sources":["../../../../../packages/tooling/rules-config/src/pr-gate-config.ts"],"names":[],"mappings":";AAAA,2FAA2F;AAC3F,2FAA2F;AAC3F,iFAAiF;AACjF,iGAAiG;;;AAkFjG,oCAOC;AAED,kDAGC;AA6BD,8CAgBC;AAzID,yDAAoF;AAEpF,MAAa,cAAc;IACvB,IAAI,CAAS;IACb,QAAQ,CAAW;IACnB,iGAAiG;IACjG,8FAA8F;IAC9F,+FAA+F;IAC/F,gGAAgG;IAChG,YAAY,CAAS,CAAC,mBAAmB;IACzC,2FAA2F;IAC3F,yFAAyF;IACzF,QAAQ,CAAU;IAElB,YAAY,IAAY,EAAE,QAAkB,EAAE,YAAoB,EAAE,QAAQ,GAAG,KAAK;QAChF,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;QACjC,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;IAC7B,CAAC;CACJ;AAlBD,wCAkBC;AAED,qGAAqG;AACrG,mGAAmG;AACnG,sGAAsG;AACtG,sGAAsG;AACtG,sGAAsG;AACzF,QAAA,eAAe,GAAG,MAAM,CAAC;AACzB,QAAA,eAAe,GAAG,MAAM,CAAC;AACzB,QAAA,WAAW,GAAG,CAAC,uBAAe,EAAE,uBAAe,CAAC,CAAC;AAE9D,MAAa,YAAY;IACrB,IAAI,CAAS;IACb,YAAY,CAAS;IACrB,KAAK,CAAmB;IACxB;;;;;;;;;;;;;OAaG;IACH,SAAS,CAAS;IAClB,6FAA6F;IAC7F,kFAAkF;IAClF,UAAU,CAAwB;IAClC;;;;;;;;;;;OAWG;IACH,QAAQ,CAAS;IAEjB,yDAAyD;IACzD,YAAY,IAAY,EAAE,YAAoB,EAAE,KAAuB,EAAE,SAAiB,EAAE,aAAoC,EAAE,EAAE,QAAQ,GAAG,EAAE;QAC7I,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;QACjC,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,UAAU,GAAG,UAAU,CAAC;QAC7B,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;IAC7B,CAAC;CACJ;AA7CD,oCA6CC;AAED,0FAA0F;AAC1F,qEAAqE;AACrE,SAAgB,YAAY;IACxB,OAAO;QACH,IAAI,cAAc,CAAC,aAAa,EAAE,CAAC,mBAAmB,EAAE,YAAY,CAAC,EAAE,QAAQ,CAAC;QAChF,IAAI,cAAc,CAAC,sBAAsB,EAAE,CAAC,iBAAiB,EAAE,mBAAmB,EAAE,SAAS,EAAE,eAAe,CAAC,EAAE,QAAQ,CAAC;QAC1H,IAAI,cAAc,CAAC,0BAA0B,EAAE,CAAC,gCAAgC,CAAC,EAAE,QAAQ,CAAC;QAC5F,IAAI,cAAc,CAAC,wBAAwB,EAAE,CAAC,cAAc,EAAE,gBAAgB,EAAE,YAAY,EAAE,uBAAuB,CAAC,EAAE,QAAQ,CAAC;KACpI,CAAC;AACN,CAAC;AAED,SAAgB,mBAAmB;IAC/B,0FAA0F;IAC1F,OAAO,IAAI,YAAY,CAAC,IAAI,EAAE,EAAE,EAAE,YAAY,EAAE,EAAE,uBAAe,EAAE,EAAE,CAAC,CAAC;AAC3E,CAAC;AAkBD,SAAS,MAAM,CAAC,GAAY;IACxB,OAAO,IAAI,cAAc,CAAC,GAAG,CAAC,IAAI,IAAI,EAAE,EAAE,GAAG,CAAC,QAAQ,IAAI,EAAE,EAAE,GAAG,CAAC,YAAY,IAAI,QAAQ,EAAE,GAAG,CAAC,QAAQ,IAAI,KAAK,CAAC,CAAC;AACvH,CAAC;AAED;;;;;GAKG;AACH,4FAA4F;AAC5F,SAAgB,iBAAiB,CAAC,OAAgB;IAC9C,MAAM,QAAQ,GAAG,mBAAmB,EAAE,CAAC;IACvC,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,KAAK,IAAI,IAAI,OAAO,OAAO,KAAK,QAAQ;QAAE,OAAO,QAAQ,CAAC;IAE9F,MAAM,GAAG,GAAG,OAA2B,CAAC;IACxC,MAAM,IAAI,GAAG,GAAG,CAAC,IAAI,IAAI,QAAQ,CAAC,IAAI,CAAC;IACvC,MAAM,YAAY,GAAG,GAAG,CAAC,YAAY,IAAI,QAAQ,CAAC,YAAY,CAAC;IAC/D,MAAM,KAAK,GAAG,GAAG,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC;IAC/E,gGAAgG;IAChG,wEAAwE;IACxE,MAAM,SAAS,GAAG,GAAG,CAAC,SAAS,IAAI,QAAQ,CAAC,SAAS,CAAC;IACtD,wFAAwF;IACxF,MAAM,UAAU,GAAG,GAAG,CAAC,UAAU,KAAK,SAAS,CAAC,CAAC,CAAC,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,8BAAW,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC;IACxG,8FAA8F;IAC9F,MAAM,QAAQ,GAAG,GAAG,CAAC,QAAQ,IAAI,QAAQ,CAAC,QAAQ,CAAC;IACnD,OAAO,IAAI,YAAY,CAAC,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,CAAC,CAAC;AACxF,CAAC","sourcesContent":["// PrGateConfig is the \"special section\" for the pr-gate dashboard. It does NOT live in the\n// validated `rules` map (the FieldDef schema can't express nested object arrays), but as a\n// top-level `pr-gate` key in webpieces.config.json. It is built and validated by\n// loadAndValidate (load-config.ts); this module holds only the data classes + defaults + toGate.\n\nimport { ChecklistDefinition, RawChecklist, toChecklist } from './checklist-config';\n\nexport class GateDefinition {\n    name: string;\n    patterns: string[];\n    // The warning color shown on the dashboard WHEN this gate's patterns match a changed file. Green\n    // is implicit (shown when nothing matched), so it is never configured. warningColor is purely\n    // visual — even 'red' never fails/blocks the PR (only the build gate can). 'yellow' = caution,\n    // 'red' = louder \"look here\" flag (e.g. DB schema / migration changes). REQUIRED on every gate.\n    warningColor: string; // 'yellow' | 'red'\n    // Example/inactive gate: parsed and kept in the file (JSON has no comments) but skipped at\n    // compute/render time. Other projects flip this to false and tune patterns/warningColor.\n    disabled: boolean;\n\n    constructor(name: string, patterns: string[], warningColor: string, disabled = false) {\n        this.name = name;\n        this.patterns = patterns;\n        this.warningColor = warningColor;\n        this.disabled = disabled;\n    }\n}\n\n// How wp-finish-upsert-pr should try to LAND the PR once it has posted it. GitHub's auto-merge queue\n// is a REPO-level setting (`allow_auto_merge`) that many orgs turn OFF as a policy control, and it\n// CANNOT be forced from the client: `gh pr merge --auto` calls the enablePullRequestAutoMerge GraphQL\n// mutation, which hard-errors with \"Auto merge is not allowed for this repository\" when the repo says\n// no. So the only lever a config knob has is WHICH PATHS WE ATTEMPT — never whether the queue exists.\nexport const MERGE_MODE_AUTO = 'AUTO';\nexport const MERGE_MODE_NONE = 'NONE';\nexport const MERGE_MODES = [MERGE_MODE_AUTO, MERGE_MODE_NONE];\n\nexport class PrGateConfig {\n    mode: string;\n    buildCommand: string;\n    gates: GateDefinition[];\n    /**\n     * REQUIRED — every repo must state its policy; there is deliberately no default, because the two\n     * answers are a real policy decision and guessing it either merges when a team did not want that,\n     * or silently stops landing PRs on a team that relied on it.\n     *\n     * AUTO — wp-finish-upsert-pr LANDS the PR: squash-merge it right away when it is mergeable, else\n     *   enable GitHub auto-merge so it lands when the checks pass. Both carry an explicit --subject /\n     *   --body-file, which is the ONLY way main's history gets the PR title plus the compact\n     *   risk/flags body — no repo setting can produce that. Requires allow_auto_merge on the repo.\n     * NONE — wp-finish-upsert-pr only opens/updates the PR and stops; a human merges. NOTE the cost:\n     *   a UI merge cannot use the compact body, so main's commit falls back to the repo's\n     *   squash_merge_commit_title/message settings. Set squash_merge_commit_title=PR_TITLE there, or\n     *   commits land as the internal \"Squash merge of <branch>\" subject.\n     */\n    mergeMode: string;\n    // Diff-triggered company review checklists (the extension point). Defaults to [] — an absent\n    // `checklists` key produces byte-identical behavior to before this field existed.\n    checklists: ChecklistDefinition[];\n    /**\n     * Shared secret used to mint the server-verifiable gate token. `wp-finish-upsert-pr` writes\n     * `HMAC(gateSalt, HEAD_sha)` as a hidden marker into the PR body (and REFUSES to mint it unless\n     * every BLOCK checklist passed), so a valid token IS proof the local gate ran and passed. A CI\n     * check (`wp-check-pr` + the scaffolded workflow) recomputes it from the PR head sha and this salt.\n     *\n     * Optional, defaults to '' — empty means \"no token minted, no CI enforcement\" (byte-identical to\n     * before this field existed). This is COMMITTED, obscurity-grade: it stops unhooked teammates who\n     * push + open a PR in the web UI, but is readable in-repo and therefore forgeable by a determined\n     * reader. It is deliberately NOT cryptographically sound; nothing local can stop a filesystem-reading\n     * agent. See RESPONSE-pr-gate-ci-enforcement / the design memo for the full tradeoff.\n     */\n    gateSalt: string;\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(mode: string, buildCommand: string, gates: GateDefinition[], mergeMode: string, checklists: ChecklistDefinition[] = [], gateSalt = '') {\n        this.mode = mode;\n        this.buildCommand = buildCommand;\n        this.gates = gates;\n        this.mergeMode = mergeMode;\n        this.checklists = checklists;\n        this.gateSalt = gateSalt;\n    }\n}\n\n// Default infra gates — path-pattern based, tuned for this monorepo. Clients override the\n// whole list via the `pr-gate.gates` array in webpieces.config.json.\nexport function defaultGates(): GateDefinition[] {\n    return [\n        new GateDefinition('API Changed', ['libraries/apis/**', '**/*Api.ts'], 'yellow'),\n        new GateDefinition('Config Files Changed', ['**/package.json', '**/tsconfig*.json', 'nx.json', '**/*.config.*'], 'yellow'),\n        new GateDefinition('Dependency Graph Changed', ['architecture/dependencies.json'], 'yellow'),\n        new GateDefinition('Claude / Rules Changed', ['**/CLAUDE.md', '**/claude.*.md', '.claude/**', 'webpieces.config.json'], 'yellow'),\n    ];\n}\n\nexport function defaultPrGateConfig(): PrGateConfig {\n    // No default checklists — the extension point is opt-in; the default monorepo ships none.\n    return new PrGateConfig('ON', '', defaultGates(), MERGE_MODE_AUTO, []);\n}\n\ninterface RawGate {\n    name?: string;\n    patterns?: string[];\n    warningColor?: string;\n    disabled?: boolean;\n}\n\ninterface RawPrGateSection {\n    mode?: string;\n    buildCommand?: string;\n    gates?: RawGate[];\n    mergeMode?: string;\n    checklists?: RawChecklist[];\n    gateSalt?: string;\n}\n\nfunction toGate(raw: RawGate): GateDefinition {\n    return new GateDefinition(raw.name ?? '', raw.patterns ?? [], raw.warningColor ?? 'yellow', raw.disabled ?? false);\n}\n\n/**\n * Build a PrGateConfig from the already-parsed top-level `pr-gate` section, falling back to defaults\n * for any field the consumer omits. Pure transform — the file read + structural validation happen in\n * loadAndValidate (load-config.ts) so every consumer goes through one validated path. Pass undefined\n * (no `pr-gate` key / no config file) to get full defaults.\n */\n// webpieces-disable no-any-unknown -- `section` is opaque consumer JSON until narrowed here\nexport function buildPrGateConfig(section: unknown): PrGateConfig {\n    const defaults = defaultPrGateConfig();\n    if (section === undefined || section === null || typeof section !== 'object') return defaults;\n\n    const raw = section as RawPrGateSection;\n    const mode = raw.mode ?? defaults.mode;\n    const buildCommand = raw.buildCommand ?? defaults.buildCommand;\n    const gates = raw.gates !== undefined ? raw.gates.map(toGate) : defaults.gates;\n    // REQUIRED — validatePrGateSection rejects an omitted/unknown value, so this fallback only ever\n    // applies to the no-config-file path that defaultPrGateConfig() serves.\n    const mergeMode = raw.mergeMode ?? defaults.mergeMode;\n    // Optional extension point — omitted ⇒ [] ⇒ no checklists computed anywhere downstream.\n    const checklists = raw.checklists !== undefined ? raw.checklists.map(toChecklist) : defaults.checklists;\n    // Optional — omitted ⇒ '' ⇒ no gate token minted and CI enforcement is a no-op (back-compat).\n    const gateSalt = raw.gateSalt ?? defaults.gateSalt;\n    return new PrGateConfig(mode, buildCommand, gates, mergeMode, checklists, gateSalt);\n}\n"]}
+{"version":3,"file":"pr-gate-config.js","sourceRoot":"","sources":["../../../../../packages/tooling/rules-config/src/pr-gate-config.ts"],"names":[],"mappings":";AAAA,2FAA2F;AAC3F,2FAA2F;AAC3F,iFAAiF;AACjF,iGAAiG;;;AAgFjG,oCAOC;AAED,kDAGC;AA6BD,8CAgBC;AAvID,MAAa,cAAc;IACvB,IAAI,CAAS;IACb,QAAQ,CAAW;IACnB,iGAAiG;IACjG,8FAA8F;IAC9F,+FAA+F;IAC/F,gGAAgG;IAChG,YAAY,CAAS,CAAC,mBAAmB;IACzC,2FAA2F;IAC3F,yFAAyF;IACzF,QAAQ,CAAU;IAElB,YAAY,IAAY,EAAE,QAAkB,EAAE,YAAoB,EAAE,QAAQ,GAAG,KAAK;QAChF,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;QACjC,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;IAC7B,CAAC;CACJ;AAlBD,wCAkBC;AAED,qGAAqG;AACrG,mGAAmG;AACnG,sGAAsG;AACtG,sGAAsG;AACtG,sGAAsG;AACzF,QAAA,eAAe,GAAG,MAAM,CAAC;AACzB,QAAA,eAAe,GAAG,MAAM,CAAC;AACzB,QAAA,WAAW,GAAG,CAAC,uBAAe,EAAE,uBAAe,CAAC,CAAC;AAE9D,MAAa,YAAY;IACrB,IAAI,CAAS;IACb,YAAY,CAAS;IACrB,KAAK,CAAmB;IACxB;;;;;;;;;;;;;OAaG;IACH,SAAS,CAAS;IAClB,2GAA2G;IAC3G,uGAAuG;IACvG,YAAY,CAAS;IACrB;;;;;;;;;;;OAWG;IACH,QAAQ,CAAS;IAEjB,yDAAyD;IACzD,YAAY,IAAY,EAAE,YAAoB,EAAE,KAAuB,EAAE,SAAiB,EAAE,YAAY,GAAG,EAAE,EAAE,QAAQ,GAAG,EAAE;QACxH,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;QACjC,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;QAC3B,IAAI,CAAC,YAAY,GAAG,YAAY,CAAC;QACjC,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;IAC7B,CAAC;CACJ;AA7CD,oCA6CC;AAED,0FAA0F;AAC1F,qEAAqE;AACrE,SAAgB,YAAY;IACxB,OAAO;QACH,IAAI,cAAc,CAAC,aAAa,EAAE,CAAC,mBAAmB,EAAE,YAAY,CAAC,EAAE,QAAQ,CAAC;QAChF,IAAI,cAAc,CAAC,sBAAsB,EAAE,CAAC,iBAAiB,EAAE,mBAAmB,EAAE,SAAS,EAAE,eAAe,CAAC,EAAE,QAAQ,CAAC;QAC1H,IAAI,cAAc,CAAC,0BAA0B,EAAE,CAAC,gCAAgC,CAAC,EAAE,QAAQ,CAAC;QAC5F,IAAI,cAAc,CAAC,wBAAwB,EAAE,CAAC,cAAc,EAAE,gBAAgB,EAAE,YAAY,EAAE,uBAAuB,CAAC,EAAE,QAAQ,CAAC;KACpI,CAAC;AACN,CAAC;AAED,SAAgB,mBAAmB;IAC/B,6FAA6F;IAC7F,OAAO,IAAI,YAAY,CAAC,IAAI,EAAE,EAAE,EAAE,YAAY,EAAE,EAAE,uBAAe,EAAE,EAAE,CAAC,CAAC;AAC3E,CAAC;AAkBD,SAAS,MAAM,CAAC,GAAY;IACxB,OAAO,IAAI,cAAc,CAAC,GAAG,CAAC,IAAI,IAAI,EAAE,EAAE,GAAG,CAAC,QAAQ,IAAI,EAAE,EAAE,GAAG,CAAC,YAAY,IAAI,QAAQ,EAAE,GAAG,CAAC,QAAQ,IAAI,KAAK,CAAC,CAAC;AACvH,CAAC;AAED;;;;;GAKG;AACH,4FAA4F;AAC5F,SAAgB,iBAAiB,CAAC,OAAgB;IAC9C,MAAM,QAAQ,GAAG,mBAAmB,EAAE,CAAC;IACvC,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,KAAK,IAAI,IAAI,OAAO,OAAO,KAAK,QAAQ;QAAE,OAAO,QAAQ,CAAC;IAE9F,MAAM,GAAG,GAAG,OAA2B,CAAC;IACxC,MAAM,IAAI,GAAG,GAAG,CAAC,IAAI,IAAI,QAAQ,CAAC,IAAI,CAAC;IACvC,MAAM,YAAY,GAAG,GAAG,CAAC,YAAY,IAAI,QAAQ,CAAC,YAAY,CAAC;IAC/D,MAAM,KAAK,GAAG,GAAG,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC;IAC/E,gGAAgG;IAChG,wEAAwE;IACxE,MAAM,SAAS,GAAG,GAAG,CAAC,SAAS,IAAI,QAAQ,CAAC,SAAS,CAAC;IACtD,wFAAwF;IACxF,MAAM,YAAY,GAAG,GAAG,CAAC,UAAU,EAAE,GAAG,IAAI,QAAQ,CAAC,YAAY,CAAC;IAClE,8FAA8F;IAC9F,MAAM,QAAQ,GAAG,GAAG,CAAC,QAAQ,IAAI,QAAQ,CAAC,QAAQ,CAAC;IACnD,OAAO,IAAI,YAAY,CAAC,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,SAAS,EAAE,YAAY,EAAE,QAAQ,CAAC,CAAC;AAC1F,CAAC","sourcesContent":["// PrGateConfig is the \"special section\" for the pr-gate dashboard. It does NOT live in the\n// validated `rules` map (the FieldDef schema can't express nested object arrays), but as a\n// top-level `pr-gate` key in webpieces.config.json. It is built and validated by\n// loadAndValidate (load-config.ts); this module holds only the data classes + defaults + toGate.\n\nexport class GateDefinition {\n    name: string;\n    patterns: string[];\n    // The warning color shown on the dashboard WHEN this gate's patterns match a changed file. Green\n    // is implicit (shown when nothing matched), so it is never configured. warningColor is purely\n    // visual — even 'red' never fails/blocks the PR (only the build gate can). 'yellow' = caution,\n    // 'red' = louder \"look here\" flag (e.g. DB schema / migration changes). REQUIRED on every gate.\n    warningColor: string; // 'yellow' | 'red'\n    // Example/inactive gate: parsed and kept in the file (JSON has no comments) but skipped at\n    // compute/render time. Other projects flip this to false and tune patterns/warningColor.\n    disabled: boolean;\n\n    constructor(name: string, patterns: string[], warningColor: string, disabled = false) {\n        this.name = name;\n        this.patterns = patterns;\n        this.warningColor = warningColor;\n        this.disabled = disabled;\n    }\n}\n\n// How wp-finish-upsert-pr should try to LAND the PR once it has posted it. GitHub's auto-merge queue\n// is a REPO-level setting (`allow_auto_merge`) that many orgs turn OFF as a policy control, and it\n// CANNOT be forced from the client: `gh pr merge --auto` calls the enablePullRequestAutoMerge GraphQL\n// mutation, which hard-errors with \"Auto merge is not allowed for this repository\" when the repo says\n// no. So the only lever a config knob has is WHICH PATHS WE ATTEMPT — never whether the queue exists.\nexport const MERGE_MODE_AUTO = 'AUTO';\nexport const MERGE_MODE_NONE = 'NONE';\nexport const MERGE_MODES = [MERGE_MODE_AUTO, MERGE_MODE_NONE];\n\nexport class PrGateConfig {\n    mode: string;\n    buildCommand: string;\n    gates: GateDefinition[];\n    /**\n     * REQUIRED — every repo must state its policy; there is deliberately no default, because the two\n     * answers are a real policy decision and guessing it either merges when a team did not want that,\n     * or silently stops landing PRs on a team that relied on it.\n     *\n     * AUTO — wp-finish-upsert-pr LANDS the PR: squash-merge it right away when it is mergeable, else\n     *   enable GitHub auto-merge so it lands when the checks pass. Both carry an explicit --subject /\n     *   --body-file, which is the ONLY way main's history gets the PR title plus the compact\n     *   risk/flags body — no repo setting can produce that. Requires allow_auto_merge on the repo.\n     * NONE — wp-finish-upsert-pr only opens/updates the PR and stops; a human merges. NOTE the cost:\n     *   a UI merge cannot use the compact body, so main's commit falls back to the repo's\n     *   squash_merge_commit_title/message settings. Set squash_merge_commit_title=PR_TITLE there, or\n     *   commits land as the internal \"Squash merge of <branch>\" subject.\n     */\n    mergeMode: string;\n    // Repo-relative path of the ONE doc carrying the checklist manifest (a <!-- webpieces:checklists [...] -->\n    // JSON block). '' = no checklists. The checklist SET lives in that doc (content), never here (config).\n    checklistDoc: string;\n    /**\n     * Shared secret used to mint the server-verifiable gate token. `wp-finish-upsert-pr` writes\n     * `HMAC(gateSalt, HEAD_sha)` as a hidden marker into the PR body (and REFUSES to mint it unless\n     * every BLOCK checklist passed), so a valid token IS proof the local gate ran and passed. A CI\n     * check (`wp-check-pr` + the scaffolded workflow) recomputes it from the PR head sha and this salt.\n     *\n     * Optional, defaults to '' — empty means \"no token minted, no CI enforcement\" (byte-identical to\n     * before this field existed). This is COMMITTED, obscurity-grade: it stops unhooked teammates who\n     * push + open a PR in the web UI, but is readable in-repo and therefore forgeable by a determined\n     * reader. It is deliberately NOT cryptographically sound; nothing local can stop a filesystem-reading\n     * agent. See RESPONSE-pr-gate-ci-enforcement / the design memo for the full tradeoff.\n     */\n    gateSalt: string;\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    constructor(mode: string, buildCommand: string, gates: GateDefinition[], mergeMode: string, checklistDoc = '', gateSalt = '') {\n        this.mode = mode;\n        this.buildCommand = buildCommand;\n        this.gates = gates;\n        this.mergeMode = mergeMode;\n        this.checklistDoc = checklistDoc;\n        this.gateSalt = gateSalt;\n    }\n}\n\n// Default infra gates — path-pattern based, tuned for this monorepo. Clients override the\n// whole list via the `pr-gate.gates` array in webpieces.config.json.\nexport function defaultGates(): GateDefinition[] {\n    return [\n        new GateDefinition('API Changed', ['libraries/apis/**', '**/*Api.ts'], 'yellow'),\n        new GateDefinition('Config Files Changed', ['**/package.json', '**/tsconfig*.json', 'nx.json', '**/*.config.*'], 'yellow'),\n        new GateDefinition('Dependency Graph Changed', ['architecture/dependencies.json'], 'yellow'),\n        new GateDefinition('Claude / Rules Changed', ['**/CLAUDE.md', '**/claude.*.md', '.claude/**', 'webpieces.config.json'], 'yellow'),\n    ];\n}\n\nexport function defaultPrGateConfig(): PrGateConfig {\n    // No default checklist doc — the extension point is opt-in; the default monorepo ships none.\n    return new PrGateConfig('ON', '', defaultGates(), MERGE_MODE_AUTO, '');\n}\n\ninterface RawGate {\n    name?: string;\n    patterns?: string[];\n    warningColor?: string;\n    disabled?: boolean;\n}\n\ninterface RawPrGateSection {\n    mode?: string;\n    buildCommand?: string;\n    gates?: RawGate[];\n    mergeMode?: string;\n    checklists?: { doc?: string };\n    gateSalt?: string;\n}\n\nfunction toGate(raw: RawGate): GateDefinition {\n    return new GateDefinition(raw.name ?? '', raw.patterns ?? [], raw.warningColor ?? 'yellow', raw.disabled ?? false);\n}\n\n/**\n * Build a PrGateConfig from the already-parsed top-level `pr-gate` section, falling back to defaults\n * for any field the consumer omits. Pure transform — the file read + structural validation happen in\n * loadAndValidate (load-config.ts) so every consumer goes through one validated path. Pass undefined\n * (no `pr-gate` key / no config file) to get full defaults.\n */\n// webpieces-disable no-any-unknown -- `section` is opaque consumer JSON until narrowed here\nexport function buildPrGateConfig(section: unknown): PrGateConfig {\n    const defaults = defaultPrGateConfig();\n    if (section === undefined || section === null || typeof section !== 'object') return defaults;\n\n    const raw = section as RawPrGateSection;\n    const mode = raw.mode ?? defaults.mode;\n    const buildCommand = raw.buildCommand ?? defaults.buildCommand;\n    const gates = raw.gates !== undefined ? raw.gates.map(toGate) : defaults.gates;\n    // REQUIRED — validatePrGateSection rejects an omitted/unknown value, so this fallback only ever\n    // applies to the no-config-file path that defaultPrGateConfig() serves.\n    const mergeMode = raw.mergeMode ?? defaults.mergeMode;\n    // Optional extension point — omitted ⇒ '' ⇒ no checklists computed anywhere downstream.\n    const checklistDoc = raw.checklists?.doc ?? defaults.checklistDoc;\n    // Optional — omitted ⇒ '' ⇒ no gate token minted and CI enforcement is a no-op (back-compat).\n    const gateSalt = raw.gateSalt ?? defaults.gateSalt;\n    return new PrGateConfig(mode, buildCommand, gates, mergeMode, checklistDoc, gateSalt);\n}\n"]}

package/src/review-json.d.ts

@@ -1,9 +1,3 @@
-export declare class ChecklistAck {
-    id: string;
-    acknowledged: boolean;
-    notes: string[];
-    constructor(id: string, acknowledged: boolean, notes: string[]);
-}
 export declare class ChecklistResult {
     id: string;
     success: boolean;
@@ -13,13 +7,10 @@ export declare class ChecklistResult {
 }
 export declare class RequiredChecklist {
     id: string;
-    title: string;
-    severity: string;
-    docs: string[];
-    blockMessage: string;
-    matchedFiles: string[];
     subagent: string;
-    constructor(id: string, title: string, severity: string, docs: string[], blockMessage: string, matchedFiles: string[], subagent?: string);
+    doc: string;
+    matchedFiles: string[];
+    constructor(id: string, subagent: string, doc: string, matchedFiles: string[]);
 }
 export declare class ReviewJson {
     title: string;
@@ -30,15 +21,13 @@ export declare class ReviewJson {
     violations: string[];
     risks: string[];
     filesToReview: string[];
-    checklists: ChecklistAck[];
     results: ChecklistResult[];
-    constructor(title: string, riskScore: number, riskLevel: string, riskEmoji: string, summary: string, violations: string[], risks: string[], filesToReview: string[], checklists?: ChecklistAck[], results?: ChecklistResult[]);
+    constructor(title: string, riskScore: number, riskLevel: string, riskEmoji: string, summary: string, violations: string[], risks: string[], filesToReview: string[], results?: ChecklistResult[]);
 }
 export declare const CK_PASS = "pass";
 export declare const CK_OVERRIDDEN = "overridden";
 export declare const CK_FAIL = "fail";
 export declare const CK_MISSING = "missing";
-export declare const CK_ACKED = "acknowledged";
 export declare class ChecklistVerdict {
     id: string;
     status: string;
@@ -54,18 +43,13 @@ export declare class ReviewJsonService {
     private requiredChecklistHint;
     /**
      * Load + validate the AI-authored review.json. Throws InformAiError (with the schema) when missing,
-     * unparseable, or structurally wrong. Returns a fully-populated ReviewJson on success.
-     *
-     * `required` is the set of consumer checklists the diff triggered (empty for non-adopting repos, in
-     * which case this behaves byte-identically to before the feature). Every BLOCK entry must appear in
-     * review.json's `checklists[]` with `acknowledged: true`, or a validation error is raised alongside
-     * the usual ones so the AI gets ONE message. WARN entries are never validated; unknown ids in
-     * `checklists[]` are ignored (forward-compat).
+     * unparseable, or structurally wrong. `required` is the set of checklists the diff matched: every one
+     * must have a well-formed, passing (or overridden) review-<id>.json or a validation error is raised
+     * alongside the usual ones so the AI gets ONE message.
      */
     loadReviewJson(filePath: string, required?: readonly RequiredChecklist[]): ReviewJson;
-    private parseChecklistAcks;
     loadChecklistResults(reviewJsonFilePath: string, required: readonly RequiredChecklist[]): ChecklistResult[];
-    resolveVerdict(req: RequiredChecklist, acks: readonly ChecklistAck[], results: readonly ChecklistResult[]): ChecklistVerdict;
+    resolveVerdict(req: RequiredChecklist, results: readonly ChecklistResult[]): ChecklistVerdict;
     private requiredChecklistErrors;
     private checklistFileName;
     private parseChecklistResult;

package/src/review-json.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ReviewJsonService = exports.ChecklistVerdict = exports.CK_ACKED = exports.CK_MISSING = exports.CK_FAIL = exports.CK_OVERRIDDEN = exports.CK_PASS = exports.ReviewJson = exports.RequiredChecklist = exports.ChecklistResult = exports.ChecklistAck = void 0;
+exports.ReviewJsonService = exports.ChecklistVerdict = exports.CK_MISSING = exports.CK_FAIL = exports.CK_OVERRIDDEN = exports.CK_PASS = exports.ReviewJson = exports.RequiredChecklist = exports.ChecklistResult = void 0;
 exports.prDirFor = prDirFor;
 exports.reviewJsonPath = reviewJsonPath;
 exports.reviewJsonSchemaHint = reviewJsonSchemaHint;
@@ -10,34 +10,20 @@ const fs = tslib_1.__importStar(require("fs"));
 const path = tslib_1.__importStar(require("path"));
 const inversify_1 = require("inversify");
 const constants_1 = require("./constants");
-const checklist_config_1 = require("./checklist-config");
 const inform_ai_error_1 = require("./inform-ai-error");
 const to_error_1 = require("./to-error");
-// One entry the AI writes into review.json's `checklists[]`: "I read the doc for <id> and walked it".
-// acknowledged: true is the AI attesting it did the walk — a SURFACING/AUDIT signal, not authorization.
-class ChecklistAck {
-    id;
-    acknowledged;
-    notes; // per-item findings the AI chose to record (optional; [] when none)
-    constructor(id, acknowledged, notes) {
-        this.id = id;
-        this.acknowledged = acknowledged;
-        this.notes = notes;
-    }
-}
-exports.ChecklistAck = ChecklistAck;
-// The verdict a reviewer wrote into a PER-CHECKLIST file `.webpieces/pr-review/<branch>/review-<id>.json`,
-// one per triggered checklist. Replaces the single shared `checklists[]` array so concurrent reviewer
-// subagents never clobber one file. Unlike ChecklistAck's bare boolean, this records the OUTCOME:
+// The verdict a reviewer SUBAGENT writes into `.webpieces/pr-review/<branch>/review-<id>.json`, one per
+// matched checklist. One file per checklist so N concurrent reviewer subagents never clobber a shared
+// file. It records the OUTCOME:
 //   success:true                       → PASS
 //   success:false + override non-empty → OVERRIDDEN (pass; the free-text justification reaches the PR)
 //   success:false + no override        → FAIL (refuse; `output` is printed verbatim)
-// `override` is deliberately free text, not a boolean — it forces the bypass to be stated in words and
-// surfaces it on the dashboard, where a human sees it. Data-only (per CLAUDE.md).
+// `override` is deliberately free text, not a boolean — it forces the ship-anyway decision to be stated
+// in words and surfaces it on the dashboard, where a human sees it. Data-only (per CLAUDE.md).
 class ChecklistResult {
     id;
     success;
-    output; // what the reviewer found; printed verbatim when a BLOCK checklist fails
+    output; // what the reviewer found; printed verbatim when the checklist fails
     override; // '' = no override; non-empty = ship-anyway justification (renders 🟡 overridden)
     constructor(id, success, output, override) {
         this.id = id;
@@ -47,31 +33,25 @@ class ChecklistResult {
     }
 }
 exports.ChecklistResult = ChecklistResult;
-// What the CALLER (the pr-gate command) computed from the diff: the checklists this branch triggered.
-// Drives BOTH review.json validation (BLOCK must be acknowledged) AND the printed schema hint (so the
-// AI is told, at the moment it writes review.json, exactly which docs to read). Data-only.
+// What the pr-gate command computed from the diff: a checklist this branch MATCHED (its patterns hit the
+// diff, so its reviewer subagent must run). Drives review-<id>.json enforcement, provenance, the schema
+// hint, and the dashboard. Data-only.
 class RequiredChecklist {
-    id;
-    title;
-    severity; // 'BLOCK' | 'WARN'
-    docs;
-    blockMessage;
-    matchedFiles; // the changed files that triggered it (for the dashboard + hint)
-    subagent; // expected reviewer agentType ('' = no provenance requirement); enforced by finish
-    // eslint-disable-next-line @typescript-eslint/max-params
-    constructor(id, title, severity, docs, blockMessage, matchedFiles, subagent = '') {
+    id; // = subagent name; keys review-<id>.json
+    subagent; // reviewer agent that must run (agentType the harness stamps)
+    doc; // guidance doc the reviewer reads ('' → it reads the manifest doc)
+    matchedFiles; // the changed files that matched it (for the dashboard + hint)
+    constructor(id, subagent, doc, matchedFiles) {
         this.id = id;
-        this.title = title;
-        this.severity = severity;
-        this.docs = docs;
-        this.blockMessage = blockMessage;
-        this.matchedFiles = matchedFiles;
         this.subagent = subagent;
+        this.doc = doc;
+        this.matchedFiles = matchedFiles;
     }
 }
 exports.RequiredChecklist = RequiredChecklist;
-// The AI-authored review for a PR. The AI writes this file itself between `wp-start-upsert-pr` (which
-// prints the schema) and `wp-finish-upsert-pr` (which reads it). Data-only (per CLAUDE.md).
+// The AI-authored review for a PR. The AI writes review.json itself between `wp-start-upsert-pr` (which
+// prints the schema) and `wp-finish-upsert-pr` (which reads it); reviewer subagents write the per-checklist
+// review-<id>.json files. Data-only (per CLAUDE.md).
 class ReviewJson {
     title; // human PR title describing the change; used as the `gh pr` title (empty → caller falls back)
     riskScore; // 0–100, drives the risk bar
@@ -81,10 +61,9 @@ class ReviewJson {
     violations; // pattern/architecture violations; length = the Pattern Violations count
     risks;
     filesToReview;
-    checklists; // legacy inline acknowledgments (back-compat); [] when none written
     results; // resolved per-checklist verdicts (from review-<id>.json); [] when none
     // eslint-disable-next-line @typescript-eslint/max-params
-    constructor(title, riskScore, riskLevel, riskEmoji, summary, violations, risks, filesToReview, checklists = [], results = []) {
+    constructor(title, riskScore, riskLevel, riskEmoji, summary, violations, risks, filesToReview, results = []) {
         this.title = title;
         this.riskScore = riskScore;
         this.riskLevel = riskLevel;
@@ -93,7 +72,6 @@ class ReviewJson {
         this.violations = violations;
         this.risks = risks;
         this.filesToReview = filesToReview;
-        this.checklists = checklists;
         this.results = results;
     }
 }
@@ -102,12 +80,11 @@ exports.ReviewJson = ReviewJson;
 exports.CK_PASS = 'pass'; // review-<id>.json success:true
 exports.CK_OVERRIDDEN = 'overridden'; // review-<id>.json success:false + non-empty override → 🟡
 exports.CK_FAIL = 'fail'; // review-<id>.json success:false + no override → refuse
-exports.CK_MISSING = 'missing'; // no verdict file and no inline ack → refuse (BLOCK)
-exports.CK_ACKED = 'acknowledged'; // legacy inline checklists[] ack satisfied (back-compat)
+exports.CK_MISSING = 'missing'; // no review-<id>.json written → refuse
 class ChecklistVerdict {
     id;
-    status; // one of CK_PASS | CK_OVERRIDDEN | CK_FAIL | CK_MISSING | CK_ACKED
-    detail; // reviewer output / override justification / ack notes (for the dashboard + errors)
+    status; // one of CK_PASS | CK_OVERRIDDEN | CK_FAIL | CK_MISSING
+    detail; // reviewer output / override justification (for the dashboard + errors)
     constructor(id, status, detail) {
         this.id = id;
         this.status = status;
@@ -127,11 +104,9 @@ let ReviewJsonService = class ReviewJsonService {
     reviewJsonPath(repoRoot, featureName) {
         return path.join(this.prDirFor(repoRoot, featureName), 'review.json');
     }
-    // Copy-paste schema both commands print (write it / fix it). `required` is the set of consumer
-    // checklists the diff triggered; when it is empty the output is byte-identical to before this
-    // feature existed (non-adopting repos see no change). When non-empty it grows a `checklists` line
-    // in the JSON shape PLUS an instruction block naming the docs to read — diff-derived instructions
-    // injected at exactly the moment the AI writes review.json.
+    // Copy-paste schema both commands print. `required` is the set of checklists the diff MATCHED; empty
+    // ⇒ output identical to a repo with no checklists. Non-empty ⇒ appends per-checklist instructions
+    // naming the reviewer subagent + doc + the review-<id>.json to write.
     reviewJsonSchemaHint(filePath, required = []) {
         return (`Write your PR review to:\n  ${filePath}\n\n` +
             `with this exact JSON shape (riskEmoji optional — derived from riskLevel):\n\n` +
@@ -150,44 +125,33 @@ let ReviewJsonService = class ReviewJsonService {
     checklistResultPath(reviewJsonFilePath, checklistId) {
         return path.join(path.dirname(reviewJsonFilePath), `review-${checklistId}.json`);
     }
-    // The diff-triggered instruction block, appended ONLY when the branch triggered a checklist. This is
-    // the consumer's review process, re-injected: read doc Y because the diff touched X, then write ONE
-    // file per checklist — `review-<id>.json` — so concurrent reviewer subagents never clobber a shared
-    // file. A BLOCK checklist with success:false and no override refuses to open the PR.
+    // The matched-checklist instruction block, appended ONLY when the diff matched a checklist. Each matched
+    // checklist must be reviewed by its OWN subagent (a distinct one), which writes review-<id>.json.
     requiredChecklistHint(reviewJsonFilePath, required) {
         if (required.length === 0)
             return '';
-        const lines = ['', '', 'This branch triggered company review checklist(s). For EACH one below: READ its docs, walk'];
-        lines.push('the items against your diff, then write a SEPARATE file `review-<id>.json` beside review.json');
-        lines.push('with this shape (override optional — a free-text ship-anyway justification):');
+        const lines = ['', '', 'This diff MATCHED company review checklist(s). Spawn EACH named subagent as a SEPARATE'];
+        lines.push('subagent (a different one per checklist — the coding agent may NOT self-certify). Each reads its');
+        lines.push('doc + the diff and writes its own review-<id>.json with this shape:');
         lines.push('');
-        lines.push('  { "success": true, "output": "what you checked / what you found", "override": "" }');
+        lines.push('  { "id": "<id>", "success": true, "output": "what you checked / found", "override": "" }');
+        lines.push('  (success:false with no non-empty "override" refuses the PR; a non-empty override ships it 🟡.)');
         lines.push('');
         for (const req of required) {
-            const gate = req.severity === checklist_config_1.CHECKLIST_BLOCK
-                ? 'BLOCK — success:false with no "override" will NOT open the PR'
-                : 'WARN — recorded on the dashboard; never blocks';
-            lines.push(`  • [${req.id}] ${req.title} (${gate})`);
+            lines.push(`  • [${req.id}] reviewer subagent: ${req.subagent}`);
             lines.push(`      write: ${this.checklistResultPath(reviewJsonFilePath, req.id)}`);
-            lines.push(`      docs to read: ${req.docs.join(', ')}`);
-            if (req.subagent.trim() !== '')
-                lines.push(`      must be reviewed by the "${req.subagent.trim()}" subagent (its independent run is verified from the harness).`);
-            if (req.blockMessage.trim() !== '')
-                lines.push(`      ${req.blockMessage.trim()}`);
+            if (req.doc.trim() !== '')
+                lines.push(`      doc to read: ${req.doc}`);
             if (req.matchedFiles.length > 0)
-                lines.push(`      triggered by: ${req.matchedFiles.slice(0, 5).join(', ')}`);
+                lines.push(`      matched: ${req.matchedFiles.slice(0, 5).join(', ')}`);
         }
         return lines.join('\n');
     }
     /**
      * Load + validate the AI-authored review.json. Throws InformAiError (with the schema) when missing,
-     * unparseable, or structurally wrong. Returns a fully-populated ReviewJson on success.
-     *
-     * `required` is the set of consumer checklists the diff triggered (empty for non-adopting repos, in
-     * which case this behaves byte-identically to before the feature). Every BLOCK entry must appear in
-     * review.json's `checklists[]` with `acknowledged: true`, or a validation error is raised alongside
-     * the usual ones so the AI gets ONE message. WARN entries are never validated; unknown ids in
-     * `checklists[]` are ignored (forward-compat).
+     * unparseable, or structurally wrong. `required` is the set of checklists the diff matched: every one
+     * must have a well-formed, passing (or overridden) review-<id>.json or a validation error is raised
+     * alongside the usual ones so the AI gets ONE message.
      */
     // webpieces-disable max-lines-new-methods -- one cohesive load+validate pass over the review fields
     loadReviewJson(filePath, required = []) {
@@ -212,9 +176,8 @@ let ReviewJsonService = class ReviewJsonService {
         if (title === '') {
             errors.push('"title" must be a non-empty, imperative PR title describing the change (no branch names).');
         }
-        const acks = this.parseChecklistAcks(raw['checklists']);
         const results = this.loadChecklistResults(filePath, required);
-        for (const err of this.requiredChecklistErrors(required, acks, results))
+        for (const err of this.requiredChecklistErrors(required, results))
             errors.push(err);
         if (errors.length > 0) {
             throw new inform_ai_error_1.InformAiError(`review.json has ${errors.length} error(s) — fix ALL, then re-run pnpm wp-finish-upsert-pr:\n\n` +
@@ -226,32 +189,11 @@ let ReviewJsonService = class ReviewJsonService {
             ? raw['riskEmoji']
             : (EMOJI_FOR_LEVEL[level] ?? '🟡');
         const summary = typeof raw['summary'] === 'string' ? raw['summary'] : '';
-        return new ReviewJson(title, riskScore, level, emoji, summary, this.asStringArray(raw['violations']), this.asStringArray(raw['risks']), this.asStringArray(raw['filesToReview']), acks, results);
+        return new ReviewJson(title, riskScore, level, emoji, summary, this.asStringArray(raw['violations']), this.asStringArray(raw['risks']), this.asStringArray(raw['filesToReview']), results);
     }
-    // Parse the AI-authored `checklists[]` into typed ChecklistAck[]. Tolerant of a missing/garbage
-    // field (→ []) and of non-object entries (skipped) — malformed acks simply fail to satisfy a BLOCK
-    // requirement rather than crashing the load.
-    // webpieces-disable no-any-unknown -- opaque parsed JSON value, narrowed here
-    parseChecklistAcks(value) {
-        if (!Array.isArray(value))
-            return [];
-        const acks = [];
-        for (const entry of value) {
-            if (typeof entry !== 'object' || entry === null || Array.isArray(entry))
-                continue;
-            // webpieces-disable no-any-unknown -- one opaque ack entry, narrowed field-by-field
-            const e = entry;
-            const id = typeof e['id'] === 'string' ? e['id'] : '';
-            if (id === '')
-                continue;
-            acks.push(new ChecklistAck(id, e['acknowledged'] === true, this.asStringArray(e['notes'])));
-        }
-        return acks;
-    }
-    // Read the per-checklist verdict files `review-<id>.json` that sit beside review.json — one per
-    // triggered checklist. Tolerant like parseChecklistAcks: a missing file is simply absent from the
-    // result (→ falls back to the inline ack / counts as unmet for a BLOCK), and a malformed one is
-    // skipped (an unknown/stale review-<id>.json never wedges the branch).
+    // Read the per-checklist verdict files `review-<id>.json` beside review.json — one per matched checklist.
+    // A missing file is simply absent from the result (→ counts as MISSING for that checklist); a malformed
+    // one is skipped (a stale review-<id>.json never wedges the branch).
     loadChecklistResults(reviewJsonFilePath, required) {
         const results = [];
         for (const req of required) {
@@ -264,42 +206,33 @@ let ReviewJsonService = class ReviewJsonService {
         }
         return results;
     }
-    // Resolve ONE checklist's verdict from its per-file result (preferred) or its legacy inline ack.
-    // Central so review.json enforcement AND the finish-command dashboard agree on the outcome.
-    resolveVerdict(req, acks, results) {
+    // Resolve ONE checklist's verdict from its review-<id>.json. Central so review.json enforcement AND the
+    // finish-command dashboard agree on the outcome.
+    resolveVerdict(req, results) {
         const result = results.find((r) => r.id === req.id);
-        if (result) {
-            if (result.success)
-                return new ChecklistVerdict(req.id, exports.CK_PASS, result.output);
-            if (result.override.trim() !== '')
-                return new ChecklistVerdict(req.id, exports.CK_OVERRIDDEN, result.override.trim());
-            return new ChecklistVerdict(req.id, exports.CK_FAIL, result.output);
-        }
-        const ack = acks.find((a) => a.id === req.id);
-        if (ack && ack.acknowledged)
-            return new ChecklistVerdict(req.id, exports.CK_ACKED, ack.notes.join('; '));
-        return new ChecklistVerdict(req.id, exports.CK_MISSING, '');
+        if (!result)
+            return new ChecklistVerdict(req.id, exports.CK_MISSING, '');
+        if (result.success)
+            return new ChecklistVerdict(req.id, exports.CK_PASS, result.output);
+        if (result.override.trim() !== '')
+            return new ChecklistVerdict(req.id, exports.CK_OVERRIDDEN, result.override.trim());
+        return new ChecklistVerdict(req.id, exports.CK_FAIL, result.output);
     }
-    // BLOCK requirements whose verdict is FAIL (reviewed, found a problem, no override) or MISSING (no
-    // verdict written at all) → one error each. WARN never blocks. Uses the consumer's blockMessage /
-    // the reviewer's `output` verbatim so the consumer owns the wording and webpieces owns the mechanism.
-    requiredChecklistErrors(required, acks, results) {
+    // Every matched checklist whose verdict is FAIL (reviewed, found a problem, no override) or MISSING (no
+    // review-<id>.json written) → one error each, printing the reviewer's `output` verbatim.
+    requiredChecklistErrors(required, results) {
         const errors = [];
         for (const req of required) {
-            if (req.severity !== checklist_config_1.CHECKLIST_BLOCK)
-                continue;
-            const verdict = this.resolveVerdict(req, acks, results);
+            const verdict = this.resolveVerdict(req, results);
             if (verdict.status === exports.CK_FAIL) {
-                const msg = req.blockMessage.trim() !== '' ? `${req.blockMessage.trim()} ` : '';
-                errors.push(`Checklist "${req.id}" (${req.title}) FAILED review. ${msg}` +
-                    `The reviewer wrote:\n      ${verdict.detail.split('\n').join('\n      ')}\n` +
+                errors.push(`Checklist "${req.id}" FAILED review. The reviewer (${req.subagent}) wrote:\n      ` +
+                    `${verdict.detail.split('\n').join('\n      ')}\n` +
                     `      Fix it, then re-run; or set a non-empty "override" in ${this.checklistFileName(req.id)} to ship anyway with a stated justification.`);
             }
             else if (verdict.status === exports.CK_MISSING) {
-                const docs = req.docs.length > 0 ? ` Read: ${req.docs.join(', ')}.` : '';
-                const msg = req.blockMessage.trim() !== '' ? `${req.blockMessage.trim()} ` : '';
-                errors.push(`Checklist "${req.id}" (${req.title}) is REQUIRED for this diff but has no verdict. ${msg}` +
-                    `Write ${this.checklistFileName(req.id)} with {"success":true,"output":"…"} once you have walked it.${docs}`);
+                const doc = req.doc.trim() !== '' ? ` Read: ${req.doc}.` : '';
+                errors.push(`Checklist "${req.id}" MATCHED this diff but has no verdict. Spawn the "${req.subagent}" subagent to review it, ` +
+                    `then write ${this.checklistFileName(req.id)} with {"id":"${req.id}","success":true,"output":"…"}.${doc}`);
             }
         }
         return errors;
@@ -337,8 +270,7 @@ let ReviewJsonService = class ReviewJsonService {
         return value.filter((v) => typeof v === 'string');
     }
     // Parse opaque AI-authored JSON, converting a SyntaxError into a readable InformAiError. `required`
-    // is threaded through so a JSON syntax error still prints the checklist instructions the AI needs —
-    // exactly when it most needs them — rather than the bare schema.
+    // is threaded through so a JSON syntax error still prints the checklist instructions the AI needs.
     // webpieces-disable no-any-unknown -- returns the opaque parsed object; loadReviewJson narrows each field
     parseReviewJson(raw, filePath, required) {
         // webpieces-disable no-unmanaged-exceptions -- chokepoint: convert JSON.parse SyntaxError to an InformAiError for the AI