@webpieces/pr-gate 0.4.564 → 0.4.565

package/src/scripts/workflow/review-report.js.map

@@ -1 +1 @@
-{"version":3,"file":"review-report.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/review-report.ts"],"names":[],"mappings":";;;;AAAA,yCAA2D;AAC3D,0DAAiI;AACjI,yDAAqD;AAErD,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE;;;;;;;;;;;;GAYG;AACH,MAAa,eAAe;IACxB,WAAW,CAAS;IACpB,OAAO,CAAS;IAEhB,YAAY,WAAmB,EAAE,OAAe;QAC5C,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAC/B,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;IAC3B,CAAC;CACJ;AARD,0CAQC;AAED;;;;GAIG;AACH,MAAa,iBAAiB;IAC1B,QAAQ,CAAS;IACjB,WAAW,CAAS;IACpB,UAAU,CAAS,CAAa,6DAA6D;IAC7F,YAAY,CAAS,CAAW,iDAAiD;IACjF,eAAe,CAAS,CAAQ,yEAAyE;IACzG,QAAQ,CAAsB,CAAE,gDAAgD;IAChF,YAAY,CAAW,CAAS,0DAA0D;IAC1F,SAAS,CAAqB,CAAE,wDAAwD;IACxF,OAAO,CAAoB,CAAK,6EAA6E;IAE7G,YAAY,QAAgB,EAAE,WAAmB,EAAE,UAAkB;QACjE,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAC/B,IAAI,CAAC,UAAU,GAAG,UAAU,CAAC;QAC7B,IAAI,CAAC,YAAY,GAAG,CAAC,CAAC;QACtB,IAAI,CAAC,eAAe,GAAG,CAAC,CAAC;QACzB,IAAI,CAAC,QAAQ,GAAG,EAAE,CAAC;QACnB,IAAI,CAAC,YAAY,GAAG,EAAE,CAAC;QACvB,IAAI,CAAC,SAAS,GAAG,EAAE,CAAC;QACpB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;IACtB,CAAC;CACJ;AAtBD,8CAsBC;AAED;;;;;;;;;;;;;;;;;GAiBG;AAEI,IAAM,YAAY,GAAlB,MAAM,YAAY;IAEA;IACA;IAFrB,YACqB,eAAgC,EAChC,oBAAiD;QADjD,oBAAe,GAAf,eAAe,CAAiB;QAChC,yBAAoB,GAApB,oBAAoB,CAA6B;IACnE,CAAC;IAEJ,MAAM,CAAC,KAAwB;QAC3B,OAAO,IAAI,GAAG,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,GAAG,GAAG;cACtC,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC;cACvB,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;IAChC,CAAC;IAED,oGAAoG;IACpG,qGAAqG;IACrG,wGAAwG;IACxG,oGAAoG;IAC5F,MAAM,CAAC,KAAwB;QACnC,IAAI,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,yBAAyB,CAAC;QAC7E,OAAO,mDAAmD,CAAC;IAC/D,CAAC;IAED;;;;OAIG;IACK,WAAW,CAAC,KAAwB;QACxC,IAAI,KAAK,CAAC,eAAe,KAAK,CAAC;YAAE,OAAO,IAAI,GAAG,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;QAC9F,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,KAAK,MAAM,CAAC,IAAI,KAAK,CAAC,QAAQ,EAAE,CAAC;YAC7B,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,QAAQ,0DAA0D,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;QACxG,CAAC;QACD,gGAAgG;QAChG,kGAAkG;QAClG,2CAA2C;QAC3C,KAAK,MAAM,CAAC,IAAI,KAAK,CAAC,YAAY;YAAE,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAC3D,IAAI,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzC,KAAK,CAAC,IAAI,CAAC,EAAE,EAAE,wEAAwE,CAAC,CAAC;QAC7F,CAAC;QACD,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAClC,OAAO,IAAI,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC;IAC1C,CAAC;IAED;;;;;;;;;;;;;;;;;;;OAmBG;IACK,SAAS,CAAC,KAAwB;QACtC,MAAM,IAAI,GAAG,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC;QACvC,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QAC5C,OAAO,IAAI,GAAG,GAAG;cACX,YAAY,SAAS,kDAAkD,GAAG,GAAG,GAAG,IAAI;cACpF,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,UAAU,CAAC;cACtC,IAAI,CAAC,SAAS,CAAC,KAAK,EAAE,IAAI,CAAC;cAC3B,IAAI,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC;IACrC,CAAC;IAEO,eAAe,CAAC,UAAkB;QACtC,OAAO,CACH,mGAAmG;YACnG,8FAA8F;YAC9F,kGAAkG;YAClG,oGAAoG;YACpG,6FAA6F;YAC7F,IAAA,mCAAoB,EAAC,UAAU,CAAC,GAAG,MAAM,CAC5C,CAAC;IACN,CAAC;IAED;;;;;OAKG;IACK,SAAS,CAAC,KAAwB,EAAE,IAAiC;QACzE,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACjC,MAAM,KAAK,GAAa;YACpB,wDAAwD,IAAI,CAAC,MAAM,oCAAoC;YACvG,kGAAkG;YAClG,8BAA8B;YAC9B,EAAE;SACL,CAAC;QACF,sGAAsG;QACtG,uFAAuF;QACvF,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC3B,KAAK,CAAC,IAAI,CACN,YAAY,KAAK,CAAC,OAAO,CAAC,MAAM,sEAAsE,EACtG,iGAAiG,EACjG,EAAE,CAAC,CAAC;QACZ,CAAC;QACD,KAAK,MAAM,CAAC,IAAI,IAAI;YAAE,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC;QAClE,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5B,CAAC;IAEO,UAAU,CAAC,UAAkB;QACjC,MAAM,YAAY,GAAG,UAAU,KAAK,CAAC;YACjC,CAAC,CAAC,wDAAwD;YAC1D,CAAC,CAAC,uBAAuB,CAAC;QAC9B,OAAO,CACH,QAAQ,UAAU,WAAW,YAAY,oCAAoC;YAC7E,sGAAsG,CACzG,CAAC;IACN,CAAC;IAED,sGAAsG;IACtG,yGAAyG;IACjG,aAAa,CAAC,KAAwB;QAC1C,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QACxF,OAAO,KAAK,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAAmB,EAAW,EAAE,CAAC,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC;IACrG,CAAC;IAED;;;;;;;;;OASG;IACK,aAAa,CAAC,KAAwB,EAAE,CAAmB;QAC/D,MAAM,gBAAgB,GAAG,IAAI,CAAC,oBAAoB,CAAC,OAAO,CAAC,KAAK,CAAC,QAAQ,EAAE,KAAK,CAAC,WAAW,EAAE,CAAC,CAAC,QAAQ,CAAC,CAAC;QAC1G,OAAO;YACH,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,EAAE,CAAC,CAAC;YACxB,wBAAwB,CAAC,CAAC,QAAQ,EAAE;YACpC,+EAA+E;YAC/E,wBAAwB,gBAAgB,EAAE;YAC1C,EAAE;SACL,CAAC;IACN,CAAC;IAED,mGAAmG;IACnG,uFAAuF;IAC/E,MAAM,CAAC,KAAwB,EAAE,CAAmB;QACxD,MAAM,OAAO,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAkB,EAAW,EAAE,CAAC,CAAC,CAAC,WAAW,KAAK,CAAC,CAAC,WAAW,CAAC,CAAC;QACrG,IAAI,CAAC,OAAO;YAAE,OAAO,CAAC,OAAO,CAAC,CAAC,QAAQ,MAAM,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;QAC5D,OAAO;YACH,OAAO,CAAC,CAAC,QAAQ,sFAAsF;YACvG,SAAS,OAAO,CAAC,OAAO,EAAE;YAC1B,iGAAiG;YACjG,8BAA8B;SACjC,CAAC;IACN,CAAC;IAED,sGAAsG;IACtG,+FAA+F;IACvF,GAAG,CAAC,CAAmB;QAC3B,IAAI,CAAC,CAAC,eAAe,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACjC,OAAO,iEAAiE,CAAC,CAAC,OAAO,CAAC,MAAM,UAAU,CAAC;QACvG,CAAC;QACD,OAAO,GAAG,CAAC,CAAC,OAAO,CAAC,MAAM,oBAAoB,CAAC,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;IACtH,CAAC;CACJ,CAAA;AA1KY,oCAAY;uBAAZ,YAAY;IADxB,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGC,kCAAe;QACV,0CAA2B;GAH7D,YAAY,CA0KxB","sourcesContent":["import { injectable, bindingScopeValues } from 'inversify';\nimport { reviewJsonSchemaHint, RequiredChecklist, ReviewerBriefing, ReviewerInstructionsService } from '@webpieces/rules-config';\nimport { ChecklistNotice } from './checklist-notice';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n/**\n * One reviewer that ALREADY ANSWERED on this branch and refused, with the refusal rendered by\n * `ReviewJsonService.refusalError` — the ONE wording, shared with `wp-finish-upsert-pr`. Data-only.\n *\n * Stage ② carries these because it had the same defect finish did: a refused checklist has no passing\n * verdict, so it is \"owed\", so it got an ordinary spawn block identical to a reviewer that never ran. An\n * agent obeys that block, the reviewer re-reads unchanged code, refuses again — the loop, one stage earlier.\n *\n * The message is rendered by the COMMAND rather than in here for one reason: stage ② must not archive\n * anything. `refusalError` called with no archive path says \"fix it, then re-run; or set an override in\n * review-<id>.json\", which is only true while that file is still live — and at stage ② it is. Retiring a\n * verdict is finish's act, on the refusal it is actually acting on.\n */\nexport class RefusedReviewer {\n    checklistId: string;\n    message: string;\n\n    constructor(checklistId: string, message: string) {\n        this.checklistId = checklistId;\n        this.message = message;\n    }\n}\n\n/**\n * Everything the closing block of `wp-review-upsert-pr` needs. Data-only, and a class rather than an\n * object literal per CLAUDE.md. The three identifying paths are constructor args; the rest are optional\n * facts about the scan that default to \"nothing\", so a repo with no checklists constructs it in one line.\n */\nexport class ReviewReportInput {\n    repoRoot: string;\n    featureName: string;\n    reviewPath: string;             // the branch's review.json — the file the AI must write next\n    definedCount: number;           // how many checklists pr-gate.checklists defines\n    applicableCount: number;        // how many of them apply to THIS diff (0 ⇒ the notice, not spawn blocks)\n    reviewed: RequiredChecklist[];  // already have a passing verdict on this branch\n    formatErrors: string[];         // verdict files that exist but cannot be read as verdicts\n    briefings: ReviewerBriefing[];  // one per applicable checklist, already written to disk\n    refused: RefusedReviewer[];     // of the owed ones, those that already ran and said no (see RefusedReviewer)\n\n    constructor(repoRoot: string, featureName: string, reviewPath: string) {\n        this.repoRoot = repoRoot;\n        this.featureName = featureName;\n        this.reviewPath = reviewPath;\n        this.definedCount = 0;\n        this.applicableCount = 0;\n        this.reviewed = [];\n        this.formatErrors = [];\n        this.briefings = [];\n        this.refused = [];\n    }\n}\n\n/**\n * Renders the closing block of `wp-review-upsert-pr` — the checklist verdict, then EXACTLY ONE \"what to do\n * next\".\n *\n * Extracted from the command so it can be asserted on as a rendered string, because the ordering IS the\n * contract. The bug it was extracted to fix: the zero-checklist notice ended with \"Carry on and run: pnpm\n * wp-finish-upsert-pr\", and the block printed directly beneath it said to write review.json first and\n * finish afterwards. Two next-steps, in the wrong order, and an agent that follows instructions literally —\n * which is the entire reason this command prints them — took the first one and opened a PR with no review.\n * That is precisely the failure the three-stage flow exists to prevent (reported on PR #519).\n *\n * The invariants, enforced by review-report.spec.ts:\n *   1. `wp-finish-upsert-pr` is named as a thing to run EXACTLY ONCE in the whole block.\n *   2. The review.json instruction comes BEFORE it — and BEFORE the spawn blocks (see nextSteps).\n *   3. With zero checklists the all-clear precedes any configuration guidance.\n *\n * Pure string building, no I/O. `@injectable(bindingScopeValues.Singleton)` so it is injected by type.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewReport {\n    constructor(\n        private readonly checklistNotice: ChecklistNotice,\n        private readonly reviewerInstructions: ReviewerInstructionsService,\n    ) {}\n\n    render(input: ReviewReportInput): string {\n        return '\\n' + SEP + this.header(input) + SEP\n            + this.scanVerdict(input)\n            + this.nextSteps(input);\n    }\n\n    // Name what this block is actually about. A repo with reviewers owed is being told to SPAWN; a repo\n    // with none is not, and promising subagents it does not have is the same kind of noise as explaining\n    // checklist configuration to a repo that configured none. Keyed on what is actually OWED rather than on\n    // the applicable count: every applicable checklist already having a verdict means nothing to spawn.\n    private header(input: ReviewReportInput): string {\n        if (this.owedReviewers(input).length === 0) return '② Review, then finish\\n';\n        return '② Review, spawn subagent reviewers, then finish\\n';\n    }\n\n    /**\n     * What the SCAN found: either \"nothing applies here\" or the already-reviewed / unreadable-verdict lines.\n     * Verdicts, not instructions — every instruction lives in nextSteps() below, so no line up here can be\n     * mistaken for the next action.\n     */\n    private scanVerdict(input: ReviewReportInput): string {\n        if (input.applicableCount === 0) return '\\n' + this.checklistNotice.build(input.definedCount);\n        const lines: string[] = [];\n        for (const r of input.reviewed) {\n            lines.push(`  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)`);\n        }\n        // A verdict file that EXISTS but is unreadable as a verdict is called out here. Without it this\n        // reports the checklist as simply owed, and the AI re-runs a reviewer that already ran instead of\n        // correcting the file sitting right there.\n        for (const e of input.formatErrors) lines.push(`  ⛔ ${e}`);\n        if (this.owedReviewers(input).length === 0) {\n            lines.push('', '✅ Every checklist that applies is already reviewed — nothing to spawn.');\n        }\n        if (lines.length === 0) return '';\n        return '\\n' + lines.join('\\n') + '\\n';\n    }\n\n    /**\n     * The ONE instruction block, and the last thing the stage prints. Numbered rather than prose-linked\n     * (\"Then… Finally…\") so that skipping step 1 is visibly skipping a step, and worded so no earlier line\n     * can be mistaken for the real next action.\n     *\n     * review.json is STEP 1 and the spawn blocks are STEP 2 — that ORDER is the contract, not a preference.\n     * This block used to print the spawn blocks first and then say to write review.json \"WHILE any reviewer\n     * subagents above are still running\", which does not merely permit spawning first, it instructs it.\n     * Harmless for a reviewer that only reads the diff; wrong for one that judges the PR's stated INTENT —\n     * its title, summary or risk level — because review.json is the only place that intent lives. Such a\n     * reviewer either finds no file (a false RED and a wasted reviewer run) or, on a second run of this\n     * stage on the same branch, finds the PREVIOUS run's file and validates a title that no longer exists —\n     * a false GREEN, with nothing in the output saying which of the two happened. A consuming repo had to\n     * write itself a rule telling its agents to DISOBEY this block to work around it.\n     *\n     * What the old ordering bought was overlap on a single local file write, not a subagent round-trip.\n     *\n     * The schema hint is rendered by ReviewJsonService — the single renderer — so the shape printed here\n     * can never drift from the shape `wp-finish-upsert-pr` validates.\n     */\n    private nextSteps(input: ReviewReportInput): string {\n        const owed = this.owedReviewers(input);\n        const stepCount = owed.length === 0 ? 2 : 3;\n        return '\\n' + SEP\n            + `▶ NEXT — ${stepCount} steps, in this order. Step 1 is NOT optional:\\n` + SEP + '\\n'\n            + this.writeReviewStep(input.reviewPath)\n            + this.spawnStep(input, owed)\n            + this.finishStep(stepCount);\n    }\n\n    private writeReviewStep(reviewPath: string): string {\n        return (\n            'STEP 1 — review your own changes, then write the review file. Write it FIRST — BEFORE you spawn\\n' +\n            '         anything below. finish REFUSES without it, and a reviewer subagent may READ it: a\\n' +\n            '         checklist that judges the PR title, summary or risk level reads exactly this file, so\\n' +\n            '         writing it afterwards races that reviewer into seeing nothing — or, on a re-run of this\\n' +\n            '         stage, into judging the PREVIOUS run\\'s review of code that has since changed.\\n\\n' +\n            reviewJsonSchemaHint(reviewPath) + '\\n\\n'\n        );\n    }\n\n    /**\n     * STEP 2 — one copy-paste block per owed reviewer, and nothing at all when none is owed. The prompt is\n     * deliberately a POINTER and nothing else: the generated instructions file is the contract, so anything\n     * restated here is a second copy that can go stale — which is exactly how a removed `success` field\n     * outlived its own removal in print.\n     */\n    private spawnStep(input: ReviewReportInput, owed: readonly ReviewerBriefing[]): string {\n        if (owed.length === 0) return '';\n        const lines: string[] = [\n            `STEP 2 — only once that file is written, spawn these ${owed.length} reviewer subagent(s) — a SEPARATE`,\n            '         one each. You may NOT review your own work, and you may NOT write a reviewer\\'s verdict',\n            '         file on its behalf.',\n            '',\n        ];\n        // Said up front, not only beside the block: an agent that has decided to spawn everything listed here\n        // needs to know BEFORE it starts that one of these entries is not a spawn-shaped task.\n        if (input.refused.length > 0) {\n            lines.push(\n                `         ${input.refused.length} of them already ANSWERED and refused (marked ⛔ below). Do not spawn`,\n                '         those against unchanged code — fix what they found first; the fix is the prerequisite.',\n                '');\n        }\n        for (const b of owed) lines.push(...this.oneSpawnBlock(input, b));\n        lines.push('');\n        return lines.join('\\n');\n    }\n\n    private finishStep(stepNumber: number): string {\n        const precondition = stepNumber === 3\n            ? 'once every reviewer above has written its verdict file'\n            : 'once that file exists';\n        return (\n            `STEP ${stepNumber} — only ${precondition}, run:  pnpm wp-finish-upsert-pr\\n` +\n            '         (The build gate is already green for this commit — finish reuses it unless HEAD moves.)\\n\\n'\n        );\n    }\n\n    // The briefings with no passing verdict yet — the ONE definition of \"owed\", shared by the header, the\n    // scan verdict and the step numbering, so they cannot disagree about whether there is anything to spawn.\n    private owedReviewers(input: ReviewReportInput): ReviewerBriefing[] {\n        const reviewedIds = new Set(input.reviewed.map((r: RequiredChecklist): string => r.id));\n        return input.briefings.filter((b: ReviewerBriefing): boolean => !reviewedIds.has(b.checklistId));\n    }\n\n    /**\n     * One reviewer's block. A reviewer that already REFUSED gets the SAME spawn coordinates but a different\n     * lead-in, because the action before spawning is different: its own words are printed, and the spawn is\n     * explicitly conditioned on having fixed the finding first.\n     *\n     * It keeps its spawn block rather than being dropped from the list, because the reviewer genuinely does\n     * still owe a fresh verdict — dropping it would leave nothing anywhere saying how to get one. What must\n     * not happen is a bare \"spawn this\" that reads identically to a reviewer that never ran, which is the\n     * loop this exists to break.\n     */\n    private oneSpawnBlock(input: ReviewReportInput, b: ReviewerBriefing): string[] {\n        const instructionsFile = this.reviewerInstructions.pathFor(input.repoRoot, input.featureName, b.subagent);\n        return [\n            ...this.leadIn(input, b),\n            `      subagent_type: ${b.subagent}`,\n            '      prompt:        Read your instructions file FIRST and follow it exactly:',\n            `                     ${instructionsFile}`,\n            '',\n        ];\n    }\n\n    // The lines above the spawn coordinates: normally just why this reviewer is in scope; for one that\n    // already refused, its verdict verbatim plus the order the two actions must happen in.\n    private leadIn(input: ReviewReportInput, b: ReviewerBriefing): string[] {\n        const refusal = input.refused.find((r: RefusedReviewer): boolean => r.checklistId === b.checklistId);\n        if (!refusal) return [`  ▶ ${b.subagent} — ${this.why(b)}`];\n        return [\n            `  ⛔ ${b.subagent} — ALREADY REVIEWED THIS BRANCH AND REFUSED. It will refuse again on unchanged code.`,\n            `      ${refusal.message}`,\n            '      FIX THE FINDING FIRST (or record a human-authored override). ONLY THEN spawn it again, to',\n            '      write a fresh verdict:',\n        ];\n    }\n\n    // Why this one is in scope. A patternless checklist is NOT \"matched\" — it always runs, over the whole\n    // diff, and saying so is what tells a repo its checklist is firing on docs-only PRs by design.\n    private why(b: ReviewerBriefing): string {\n        if (b.matchedPatterns.length === 0) {\n            return `ALWAYS RUNS (no \"patterns\" configured), whole diff in scope — ${b.myFiles.length} file(s)`;\n        }\n        return `${b.myFiles.length} file(s) matched ${b.matchedPatterns.map((p: string): string => `\"${p}\"`).join(', ')}`;\n    }\n}\n"]}
+{"version":3,"file":"review-report.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/review-report.ts"],"names":[],"mappings":";;;;AAAA,yCAA2D;AAC3D,0DAAiI;AACjI,yDAAqD;AAErD,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE;;;;;;;;;;;;GAYG;AACH,MAAa,eAAe;IACxB,WAAW,CAAS;IACpB,OAAO,CAAS;IAEhB,YAAY,WAAmB,EAAE,OAAe;QAC5C,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAC/B,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;IAC3B,CAAC;CACJ;AARD,0CAQC;AAED;;;;GAIG;AACH,MAAa,iBAAiB;IAC1B,QAAQ,CAAS;IACjB,WAAW,CAAS;IACpB,UAAU,CAAS,CAAa,6DAA6D;IAC7F,YAAY,CAAS,CAAW,iDAAiD;IACjF,eAAe,CAAS,CAAQ,yEAAyE;IACzG,QAAQ,CAAsB,CAAE,gDAAgD;IAChF,YAAY,CAAW,CAAS,0DAA0D;IAC1F,SAAS,CAAqB,CAAE,wDAAwD;IACxF,OAAO,CAAoB,CAAK,6EAA6E;IAC7G;;;;OAIG;IACH,YAAY,CAAU;IAEtB,YAAY,QAAgB,EAAE,WAAmB,EAAE,UAAkB;QACjE,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAC/B,IAAI,CAAC,UAAU,GAAG,UAAU,CAAC;QAC7B,IAAI,CAAC,YAAY,GAAG,CAAC,CAAC;QACtB,IAAI,CAAC,eAAe,GAAG,CAAC,CAAC;QACzB,IAAI,CAAC,QAAQ,GAAG,EAAE,CAAC;QACnB,IAAI,CAAC,YAAY,GAAG,EAAE,CAAC;QACvB,IAAI,CAAC,SAAS,GAAG,EAAE,CAAC;QACpB,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;QAClB,IAAI,CAAC,YAAY,GAAG,KAAK,CAAC;IAC9B,CAAC;CACJ;AA7BD,8CA6BC;AAED;;;;;;;;;;;;;;;;;;;;GAoBG;AAEI,IAAM,YAAY,GAAlB,MAAM,YAAY;IAEA;IACA;IAFrB,YACqB,eAAgC,EAChC,oBAAiD;QADjD,oBAAe,GAAf,eAAe,CAAiB;QAChC,yBAAoB,GAApB,oBAAoB,CAA6B;IACnE,CAAC;IAEJ,MAAM,CAAC,KAAwB;QAC3B,OAAO,IAAI,GAAG,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,GAAG,GAAG;cACtC,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC;cACvB,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;IAChC,CAAC;IAED;;;;;;;;;;OAUG;IACK,MAAM,CAAC,KAAwB;QACnC,IAAI,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,mDAAmD,CAAC;QACpG,IAAI,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,uDAAuD,CAAC;QACzG,OAAO,yBAAyB,CAAC;IACrC,CAAC;IAED;;;;OAIG;IACK,WAAW,CAAC,KAAwB;QACxC,IAAI,KAAK,CAAC,eAAe,KAAK,CAAC;YAAE,OAAO,IAAI,GAAG,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;QAC9F,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,KAAK,MAAM,CAAC,IAAI,KAAK,CAAC,QAAQ,EAAE,CAAC;YAC7B,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,QAAQ,0DAA0D,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;QACxG,CAAC;QACD,gGAAgG;QAChG,kGAAkG;QAClG,2CAA2C;QAC3C,KAAK,MAAM,CAAC,IAAI,KAAK,CAAC,YAAY;YAAE,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAC3D,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,CAAC,CAAC;QACxC,IAAI,IAAI,CAAC,cAAc,CAAC,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC;YAAE,KAAK,CAAC,IAAI,CAAC,EAAE,EAAE,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC;QAClF,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAClC,OAAO,IAAI,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC;IAC1C,CAAC;IAED;;;;OAIG;IACK,YAAY,CAAC,KAAwB;QACzC,MAAM,OAAO,GAAG,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,CAAC;QACzC,IAAI,CAAC,KAAK,CAAC,YAAY,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAC3D,OAAO;YACH,EAAE;YACF,SAAS,OAAO,CAAC,MAAM,4EAA4E;YACnG,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,CAAmB,EAAU,EAAE,CAAC,UAAU,CAAC,CAAC,QAAQ,MAAM,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;YACxF,oFAAoF;SACvF,CAAC;IACN,CAAC;IAED,wGAAwG;IACxG,oGAAoG;IAC5F,QAAQ,CAAC,KAAwB;QACrC,IAAI,KAAK,CAAC,YAAY,IAAI,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC5D,OAAO,+FAA+F,CAAC;QAC3G,CAAC;QACD,OAAO,wEAAwE,CAAC;IACpF,CAAC;IAED;;;;;;;;;;;;;;;;;;;OAmBG;IACK,SAAS,CAAC,KAAwB;QACtC,MAAM,QAAQ,GAAG,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,CAAC;QAC1C,MAAM,SAAS,GAAG,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC;QAC5C,kGAAkG;QAClG,qGAAqG;QACrG,IAAI,IAAI,GAAG,CAAC,CAAC;QACb,MAAM,KAAK,GAAG,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,UAAU,EAAE,IAAI,EAAE,CAAC,CAAC;QAC7D,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;QACnF,MAAM,KAAK,GAAG,SAAS,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACrF,OAAO,IAAI,GAAG,GAAG;cACX,YAAY,IAAI,kDAAkD,GAAG,GAAG,GAAG,IAAI;cAC/E,KAAK,GAAG,KAAK,GAAG,KAAK,GAAG,IAAI,CAAC,UAAU,CAAC,IAAI,EAAE,QAAQ,CAAC,MAAM,GAAG,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAChG,CAAC;IAEO,eAAe,CAAC,UAAkB,EAAE,IAAY;QACpD,OAAO,CACH,QAAQ,IAAI,6FAA6F;YACzG,8FAA8F;YAC9F,kGAAkG;YAClG,oGAAoG;YACpG,6FAA6F;YAC7F,IAAA,mCAAoB,EAAC,UAAU,CAAC,GAAG,MAAM,CAC5C,CAAC;IACN,CAAC;IAED;;;;;;;;;OASG;IACK,SAAS,CAAC,KAAwB,EAAE,IAAiC,EAAE,IAAY;QACvF,MAAM,KAAK,GAAa;YACpB,QAAQ,IAAI,kDAAkD,IAAI,CAAC,MAAM,oCAAoC;YAC7G,+FAA+F;YAC/F,gGAAgG;YAChG,EAAE;SACL,CAAC;QACF,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,cAAc,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC,CAAC;QAChD,KAAK,MAAM,CAAC,IAAI,IAAI;YAAE,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC;QAClE,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5B,CAAC;IAED;;;;;;;;;;;;;;;OAeG;IACK,SAAS,CAAC,KAAwB,EAAE,SAAsC,EAAE,IAAY;QAC5F,MAAM,KAAK,GAAa;YACpB,QAAQ,IAAI,YAAY,SAAS,CAAC,MAAM,wEAAwE;YAChH,wEAAwE;YACxE,EAAE;YACF,2FAA2F;YAC3F,+FAA+F;YAC/F,gEAAgE;YAChE,EAAE;YACF,+FAA+F;YAC/F,4EAA4E;YAC5E,6EAA6E;YAC7E,EAAE;YACF,gGAAgG;YAChG,uEAAuE;YACvE,EAAE;SACL,CAAC;QACF,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,cAAc,CAAC,KAAK,EAAE,SAAS,CAAC,CAAC,CAAC;QACrD,KAAK,MAAM,CAAC,IAAI,SAAS;YAAE,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC;QACvE,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5B,CAAC;IAED,sGAAsG;IACtG,qGAAqG;IACrG,qGAAqG;IAC7F,cAAc,CAAC,KAAwB,EAAE,KAAkC;QAC/E,MAAM,GAAG,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAmB,EAAU,EAAE,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC;QAC/E,MAAM,CAAC,GAAG,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAkB,EAAW,EAAE,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC,MAAM,CAAC;QAC/F,IAAI,CAAC,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACvB,OAAO;YACH,YAAY,CAAC,sEAAsE;YACnF,iGAAiG;YACjG,EAAE;SACL,CAAC;IACN,CAAC;IAEO,UAAU,CAAC,UAAkB,EAAE,YAAqB;QACxD,mGAAmG;QACnG,sGAAsG;QACtG,qBAAqB;QACrB,MAAM,YAAY,GAAG,YAAY;YAC7B,CAAC,CAAC,0DAA0D;YAC5D,CAAC,CAAC,uBAAuB,CAAC;QAC9B,OAAO,CACH,QAAQ,UAAU,WAAW,YAAY,oCAAoC;YAC7E,sGAAsG,CACzG,CAAC;IACN,CAAC;IAED,sGAAsG;IACtG,yGAAyG;IACjG,aAAa,CAAC,KAAwB;QAC1C,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QACxF,OAAO,KAAK,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAAmB,EAAW,EAAE,CAAC,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC;IACrG,CAAC;IAED,8CAA8C;IACtC,YAAY,CAAC,KAAwB;QACzC,OAAO,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,CAAmB,EAAW,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;IAC1F,CAAC;IAED,mGAAmG;IAC3F,YAAY,CAAC,KAAwB;QACzC,OAAO,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,CAAmB,EAAW,EAAE,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;IAC3F,CAAC;IAED,qGAAqG;IAC7F,aAAa,CAAC,KAAwB;QAC1C,OAAO,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,CAAC;IAC9D,CAAC;IAED,wGAAwG;IACxG,gGAAgG;IAChG,oDAAoD;IAC5C,cAAc,CAAC,KAAwB;QAC3C,OAAO,CAAC,GAAG,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,EAAE,GAAG,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC,CAAC;IACvE,CAAC;IAED;;;;;;;;;OASG;IACK,aAAa,CAAC,KAAwB,EAAE,CAAmB;QAC/D,MAAM,gBAAgB,GAAG,IAAI,CAAC,oBAAoB,CAAC,OAAO,CAAC,KAAK,CAAC,QAAQ,EAAE,KAAK,CAAC,WAAW,EAAE,CAAC,CAAC,QAAQ,CAAC,CAAC;QAC1G,OAAO;YACH,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,EAAE,CAAC,CAAC;YACxB,wBAAwB,CAAC,CAAC,QAAQ,EAAE;YACpC,+EAA+E;YAC/E,wBAAwB,gBAAgB,EAAE;YAC1C,EAAE;SACL,CAAC;IACN,CAAC;IAED,mGAAmG;IACnG,uFAAuF;IAC/E,MAAM,CAAC,KAAwB,EAAE,CAAmB;QACxD,MAAM,OAAO,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAkB,EAAW,EAAE,CAAC,CAAC,CAAC,WAAW,KAAK,CAAC,CAAC,WAAW,CAAC,CAAC;QACrG,IAAI,CAAC,OAAO;YAAE,OAAO,CAAC,OAAO,CAAC,CAAC,QAAQ,MAAM,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,GAAG,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC;QAChF,OAAO;YACH,OAAO,CAAC,CAAC,QAAQ,sFAAsF;YACvG,SAAS,OAAO,CAAC,OAAO,EAAE;YAC1B,iGAAiG;YACjG,8BAA8B;SACjC,CAAC;IACN,CAAC;IAED;;;;;;OAMG;IACK,OAAO,CAAC,CAAmB;QAC/B,IAAI,CAAC,CAAC,QAAQ,IAAI,CAAC,CAAC,OAAO,KAAK,EAAE;YAAE,OAAO,EAAE,CAAC;QAC9C,OAAO,CAAC,0BAA0B,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;IACnD,CAAC;IAED,sGAAsG;IACtG,+FAA+F;IACvF,GAAG,CAAC,CAAmB;QAC3B,IAAI,CAAC,CAAC,eAAe,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACjC,OAAO,iEAAiE,CAAC,CAAC,OAAO,CAAC,MAAM,UAAU,CAAC;QACvG,CAAC;QACD,OAAO,GAAG,CAAC,CAAC,OAAO,CAAC,MAAM,oBAAoB,CAAC,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;IACtH,CAAC;CACJ,CAAA;AApSY,oCAAY;uBAAZ,YAAY;IADxB,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGC,kCAAe;QACV,0CAA2B;GAH7D,YAAY,CAoSxB","sourcesContent":["import { injectable, bindingScopeValues } from 'inversify';\nimport { reviewJsonSchemaHint, RequiredChecklist, ReviewerBriefing, ReviewerInstructionsService } from '@webpieces/rules-config';\nimport { ChecklistNotice } from './checklist-notice';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n/**\n * One reviewer that ALREADY ANSWERED on this branch and refused, with the refusal rendered by\n * `ReviewJsonService.refusalError` — the ONE wording, shared with `wp-finish-upsert-pr`. Data-only.\n *\n * Stage ② carries these because it had the same defect finish did: a refused checklist has no passing\n * verdict, so it is \"owed\", so it got an ordinary spawn block identical to a reviewer that never ran. An\n * agent obeys that block, the reviewer re-reads unchanged code, refuses again — the loop, one stage earlier.\n *\n * The message is rendered by the COMMAND rather than in here for one reason: stage ② must not archive\n * anything. `refusalError` called with no archive path says \"fix it, then re-run; or set an override in\n * review-<id>.json\", which is only true while that file is still live — and at stage ② it is. Retiring a\n * verdict is finish's act, on the refusal it is actually acting on.\n */\nexport class RefusedReviewer {\n    checklistId: string;\n    message: string;\n\n    constructor(checklistId: string, message: string) {\n        this.checklistId = checklistId;\n        this.message = message;\n    }\n}\n\n/**\n * Everything the closing block of `wp-review-upsert-pr` needs. Data-only, and a class rather than an\n * object literal per CLAUDE.md. The three identifying paths are constructor args; the rest are optional\n * facts about the scan that default to \"nothing\", so a repo with no checklists constructs it in one line.\n */\nexport class ReviewReportInput {\n    repoRoot: string;\n    featureName: string;\n    reviewPath: string;             // the branch's review.json — the file the AI must write next\n    definedCount: number;           // how many checklists pr-gate.checklists defines\n    applicableCount: number;        // how many of them apply to THIS diff (0 ⇒ the notice, not spawn blocks)\n    reviewed: RequiredChecklist[];  // already have a passing verdict on this branch\n    formatErrors: string[];         // verdict files that exist but cannot be read as verdicts\n    briefings: ReviewerBriefing[];  // one per applicable checklist, already written to disk\n    refused: RefusedReviewer[];     // of the owed ones, those that already ran and said no (see RefusedReviewer)\n    /**\n     * `--no-optional` was passed: the human has already said to submit without the optional reviews, so the\n     * block that offers them is replaced by a one-line statement that they were skipped. It never suppresses\n     * a REQUIRED reviewer, and it is not a gate — nothing about what blocks the PR changes.\n     */\n    skipOptional: boolean;\n\n    constructor(repoRoot: string, featureName: string, reviewPath: string) {\n        this.repoRoot = repoRoot;\n        this.featureName = featureName;\n        this.reviewPath = reviewPath;\n        this.definedCount = 0;\n        this.applicableCount = 0;\n        this.reviewed = [];\n        this.formatErrors = [];\n        this.briefings = [];\n        this.refused = [];\n        this.skipOptional = false;\n    }\n}\n\n/**\n * Renders the closing block of `wp-review-upsert-pr` — the checklist verdict, then EXACTLY ONE \"what to do\n * next\".\n *\n * Extracted from the command so it can be asserted on as a rendered string, because the ordering IS the\n * contract. The bug it was extracted to fix: the zero-checklist notice ended with \"Carry on and run: pnpm\n * wp-finish-upsert-pr\", and the block printed directly beneath it said to write review.json first and\n * finish afterwards. Two next-steps, in the wrong order, and an agent that follows instructions literally —\n * which is the entire reason this command prints them — took the first one and opened a PR with no review.\n * That is precisely the failure the three-stage flow exists to prevent (reported on PR #519).\n *\n * The invariants, enforced by review-report.spec.ts:\n *   1. `wp-finish-upsert-pr` is named as a thing to run EXACTLY ONCE in the whole block.\n *   2. The review.json instruction comes BEFORE it — and BEFORE the spawn blocks (see nextSteps).\n *   3. With zero checklists the all-clear precedes any configuration guidance.\n *   4. REQUIRED reviewers are spawned unasked; OPTIONAL ones are only ever OFFERED, in one batched\n *      question. The two never share a step, because one instruction says \"do it\" and the other says\n *      \"ask first\", and an agent reading a merged list will act on the stronger of the two.\n *\n * Pure string building, no I/O. `@injectable(bindingScopeValues.Singleton)` so it is injected by type.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewReport {\n    constructor(\n        private readonly checklistNotice: ChecklistNotice,\n        private readonly reviewerInstructions: ReviewerInstructionsService,\n    ) {}\n\n    render(input: ReviewReportInput): string {\n        return '\\n' + SEP + this.header(input) + SEP\n            + this.scanVerdict(input)\n            + this.nextSteps(input);\n    }\n\n    /**\n     * Name what this block is actually about. A repo with reviewers owed is being told to SPAWN; a repo with\n     * none is not, and promising subagents it does not have is the same kind of noise as explaining checklist\n     * configuration to a repo that configured none. Keyed on what is actually ACTIONABLE rather than on the\n     * applicable count: every applicable checklist already having a verdict means nothing to spawn, and so\n     * does a branch whose only outstanding reviews are optional ones the human already waved off.\n     *\n     * \"spawn\" and \"ask about\" are separate headings because they are separate obligations. A branch owing\n     * only optional reviews has nothing the AI may do unilaterally, and a heading that says SPAWN is the\n     * single line most likely to make it do exactly that.\n     */\n    private header(input: ReviewReportInput): string {\n        if (this.requiredOwed(input).length > 0) return '② Review, spawn subagent reviewers, then finish\\n';\n        if (this.offerableOwed(input).length > 0) return '② Review, offer the optional reviewers, then finish\\n';\n        return '② Review, then finish\\n';\n    }\n\n    /**\n     * What the SCAN found: either \"nothing applies here\" or the already-reviewed / unreadable-verdict lines.\n     * Verdicts, not instructions — every instruction lives in nextSteps() below, so no line up here can be\n     * mistaken for the next action.\n     */\n    private scanVerdict(input: ReviewReportInput): string {\n        if (input.applicableCount === 0) return '\\n' + this.checklistNotice.build(input.definedCount);\n        const lines: string[] = [];\n        for (const r of input.reviewed) {\n            lines.push(`  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)`);\n        }\n        // A verdict file that EXISTS but is unreadable as a verdict is called out here. Without it this\n        // reports the checklist as simply owed, and the AI re-runs a reviewer that already ran instead of\n        // correcting the file sitting right there.\n        for (const e of input.formatErrors) lines.push(`  ⛔ ${e}`);\n        lines.push(...this.skippedLines(input));\n        if (this.actionableOwed(input).length === 0) lines.push('', this.allClear(input));\n        if (lines.length === 0) return '';\n        return '\\n' + lines.join('\\n') + '\\n';\n    }\n\n    /**\n     * `--no-optional`, stated as a VERDICT rather than left silent. Named individually, not just counted: the\n     * whole reason the human is allowed to skip these is that they know this diff, and the only way they can\n     * catch \"wait, not THAT one\" is to see which ones went unreviewed.\n     */\n    private skippedLines(input: ReviewReportInput): string[] {\n        const skipped = this.optionalOwed(input);\n        if (!input.skipOptional || skipped.length === 0) return [];\n        return [\n            '',\n            `  ⏭️  ${skipped.length} OPTIONAL checklist(s) matched this diff and were SKIPPED (--no-optional):`,\n            ...skipped.map((b: ReviewerBriefing): string => `       ${b.subagent} — ${this.why(b)}`),\n            '      Not blocking. Drop the flag and re-run this command to offer them after all.',\n        ];\n    }\n\n    // The all-clear. It must NOT claim everything was reviewed when optional reviews were skipped — that is\n    // the one sentence that would turn a deliberate skip into a false record of a review that happened.\n    private allClear(input: ReviewReportInput): string {\n        if (input.skipOptional && this.optionalOwed(input).length > 0) {\n            return '✅ Nothing left to spawn — every REQUIRED checklist is reviewed (optional ones skipped above).';\n        }\n        return '✅ Every checklist that applies is already reviewed — nothing to spawn.';\n    }\n\n    /**\n     * The ONE instruction block, and the last thing the stage prints. Numbered rather than prose-linked\n     * (\"Then… Finally…\") so that skipping step 1 is visibly skipping a step, and worded so no earlier line\n     * can be mistaken for the real next action.\n     *\n     * review.json is STEP 1 and the spawn blocks are STEP 2 — that ORDER is the contract, not a preference.\n     * This block used to print the spawn blocks first and then say to write review.json \"WHILE any reviewer\n     * subagents above are still running\", which does not merely permit spawning first, it instructs it.\n     * Harmless for a reviewer that only reads the diff; wrong for one that judges the PR's stated INTENT —\n     * its title, summary or risk level — because review.json is the only place that intent lives. Such a\n     * reviewer either finds no file (a false RED and a wasted reviewer run) or, on a second run of this\n     * stage on the same branch, finds the PREVIOUS run's file and validates a title that no longer exists —\n     * a false GREEN, with nothing in the output saying which of the two happened. A consuming repo had to\n     * write itself a rule telling its agents to DISOBEY this block to work around it.\n     *\n     * What the old ordering bought was overlap on a single local file write, not a subagent round-trip.\n     *\n     * The schema hint is rendered by ReviewJsonService — the single renderer — so the shape printed here\n     * can never drift from the shape `wp-finish-upsert-pr` validates.\n     */\n    private nextSteps(input: ReviewReportInput): string {\n        const required = this.requiredOwed(input);\n        const offerable = this.offerableOwed(input);\n        // Numbered by what is actually PRINTED, so the numbers a reader sees are 1..n with no gaps: write\n        // review.json, then a spawn step only if anything must run, then an offer step only if anything may.\n        let step = 1;\n        const write = this.writeReviewStep(input.reviewPath, step++);\n        const spawn = required.length === 0 ? '' : this.spawnStep(input, required, step++);\n        const offer = offerable.length === 0 ? '' : this.offerStep(input, offerable, step++);\n        return '\\n' + SEP\n            + `▶ NEXT — ${step} steps, in this order. Step 1 is NOT optional:\\n` + SEP + '\\n'\n            + write + spawn + offer + this.finishStep(step, required.length + offerable.length > 0);\n    }\n\n    private writeReviewStep(reviewPath: string, step: number): string {\n        return (\n            `STEP ${step} — review your own changes, then write the review file. Write it FIRST — BEFORE you spawn\\n` +\n            '         anything below. finish REFUSES without it, and a reviewer subagent may READ it: a\\n' +\n            '         checklist that judges the PR title, summary or risk level reads exactly this file, so\\n' +\n            '         writing it afterwards races that reviewer into seeing nothing — or, on a re-run of this\\n' +\n            '         stage, into judging the PREVIOUS run\\'s review of code that has since changed.\\n\\n' +\n            reviewJsonSchemaHint(reviewPath) + '\\n\\n'\n        );\n    }\n\n    /**\n     * The REQUIRED reviewers — one copy-paste block each, and nothing at all when none is owed. The prompt is\n     * deliberately a POINTER and nothing else: the generated instructions file is the contract, so anything\n     * restated here is a second copy that can go stale — which is exactly how a removed `success` field\n     * outlived its own removal in print.\n     *\n     * These are spawned WITHOUT asking. They are the checklists the repo declared `required: true`, which is\n     * the repo saying the decision was already made; putting them to the human again would re-open a question\n     * the config exists to settle.\n     */\n    private spawnStep(input: ReviewReportInput, owed: readonly ReviewerBriefing[], step: number): string {\n        const lines: string[] = [\n            `STEP ${step} — only once that file is written, spawn these ${owed.length} REQUIRED reviewer subagent(s) — a`,\n            '         SEPARATE one each. They block the PR, so do NOT ask whether to run them. You may NOT',\n            '         review your own work, and you may NOT write a reviewer\\'s verdict file on its behalf.',\n            '',\n        ];\n        lines.push(...this.refusedWarning(input, owed));\n        for (const b of owed) lines.push(...this.oneSpawnBlock(input, b));\n        lines.push('');\n        return lines.join('\\n');\n    }\n\n    /**\n     * STEP n — the OPTIONAL reviewers: listed, never spawned unasked.\n     *\n     * This is the whole point of `required: false`. A one-line bug fix in a repo whose checklists key on a\n     * glob as broad as every TypeScript file otherwise pays for a dozen subagent reviews, and the only party\n     * who can judge whether this particular diff is worth them is the human looking at it.\n     *\n     * ONE batched multi-select question, explicitly. Asked one at a time, a human answering \"no\" nine times\n     * is being worn down rather than consulted, and by the third question the cheap thing is to say yes to\n     * everything — which is the state this feature exists to leave. The \"None\" option has to be spelled out\n     * too: an agent that offers a list without an explicit way to decline it has not really offered a choice.\n     *\n     * The blocking consequence is stated because it is the one non-obvious part of the contract: `required`\n     * governs whether a reviewer must RUN, not whether its answer counts. Choosing to run one and then\n     * shrugging off a red verdict would make the whole exercise theater.\n     */\n    private offerStep(input: ReviewReportInput, offerable: readonly ReviewerBriefing[], step: number): string {\n        const lines: string[] = [\n            `STEP ${step} — these ${offerable.length} OPTIONAL review checklist(s) matched this diff. They do NOT block the`,\n            '         PR, and you may NOT decide for the human whether to run them.',\n            '',\n            '         ASK THE HUMAN, in ONE multi-select question listing all of them plus an explicit',\n            '         \"None — required only\" choice. Do not ask one question per reviewer. Then spawn ONLY',\n            '         what they picked, the same way as any other reviewer.',\n            '',\n            '         If they pick none, that is a complete answer: go straight to the final step. If they',\n            '         told you up front to submit without reviews, re-run this stage as',\n            '         `pnpm wp-review-upsert-pr --no-optional` and this step disappears.',\n            '',\n            '         NOTE: whichever ones you DO run, their verdicts count in full — a red verdict from an',\n            '         optional reviewer blocks the PR exactly like a required one.',\n            '',\n        ];\n        lines.push(...this.refusedWarning(input, offerable));\n        for (const b of offerable) lines.push(...this.oneSpawnBlock(input, b));\n        lines.push('');\n        return lines.join('\\n');\n    }\n\n    // Said up front, not only beside the block: an agent that has decided to spawn everything listed here\n    // needs to know BEFORE it starts that one of these entries is not a spawn-shaped task. Scoped to the\n    // group being printed — a refusal among the REQUIRED reviewers is not a caveat on the optional list.\n    private refusedWarning(input: ReviewReportInput, group: readonly ReviewerBriefing[]): string[] {\n        const ids = new Set(group.map((b: ReviewerBriefing): string => b.checklistId));\n        const n = input.refused.filter((r: RefusedReviewer): boolean => ids.has(r.checklistId)).length;\n        if (n === 0) return [];\n        return [\n            `         ${n} of them already ANSWERED and refused (marked ⛔ below). Do not spawn`,\n            '         those against unchanged code — fix what they found first; the fix is the prerequisite.',\n            '',\n        ];\n    }\n\n    private finishStep(stepNumber: number, anyReviewers: boolean): string {\n        // \"every reviewer you ran\" rather than \"every reviewer above\": with an optional list the human may\n        // legitimately have run none of them, and a precondition naming reviewers that were declined reads as\n        // an unmeetable one.\n        const precondition = anyReviewers\n            ? 'once every reviewer you ran has written its verdict file'\n            : 'once that file exists';\n        return (\n            `STEP ${stepNumber} — only ${precondition}, run:  pnpm wp-finish-upsert-pr\\n` +\n            '         (The build gate is already green for this commit — finish reuses it unless HEAD moves.)\\n\\n'\n        );\n    }\n\n    // The briefings with no passing verdict yet — the ONE definition of \"owed\", shared by the header, the\n    // scan verdict and the step numbering, so they cannot disagree about whether there is anything to spawn.\n    private owedReviewers(input: ReviewReportInput): ReviewerBriefing[] {\n        const reviewedIds = new Set(input.reviewed.map((r: RequiredChecklist): string => r.id));\n        return input.briefings.filter((b: ReviewerBriefing): boolean => !reviewedIds.has(b.checklistId));\n    }\n\n    // Owed AND blocking — spawned without asking.\n    private requiredOwed(input: ReviewReportInput): ReviewerBriefing[] {\n        return this.owedReviewers(input).filter((b: ReviewerBriefing): boolean => b.required);\n    }\n\n    // Owed and optional. Still listed under `--no-optional` (as a skip verdict), just never as a step.\n    private optionalOwed(input: ReviewReportInput): ReviewerBriefing[] {\n        return this.owedReviewers(input).filter((b: ReviewerBriefing): boolean => !b.required);\n    }\n\n    // The optional ones the human is actually to be ASKED about — none, once they have already answered.\n    private offerableOwed(input: ReviewReportInput): ReviewerBriefing[] {\n        return input.skipOptional ? [] : this.optionalOwed(input);\n    }\n\n    // Everything the AI still has to act on. Distinct from `owedReviewers`: a skipped optional checklist is\n    // owed a verdict it will never get, and treating it as pending work is what would print a spawn\n    // instruction for a review the human just declined.\n    private actionableOwed(input: ReviewReportInput): ReviewerBriefing[] {\n        return [...this.requiredOwed(input), ...this.offerableOwed(input)];\n    }\n\n    /**\n     * One reviewer's block. A reviewer that already REFUSED gets the SAME spawn coordinates but a different\n     * lead-in, because the action before spawning is different: its own words are printed, and the spawn is\n     * explicitly conditioned on having fixed the finding first.\n     *\n     * It keeps its spawn block rather than being dropped from the list, because the reviewer genuinely does\n     * still owe a fresh verdict — dropping it would leave nothing anywhere saying how to get one. What must\n     * not happen is a bare \"spawn this\" that reads identically to a reviewer that never ran, which is the\n     * loop this exists to break.\n     */\n    private oneSpawnBlock(input: ReviewReportInput, b: ReviewerBriefing): string[] {\n        const instructionsFile = this.reviewerInstructions.pathFor(input.repoRoot, input.featureName, b.subagent);\n        return [\n            ...this.leadIn(input, b),\n            `      subagent_type: ${b.subagent}`,\n            '      prompt:        Read your instructions file FIRST and follow it exactly:',\n            `                     ${instructionsFile}`,\n            '',\n        ];\n    }\n\n    // The lines above the spawn coordinates: normally just why this reviewer is in scope; for one that\n    // already refused, its verdict verbatim plus the order the two actions must happen in.\n    private leadIn(input: ReviewReportInput, b: ReviewerBriefing): string[] {\n        const refusal = input.refused.find((r: RefusedReviewer): boolean => r.checklistId === b.checklistId);\n        if (!refusal) return [`  ▶ ${b.subagent} — ${this.why(b)}`, ...this.docLine(b)];\n        return [\n            `  ⛔ ${b.subagent} — ALREADY REVIEWED THIS BRANCH AND REFUSED. It will refuse again on unchanged code.`,\n            `      ${refusal.message}`,\n            '      FIX THE FINDING FIRST (or record a human-authored override). ONLY THEN spawn it again, to',\n            '      write a fresh verdict:',\n        ];\n    }\n\n    /**\n     * The checklist's guidance doc, for OPTIONAL reviewers only.\n     *\n     * \"4 file(s) matched\" plus a broad glob does not tell a human what the review would actually look AT,\n     * and they are being asked to decide exactly that. Omitted for required reviewers: there is no decision\n     * to inform there — the reviewer runs either way, and the doc is already in its instructions file.\n     */\n    private docLine(b: ReviewerBriefing): string[] {\n        if (b.required || b.docPath === '') return [];\n        return [`      reviews against: ${b.docPath}`];\n    }\n\n    // Why this one is in scope. A patternless checklist is NOT \"matched\" — it always runs, over the whole\n    // diff, and saying so is what tells a repo its checklist is firing on docs-only PRs by design.\n    private why(b: ReviewerBriefing): string {\n        if (b.matchedPatterns.length === 0) {\n            return `ALWAYS RUNS (no \"patterns\" configured), whole diff in scope — ${b.myFiles.length} file(s)`;\n        }\n        return `${b.myFiles.length} file(s) matched ${b.matchedPatterns.map((p: string): string => `\"${p}\"`).join(', ')}`;\n    }\n}\n"]}

package/src/scripts/workflow/reviewer-briefing-builder.js

@@ -36,6 +36,7 @@ let ReviewerBriefingBuilder = class ReviewerBriefingBuilder {
         b.manifestPath = diffDir === '' ? '' : path.join(diffDir, 'manifest.json');
         b.myFiles = req.matchedFiles.map((f) => this.briefedFile(repoRoot, f, entryByFile));
         b.matchedPatterns = req.matchedPatterns;
+        b.required = req.required;
         b.sourceDirs = this.sourceDirsFor(repoRoot, req.matchedFiles);
         b.contextEntries = shared;
         b.verdictPath = this.reviewJsonService.checklistResultPath(scan.reviewPath, req.id);

package/src/scripts/workflow/reviewer-briefing-builder.js.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-briefing-builder.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/reviewer-briefing-builder.ts"],"names":[],"mappings":";;;;AAAA,+CAAyB;AACzB,mDAA6B;AAC7B,0DAEiC;AACjC,yCAA2D;AAI3D;;;;;;GAMG;AAEI,IAAM,uBAAuB,GAA7B,MAAM,uBAAuB;IACH;IAA7B,YAA6B,iBAAoC;QAApC,sBAAiB,GAAjB,iBAAiB,CAAmB;IAAG,CAAC;IAErE,KAAK,CAAC,QAAgB,EAAE,IAAmB,EAAE,QAAsB,EAAE,OAAe,EAAE,MAAoB;QACtG,oGAAoG;QACpG,kEAAkE;QAClE,MAAM,MAAM,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QACrD,MAAM,WAAW,GAAG,IAAI,GAAG,EAA6B,CAAC;QACzD,KAAK,MAAM,CAAC,IAAI,QAAQ,CAAC,OAAO;YAAE,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAC7D,OAAO,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,GAAsB,EAAoB,EAAE,CACpE,IAAI,CAAC,GAAG,CAAC,QAAQ,EAAE,GAAG,EAAE,IAAI,EAAE,WAAW,EAAE,OAAO,EAAE,MAAM,EAAE,QAAQ,CAAC,CAAC,CAAC;IAC/E,CAAC;IAED,yDAAyD;IACjD,GAAG,CACP,QAAgB,EAAE,GAAsB,EAAE,IAAmB,EAC7D,WAA2C,EAAE,OAAe,EAAE,MAAsB,EAAE,QAAsB;QAE5G,MAAM,CAAC,GAAG,IAAI,+BAAgB,CAAC,GAAG,CAAC,QAAQ,EAAE,GAAG,CAAC,EAAE,EAAE,QAAQ,CAAC,CAAC;QAC/D,CAAC,CAAC,OAAO,GAAG,GAAG,CAAC,GAAG,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,GAAG,CAAC,GAAG,CAAC,CAAC;QACzE,CAAC,CAAC,OAAO,GAAG,OAAO,CAAC;QACpB,CAAC,CAAC,WAAW,GAAG,OAAO,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;QACrE,CAAC,CAAC,YAAY,GAAG,OAAO,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,eAAe,CAAC,CAAC;QAC3E,CAAC,CAAC,OAAO,GAAG,GAAG,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAS,EAAe,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,QAAQ,EAAE,CAAC,EAAE,WAAW,CAAC,CAAC,CAAC;QACzG,CAAC,CAAC,eAAe,GAAG,GAAG,CAAC,eAAe,CAAC;QACxC,CAAC,CAAC,UAAU,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,GAAG,CAAC,YAAY,CAAC,CAAC;QAC9D,CAAC,CAAC,cAAc,GAAG,MAAM,CAAC;QAC1B,CAAC,CAAC,WAAW,GAAG,IAAI,CAAC,iBAAiB,CAAC,mBAAmB,CAAC,IAAI,CAAC,UAAU,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC;QACpF,CAAC,CAAC,eAAe,GAAG,IAAI,CAAC,OAAO,CAAC,eAAe,CAAC;QACjD,CAAC,CAAC,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC;QAC3B,CAAC,CAAC,kBAAkB,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,GAAG,CAAC,QAAQ,CAAC,CAAC;QACnE,IAAI,CAAC,iBAAiB,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;QACpC,OAAO,CAAC,CAAC;IACb,CAAC;IAED;;;;OAIG;IACK,WAAW,CAAC,QAAgB,EAAE,IAAY,EAAE,WAA2C;QAC3F,MAAM,CAAC,GAAG,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAChC,IAAI,CAAC,KAAK,SAAS;YAAE,OAAO,IAAI,0BAAW,CAAC,IAAI,EAAE,EAAE,EAAE,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC,CAAC;QACpF,OAAO,IAAI,0BAAW,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC,SAAS,CAAC,CAAC;IACvF,CAAC;IAED;;;;OAIG;IACK,iBAAiB,CAAC,CAAmB,EAAE,QAAsB;QACjE,CAAC,CAAC,gBAAgB,GAAG,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC;QAC7C,CAAC,CAAC,cAAc,GAAG,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,MAAM,CAAC;QAClG,CAAC,CAAC,aAAa,GAAG,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;QAC3C,CAAC,CAAC,YAAY,GAAG,QAAQ,CAAC,YAAY,CAAC;QACvC,CAAC,CAAC,YAAY,GAAG,QAAQ,CAAC,YAAY,CAAC;QACvC,CAAC,CAAC,aAAa,GAAG,QAAQ,CAAC,aAAa,CAAC;QACzC,CAAC,CAAC,eAAe,GAAG,QAAQ,CAAC,eAAe,CAAC;QAC7C,CAAC,CAAC,YAAY,GAAG,QAAQ,CAAC,YAAY,CAAC;IAC3C,CAAC;IAED;;;;OAIG;IACK,cAAc,CAAC,QAAsB,EAAE,QAAgB;QAC3D,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,QAAQ,EAAE,GAAG,QAAQ,KAAK,CAAC,CAAC;QAChE,MAAM,GAAG,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC;QACxH,OAAO,GAAG,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;IAClF,CAAC;IAED;;;;OAIG;IACK,aAAa,CAAC,QAAgB,EAAE,KAAwB;QAC5D,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;QAC/B,KAAK,MAAM,CAAC,IAAI,KAAK;YAAE,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACzE,OAAO,CAAC,GAAG,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC;IAC5B,CAAC;IAED;;;;;;;;;;;OAWG;IACK,cAAc,CAAC,QAAgB,EAAE,MAAoB;QACzD,MAAM,OAAO,GAAmB,EAAE,CAAC;QACnC,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,qBAAqB;YAAE,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC,CAAC;QACjG,KAAK,MAAM,IAAI,IAAI,MAAM,CAAC,aAAa,EAAE,CAAC;YACtC,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;YAC9C,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC;gBAC3B,CAAC,CAAC,IAAI,2BAAY,CAAC,IAAI,CAAC,KAAK,EAAE,GAAG,CAAC;gBACnC,CAAC,CAAC,IAAI,2BAAY,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,EAAE,mBAAmB,IAAI,CAAC,IAAI,gBAAgB,CAAC,CAAC,CAAC;QAC1F,CAAC;QACD,OAAO,OAAO,CAAC;IACnB,CAAC;IAEO,cAAc,CAAC,QAAgB,EAAE,GAAW;QAChD,oHAAoH;QACpH,8DAA8D;QAC9D,IAAI,CAAC;YACD,MAAM,YAAY,GAAG,OAAO,CAAC,OAAO,CAAC,GAAG,GAAG,eAAe,EAAE,EAAE,KAAK,EAAE,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;YACnF,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;YACvC,sFAAsF;YACtF,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,YAAY,CAAC,YAAY,EAAE,MAAM,CAAC,CAA4B,CAAC;YAC1F,MAAM,IAAI,GAAG,OAAO,IAAI,CAAC,aAAa,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,IAAI,CAAC,aAAa,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5F,OAAO,IAAI,2BAAY,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,GAAG,MAAM,IAAI,EAAE,EAAE,GAAG,CAAC,CAAC;QACzE,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,sBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,KAAK,KAAK,CAAC,CAAC,yDAAyD;YACrE,OAAO,IAAI,2BAAY,CAAC,GAAG,EAAE,EAAE,EAAE,+DAA+D,CAAC,CAAC;QACtG,CAAC;IACL,CAAC;CACJ,CAAA;AA5HY,0DAAuB;kCAAvB,uBAAuB;IADnC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAEW,gCAAiB;GADxD,uBAAuB,CA4HnC","sourcesContent":["import * as fs from 'fs';\nimport * as path from 'path';\nimport {\n    BriefedFile, ContextEntry, PrGateConfig, RequiredChecklist, ReviewerBriefing, ReviewJsonService, toError,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { DiffManifest, DiffManifestEntry } from './diff-materializer';\nimport { ChecklistScan } from './checklist-scanner';\n\n/**\n * Turns a {@link ChecklistScan} plus the materialized {@link DiffManifest} into one {@link ReviewerBriefing}\n * per reviewer — resolving every path to an absolute one, because a reviewer that has to resolve a path\n * ends up searching, and searching is the cost this whole feature exists to remove.\n *\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewerBriefingBuilder {\n    constructor(private readonly reviewJsonService: ReviewJsonService) {}\n\n    build(repoRoot: string, scan: ChecklistScan, manifest: DiffManifest, diffDir: string, config: PrGateConfig): ReviewerBriefing[] {\n        // Resolved ONCE for the whole run, not per reviewer: `require.resolve` hits the filesystem, and the\n        // answer cannot differ between two reviewers in the same process.\n        const shared = this.contextEntries(repoRoot, config);\n        const entryByFile = new Map<string, DiffManifestEntry>();\n        for (const e of manifest.entries) entryByFile.set(e.file, e);\n        return scan.applicable.map((req: RequiredChecklist): ReviewerBriefing =>\n            this.one(repoRoot, req, scan, entryByFile, diffDir, shared, manifest));\n    }\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    private one(\n        repoRoot: string, req: RequiredChecklist, scan: ChecklistScan,\n        entryByFile: Map<string, DiffManifestEntry>, diffDir: string, shared: ContextEntry[], manifest: DiffManifest,\n    ): ReviewerBriefing {\n        const b = new ReviewerBriefing(req.subagent, req.id, repoRoot);\n        b.docPath = req.doc.trim() === '' ? '' : path.resolve(repoRoot, req.doc);\n        b.diffDir = diffDir;\n        b.allDiffPath = diffDir === '' ? '' : path.join(diffDir, 'ALL.diff');\n        b.manifestPath = diffDir === '' ? '' : path.join(diffDir, 'manifest.json');\n        b.myFiles = req.matchedFiles.map((f: string): BriefedFile => this.briefedFile(repoRoot, f, entryByFile));\n        b.matchedPatterns = req.matchedPatterns;\n        b.sourceDirs = this.sourceDirsFor(repoRoot, req.matchedFiles);\n        b.contextEntries = shared;\n        b.verdictPath = this.reviewJsonService.checklistResultPath(scan.reviewPath, req.id);\n        b.fileDiffCommand = scan.context.fileDiffCommand;\n        b.dirty = scan.basis.dirty;\n        b.ownAgentFileInDiff = this.ownAgentFileIn(manifest, req.subagent);\n        this.copyManifestFacts(b, manifest);\n        return b;\n    }\n\n    /**\n     * One row of the reviewer's table. The SOURCE path comes over with the diff path because the two need\n     * identical affordance: when the diff was an absolute path and the source was a parent directory, four of\n     * four reviewers read the diff and none opened a source file.\n     */\n    private briefedFile(repoRoot: string, file: string, entryByFile: Map<string, DiffManifestEntry>): BriefedFile {\n        const e = entryByFile.get(file);\n        if (e === undefined) return new BriefedFile(file, '', path.resolve(repoRoot, file));\n        return new BriefedFile(file, e.diffAbs, e.fileAbs, e.status, e.bytes, e.truncated);\n    }\n\n    /**\n     * Manifest headline facts, copied onto the briefing so the instructions can state them INLINE. A reviewer\n     * that never opens the manifest still has to learn whether anything was truncated or excluded — that is\n     * precisely the thing it could not otherwise know it was missing.\n     */\n    private copyManifestFacts(b: ReviewerBriefing, manifest: DiffManifest): void {\n        b.changedFileCount = manifest.entries.length;\n        b.truncatedCount = manifest.entries.filter((e: DiffManifestEntry): boolean => e.truncated).length;\n        b.excludedCount = manifest.excluded.length;\n        b.allDiffLines = manifest.allDiffLines;\n        b.allDiffBytes = manifest.allDiffBytes;\n        b.hashForkPoint = manifest.hashForkPoint;\n        b.hashFeatureHead = manifest.hashFeatureHead;\n        b.hashMainHead = manifest.hashMainHead;\n    }\n\n    /**\n     * The reviewer's own `.claude/agents/<subagent>.md`, when THIS diff changes it. Detected here rather than\n     * left to the reviewer to notice: on the measured run two reviewers reviewed their own definition and\n     * neither mentioned it, and every PR that edits the review gate reproduces that.\n     */\n    private ownAgentFileIn(manifest: DiffManifest, subagent: string): string {\n        const suffix = path.join('.claude', 'agents', `${subagent}.md`);\n        const hit = manifest.entries.find((e: DiffManifestEntry): boolean => e.file.split('/').join(path.sep).endsWith(suffix));\n        return hit === undefined ? '' : (hit.fileAbs === '' ? hit.file : hit.fileAbs);\n    }\n\n    /**\n     * Deduped absolute parent dirs of the matched files. Dirs rather than files because the point is to say\n     * \"the neighbourhood is here\" — a reviewer already has the file list; what it lacks is where to look for\n     * the code AROUND the change.\n     */\n    private sourceDirsFor(repoRoot: string, files: readonly string[]): string[] {\n        const dirs = new Set<string>();\n        for (const f of files) dirs.add(path.resolve(repoRoot, path.dirname(f)));\n        return [...dirs].sort();\n    }\n\n    /**\n     * The pre-resolved context list, from two config keys with deliberately different jobs:\n     *\n     * `reviewContextPackages` — installed packages, resolved to their real on-disk dir. This is what deletes\n     *   the repeated `node_modules/@webpieces` greps: the tooling knows where a package resolved to, and the\n     *   reviewer does not.\n     * `reviewContext` — the repo-specific escape hatch (`{label, path}`) for what tooling cannot possibly\n     *   guess, e.g. \"queue names live in terraform/services/\".\n     *\n     * Neither ever drops an entry: an unresolvable package or a missing path is LISTED, with the reason. A\n     * silently shorter list is indistinguishable from a complete one.\n     */\n    private contextEntries(repoRoot: string, config: PrGateConfig): ContextEntry[] {\n        const entries: ContextEntry[] = [];\n        for (const pkg of config.reviewContextPackages) entries.push(this.resolvePackage(repoRoot, pkg));\n        for (const item of config.reviewContext) {\n            const abs = path.resolve(repoRoot, item.path);\n            entries.push(fs.existsSync(abs)\n                ? new ContextEntry(item.label, abs)\n                : new ContextEntry(item.label, '', `(configured as \"${item.path}\" but missing)`));\n        }\n        return entries;\n    }\n\n    private resolvePackage(repoRoot: string, pkg: string): ContextEntry {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: an unresolvable package is REPORTED as such, never fatal\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            const manifestPath = require.resolve(`${pkg}/package.json`, { paths: [repoRoot] });\n            const dir = path.dirname(manifestPath);\n            // webpieces-disable no-any-unknown -- opaque package.json, only `description` is read\n            const meta = JSON.parse(fs.readFileSync(manifestPath, 'utf8')) as Record<string, unknown>;\n            const desc = typeof meta['description'] === 'string' ? (meta['description'] as string) : '';\n            return new ContextEntry(desc === '' ? pkg : `${pkg} — ${desc}`, dir);\n        } catch (err: unknown) {\n            const error = toError(err);\n            void error; // an unresolvable package is REPORTED below, never fatal\n            return new ContextEntry(pkg, '', '(not installed — configured in pr-gate.reviewContextPackages)');\n        }\n    }\n}\n"]}
+{"version":3,"file":"reviewer-briefing-builder.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/reviewer-briefing-builder.ts"],"names":[],"mappings":";;;;AAAA,+CAAyB;AACzB,mDAA6B;AAC7B,0DAEiC;AACjC,yCAA2D;AAI3D;;;;;;GAMG;AAEI,IAAM,uBAAuB,GAA7B,MAAM,uBAAuB;IACH;IAA7B,YAA6B,iBAAoC;QAApC,sBAAiB,GAAjB,iBAAiB,CAAmB;IAAG,CAAC;IAErE,KAAK,CAAC,QAAgB,EAAE,IAAmB,EAAE,QAAsB,EAAE,OAAe,EAAE,MAAoB;QACtG,oGAAoG;QACpG,kEAAkE;QAClE,MAAM,MAAM,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QACrD,MAAM,WAAW,GAAG,IAAI,GAAG,EAA6B,CAAC;QACzD,KAAK,MAAM,CAAC,IAAI,QAAQ,CAAC,OAAO;YAAE,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAC7D,OAAO,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,GAAsB,EAAoB,EAAE,CACpE,IAAI,CAAC,GAAG,CAAC,QAAQ,EAAE,GAAG,EAAE,IAAI,EAAE,WAAW,EAAE,OAAO,EAAE,MAAM,EAAE,QAAQ,CAAC,CAAC,CAAC;IAC/E,CAAC;IAED,yDAAyD;IACjD,GAAG,CACP,QAAgB,EAAE,GAAsB,EAAE,IAAmB,EAC7D,WAA2C,EAAE,OAAe,EAAE,MAAsB,EAAE,QAAsB;QAE5G,MAAM,CAAC,GAAG,IAAI,+BAAgB,CAAC,GAAG,CAAC,QAAQ,EAAE,GAAG,CAAC,EAAE,EAAE,QAAQ,CAAC,CAAC;QAC/D,CAAC,CAAC,OAAO,GAAG,GAAG,CAAC,GAAG,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,GAAG,CAAC,GAAG,CAAC,CAAC;QACzE,CAAC,CAAC,OAAO,GAAG,OAAO,CAAC;QACpB,CAAC,CAAC,WAAW,GAAG,OAAO,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;QACrE,CAAC,CAAC,YAAY,GAAG,OAAO,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,eAAe,CAAC,CAAC;QAC3E,CAAC,CAAC,OAAO,GAAG,GAAG,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAS,EAAe,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,QAAQ,EAAE,CAAC,EAAE,WAAW,CAAC,CAAC,CAAC;QACzG,CAAC,CAAC,eAAe,GAAG,GAAG,CAAC,eAAe,CAAC;QACxC,CAAC,CAAC,QAAQ,GAAG,GAAG,CAAC,QAAQ,CAAC;QAC1B,CAAC,CAAC,UAAU,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,GAAG,CAAC,YAAY,CAAC,CAAC;QAC9D,CAAC,CAAC,cAAc,GAAG,MAAM,CAAC;QAC1B,CAAC,CAAC,WAAW,GAAG,IAAI,CAAC,iBAAiB,CAAC,mBAAmB,CAAC,IAAI,CAAC,UAAU,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC;QACpF,CAAC,CAAC,eAAe,GAAG,IAAI,CAAC,OAAO,CAAC,eAAe,CAAC;QACjD,CAAC,CAAC,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC;QAC3B,CAAC,CAAC,kBAAkB,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,GAAG,CAAC,QAAQ,CAAC,CAAC;QACnE,IAAI,CAAC,iBAAiB,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;QACpC,OAAO,CAAC,CAAC;IACb,CAAC;IAED;;;;OAIG;IACK,WAAW,CAAC,QAAgB,EAAE,IAAY,EAAE,WAA2C;QAC3F,MAAM,CAAC,GAAG,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QAChC,IAAI,CAAC,KAAK,SAAS;YAAE,OAAO,IAAI,0BAAW,CAAC,IAAI,EAAE,EAAE,EAAE,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC,CAAC;QACpF,OAAO,IAAI,0BAAW,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC,SAAS,CAAC,CAAC;IACvF,CAAC;IAED;;;;OAIG;IACK,iBAAiB,CAAC,CAAmB,EAAE,QAAsB;QACjE,CAAC,CAAC,gBAAgB,GAAG,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC;QAC7C,CAAC,CAAC,cAAc,GAAG,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,MAAM,CAAC;QAClG,CAAC,CAAC,aAAa,GAAG,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;QAC3C,CAAC,CAAC,YAAY,GAAG,QAAQ,CAAC,YAAY,CAAC;QACvC,CAAC,CAAC,YAAY,GAAG,QAAQ,CAAC,YAAY,CAAC;QACvC,CAAC,CAAC,aAAa,GAAG,QAAQ,CAAC,aAAa,CAAC;QACzC,CAAC,CAAC,eAAe,GAAG,QAAQ,CAAC,eAAe,CAAC;QAC7C,CAAC,CAAC,YAAY,GAAG,QAAQ,CAAC,YAAY,CAAC;IAC3C,CAAC;IAED;;;;OAIG;IACK,cAAc,CAAC,QAAsB,EAAE,QAAgB;QAC3D,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,QAAQ,EAAE,GAAG,QAAQ,KAAK,CAAC,CAAC;QAChE,MAAM,GAAG,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC;QACxH,OAAO,GAAG,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;IAClF,CAAC;IAED;;;;OAIG;IACK,aAAa,CAAC,QAAgB,EAAE,KAAwB;QAC5D,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;QAC/B,KAAK,MAAM,CAAC,IAAI,KAAK;YAAE,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACzE,OAAO,CAAC,GAAG,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC;IAC5B,CAAC;IAED;;;;;;;;;;;OAWG;IACK,cAAc,CAAC,QAAgB,EAAE,MAAoB;QACzD,MAAM,OAAO,GAAmB,EAAE,CAAC;QACnC,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,qBAAqB;YAAE,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC,CAAC;QACjG,KAAK,MAAM,IAAI,IAAI,MAAM,CAAC,aAAa,EAAE,CAAC;YACtC,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;YAC9C,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC;gBAC3B,CAAC,CAAC,IAAI,2BAAY,CAAC,IAAI,CAAC,KAAK,EAAE,GAAG,CAAC;gBACnC,CAAC,CAAC,IAAI,2BAAY,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,EAAE,mBAAmB,IAAI,CAAC,IAAI,gBAAgB,CAAC,CAAC,CAAC;QAC1F,CAAC;QACD,OAAO,OAAO,CAAC;IACnB,CAAC;IAEO,cAAc,CAAC,QAAgB,EAAE,GAAW;QAChD,oHAAoH;QACpH,8DAA8D;QAC9D,IAAI,CAAC;YACD,MAAM,YAAY,GAAG,OAAO,CAAC,OAAO,CAAC,GAAG,GAAG,eAAe,EAAE,EAAE,KAAK,EAAE,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;YACnF,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;YACvC,sFAAsF;YACtF,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,YAAY,CAAC,YAAY,EAAE,MAAM,CAAC,CAA4B,CAAC;YAC1F,MAAM,IAAI,GAAG,OAAO,IAAI,CAAC,aAAa,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,IAAI,CAAC,aAAa,CAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5F,OAAO,IAAI,2BAAY,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,GAAG,MAAM,IAAI,EAAE,EAAE,GAAG,CAAC,CAAC;QACzE,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,sBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,KAAK,KAAK,CAAC,CAAC,yDAAyD;YACrE,OAAO,IAAI,2BAAY,CAAC,GAAG,EAAE,EAAE,EAAE,+DAA+D,CAAC,CAAC;QACtG,CAAC;IACL,CAAC;CACJ,CAAA;AA7HY,0DAAuB;kCAAvB,uBAAuB;IADnC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAEW,gCAAiB;GADxD,uBAAuB,CA6HnC","sourcesContent":["import * as fs from 'fs';\nimport * as path from 'path';\nimport {\n    BriefedFile, ContextEntry, PrGateConfig, RequiredChecklist, ReviewerBriefing, ReviewJsonService, toError,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { DiffManifest, DiffManifestEntry } from './diff-materializer';\nimport { ChecklistScan } from './checklist-scanner';\n\n/**\n * Turns a {@link ChecklistScan} plus the materialized {@link DiffManifest} into one {@link ReviewerBriefing}\n * per reviewer — resolving every path to an absolute one, because a reviewer that has to resolve a path\n * ends up searching, and searching is the cost this whole feature exists to remove.\n *\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewerBriefingBuilder {\n    constructor(private readonly reviewJsonService: ReviewJsonService) {}\n\n    build(repoRoot: string, scan: ChecklistScan, manifest: DiffManifest, diffDir: string, config: PrGateConfig): ReviewerBriefing[] {\n        // Resolved ONCE for the whole run, not per reviewer: `require.resolve` hits the filesystem, and the\n        // answer cannot differ between two reviewers in the same process.\n        const shared = this.contextEntries(repoRoot, config);\n        const entryByFile = new Map<string, DiffManifestEntry>();\n        for (const e of manifest.entries) entryByFile.set(e.file, e);\n        return scan.applicable.map((req: RequiredChecklist): ReviewerBriefing =>\n            this.one(repoRoot, req, scan, entryByFile, diffDir, shared, manifest));\n    }\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    private one(\n        repoRoot: string, req: RequiredChecklist, scan: ChecklistScan,\n        entryByFile: Map<string, DiffManifestEntry>, diffDir: string, shared: ContextEntry[], manifest: DiffManifest,\n    ): ReviewerBriefing {\n        const b = new ReviewerBriefing(req.subagent, req.id, repoRoot);\n        b.docPath = req.doc.trim() === '' ? '' : path.resolve(repoRoot, req.doc);\n        b.diffDir = diffDir;\n        b.allDiffPath = diffDir === '' ? '' : path.join(diffDir, 'ALL.diff');\n        b.manifestPath = diffDir === '' ? '' : path.join(diffDir, 'manifest.json');\n        b.myFiles = req.matchedFiles.map((f: string): BriefedFile => this.briefedFile(repoRoot, f, entryByFile));\n        b.matchedPatterns = req.matchedPatterns;\n        b.required = req.required;\n        b.sourceDirs = this.sourceDirsFor(repoRoot, req.matchedFiles);\n        b.contextEntries = shared;\n        b.verdictPath = this.reviewJsonService.checklistResultPath(scan.reviewPath, req.id);\n        b.fileDiffCommand = scan.context.fileDiffCommand;\n        b.dirty = scan.basis.dirty;\n        b.ownAgentFileInDiff = this.ownAgentFileIn(manifest, req.subagent);\n        this.copyManifestFacts(b, manifest);\n        return b;\n    }\n\n    /**\n     * One row of the reviewer's table. The SOURCE path comes over with the diff path because the two need\n     * identical affordance: when the diff was an absolute path and the source was a parent directory, four of\n     * four reviewers read the diff and none opened a source file.\n     */\n    private briefedFile(repoRoot: string, file: string, entryByFile: Map<string, DiffManifestEntry>): BriefedFile {\n        const e = entryByFile.get(file);\n        if (e === undefined) return new BriefedFile(file, '', path.resolve(repoRoot, file));\n        return new BriefedFile(file, e.diffAbs, e.fileAbs, e.status, e.bytes, e.truncated);\n    }\n\n    /**\n     * Manifest headline facts, copied onto the briefing so the instructions can state them INLINE. A reviewer\n     * that never opens the manifest still has to learn whether anything was truncated or excluded — that is\n     * precisely the thing it could not otherwise know it was missing.\n     */\n    private copyManifestFacts(b: ReviewerBriefing, manifest: DiffManifest): void {\n        b.changedFileCount = manifest.entries.length;\n        b.truncatedCount = manifest.entries.filter((e: DiffManifestEntry): boolean => e.truncated).length;\n        b.excludedCount = manifest.excluded.length;\n        b.allDiffLines = manifest.allDiffLines;\n        b.allDiffBytes = manifest.allDiffBytes;\n        b.hashForkPoint = manifest.hashForkPoint;\n        b.hashFeatureHead = manifest.hashFeatureHead;\n        b.hashMainHead = manifest.hashMainHead;\n    }\n\n    /**\n     * The reviewer's own `.claude/agents/<subagent>.md`, when THIS diff changes it. Detected here rather than\n     * left to the reviewer to notice: on the measured run two reviewers reviewed their own definition and\n     * neither mentioned it, and every PR that edits the review gate reproduces that.\n     */\n    private ownAgentFileIn(manifest: DiffManifest, subagent: string): string {\n        const suffix = path.join('.claude', 'agents', `${subagent}.md`);\n        const hit = manifest.entries.find((e: DiffManifestEntry): boolean => e.file.split('/').join(path.sep).endsWith(suffix));\n        return hit === undefined ? '' : (hit.fileAbs === '' ? hit.file : hit.fileAbs);\n    }\n\n    /**\n     * Deduped absolute parent dirs of the matched files. Dirs rather than files because the point is to say\n     * \"the neighbourhood is here\" — a reviewer already has the file list; what it lacks is where to look for\n     * the code AROUND the change.\n     */\n    private sourceDirsFor(repoRoot: string, files: readonly string[]): string[] {\n        const dirs = new Set<string>();\n        for (const f of files) dirs.add(path.resolve(repoRoot, path.dirname(f)));\n        return [...dirs].sort();\n    }\n\n    /**\n     * The pre-resolved context list, from two config keys with deliberately different jobs:\n     *\n     * `reviewContextPackages` — installed packages, resolved to their real on-disk dir. This is what deletes\n     *   the repeated `node_modules/@webpieces` greps: the tooling knows where a package resolved to, and the\n     *   reviewer does not.\n     * `reviewContext` — the repo-specific escape hatch (`{label, path}`) for what tooling cannot possibly\n     *   guess, e.g. \"queue names live in terraform/services/\".\n     *\n     * Neither ever drops an entry: an unresolvable package or a missing path is LISTED, with the reason. A\n     * silently shorter list is indistinguishable from a complete one.\n     */\n    private contextEntries(repoRoot: string, config: PrGateConfig): ContextEntry[] {\n        const entries: ContextEntry[] = [];\n        for (const pkg of config.reviewContextPackages) entries.push(this.resolvePackage(repoRoot, pkg));\n        for (const item of config.reviewContext) {\n            const abs = path.resolve(repoRoot, item.path);\n            entries.push(fs.existsSync(abs)\n                ? new ContextEntry(item.label, abs)\n                : new ContextEntry(item.label, '', `(configured as \"${item.path}\" but missing)`));\n        }\n        return entries;\n    }\n\n    private resolvePackage(repoRoot: string, pkg: string): ContextEntry {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: an unresolvable package is REPORTED as such, never fatal\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            const manifestPath = require.resolve(`${pkg}/package.json`, { paths: [repoRoot] });\n            const dir = path.dirname(manifestPath);\n            // webpieces-disable no-any-unknown -- opaque package.json, only `description` is read\n            const meta = JSON.parse(fs.readFileSync(manifestPath, 'utf8')) as Record<string, unknown>;\n            const desc = typeof meta['description'] === 'string' ? (meta['description'] as string) : '';\n            return new ContextEntry(desc === '' ? pkg : `${pkg} — ${desc}`, dir);\n        } catch (err: unknown) {\n            const error = toError(err);\n            void error; // an unresolvable package is REPORTED below, never fatal\n            return new ContextEntry(pkg, '', '(not installed — configured in pr-gate.reviewContextPackages)');\n        }\n    }\n}\n"]}

package/src/scripts/workflow/reviewer-verdict-gate.d.ts

@@ -41,6 +41,16 @@ export declare class ReviewerVerdictGate {
      * and reads as though nobody had looked. It is the sentence that framed a decision as an omission.
      */
     private headline;
+    /**
+     * The optional checklists nobody ran, stated OUT LOUD on the refusal.
+     *
+     * They are not why the PR is being refused and this block says so — but a message that lists only what
+     * blocked reads as "everything else was reviewed", and here that is false: those reviews were declined,
+     * not passed. The one moment a human is looking at the review state is the moment to be honest about
+     * which reviews did not happen, and it is also the prompt an AI needs to offer them again if the human
+     * has changed their mind now that something else came back red.
+     */
+    private skippedNote;
     private unreadableSection;
     /**
      * The refusals — SECOND, above anything that says to spawn a subagent, because a spawn instruction is the

package/src/scripts/workflow/reviewer-verdict-gate.js

@@ -74,7 +74,23 @@ let ReviewerVerdictGate = class ReviewerVerdictGate {
         if (neverRan.length > 0) {
             lines.push(`  • ${neverRan.length} never ran — no verdict has been written yet: ${this.instructions.names(neverRan)}`);
         }
-        return lines.join('\n') + '\n\n';
+        return lines.join('\n') + this.skippedNote(scan) + '\n\n';
+    }
+    /**
+     * The optional checklists nobody ran, stated OUT LOUD on the refusal.
+     *
+     * They are not why the PR is being refused and this block says so — but a message that lists only what
+     * blocked reads as "everything else was reviewed", and here that is false: those reviews were declined,
+     * not passed. The one moment a human is looking at the review state is the moment to be honest about
+     * which reviews did not happen, and it is also the prompt an AI needs to offer them again if the human
+     * has changed their mind now that something else came back red.
+     */
+    skippedNote(scan) {
+        if (scan.optionalNotRun.length === 0)
+            return '';
+        return `\n  (Not blocking: ${scan.optionalNotRun.length} OPTIONAL checklist(s) were not run — `
+            + `${this.instructions.names(scan.optionalNotRun)}. They do not have to run; re-run\n`
+            + '   pnpm wp-review-upsert-pr if you now want to offer them.)';
     }
     // Unreadable verdict files come FIRST. A reviewer that wrote its verdict in the removed `success` format
     // is otherwise indistinguishable from one that never ran, and the AI would go re-run a subagent instead

package/src/scripts/workflow/reviewer-verdict-gate.js.map

@@ -1 +1 @@
-{"version":3,"file":"reviewer-verdict-gate.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/reviewer-verdict-gate.ts"],"names":[],"mappings":";;;;AAAA,0DAEiC;AACjC,yCAA2D;AAG3D;;;;;;;;;;;;;;;;;;;;GAoBG;AAEI,IAAM,mBAAmB,GAAzB,MAAM,mBAAmB;IAEP;IACA;IAFrB,YACqB,iBAAoC,EACpC,YAA0C;QAD1C,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,iBAAY,GAAZ,YAAY,CAA8B;IAC5D,CAAC;IAEJ;;;;;;;OAOG;IACH,sBAAsB,CAAC,IAAmB;QACtC,IAAI,IAAI,CAAC,WAAW,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAC1C,qGAAqG;QACrG,kGAAkG;QAClG,gGAAgG;QAChG,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,IAAI,CAAC,WAAW,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QACzF,MAAM,UAAU,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QAChF,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QACnG,qGAAqG;QACrG,kGAAkG;QAClG,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,GAAsB,EAAU,EAAE,CAAC,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,CAAC;QAClG,MAAM,IAAI,4BAAa,CACnB,IAAI,CAAC,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,CAAC;cACpC,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC;cAC5B,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC;cAC7B,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,QAAQ,CAAC;cACpC,IAAI,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC,CAAC,CACpC,CAAC;IACN,CAAC;IAED;;;;;OAKG;IACK,QAAQ,CAAC,IAAmB,EAAE,OAAqC,EAAE,QAAsC;QAC/G,MAAM,KAAK,GAAG;YACV,aAAa,IAAI,CAAC,WAAW,CAAC,MAAM,OAAO,IAAI,CAAC,UAAU,CAAC,MAAM,+DAA+D;SACnI,CAAC;QACF,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,KAAK,CAAC,IAAI,CAAC,OAAO,OAAO,CAAC,MAAM,+DAA+D,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACvI,CAAC;QACD,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,KAAK,CAAC,IAAI,CAAC,OAAO,QAAQ,CAAC,MAAM,iDAAiD,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;QAC3H,CAAC;QACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC;IACrC,CAAC;IAED,yGAAyG;IACzG,wGAAwG;IACxG,yCAAyC;IACjC,iBAAiB,CAAC,IAAmB;QACzC,IAAI,IAAI,CAAC,YAAY,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAC9C,OAAO,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,mDAAmD;cAC/E,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC;IACvF,CAAC;IAED;;;OAGG;IACK,cAAc,CAAC,QAA2B;QAC9C,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,OAAO,kGAAkG;cACnG,yGAAyG;cACzG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,GAAG,MAAM,CAAC;IAChF,CAAC;IAED;;;;OAIG;IACK,eAAe,CAAC,IAAmB,EAAE,QAAsC;QAC/E,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,OAAO,0FAA0F;cAC3F,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,QAAQ,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC;IACrF,CAAC;IAED;;;;;;;;;;;;OAYG;IACK,eAAe,CAAC,IAAmB,EAAE,GAAsB;QAC/D,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAAC,GAAG,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QACzE,OAAO,IAAI,CAAC,iBAAiB,CAAC,YAAY,CAAC,GAAG,EAAE,OAAO,EAAE,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,UAAU,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC,CAAC;IAC1G,CAAC;IAED,mGAAmG;IAC3F,aAAa,CAAC,UAAkB,EAAE,WAAmB;QACzD,yHAAyH;QACzH,8DAA8D;QAC9D,IAAI,CAAC;YACD,OAAO,IAAI,CAAC,iBAAiB,CAAC,sBAAsB,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC;QAClF,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,sBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,iDAAiD,WAAW,sCAAsC;kBAChG,oBAAoB,KAAK,CAAC,OAAO,IAAI,CAAC,CAAC;YAC7C,OAAO,EAAE,CAAC;QACd,CAAC;IACL,CAAC;IAED,yGAAyG;IACzG,0GAA0G;IAC1G,2BAA2B;IACnB,MAAM,CAAC,UAAmB;QAC9B,IAAI,UAAU,EAAE,CAAC;YACb,OAAO,mGAAmG;kBACpG,2FAA2F,CAAC;QACtG,CAAC;QACD,OAAO,yCAAyC;cAC1C,0GAA0G;cAC1G,oDAAoD,CAAC;IAC/D,CAAC;CACJ,CAAA;AAjIY,kDAAmB;8BAAnB,mBAAmB;IAD/B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGG,gCAAiB;QACtB,2CAA4B;GAHtD,mBAAmB,CAiI/B","sourcesContent":["import {\n    ChecklistInstructionsService, InformAiError, RequiredChecklist, ReviewJsonService, toError,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { ChecklistScan } from './checklist-scanner';\n\n/**\n * The gate `wp-finish-upsert-pr` runs before it parses review.json: REFUSE the PR while any applicable\n * checklist is not clear, and say — per checklist — which of three different things went wrong.\n *\n * It is its own class, not a private method on the command, for two reasons. It is the one piece of finish\n * that both MUTATES the branch (it retires red verdicts) and produces the text an AI acts on, so it is the\n * piece most worth asserting on directly; and the command it came out of is already the largest file in this\n * package, against a hard `@webpieces/max-file-lines` limit.\n *\n * THE BUG THIS EXISTS TO FIX. The message used to be one bucket and one imperative — \"You MUST run these N\n * reviewer subagent(s)\" — for three unrelated states. Handed to an agent, the literal, obedient response for\n * a checklist that had ALREADY REFUSED was to spawn the reviewer again; it re-read the same unchanged code,\n * refused again, and the loop cost a full subagent run per pass while the reviewer's actual finding was\n * never printed at all. Three states, three actions, in this order:\n *\n *   1. UNREADABLE (`scan.formatErrors`) -> fix four characters of JSON. Not a reviewer problem.\n *   2. REFUSED (CK_FAIL)                -> fix the finding (or get a HUMAN override). Not a missing step.\n *   3. NEVER RAN (the rest)             -> spawn the subagent. The ONLY case where that is the right move.\n *\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewerVerdictGate {\n    constructor(\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly instructions: ChecklistInstructionsService,\n    ) {}\n\n    /**\n     * Refuse the PR while ANY applicable checklist still owes a passing verdict — naming exactly what each\n     * one needs. No-op for a repo with no applicable checklists.\n     *\n     * SIDE EFFECT, deliberately: every REFUSED checklist's verdict file is RETIRED to review-<id>.json.old on\n     * the way out (see {@link retireAndReport}). Only red verdicts are ever moved — a green, yellow or\n     * overridden one is reused across finish attempts and retiring it would force a needless subagent re-run.\n     */\n    assertEveryReviewerRan(scan: ChecklistScan): void {\n        if (scan.outstanding.length === 0) return;\n        // The split is computed from the verdicts the SCAN already loaded, never from a second read of disk:\n        // a re-read here could disagree with the set that produced `outstanding`, and a checklist that is\n        // \"outstanding\" per one read and \"clear\" per another belongs to neither section of the message.\n        const refused = this.reviewJsonService.refusedChecklists(scan.outstanding, scan.results);\n        const refusedIds = new Set(refused.map((r: RequiredChecklist): string => r.id));\n        const neverRan = scan.outstanding.filter((r: RequiredChecklist): boolean => !refusedIds.has(r.id));\n        // Rendered BEFORE the throw and, per checklist, with the verdict resolved before its file is moved —\n        // the message quotes the reviewer's own words, so losing them to the move would defeat the point.\n        const refusals = refused.map((req: RequiredChecklist): string => this.retireAndReport(scan, req));\n        throw new InformAiError(\n            this.headline(scan, refused, neverRan)\n            + this.unreadableSection(scan)\n            + this.refusedSection(refusals)\n            + this.neverRanSection(scan, neverRan)\n            + this.footer(refused.length > 0),\n        );\n    }\n\n    /**\n     * Say plainly how many REFUSED and how many never ran.\n     *\n     * The old headline said all of them \"have no passing verdict yet\", which is technically true of a refusal\n     * and reads as though nobody had looked. It is the sentence that framed a decision as an omission.\n     */\n    private headline(scan: ChecklistScan, refused: readonly RequiredChecklist[], neverRan: readonly RequiredChecklist[]): string {\n        const lines = [\n            `⛔ NO PR — ${scan.outstanding.length} of ${scan.applicable.length} review checklist(s) that apply to this branch are not clear:`,\n        ];\n        if (refused.length > 0) {\n            lines.push(`  • ${refused.length} REFUSED — a reviewer ran, judged this change, and said no: ${this.instructions.names(refused)}`);\n        }\n        if (neverRan.length > 0) {\n            lines.push(`  • ${neverRan.length} never ran — no verdict has been written yet: ${this.instructions.names(neverRan)}`);\n        }\n        return lines.join('\\n') + '\\n\\n';\n    }\n\n    // Unreadable verdict files come FIRST. A reviewer that wrote its verdict in the removed `success` format\n    // is otherwise indistinguishable from one that never ran, and the AI would go re-run a subagent instead\n    // of correcting four characters of JSON.\n    private unreadableSection(scan: ChecklistScan): string {\n        if (scan.formatErrors.length === 0) return '';\n        return `${scan.formatErrors.length} verdict file(s) are in an UNREADABLE format:\\n\\n`\n            + scan.formatErrors.map((e: string): string => `  • ${e}`).join('\\n') + '\\n\\n';\n    }\n\n    /**\n     * The refusals — SECOND, above anything that says to spawn a subagent, because a spawn instruction is the\n     * one line an agent acts on first, and acting on it here IS the loop.\n     */\n    private refusedSection(refusals: readonly string[]): string {\n        if (refusals.length === 0) return '';\n        return '⛔ REFUSED — these reviewers ALREADY ANSWERED. Re-spawning one against unchanged code only buys\\n'\n            + '   the same answer: fix what it found (or get a HUMAN to authorize an override), THEN review again.\\n\\n'\n            + refusals.map((r: string): string => `  • ${r}`).join('\\n\\n') + '\\n\\n';\n    }\n\n    /**\n     * The reviewers that genuinely never ran — LAST, and listing ONLY these. When there are none this block\n     * is absent entirely, which is the whole point: the \"You MUST run these N reviewer subagent(s)\"\n     * imperative must not appear at all on a run whose only problem is a refusal.\n     */\n    private neverRanSection(scan: ChecklistScan, neverRan: readonly RequiredChecklist[]): string {\n        if (neverRan.length === 0) return '';\n        return '❓ NO VERDICT YET — nothing has been written for these, so they must actually be run:\\n\\n'\n            + `${this.instructions.render(neverRan, scan.reviewPath, scan.context)}\\n\\n`;\n    }\n\n    /**\n     * Retire ONE refused checklist's verdict and render the refusal that reports it.\n     *\n     * ORDER IS LOAD-BEARING. The verdict is resolved from the already-loaded results, so the finding is in\n     * hand before the file moves; the move then happens; and only then is the message rendered, because it\n     * names the archive path and must not claim a move that did not happen.\n     *\n     * The move is NON-FATAL. A finish that died after retiring a verdict would leave the AI with a red\n     * verdict gone from the live path and no message saying where it went or why the PR was refused — a\n     * silent gap, and the worst possible outcome for a feature whose entire purpose is a durable record. So a\n     * failed move warns and the refusal is reported without an archive path (the file is then still live,\n     * which the un-archived wording of `refusalError` describes correctly).\n     */\n    private retireAndReport(scan: ChecklistScan, req: RequiredChecklist): string {\n        const verdict = this.reviewJsonService.resolveVerdict(req, scan.results);\n        return this.reviewJsonService.refusalError(req, verdict, this.archiveOrWarn(scan.reviewPath, req.id));\n    }\n\n    // The archive path, or '' when there was nothing to move or the move failed (see retireAndReport).\n    private archiveOrWarn(reviewPath: string, checklistId: string): string {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: a failed archive must never swallow the refusal it belongs to\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            return this.reviewJsonService.archiveChecklistResult(reviewPath, checklistId);\n        } catch (err: unknown) {\n            const error = toError(err);\n            process.stderr.write(\n                `⚠️  Could not retire the refused verdict for \"${checklistId}\" (non-fatal — the refusal is still `\n                + `reported below): ${error.message}\\n`);\n            return '';\n        }\n    }\n\n    // Re-running stage 2 is normally optional. It stops being optional after a refusal, because the only way\n    // past one is to CHANGE the code — which is exactly the condition that makes the extracted diff and every\n    // reviewer briefing stale.\n    private footer(anyRefused: boolean): string {\n        if (anyRefused) {\n            return 'Then re-run: pnpm wp-review-upsert-pr (the code changed, so the extracted diff and the reviewer\\n'\n                + 'briefings are stale), re-run the reviewer(s) above, and finally: pnpm wp-finish-upsert-pr';\n        }\n        return 'Then re-run: pnpm wp-finish-upsert-pr\\n'\n            + '(Each reviewer\\'s generated instructions file is already written — re-running pnpm wp-review-upsert-pr\\n'\n            + ' is only needed if the code changed since it ran.)';\n    }\n}\n"]}
+{"version":3,"file":"reviewer-verdict-gate.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/reviewer-verdict-gate.ts"],"names":[],"mappings":";;;;AAAA,0DAEiC;AACjC,yCAA2D;AAG3D;;;;;;;;;;;;;;;;;;;;GAoBG;AAEI,IAAM,mBAAmB,GAAzB,MAAM,mBAAmB;IAEP;IACA;IAFrB,YACqB,iBAAoC,EACpC,YAA0C;QAD1C,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,iBAAY,GAAZ,YAAY,CAA8B;IAC5D,CAAC;IAEJ;;;;;;;OAOG;IACH,sBAAsB,CAAC,IAAmB;QACtC,IAAI,IAAI,CAAC,WAAW,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAC1C,qGAAqG;QACrG,kGAAkG;QAClG,gGAAgG;QAChG,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,IAAI,CAAC,WAAW,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QACzF,MAAM,UAAU,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QAChF,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QACnG,qGAAqG;QACrG,kGAAkG;QAClG,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,GAAsB,EAAU,EAAE,CAAC,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,CAAC;QAClG,MAAM,IAAI,4BAAa,CACnB,IAAI,CAAC,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,CAAC;cACpC,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC;cAC5B,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC;cAC7B,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,QAAQ,CAAC;cACpC,IAAI,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC,CAAC,CACpC,CAAC;IACN,CAAC;IAED;;;;;OAKG;IACK,QAAQ,CAAC,IAAmB,EAAE,OAAqC,EAAE,QAAsC;QAC/G,MAAM,KAAK,GAAG;YACV,aAAa,IAAI,CAAC,WAAW,CAAC,MAAM,OAAO,IAAI,CAAC,UAAU,CAAC,MAAM,+DAA+D;SACnI,CAAC;QACF,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,KAAK,CAAC,IAAI,CAAC,OAAO,OAAO,CAAC,MAAM,+DAA+D,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACvI,CAAC;QACD,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,KAAK,CAAC,IAAI,CAAC,OAAO,QAAQ,CAAC,MAAM,iDAAiD,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;QAC3H,CAAC;QACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC;IAC9D,CAAC;IAED;;;;;;;;OAQG;IACK,WAAW,CAAC,IAAmB;QACnC,IAAI,IAAI,CAAC,cAAc,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAChD,OAAO,sBAAsB,IAAI,CAAC,cAAc,CAAC,MAAM,wCAAwC;cACzF,GAAG,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,IAAI,CAAC,cAAc,CAAC,qCAAqC;cACpF,6DAA6D,CAAC;IACxE,CAAC;IAED,yGAAyG;IACzG,wGAAwG;IACxG,yCAAyC;IACjC,iBAAiB,CAAC,IAAmB;QACzC,IAAI,IAAI,CAAC,YAAY,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAC9C,OAAO,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,mDAAmD;cAC/E,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC;IACvF,CAAC;IAED;;;OAGG;IACK,cAAc,CAAC,QAA2B;QAC9C,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,OAAO,kGAAkG;cACnG,yGAAyG;cACzG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,GAAG,MAAM,CAAC;IAChF,CAAC;IAED;;;;OAIG;IACK,eAAe,CAAC,IAAmB,EAAE,QAAsC;QAC/E,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,OAAO,0FAA0F;cAC3F,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,QAAQ,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC;IACrF,CAAC;IAED;;;;;;;;;;;;OAYG;IACK,eAAe,CAAC,IAAmB,EAAE,GAAsB;QAC/D,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAAC,GAAG,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QACzE,OAAO,IAAI,CAAC,iBAAiB,CAAC,YAAY,CAAC,GAAG,EAAE,OAAO,EAAE,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,UAAU,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC,CAAC;IAC1G,CAAC;IAED,mGAAmG;IAC3F,aAAa,CAAC,UAAkB,EAAE,WAAmB;QACzD,yHAAyH;QACzH,8DAA8D;QAC9D,IAAI,CAAC;YACD,OAAO,IAAI,CAAC,iBAAiB,CAAC,sBAAsB,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC;QAClF,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,sBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,iDAAiD,WAAW,sCAAsC;kBAChG,oBAAoB,KAAK,CAAC,OAAO,IAAI,CAAC,CAAC;YAC7C,OAAO,EAAE,CAAC;QACd,CAAC;IACL,CAAC;IAED,yGAAyG;IACzG,0GAA0G;IAC1G,2BAA2B;IACnB,MAAM,CAAC,UAAmB;QAC9B,IAAI,UAAU,EAAE,CAAC;YACb,OAAO,mGAAmG;kBACpG,2FAA2F,CAAC;QACtG,CAAC;QACD,OAAO,yCAAyC;cAC1C,0GAA0G;cAC1G,oDAAoD,CAAC;IAC/D,CAAC;CACJ,CAAA;AAjJY,kDAAmB;8BAAnB,mBAAmB;IAD/B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGG,gCAAiB;QACtB,2CAA4B;GAHtD,mBAAmB,CAiJ/B","sourcesContent":["import {\n    ChecklistInstructionsService, InformAiError, RequiredChecklist, ReviewJsonService, toError,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { ChecklistScan } from './checklist-scanner';\n\n/**\n * The gate `wp-finish-upsert-pr` runs before it parses review.json: REFUSE the PR while any applicable\n * checklist is not clear, and say — per checklist — which of three different things went wrong.\n *\n * It is its own class, not a private method on the command, for two reasons. It is the one piece of finish\n * that both MUTATES the branch (it retires red verdicts) and produces the text an AI acts on, so it is the\n * piece most worth asserting on directly; and the command it came out of is already the largest file in this\n * package, against a hard `@webpieces/max-file-lines` limit.\n *\n * THE BUG THIS EXISTS TO FIX. The message used to be one bucket and one imperative — \"You MUST run these N\n * reviewer subagent(s)\" — for three unrelated states. Handed to an agent, the literal, obedient response for\n * a checklist that had ALREADY REFUSED was to spawn the reviewer again; it re-read the same unchanged code,\n * refused again, and the loop cost a full subagent run per pass while the reviewer's actual finding was\n * never printed at all. Three states, three actions, in this order:\n *\n *   1. UNREADABLE (`scan.formatErrors`) -> fix four characters of JSON. Not a reviewer problem.\n *   2. REFUSED (CK_FAIL)                -> fix the finding (or get a HUMAN override). Not a missing step.\n *   3. NEVER RAN (the rest)             -> spawn the subagent. The ONLY case where that is the right move.\n *\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewerVerdictGate {\n    constructor(\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly instructions: ChecklistInstructionsService,\n    ) {}\n\n    /**\n     * Refuse the PR while ANY applicable checklist still owes a passing verdict — naming exactly what each\n     * one needs. No-op for a repo with no applicable checklists.\n     *\n     * SIDE EFFECT, deliberately: every REFUSED checklist's verdict file is RETIRED to review-<id>.json.old on\n     * the way out (see {@link retireAndReport}). Only red verdicts are ever moved — a green, yellow or\n     * overridden one is reused across finish attempts and retiring it would force a needless subagent re-run.\n     */\n    assertEveryReviewerRan(scan: ChecklistScan): void {\n        if (scan.outstanding.length === 0) return;\n        // The split is computed from the verdicts the SCAN already loaded, never from a second read of disk:\n        // a re-read here could disagree with the set that produced `outstanding`, and a checklist that is\n        // \"outstanding\" per one read and \"clear\" per another belongs to neither section of the message.\n        const refused = this.reviewJsonService.refusedChecklists(scan.outstanding, scan.results);\n        const refusedIds = new Set(refused.map((r: RequiredChecklist): string => r.id));\n        const neverRan = scan.outstanding.filter((r: RequiredChecklist): boolean => !refusedIds.has(r.id));\n        // Rendered BEFORE the throw and, per checklist, with the verdict resolved before its file is moved —\n        // the message quotes the reviewer's own words, so losing them to the move would defeat the point.\n        const refusals = refused.map((req: RequiredChecklist): string => this.retireAndReport(scan, req));\n        throw new InformAiError(\n            this.headline(scan, refused, neverRan)\n            + this.unreadableSection(scan)\n            + this.refusedSection(refusals)\n            + this.neverRanSection(scan, neverRan)\n            + this.footer(refused.length > 0),\n        );\n    }\n\n    /**\n     * Say plainly how many REFUSED and how many never ran.\n     *\n     * The old headline said all of them \"have no passing verdict yet\", which is technically true of a refusal\n     * and reads as though nobody had looked. It is the sentence that framed a decision as an omission.\n     */\n    private headline(scan: ChecklistScan, refused: readonly RequiredChecklist[], neverRan: readonly RequiredChecklist[]): string {\n        const lines = [\n            `⛔ NO PR — ${scan.outstanding.length} of ${scan.applicable.length} review checklist(s) that apply to this branch are not clear:`,\n        ];\n        if (refused.length > 0) {\n            lines.push(`  • ${refused.length} REFUSED — a reviewer ran, judged this change, and said no: ${this.instructions.names(refused)}`);\n        }\n        if (neverRan.length > 0) {\n            lines.push(`  • ${neverRan.length} never ran — no verdict has been written yet: ${this.instructions.names(neverRan)}`);\n        }\n        return lines.join('\\n') + this.skippedNote(scan) + '\\n\\n';\n    }\n\n    /**\n     * The optional checklists nobody ran, stated OUT LOUD on the refusal.\n     *\n     * They are not why the PR is being refused and this block says so — but a message that lists only what\n     * blocked reads as \"everything else was reviewed\", and here that is false: those reviews were declined,\n     * not passed. The one moment a human is looking at the review state is the moment to be honest about\n     * which reviews did not happen, and it is also the prompt an AI needs to offer them again if the human\n     * has changed their mind now that something else came back red.\n     */\n    private skippedNote(scan: ChecklistScan): string {\n        if (scan.optionalNotRun.length === 0) return '';\n        return `\\n  (Not blocking: ${scan.optionalNotRun.length} OPTIONAL checklist(s) were not run — `\n            + `${this.instructions.names(scan.optionalNotRun)}. They do not have to run; re-run\\n`\n            + '   pnpm wp-review-upsert-pr if you now want to offer them.)';\n    }\n\n    // Unreadable verdict files come FIRST. A reviewer that wrote its verdict in the removed `success` format\n    // is otherwise indistinguishable from one that never ran, and the AI would go re-run a subagent instead\n    // of correcting four characters of JSON.\n    private unreadableSection(scan: ChecklistScan): string {\n        if (scan.formatErrors.length === 0) return '';\n        return `${scan.formatErrors.length} verdict file(s) are in an UNREADABLE format:\\n\\n`\n            + scan.formatErrors.map((e: string): string => `  • ${e}`).join('\\n') + '\\n\\n';\n    }\n\n    /**\n     * The refusals — SECOND, above anything that says to spawn a subagent, because a spawn instruction is the\n     * one line an agent acts on first, and acting on it here IS the loop.\n     */\n    private refusedSection(refusals: readonly string[]): string {\n        if (refusals.length === 0) return '';\n        return '⛔ REFUSED — these reviewers ALREADY ANSWERED. Re-spawning one against unchanged code only buys\\n'\n            + '   the same answer: fix what it found (or get a HUMAN to authorize an override), THEN review again.\\n\\n'\n            + refusals.map((r: string): string => `  • ${r}`).join('\\n\\n') + '\\n\\n';\n    }\n\n    /**\n     * The reviewers that genuinely never ran — LAST, and listing ONLY these. When there are none this block\n     * is absent entirely, which is the whole point: the \"You MUST run these N reviewer subagent(s)\"\n     * imperative must not appear at all on a run whose only problem is a refusal.\n     */\n    private neverRanSection(scan: ChecklistScan, neverRan: readonly RequiredChecklist[]): string {\n        if (neverRan.length === 0) return '';\n        return '❓ NO VERDICT YET — nothing has been written for these, so they must actually be run:\\n\\n'\n            + `${this.instructions.render(neverRan, scan.reviewPath, scan.context)}\\n\\n`;\n    }\n\n    /**\n     * Retire ONE refused checklist's verdict and render the refusal that reports it.\n     *\n     * ORDER IS LOAD-BEARING. The verdict is resolved from the already-loaded results, so the finding is in\n     * hand before the file moves; the move then happens; and only then is the message rendered, because it\n     * names the archive path and must not claim a move that did not happen.\n     *\n     * The move is NON-FATAL. A finish that died after retiring a verdict would leave the AI with a red\n     * verdict gone from the live path and no message saying where it went or why the PR was refused — a\n     * silent gap, and the worst possible outcome for a feature whose entire purpose is a durable record. So a\n     * failed move warns and the refusal is reported without an archive path (the file is then still live,\n     * which the un-archived wording of `refusalError` describes correctly).\n     */\n    private retireAndReport(scan: ChecklistScan, req: RequiredChecklist): string {\n        const verdict = this.reviewJsonService.resolveVerdict(req, scan.results);\n        return this.reviewJsonService.refusalError(req, verdict, this.archiveOrWarn(scan.reviewPath, req.id));\n    }\n\n    // The archive path, or '' when there was nothing to move or the move failed (see retireAndReport).\n    private archiveOrWarn(reviewPath: string, checklistId: string): string {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: a failed archive must never swallow the refusal it belongs to\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            return this.reviewJsonService.archiveChecklistResult(reviewPath, checklistId);\n        } catch (err: unknown) {\n            const error = toError(err);\n            process.stderr.write(\n                `⚠️  Could not retire the refused verdict for \"${checklistId}\" (non-fatal — the refusal is still `\n                + `reported below): ${error.message}\\n`);\n            return '';\n        }\n    }\n\n    // Re-running stage 2 is normally optional. It stops being optional after a refusal, because the only way\n    // past one is to CHANGE the code — which is exactly the condition that makes the extracted diff and every\n    // reviewer briefing stale.\n    private footer(anyRefused: boolean): string {\n        if (anyRefused) {\n            return 'Then re-run: pnpm wp-review-upsert-pr (the code changed, so the extracted diff and the reviewer\\n'\n                + 'briefings are stale), re-run the reviewer(s) above, and finally: pnpm wp-finish-upsert-pr';\n        }\n        return 'Then re-run: pnpm wp-finish-upsert-pr\\n'\n            + '(Each reviewer\\'s generated instructions file is already written — re-running pnpm wp-review-upsert-pr\\n'\n            + ' is only needed if the code changed since it ran.)';\n    }\n}\n"]}

package/src/scripts/wp-review-upsert-pr.js

@@ -5,12 +5,19 @@ require("reflect-metadata");
 const inversify_1 = require("inversify");
 const rules_config_1 = require("@webpieces/rules-config");
 const pr_gate_app_1 = require("./pr-gate-app");
+const review_upsert_pr_command_1 = require("./commands/review-upsert-pr-command");
+const NO_OPTIONAL = '--no-optional';
 // Composition root: build the container and resolve the app so inversify constructs the whole DAG.
 (0, rules_config_1.runMain)(async () => {
     // autobind self-binds every @injectable(Singleton) tooling class (replaces the buildProviderModule registry scan)
     const container = new inversify_1.Container({ autobind: true });
     // Reject `--help`/bogus flags BEFORE the app touches git — an ignored flag must never start the flow.
-    container.get(rules_config_1.CliArgs).assertNoArgs(new rules_config_1.CliUsage('wp-review-upsert-pr', 'Validate the 3-point merge, build it, extract this branch\'s diff, and brief the reviewer subagents.'));
-    await container.get(pr_gate_app_1.PrGateApp).reviewUpsertPr();
+    // An UNDECLARED token is still fatal here: a mistyped `--no-optionl` that was silently ignored would run
+    // the flow with exactly the reviews the caller was trying to skip.
+    const args = container.get(rules_config_1.CliArgs).parse(new rules_config_1.CliUsage('wp-review-upsert-pr', 'Validate the 3-point merge, build it, extract this branch\'s diff, and brief the reviewer subagents.', [new rules_config_1.CliFlag(NO_OPTIONAL, 'The human has ALREADY said to submit without the optional reviews — do not offer them.\n' +
+            '                 Pass this ONLY on their instruction, never on your own judgement. Required\n' +
+            '                 checklists are unaffected, and an optional checklist that already has a red\n' +
+            '                 verdict on this branch still blocks the PR.')]));
+    await container.get(pr_gate_app_1.PrGateApp).reviewUpsertPr(new review_upsert_pr_command_1.ReviewUpsertPrOptions(args.has(NO_OPTIONAL)));
 });
 //# sourceMappingURL=wp-review-upsert-pr.js.map

package/src/scripts/wp-review-upsert-pr.js.map

@@ -1 +1 @@
-{"version":3,"file":"wp-review-upsert-pr.js","sourceRoot":"","sources":["../../../../../../packages/tooling/pr-gate/src/scripts/wp-review-upsert-pr.ts"],"names":[],"mappings":";;;AACA,4BAA0B;AAC1B,yCAAsC;AACtC,0DAAqE;AACrE,+CAA0C;AAE1C,mGAAmG;AACnG,IAAA,sBAAO,EAAC,KAAK,IAAmB,EAAE;IAC9B,kHAAkH;IAClH,MAAM,SAAS,GAAG,IAAI,qBAAS,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;IACpD,sGAAsG;IACtG,SAAS,CAAC,GAAG,CAAC,sBAAO,CAAC,CAAC,YAAY,CAAC,IAAI,uBAAQ,CAC5C,qBAAqB,EACrB,sGAAsG,CACzG,CAAC,CAAC;IACH,MAAM,SAAS,CAAC,GAAG,CAAC,uBAAS,CAAC,CAAC,cAAc,EAAE,CAAC;AACpD,CAAC,CAAC,CAAC","sourcesContent":["#!/usr/bin/env node\nimport 'reflect-metadata';\nimport { Container } from 'inversify';\nimport { runMain, CliArgs, CliUsage } from '@webpieces/rules-config';\nimport { PrGateApp } from './pr-gate-app';\n\n// Composition root: build the container and resolve the app so inversify constructs the whole DAG.\nrunMain(async (): Promise<void> => {\n    // autobind self-binds every @injectable(Singleton) tooling class (replaces the buildProviderModule registry scan)\n    const container = new Container({ autobind: true });\n    // Reject `--help`/bogus flags BEFORE the app touches git — an ignored flag must never start the flow.\n    container.get(CliArgs).assertNoArgs(new CliUsage(\n        'wp-review-upsert-pr',\n        'Validate the 3-point merge, build it, extract this branch\\'s diff, and brief the reviewer subagents.',\n    ));\n    await container.get(PrGateApp).reviewUpsertPr();\n});\n"]}
+{"version":3,"file":"wp-review-upsert-pr.js","sourceRoot":"","sources":["../../../../../../packages/tooling/pr-gate/src/scripts/wp-review-upsert-pr.ts"],"names":[],"mappings":";;;AACA,4BAA0B;AAC1B,yCAAsC;AACtC,0DAA8E;AAC9E,+CAA0C;AAC1C,kFAA4E;AAE5E,MAAM,WAAW,GAAG,eAAe,CAAC;AAEpC,mGAAmG;AACnG,IAAA,sBAAO,EAAC,KAAK,IAAmB,EAAE;IAC9B,kHAAkH;IAClH,MAAM,SAAS,GAAG,IAAI,qBAAS,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;IACpD,sGAAsG;IACtG,yGAAyG;IACzG,mEAAmE;IACnE,MAAM,IAAI,GAAG,SAAS,CAAC,GAAG,CAAC,sBAAO,CAAC,CAAC,KAAK,CAAC,IAAI,uBAAQ,CAClD,qBAAqB,EACrB,sGAAsG,EACtG,CAAC,IAAI,sBAAO,CACR,WAAW,EACX,0FAA0F;YAC1F,+FAA+F;YAC/F,gGAAgG;YAChG,8DAA8D,CAAC,CAAC,CACvE,CAAC,CAAC;IACH,MAAM,SAAS,CAAC,GAAG,CAAC,uBAAS,CAAC,CAAC,cAAc,CAAC,IAAI,gDAAqB,CAAC,IAAI,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;AACpG,CAAC,CAAC,CAAC","sourcesContent":["#!/usr/bin/env node\nimport 'reflect-metadata';\nimport { Container } from 'inversify';\nimport { runMain, CliArgs, CliFlag, CliUsage } from '@webpieces/rules-config';\nimport { PrGateApp } from './pr-gate-app';\nimport { ReviewUpsertPrOptions } from './commands/review-upsert-pr-command';\n\nconst NO_OPTIONAL = '--no-optional';\n\n// Composition root: build the container and resolve the app so inversify constructs the whole DAG.\nrunMain(async (): Promise<void> => {\n    // autobind self-binds every @injectable(Singleton) tooling class (replaces the buildProviderModule registry scan)\n    const container = new Container({ autobind: true });\n    // Reject `--help`/bogus flags BEFORE the app touches git — an ignored flag must never start the flow.\n    // An UNDECLARED token is still fatal here: a mistyped `--no-optionl` that was silently ignored would run\n    // the flow with exactly the reviews the caller was trying to skip.\n    const args = container.get(CliArgs).parse(new CliUsage(\n        'wp-review-upsert-pr',\n        'Validate the 3-point merge, build it, extract this branch\\'s diff, and brief the reviewer subagents.',\n        [new CliFlag(\n            NO_OPTIONAL,\n            'The human has ALREADY said to submit without the optional reviews — do not offer them.\\n' +\n            '                 Pass this ONLY on their instruction, never on your own judgement. Required\\n' +\n            '                 checklists are unaffected, and an optional checklist that already has a red\\n' +\n            '                 verdict on this branch still blocks the PR.')],\n    ));\n    await container.get(PrGateApp).reviewUpsertPr(new ReviewUpsertPrOptions(args.has(NO_OPTIONAL)));\n});\n"]}