@webpieces/pr-gate 0.4.535 → 0.4.537

package/src/scripts/workflow/reviewer-verdict-gate.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewer-verdict-gate.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/reviewer-verdict-gate.ts"],"names":[],"mappings":";;;;AAAA,0DAEiC;AACjC,yCAA2D;AAG3D;;;;;;;;;;;;;;;;;;;;GAoBG;AAEI,IAAM,mBAAmB,GAAzB,MAAM,mBAAmB;IAEP;IACA;IAFrB,YACqB,iBAAoC,EACpC,YAA0C;QAD1C,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,iBAAY,GAAZ,YAAY,CAA8B;IAC5D,CAAC;IAEJ;;;;;;;OAOG;IACH,sBAAsB,CAAC,IAAmB;QACtC,IAAI,IAAI,CAAC,WAAW,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAC1C,qGAAqG;QACrG,kGAAkG;QAClG,gGAAgG;QAChG,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,IAAI,CAAC,WAAW,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QACzF,MAAM,UAAU,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QAChF,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QACnG,qGAAqG;QACrG,kGAAkG;QAClG,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,GAAsB,EAAU,EAAE,CAAC,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,CAAC;QAClG,MAAM,IAAI,4BAAa,CACnB,IAAI,CAAC,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,QAAQ,CAAC;cACpC,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC;cAC5B,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC;cAC7B,IAAI,CAAC,eAAe,CAAC,IAAI,EAAE,QAAQ,CAAC;cACpC,IAAI,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC,CAAC,CACpC,CAAC;IACN,CAAC;IAED;;;;;OAKG;IACK,QAAQ,CAAC,IAAmB,EAAE,OAAqC,EAAE,QAAsC;QAC/G,MAAM,KAAK,GAAG;YACV,aAAa,IAAI,CAAC,WAAW,CAAC,MAAM,OAAO,IAAI,CAAC,UAAU,CAAC,MAAM,+DAA+D;SACnI,CAAC;QACF,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,KAAK,CAAC,IAAI,CAAC,OAAO,OAAO,CAAC,MAAM,+DAA+D,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACvI,CAAC;QACD,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,KAAK,CAAC,IAAI,CAAC,OAAO,QAAQ,CAAC,MAAM,iDAAiD,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;QAC3H,CAAC;QACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC;IACrC,CAAC;IAED,yGAAyG;IACzG,wGAAwG;IACxG,yCAAyC;IACjC,iBAAiB,CAAC,IAAmB;QACzC,IAAI,IAAI,CAAC,YAAY,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAC9C,OAAO,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,mDAAmD;cAC/E,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC;IACvF,CAAC;IAED;;;OAGG;IACK,cAAc,CAAC,QAA2B;QAC9C,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,OAAO,kGAAkG;cACnG,yGAAyG;cACzG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,GAAG,MAAM,CAAC;IAChF,CAAC;IAED;;;;OAIG;IACK,eAAe,CAAC,IAAmB,EAAE,QAAsC;QAC/E,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACrC,OAAO,0FAA0F;cAC3F,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,QAAQ,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC;IACrF,CAAC;IAED;;;;;;;;;;;;OAYG;IACK,eAAe,CAAC,IAAmB,EAAE,GAAsB;QAC/D,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAAC,GAAG,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QACzE,OAAO,IAAI,CAAC,iBAAiB,CAAC,YAAY,CAAC,GAAG,EAAE,OAAO,EAAE,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,UAAU,EAAE,GAAG,CAAC,EAAE,CAAC,CAAC,CAAC;IAC1G,CAAC;IAED,mGAAmG;IAC3F,aAAa,CAAC,UAAkB,EAAE,WAAmB;QACzD,yHAAyH;QACzH,8DAA8D;QAC9D,IAAI,CAAC;YACD,OAAO,IAAI,CAAC,iBAAiB,CAAC,sBAAsB,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC;QAClF,CAAC;QAAC,OAAO,GAAY,EAAE,CAAC;YACpB,MAAM,KAAK,GAAG,IAAA,sBAAO,EAAC,GAAG,CAAC,CAAC;YAC3B,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,iDAAiD,WAAW,sCAAsC;kBAChG,oBAAoB,KAAK,CAAC,OAAO,IAAI,CAAC,CAAC;YAC7C,OAAO,EAAE,CAAC;QACd,CAAC;IACL,CAAC;IAED,yGAAyG;IACzG,0GAA0G;IAC1G,2BAA2B;IACnB,MAAM,CAAC,UAAmB;QAC9B,IAAI,UAAU,EAAE,CAAC;YACb,OAAO,mGAAmG;kBACpG,2FAA2F,CAAC;QACtG,CAAC;QACD,OAAO,yCAAyC;cAC1C,0GAA0G;cAC1G,oDAAoD,CAAC;IAC/D,CAAC;CACJ,CAAA;AAjIY,kDAAmB;8BAAnB,mBAAmB;IAD/B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGG,gCAAiB;QACtB,2CAA4B;GAHtD,mBAAmB,CAiI/B","sourcesContent":["import {\n    ChecklistInstructionsService, InformAiError, RequiredChecklist, ReviewJsonService, toError,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { ChecklistScan } from './checklist-scanner';\n\n/**\n * The gate `wp-finish-upsert-pr` runs before it parses review.json: REFUSE the PR while any applicable\n * checklist is not clear, and say — per checklist — which of three different things went wrong.\n *\n * It is its own class, not a private method on the command, for two reasons. It is the one piece of finish\n * that both MUTATES the branch (it retires red verdicts) and produces the text an AI acts on, so it is the\n * piece most worth asserting on directly; and the command it came out of is already the largest file in this\n * package, against a hard `@webpieces/max-file-lines` limit.\n *\n * THE BUG THIS EXISTS TO FIX. The message used to be one bucket and one imperative — \"You MUST run these N\n * reviewer subagent(s)\" — for three unrelated states. Handed to an agent, the literal, obedient response for\n * a checklist that had ALREADY REFUSED was to spawn the reviewer again; it re-read the same unchanged code,\n * refused again, and the loop cost a full subagent run per pass while the reviewer's actual finding was\n * never printed at all. Three states, three actions, in this order:\n *\n *   1. UNREADABLE (`scan.formatErrors`) -> fix four characters of JSON. Not a reviewer problem.\n *   2. REFUSED (CK_FAIL)                -> fix the finding (or get a HUMAN override). Not a missing step.\n *   3. NEVER RAN (the rest)             -> spawn the subagent. The ONLY case where that is the right move.\n *\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ReviewerVerdictGate {\n    constructor(\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly instructions: ChecklistInstructionsService,\n    ) {}\n\n    /**\n     * Refuse the PR while ANY applicable checklist still owes a passing verdict — naming exactly what each\n     * one needs. No-op for a repo with no applicable checklists.\n     *\n     * SIDE EFFECT, deliberately: every REFUSED checklist's verdict file is RETIRED to review-<id>.json.old on\n     * the way out (see {@link retireAndReport}). Only red verdicts are ever moved — a green, yellow or\n     * overridden one is reused across finish attempts and retiring it would force a needless subagent re-run.\n     */\n    assertEveryReviewerRan(scan: ChecklistScan): void {\n        if (scan.outstanding.length === 0) return;\n        // The split is computed from the verdicts the SCAN already loaded, never from a second read of disk:\n        // a re-read here could disagree with the set that produced `outstanding`, and a checklist that is\n        // \"outstanding\" per one read and \"clear\" per another belongs to neither section of the message.\n        const refused = this.reviewJsonService.refusedChecklists(scan.outstanding, scan.results);\n        const refusedIds = new Set(refused.map((r: RequiredChecklist): string => r.id));\n        const neverRan = scan.outstanding.filter((r: RequiredChecklist): boolean => !refusedIds.has(r.id));\n        // Rendered BEFORE the throw and, per checklist, with the verdict resolved before its file is moved —\n        // the message quotes the reviewer's own words, so losing them to the move would defeat the point.\n        const refusals = refused.map((req: RequiredChecklist): string => this.retireAndReport(scan, req));\n        throw new InformAiError(\n            this.headline(scan, refused, neverRan)\n            + this.unreadableSection(scan)\n            + this.refusedSection(refusals)\n            + this.neverRanSection(scan, neverRan)\n            + this.footer(refused.length > 0),\n        );\n    }\n\n    /**\n     * Say plainly how many REFUSED and how many never ran.\n     *\n     * The old headline said all of them \"have no passing verdict yet\", which is technically true of a refusal\n     * and reads as though nobody had looked. It is the sentence that framed a decision as an omission.\n     */\n    private headline(scan: ChecklistScan, refused: readonly RequiredChecklist[], neverRan: readonly RequiredChecklist[]): string {\n        const lines = [\n            `⛔ NO PR — ${scan.outstanding.length} of ${scan.applicable.length} review checklist(s) that apply to this branch are not clear:`,\n        ];\n        if (refused.length > 0) {\n            lines.push(`  • ${refused.length} REFUSED — a reviewer ran, judged this change, and said no: ${this.instructions.names(refused)}`);\n        }\n        if (neverRan.length > 0) {\n            lines.push(`  • ${neverRan.length} never ran — no verdict has been written yet: ${this.instructions.names(neverRan)}`);\n        }\n        return lines.join('\\n') + '\\n\\n';\n    }\n\n    // Unreadable verdict files come FIRST. A reviewer that wrote its verdict in the removed `success` format\n    // is otherwise indistinguishable from one that never ran, and the AI would go re-run a subagent instead\n    // of correcting four characters of JSON.\n    private unreadableSection(scan: ChecklistScan): string {\n        if (scan.formatErrors.length === 0) return '';\n        return `${scan.formatErrors.length} verdict file(s) are in an UNREADABLE format:\\n\\n`\n            + scan.formatErrors.map((e: string): string => `  • ${e}`).join('\\n') + '\\n\\n';\n    }\n\n    /**\n     * The refusals — SECOND, above anything that says to spawn a subagent, because a spawn instruction is the\n     * one line an agent acts on first, and acting on it here IS the loop.\n     */\n    private refusedSection(refusals: readonly string[]): string {\n        if (refusals.length === 0) return '';\n        return '⛔ REFUSED — these reviewers ALREADY ANSWERED. Re-spawning one against unchanged code only buys\\n'\n            + '   the same answer: fix what it found (or get a HUMAN to authorize an override), THEN review again.\\n\\n'\n            + refusals.map((r: string): string => `  • ${r}`).join('\\n\\n') + '\\n\\n';\n    }\n\n    /**\n     * The reviewers that genuinely never ran — LAST, and listing ONLY these. When there are none this block\n     * is absent entirely, which is the whole point: the \"You MUST run these N reviewer subagent(s)\"\n     * imperative must not appear at all on a run whose only problem is a refusal.\n     */\n    private neverRanSection(scan: ChecklistScan, neverRan: readonly RequiredChecklist[]): string {\n        if (neverRan.length === 0) return '';\n        return '❓ NO VERDICT YET — nothing has been written for these, so they must actually be run:\\n\\n'\n            + `${this.instructions.render(neverRan, scan.reviewPath, scan.context)}\\n\\n`;\n    }\n\n    /**\n     * Retire ONE refused checklist's verdict and render the refusal that reports it.\n     *\n     * ORDER IS LOAD-BEARING. The verdict is resolved from the already-loaded results, so the finding is in\n     * hand before the file moves; the move then happens; and only then is the message rendered, because it\n     * names the archive path and must not claim a move that did not happen.\n     *\n     * The move is NON-FATAL. A finish that died after retiring a verdict would leave the AI with a red\n     * verdict gone from the live path and no message saying where it went or why the PR was refused — a\n     * silent gap, and the worst possible outcome for a feature whose entire purpose is a durable record. So a\n     * failed move warns and the refusal is reported without an archive path (the file is then still live,\n     * which the un-archived wording of `refusalError` describes correctly).\n     */\n    private retireAndReport(scan: ChecklistScan, req: RequiredChecklist): string {\n        const verdict = this.reviewJsonService.resolveVerdict(req, scan.results);\n        return this.reviewJsonService.refusalError(req, verdict, this.archiveOrWarn(scan.reviewPath, req.id));\n    }\n\n    // The archive path, or '' when there was nothing to move or the move failed (see retireAndReport).\n    private archiveOrWarn(reviewPath: string, checklistId: string): string {\n        // webpieces-disable no-unmanaged-exceptions -- chokepoint: a failed archive must never swallow the refusal it belongs to\n        // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n        try {\n            return this.reviewJsonService.archiveChecklistResult(reviewPath, checklistId);\n        } catch (err: unknown) {\n            const error = toError(err);\n            process.stderr.write(\n                `⚠️  Could not retire the refused verdict for \"${checklistId}\" (non-fatal — the refusal is still `\n                + `reported below): ${error.message}\\n`);\n            return '';\n        }\n    }\n\n    // Re-running stage 2 is normally optional. It stops being optional after a refusal, because the only way\n    // past one is to CHANGE the code — which is exactly the condition that makes the extracted diff and every\n    // reviewer briefing stale.\n    private footer(anyRefused: boolean): string {\n        if (anyRefused) {\n            return 'Then re-run: pnpm wp-review-upsert-pr (the code changed, so the extracted diff and the reviewer\\n'\n                + 'briefings are stale), re-run the reviewer(s) above, and finally: pnpm wp-finish-upsert-pr';\n        }\n        return 'Then re-run: pnpm wp-finish-upsert-pr\\n'\n            + '(Each reviewer\\'s generated instructions file is already written — re-running pnpm wp-review-upsert-pr\\n'\n            + ' is only needed if the code changed since it ran.)';\n    }\n}\n"]}