@webpieces/pr-gate 0.4.485 → 0.4.487

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webpieces/pr-gate",
-  "version": "0.4.485",
+  "version": "0.4.487",
   "description": "Gated PR system: 3-point squash-merge, merge validation gate, and red/yellow/green PR dashboard. Standalone scripts, no Nx dependency required.",
   "type": "commonjs",
   "main": "./src/index.js",
@@ -25,7 +25,7 @@
     "directory": "packages/tooling/pr-gate"
   },
   "dependencies": {
-    "@webpieces/rules-config": "0.4.485",
+    "@webpieces/rules-config": "0.4.487",
     "@inversifyjs/binding-decorators": "1.1.5",
     "inversify": "7.10.4",
     "reflect-metadata": "0.2.2"

package/src/scripts/commands/checklist-command.d.ts

@@ -1,34 +1,26 @@
-import { RepoRootFinder, ChecklistInstructionsService, ReviewJsonService } from '@webpieces/rules-config';
-import { AiBranchName } from '../workflow/git-readAiBranchName';
-import { ChecklistDetector } from '../workflow/checklist-detector';
+import { RepoRootFinder, ChecklistInstructionsService } from '@webpieces/rules-config';
 import { ChecklistNotice } from '../workflow/checklist-notice';
+import { ChecklistScanner } from '../workflow/checklist-scanner';
 /**
- * `wp-checklist` — READ-ONLY. Answers the one question the coding agent has at review time: *which reviewer
- * subagents do I owe on THIS diff, and what exactly do I tell them?*
+ * `wp-checklist` — ALWAYS SUCCEEDS, always just lists. It answers the one question the coding agent has at
+ * review time: *which reviewer subagents do I owe on this branch, and what exactly do I tell them?*
  *
- * It exists because that answer used to be smeared across `wp-start-upsert-pr`'s output in two partly
- * duplicated blocks, which made the instruction long, drift-prone, and easy to skim past. Now `wp-start`
- * points here, `wp-finish` fails fast against the same computation, and this command is the single place
- * that renders it — via {@link ChecklistInstructionsService}, shared with both.
- *
- * It NEVER mutates the repo beyond refreshing the AI-facing template, and never blocks: a diff owing no
- * review says so and exits 0. Safe to run any number of times.
+ * Safe to run at any time, including mid-work with a dirty tree — uncommitted and untracked files are part
+ * of the diff it matches against (see {@link ChecklistScanner}). It exits 0 in every case: zero checklists
+ * configured, zero matched, or several still outstanding. Reporting is not gating; `wp-finish-upsert-pr` is
+ * the only command that refuses, and it re-uses this exact scan with `filterAlreadyReviewed: true`, so the
+ * two can never disagree about what is owed.
  */
 export declare class ChecklistCommand {
     private readonly repoRootFinder;
-    private readonly aiBranchName;
-    private readonly checklistDetector;
-    private readonly reviewJsonService;
+    private readonly checklistScanner;
     private readonly instructions;
     private readonly checklistNotice;
-    constructor(repoRootFinder: RepoRootFinder, aiBranchName: AiBranchName, checklistDetector: ChecklistDetector, reviewJsonService: ReviewJsonService, instructions: ChecklistInstructionsService, checklistNotice: ChecklistNotice);
+    constructor(repoRootFinder: RepoRootFinder, checklistScanner: ChecklistScanner, instructions: ChecklistInstructionsService, checklistNotice: ChecklistNotice);
     run(): Promise<void>;
-    /**
-     * The whole report. Computed in the same order wp-finish-upsert-pr computes it, from the same services,
-     * so "wp-checklist said I was done" and "wp-finish let me through" can never disagree.
-     */
     private report;
-    private plan;
-    private doneLines;
+    private header;
+    private rosterLines;
+    private why;
     private allDone;
 }

package/src/scripts/commands/checklist-command.js

@@ -4,34 +4,27 @@ exports.ChecklistCommand = void 0;
 const tslib_1 = require("tslib");
 const rules_config_1 = require("@webpieces/rules-config");
 const inversify_1 = require("inversify");
-const git_readAiBranchName_1 = require("../workflow/git-readAiBranchName");
-const checklist_detector_1 = require("../workflow/checklist-detector");
 const checklist_notice_1 = require("../workflow/checklist-notice");
+const checklist_scanner_1 = require("../workflow/checklist-scanner");
 const SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n';
 /**
- * `wp-checklist` — READ-ONLY. Answers the one question the coding agent has at review time: *which reviewer
- * subagents do I owe on THIS diff, and what exactly do I tell them?*
+ * `wp-checklist` — ALWAYS SUCCEEDS, always just lists. It answers the one question the coding agent has at
+ * review time: *which reviewer subagents do I owe on this branch, and what exactly do I tell them?*
  *
- * It exists because that answer used to be smeared across `wp-start-upsert-pr`'s output in two partly
- * duplicated blocks, which made the instruction long, drift-prone, and easy to skim past. Now `wp-start`
- * points here, `wp-finish` fails fast against the same computation, and this command is the single place
- * that renders it — via {@link ChecklistInstructionsService}, shared with both.
- *
- * It NEVER mutates the repo beyond refreshing the AI-facing template, and never blocks: a diff owing no
- * review says so and exits 0. Safe to run any number of times.
+ * Safe to run at any time, including mid-work with a dirty tree — uncommitted and untracked files are part
+ * of the diff it matches against (see {@link ChecklistScanner}). It exits 0 in every case: zero checklists
+ * configured, zero matched, or several still outstanding. Reporting is not gating; `wp-finish-upsert-pr` is
+ * the only command that refuses, and it re-uses this exact scan with `filterAlreadyReviewed: true`, so the
+ * two can never disagree about what is owed.
  */
 let ChecklistCommand = class ChecklistCommand {
     repoRootFinder;
-    aiBranchName;
-    checklistDetector;
-    reviewJsonService;
+    checklistScanner;
     instructions;
     checklistNotice;
-    constructor(repoRootFinder, aiBranchName, checklistDetector, reviewJsonService, instructions, checklistNotice) {
+    constructor(repoRootFinder, checklistScanner, instructions, checklistNotice) {
         this.repoRootFinder = repoRootFinder;
-        this.aiBranchName = aiBranchName;
-        this.checklistDetector = checklistDetector;
-        this.reviewJsonService = reviewJsonService;
+        this.checklistScanner = checklistScanner;
         this.instructions = instructions;
         this.checklistNotice = checklistNotice;
     }
@@ -39,56 +32,56 @@ let ChecklistCommand = class ChecklistCommand {
         const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());
         // Refresh the long-form doc so the block below can cite a file that is present and current.
         (0, rules_config_1.writeTemplate)(repoRoot, 'webpieces.review-checklists.md');
-        process.stdout.write('\n' + SEP + '📋 Review checklists for this diff\n' + SEP + '\n');
-        process.stdout.write(this.report(repoRoot));
+        process.stdout.write('\n' + SEP + '📋 Review checklists for this branch\n' + SEP + '\n');
+        // filterAlreadyReviewed:false — LIST everything that applies, marking what is already done. Hiding the
+        // done ones would make a second run look like it found fewer checklists than the first.
+        const defined = (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists;
+        process.stdout.write(this.report(this.checklistScanner.scan(repoRoot, defined, new checklist_scanner_1.ChecklistScanOptions(false))));
         return Promise.resolve();
     }
-    /**
-     * The whole report. Computed in the same order wp-finish-upsert-pr computes it, from the same services,
-     * so "wp-checklist said I was done" and "wp-finish let me through" can never disagree.
-     */
-    report(repoRoot) {
-        // loadAndValidate is the ONE gate: it rejects a structurally bad `checklists` (including the removed
-        // { doc } manifest shape) AND checks that every guidance doc + reviewer agent file exists. So reaching
-        // here means the set is valid — there is no "configured but silently broken" state left to report.
-        const defs = (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists;
-        const triggered = this.checklistDetector.detectForRepo(repoRoot, defs);
-        if (triggered.length === 0) {
+    report(scan) {
+        if (scan.applicable.length === 0) {
             // Zero is a SUPPORTED state, never a blocker (see ChecklistNotice).
-            return this.checklistNotice.build(defs.length, 'wp-finish-upsert-pr');
+            return this.checklistNotice.build(scan.defined.length, 'wp-finish-upsert-pr');
         }
-        return this.plan(repoRoot, defs, triggered);
+        const reviewedIds = new Set(scan.reviewed.map((r) => r.id));
+        const owed = scan.applicable.filter((r) => !reviewedIds.has(r.id));
+        return (this.header(scan) +
+            this.rosterLines(scan, owed) +
+            (owed.length === 0 ? this.allDone() : `\n${this.instructions.render(owed, scan.reviewPath, scan.context)}\n`));
+    }
+    // State the base out loud: a reader (and a reviewer) needs to know the diff was taken from the fork point
+    // of main and that uncommitted work counted, because both change which checklists fired.
+    header(scan) {
+        const base = scan.forkPoint === '' ? 'no fork point resolved' : `fork point ${scan.forkPoint.slice(0, 8)}`;
+        return `${scan.defined.length} checklist(s) configured, ${scan.applicable.length} apply to this branch\n` +
+            `(${base}, including uncommitted + untracked work).\n\n`;
     }
-    // The triggered set split into "already reviewed on this branch" (reused, not re-run) and "still owed".
-    plan(repoRoot, defs, triggered) {
-        const featureName = this.aiBranchName.getFeatureName();
-        const reviewPath = (0, rules_config_1.reviewJsonPath)(repoRoot, featureName);
-        const required = this.checklistDetector.toRequired(triggered);
-        const results = this.reviewJsonService.loadChecklistResults(reviewPath, required);
-        const pending = this.reviewJsonService.pendingChecklists(required, results);
-        const done = required.filter((r) => !pending.includes(r));
-        const context = this.reviewJsonService.reviewContextFor(repoRoot, featureName);
-        return (`${defs.length} checklist(s) configured, ${required.length} apply to this diff.\n` +
-            this.doneLines(done) +
-            (pending.length === 0 ? this.allDone() : `\n${this.instructions.render(pending, reviewPath, context)}\n`));
+    // REVIEW ONCE, PER SUBAGENT: a checklist with a passing verdict is reused, not re-run. 2 of 4 done means
+    // the other 2 still need running, so both groups are shown and only the owed ones become instructions.
+    rosterLines(scan, owed) {
+        const lines = scan.reviewed.map((r) => `  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)\n`);
+        for (const r of owed)
+            lines.push(`  ▶ ${r.subagent} — ${this.why(r)}\n`);
+        return lines.join('');
     }
-    // REVIEW ONCE PER BRANCH: verdict files persist in .webpieces, so a second cycle re-instructs nothing.
-    doneLines(done) {
-        if (done.length === 0)
-            return '';
-        return done.map((r) => `  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)\n`).join('');
+    // Why this one is in scope. A patternless checklist is NOT "matched" — it always runs, over the whole diff.
+    why(req) {
+        if (req.matchedPatterns.length === 0)
+            return 'ALWAYS RUNS (no patterns), whole diff in scope';
+        const globs = req.matchedPatterns.map((p) => `"${p}"`).join(', ');
+        return `${req.matchedFiles.length} file(s) matched ${globs}`;
     }
     allDone() {
-        return '\n✅ Every checklist that applies is already reviewed — nothing to run.\n   Write review.json and run:  pnpm wp-finish-upsert-pr\n';
+        return '\n✅ Every checklist that applies is already reviewed — nothing to run.\n' +
+            '   Write review.json and run:  pnpm wp-finish-upsert-pr\n';
     }
 };
 exports.ChecklistCommand = ChecklistCommand;
 exports.ChecklistCommand = ChecklistCommand = tslib_1.__decorate([
     (0, inversify_1.injectable)(inversify_1.bindingScopeValues.Singleton),
     tslib_1.__metadata("design:paramtypes", [rules_config_1.RepoRootFinder,
-        git_readAiBranchName_1.AiBranchName,
-        checklist_detector_1.ChecklistDetector,
-        rules_config_1.ReviewJsonService,
+        checklist_scanner_1.ChecklistScanner,
         rules_config_1.ChecklistInstructionsService,
         checklist_notice_1.ChecklistNotice])
 ], ChecklistCommand);

package/src/scripts/commands/checklist-command.js.map

@@ -1 +1 @@
-{"version":3,"file":"checklist-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/checklist-command.ts"],"names":[],"mappings":";;;;AAAA,0DAGiC;AACjC,yCAA2D;AAC3D,2EAAgE;AAChE,uEAAuF;AACvF,mEAA+D;AAE/D,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE;;;;;;;;;;;GAWG;AAEI,IAAM,gBAAgB,GAAtB,MAAM,gBAAgB;IAEJ;IACA;IACA;IACA;IACA;IACA;IANrB,YACqB,cAA8B,EAC9B,YAA0B,EAC1B,iBAAoC,EACpC,iBAAoC,EACpC,YAA0C,EAC1C,eAAgC;QALhC,mBAAc,GAAd,cAAc,CAAgB;QAC9B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,iBAAY,GAAZ,YAAY,CAA8B;QAC1C,oBAAe,GAAf,eAAe,CAAiB;IAClD,CAAC;IAEJ,GAAG;QACC,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,4FAA4F;QAC5F,IAAA,4BAAa,EAAC,QAAQ,EAAE,gCAAgC,CAAC,CAAC;QAC1D,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,sCAAsC,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACvF,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC;QAC5C,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC7B,CAAC;IAED;;;OAGG;IACK,MAAM,CAAC,QAAgB;QAC3B,qGAAqG;QACrG,uGAAuG;QACvG,mGAAmG;QACnG,MAAM,IAAI,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC;QACzD,MAAM,SAAS,GAAG,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QACvE,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzB,oEAAoE;YACpE,OAAO,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC;QAC1E,CAAC;QACD,OAAO,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,EAAE,SAAS,CAAC,CAAC;IAChD,CAAC;IAED,wGAAwG;IAChG,IAAI,CAAC,QAAgB,EAAE,IAAoC,EAAE,SAAwC;QACzG,MAAM,WAAW,GAAG,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC;QACvD,MAAM,UAAU,GAAG,IAAA,6BAAc,EAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACzD,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC;QAC9D,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,oBAAoB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC5E,MAAM,IAAI,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC;QACtF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QAC/E,OAAO,CACH,GAAG,IAAI,CAAC,MAAM,6BAA6B,QAAQ,CAAC,MAAM,wBAAwB;YAClF,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;YACpB,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAC,IAAI,CAAC,CAC5G,CAAC;IACN,CAAC;IAED,uGAAuG;IAC/F,SAAS,CAAC,IAAkC;QAChD,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACjC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAC7C,OAAO,CAAC,CAAC,QAAQ,0DAA0D,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC5G,CAAC;IAEO,OAAO;QACX,OAAO,mIAAmI,CAAC;IAC/I,CAAC;CACJ,CAAA;AA9DY,4CAAgB;2BAAhB,gBAAgB;IAD5B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QAChB,mCAAY;QACP,sCAAiB;QACjB,gCAAiB;QACtB,2CAA4B;QACzB,kCAAe;GAP5C,gBAAgB,CA8D5B","sourcesContent":["import {\n    loadAndValidate, reviewJsonPath, writeTemplate, RepoRootFinder,\n    ChecklistDefinition, ChecklistInstructionsService, ReviewJsonService, RequiredChecklist,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { AiBranchName } from '../workflow/git-readAiBranchName';\nimport { ChecklistDetector, TriggeredChecklist } from '../workflow/checklist-detector';\nimport { ChecklistNotice } from '../workflow/checklist-notice';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n/**\n * `wp-checklist` — READ-ONLY. Answers the one question the coding agent has at review time: *which reviewer\n * subagents do I owe on THIS diff, and what exactly do I tell them?*\n *\n * It exists because that answer used to be smeared across `wp-start-upsert-pr`'s output in two partly\n * duplicated blocks, which made the instruction long, drift-prone, and easy to skim past. Now `wp-start`\n * points here, `wp-finish` fails fast against the same computation, and this command is the single place\n * that renders it — via {@link ChecklistInstructionsService}, shared with both.\n *\n * It NEVER mutates the repo beyond refreshing the AI-facing template, and never blocks: a diff owing no\n * review says so and exits 0. Safe to run any number of times.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ChecklistCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly aiBranchName: AiBranchName,\n        private readonly checklistDetector: ChecklistDetector,\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly instructions: ChecklistInstructionsService,\n        private readonly checklistNotice: ChecklistNotice,\n    ) {}\n\n    run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the long-form doc so the block below can cite a file that is present and current.\n        writeTemplate(repoRoot, 'webpieces.review-checklists.md');\n        process.stdout.write('\\n' + SEP + '📋 Review checklists for this diff\\n' + SEP + '\\n');\n        process.stdout.write(this.report(repoRoot));\n        return Promise.resolve();\n    }\n\n    /**\n     * The whole report. Computed in the same order wp-finish-upsert-pr computes it, from the same services,\n     * so \"wp-checklist said I was done\" and \"wp-finish let me through\" can never disagree.\n     */\n    private report(repoRoot: string): string {\n        // loadAndValidate is the ONE gate: it rejects a structurally bad `checklists` (including the removed\n        // { doc } manifest shape) AND checks that every guidance doc + reviewer agent file exists. So reaching\n        // here means the set is valid — there is no \"configured but silently broken\" state left to report.\n        const defs = loadAndValidate(repoRoot).prGate.checklists;\n        const triggered = this.checklistDetector.detectForRepo(repoRoot, defs);\n        if (triggered.length === 0) {\n            // Zero is a SUPPORTED state, never a blocker (see ChecklistNotice).\n            return this.checklistNotice.build(defs.length, 'wp-finish-upsert-pr');\n        }\n        return this.plan(repoRoot, defs, triggered);\n    }\n\n    // The triggered set split into \"already reviewed on this branch\" (reused, not re-run) and \"still owed\".\n    private plan(repoRoot: string, defs: readonly ChecklistDefinition[], triggered: readonly TriggeredChecklist[]): string {\n        const featureName = this.aiBranchName.getFeatureName();\n        const reviewPath = reviewJsonPath(repoRoot, featureName);\n        const required = this.checklistDetector.toRequired(triggered);\n        const results = this.reviewJsonService.loadChecklistResults(reviewPath, required);\n        const pending = this.reviewJsonService.pendingChecklists(required, results);\n        const done = required.filter((r: RequiredChecklist): boolean => !pending.includes(r));\n        const context = this.reviewJsonService.reviewContextFor(repoRoot, featureName);\n        return (\n            `${defs.length} checklist(s) configured, ${required.length} apply to this diff.\\n` +\n            this.doneLines(done) +\n            (pending.length === 0 ? this.allDone() : `\\n${this.instructions.render(pending, reviewPath, context)}\\n`)\n        );\n    }\n\n    // REVIEW ONCE PER BRANCH: verdict files persist in .webpieces, so a second cycle re-instructs nothing.\n    private doneLines(done: readonly RequiredChecklist[]): string {\n        if (done.length === 0) return '';\n        return done.map((r: RequiredChecklist): string =>\n            `  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)\\n`).join('');\n    }\n\n    private allDone(): string {\n        return '\\n✅ Every checklist that applies is already reviewed — nothing to run.\\n   Write review.json and run:  pnpm wp-finish-upsert-pr\\n';\n    }\n}\n"]}
+{"version":3,"file":"checklist-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/checklist-command.ts"],"names":[],"mappings":";;;;AAAA,0DAA0I;AAC1I,yCAA2D;AAC3D,mEAA+D;AAC/D,qEAAsG;AAEtG,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE;;;;;;;;;GASG;AAEI,IAAM,gBAAgB,GAAtB,MAAM,gBAAgB;IAEJ;IACA;IACA;IACA;IAJrB,YACqB,cAA8B,EAC9B,gBAAkC,EAClC,YAA0C,EAC1C,eAAgC;QAHhC,mBAAc,GAAd,cAAc,CAAgB;QAC9B,qBAAgB,GAAhB,gBAAgB,CAAkB;QAClC,iBAAY,GAAZ,YAAY,CAA8B;QAC1C,oBAAe,GAAf,eAAe,CAAiB;IAClD,CAAC;IAEJ,GAAG;QACC,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,4FAA4F;QAC5F,IAAA,4BAAa,EAAC,QAAQ,EAAE,gCAAgC,CAAC,CAAC;QAC1D,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,wCAAwC,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACzF,uGAAuG;QACvG,wFAAwF;QACxF,MAAM,OAAO,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC;QAC5D,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,EAAE,IAAI,wCAAoB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAClH,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC7B,CAAC;IAEO,MAAM,CAAC,IAAmB;QAC9B,IAAI,IAAI,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC/B,oEAAoE;YACpE,OAAO,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC;QAClF,CAAC;QACD,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QACvF,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QAC/F,OAAO,CACH,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC;YACjB,IAAI,CAAC,WAAW,CAAC,IAAI,EAAE,IAAI,CAAC;YAC5B,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAChH,CAAC;IACN,CAAC;IAED,0GAA0G;IAC1G,yFAAyF;IACjF,MAAM,CAAC,IAAmB;QAC9B,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,KAAK,EAAE,CAAC,CAAC,CAAC,wBAAwB,CAAC,CAAC,CAAC,cAAc,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC;QAC3G,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,6BAA6B,IAAI,CAAC,UAAU,CAAC,MAAM,yBAAyB;YACrG,IAAI,IAAI,gDAAgD,CAAC;IACjE,CAAC;IAED,yGAAyG;IACzG,uGAAuG;IAC/F,WAAW,CAAC,IAAmB,EAAE,IAAkC;QACvE,MAAM,KAAK,GAAG,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAC7D,OAAO,CAAC,CAAC,QAAQ,0DAA0D,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC;QAC/F,KAAK,MAAM,CAAC,IAAI,IAAI;YAAE,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,QAAQ,MAAM,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;QACzE,OAAO,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC1B,CAAC;IAED,4GAA4G;IACpG,GAAG,CAAC,GAAsB;QAC9B,IAAI,GAAG,CAAC,eAAe,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,gDAAgD,CAAC;QAC9F,MAAM,KAAK,GAAG,GAAG,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClF,OAAO,GAAG,GAAG,CAAC,YAAY,CAAC,MAAM,oBAAoB,KAAK,EAAE,CAAC;IACjE,CAAC;IAEO,OAAO;QACX,OAAO,0EAA0E;YAC7E,2DAA2D,CAAC;IACpE,CAAC;CACJ,CAAA;AA9DY,4CAAgB;2BAAhB,gBAAgB;IAD5B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QACZ,oCAAgB;QACpB,2CAA4B;QACzB,kCAAe;GAL5C,gBAAgB,CA8D5B","sourcesContent":["import { loadAndValidate, writeTemplate, RepoRootFinder, ChecklistInstructionsService, RequiredChecklist } from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { ChecklistNotice } from '../workflow/checklist-notice';\nimport { ChecklistScan, ChecklistScanOptions, ChecklistScanner } from '../workflow/checklist-scanner';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n/**\n * `wp-checklist` — ALWAYS SUCCEEDS, always just lists. It answers the one question the coding agent has at\n * review time: *which reviewer subagents do I owe on this branch, and what exactly do I tell them?*\n *\n * Safe to run at any time, including mid-work with a dirty tree — uncommitted and untracked files are part\n * of the diff it matches against (see {@link ChecklistScanner}). It exits 0 in every case: zero checklists\n * configured, zero matched, or several still outstanding. Reporting is not gating; `wp-finish-upsert-pr` is\n * the only command that refuses, and it re-uses this exact scan with `filterAlreadyReviewed: true`, so the\n * two can never disagree about what is owed.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ChecklistCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly checklistScanner: ChecklistScanner,\n        private readonly instructions: ChecklistInstructionsService,\n        private readonly checklistNotice: ChecklistNotice,\n    ) {}\n\n    run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the long-form doc so the block below can cite a file that is present and current.\n        writeTemplate(repoRoot, 'webpieces.review-checklists.md');\n        process.stdout.write('\\n' + SEP + '📋 Review checklists for this branch\\n' + SEP + '\\n');\n        // filterAlreadyReviewed:false — LIST everything that applies, marking what is already done. Hiding the\n        // done ones would make a second run look like it found fewer checklists than the first.\n        const defined = loadAndValidate(repoRoot).prGate.checklists;\n        process.stdout.write(this.report(this.checklistScanner.scan(repoRoot, defined, new ChecklistScanOptions(false))));\n        return Promise.resolve();\n    }\n\n    private report(scan: ChecklistScan): string {\n        if (scan.applicable.length === 0) {\n            // Zero is a SUPPORTED state, never a blocker (see ChecklistNotice).\n            return this.checklistNotice.build(scan.defined.length, 'wp-finish-upsert-pr');\n        }\n        const reviewedIds = new Set(scan.reviewed.map((r: RequiredChecklist): string => r.id));\n        const owed = scan.applicable.filter((r: RequiredChecklist): boolean => !reviewedIds.has(r.id));\n        return (\n            this.header(scan) +\n            this.rosterLines(scan, owed) +\n            (owed.length === 0 ? this.allDone() : `\\n${this.instructions.render(owed, scan.reviewPath, scan.context)}\\n`)\n        );\n    }\n\n    // State the base out loud: a reader (and a reviewer) needs to know the diff was taken from the fork point\n    // of main and that uncommitted work counted, because both change which checklists fired.\n    private header(scan: ChecklistScan): string {\n        const base = scan.forkPoint === '' ? 'no fork point resolved' : `fork point ${scan.forkPoint.slice(0, 8)}`;\n        return `${scan.defined.length} checklist(s) configured, ${scan.applicable.length} apply to this branch\\n` +\n            `(${base}, including uncommitted + untracked work).\\n\\n`;\n    }\n\n    // REVIEW ONCE, PER SUBAGENT: a checklist with a passing verdict is reused, not re-run. 2 of 4 done means\n    // the other 2 still need running, so both groups are shown and only the owed ones become instructions.\n    private rosterLines(scan: ChecklistScan, owed: readonly RequiredChecklist[]): string {\n        const lines = scan.reviewed.map((r: RequiredChecklist): string =>\n            `  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)\\n`);\n        for (const r of owed) lines.push(`  ▶ ${r.subagent} — ${this.why(r)}\\n`);\n        return lines.join('');\n    }\n\n    // Why this one is in scope. A patternless checklist is NOT \"matched\" — it always runs, over the whole diff.\n    private why(req: RequiredChecklist): string {\n        if (req.matchedPatterns.length === 0) return 'ALWAYS RUNS (no patterns), whole diff in scope';\n        const globs = req.matchedPatterns.map((p: string): string => `\"${p}\"`).join(', ');\n        return `${req.matchedFiles.length} file(s) matched ${globs}`;\n    }\n\n    private allDone(): string {\n        return '\\n✅ Every checklist that applies is already reviewed — nothing to run.\\n' +\n            '   Write review.json and run:  pnpm wp-finish-upsert-pr\\n';\n    }\n}\n"]}

package/src/scripts/commands/finish-upsert-pr-command.d.ts

@@ -1,7 +1,7 @@
 import { RepoRootFinder, ReviewJsonService, GateTokenService, SubagentProvenanceService, ChecklistInstructionsService } from '@webpieces/rules-config';
 import { AiBranchName } from '../workflow/git-readAiBranchName';
 import { BranchNaming } from '../workflow/branch-naming';
-import { ChecklistDetector } from '../workflow/checklist-detector';
+import { ChecklistScanner } from '../workflow/checklist-scanner';
 import { GitExec } from '../workflow/git-exec';
 import { BuildAffected } from '../workflow/build-affected';
 import { MergeState } from '../workflow/merge-state';
@@ -20,18 +20,21 @@ export declare class FinishUpsertPrCommand {
     private readonly prMerger;
     private readonly publisher;
     private readonly dashboard;
-    private readonly checklistDetector;
+    private readonly checklistScanner;
     private readonly reviewJsonService;
     private readonly gateTokenService;
     private readonly provenance;
     private readonly instructions;
-    constructor(repoRootFinder: RepoRootFinder, aiBranchName: AiBranchName, branchNaming: BranchNaming, gitExec: GitExec, buildAffected: BuildAffected, mergeState: MergeState, mergeEnd: MergeEnd, prMerger: PrMerger, publisher: GatedPrPublisher, dashboard: Dashboard, checklistDetector: ChecklistDetector, reviewJsonService: ReviewJsonService, gateTokenService: GateTokenService, provenance: SubagentProvenanceService, instructions: ChecklistInstructionsService);
+    constructor(repoRootFinder: RepoRootFinder, aiBranchName: AiBranchName, branchNaming: BranchNaming, gitExec: GitExec, buildAffected: BuildAffected, mergeState: MergeState, mergeEnd: MergeEnd, prMerger: PrMerger, publisher: GatedPrPublisher, dashboard: Dashboard, checklistScanner: ChecklistScanner, reviewJsonService: ReviewJsonService, gateTokenService: GateTokenService, provenance: SubagentProvenanceService, instructions: ChecklistInstructionsService);
     run(): Promise<void>;
+    private emitClickableLinkDirective;
     private finalizeAnyInProgressMerge;
     /**
      * Refuse the PR while ANY applicable checklist still owes a verdict, naming exactly those reviewers and
-     * exactly what to tell them. Throws InformAiError so the AI gets one actionable message; passes silently
-     * when nothing is pending, and is a no-op for a repo with no checklists.
+     * exactly what to tell them — via the same renderer `wp-checklist` uses, so the AI sees the identical
+     * block it would have seen there. Lists ONLY the outstanding ones: re-instructing an already-reviewed
+     * checklist invites a redundant second run and reads as though the earlier verdict did not count.
+     * No-op for a repo with no applicable checklists.
      */
     private assertEveryReviewerRan;
     private gitOut;

package/src/scripts/commands/finish-upsert-pr-command.js

@@ -9,7 +9,7 @@ const rules_config_1 = require("@webpieces/rules-config");
 const inversify_1 = require("inversify");
 const git_readAiBranchName_1 = require("../workflow/git-readAiBranchName");
 const branch_naming_1 = require("../workflow/branch-naming");
-const checklist_detector_1 = require("../workflow/checklist-detector");
+const checklist_scanner_1 = require("../workflow/checklist-scanner");
 const git_exec_1 = require("../workflow/git-exec");
 const build_affected_1 = require("../workflow/build-affected");
 const merge_state_1 = require("../workflow/merge-state");
@@ -28,13 +28,16 @@ class PrRef {
         this.url = url;
     }
 }
-// The outcome of the whole upsert: the PR number ('' when it could not be resolved) plus what actually
-// happened to the merge, so the final summary reports the REAL result rather than assuming success.
+// The outcome of the whole upsert: the PR number + web URL ('' each when unresolved) plus what actually
+// happened to the merge, so the final summary reports the REAL result rather than assuming success. The
+// URL is carried so the closing block can hand the AI a clickable link to relay to the user verbatim.
 class UpsertResult {
     prNumber;
+    prUrl;
     merge;
-    constructor(prNumber, merge) {
+    constructor(prNumber, prUrl, merge) {
         this.prNumber = prNumber;
+        this.prUrl = prUrl;
         this.merge = merge;
     }
 }
@@ -53,12 +56,12 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
     prMerger;
     publisher;
     dashboard;
-    checklistDetector;
+    checklistScanner;
     reviewJsonService;
     gateTokenService;
     provenance;
     instructions;
-    constructor(repoRootFinder, aiBranchName, branchNaming, gitExec, buildAffected, mergeState, mergeEnd, prMerger, publisher, dashboard, checklistDetector, reviewJsonService, gateTokenService, provenance, instructions) {
+    constructor(repoRootFinder, aiBranchName, branchNaming, gitExec, buildAffected, mergeState, mergeEnd, prMerger, publisher, dashboard, checklistScanner, reviewJsonService, gateTokenService, provenance, instructions) {
         this.repoRootFinder = repoRootFinder;
         this.aiBranchName = aiBranchName;
         this.branchNaming = branchNaming;
@@ -69,7 +72,7 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
         this.prMerger = prMerger;
         this.publisher = publisher;
         this.dashboard = dashboard;
-        this.checklistDetector = checklistDetector;
+        this.checklistScanner = checklistScanner;
         this.reviewJsonService = reviewJsonService;
         this.gateTokenService = gateTokenService;
         this.provenance = provenance;
@@ -84,18 +87,19 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
         // 2. REQUIRE the AI-authored review.json (throws InformAiError with the schema if missing/invalid).
         //    Compute the consumer checklists this diff triggered FIRST so an unacknowledged BLOCK throws
         //    here — BEFORE any `gh pr create` — matching the guarantee buildCommand already provides.
-        const defs = (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists;
-        const required = this.checklistDetector.toRequired(this.checklistDetector.detectForRepo(repoRoot, defs));
-        // review-<id>.json files persist locally between runs, so a re-run after a push re-validates the
-        // EXISTING verdicts against the (possibly changed) triggered set for free: an unchanged checklist
-        // needs no re-review, a newly-triggered one refuses until its file is written. That is the
-        // "full review only when the checklist surface changes" behavior — no special-casing here.
-        // FAIL FAST on missing reviewers, BEFORE review.json is even parsed. A missing reviewer is not a
-        // review.json defect and folding it into that error made the AI fix the wrong thing; and the message
-        // lists ONLY the subagents that still owe a verdict, so an already-reviewed checklist is never
-        // re-instructed. Same computation + same renderer as `wp-checklist`, so the two cannot disagree.
+        // The SAME scan wp-checklist runs, with filterAlreadyReviewed:true so `outstanding` is exactly what
+        // still owes a verdict (Z of N of X). Sharing the computation is the point: the command that REPORTS
+        // and the command that GATES must not be able to disagree about what is owed. review-<id>.json files
+        // persist locally, so a re-run re-validates the EXISTING verdicts against the (possibly changed)
+        // applicable set for free — an unchanged checklist needs no re-review, a newly-applicable one refuses
+        // until its file is written.
         const featureName = this.aiBranchName.getFeatureName();
-        this.assertEveryReviewerRan(repoRoot, featureName, required);
+        const scan = this.checklistScanner.scan(repoRoot, (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists, new checklist_scanner_1.ChecklistScanOptions(true));
+        const required = scan.applicable;
+        // FAIL FAST on missing reviewers, BEFORE review.json is parsed and before the build gate runs. A
+        // missing reviewer is not a review.json defect (folding it in made the AI fix the wrong thing), and
+        // nobody should wait on a build to be told a reviewer never ran.
+        this.assertEveryReviewerRan(scan);
         const review = this.reviewJsonService.loadReviewJson((0, rules_config_1.reviewJsonPath)(repoRoot, featureName), required);
         // 2c. For any BLOCK checklist that names a reviewer `subagent`, VERIFY (from the harness's own
         //     artifacts) that such a subagent actually ran on this branch — the coding agent may not
@@ -129,6 +133,19 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
             `   3. force-pushed your work to origin/${base} (after the body, so CI reads the right token)\n` +
             `   4. ${result.merge.message}\n` +
             `   You are on  ${base}  — same name as the remote branch and the PR head.\n\n`);
+        // Close by handing the AI a clickable link + directive to end its summary with it (see helper).
+        this.emitClickableLinkDirective(prNum, result.prUrl, title);
+    }
+    // Print the closing AI directive: the resolved PR's number/title/URL and an instruction to end the
+    // user-facing summary with EXACTLY `[#N title](url)` as the final line, nothing after it. No-op when
+    // the PR could not be resolved — better to say nothing than to point the user at a link that isn't real.
+    emitClickableLinkDirective(prNum, prUrl, title) {
+        if (prNum === '' || prUrl === '')
+            return;
+        process.stdout.write(SEP + `🔗 PR #${prNum}: ${title}\n   ${prUrl}\n\n` + SEP +
+            `AI — the LAST line of your summary to the user MUST be EXACTLY this clickable link, with\n` +
+            `NOTHING printed after it (no sign-off, no next steps, no blank commentary):\n\n` +
+            `   [#${prNum} ${title}](${prUrl})\n\n`);
     }
     // Validate + commit + finalize a 3-point merge the AI resolved, if one is in progress. Finalizing here
     // does NOT push (pushRemote=false): this command pushes exactly ONCE, from GatedPrPublisher, and only
@@ -143,21 +160,17 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
     }
     /**
      * Refuse the PR while ANY applicable checklist still owes a verdict, naming exactly those reviewers and
-     * exactly what to tell them. Throws InformAiError so the AI gets one actionable message; passes silently
-     * when nothing is pending, and is a no-op for a repo with no checklists.
+     * exactly what to tell them — via the same renderer `wp-checklist` uses, so the AI sees the identical
+     * block it would have seen there. Lists ONLY the outstanding ones: re-instructing an already-reviewed
+     * checklist invites a redundant second run and reads as though the earlier verdict did not count.
+     * No-op for a repo with no applicable checklists.
      */
-    assertEveryReviewerRan(repoRoot, featureName, required) {
-        if (required.length === 0)
-            return;
-        const reviewPath = (0, rules_config_1.reviewJsonPath)(repoRoot, featureName);
-        const results = this.reviewJsonService.loadChecklistResults(reviewPath, required);
-        const pending = this.reviewJsonService.pendingChecklists(required, results);
-        if (pending.length === 0)
+    assertEveryReviewerRan(scan) {
+        if (scan.outstanding.length === 0)
             return;
-        const context = this.reviewJsonService.reviewContextFor(repoRoot, featureName);
-        throw new rules_config_1.InformAiError(`⛔ NO PR — ${pending.length} of ${required.length} review checklist(s) that apply to this diff have ` +
-            `no passing verdict yet: ${this.instructions.names(pending)}\n\n` +
-            `${this.instructions.render(pending, reviewPath, context)}\n\n` +
+        throw new rules_config_1.InformAiError(`⛔ NO PR — ${scan.outstanding.length} of ${scan.applicable.length} review checklist(s) that apply to this ` +
+            `branch have no passing verdict yet: ${this.instructions.names(scan.outstanding)}\n\n` +
+            `${this.instructions.render(scan.outstanding, scan.reviewPath, scan.context)}\n\n` +
             `Then re-run: pnpm wp-finish-upsert-pr   (or check anytime with: pnpm wp-checklist)`);
     }
     gitOut(args) {
@@ -270,7 +283,7 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
         const published = this.publisher.publish(baseBranch, title, bodyFile);
         if (published.createFailed) {
             process.stderr.write('⚠️  gh pr create failed — create the PR manually with the body in:\n  ' + bodyFile + '\n');
-            return new UpsertResult('', new pr_merger_1.MergeOutcome(false, false, '⚠️  did NOT merge — there is no PR to merge (gh pr create failed above)'));
+            return new UpsertResult('', '', new pr_merger_1.MergeOutcome(false, false, '⚠️  did NOT merge — there is no PR to merge (gh pr create failed above)'));
         }
         const num = published.number;
         // Set the squash-merge SUBJECT to the PR title (+ the `(#N)` GitHub normally appends, which an
@@ -287,7 +300,7 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
         // rules-config that has no such field) reaches PrMerger as '' and is treated as "do not merge".
         const mergeMode = (0, rules_config_1.loadAndValidate)(repoRoot).prGate.mergeMode ?? '';
         const outcome = this.prMerger.merge(baseBranch, subject, mergeBodyFile, mergeMode);
-        return new UpsertResult(ref.number !== '' ? ref.number : num, outcome);
+        return new UpsertResult(ref.number !== '' ? ref.number : num, ref.url, outcome);
     }
     // The PR's number + web URL (for the merge subject `(#N)` and the commit-body back-link). Both ''
     // if it can't be resolved. Rendered via jq into one tab-separated line so no JSON parsing is needed.
@@ -313,7 +326,7 @@ exports.FinishUpsertPrCommand = FinishUpsertPrCommand = tslib_1.__decorate([
         pr_merger_1.PrMerger,
         gated_pr_publisher_1.GatedPrPublisher,
         dashboard_1.Dashboard,
-        checklist_detector_1.ChecklistDetector,
+        checklist_scanner_1.ChecklistScanner,
         rules_config_1.ReviewJsonService,
         rules_config_1.GateTokenService,
         rules_config_1.SubagentProvenanceService,