@webpieces/pr-gate 0.4.483 → 0.4.484

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webpieces/pr-gate",
-  "version": "0.4.483",
+  "version": "0.4.484",
   "description": "Gated PR system: 3-point squash-merge, merge validation gate, and red/yellow/green PR dashboard. Standalone scripts, no Nx dependency required.",
   "type": "commonjs",
   "main": "./src/index.js",
@@ -25,7 +25,7 @@
     "directory": "packages/tooling/pr-gate"
   },
   "dependencies": {
-    "@webpieces/rules-config": "0.4.483",
+    "@webpieces/rules-config": "0.4.484",
     "@inversifyjs/binding-decorators": "1.1.5",
     "inversify": "7.10.4",
     "reflect-metadata": "0.2.2"

package/src/scripts/commands/checklist-command.d.ts

@@ -1,4 +1,4 @@
-import { RepoRootFinder, ChecklistManifestService, ChecklistInstructionsService, ReviewJsonService } from '@webpieces/rules-config';
+import { RepoRootFinder, ChecklistInstructionsService, ReviewJsonService } from '@webpieces/rules-config';
 import { AiBranchName } from '../workflow/git-readAiBranchName';
 import { ChecklistDetector } from '../workflow/checklist-detector';
 import { ChecklistNotice } from '../workflow/checklist-notice';
@@ -17,12 +17,11 @@ import { ChecklistNotice } from '../workflow/checklist-notice';
 export declare class ChecklistCommand {
     private readonly repoRootFinder;
     private readonly aiBranchName;
-    private readonly manifestService;
     private readonly checklistDetector;
     private readonly reviewJsonService;
     private readonly instructions;
     private readonly checklistNotice;
-    constructor(repoRootFinder: RepoRootFinder, aiBranchName: AiBranchName, manifestService: ChecklistManifestService, checklistDetector: ChecklistDetector, reviewJsonService: ReviewJsonService, instructions: ChecklistInstructionsService, checklistNotice: ChecklistNotice);
+    constructor(repoRootFinder: RepoRootFinder, aiBranchName: AiBranchName, checklistDetector: ChecklistDetector, reviewJsonService: ReviewJsonService, instructions: ChecklistInstructionsService, checklistNotice: ChecklistNotice);
     run(): Promise<void>;
     /**
      * The whole report. Computed in the same order wp-finish-upsert-pr computes it, from the same services,

package/src/scripts/commands/checklist-command.js

@@ -23,15 +23,13 @@ const SEP = '━━━━━━━━━━━━━━━━━━━━━━
 let ChecklistCommand = class ChecklistCommand {
     repoRootFinder;
     aiBranchName;
-    manifestService;
     checklistDetector;
     reviewJsonService;
     instructions;
     checklistNotice;
-    constructor(repoRootFinder, aiBranchName, manifestService, checklistDetector, reviewJsonService, instructions, checklistNotice) {
+    constructor(repoRootFinder, aiBranchName, checklistDetector, reviewJsonService, instructions, checklistNotice) {
         this.repoRootFinder = repoRootFinder;
         this.aiBranchName = aiBranchName;
-        this.manifestService = manifestService;
         this.checklistDetector = checklistDetector;
         this.reviewJsonService = reviewJsonService;
         this.instructions = instructions;
@@ -50,13 +48,14 @@ let ChecklistCommand = class ChecklistCommand {
      * so "wp-checklist said I was done" and "wp-finish let me through" can never disagree.
      */
     report(repoRoot) {
-        const source = (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists;
-        const defs = this.manifestService.load(repoRoot, source);
+        // loadAndValidate is the ONE gate: it rejects a structurally bad `checklists` (including the removed
+        // { doc } manifest shape) AND checks that every guidance doc + reviewer agent file exists. So reaching
+        // here means the set is valid — there is no "configured but silently broken" state left to report.
+        const defs = (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists;
         const triggered = this.checklistDetector.detectForRepo(repoRoot, defs);
         if (triggered.length === 0) {
-            // Zero is a SUPPORTED state, never a blocker — and a configured-but-broken source is reported
-            // loudly here rather than silently enforcing nothing (see ChecklistNotice).
-            return this.checklistNotice.build(source, this.manifestService.validate(repoRoot, source), defs.length, 'wp-finish-upsert-pr');
+            // Zero is a SUPPORTED state, never a blocker (see ChecklistNotice).
+            return this.checklistNotice.build(defs.length, 'wp-finish-upsert-pr');
         }
         return this.plan(repoRoot, defs, triggered);
     }
@@ -88,7 +87,6 @@ exports.ChecklistCommand = ChecklistCommand = tslib_1.__decorate([
     (0, inversify_1.injectable)(inversify_1.bindingScopeValues.Singleton),
     tslib_1.__metadata("design:paramtypes", [rules_config_1.RepoRootFinder,
         git_readAiBranchName_1.AiBranchName,
-        rules_config_1.ChecklistManifestService,
         checklist_detector_1.ChecklistDetector,
         rules_config_1.ReviewJsonService,
         rules_config_1.ChecklistInstructionsService,

package/src/scripts/commands/checklist-command.js.map

@@ -1 +1 @@
-{"version":3,"file":"checklist-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/checklist-command.ts"],"names":[],"mappings":";;;;AAAA,0DAGiC;AACjC,yCAA2D;AAC3D,2EAAgE;AAChE,uEAAuF;AACvF,mEAA+D;AAE/D,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE;;;;;;;;;;;GAWG;AAEI,IAAM,gBAAgB,GAAtB,MAAM,gBAAgB;IAEJ;IACA;IACA;IACA;IACA;IACA;IACA;IAPrB,YACqB,cAA8B,EAC9B,YAA0B,EAC1B,eAAyC,EACzC,iBAAoC,EACpC,iBAAoC,EACpC,YAA0C,EAC1C,eAAgC;QANhC,mBAAc,GAAd,cAAc,CAAgB;QAC9B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,oBAAe,GAAf,eAAe,CAA0B;QACzC,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,iBAAY,GAAZ,YAAY,CAA8B;QAC1C,oBAAe,GAAf,eAAe,CAAiB;IAClD,CAAC;IAEJ,GAAG;QACC,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,4FAA4F;QAC5F,IAAA,4BAAa,EAAC,QAAQ,EAAE,gCAAgC,CAAC,CAAC;QAC1D,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,sCAAsC,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACvF,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC;QAC5C,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC7B,CAAC;IAED;;;OAGG;IACK,MAAM,CAAC,QAAgB;QAC3B,MAAM,MAAM,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC;QAC3D,MAAM,IAAI,GAAG,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QACzD,MAAM,SAAS,GAAG,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QACvE,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzB,8FAA8F;YAC9F,4EAA4E;YAC5E,OAAO,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,MAAM,EAAE,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC,QAAQ,EAAE,MAAM,CAAC,EAAE,IAAI,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC;QACnI,CAAC;QACD,OAAO,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,EAAE,SAAS,CAAC,CAAC;IAChD,CAAC;IAED,wGAAwG;IAChG,IAAI,CAAC,QAAgB,EAAE,IAAoC,EAAE,SAAwC;QACzG,MAAM,WAAW,GAAG,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC;QACvD,MAAM,UAAU,GAAG,IAAA,6BAAc,EAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACzD,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC;QAC9D,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,oBAAoB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC5E,MAAM,IAAI,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC;QACtF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QAC/E,OAAO,CACH,GAAG,IAAI,CAAC,MAAM,6BAA6B,QAAQ,CAAC,MAAM,wBAAwB;YAClF,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;YACpB,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAC,IAAI,CAAC,CAC5G,CAAC;IACN,CAAC;IAED,uGAAuG;IAC/F,SAAS,CAAC,IAAkC;QAChD,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACjC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAC7C,OAAO,CAAC,CAAC,QAAQ,0DAA0D,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC5G,CAAC;IAEO,OAAO;QACX,OAAO,mIAAmI,CAAC;IAC/I,CAAC;CACJ,CAAA;AA9DY,4CAAgB;2BAAhB,gBAAgB;IAD5B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QAChB,mCAAY;QACT,uCAAwB;QACtB,sCAAiB;QACjB,gCAAiB;QACtB,2CAA4B;QACzB,kCAAe;GAR5C,gBAAgB,CA8D5B","sourcesContent":["import {\n    loadAndValidate, reviewJsonPath, writeTemplate, RepoRootFinder, ChecklistManifestService,\n    ChecklistDefinition, ChecklistInstructionsService, ReviewJsonService, RequiredChecklist,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { AiBranchName } from '../workflow/git-readAiBranchName';\nimport { ChecklistDetector, TriggeredChecklist } from '../workflow/checklist-detector';\nimport { ChecklistNotice } from '../workflow/checklist-notice';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n/**\n * `wp-checklist` — READ-ONLY. Answers the one question the coding agent has at review time: *which reviewer\n * subagents do I owe on THIS diff, and what exactly do I tell them?*\n *\n * It exists because that answer used to be smeared across `wp-start-upsert-pr`'s output in two partly\n * duplicated blocks, which made the instruction long, drift-prone, and easy to skim past. Now `wp-start`\n * points here, `wp-finish` fails fast against the same computation, and this command is the single place\n * that renders it — via {@link ChecklistInstructionsService}, shared with both.\n *\n * It NEVER mutates the repo beyond refreshing the AI-facing template, and never blocks: a diff owing no\n * review says so and exits 0. Safe to run any number of times.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ChecklistCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly aiBranchName: AiBranchName,\n        private readonly manifestService: ChecklistManifestService,\n        private readonly checklistDetector: ChecklistDetector,\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly instructions: ChecklistInstructionsService,\n        private readonly checklistNotice: ChecklistNotice,\n    ) {}\n\n    run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the long-form doc so the block below can cite a file that is present and current.\n        writeTemplate(repoRoot, 'webpieces.review-checklists.md');\n        process.stdout.write('\\n' + SEP + '📋 Review checklists for this diff\\n' + SEP + '\\n');\n        process.stdout.write(this.report(repoRoot));\n        return Promise.resolve();\n    }\n\n    /**\n     * The whole report. Computed in the same order wp-finish-upsert-pr computes it, from the same services,\n     * so \"wp-checklist said I was done\" and \"wp-finish let me through\" can never disagree.\n     */\n    private report(repoRoot: string): string {\n        const source = loadAndValidate(repoRoot).prGate.checklists;\n        const defs = this.manifestService.load(repoRoot, source);\n        const triggered = this.checklistDetector.detectForRepo(repoRoot, defs);\n        if (triggered.length === 0) {\n            // Zero is a SUPPORTED state, never a blocker — and a configured-but-broken source is reported\n            // loudly here rather than silently enforcing nothing (see ChecklistNotice).\n            return this.checklistNotice.build(source, this.manifestService.validate(repoRoot, source), defs.length, 'wp-finish-upsert-pr');\n        }\n        return this.plan(repoRoot, defs, triggered);\n    }\n\n    // The triggered set split into \"already reviewed on this branch\" (reused, not re-run) and \"still owed\".\n    private plan(repoRoot: string, defs: readonly ChecklistDefinition[], triggered: readonly TriggeredChecklist[]): string {\n        const featureName = this.aiBranchName.getFeatureName();\n        const reviewPath = reviewJsonPath(repoRoot, featureName);\n        const required = this.checklistDetector.toRequired(triggered);\n        const results = this.reviewJsonService.loadChecklistResults(reviewPath, required);\n        const pending = this.reviewJsonService.pendingChecklists(required, results);\n        const done = required.filter((r: RequiredChecklist): boolean => !pending.includes(r));\n        const context = this.reviewJsonService.reviewContextFor(repoRoot, featureName);\n        return (\n            `${defs.length} checklist(s) configured, ${required.length} apply to this diff.\\n` +\n            this.doneLines(done) +\n            (pending.length === 0 ? this.allDone() : `\\n${this.instructions.render(pending, reviewPath, context)}\\n`)\n        );\n    }\n\n    // REVIEW ONCE PER BRANCH: verdict files persist in .webpieces, so a second cycle re-instructs nothing.\n    private doneLines(done: readonly RequiredChecklist[]): string {\n        if (done.length === 0) return '';\n        return done.map((r: RequiredChecklist): string =>\n            `  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)\\n`).join('');\n    }\n\n    private allDone(): string {\n        return '\\n✅ Every checklist that applies is already reviewed — nothing to run.\\n   Write review.json and run:  pnpm wp-finish-upsert-pr\\n';\n    }\n}\n"]}
+{"version":3,"file":"checklist-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/checklist-command.ts"],"names":[],"mappings":";;;;AAAA,0DAGiC;AACjC,yCAA2D;AAC3D,2EAAgE;AAChE,uEAAuF;AACvF,mEAA+D;AAE/D,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE;;;;;;;;;;;GAWG;AAEI,IAAM,gBAAgB,GAAtB,MAAM,gBAAgB;IAEJ;IACA;IACA;IACA;IACA;IACA;IANrB,YACqB,cAA8B,EAC9B,YAA0B,EAC1B,iBAAoC,EACpC,iBAAoC,EACpC,YAA0C,EAC1C,eAAgC;QALhC,mBAAc,GAAd,cAAc,CAAgB;QAC9B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,iBAAY,GAAZ,YAAY,CAA8B;QAC1C,oBAAe,GAAf,eAAe,CAAiB;IAClD,CAAC;IAEJ,GAAG;QACC,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,4FAA4F;QAC5F,IAAA,4BAAa,EAAC,QAAQ,EAAE,gCAAgC,CAAC,CAAC;QAC1D,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,sCAAsC,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACvF,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC;QAC5C,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC7B,CAAC;IAED;;;OAGG;IACK,MAAM,CAAC,QAAgB;QAC3B,qGAAqG;QACrG,uGAAuG;QACvG,mGAAmG;QACnG,MAAM,IAAI,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC;QACzD,MAAM,SAAS,GAAG,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QACvE,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzB,oEAAoE;YACpE,OAAO,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC;QAC1E,CAAC;QACD,OAAO,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,EAAE,SAAS,CAAC,CAAC;IAChD,CAAC;IAED,wGAAwG;IAChG,IAAI,CAAC,QAAgB,EAAE,IAAoC,EAAE,SAAwC;QACzG,MAAM,WAAW,GAAG,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC;QACvD,MAAM,UAAU,GAAG,IAAA,6BAAc,EAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACzD,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC;QAC9D,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,oBAAoB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC5E,MAAM,IAAI,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAoB,EAAW,EAAE,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC;QACtF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QAC/E,OAAO,CACH,GAAG,IAAI,CAAC,MAAM,6BAA6B,QAAQ,CAAC,MAAM,wBAAwB;YAClF,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;YACpB,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAC,IAAI,CAAC,CAC5G,CAAC;IACN,CAAC;IAED,uGAAuG;IAC/F,SAAS,CAAC,IAAkC;QAChD,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QACjC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAC7C,OAAO,CAAC,CAAC,QAAQ,0DAA0D,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC5G,CAAC;IAEO,OAAO;QACX,OAAO,mIAAmI,CAAC;IAC/I,CAAC;CACJ,CAAA;AA9DY,4CAAgB;2BAAhB,gBAAgB;IAD5B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QAChB,mCAAY;QACP,sCAAiB;QACjB,gCAAiB;QACtB,2CAA4B;QACzB,kCAAe;GAP5C,gBAAgB,CA8D5B","sourcesContent":["import {\n    loadAndValidate, reviewJsonPath, writeTemplate, RepoRootFinder,\n    ChecklistDefinition, ChecklistInstructionsService, ReviewJsonService, RequiredChecklist,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { AiBranchName } from '../workflow/git-readAiBranchName';\nimport { ChecklistDetector, TriggeredChecklist } from '../workflow/checklist-detector';\nimport { ChecklistNotice } from '../workflow/checklist-notice';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n/**\n * `wp-checklist` — READ-ONLY. Answers the one question the coding agent has at review time: *which reviewer\n * subagents do I owe on THIS diff, and what exactly do I tell them?*\n *\n * It exists because that answer used to be smeared across `wp-start-upsert-pr`'s output in two partly\n * duplicated blocks, which made the instruction long, drift-prone, and easy to skim past. Now `wp-start`\n * points here, `wp-finish` fails fast against the same computation, and this command is the single place\n * that renders it — via {@link ChecklistInstructionsService}, shared with both.\n *\n * It NEVER mutates the repo beyond refreshing the AI-facing template, and never blocks: a diff owing no\n * review says so and exits 0. Safe to run any number of times.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ChecklistCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly aiBranchName: AiBranchName,\n        private readonly checklistDetector: ChecklistDetector,\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly instructions: ChecklistInstructionsService,\n        private readonly checklistNotice: ChecklistNotice,\n    ) {}\n\n    run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the long-form doc so the block below can cite a file that is present and current.\n        writeTemplate(repoRoot, 'webpieces.review-checklists.md');\n        process.stdout.write('\\n' + SEP + '📋 Review checklists for this diff\\n' + SEP + '\\n');\n        process.stdout.write(this.report(repoRoot));\n        return Promise.resolve();\n    }\n\n    /**\n     * The whole report. Computed in the same order wp-finish-upsert-pr computes it, from the same services,\n     * so \"wp-checklist said I was done\" and \"wp-finish let me through\" can never disagree.\n     */\n    private report(repoRoot: string): string {\n        // loadAndValidate is the ONE gate: it rejects a structurally bad `checklists` (including the removed\n        // { doc } manifest shape) AND checks that every guidance doc + reviewer agent file exists. So reaching\n        // here means the set is valid — there is no \"configured but silently broken\" state left to report.\n        const defs = loadAndValidate(repoRoot).prGate.checklists;\n        const triggered = this.checklistDetector.detectForRepo(repoRoot, defs);\n        if (triggered.length === 0) {\n            // Zero is a SUPPORTED state, never a blocker (see ChecklistNotice).\n            return this.checklistNotice.build(defs.length, 'wp-finish-upsert-pr');\n        }\n        return this.plan(repoRoot, defs, triggered);\n    }\n\n    // The triggered set split into \"already reviewed on this branch\" (reused, not re-run) and \"still owed\".\n    private plan(repoRoot: string, defs: readonly ChecklistDefinition[], triggered: readonly TriggeredChecklist[]): string {\n        const featureName = this.aiBranchName.getFeatureName();\n        const reviewPath = reviewJsonPath(repoRoot, featureName);\n        const required = this.checklistDetector.toRequired(triggered);\n        const results = this.reviewJsonService.loadChecklistResults(reviewPath, required);\n        const pending = this.reviewJsonService.pendingChecklists(required, results);\n        const done = required.filter((r: RequiredChecklist): boolean => !pending.includes(r));\n        const context = this.reviewJsonService.reviewContextFor(repoRoot, featureName);\n        return (\n            `${defs.length} checklist(s) configured, ${required.length} apply to this diff.\\n` +\n            this.doneLines(done) +\n            (pending.length === 0 ? this.allDone() : `\\n${this.instructions.render(pending, reviewPath, context)}\\n`)\n        );\n    }\n\n    // REVIEW ONCE PER BRANCH: verdict files persist in .webpieces, so a second cycle re-instructs nothing.\n    private doneLines(done: readonly RequiredChecklist[]): string {\n        if (done.length === 0) return '';\n        return done.map((r: RequiredChecklist): string =>\n            `  ✓ ${r.subagent} — already reviewed on this branch (reusing its review-${r.id}.json)\\n`).join('');\n    }\n\n    private allDone(): string {\n        return '\\n✅ Every checklist that applies is already reviewed — nothing to run.\\n   Write review.json and run:  pnpm wp-finish-upsert-pr\\n';\n    }\n}\n"]}

package/src/scripts/commands/finish-upsert-pr-command.d.ts

@@ -1,4 +1,4 @@
-import { RepoRootFinder, ReviewJsonService, ChecklistManifestService, GateTokenService, SubagentProvenanceService, ChecklistInstructionsService } from '@webpieces/rules-config';
+import { RepoRootFinder, ReviewJsonService, GateTokenService, SubagentProvenanceService, ChecklistInstructionsService } from '@webpieces/rules-config';
 import { AiBranchName } from '../workflow/git-readAiBranchName';
 import { BranchNaming } from '../workflow/branch-naming';
 import { ChecklistDetector } from '../workflow/checklist-detector';
@@ -21,12 +21,11 @@ export declare class FinishUpsertPrCommand {
     private readonly publisher;
     private readonly dashboard;
     private readonly checklistDetector;
-    private readonly manifestService;
     private readonly reviewJsonService;
     private readonly gateTokenService;
     private readonly provenance;
     private readonly instructions;
-    constructor(repoRootFinder: RepoRootFinder, aiBranchName: AiBranchName, branchNaming: BranchNaming, gitExec: GitExec, buildAffected: BuildAffected, mergeState: MergeState, mergeEnd: MergeEnd, prMerger: PrMerger, publisher: GatedPrPublisher, dashboard: Dashboard, checklistDetector: ChecklistDetector, manifestService: ChecklistManifestService, reviewJsonService: ReviewJsonService, gateTokenService: GateTokenService, provenance: SubagentProvenanceService, instructions: ChecklistInstructionsService);
+    constructor(repoRootFinder: RepoRootFinder, aiBranchName: AiBranchName, branchNaming: BranchNaming, gitExec: GitExec, buildAffected: BuildAffected, mergeState: MergeState, mergeEnd: MergeEnd, prMerger: PrMerger, publisher: GatedPrPublisher, dashboard: Dashboard, checklistDetector: ChecklistDetector, reviewJsonService: ReviewJsonService, gateTokenService: GateTokenService, provenance: SubagentProvenanceService, instructions: ChecklistInstructionsService);
     run(): Promise<void>;
     private finalizeAnyInProgressMerge;
     /**

package/src/scripts/commands/finish-upsert-pr-command.js

@@ -54,12 +54,11 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
     publisher;
     dashboard;
     checklistDetector;
-    manifestService;
     reviewJsonService;
     gateTokenService;
     provenance;
     instructions;
-    constructor(repoRootFinder, aiBranchName, branchNaming, gitExec, buildAffected, mergeState, mergeEnd, prMerger, publisher, dashboard, checklistDetector, manifestService, reviewJsonService, gateTokenService, provenance, instructions) {
+    constructor(repoRootFinder, aiBranchName, branchNaming, gitExec, buildAffected, mergeState, mergeEnd, prMerger, publisher, dashboard, checklistDetector, reviewJsonService, gateTokenService, provenance, instructions) {
         this.repoRootFinder = repoRootFinder;
         this.aiBranchName = aiBranchName;
         this.branchNaming = branchNaming;
@@ -71,7 +70,6 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
         this.publisher = publisher;
         this.dashboard = dashboard;
         this.checklistDetector = checklistDetector;
-        this.manifestService = manifestService;
         this.reviewJsonService = reviewJsonService;
         this.gateTokenService = gateTokenService;
         this.provenance = provenance;
@@ -86,7 +84,7 @@ let FinishUpsertPrCommand = class FinishUpsertPrCommand {
         // 2. REQUIRE the AI-authored review.json (throws InformAiError with the schema if missing/invalid).
         //    Compute the consumer checklists this diff triggered FIRST so an unacknowledged BLOCK throws
         //    here — BEFORE any `gh pr create` — matching the guarantee buildCommand already provides.
-        const defs = this.manifestService.load(repoRoot, (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists);
+        const defs = (0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists;
         const required = this.checklistDetector.toRequired(this.checklistDetector.detectForRepo(repoRoot, defs));
         // review-<id>.json files persist locally between runs, so a re-run after a push re-validates the
         // EXISTING verdicts against the (possibly changed) triggered set for free: an unchanged checklist
@@ -316,7 +314,6 @@ exports.FinishUpsertPrCommand = FinishUpsertPrCommand = tslib_1.__decorate([
         gated_pr_publisher_1.GatedPrPublisher,
         dashboard_1.Dashboard,
         checklist_detector_1.ChecklistDetector,
-        rules_config_1.ChecklistManifestService,
         rules_config_1.ReviewJsonService,
         rules_config_1.GateTokenService,
         rules_config_1.SubagentProvenanceService,

package/src/scripts/commands/finish-upsert-pr-command.js.map

@@ -1 +1 @@
-{"version":3,"file":"finish-upsert-pr-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/finish-upsert-pr-command.ts"],"names":[],"mappings":";;;;AAAA,iDAAoD;AACpD,+CAAyB;AACzB,mDAA6B;AAC7B,0DAKiC;AACjC,yCAA2D;AAC3D,2EAAgE;AAChE,6DAAyD;AACzD,uEAAmE;AACnE,mDAA+C;AAC/C,+DAA6E;AAC7E,yDAAqD;AACrD,qDAAkE;AAClE,yDAAuD;AACvD,qDAA+D;AAC/D,uEAAkE;AAClE,yDAA8G;AAE9G,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE,gGAAgG;AAChG,MAAM,KAAK;IACP,MAAM,CAAS;IACf,GAAG,CAAS;IAEZ,YAAY,MAAc,EAAE,GAAW;QACnC,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,GAAG,GAAG,GAAG,CAAC;IACnB,CAAC;CACJ;AAED,uGAAuG;AACvG,oGAAoG;AACpG,MAAM,YAAY;IACd,QAAQ,CAAS;IACjB,KAAK,CAAe;IAEpB,YAAY,QAAgB,EAAE,KAAmB;QAC7C,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;IACvB,CAAC;CACJ;AAED,wGAAwG;AACxG,oGAAoG;AACpG,kGAAkG;AAClG,0BAA0B;AAEnB,IAAM,qBAAqB,GAA3B,MAAM,qBAAqB;IAET;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IAhBrB,YACqB,cAA8B,EAC9B,YAA0B,EAC1B,YAA0B,EAC1B,OAAgB,EAChB,aAA4B,EAC5B,UAAsB,EACtB,QAAkB,EAClB,QAAkB,EAClB,SAA2B,EAC3B,SAAoB,EACpB,iBAAoC,EACpC,eAAyC,EACzC,iBAAoC,EACpC,gBAAkC,EAClC,UAAqC,EACrC,YAA0C;QAf1C,mBAAc,GAAd,cAAc,CAAgB;QAC9B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,YAAO,GAAP,OAAO,CAAS;QAChB,kBAAa,GAAb,aAAa,CAAe;QAC5B,eAAU,GAAV,UAAU,CAAY;QACtB,aAAQ,GAAR,QAAQ,CAAU;QAClB,aAAQ,GAAR,QAAQ,CAAU;QAClB,cAAS,GAAT,SAAS,CAAkB;QAC3B,cAAS,GAAT,SAAS,CAAW;QACpB,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,oBAAe,GAAf,eAAe,CAA0B;QACzC,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,qBAAgB,GAAhB,gBAAgB,CAAkB;QAClC,eAAU,GAAV,UAAU,CAA2B;QACrC,iBAAY,GAAZ,YAAY,CAA8B;IAC5D,CAAC;IAEJ,KAAK,CAAC,GAAG;QACL,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,gGAAgG;QAChG,IAAA,4BAAa,EAAC,QAAQ,EAAE,2BAA2B,CAAC,CAAC;QACrD,+FAA+F;QAC/F,MAAM,IAAI,CAAC,0BAA0B,CAAC,QAAQ,CAAC,CAAC;QAEhD,oGAAoG;QACpG,iGAAiG;QACjG,8FAA8F;QAC9F,MAAM,IAAI,GAAG,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC;QAC9F,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC,CAAC;QACzG,iGAAiG;QACjG,kGAAkG;QAClG,2FAA2F;QAC3F,2FAA2F;QAC3F,iGAAiG;QACjG,qGAAqG;QACrG,+FAA+F;QAC/F,iGAAiG;QACjG,MAAM,WAAW,GAAG,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC;QACvD,IAAI,CAAC,sBAAsB,CAAC,QAAQ,EAAE,WAAW,EAAE,QAAQ,CAAC,CAAC;QAC7D,MAAM,MAAM,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAAC,IAAA,6BAAc,EAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,QAAQ,CAAC,CAAC;QAEtG,+FAA+F;QAC/F,6FAA6F;QAC7F,mGAAmG;QACnG,MAAM,aAAa,GAAG,IAAA,wBAAQ,EAAC,2BAA2B,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;QACzF,MAAM,kBAAkB,GAAG,IAAI,CAAC,iBAAiB,CAAC,QAAQ,EAAE,aAAa,CAAC,CAAC;QAE3E,8FAA8F;QAC9F,IAAI,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;QAEvC,wGAAwG;QACxG,IAAI,CAAC,aAAa,CAAC,YAAY,CAAC,QAAQ,EAAE,IAAI,iCAAgB,CAC1D,iCAAiC,EAAE,0BAA0B,EAAE,uCAAuC,CACzG,CAAC,CAAC;QACH,MAAM,IAAI,GAAG,IAAI,CAAC,YAAY,CAAC,cAAc,CAAC,IAAA,wBAAQ,EAAC,2BAA2B,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QAElH,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,qBAAqB,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACtE,MAAM,KAAK,GAAG,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;QACvC,MAAM,KAAK,GAAG,IAAI,CAAC,qBAAqB,CAAC,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,CAAC,CAAC;QAClF,oGAAoG;QACpG,mGAAmG;QACnG,kGAAkG;QAClG,8FAA8F;QAC9F,gGAAgG;QAChG,MAAM,QAAQ,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC;QAC3D,MAAM,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC,CAAC;QACnD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,eAAe,CAAC,KAAK,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC3F,MAAM,MAAM,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,KAAK,CAAC,CAAC;QACjE,oGAAoG;QACpG,wEAAwE;QACxE,IAAI,CAAC,oBAAoB,CAAC,QAAQ,EAAE,MAAM,CAAC,QAAQ,EAAE,KAAK,CAAC,UAAU,EAAE,kBAAkB,CAAC,CAAC;QAC3F,MAAM,KAAK,GAAG,MAAM,CAAC,QAAQ,CAAC;QAE9B,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,IAAI,GAAG,GAAG,GAAG,8CAA8C,GAAG,GAAG,GAAG,IAAI;YACxE,kDAAkD;YAClD,SAAS,KAAK,CAAC,CAAC,CAAC,+BAA+B,KAAK,EAAE,CAAC,CAAC,CAAC,4BAA4B,aAAa,KAAK,KAAK;YAC7G,0CAA0C,IAAI,kDAAkD;YAChG,SAAS,MAAM,CAAC,KAAK,CAAC,OAAO,IAAI;YACjC,kBAAkB,IAAI,yDAAyD,CAClF,CAAC;IACN,CAAC;IAED,uGAAuG;IACvG,sGAAsG;IACtG,oGAAoG;IAC5F,KAAK,CAAC,0BAA0B,CAAC,QAAgB;QACrD,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,WAAW,CAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QACvF,MAAM,SAAS,GAAG,IAAI,CAAC,UAAU,CAAC,qBAAqB,CAAC,IAAI,CAAC,CAAC;QAC9D,MAAM,MAAM,GAAG,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAC7E,IAAI,CAAC,SAAS,IAAI,CAAC,MAAM,IAAI,MAAM,CAAC,SAAS;YAAE,OAAO;QACtD,MAAM,IAAI,CAAC,QAAQ,CAAC,QAAQ,CACxB,QAAQ,EAAE,qBAAqB,EAAE,SAAS,EAC1C,IAAI,0BAAY,CAAC,MAAM,CAAC,aAAa,EAAE,MAAM,CAAC,YAAY,EAAE,MAAM,CAAC,YAAY,EAAE,MAAM,CAAC,QAAQ,CAAC,EACjG,IAAI,2BAAe,CAAC,MAAM,CAAC,eAAe,EAAE,KAAK,CAAC,CACrD,CAAC;IACN,CAAC;IAED;;;;OAIG;IACK,sBAAsB,CAAC,QAAgB,EAAE,WAAmB,EAAE,QAAsC;QACxG,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAClC,MAAM,UAAU,GAAG,IAAA,6BAAc,EAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACzD,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,oBAAoB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC5E,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QACjC,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QAC/E,MAAM,IAAI,4BAAa,CACnB,aAAa,OAAO,CAAC,MAAM,OAAO,QAAQ,CAAC,MAAM,oDAAoD;YACrG,2BAA2B,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM;YACjE,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAC,MAAM;YAC/D,oFAAoF,CACvF,CAAC;IACN,CAAC;IAEO,MAAM,CAAC,IAAc;QACzB,MAAM,MAAM,GAAG,IAAA,yBAAS,EAAC,KAAK,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QAC5D,OAAO,MAAM,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;IACnE,CAAC;IAED,gGAAgG;IAChG,uGAAuG;IAC/F,WAAW,CAAC,MAAkB;QAClC,IAAI,MAAM,CAAC,KAAK,KAAK,EAAE;YAAE,OAAO,MAAM,CAAC,KAAK,CAAC;QAC7C,OAAO,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,OAAO,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC;IAC5E,CAAC;IAED,yDAAyD;IACjD,qBAAqB,CAAC,QAAgB,EAAE,WAAoB,EAAE,MAAkB,EAAE,KAAa,EAAE,QAAsC;QAC3I,MAAM,MAAM,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC;QAChD,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,YAAY,EAAE,aAAa,EAAE,MAAM,CAAC,CAAC,CAAC;QACrE,MAAM,WAAW,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC,CAAC;QACvD,MAAM,QAAQ,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,aAAa,CAAC,CAAC,CAAC;QAC3D,MAAM,KAAK,GAAG,GAAG,SAAS,KAAK,WAAW,EAAE,CAAC;QAC7C,MAAM,YAAY,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,aAAa,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAS,EAAW,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;QAC7H,MAAM,KAAK,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC,CAAC;QAE3C,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,MAAM,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;QAClF,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,KAAK,CAAC,CAAC;QAC1D,MAAM,IAAI,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAClD,OAAO,IAAI,0BAAc,CAAC,KAAK,EAAE,WAAW,EAAE,QAAQ,EAAE,WAAW,EAAE,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,CAAC,CAAC;IACzH,CAAC;IAED,sGAAsG;IACtG,mFAAmF;IAC3E,aAAa,CAAC,QAAsC,EAAE,MAAkB;QAC5E,OAAO,QAAQ,CAAC,GAAG,CAAC,CAAC,GAAsB,EAAgB,EAAE;YACzD,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAAC,GAAG,EAAE,MAAM,CAAC,OAAO,CAAC,CAAC;YAC3E,OAAO,IAAI,wBAAY,CAAC,GAAG,CAAC,EAAE,EAAE,OAAO,CAAC,MAAM,EAAE,OAAO,CAAC,MAAM,CAAC,CAAC;QACpE,CAAC,CAAC,CAAC;IACP,CAAC;IAED,qGAAqG;IACrG,oGAAoG;IAC5F,aAAa,CAAC,QAAgB,EAAE,OAAe;QACnD,MAAM,MAAM,GAAG,IAAI,CAAC,gBAAgB,CAAC,eAAe,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QACxE,OAAO,MAAM,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,MAAM,IAAI,CAAC;IAClD,CAAC;IAED,kGAAkG;IAClG,uGAAuG;IACvG,wGAAwG;IAChG,iBAAiB,CAAC,QAAsC,EAAE,MAAc;QAC5E,MAAM,MAAM,GAAa,EAAE,CAAC;QAC5B,IAAI,QAAQ,GAAG,IAAI,CAAC,CAAC,0CAA0C;QAC/D,MAAM,SAAS,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,CAAS,EAAW,EAAE,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC;QAC7H,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACvB,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,cAAc,CAAC,SAAS,EAAE,MAAM,CAAC,CAAC;YACjE,QAAQ,GAAG,MAAM,CAAC,MAAM,KAAK,4BAAa,CAAC;YAC3C,IAAI,MAAM,CAAC,MAAM,KAAK,iCAAkB,EAAE,CAAC;gBACvC,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;YAC/B,CAAC;iBAAM,IAAI,MAAM,CAAC,MAAM,KAAK,iCAAkB,EAAE,CAAC;gBAC9C,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,MAAM,CAAC,MAAM,IAAI,CAAC,CAAC;YACnD,CAAC;QACL,CAAC;QACD,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACpB,MAAM,IAAI,4BAAa,CACnB,GAAG,MAAM,CAAC,MAAM,0HAA0H;gBAC1I,MAAM,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;gBACxD,4FAA4F,CAC/F,CAAC;QACN,CAAC;QACD,OAAO,QAAQ,CAAC;IACpB,CAAC;IAED,mGAAmG;IACnG,mGAAmG;IACnG,kFAAkF;IAC1E,oBAAoB,CAAC,QAAgB,EAAE,QAAgB,EAAE,IAA6B,EAAE,kBAA2B;QACvH,IAAI,QAAQ,KAAK,EAAE,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QACjD,IAAI,CAAC,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,iBAAiB;YAAE,OAAO;QAChE,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,sBAAsB,CAAC,IAAI,EAAE,kBAAkB,CAAC,CAAC;QAC7E,MAAM,KAAK,GAAG,IAAA,uBAAQ,EAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QACrE,EAAE,CAAC,SAAS,CAAC,KAAK,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACzC,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,wBAAwB,CAAC,CAAC;QAC3D,EAAE,CAAC,aAAa,CAAC,OAAO,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;QACpD,MAAM,SAAS,GAAG,IAAI,CAAC,sBAAsB,CAAC,QAAQ,CAAC,CAAC;QACxD,MAAM,IAAI,GAAG,SAAS,KAAK,EAAE;YACzB,CAAC,CAAC,CAAC,KAAK,EAAE,UAAU,EAAE,OAAO,EAAE,wCAAwC,SAAS,EAAE,EAAE,SAAS,EAAE,OAAO,CAAC;YACvG,CAAC,CAAC,CAAC,KAAK,EAAE,UAAU,EAAE,MAAM,EAAE,+BAA+B,QAAQ,WAAW,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QAC1G,MAAM,GAAG,GAAG,IAAA,yBAAS,EAAC,IAAI,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QACxD,IAAI,GAAG,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACnB,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,uFAAuF,CAAC,CAAC;QAClH,CAAC;aAAM,CAAC;YACJ,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,SAAS,KAAK,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,QAAQ,mCAAmC,CAAC,CAAC;QAC3G,CAAC;IACL,CAAC;IAED,oGAAoG;IAC5F,sBAAsB,CAAC,QAAgB;QAC3C,MAAM,GAAG,GAAG,IAAA,yBAAS,EAAC,IAAI,EAAE;YACxB,KAAK,EAAE,YAAY,EAAE,+BAA+B,QAAQ,WAAW;YACvE,MAAM,EAAE,kCAAkC,oCAAwB,WAAW;SAChF,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QACzB,IAAI,GAAG,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAChC,OAAO,CAAC,GAAG,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAC1D,CAAC;IAED,mGAAmG;IACnG,mGAAmG;IACnG,mGAAmG;IACnG,4EAA4E;IACpE,QAAQ,CAAC,QAAgB,EAAE,UAAkB,EAAE,IAAY,EAAE,KAAa,EAAE,KAAqB;QACrG,MAAM,KAAK,GAAG,IAAA,uBAAQ,EAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QACrE,EAAE,CAAC,SAAS,CAAC,KAAK,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;QAChD,EAAE,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,GAAG,IAAI,CAAC,CAAC;QAExC,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,UAAU,EAAE,KAAK,EAAE,QAAQ,CAAC,CAAC;QACtE,IAAI,SAAS,CAAC,YAAY,EAAE,CAAC;YACzB,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,wEAAwE,GAAG,QAAQ,GAAG,IAAI,CAAC,CAAC;YACjH,OAAO,IAAI,YAAY,CAAC,EAAE,EAAE,IAAI,wBAAY,CAAC,KAAK,EAAE,KAAK,EACrD,yEAAyE,CAAC,CAAC,CAAC;QACpF,CAAC;QACD,MAAM,GAAG,GAAG,SAAS,CAAC,MAAM,CAAC;QAE7B,+FAA+F;QAC/F,iGAAiG;QACjG,+FAA+F;QAC/F,4EAA4E;QAC5E,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;QACnC,MAAM,OAAO,GAAG,GAAG,CAAC,MAAM,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,KAAK,MAAM,GAAG,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC;QACxE,MAAM,aAAa,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,sBAAsB,CAAC,CAAC;QAC/D,EAAE,CAAC,aAAa,CAAC,aAAa,EAAE,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,KAAK,EAAE,GAAG,CAAC,GAAG,CAAC,GAAG,IAAI,CAAC,CAAC;QACxF,iGAAiG;QACjG,+FAA+F;QAC/F,oFAAoF;QACpF,gGAAgG;QAChG,MAAM,SAAS,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,SAAS,IAAI,EAAE,CAAC;QACnE,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,EAAE,aAAa,EAAE,SAAS,CAAC,CAAC;QACnF,OAAO,IAAI,YAAY,CAAC,GAAG,CAAC,MAAM,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;IAC3E,CAAC;IAED,kGAAkG;IAClG,qGAAqG;IAC7F,KAAK,CAAC,UAAkB;QAC5B,MAAM,MAAM,GAAG,IAAA,yBAAS,EACpB,IAAI,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,UAAU,EAAE,QAAQ,EAAE,YAAY,EAAE,MAAM,EAAE,0BAA0B,CAAC,EAC5F,EAAE,QAAQ,EAAE,MAAM,EAAE,CACvB,CAAC;QACF,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACtB,OAAO,IAAI,KAAK,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;QAC7B,CAAC;QACD,MAAM,KAAK,GAAG,CAAC,MAAM,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QACvD,OAAO,IAAI,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,EAAE,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;IACrD,CAAC;CACJ,CAAA;AAhRY,sDAAqB;gCAArB,qBAAqB;IADjC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QAChB,mCAAY;QACZ,4BAAY;QACjB,kBAAO;QACD,8BAAa;QAChB,wBAAU;QACZ,oBAAQ;QACR,oBAAQ;QACP,qCAAgB;QAChB,qBAAS;QACD,sCAAiB;QACnB,uCAAwB;QACtB,gCAAiB;QAClB,+BAAgB;QACtB,wCAAyB;QACvB,2CAA4B;GAjBtD,qBAAqB,CAgRjC","sourcesContent":["import { execSync, spawnSync } from 'child_process';\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport {\n    loadAndValidate, prDirFor, reviewJsonPath, ReviewJson, RequiredChecklist,\n    writeTemplate, RepoRootFinder, ReviewJsonService, ChecklistManifestService,\n    GateTokenService, SubagentProvenanceService, PROVENANCE_OK, PROVENANCE_MISSING, PROVENANCE_SKIPPED,\n    ChecklistInstructionsService, InformAiError,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { AiBranchName } from '../workflow/git-readAiBranchName';\nimport { BranchNaming } from '../workflow/branch-naming';\nimport { ChecklistDetector } from '../workflow/checklist-detector';\nimport { GitExec } from '../workflow/git-exec';\nimport { BuildAffected, BuildGateOptions } from '../workflow/build-affected';\nimport { MergeState } from '../workflow/merge-state';\nimport { MergeEnd, MergeEndOptions } from '../workflow/merge-end';\nimport { MergeContext } from '../workflow/merge-start';\nimport { PrMerger, MergeOutcome } from '../workflow/pr-merger';\nimport { GatedPrPublisher } from '../workflow/gated-pr-publisher';\nimport { Dashboard, DashboardInput, ChecklistRow, CHECKLIST_COMMENT_MARKER } from '../../dashboard/dashboard';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n// A resolved PR's number + web URL. Both '' when the PR can't be resolved (e.g. create failed).\nclass PrRef {\n    number: string;\n    url: string;\n\n    constructor(number: string, url: string) {\n        this.number = number;\n        this.url = url;\n    }\n}\n\n// The outcome of the whole upsert: the PR number ('' when it could not be resolved) plus what actually\n// happened to the merge, so the final summary reports the REAL result rather than assuming success.\nclass UpsertResult {\n    prNumber: string;\n    merge: MergeOutcome;\n\n    constructor(prNumber: string, merge: MergeOutcome) {\n        this.prNumber = prNumber;\n        this.merge = merge;\n    }\n}\n\n// FINISH of the AI-first PR flow. Runs after the AI wrote review.json. In order: (1) if a 3-point merge\n// was in progress, validate + commit + FINALIZE via merge-END; (2) REQUIRE review.json; (3) run the\n// authoritative build gate; (4) render the dashboard; (5) create/update the PR via `gh`. The ONLY\n// command that posts PRs.\n@injectable(bindingScopeValues.Singleton)\nexport class FinishUpsertPrCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly aiBranchName: AiBranchName,\n        private readonly branchNaming: BranchNaming,\n        private readonly gitExec: GitExec,\n        private readonly buildAffected: BuildAffected,\n        private readonly mergeState: MergeState,\n        private readonly mergeEnd: MergeEnd,\n        private readonly prMerger: PrMerger,\n        private readonly publisher: GatedPrPublisher,\n        private readonly dashboard: Dashboard,\n        private readonly checklistDetector: ChecklistDetector,\n        private readonly manifestService: ChecklistManifestService,\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly gateTokenService: GateTokenService,\n        private readonly provenance: SubagentProvenanceService,\n        private readonly instructions: ChecklistInstructionsService,\n    ) {}\n\n    async run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the AI-facing workflow doc so it's present + current for any failure message to cite.\n        writeTemplate(repoRoot, 'webpieces.git-workflow.md');\n        // 1. Finish any in-progress conflict resolution: validate + commit + finalize the branch swap.\n        await this.finalizeAnyInProgressMerge(repoRoot);\n\n        // 2. REQUIRE the AI-authored review.json (throws InformAiError with the schema if missing/invalid).\n        //    Compute the consumer checklists this diff triggered FIRST so an unacknowledged BLOCK throws\n        //    here — BEFORE any `gh pr create` — matching the guarantee buildCommand already provides.\n        const defs = this.manifestService.load(repoRoot, loadAndValidate(repoRoot).prGate.checklists);\n        const required = this.checklistDetector.toRequired(this.checklistDetector.detectForRepo(repoRoot, defs));\n        // review-<id>.json files persist locally between runs, so a re-run after a push re-validates the\n        // EXISTING verdicts against the (possibly changed) triggered set for free: an unchanged checklist\n        // needs no re-review, a newly-triggered one refuses until its file is written. That is the\n        // \"full review only when the checklist surface changes\" behavior — no special-casing here.\n        // FAIL FAST on missing reviewers, BEFORE review.json is even parsed. A missing reviewer is not a\n        // review.json defect and folding it into that error made the AI fix the wrong thing; and the message\n        // lists ONLY the subagents that still owe a verdict, so an already-reviewed checklist is never\n        // re-instructed. Same computation + same renderer as `wp-checklist`, so the two cannot disagree.\n        const featureName = this.aiBranchName.getFeatureName();\n        this.assertEveryReviewerRan(repoRoot, featureName, required);\n        const review = this.reviewJsonService.loadReviewJson(reviewJsonPath(repoRoot, featureName), required);\n\n        // 2c. For any BLOCK checklist that names a reviewer `subagent`, VERIFY (from the harness's own\n        //     artifacts) that such a subagent actually ran on this branch — the coding agent may not\n        //     self-certify. Absent CLAUDE_CODE_SESSION_ID this skips with a warning (CI / plain terminal).\n        const currentBranch = execSync('git branch --show-current', { encoding: 'utf8' }).trim();\n        const provenanceVerified = this.enforceProvenance(required, currentBranch);\n\n        // 2b. The build gate validates the WORKING TREE but we push HEAD — so they MUST be identical.\n        this.gitExec.assertCleanTree(repoRoot);\n\n        // 3. Authoritative build gate, then post the gated body, then push (that ORDER — see GatedPrPublisher).\n        this.buildAffected.runBuildGate(repoRoot, new BuildGateOptions(\n            '🛠️  Build gate (authoritative)', 'pnpm wp-finish-upsert-pr', 'Build failed — no PR created/updated.',\n        ));\n        const base = this.branchNaming.baseBranchName(execSync('git branch --show-current', { encoding: 'utf8' }).trim());\n\n        process.stdout.write('\\n' + SEP + '📋 Dashboard + PR\\n' + SEP + '\\n');\n        const title = this.prTitleFrom(review);\n        const input = this.computeDashboardInput(repoRoot, true, review, title, required);\n        // Append the hidden HMAC gate token bound to the LOCAL HEAD sha — computed BEFORE the push, because\n        // GatedPrPublisher writes the body first so CI's `synchronize` read can never see a stale token. A\n        // valid token in the PR body is proof this gated flow ran + passed on this exact commit, which CI\n        // (`wp-check-pr`) recomputes. We reach here only after the build gate + every BLOCK checklist\n        // passed, so minting is legitimate. Nothing about HMAC(salt, HEAD) needs the remote to have it.\n        const gateSalt = loadAndValidate(repoRoot).prGate.gateSalt;\n        const headSha = this.gitOut(['rev-parse', 'HEAD']);\n        const body = this.dashboard.renderDashboard(input) + this.gateTokenBody(gateSalt, headSha);\n        const result = this.upsertPr(repoRoot, base, body, title, input);\n        // Publish each reviewer's full output as ONE combined PR comment (idempotent, opt-out-aware). Never\n        // fatal — the PR is already up by now, so a comment failure only warns.\n        this.postChecklistComment(repoRoot, result.prNumber, input.checklists, provenanceVerified);\n        const prNum = result.prNumber;\n\n        process.stdout.write(\n            '\\n' + SEP + '✅ PR finished — here is exactly what I did\\n' + SEP + '\\n' +\n            `   1. validated the build gate (authoritative)\\n` +\n            `   2. ${prNum ? `wrote the gated body to PR #${prNum}` : 'composed the gated PR body'} titled: \"${title}\"\\n` +\n            `   3. force-pushed your work to origin/${base} (after the body, so CI reads the right token)\\n` +\n            `   4. ${result.merge.message}\\n` +\n            `   You are on  ${base}  — same name as the remote branch and the PR head.\\n\\n`,\n        );\n    }\n\n    // Validate + commit + finalize a 3-point merge the AI resolved, if one is in progress. Finalizing here\n    // does NOT push (pushRemote=false): this command pushes exactly ONCE, from GatedPrPublisher, and only\n    // after review.json + every BLOCK checklist + the build gate pass and the gated PR body is written.\n    private async finalizeAnyInProgressMerge(repoRoot: string): Promise<void> {\n        const home = this.mergeState.mergeDirFor(repoRoot, this.aiBranchName.getFeatureName());\n        const activeDir = this.mergeState.findActiveMergeRunDir(home);\n        const marker = activeDir ? this.mergeState.readMergeMarker(activeDir) : null;\n        if (!activeDir || !marker || marker.validated) return;\n        await this.mergeEnd.mergeEnd(\n            repoRoot, 'wp-finish-upsert-pr', activeDir,\n            new MergeContext(marker.currentBranch, marker.squashBranch, marker.backupBranch, marker.prNumber),\n            new MergeEndOptions(marker.conflictedFiles, false),\n        );\n    }\n\n    /**\n     * Refuse the PR while ANY applicable checklist still owes a verdict, naming exactly those reviewers and\n     * exactly what to tell them. Throws InformAiError so the AI gets one actionable message; passes silently\n     * when nothing is pending, and is a no-op for a repo with no checklists.\n     */\n    private assertEveryReviewerRan(repoRoot: string, featureName: string, required: readonly RequiredChecklist[]): void {\n        if (required.length === 0) return;\n        const reviewPath = reviewJsonPath(repoRoot, featureName);\n        const results = this.reviewJsonService.loadChecklistResults(reviewPath, required);\n        const pending = this.reviewJsonService.pendingChecklists(required, results);\n        if (pending.length === 0) return;\n        const context = this.reviewJsonService.reviewContextFor(repoRoot, featureName);\n        throw new InformAiError(\n            `⛔ NO PR — ${pending.length} of ${required.length} review checklist(s) that apply to this diff have ` +\n            `no passing verdict yet: ${this.instructions.names(pending)}\\n\\n` +\n            `${this.instructions.render(pending, reviewPath, context)}\\n\\n` +\n            `Then re-run: pnpm wp-finish-upsert-pr   (or check anytime with: pnpm wp-checklist)`,\n        );\n    }\n\n    private gitOut(args: string[]): string {\n        const result = spawnSync('git', args, { encoding: 'utf8' });\n        return result.status === 0 ? (result.stdout ?? '').trim() : '';\n    }\n\n    // The user-facing PR title: the AI-authored review.title, or — if omitted — a readable fallback\n    // derived from the stable feature name (NEVER the internal `Squash merge of <branch>` commit subject).\n    private prTitleFrom(review: ReviewJson): string {\n        if (review.title !== '') return review.title;\n        return this.aiBranchName.getFeatureName().replace(/[-/]+/g, ' ').trim();\n    }\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    private computeDashboardInput(repoRoot: string, buildPassed: boolean, review: ReviewJson, title: string, required: readonly RequiredChecklist[]): DashboardInput {\n        const config = loadAndValidate(repoRoot).prGate;\n        const forkPoint = this.gitOut(['merge-base', 'origin/main', 'HEAD']);\n        const featureHead = this.gitOut(['rev-parse', 'HEAD']);\n        const mainHead = this.gitOut(['rev-parse', 'origin/main']);\n        const range = `${forkPoint}..${featureHead}`;\n        const changedFiles = this.gitOut(['diff', range, '--name-only']).split('\\n').filter((f: string): boolean => f.trim() !== '');\n        const patch = this.gitOut(['diff', range]);\n\n        const gateResults = this.dashboard.computeGateResults(config.gates, changedFiles);\n        const disables = this.dashboard.countAddedDisables(patch);\n        const rows = this.checklistRows(required, review);\n        return new DashboardInput(title, gateResults, disables, buildPassed, forkPoint, featureHead, mainHead, review, rows);\n    }\n\n    // Pair each matched checklist with its resolved verdict for the dashboard. (A checklist reaching this\n    // point is always PASS/OVERRIDDEN — loadReviewJson already threw on FAIL/MISSING.)\n    private checklistRows(required: readonly RequiredChecklist[], review: ReviewJson): ChecklistRow[] {\n        return required.map((req: RequiredChecklist): ChecklistRow => {\n            const verdict = this.reviewJsonService.resolveVerdict(req, review.results);\n            return new ChecklistRow(req.id, verdict.status, verdict.detail);\n        });\n    }\n\n    // Hidden HMAC gate-token marker (with a leading blank line) to append to the PR body, or '' when the\n    // repo sets no gateSalt (byte-identical body to before this feature). Bound to the pushed HEAD sha.\n    private gateTokenBody(gateSalt: string, headSha: string): string {\n        const marker = this.gateTokenService.gateTokenMarker(gateSalt, headSha);\n        return marker === '' ? '' : `\\n\\n${marker}\\n`;\n    }\n\n    // Enforce that EACH matched checklist was reviewed by its OWN named subagent, as a DISTINCT run —\n    // the coding agent may not self-certify, and one reviewer may not stand in for several. A verified set\n    // passes silently; no session id warns but passes; any missing reviewer throws so the PR does not open.\n    private enforceProvenance(required: readonly RequiredChecklist[], branch: string): boolean {\n        const errors: string[] = [];\n        let verified = true; // no reviewers to verify ⇒ vacuously true\n        const subagents = required.map((r: RequiredChecklist): string => r.subagent.trim()).filter((s: string): boolean => s !== '');\n        if (subagents.length > 0) {\n            const result = this.provenance.verifyDistinct(subagents, branch);\n            verified = result.status === PROVENANCE_OK;\n            if (result.status === PROVENANCE_MISSING) {\n                errors.push(result.detail);\n            } else if (result.status === PROVENANCE_SKIPPED) {\n                process.stderr.write(`⚠️  ${result.detail}\\n`);\n            }\n        }\n        if (errors.length > 0) {\n            throw new InformAiError(\n                `${errors.length} checklist(s) require an independent reviewer subagent that did not run — fix, then re-run pnpm wp-finish-upsert-pr:\\n\\n` +\n                errors.map((e: string): string => `  • ${e}`).join('\\n') +\n                `\\n\\nSpawn the named reviewer subagent to review the checklist on THIS branch, then re-run.`,\n            );\n        }\n        return verified;\n    }\n\n    // Publish every reviewer's full `output` as ONE combined PR comment, idempotently (find the marker\n    // comment → PATCH it, else POST). No-op when there is no PR number or no matched checklists. Never\n    // fatal: by here the PR is already created/updated, so a `gh` failure only warns.\n    private postChecklistComment(repoRoot: string, prNumber: string, rows: readonly ChecklistRow[], provenanceVerified: boolean): void {\n        if (prNumber === '' || rows.length === 0) return;\n        if (!loadAndValidate(repoRoot).prGate.checklistComments) return;\n        const body = this.dashboard.renderChecklistComment(rows, provenanceVerified);\n        const prDir = prDirFor(repoRoot, this.aiBranchName.getFeatureName());\n        fs.mkdirSync(prDir, { recursive: true });\n        const payload = path.join(prDir, 'checklist-comment.json');\n        fs.writeFileSync(payload, JSON.stringify({ body }));\n        const commentId = this.findChecklistCommentId(prNumber);\n        const args = commentId !== ''\n            ? ['api', '--method', 'PATCH', `repos/{owner}/{repo}/issues/comments/${commentId}`, '--input', payload]\n            : ['api', '--method', 'POST', `repos/{owner}/{repo}/issues/${prNumber}/comments`, '--input', payload];\n        const res = spawnSync('gh', args, { encoding: 'utf8' });\n        if (res.status !== 0) {\n            process.stderr.write('⚠️  Could not post the checklist review comment (non-fatal — the PR is already up).\\n');\n        } else {\n            process.stdout.write(`   ${commentId !== '' ? 'updated' : 'posted'} the checklist review comment ✓\\n`);\n        }\n    }\n\n    // The id of THIS tool's existing checklist comment on the PR (by the hidden marker), or '' if none.\n    private findChecklistCommentId(prNumber: string): string {\n        const res = spawnSync('gh', [\n            'api', '--paginate', `repos/{owner}/{repo}/issues/${prNumber}/comments`,\n            '--jq', `.[] | select(.body | contains(\"${CHECKLIST_COMMENT_MARKER}\")) | .id`,\n        ], { encoding: 'utf8' });\n        if (res.status !== 0) return '';\n        return (res.stdout ?? '').trim().split('\\n')[0] ?? '';\n    }\n\n    // The PR, the remote branch, and the local branch all share the one stable feature name. Look up /\n    // create / merge against `baseBranch` (baseBranchName tolerates a leftover `…wpN` mid-transition).\n    // GatedPrPublisher owns the edit/push/create half and its ORDERING — the gated body goes up before\n    // the push, so CI's `synchronize` read cannot see the previous run's token.\n    private upsertPr(repoRoot: string, baseBranch: string, body: string, title: string, input: DashboardInput): UpsertResult {\n        const prDir = prDirFor(repoRoot, this.aiBranchName.getFeatureName());\n        fs.mkdirSync(prDir, { recursive: true });\n        const bodyFile = path.join(prDir, 'pr-body.md');\n        fs.writeFileSync(bodyFile, body + '\\n');\n\n        const published = this.publisher.publish(baseBranch, title, bodyFile);\n        if (published.createFailed) {\n            process.stderr.write('⚠️  gh pr create failed — create the PR manually with the body in:\\n  ' + bodyFile + '\\n');\n            return new UpsertResult('', new MergeOutcome(false, false,\n                '⚠️  did NOT merge — there is no PR to merge (gh pr create failed above)'));\n        }\n        const num = published.number;\n\n        // Set the squash-merge SUBJECT to the PR title (+ the `(#N)` GitHub normally appends, which an\n        // explicit --subject would otherwise drop) and the BODY to the compact commit summary, so main's\n        // history carries the PR title + risk/flags/link — NOT the internal `Squash merge of <branch>`\n        // subject GitHub would inherit from the single squash commit on the branch.\n        const ref = this.prRef(baseBranch);\n        const subject = ref.number !== '' ? `${title} (#${ref.number})` : title;\n        const mergeBodyFile = path.join(prDir, 'merge-commit-body.md');\n        fs.writeFileSync(mergeBodyFile, this.dashboard.renderCommitBody(input, ref.url) + '\\n');\n        // PrMerger owns the direct-merge / auto-merge-fallback decision AND checks every gh status, so a\n        // merge that did not happen is reported as such instead of being swallowed (see pr-merger.ts).\n        // REQUIRED config — no default here on purpose. A missing value (an older published\n        // rules-config that has no such field) reaches PrMerger as '' and is treated as \"do not merge\".\n        const mergeMode = loadAndValidate(repoRoot).prGate.mergeMode ?? '';\n        const outcome = this.prMerger.merge(baseBranch, subject, mergeBodyFile, mergeMode);\n        return new UpsertResult(ref.number !== '' ? ref.number : num, outcome);\n    }\n\n    // The PR's number + web URL (for the merge subject `(#N)` and the commit-body back-link). Both ''\n    // if it can't be resolved. Rendered via jq into one tab-separated line so no JSON parsing is needed.\n    private prRef(baseBranch: string): PrRef {\n        const result = spawnSync(\n            'gh', ['pr', 'view', baseBranch, '--json', 'number,url', '--jq', '\"\\\\(.number)\\\\t\\\\(.url)\"'],\n            { encoding: 'utf8' },\n        );\n        if (result.status !== 0) {\n            return new PrRef('', '');\n        }\n        const parts = (result.stdout ?? '').trim().split('\\t');\n        return new PrRef(parts[0] ?? '', parts[1] ?? '');\n    }\n}\n"]}
+{"version":3,"file":"finish-upsert-pr-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/finish-upsert-pr-command.ts"],"names":[],"mappings":";;;;AAAA,iDAAoD;AACpD,+CAAyB;AACzB,mDAA6B;AAC7B,0DAKiC;AACjC,yCAA2D;AAC3D,2EAAgE;AAChE,6DAAyD;AACzD,uEAAmE;AACnE,mDAA+C;AAC/C,+DAA6E;AAC7E,yDAAqD;AACrD,qDAAkE;AAClE,yDAAuD;AACvD,qDAA+D;AAC/D,uEAAkE;AAClE,yDAA8G;AAE9G,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE,gGAAgG;AAChG,MAAM,KAAK;IACP,MAAM,CAAS;IACf,GAAG,CAAS;IAEZ,YAAY,MAAc,EAAE,GAAW;QACnC,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,GAAG,GAAG,GAAG,CAAC;IACnB,CAAC;CACJ;AAED,uGAAuG;AACvG,oGAAoG;AACpG,MAAM,YAAY;IACd,QAAQ,CAAS;IACjB,KAAK,CAAe;IAEpB,YAAY,QAAgB,EAAE,KAAmB;QAC7C,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;IACvB,CAAC;CACJ;AAED,wGAAwG;AACxG,oGAAoG;AACpG,kGAAkG;AAClG,0BAA0B;AAEnB,IAAM,qBAAqB,GAA3B,MAAM,qBAAqB;IAET;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IAfrB,YACqB,cAA8B,EAC9B,YAA0B,EAC1B,YAA0B,EAC1B,OAAgB,EAChB,aAA4B,EAC5B,UAAsB,EACtB,QAAkB,EAClB,QAAkB,EAClB,SAA2B,EAC3B,SAAoB,EACpB,iBAAoC,EACpC,iBAAoC,EACpC,gBAAkC,EAClC,UAAqC,EACrC,YAA0C;QAd1C,mBAAc,GAAd,cAAc,CAAgB;QAC9B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,YAAO,GAAP,OAAO,CAAS;QAChB,kBAAa,GAAb,aAAa,CAAe;QAC5B,eAAU,GAAV,UAAU,CAAY;QACtB,aAAQ,GAAR,QAAQ,CAAU;QAClB,aAAQ,GAAR,QAAQ,CAAU;QAClB,cAAS,GAAT,SAAS,CAAkB;QAC3B,cAAS,GAAT,SAAS,CAAW;QACpB,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,qBAAgB,GAAhB,gBAAgB,CAAkB;QAClC,eAAU,GAAV,UAAU,CAA2B;QACrC,iBAAY,GAAZ,YAAY,CAA8B;IAC5D,CAAC;IAEJ,KAAK,CAAC,GAAG;QACL,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,gGAAgG;QAChG,IAAA,4BAAa,EAAC,QAAQ,EAAE,2BAA2B,CAAC,CAAC;QACrD,+FAA+F;QAC/F,MAAM,IAAI,CAAC,0BAA0B,CAAC,QAAQ,CAAC,CAAC;QAEhD,oGAAoG;QACpG,iGAAiG;QACjG,8FAA8F;QAC9F,MAAM,IAAI,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC;QACzD,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,IAAI,CAAC,iBAAiB,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC,CAAC;QACzG,iGAAiG;QACjG,kGAAkG;QAClG,2FAA2F;QAC3F,2FAA2F;QAC3F,iGAAiG;QACjG,qGAAqG;QACrG,+FAA+F;QAC/F,iGAAiG;QACjG,MAAM,WAAW,GAAG,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC;QACvD,IAAI,CAAC,sBAAsB,CAAC,QAAQ,EAAE,WAAW,EAAE,QAAQ,CAAC,CAAC;QAC7D,MAAM,MAAM,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAAC,IAAA,6BAAc,EAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,QAAQ,CAAC,CAAC;QAEtG,+FAA+F;QAC/F,6FAA6F;QAC7F,mGAAmG;QACnG,MAAM,aAAa,GAAG,IAAA,wBAAQ,EAAC,2BAA2B,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;QACzF,MAAM,kBAAkB,GAAG,IAAI,CAAC,iBAAiB,CAAC,QAAQ,EAAE,aAAa,CAAC,CAAC;QAE3E,8FAA8F;QAC9F,IAAI,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;QAEvC,wGAAwG;QACxG,IAAI,CAAC,aAAa,CAAC,YAAY,CAAC,QAAQ,EAAE,IAAI,iCAAgB,CAC1D,iCAAiC,EAAE,0BAA0B,EAAE,uCAAuC,CACzG,CAAC,CAAC;QACH,MAAM,IAAI,GAAG,IAAI,CAAC,YAAY,CAAC,cAAc,CAAC,IAAA,wBAAQ,EAAC,2BAA2B,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QAElH,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,qBAAqB,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACtE,MAAM,KAAK,GAAG,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;QACvC,MAAM,KAAK,GAAG,IAAI,CAAC,qBAAqB,CAAC,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,CAAC,CAAC;QAClF,oGAAoG;QACpG,mGAAmG;QACnG,kGAAkG;QAClG,8FAA8F;QAC9F,gGAAgG;QAChG,MAAM,QAAQ,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC;QAC3D,MAAM,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC,CAAC;QACnD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,eAAe,CAAC,KAAK,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC3F,MAAM,MAAM,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,KAAK,CAAC,CAAC;QACjE,oGAAoG;QACpG,wEAAwE;QACxE,IAAI,CAAC,oBAAoB,CAAC,QAAQ,EAAE,MAAM,CAAC,QAAQ,EAAE,KAAK,CAAC,UAAU,EAAE,kBAAkB,CAAC,CAAC;QAC3F,MAAM,KAAK,GAAG,MAAM,CAAC,QAAQ,CAAC;QAE9B,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,IAAI,GAAG,GAAG,GAAG,8CAA8C,GAAG,GAAG,GAAG,IAAI;YACxE,kDAAkD;YAClD,SAAS,KAAK,CAAC,CAAC,CAAC,+BAA+B,KAAK,EAAE,CAAC,CAAC,CAAC,4BAA4B,aAAa,KAAK,KAAK;YAC7G,0CAA0C,IAAI,kDAAkD;YAChG,SAAS,MAAM,CAAC,KAAK,CAAC,OAAO,IAAI;YACjC,kBAAkB,IAAI,yDAAyD,CAClF,CAAC;IACN,CAAC;IAED,uGAAuG;IACvG,sGAAsG;IACtG,oGAAoG;IAC5F,KAAK,CAAC,0BAA0B,CAAC,QAAgB;QACrD,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,WAAW,CAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QACvF,MAAM,SAAS,GAAG,IAAI,CAAC,UAAU,CAAC,qBAAqB,CAAC,IAAI,CAAC,CAAC;QAC9D,MAAM,MAAM,GAAG,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAC7E,IAAI,CAAC,SAAS,IAAI,CAAC,MAAM,IAAI,MAAM,CAAC,SAAS;YAAE,OAAO;QACtD,MAAM,IAAI,CAAC,QAAQ,CAAC,QAAQ,CACxB,QAAQ,EAAE,qBAAqB,EAAE,SAAS,EAC1C,IAAI,0BAAY,CAAC,MAAM,CAAC,aAAa,EAAE,MAAM,CAAC,YAAY,EAAE,MAAM,CAAC,YAAY,EAAE,MAAM,CAAC,QAAQ,CAAC,EACjG,IAAI,2BAAe,CAAC,MAAM,CAAC,eAAe,EAAE,KAAK,CAAC,CACrD,CAAC;IACN,CAAC;IAED;;;;OAIG;IACK,sBAAsB,CAAC,QAAgB,EAAE,WAAmB,EAAE,QAAsC;QACxG,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAClC,MAAM,UAAU,GAAG,IAAA,6BAAc,EAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QACzD,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,oBAAoB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC5E,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QACjC,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QAC/E,MAAM,IAAI,4BAAa,CACnB,aAAa,OAAO,CAAC,MAAM,OAAO,QAAQ,CAAC,MAAM,oDAAoD;YACrG,2BAA2B,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM;YACjE,GAAG,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAC,MAAM;YAC/D,oFAAoF,CACvF,CAAC;IACN,CAAC;IAEO,MAAM,CAAC,IAAc;QACzB,MAAM,MAAM,GAAG,IAAA,yBAAS,EAAC,KAAK,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QAC5D,OAAO,MAAM,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;IACnE,CAAC;IAED,gGAAgG;IAChG,uGAAuG;IAC/F,WAAW,CAAC,MAAkB;QAClC,IAAI,MAAM,CAAC,KAAK,KAAK,EAAE;YAAE,OAAO,MAAM,CAAC,KAAK,CAAC;QAC7C,OAAO,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,OAAO,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC;IAC5E,CAAC;IAED,yDAAyD;IACjD,qBAAqB,CAAC,QAAgB,EAAE,WAAoB,EAAE,MAAkB,EAAE,KAAa,EAAE,QAAsC;QAC3I,MAAM,MAAM,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC;QAChD,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,YAAY,EAAE,aAAa,EAAE,MAAM,CAAC,CAAC,CAAC;QACrE,MAAM,WAAW,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC,CAAC;QACvD,MAAM,QAAQ,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,aAAa,CAAC,CAAC,CAAC;QAC3D,MAAM,KAAK,GAAG,GAAG,SAAS,KAAK,WAAW,EAAE,CAAC;QAC7C,MAAM,YAAY,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,aAAa,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAS,EAAW,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;QAC7H,MAAM,KAAK,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC,CAAC;QAE3C,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,MAAM,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;QAClF,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,KAAK,CAAC,CAAC;QAC1D,MAAM,IAAI,GAAG,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAClD,OAAO,IAAI,0BAAc,CAAC,KAAK,EAAE,WAAW,EAAE,QAAQ,EAAE,WAAW,EAAE,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,CAAC,CAAC;IACzH,CAAC;IAED,sGAAsG;IACtG,mFAAmF;IAC3E,aAAa,CAAC,QAAsC,EAAE,MAAkB;QAC5E,OAAO,QAAQ,CAAC,GAAG,CAAC,CAAC,GAAsB,EAAgB,EAAE;YACzD,MAAM,OAAO,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAAC,GAAG,EAAE,MAAM,CAAC,OAAO,CAAC,CAAC;YAC3E,OAAO,IAAI,wBAAY,CAAC,GAAG,CAAC,EAAE,EAAE,OAAO,CAAC,MAAM,EAAE,OAAO,CAAC,MAAM,CAAC,CAAC;QACpE,CAAC,CAAC,CAAC;IACP,CAAC;IAED,qGAAqG;IACrG,oGAAoG;IAC5F,aAAa,CAAC,QAAgB,EAAE,OAAe;QACnD,MAAM,MAAM,GAAG,IAAI,CAAC,gBAAgB,CAAC,eAAe,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QACxE,OAAO,MAAM,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,MAAM,IAAI,CAAC;IAClD,CAAC;IAED,kGAAkG;IAClG,uGAAuG;IACvG,wGAAwG;IAChG,iBAAiB,CAAC,QAAsC,EAAE,MAAc;QAC5E,MAAM,MAAM,GAAa,EAAE,CAAC;QAC5B,IAAI,QAAQ,GAAG,IAAI,CAAC,CAAC,0CAA0C;QAC/D,MAAM,SAAS,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAoB,EAAU,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,CAAS,EAAW,EAAE,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC;QAC7H,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACvB,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,cAAc,CAAC,SAAS,EAAE,MAAM,CAAC,CAAC;YACjE,QAAQ,GAAG,MAAM,CAAC,MAAM,KAAK,4BAAa,CAAC;YAC3C,IAAI,MAAM,CAAC,MAAM,KAAK,iCAAkB,EAAE,CAAC;gBACvC,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;YAC/B,CAAC;iBAAM,IAAI,MAAM,CAAC,MAAM,KAAK,iCAAkB,EAAE,CAAC;gBAC9C,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,MAAM,CAAC,MAAM,IAAI,CAAC,CAAC;YACnD,CAAC;QACL,CAAC;QACD,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACpB,MAAM,IAAI,4BAAa,CACnB,GAAG,MAAM,CAAC,MAAM,0HAA0H;gBAC1I,MAAM,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;gBACxD,4FAA4F,CAC/F,CAAC;QACN,CAAC;QACD,OAAO,QAAQ,CAAC;IACpB,CAAC;IAED,mGAAmG;IACnG,mGAAmG;IACnG,kFAAkF;IAC1E,oBAAoB,CAAC,QAAgB,EAAE,QAAgB,EAAE,IAA6B,EAAE,kBAA2B;QACvH,IAAI,QAAQ,KAAK,EAAE,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QACjD,IAAI,CAAC,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,iBAAiB;YAAE,OAAO;QAChE,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,sBAAsB,CAAC,IAAI,EAAE,kBAAkB,CAAC,CAAC;QAC7E,MAAM,KAAK,GAAG,IAAA,uBAAQ,EAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QACrE,EAAE,CAAC,SAAS,CAAC,KAAK,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACzC,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,wBAAwB,CAAC,CAAC;QAC3D,EAAE,CAAC,aAAa,CAAC,OAAO,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;QACpD,MAAM,SAAS,GAAG,IAAI,CAAC,sBAAsB,CAAC,QAAQ,CAAC,CAAC;QACxD,MAAM,IAAI,GAAG,SAAS,KAAK,EAAE;YACzB,CAAC,CAAC,CAAC,KAAK,EAAE,UAAU,EAAE,OAAO,EAAE,wCAAwC,SAAS,EAAE,EAAE,SAAS,EAAE,OAAO,CAAC;YACvG,CAAC,CAAC,CAAC,KAAK,EAAE,UAAU,EAAE,MAAM,EAAE,+BAA+B,QAAQ,WAAW,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QAC1G,MAAM,GAAG,GAAG,IAAA,yBAAS,EAAC,IAAI,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QACxD,IAAI,GAAG,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACnB,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,uFAAuF,CAAC,CAAC;QAClH,CAAC;aAAM,CAAC;YACJ,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,SAAS,KAAK,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,QAAQ,mCAAmC,CAAC,CAAC;QAC3G,CAAC;IACL,CAAC;IAED,oGAAoG;IAC5F,sBAAsB,CAAC,QAAgB;QAC3C,MAAM,GAAG,GAAG,IAAA,yBAAS,EAAC,IAAI,EAAE;YACxB,KAAK,EAAE,YAAY,EAAE,+BAA+B,QAAQ,WAAW;YACvE,MAAM,EAAE,kCAAkC,oCAAwB,WAAW;SAChF,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QACzB,IAAI,GAAG,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAChC,OAAO,CAAC,GAAG,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAC1D,CAAC;IAED,mGAAmG;IACnG,mGAAmG;IACnG,mGAAmG;IACnG,4EAA4E;IACpE,QAAQ,CAAC,QAAgB,EAAE,UAAkB,EAAE,IAAY,EAAE,KAAa,EAAE,KAAqB;QACrG,MAAM,KAAK,GAAG,IAAA,uBAAQ,EAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QACrE,EAAE,CAAC,SAAS,CAAC,KAAK,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;QAChD,EAAE,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,GAAG,IAAI,CAAC,CAAC;QAExC,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,UAAU,EAAE,KAAK,EAAE,QAAQ,CAAC,CAAC;QACtE,IAAI,SAAS,CAAC,YAAY,EAAE,CAAC;YACzB,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,wEAAwE,GAAG,QAAQ,GAAG,IAAI,CAAC,CAAC;YACjH,OAAO,IAAI,YAAY,CAAC,EAAE,EAAE,IAAI,wBAAY,CAAC,KAAK,EAAE,KAAK,EACrD,yEAAyE,CAAC,CAAC,CAAC;QACpF,CAAC;QACD,MAAM,GAAG,GAAG,SAAS,CAAC,MAAM,CAAC;QAE7B,+FAA+F;QAC/F,iGAAiG;QACjG,+FAA+F;QAC/F,4EAA4E;QAC5E,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;QACnC,MAAM,OAAO,GAAG,GAAG,CAAC,MAAM,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,KAAK,MAAM,GAAG,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC;QACxE,MAAM,aAAa,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,sBAAsB,CAAC,CAAC;QAC/D,EAAE,CAAC,aAAa,CAAC,aAAa,EAAE,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,KAAK,EAAE,GAAG,CAAC,GAAG,CAAC,GAAG,IAAI,CAAC,CAAC;QACxF,iGAAiG;QACjG,+FAA+F;QAC/F,oFAAoF;QACpF,gGAAgG;QAChG,MAAM,SAAS,GAAG,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,SAAS,IAAI,EAAE,CAAC;QACnE,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,EAAE,aAAa,EAAE,SAAS,CAAC,CAAC;QACnF,OAAO,IAAI,YAAY,CAAC,GAAG,CAAC,MAAM,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;IAC3E,CAAC;IAED,kGAAkG;IAClG,qGAAqG;IAC7F,KAAK,CAAC,UAAkB;QAC5B,MAAM,MAAM,GAAG,IAAA,yBAAS,EACpB,IAAI,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,UAAU,EAAE,QAAQ,EAAE,YAAY,EAAE,MAAM,EAAE,0BAA0B,CAAC,EAC5F,EAAE,QAAQ,EAAE,MAAM,EAAE,CACvB,CAAC;QACF,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACtB,OAAO,IAAI,KAAK,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;QAC7B,CAAC;QACD,MAAM,KAAK,GAAG,CAAC,MAAM,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QACvD,OAAO,IAAI,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,EAAE,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;IACrD,CAAC;CACJ,CAAA;AA/QY,sDAAqB;gCAArB,qBAAqB;IADjC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QAChB,mCAAY;QACZ,4BAAY;QACjB,kBAAO;QACD,8BAAa;QAChB,wBAAU;QACZ,oBAAQ;QACR,oBAAQ;QACP,qCAAgB;QAChB,qBAAS;QACD,sCAAiB;QACjB,gCAAiB;QAClB,+BAAgB;QACtB,wCAAyB;QACvB,2CAA4B;GAhBtD,qBAAqB,CA+QjC","sourcesContent":["import { execSync, spawnSync } from 'child_process';\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport {\n    loadAndValidate, prDirFor, reviewJsonPath, ReviewJson, RequiredChecklist,\n    writeTemplate, RepoRootFinder, ReviewJsonService,\n    GateTokenService, SubagentProvenanceService, PROVENANCE_OK, PROVENANCE_MISSING, PROVENANCE_SKIPPED,\n    ChecklistInstructionsService, InformAiError,\n} from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { AiBranchName } from '../workflow/git-readAiBranchName';\nimport { BranchNaming } from '../workflow/branch-naming';\nimport { ChecklistDetector } from '../workflow/checklist-detector';\nimport { GitExec } from '../workflow/git-exec';\nimport { BuildAffected, BuildGateOptions } from '../workflow/build-affected';\nimport { MergeState } from '../workflow/merge-state';\nimport { MergeEnd, MergeEndOptions } from '../workflow/merge-end';\nimport { MergeContext } from '../workflow/merge-start';\nimport { PrMerger, MergeOutcome } from '../workflow/pr-merger';\nimport { GatedPrPublisher } from '../workflow/gated-pr-publisher';\nimport { Dashboard, DashboardInput, ChecklistRow, CHECKLIST_COMMENT_MARKER } from '../../dashboard/dashboard';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n// A resolved PR's number + web URL. Both '' when the PR can't be resolved (e.g. create failed).\nclass PrRef {\n    number: string;\n    url: string;\n\n    constructor(number: string, url: string) {\n        this.number = number;\n        this.url = url;\n    }\n}\n\n// The outcome of the whole upsert: the PR number ('' when it could not be resolved) plus what actually\n// happened to the merge, so the final summary reports the REAL result rather than assuming success.\nclass UpsertResult {\n    prNumber: string;\n    merge: MergeOutcome;\n\n    constructor(prNumber: string, merge: MergeOutcome) {\n        this.prNumber = prNumber;\n        this.merge = merge;\n    }\n}\n\n// FINISH of the AI-first PR flow. Runs after the AI wrote review.json. In order: (1) if a 3-point merge\n// was in progress, validate + commit + FINALIZE via merge-END; (2) REQUIRE review.json; (3) run the\n// authoritative build gate; (4) render the dashboard; (5) create/update the PR via `gh`. The ONLY\n// command that posts PRs.\n@injectable(bindingScopeValues.Singleton)\nexport class FinishUpsertPrCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly aiBranchName: AiBranchName,\n        private readonly branchNaming: BranchNaming,\n        private readonly gitExec: GitExec,\n        private readonly buildAffected: BuildAffected,\n        private readonly mergeState: MergeState,\n        private readonly mergeEnd: MergeEnd,\n        private readonly prMerger: PrMerger,\n        private readonly publisher: GatedPrPublisher,\n        private readonly dashboard: Dashboard,\n        private readonly checklistDetector: ChecklistDetector,\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly gateTokenService: GateTokenService,\n        private readonly provenance: SubagentProvenanceService,\n        private readonly instructions: ChecklistInstructionsService,\n    ) {}\n\n    async run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the AI-facing workflow doc so it's present + current for any failure message to cite.\n        writeTemplate(repoRoot, 'webpieces.git-workflow.md');\n        // 1. Finish any in-progress conflict resolution: validate + commit + finalize the branch swap.\n        await this.finalizeAnyInProgressMerge(repoRoot);\n\n        // 2. REQUIRE the AI-authored review.json (throws InformAiError with the schema if missing/invalid).\n        //    Compute the consumer checklists this diff triggered FIRST so an unacknowledged BLOCK throws\n        //    here — BEFORE any `gh pr create` — matching the guarantee buildCommand already provides.\n        const defs = loadAndValidate(repoRoot).prGate.checklists;\n        const required = this.checklistDetector.toRequired(this.checklistDetector.detectForRepo(repoRoot, defs));\n        // review-<id>.json files persist locally between runs, so a re-run after a push re-validates the\n        // EXISTING verdicts against the (possibly changed) triggered set for free: an unchanged checklist\n        // needs no re-review, a newly-triggered one refuses until its file is written. That is the\n        // \"full review only when the checklist surface changes\" behavior — no special-casing here.\n        // FAIL FAST on missing reviewers, BEFORE review.json is even parsed. A missing reviewer is not a\n        // review.json defect and folding it into that error made the AI fix the wrong thing; and the message\n        // lists ONLY the subagents that still owe a verdict, so an already-reviewed checklist is never\n        // re-instructed. Same computation + same renderer as `wp-checklist`, so the two cannot disagree.\n        const featureName = this.aiBranchName.getFeatureName();\n        this.assertEveryReviewerRan(repoRoot, featureName, required);\n        const review = this.reviewJsonService.loadReviewJson(reviewJsonPath(repoRoot, featureName), required);\n\n        // 2c. For any BLOCK checklist that names a reviewer `subagent`, VERIFY (from the harness's own\n        //     artifacts) that such a subagent actually ran on this branch — the coding agent may not\n        //     self-certify. Absent CLAUDE_CODE_SESSION_ID this skips with a warning (CI / plain terminal).\n        const currentBranch = execSync('git branch --show-current', { encoding: 'utf8' }).trim();\n        const provenanceVerified = this.enforceProvenance(required, currentBranch);\n\n        // 2b. The build gate validates the WORKING TREE but we push HEAD — so they MUST be identical.\n        this.gitExec.assertCleanTree(repoRoot);\n\n        // 3. Authoritative build gate, then post the gated body, then push (that ORDER — see GatedPrPublisher).\n        this.buildAffected.runBuildGate(repoRoot, new BuildGateOptions(\n            '🛠️  Build gate (authoritative)', 'pnpm wp-finish-upsert-pr', 'Build failed — no PR created/updated.',\n        ));\n        const base = this.branchNaming.baseBranchName(execSync('git branch --show-current', { encoding: 'utf8' }).trim());\n\n        process.stdout.write('\\n' + SEP + '📋 Dashboard + PR\\n' + SEP + '\\n');\n        const title = this.prTitleFrom(review);\n        const input = this.computeDashboardInput(repoRoot, true, review, title, required);\n        // Append the hidden HMAC gate token bound to the LOCAL HEAD sha — computed BEFORE the push, because\n        // GatedPrPublisher writes the body first so CI's `synchronize` read can never see a stale token. A\n        // valid token in the PR body is proof this gated flow ran + passed on this exact commit, which CI\n        // (`wp-check-pr`) recomputes. We reach here only after the build gate + every BLOCK checklist\n        // passed, so minting is legitimate. Nothing about HMAC(salt, HEAD) needs the remote to have it.\n        const gateSalt = loadAndValidate(repoRoot).prGate.gateSalt;\n        const headSha = this.gitOut(['rev-parse', 'HEAD']);\n        const body = this.dashboard.renderDashboard(input) + this.gateTokenBody(gateSalt, headSha);\n        const result = this.upsertPr(repoRoot, base, body, title, input);\n        // Publish each reviewer's full output as ONE combined PR comment (idempotent, opt-out-aware). Never\n        // fatal — the PR is already up by now, so a comment failure only warns.\n        this.postChecklistComment(repoRoot, result.prNumber, input.checklists, provenanceVerified);\n        const prNum = result.prNumber;\n\n        process.stdout.write(\n            '\\n' + SEP + '✅ PR finished — here is exactly what I did\\n' + SEP + '\\n' +\n            `   1. validated the build gate (authoritative)\\n` +\n            `   2. ${prNum ? `wrote the gated body to PR #${prNum}` : 'composed the gated PR body'} titled: \"${title}\"\\n` +\n            `   3. force-pushed your work to origin/${base} (after the body, so CI reads the right token)\\n` +\n            `   4. ${result.merge.message}\\n` +\n            `   You are on  ${base}  — same name as the remote branch and the PR head.\\n\\n`,\n        );\n    }\n\n    // Validate + commit + finalize a 3-point merge the AI resolved, if one is in progress. Finalizing here\n    // does NOT push (pushRemote=false): this command pushes exactly ONCE, from GatedPrPublisher, and only\n    // after review.json + every BLOCK checklist + the build gate pass and the gated PR body is written.\n    private async finalizeAnyInProgressMerge(repoRoot: string): Promise<void> {\n        const home = this.mergeState.mergeDirFor(repoRoot, this.aiBranchName.getFeatureName());\n        const activeDir = this.mergeState.findActiveMergeRunDir(home);\n        const marker = activeDir ? this.mergeState.readMergeMarker(activeDir) : null;\n        if (!activeDir || !marker || marker.validated) return;\n        await this.mergeEnd.mergeEnd(\n            repoRoot, 'wp-finish-upsert-pr', activeDir,\n            new MergeContext(marker.currentBranch, marker.squashBranch, marker.backupBranch, marker.prNumber),\n            new MergeEndOptions(marker.conflictedFiles, false),\n        );\n    }\n\n    /**\n     * Refuse the PR while ANY applicable checklist still owes a verdict, naming exactly those reviewers and\n     * exactly what to tell them. Throws InformAiError so the AI gets one actionable message; passes silently\n     * when nothing is pending, and is a no-op for a repo with no checklists.\n     */\n    private assertEveryReviewerRan(repoRoot: string, featureName: string, required: readonly RequiredChecklist[]): void {\n        if (required.length === 0) return;\n        const reviewPath = reviewJsonPath(repoRoot, featureName);\n        const results = this.reviewJsonService.loadChecklistResults(reviewPath, required);\n        const pending = this.reviewJsonService.pendingChecklists(required, results);\n        if (pending.length === 0) return;\n        const context = this.reviewJsonService.reviewContextFor(repoRoot, featureName);\n        throw new InformAiError(\n            `⛔ NO PR — ${pending.length} of ${required.length} review checklist(s) that apply to this diff have ` +\n            `no passing verdict yet: ${this.instructions.names(pending)}\\n\\n` +\n            `${this.instructions.render(pending, reviewPath, context)}\\n\\n` +\n            `Then re-run: pnpm wp-finish-upsert-pr   (or check anytime with: pnpm wp-checklist)`,\n        );\n    }\n\n    private gitOut(args: string[]): string {\n        const result = spawnSync('git', args, { encoding: 'utf8' });\n        return result.status === 0 ? (result.stdout ?? '').trim() : '';\n    }\n\n    // The user-facing PR title: the AI-authored review.title, or — if omitted — a readable fallback\n    // derived from the stable feature name (NEVER the internal `Squash merge of <branch>` commit subject).\n    private prTitleFrom(review: ReviewJson): string {\n        if (review.title !== '') return review.title;\n        return this.aiBranchName.getFeatureName().replace(/[-/]+/g, ' ').trim();\n    }\n\n    // eslint-disable-next-line @typescript-eslint/max-params\n    private computeDashboardInput(repoRoot: string, buildPassed: boolean, review: ReviewJson, title: string, required: readonly RequiredChecklist[]): DashboardInput {\n        const config = loadAndValidate(repoRoot).prGate;\n        const forkPoint = this.gitOut(['merge-base', 'origin/main', 'HEAD']);\n        const featureHead = this.gitOut(['rev-parse', 'HEAD']);\n        const mainHead = this.gitOut(['rev-parse', 'origin/main']);\n        const range = `${forkPoint}..${featureHead}`;\n        const changedFiles = this.gitOut(['diff', range, '--name-only']).split('\\n').filter((f: string): boolean => f.trim() !== '');\n        const patch = this.gitOut(['diff', range]);\n\n        const gateResults = this.dashboard.computeGateResults(config.gates, changedFiles);\n        const disables = this.dashboard.countAddedDisables(patch);\n        const rows = this.checklistRows(required, review);\n        return new DashboardInput(title, gateResults, disables, buildPassed, forkPoint, featureHead, mainHead, review, rows);\n    }\n\n    // Pair each matched checklist with its resolved verdict for the dashboard. (A checklist reaching this\n    // point is always PASS/OVERRIDDEN — loadReviewJson already threw on FAIL/MISSING.)\n    private checklistRows(required: readonly RequiredChecklist[], review: ReviewJson): ChecklistRow[] {\n        return required.map((req: RequiredChecklist): ChecklistRow => {\n            const verdict = this.reviewJsonService.resolveVerdict(req, review.results);\n            return new ChecklistRow(req.id, verdict.status, verdict.detail);\n        });\n    }\n\n    // Hidden HMAC gate-token marker (with a leading blank line) to append to the PR body, or '' when the\n    // repo sets no gateSalt (byte-identical body to before this feature). Bound to the pushed HEAD sha.\n    private gateTokenBody(gateSalt: string, headSha: string): string {\n        const marker = this.gateTokenService.gateTokenMarker(gateSalt, headSha);\n        return marker === '' ? '' : `\\n\\n${marker}\\n`;\n    }\n\n    // Enforce that EACH matched checklist was reviewed by its OWN named subagent, as a DISTINCT run —\n    // the coding agent may not self-certify, and one reviewer may not stand in for several. A verified set\n    // passes silently; no session id warns but passes; any missing reviewer throws so the PR does not open.\n    private enforceProvenance(required: readonly RequiredChecklist[], branch: string): boolean {\n        const errors: string[] = [];\n        let verified = true; // no reviewers to verify ⇒ vacuously true\n        const subagents = required.map((r: RequiredChecklist): string => r.subagent.trim()).filter((s: string): boolean => s !== '');\n        if (subagents.length > 0) {\n            const result = this.provenance.verifyDistinct(subagents, branch);\n            verified = result.status === PROVENANCE_OK;\n            if (result.status === PROVENANCE_MISSING) {\n                errors.push(result.detail);\n            } else if (result.status === PROVENANCE_SKIPPED) {\n                process.stderr.write(`⚠️  ${result.detail}\\n`);\n            }\n        }\n        if (errors.length > 0) {\n            throw new InformAiError(\n                `${errors.length} checklist(s) require an independent reviewer subagent that did not run — fix, then re-run pnpm wp-finish-upsert-pr:\\n\\n` +\n                errors.map((e: string): string => `  • ${e}`).join('\\n') +\n                `\\n\\nSpawn the named reviewer subagent to review the checklist on THIS branch, then re-run.`,\n            );\n        }\n        return verified;\n    }\n\n    // Publish every reviewer's full `output` as ONE combined PR comment, idempotently (find the marker\n    // comment → PATCH it, else POST). No-op when there is no PR number or no matched checklists. Never\n    // fatal: by here the PR is already created/updated, so a `gh` failure only warns.\n    private postChecklistComment(repoRoot: string, prNumber: string, rows: readonly ChecklistRow[], provenanceVerified: boolean): void {\n        if (prNumber === '' || rows.length === 0) return;\n        if (!loadAndValidate(repoRoot).prGate.checklistComments) return;\n        const body = this.dashboard.renderChecklistComment(rows, provenanceVerified);\n        const prDir = prDirFor(repoRoot, this.aiBranchName.getFeatureName());\n        fs.mkdirSync(prDir, { recursive: true });\n        const payload = path.join(prDir, 'checklist-comment.json');\n        fs.writeFileSync(payload, JSON.stringify({ body }));\n        const commentId = this.findChecklistCommentId(prNumber);\n        const args = commentId !== ''\n            ? ['api', '--method', 'PATCH', `repos/{owner}/{repo}/issues/comments/${commentId}`, '--input', payload]\n            : ['api', '--method', 'POST', `repos/{owner}/{repo}/issues/${prNumber}/comments`, '--input', payload];\n        const res = spawnSync('gh', args, { encoding: 'utf8' });\n        if (res.status !== 0) {\n            process.stderr.write('⚠️  Could not post the checklist review comment (non-fatal — the PR is already up).\\n');\n        } else {\n            process.stdout.write(`   ${commentId !== '' ? 'updated' : 'posted'} the checklist review comment ✓\\n`);\n        }\n    }\n\n    // The id of THIS tool's existing checklist comment on the PR (by the hidden marker), or '' if none.\n    private findChecklistCommentId(prNumber: string): string {\n        const res = spawnSync('gh', [\n            'api', '--paginate', `repos/{owner}/{repo}/issues/${prNumber}/comments`,\n            '--jq', `.[] | select(.body | contains(\"${CHECKLIST_COMMENT_MARKER}\")) | .id`,\n        ], { encoding: 'utf8' });\n        if (res.status !== 0) return '';\n        return (res.stdout ?? '').trim().split('\\n')[0] ?? '';\n    }\n\n    // The PR, the remote branch, and the local branch all share the one stable feature name. Look up /\n    // create / merge against `baseBranch` (baseBranchName tolerates a leftover `…wpN` mid-transition).\n    // GatedPrPublisher owns the edit/push/create half and its ORDERING — the gated body goes up before\n    // the push, so CI's `synchronize` read cannot see the previous run's token.\n    private upsertPr(repoRoot: string, baseBranch: string, body: string, title: string, input: DashboardInput): UpsertResult {\n        const prDir = prDirFor(repoRoot, this.aiBranchName.getFeatureName());\n        fs.mkdirSync(prDir, { recursive: true });\n        const bodyFile = path.join(prDir, 'pr-body.md');\n        fs.writeFileSync(bodyFile, body + '\\n');\n\n        const published = this.publisher.publish(baseBranch, title, bodyFile);\n        if (published.createFailed) {\n            process.stderr.write('⚠️  gh pr create failed — create the PR manually with the body in:\\n  ' + bodyFile + '\\n');\n            return new UpsertResult('', new MergeOutcome(false, false,\n                '⚠️  did NOT merge — there is no PR to merge (gh pr create failed above)'));\n        }\n        const num = published.number;\n\n        // Set the squash-merge SUBJECT to the PR title (+ the `(#N)` GitHub normally appends, which an\n        // explicit --subject would otherwise drop) and the BODY to the compact commit summary, so main's\n        // history carries the PR title + risk/flags/link — NOT the internal `Squash merge of <branch>`\n        // subject GitHub would inherit from the single squash commit on the branch.\n        const ref = this.prRef(baseBranch);\n        const subject = ref.number !== '' ? `${title} (#${ref.number})` : title;\n        const mergeBodyFile = path.join(prDir, 'merge-commit-body.md');\n        fs.writeFileSync(mergeBodyFile, this.dashboard.renderCommitBody(input, ref.url) + '\\n');\n        // PrMerger owns the direct-merge / auto-merge-fallback decision AND checks every gh status, so a\n        // merge that did not happen is reported as such instead of being swallowed (see pr-merger.ts).\n        // REQUIRED config — no default here on purpose. A missing value (an older published\n        // rules-config that has no such field) reaches PrMerger as '' and is treated as \"do not merge\".\n        const mergeMode = loadAndValidate(repoRoot).prGate.mergeMode ?? '';\n        const outcome = this.prMerger.merge(baseBranch, subject, mergeBodyFile, mergeMode);\n        return new UpsertResult(ref.number !== '' ? ref.number : num, outcome);\n    }\n\n    // The PR's number + web URL (for the merge subject `(#N)` and the commit-body back-link). Both ''\n    // if it can't be resolved. Rendered via jq into one tab-separated line so no JSON parsing is needed.\n    private prRef(baseBranch: string): PrRef {\n        const result = spawnSync(\n            'gh', ['pr', 'view', baseBranch, '--json', 'number,url', '--jq', '\"\\\\(.number)\\\\t\\\\(.url)\"'],\n            { encoding: 'utf8' },\n        );\n        if (result.status !== 0) {\n            return new PrRef('', '');\n        }\n        const parts = (result.stdout ?? '').trim().split('\\t');\n        return new PrRef(parts[0] ?? '', parts[1] ?? '');\n    }\n}\n"]}

package/src/scripts/commands/start-upsert-pr-command.js

@@ -86,7 +86,7 @@ let StartUpsertPrCommand = class StartUpsertPrCommand {
      * forever at a repo that will never have one is noise, and silence reads as "a checklist passed".
      */
     checklistPointer(repoRoot) {
-        if ((0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists.isEmpty()) {
+        if ((0, rules_config_1.loadAndValidate)(repoRoot).prGate.checklists.length === 0) {
             return '📋 Review checklists: NONE CONFIGURED for this repo — nothing to run, and that is fine.\n';
         }
         return ('📋 FIRST run:  pnpm wp-checklist\n' +

package/src/scripts/commands/start-upsert-pr-command.js.map

@@ -1 +1 @@
-{"version":3,"file":"start-upsert-pr-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/start-upsert-pr-command.ts"],"names":[],"mappings":";;;;AACA,0DAA2P;AAC3P,yCAA2D;AAC3D,2EAAgE;AAChE,6DAAyD;AACzD,+DAA6E;AAC7E,mDAA+C;AAC/C,uDAAmD;AAEnD,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE,yGAAyG;AACzG,yGAAyG;AACzG,wGAAwG;AACxG,2FAA2F;AAEpF,IAAM,oBAAoB,GAA1B,MAAM,oBAAoB;IAER;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IARrB,YACqB,cAA8B,EAC9B,YAA0B,EAC1B,YAA0B,EAC1B,aAA4B,EAC5B,OAAgB,EAChB,SAAoB,EACpB,iBAAoC,EACpC,SAAoB;QAPpB,mBAAc,GAAd,cAAc,CAAgB;QAC9B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,kBAAa,GAAb,aAAa,CAAe;QAC5B,YAAO,GAAP,OAAO,CAAS;QAChB,cAAS,GAAT,SAAS,CAAW;QACpB,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,cAAS,GAAT,SAAS,CAAW;IACtC,CAAC;IAEJ,KAAK,CAAC,GAAG;QACL,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,gGAAgG;QAChG,IAAA,4BAAa,EAAC,QAAQ,EAAE,2BAA2B,CAAC,CAAC;QACrD,gGAAgG;QAChG,mGAAmG;QACnG,mGAAmG;QACnG,6CAA6C;QAC7C,IAAI,CAAC,kBAAkB,CAAC,QAAQ,CAAC,CAAC;QAElC,gGAAgG;QAChG,4FAA4F;QAC5F,iGAAiG;QACjG,IAAI,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;QAEvC,iGAAiG;QACjG,gGAAgG;QAChG,gGAAgG;QAChG,MAAM,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;QAE1C,6FAA6F;QAC7F,gGAAgG;QAChG,IAAI,CAAC,aAAa,CAAC,YAAY,CAAC,QAAQ,EAAE,IAAI,iCAAgB,CAC1D,4BAA4B,EAAE,yBAAyB,EAAE,yCAAyC,CACrG,CAAC,CAAC;QAEH,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;IACnC,CAAC;IAED;;;;;;;;OAQG;IACK,eAAe,CAAC,QAAgB;QACpC,MAAM,UAAU,GAAG,IAAA,6BAAc,EAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QAChF,4FAA4F;QAC5F,IAAA,4BAAa,EAAC,QAAQ,EAAE,gCAAgC,CAAC,CAAC;QAC1D,uGAAuG;QACvG,yDAAyD;QACzD,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC,CAAC;QAC9C,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,gCAAgC,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACjF,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,gGAAgG;YAChG,GAAG,IAAI,CAAC,YAAY,CAAC,OAAO,CAAC,IAAI;YACjC,GAAG,IAAI,CAAC,gBAAgB,CAAC,QAAQ,CAAC,IAAI;YACtC,oCAAoC;YACpC,GAAG,IAAA,mCAAoB,EAAC,UAAU,CAAC,MAAM;YACzC,0CAA0C;YAC1C,gHAAgH,CACnH,CAAC;IACN,CAAC;IAED;;;;OAIG;IACK,gBAAgB,CAAC,QAAgB;QACrC,IAAI,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC;YACxD,OAAO,2FAA2F,CAAC;QACvG,CAAC;QACD,OAAO,CACH,oCAAoC;YACpC,+FAA+F;YAC/F,gGAAgG;YAChG,8FAA8F,CACjG,CAAC;IACN,CAAC;IAED,gGAAgG;IAChG,oGAAoG;IACpG,kGAAkG;IAC1F,cAAc,CAAC,QAAgB;QACnC,MAAM,KAAK,GAAG,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;QACnD,IAAI,CAAC,KAAK,CAAC,IAAI;YAAE,OAAO,IAAI,qCAAsB,EAAE,CAAC;QACrD,MAAM,IAAI,GAAG,IAAI,kCAAmB,EAAE,CAAC;QACvC,IAAI,CAAC,MAAM,GAAG,KAAK,CAAC;QACpB,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;QACvF,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC;QAC1E,MAAM,CAAC,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAC3C,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,EAAE,IAAI,wBAAS,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CACzF,CAAC;QACF,OAAO,IAAI,qCAAsB,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IACrD,CAAC;IAED,kGAAkG;IAC1F,YAAY,CAAC,OAA+B;QAChD,IAAI,OAAO,CAAC,OAAO,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAO,EAAE,CAAC;QAC7C,OAAO,CACH,wBAAwB,OAAO,CAAC,OAAO,SAAS;YAChD,2CAA2C,OAAO,CAAC,aAAa,IAAI,CACvE,CAAC;IACN,CAAC;IAED,kGAAkG;IAClG,oGAAoG;IACpG,mGAAmG;IAC3F,kBAAkB,CAAC,QAAgB;QACvC,IAAI,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAO;QACpE,IAAA,qCAAsB,EAAC,QAAQ,EAAE,uBAAuB,CAAC,CAAC;QAC1D,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,qFAAqF;YACrF,gGAAgG;YAChG,2FAA2F,CAC9F,CAAC;IACN,CAAC;IAED,oGAAoG;IACpG,iFAAiF;IACzE,KAAK,CAAC,oBAAoB,CAAC,QAAgB;QAC/C,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,+BAA+B,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QAChF,wEAAwE;QACxE,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,iBAAiB,CAAC,QAAQ,EAAE,oBAAoB,EAAE,qBAAqB,EAAE,KAAK,CAAC,CAAC;QACrH,IAAI,OAAO,KAAK,UAAU,IAAI,OAAO,KAAK,mBAAmB,EAAE,CAAC;YAC5D,MAAM,IAAI,2BAAY,CAAC,CAAC,EACpB,iHAAiH,CACpH,CAAC;QACN,CAAC;IACL,CAAC;CACJ,CAAA;AAxIY,oDAAoB;+BAApB,oBAAoB;IADhC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QAChB,mCAAY;QACZ,4BAAY;QACX,8BAAa;QACnB,kBAAO;QACL,sBAAS;QACD,gCAAiB;QACzB,wBAAS;GAThC,oBAAoB,CAwIhC","sourcesContent":["import { execSync } from 'child_process';\nimport { loadAndValidate, reviewJsonPath, reviewJsonSchemaHint, writeTemplate, writeTemplateIfMissing, CliExitError, RepoRootFinder, ReviewJsonService, DiffScope, ChangedFilesOptions, PrContext, ChecklistReviewContext } from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { AiBranchName } from '../workflow/git-readAiBranchName';\nimport { BranchNaming } from '../workflow/branch-naming';\nimport { BuildAffected, BuildGateOptions } from '../workflow/build-affected';\nimport { GitExec } from '../workflow/git-exec';\nimport { RunUpdate } from '../workflow/run-update';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n// START of the AI-first PR flow: the deterministic setup — update from main, run the advisory build gate\n// — then hand the AI instructions to WRITE review.json and run `wp-finish-upsert-pr` (which reads it and\n// posts the PR). This command NEVER creates/updates a PR and NEVER pushes: all `gh` posting and the ONE\n// push live in finish, behind review.json + the checklists + the authoritative build gate.\n@injectable(bindingScopeValues.Singleton)\nexport class StartUpsertPrCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly aiBranchName: AiBranchName,\n        private readonly branchNaming: BranchNaming,\n        private readonly buildAffected: BuildAffected,\n        private readonly gitExec: GitExec,\n        private readonly runUpdate: RunUpdate,\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly diffScope: DiffScope,\n    ) {}\n\n    async run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the AI-facing workflow doc so it's present + current for any failure message to cite.\n        writeTemplate(repoRoot, 'webpieces.git-workflow.md');\n        // When this repo has opted into server-side enforcement (a committed gateSalt), scaffold the CI\n        // workflow into the gitignored instruct-ai dir (never .github directly — that would dirty the tree\n        // before the clean-tree check) and tell the human to copy + require it. IfMissing so it is written\n        // once and never clobbers a customized copy.\n        this.scaffoldCiWorkflow(repoRoot);\n\n        // Precondition: a fully-committed tree. This flow squash-updates the branch and builds it — the\n        // tooling must not commit your work for you, and building a dirty working tree would let an\n        // uncommitted change build green over a different commit than the one that ships. Fail if dirty.\n        this.gitExec.assertCleanTree(repoRoot);\n\n        // Nothing here pushes. This command reviews; wp-finish-upsert-pr pushes ONCE, after review.json,\n        // every BLOCK checklist, and the authoritative build gate — so no unreviewed commit reaches the\n        // remote, and there is no early `synchronize` firing against a PR body with a stale gate token.\n        await this.updateBranchFromMain(repoRoot);\n\n        // Advisory build gate — early feedback before the AI writes review.json. wp-finish-upsert-pr\n        // runs the authoritative one. Both go through the same runBuildGate (only the framing differs).\n        this.buildAffected.runBuildGate(repoRoot, new BuildGateOptions(\n            '② Build gate (nx affected)', 'pnpm wp-start-upsert-pr', 'Build failed — fix it before reviewing.',\n        ));\n\n        this.handOffToReview(repoRoot);\n    }\n\n    /**\n     * Hand the AI its next step: run `wp-checklist`, write review.json, then run finish (which posts the PR).\n     *\n     * This USED to compute the matched checklists and print every reviewer's full instructions inline — twice,\n     * in two blocks that could drift. That detail now lives in ONE command, `wp-checklist`, which wp-finish\n     * validates against; here we only point at it. Keeping this section short is the point: it is the block\n     * the AI must actually act on, and burying the three steps in forty lines of reviewer detail is how a\n     * step gets skipped.\n     */\n    private handOffToReview(repoRoot: string): void {\n        const reviewPath = reviewJsonPath(repoRoot, this.aiBranchName.getFeatureName());\n        // Persist the review-format + process instructions where any failure message can cite them.\n        writeTemplate(repoRoot, 'webpieces.review-checklists.md');\n        // Persist the PR diff context (base sha + the full changed-file set) — wp-checklist and every reviewer\n        // subagent read it, so it must exist before either runs.\n        const context = this.writePrContext(repoRoot);\n        process.stdout.write('\\n' + SEP + '③ Review the PR, then finish\\n' + SEP + '\\n');\n        process.stdout.write(\n            `Branch is updated and the build gate passed (nothing pushed yet — finish does the one push).\\n` +\n            `${this.contextLines(context)}\\n` +\n            `${this.checklistPointer(repoRoot)}\\n` +\n            `Then review your own changes and\\n` +\n            `${reviewJsonSchemaHint(reviewPath)}\\n\\n` +\n            `Finally run:  pnpm wp-finish-upsert-pr\\n` +\n            `(It re-validates the build, re-checks every checklist, renders the dashboard, and creates/updates the PR.)\\n\\n`,\n        );\n    }\n\n    /**\n     * Step 1 of the review: find out what review this diff owes. A repo with checklists gets pointed at\n     * `wp-checklist`; a repo with none is told plainly that it has none, because printing \"run wp-checklist\"\n     * forever at a repo that will never have one is noise, and silence reads as \"a checklist passed\".\n     */\n    private checklistPointer(repoRoot: string): string {\n        if (loadAndValidate(repoRoot).prGate.checklists.isEmpty()) {\n            return '📋 Review checklists: NONE CONFIGURED for this repo — nothing to run, and that is fine.\\n';\n        }\n        return (\n            '📋 FIRST run:  pnpm wp-checklist\\n' +\n            '   It validates this repo\\'s checklist patterns against your diff and prints WHICH reviewer\\n' +\n            '   subagents you must spawn, plus the exact review-<id>.json each must write. Do that BEFORE\\n' +\n            '   finishing — wp-finish-upsert-pr refuses to open the PR until every one of them has run.\\n'\n        );\n    }\n\n    // Write pr-context.json (base/head sha + the full changed-file set, tsOnly:false) so a reviewer\n    // subagent knows the exact base the gate uses and can `git diff <base> HEAD -- <file>` for content.\n    // Returns what every printed instruction needs to inline; an empty context when no base resolves.\n    private writePrContext(repoRoot: string): ChecklistReviewContext {\n        const range = this.diffScope.resolveBase(repoRoot);\n        if (!range.base) return new ChecklistReviewContext();\n        const opts = new ChangedFilesOptions();\n        opts.tsOnly = false;\n        const changed = this.diffScope.getChangedFiles(repoRoot, range.base, range.head, opts);\n        const head = range.head && range.head.trim() !== '' ? range.head : 'HEAD';\n        const p = this.reviewJsonService.writePrContext(\n            repoRoot, this.aiBranchName.getFeatureName(), new PrContext(range.base, head, changed),\n        );\n        return new ChecklistReviewContext(range.base, p);\n    }\n\n    // The diff facts, stated where the instruction to use them is — not in a separate block above it.\n    private contextLines(context: ChecklistReviewContext): string {\n        if (context.baseSha.trim() === '') return '';\n        return (\n            `Your diff:  git diff ${context.baseSha} HEAD\\n` +\n            `Full changed-file set + base/head sha:  ${context.prContextPath}\\n`\n        );\n    }\n\n    // Scaffold the server-side CI check when (and only when) this repo set a gateSalt. Written to the\n    // gitignored instruct-ai dir so it never dirties the tree; the human copies it to .github/workflows\n    // and marks it required (webpieces can't set branch protection). No-op for repos with no gateSalt.\n    private scaffoldCiWorkflow(repoRoot: string): void {\n        if (loadAndValidate(repoRoot).prGate.gateSalt.trim() === '') return;\n        writeTemplateIfMissing(repoRoot, 'webpieces-pr-gate.yml');\n        process.stdout.write(\n            `\\nℹ️  Server-side gate enforcement is ON (gateSalt set). If you have not already:\\n` +\n            `   • copy  .webpieces/instruct-ai/webpieces-pr-gate.yml  → .github/workflows/  and commit it\\n` +\n            `   • mark the \"webpieces-pr-gate\" check REQUIRED in branch protection (repo admin only)\\n`,\n        );\n    }\n\n    // Bring the branch up to date with main via the shared 3-point engine (in-process). On conflict the\n    // merge process doc it writes names `wp-finish-upsert-pr` as the finish command.\n    private async updateBranchFromMain(repoRoot: string): Promise<void> {\n        process.stdout.write('\\n' + SEP + '① Updating branch from main\\n' + SEP + '\\n');\n        // pushRemote=false — finish owns the single push (see MergeEndOptions).\n        const outcome = await this.runUpdate.runUpdateFromMain(repoRoot, 'wp-start-upsert-pr', 'wp-finish-upsert-pr', false);\n        if (outcome === 'conflict' || outcome === 'unvalidatedResume') {\n            throw new CliExitError(2,\n                '\\n⏸️  Conflicts — resolve them, then run pnpm wp-finish-upsert-pr (it validates the merge AND finishes the PR).',\n            );\n        }\n    }\n}\n"]}
+{"version":3,"file":"start-upsert-pr-command.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/commands/start-upsert-pr-command.ts"],"names":[],"mappings":";;;;AACA,0DAA2P;AAC3P,yCAA2D;AAC3D,2EAAgE;AAChE,6DAAyD;AACzD,+DAA6E;AAC7E,mDAA+C;AAC/C,uDAAmD;AAEnD,MAAM,GAAG,GAAG,0DAA0D,CAAC;AAEvE,yGAAyG;AACzG,yGAAyG;AACzG,wGAAwG;AACxG,2FAA2F;AAEpF,IAAM,oBAAoB,GAA1B,MAAM,oBAAoB;IAER;IACA;IACA;IACA;IACA;IACA;IACA;IACA;IARrB,YACqB,cAA8B,EAC9B,YAA0B,EAC1B,YAA0B,EAC1B,aAA4B,EAC5B,OAAgB,EAChB,SAAoB,EACpB,iBAAoC,EACpC,SAAoB;QAPpB,mBAAc,GAAd,cAAc,CAAgB;QAC9B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,iBAAY,GAAZ,YAAY,CAAc;QAC1B,kBAAa,GAAb,aAAa,CAAe;QAC5B,YAAO,GAAP,OAAO,CAAS;QAChB,cAAS,GAAT,SAAS,CAAW;QACpB,sBAAiB,GAAjB,iBAAiB,CAAmB;QACpC,cAAS,GAAT,SAAS,CAAW;IACtC,CAAC;IAEJ,KAAK,CAAC,GAAG;QACL,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QACpE,gGAAgG;QAChG,IAAA,4BAAa,EAAC,QAAQ,EAAE,2BAA2B,CAAC,CAAC;QACrD,gGAAgG;QAChG,mGAAmG;QACnG,mGAAmG;QACnG,6CAA6C;QAC7C,IAAI,CAAC,kBAAkB,CAAC,QAAQ,CAAC,CAAC;QAElC,gGAAgG;QAChG,4FAA4F;QAC5F,iGAAiG;QACjG,IAAI,CAAC,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;QAEvC,iGAAiG;QACjG,gGAAgG;QAChG,gGAAgG;QAChG,MAAM,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;QAE1C,6FAA6F;QAC7F,gGAAgG;QAChG,IAAI,CAAC,aAAa,CAAC,YAAY,CAAC,QAAQ,EAAE,IAAI,iCAAgB,CAC1D,4BAA4B,EAAE,yBAAyB,EAAE,yCAAyC,CACrG,CAAC,CAAC;QAEH,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;IACnC,CAAC;IAED;;;;;;;;OAQG;IACK,eAAe,CAAC,QAAgB;QACpC,MAAM,UAAU,GAAG,IAAA,6BAAc,EAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,CAAC,CAAC;QAChF,4FAA4F;QAC5F,IAAA,4BAAa,EAAC,QAAQ,EAAE,gCAAgC,CAAC,CAAC;QAC1D,uGAAuG;QACvG,yDAAyD;QACzD,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC,CAAC;QAC9C,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,gCAAgC,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QACjF,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,gGAAgG;YAChG,GAAG,IAAI,CAAC,YAAY,CAAC,OAAO,CAAC,IAAI;YACjC,GAAG,IAAI,CAAC,gBAAgB,CAAC,QAAQ,CAAC,IAAI;YACtC,oCAAoC;YACpC,GAAG,IAAA,mCAAoB,EAAC,UAAU,CAAC,MAAM;YACzC,0CAA0C;YAC1C,gHAAgH,CACnH,CAAC;IACN,CAAC;IAED;;;;OAIG;IACK,gBAAgB,CAAC,QAAgB;QACrC,IAAI,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC3D,OAAO,2FAA2F,CAAC;QACvG,CAAC;QACD,OAAO,CACH,oCAAoC;YACpC,+FAA+F;YAC/F,gGAAgG;YAChG,8FAA8F,CACjG,CAAC;IACN,CAAC;IAED,gGAAgG;IAChG,oGAAoG;IACpG,kGAAkG;IAC1F,cAAc,CAAC,QAAgB;QACnC,MAAM,KAAK,GAAG,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;QACnD,IAAI,CAAC,KAAK,CAAC,IAAI;YAAE,OAAO,IAAI,qCAAsB,EAAE,CAAC;QACrD,MAAM,IAAI,GAAG,IAAI,kCAAmB,EAAE,CAAC;QACvC,IAAI,CAAC,MAAM,GAAG,KAAK,CAAC;QACpB,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,eAAe,CAAC,QAAQ,EAAE,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;QACvF,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,CAAC,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC;QAC1E,MAAM,CAAC,GAAG,IAAI,CAAC,iBAAiB,CAAC,cAAc,CAC3C,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,cAAc,EAAE,EAAE,IAAI,wBAAS,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CACzF,CAAC;QACF,OAAO,IAAI,qCAAsB,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IACrD,CAAC;IAED,kGAAkG;IAC1F,YAAY,CAAC,OAA+B;QAChD,IAAI,OAAO,CAAC,OAAO,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAO,EAAE,CAAC;QAC7C,OAAO,CACH,wBAAwB,OAAO,CAAC,OAAO,SAAS;YAChD,2CAA2C,OAAO,CAAC,aAAa,IAAI,CACvE,CAAC;IACN,CAAC;IAED,kGAAkG;IAClG,oGAAoG;IACpG,mGAAmG;IAC3F,kBAAkB,CAAC,QAAgB;QACvC,IAAI,IAAA,8BAAe,EAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,KAAK,EAAE;YAAE,OAAO;QACpE,IAAA,qCAAsB,EAAC,QAAQ,EAAE,uBAAuB,CAAC,CAAC;QAC1D,OAAO,CAAC,MAAM,CAAC,KAAK,CAChB,qFAAqF;YACrF,gGAAgG;YAChG,2FAA2F,CAC9F,CAAC;IACN,CAAC;IAED,oGAAoG;IACpG,iFAAiF;IACzE,KAAK,CAAC,oBAAoB,CAAC,QAAgB;QAC/C,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,GAAG,GAAG,GAAG,+BAA+B,GAAG,GAAG,GAAG,IAAI,CAAC,CAAC;QAChF,wEAAwE;QACxE,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,iBAAiB,CAAC,QAAQ,EAAE,oBAAoB,EAAE,qBAAqB,EAAE,KAAK,CAAC,CAAC;QACrH,IAAI,OAAO,KAAK,UAAU,IAAI,OAAO,KAAK,mBAAmB,EAAE,CAAC;YAC5D,MAAM,IAAI,2BAAY,CAAC,CAAC,EACpB,iHAAiH,CACpH,CAAC;QACN,CAAC;IACL,CAAC;CACJ,CAAA;AAxIY,oDAAoB;+BAApB,oBAAoB;IADhC,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;6CAGA,6BAAc;QAChB,mCAAY;QACZ,4BAAY;QACX,8BAAa;QACnB,kBAAO;QACL,sBAAS;QACD,gCAAiB;QACzB,wBAAS;GAThC,oBAAoB,CAwIhC","sourcesContent":["import { execSync } from 'child_process';\nimport { loadAndValidate, reviewJsonPath, reviewJsonSchemaHint, writeTemplate, writeTemplateIfMissing, CliExitError, RepoRootFinder, ReviewJsonService, DiffScope, ChangedFilesOptions, PrContext, ChecklistReviewContext } from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\nimport { AiBranchName } from '../workflow/git-readAiBranchName';\nimport { BranchNaming } from '../workflow/branch-naming';\nimport { BuildAffected, BuildGateOptions } from '../workflow/build-affected';\nimport { GitExec } from '../workflow/git-exec';\nimport { RunUpdate } from '../workflow/run-update';\n\nconst SEP = '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\\n';\n\n// START of the AI-first PR flow: the deterministic setup — update from main, run the advisory build gate\n// — then hand the AI instructions to WRITE review.json and run `wp-finish-upsert-pr` (which reads it and\n// posts the PR). This command NEVER creates/updates a PR and NEVER pushes: all `gh` posting and the ONE\n// push live in finish, behind review.json + the checklists + the authoritative build gate.\n@injectable(bindingScopeValues.Singleton)\nexport class StartUpsertPrCommand {\n    constructor(\n        private readonly repoRootFinder: RepoRootFinder,\n        private readonly aiBranchName: AiBranchName,\n        private readonly branchNaming: BranchNaming,\n        private readonly buildAffected: BuildAffected,\n        private readonly gitExec: GitExec,\n        private readonly runUpdate: RunUpdate,\n        private readonly reviewJsonService: ReviewJsonService,\n        private readonly diffScope: DiffScope,\n    ) {}\n\n    async run(): Promise<void> {\n        const repoRoot = this.repoRootFinder.resolveRepoRoot(process.cwd());\n        // Refresh the AI-facing workflow doc so it's present + current for any failure message to cite.\n        writeTemplate(repoRoot, 'webpieces.git-workflow.md');\n        // When this repo has opted into server-side enforcement (a committed gateSalt), scaffold the CI\n        // workflow into the gitignored instruct-ai dir (never .github directly — that would dirty the tree\n        // before the clean-tree check) and tell the human to copy + require it. IfMissing so it is written\n        // once and never clobbers a customized copy.\n        this.scaffoldCiWorkflow(repoRoot);\n\n        // Precondition: a fully-committed tree. This flow squash-updates the branch and builds it — the\n        // tooling must not commit your work for you, and building a dirty working tree would let an\n        // uncommitted change build green over a different commit than the one that ships. Fail if dirty.\n        this.gitExec.assertCleanTree(repoRoot);\n\n        // Nothing here pushes. This command reviews; wp-finish-upsert-pr pushes ONCE, after review.json,\n        // every BLOCK checklist, and the authoritative build gate — so no unreviewed commit reaches the\n        // remote, and there is no early `synchronize` firing against a PR body with a stale gate token.\n        await this.updateBranchFromMain(repoRoot);\n\n        // Advisory build gate — early feedback before the AI writes review.json. wp-finish-upsert-pr\n        // runs the authoritative one. Both go through the same runBuildGate (only the framing differs).\n        this.buildAffected.runBuildGate(repoRoot, new BuildGateOptions(\n            '② Build gate (nx affected)', 'pnpm wp-start-upsert-pr', 'Build failed — fix it before reviewing.',\n        ));\n\n        this.handOffToReview(repoRoot);\n    }\n\n    /**\n     * Hand the AI its next step: run `wp-checklist`, write review.json, then run finish (which posts the PR).\n     *\n     * This USED to compute the matched checklists and print every reviewer's full instructions inline — twice,\n     * in two blocks that could drift. That detail now lives in ONE command, `wp-checklist`, which wp-finish\n     * validates against; here we only point at it. Keeping this section short is the point: it is the block\n     * the AI must actually act on, and burying the three steps in forty lines of reviewer detail is how a\n     * step gets skipped.\n     */\n    private handOffToReview(repoRoot: string): void {\n        const reviewPath = reviewJsonPath(repoRoot, this.aiBranchName.getFeatureName());\n        // Persist the review-format + process instructions where any failure message can cite them.\n        writeTemplate(repoRoot, 'webpieces.review-checklists.md');\n        // Persist the PR diff context (base sha + the full changed-file set) — wp-checklist and every reviewer\n        // subagent read it, so it must exist before either runs.\n        const context = this.writePrContext(repoRoot);\n        process.stdout.write('\\n' + SEP + '③ Review the PR, then finish\\n' + SEP + '\\n');\n        process.stdout.write(\n            `Branch is updated and the build gate passed (nothing pushed yet — finish does the one push).\\n` +\n            `${this.contextLines(context)}\\n` +\n            `${this.checklistPointer(repoRoot)}\\n` +\n            `Then review your own changes and\\n` +\n            `${reviewJsonSchemaHint(reviewPath)}\\n\\n` +\n            `Finally run:  pnpm wp-finish-upsert-pr\\n` +\n            `(It re-validates the build, re-checks every checklist, renders the dashboard, and creates/updates the PR.)\\n\\n`,\n        );\n    }\n\n    /**\n     * Step 1 of the review: find out what review this diff owes. A repo with checklists gets pointed at\n     * `wp-checklist`; a repo with none is told plainly that it has none, because printing \"run wp-checklist\"\n     * forever at a repo that will never have one is noise, and silence reads as \"a checklist passed\".\n     */\n    private checklistPointer(repoRoot: string): string {\n        if (loadAndValidate(repoRoot).prGate.checklists.length === 0) {\n            return '📋 Review checklists: NONE CONFIGURED for this repo — nothing to run, and that is fine.\\n';\n        }\n        return (\n            '📋 FIRST run:  pnpm wp-checklist\\n' +\n            '   It validates this repo\\'s checklist patterns against your diff and prints WHICH reviewer\\n' +\n            '   subagents you must spawn, plus the exact review-<id>.json each must write. Do that BEFORE\\n' +\n            '   finishing — wp-finish-upsert-pr refuses to open the PR until every one of them has run.\\n'\n        );\n    }\n\n    // Write pr-context.json (base/head sha + the full changed-file set, tsOnly:false) so a reviewer\n    // subagent knows the exact base the gate uses and can `git diff <base> HEAD -- <file>` for content.\n    // Returns what every printed instruction needs to inline; an empty context when no base resolves.\n    private writePrContext(repoRoot: string): ChecklistReviewContext {\n        const range = this.diffScope.resolveBase(repoRoot);\n        if (!range.base) return new ChecklistReviewContext();\n        const opts = new ChangedFilesOptions();\n        opts.tsOnly = false;\n        const changed = this.diffScope.getChangedFiles(repoRoot, range.base, range.head, opts);\n        const head = range.head && range.head.trim() !== '' ? range.head : 'HEAD';\n        const p = this.reviewJsonService.writePrContext(\n            repoRoot, this.aiBranchName.getFeatureName(), new PrContext(range.base, head, changed),\n        );\n        return new ChecklistReviewContext(range.base, p);\n    }\n\n    // The diff facts, stated where the instruction to use them is — not in a separate block above it.\n    private contextLines(context: ChecklistReviewContext): string {\n        if (context.baseSha.trim() === '') return '';\n        return (\n            `Your diff:  git diff ${context.baseSha} HEAD\\n` +\n            `Full changed-file set + base/head sha:  ${context.prContextPath}\\n`\n        );\n    }\n\n    // Scaffold the server-side CI check when (and only when) this repo set a gateSalt. Written to the\n    // gitignored instruct-ai dir so it never dirties the tree; the human copies it to .github/workflows\n    // and marks it required (webpieces can't set branch protection). No-op for repos with no gateSalt.\n    private scaffoldCiWorkflow(repoRoot: string): void {\n        if (loadAndValidate(repoRoot).prGate.gateSalt.trim() === '') return;\n        writeTemplateIfMissing(repoRoot, 'webpieces-pr-gate.yml');\n        process.stdout.write(\n            `\\nℹ️  Server-side gate enforcement is ON (gateSalt set). If you have not already:\\n` +\n            `   • copy  .webpieces/instruct-ai/webpieces-pr-gate.yml  → .github/workflows/  and commit it\\n` +\n            `   • mark the \"webpieces-pr-gate\" check REQUIRED in branch protection (repo admin only)\\n`,\n        );\n    }\n\n    // Bring the branch up to date with main via the shared 3-point engine (in-process). On conflict the\n    // merge process doc it writes names `wp-finish-upsert-pr` as the finish command.\n    private async updateBranchFromMain(repoRoot: string): Promise<void> {\n        process.stdout.write('\\n' + SEP + '① Updating branch from main\\n' + SEP + '\\n');\n        // pushRemote=false — finish owns the single push (see MergeEndOptions).\n        const outcome = await this.runUpdate.runUpdateFromMain(repoRoot, 'wp-start-upsert-pr', 'wp-finish-upsert-pr', false);\n        if (outcome === 'conflict' || outcome === 'unvalidatedResume') {\n            throw new CliExitError(2,\n                '\\n⏸️  Conflicts — resolve them, then run pnpm wp-finish-upsert-pr (it validates the merge AND finishes the PR).',\n            );\n        }\n    }\n}\n"]}

package/src/scripts/workflow/checklist-notice.d.ts

@@ -1,4 +1,3 @@
-import { ChecklistSource } from '@webpieces/rules-config';
 /**
  * Builds the message `wp-start-upsert-pr` prints when a diff matched ZERO review checklists.
  *
@@ -6,30 +5,28 @@ import { ChecklistSource } from '@webpieces/rules-config';
  * because the previous behavior was to print nothing at all, which is indistinguishable from "the
  * checklist ran and passed". Silence is the bug; refusing would be a worse one.
  *
- * The three empty cases need different fixes, so they get different text:
+ * The two empty cases need different fixes, so they get different text:
  *   - NONE CONFIGURED  — the repo configured no checklists at all. Perfectly fine; mention that a human
  *                        MAY add checklist *.md docs if they want reviews, and move on.
- *   - MISCONFIGURED    — checklists IS configured but broken. This one is worth shouting about:
- *                        the tolerant loader returns [] for it, so a broken doc silently enforces
- *                        NOTHING while looking configured.
- *   - NONE MATCHED     — checklists exist and are valid, but none of their patterns hit this diff.
- *                        Also fine; report the count so a human can judge whether that is expected.
+ *   - NONE MATCHED     — checklists exist, but none of their patterns hit this diff. Also fine; report the
+ *                        count so a human can judge whether that is expected.
+ *
+ * There is deliberately NO "misconfigured" case. Checklists live only in `pr-gate.checklists`, which
+ * loadAndValidate validates — including that every doc and reviewer agent file exists — so a broken set
+ * throws before any command reaches this class. The old tolerant manifest loader that returned [] for a
+ * malformed doc (and thus enforced NOTHING while looking configured) is gone, and with it that failure mode.
  *
  * Pure string building, no I/O, so it is unit-testable without git or a repo.
  * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.
  */
 export declare class ChecklistNotice {
     /**
-     * @param source          `prGate.checklists` — where this repo's checklists come from (empty = none)
-     * @param manifestErrors  `ChecklistManifestService.validate()` output ([] when valid or unconfigured)
-     * @param definedCount    how many checklists that source defines
-     * @param finishCommand   the command to continue with, named in every branch
+     * @param definedCount   how many checklists `pr-gate.checklists` defines (0 = the repo configured none)
+     * @param finishCommand  the command to continue with, named in every branch
      */
-    build(source: ChecklistSource, manifestErrors: readonly string[], definedCount: number, finishCommand: string): string;
+    build(definedCount: number, finishCommand: string): string;
     private reason;
     private continueLine;
     private noneConfigured;
-    private emptyManifest;
-    private misconfigured;
     private noneMatched;
 }

package/src/scripts/workflow/checklist-notice.js

@@ -10,37 +10,32 @@ const inversify_1 = require("inversify");
  * because the previous behavior was to print nothing at all, which is indistinguishable from "the
  * checklist ran and passed". Silence is the bug; refusing would be a worse one.
  *
- * The three empty cases need different fixes, so they get different text:
+ * The two empty cases need different fixes, so they get different text:
  *   - NONE CONFIGURED  — the repo configured no checklists at all. Perfectly fine; mention that a human
  *                        MAY add checklist *.md docs if they want reviews, and move on.
- *   - MISCONFIGURED    — checklists IS configured but broken. This one is worth shouting about:
- *                        the tolerant loader returns [] for it, so a broken doc silently enforces
- *                        NOTHING while looking configured.
- *   - NONE MATCHED     — checklists exist and are valid, but none of their patterns hit this diff.
- *                        Also fine; report the count so a human can judge whether that is expected.
+ *   - NONE MATCHED     — checklists exist, but none of their patterns hit this diff. Also fine; report the
+ *                        count so a human can judge whether that is expected.
+ *
+ * There is deliberately NO "misconfigured" case. Checklists live only in `pr-gate.checklists`, which
+ * loadAndValidate validates — including that every doc and reviewer agent file exists — so a broken set
+ * throws before any command reaches this class. The old tolerant manifest loader that returned [] for a
+ * malformed doc (and thus enforced NOTHING while looking configured) is gone, and with it that failure mode.
  *
  * Pure string building, no I/O, so it is unit-testable without git or a repo.
  * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.
  */
 let ChecklistNotice = class ChecklistNotice {
     /**
-     * @param source          `prGate.checklists` — where this repo's checklists come from (empty = none)
-     * @param manifestErrors  `ChecklistManifestService.validate()` output ([] when valid or unconfigured)
-     * @param definedCount    how many checklists that source defines
-     * @param finishCommand   the command to continue with, named in every branch
+     * @param definedCount   how many checklists `pr-gate.checklists` defines (0 = the repo configured none)
+     * @param finishCommand  the command to continue with, named in every branch
      */
-    // eslint-disable-next-line @typescript-eslint/max-params
-    build(source, manifestErrors, definedCount, finishCommand) {
-        return `${this.reason(source, manifestErrors, definedCount)}\n${this.continueLine(finishCommand)}`;
+    build(definedCount, finishCommand) {
+        return `${this.reason(definedCount)}\n${this.continueLine(finishCommand)}`;
     }
-    reason(source, manifestErrors, definedCount) {
-        if (manifestErrors.length > 0)
-            return this.misconfigured(source.describe(), manifestErrors);
-        if (source.isEmpty())
-            return this.noneConfigured();
+    reason(definedCount) {
         if (definedCount === 0)
-            return this.emptyManifest(source.describe());
-        return this.noneMatched(source.describe(), definedCount);
+            return this.noneConfigured();
+        return this.noneMatched(definedCount);
     }
     // Every branch ends here: 0 checklists is OK, keep going. Stated plainly so neither the AI nor the
     // human reads the notice as a gate that needs satisfying before finishing.
@@ -61,20 +56,8 @@ let ChecklistNotice = class ChecklistNotice {
             '   `doc` is REPO-relative, `patterns` are path globs, and each entry needs its OWN reviewer\n' +
             '   subagent (a .claude/agents/<subagent>.md) — that is how independent review is enforced.');
     }
-    emptyManifest(sourceLabel) {
-        return (`📋 Review checklists: 0 defined — ${sourceLabel} is readable but lists no usable\n` +
-            '   checklists (every entry needs a non-empty "subagent"). Fine to proceed; worth a look if\n' +
-            '   you expected some to run.');
-    }
-    // The one case that deserves volume: it LOOKS configured but enforces nothing.
-    misconfigured(sourceLabel, manifestErrors) {
-        return (`⚠️  Review checklists: 0 ran because ${sourceLabel} is MISCONFIGURED — so this PR is getting NO\n` +
-            '   checklist review even though this repo asked for one. Not fatal, but almost certainly not\n' +
-            '   what you want:\n\n' +
-            manifestErrors.map((e) => `     • ${e}`).join('\n'));
-    }
-    noneMatched(sourceLabel, definedCount) {
-        return (`📋 Review checklists: ${definedCount} defined in ${sourceLabel}, 0 matched this diff — none of their\n` +
+    noneMatched(definedCount) {
+        return (`📋 Review checklists: ${definedCount} defined in pr-gate.checklists, 0 matched this diff — none of their\n` +
             '   path patterns hit a changed file. Expected for changes outside those areas; if you thought\n' +
             '   one should have run, check its "patterns" against the changed-file list above.');
     }

package/src/scripts/workflow/checklist-notice.js.map

@@ -1 +1 @@
-{"version":3,"file":"checklist-notice.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/checklist-notice.ts"],"names":[],"mappings":";;;;AACA,yCAA2D;AAE3D;;;;;;;;;;;;;;;;;;GAkBG;AAEI,IAAM,eAAe,GAArB,MAAM,eAAe;IACxB;;;;;OAKG;IACH,yDAAyD;IACzD,KAAK,CAAC,MAAuB,EAAE,cAAiC,EAAE,YAAoB,EAAE,aAAqB;QACzG,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM,EAAE,cAAc,EAAE,YAAY,CAAC,KAAK,IAAI,CAAC,YAAY,CAAC,aAAa,CAAC,EAAE,CAAC;IACvG,CAAC;IAEO,MAAM,CAAC,MAAuB,EAAE,cAAiC,EAAE,YAAoB;QAC3F,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,IAAI,CAAC,aAAa,CAAC,MAAM,CAAC,QAAQ,EAAE,EAAE,cAAc,CAAC,CAAC;QAC5F,IAAI,MAAM,CAAC,OAAO,EAAE;YAAE,OAAO,IAAI,CAAC,cAAc,EAAE,CAAC;QACnD,IAAI,YAAY,KAAK,CAAC;YAAE,OAAO,IAAI,CAAC,aAAa,CAAC,MAAM,CAAC,QAAQ,EAAE,CAAC,CAAC;QACrE,OAAO,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,QAAQ,EAAE,EAAE,YAAY,CAAC,CAAC;IAC7D,CAAC;IAED,mGAAmG;IACnG,2EAA2E;IACnE,YAAY,CAAC,aAAqB;QACtC,OAAO,CACH,4FAA4F;YAC5F,6EAA6E,aAAa,IAAI,CACjG,CAAC;IACN,CAAC;IAEO,cAAc;QAClB,OAAO,CACH,4FAA4F;YAC5F,IAAI;YACJ,8FAA8F;YAC9F,6EAA6E;YAC7E,mDAAmD;YACnD,iDAAiD;YACjD,sDAAsD;YACtD,2DAA2D;YAC3D,cAAc;YACd,+FAA+F;YAC/F,4FAA4F,CAC/F,CAAC;IACN,CAAC;IAEO,aAAa,CAAC,WAAmB;QACrC,OAAO,CACH,qCAAqC,WAAW,oCAAoC;YACpF,8FAA8F;YAC9F,8BAA8B,CACjC,CAAC;IACN,CAAC;IAED,+EAA+E;IACvE,aAAa,CAAC,WAAmB,EAAE,cAAiC;QACxE,OAAO,CACH,wCAAwC,WAAW,gDAAgD;YACnG,gGAAgG;YAChG,uBAAuB;YACvB,cAAc,CAAC,GAAG,CAAC,CAAC,CAAS,EAAU,EAAE,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CACtE,CAAC;IACN,CAAC;IAEO,WAAW,CAAC,WAAmB,EAAE,YAAoB;QACzD,OAAO,CACH,yBAAyB,YAAY,eAAe,WAAW,yCAAyC;YACxG,iGAAiG;YACjG,mFAAmF,CACtF,CAAC;IACN,CAAC;CACJ,CAAA;AArEY,0CAAe;0BAAf,eAAe;IAD3B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;GAC5B,eAAe,CAqE3B","sourcesContent":["import { ChecklistSource } from '@webpieces/rules-config';\nimport { injectable, bindingScopeValues } from 'inversify';\n\n/**\n * Builds the message `wp-start-upsert-pr` prints when a diff matched ZERO review checklists.\n *\n * ZERO IS A VALID, SUPPORTED STATE — it is NOT an error and NEVER blocks the flow. This exists only\n * because the previous behavior was to print nothing at all, which is indistinguishable from \"the\n * checklist ran and passed\". Silence is the bug; refusing would be a worse one.\n *\n * The three empty cases need different fixes, so they get different text:\n *   - NONE CONFIGURED  — the repo configured no checklists at all. Perfectly fine; mention that a human\n *                        MAY add checklist *.md docs if they want reviews, and move on.\n *   - MISCONFIGURED    — checklists IS configured but broken. This one is worth shouting about:\n *                        the tolerant loader returns [] for it, so a broken doc silently enforces\n *                        NOTHING while looking configured.\n *   - NONE MATCHED     — checklists exist and are valid, but none of their patterns hit this diff.\n *                        Also fine; report the count so a human can judge whether that is expected.\n *\n * Pure string building, no I/O, so it is unit-testable without git or a repo.\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ChecklistNotice {\n    /**\n     * @param source          `prGate.checklists` — where this repo's checklists come from (empty = none)\n     * @param manifestErrors  `ChecklistManifestService.validate()` output ([] when valid or unconfigured)\n     * @param definedCount    how many checklists that source defines\n     * @param finishCommand   the command to continue with, named in every branch\n     */\n    // eslint-disable-next-line @typescript-eslint/max-params\n    build(source: ChecklistSource, manifestErrors: readonly string[], definedCount: number, finishCommand: string): string {\n        return `${this.reason(source, manifestErrors, definedCount)}\\n${this.continueLine(finishCommand)}`;\n    }\n\n    private reason(source: ChecklistSource, manifestErrors: readonly string[], definedCount: number): string {\n        if (manifestErrors.length > 0) return this.misconfigured(source.describe(), manifestErrors);\n        if (source.isEmpty()) return this.noneConfigured();\n        if (definedCount === 0) return this.emptyManifest(source.describe());\n        return this.noneMatched(source.describe(), definedCount);\n    }\n\n    // Every branch ends here: 0 checklists is OK, keep going. Stated plainly so neither the AI nor the\n    // human reads the notice as a gate that needs satisfying before finishing.\n    private continueLine(finishCommand: string): string {\n        return (\n            `\\n✅ Zero checklists is a perfectly valid state — this is INFORMATION, not a blocker, and\\n` +\n            `   nothing here needs fixing before you continue. Carry on and run:  pnpm ${finishCommand}\\n`\n        );\n    }\n\n    private noneConfigured(): string {\n        return (\n            '📋 Review checklists: NONE CONFIGURED (0 ran) — that is fine, this repo simply has none.\\n' +\n            '\\n' +\n            '   FYI for the human: if you ever want per-area reviews enforced on PRs that touch certain\\n' +\n            '   paths, add checklist *.md docs and list them in webpieces.config.json:\\n' +\n            '     \"commands\": { \"pr-gate\": { \"checklists\": [\\n' +\n            '       { \"subagent\": \"db-migration-reviewer\",\\n' +\n            '         \"doc\": \".claude/review/db-migrations.md\",\\n' +\n            '         \"patterns\": [\"**/migrations/**\", \"**/*.sql\"] }\\n' +\n            '     ] } }\\n' +\n            '   `doc` is REPO-relative, `patterns` are path globs, and each entry needs its OWN reviewer\\n' +\n            '   subagent (a .claude/agents/<subagent>.md) — that is how independent review is enforced.'\n        );\n    }\n\n    private emptyManifest(sourceLabel: string): string {\n        return (\n            `📋 Review checklists: 0 defined — ${sourceLabel} is readable but lists no usable\\n` +\n            '   checklists (every entry needs a non-empty \"subagent\"). Fine to proceed; worth a look if\\n' +\n            '   you expected some to run.'\n        );\n    }\n\n    // The one case that deserves volume: it LOOKS configured but enforces nothing.\n    private misconfigured(sourceLabel: string, manifestErrors: readonly string[]): string {\n        return (\n            `⚠️  Review checklists: 0 ran because ${sourceLabel} is MISCONFIGURED — so this PR is getting NO\\n` +\n            '   checklist review even though this repo asked for one. Not fatal, but almost certainly not\\n' +\n            '   what you want:\\n\\n' +\n            manifestErrors.map((e: string): string => `     • ${e}`).join('\\n')\n        );\n    }\n\n    private noneMatched(sourceLabel: string, definedCount: number): string {\n        return (\n            `📋 Review checklists: ${definedCount} defined in ${sourceLabel}, 0 matched this diff — none of their\\n` +\n            '   path patterns hit a changed file. Expected for changes outside those areas; if you thought\\n' +\n            '   one should have run, check its \"patterns\" against the changed-file list above.'\n        );\n    }\n}\n"]}
+{"version":3,"file":"checklist-notice.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/pr-gate/src/scripts/workflow/checklist-notice.ts"],"names":[],"mappings":";;;;AAAA,yCAA2D;AAE3D;;;;;;;;;;;;;;;;;;;;GAoBG;AAEI,IAAM,eAAe,GAArB,MAAM,eAAe;IACxB;;;OAGG;IACH,KAAK,CAAC,YAAoB,EAAE,aAAqB;QAC7C,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC,YAAY,CAAC,KAAK,IAAI,CAAC,YAAY,CAAC,aAAa,CAAC,EAAE,CAAC;IAC/E,CAAC;IAEO,MAAM,CAAC,YAAoB;QAC/B,IAAI,YAAY,KAAK,CAAC;YAAE,OAAO,IAAI,CAAC,cAAc,EAAE,CAAC;QACrD,OAAO,IAAI,CAAC,WAAW,CAAC,YAAY,CAAC,CAAC;IAC1C,CAAC;IAED,mGAAmG;IACnG,2EAA2E;IACnE,YAAY,CAAC,aAAqB;QACtC,OAAO,CACH,4FAA4F;YAC5F,6EAA6E,aAAa,IAAI,CACjG,CAAC;IACN,CAAC;IAEO,cAAc;QAClB,OAAO,CACH,4FAA4F;YAC5F,IAAI;YACJ,8FAA8F;YAC9F,6EAA6E;YAC7E,mDAAmD;YACnD,iDAAiD;YACjD,sDAAsD;YACtD,2DAA2D;YAC3D,cAAc;YACd,+FAA+F;YAC/F,4FAA4F,CAC/F,CAAC;IACN,CAAC;IAEO,WAAW,CAAC,YAAoB;QACpC,OAAO,CACH,yBAAyB,YAAY,uEAAuE;YAC5G,iGAAiG;YACjG,mFAAmF,CACtF,CAAC;IACN,CAAC;CACJ,CAAA;AA9CY,0CAAe;0BAAf,eAAe;IAD3B,IAAA,sBAAU,EAAC,8BAAkB,CAAC,SAAS,CAAC;GAC5B,eAAe,CA8C3B","sourcesContent":["import { injectable, bindingScopeValues } from 'inversify';\n\n/**\n * Builds the message `wp-start-upsert-pr` prints when a diff matched ZERO review checklists.\n *\n * ZERO IS A VALID, SUPPORTED STATE — it is NOT an error and NEVER blocks the flow. This exists only\n * because the previous behavior was to print nothing at all, which is indistinguishable from \"the\n * checklist ran and passed\". Silence is the bug; refusing would be a worse one.\n *\n * The two empty cases need different fixes, so they get different text:\n *   - NONE CONFIGURED  — the repo configured no checklists at all. Perfectly fine; mention that a human\n *                        MAY add checklist *.md docs if they want reviews, and move on.\n *   - NONE MATCHED     — checklists exist, but none of their patterns hit this diff. Also fine; report the\n *                        count so a human can judge whether that is expected.\n *\n * There is deliberately NO \"misconfigured\" case. Checklists live only in `pr-gate.checklists`, which\n * loadAndValidate validates — including that every doc and reviewer agent file exists — so a broken set\n * throws before any command reaches this class. The old tolerant manifest loader that returned [] for a\n * malformed doc (and thus enforced NOTHING while looking configured) is gone, and with it that failure mode.\n *\n * Pure string building, no I/O, so it is unit-testable without git or a repo.\n * `@injectable(bindingScopeValues.Singleton)` so it is injected by type and drawn in the DI design.\n */\n@injectable(bindingScopeValues.Singleton)\nexport class ChecklistNotice {\n    /**\n     * @param definedCount   how many checklists `pr-gate.checklists` defines (0 = the repo configured none)\n     * @param finishCommand  the command to continue with, named in every branch\n     */\n    build(definedCount: number, finishCommand: string): string {\n        return `${this.reason(definedCount)}\\n${this.continueLine(finishCommand)}`;\n    }\n\n    private reason(definedCount: number): string {\n        if (definedCount === 0) return this.noneConfigured();\n        return this.noneMatched(definedCount);\n    }\n\n    // Every branch ends here: 0 checklists is OK, keep going. Stated plainly so neither the AI nor the\n    // human reads the notice as a gate that needs satisfying before finishing.\n    private continueLine(finishCommand: string): string {\n        return (\n            `\\n✅ Zero checklists is a perfectly valid state — this is INFORMATION, not a blocker, and\\n` +\n            `   nothing here needs fixing before you continue. Carry on and run:  pnpm ${finishCommand}\\n`\n        );\n    }\n\n    private noneConfigured(): string {\n        return (\n            '📋 Review checklists: NONE CONFIGURED (0 ran) — that is fine, this repo simply has none.\\n' +\n            '\\n' +\n            '   FYI for the human: if you ever want per-area reviews enforced on PRs that touch certain\\n' +\n            '   paths, add checklist *.md docs and list them in webpieces.config.json:\\n' +\n            '     \"commands\": { \"pr-gate\": { \"checklists\": [\\n' +\n            '       { \"subagent\": \"db-migration-reviewer\",\\n' +\n            '         \"doc\": \".claude/review/db-migrations.md\",\\n' +\n            '         \"patterns\": [\"**/migrations/**\", \"**/*.sql\"] }\\n' +\n            '     ] } }\\n' +\n            '   `doc` is REPO-relative, `patterns` are path globs, and each entry needs its OWN reviewer\\n' +\n            '   subagent (a .claude/agents/<subagent>.md) — that is how independent review is enforced.'\n        );\n    }\n\n    private noneMatched(definedCount: number): string {\n        return (\n            `📋 Review checklists: ${definedCount} defined in pr-gate.checklists, 0 matched this diff — none of their\\n` +\n            '   path patterns hit a changed file. Expected for changes outside those areas; if you thought\\n' +\n            '   one should have run, check its \"patterns\" against the changed-file list above.'\n        );\n    }\n}\n"]}