@webpieces/nx-webpieces-rules 0.3.129 → 0.3.130

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webpieces/nx-webpieces-rules",
-  "version": "0.3.129",
+  "version": "0.3.130",
   "description": "Nx-specific webpieces validation rules and graph tooling. Bundles all @webpieces rule packages with Nx graph validators and an inference plugin.",
   "type": "commonjs",
   "main": "./src/index.js",
@@ -18,10 +18,10 @@
     "README.md"
   ],
   "dependencies": {
-    "@webpieces/ai-hook-rules": "0.3.129",
-    "@webpieces/code-rules": "0.3.129",
-    "@webpieces/eslint-rules": "0.3.129",
-    "@webpieces/rules-config": "0.3.129"
+    "@webpieces/ai-hook-rules": "0.3.130",
+    "@webpieces/code-rules": "0.3.130",
+    "@webpieces/eslint-rules": "0.3.130",
+    "@webpieces/rules-config": "0.3.130"
   },
   "peerDependencies": {
     "@nx/devkit": ">=18.0.0"

package/src/executors/generate/executor.js

@@ -19,12 +19,12 @@ async function runExecutor(options, context) {
     console.log('\n📊 Architecture Graph Generator\n');
     // eslint-disable-next-line @webpieces/no-unmanaged-exceptions
     try {
-        // Step 1: Generate current graph from project.json files
-        console.log('📊 Generating dependency graph from project.json files...');
-        const rawGraph = await (0, graph_generator_1.generateGraph)();
+        // Step 1: Build the full graph from nx, then transitively reduce it to the view
+        console.log("📊 Generating dependency graph from nx's project graph...");
+        const reducedGraph = await (0, graph_generator_1.generateReducedGraph)();
         // Step 2: Topological sort (to assign levels for visualization)
         console.log('🔄 Computing topological layers...');
-        const enhancedGraph = (0, graph_sorter_1.sortGraphTopologically)(rawGraph);
+        const enhancedGraph = (0, graph_sorter_1.sortGraphTopologically)(reducedGraph);
         // Step 3: Save the graph
         console.log('💾 Saving graph to architecture/dependencies.json...');
         (0, graph_loader_1.saveGraph)(enhancedGraph, workspaceRoot, graphPath);

package/src/executors/generate/executor.js.map

@@ -1 +1 @@
-{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/nx-webpieces-rules/src/executors/generate/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;GAOG;;AAgBH,8BAqCC;AAlDD,+DAA0D;AAC1D,yDAAgE;AAChE,yDAAmD;AACnD,2CAAwC;AAUzB,KAAK,UAAU,WAAW,CACrC,OAAgC,EAChC,OAAwB;IAExB,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC;IACpC,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IAEnC,OAAO,CAAC,GAAG,CAAC,qCAAqC,CAAC,CAAC;IAEnD,8DAA8D;IAC9D,IAAI,CAAC;QACD,yDAAyD;QACzD,OAAO,CAAC,GAAG,CAAC,2DAA2D,CAAC,CAAC;QACzE,MAAM,QAAQ,GAAG,MAAM,IAAA,+BAAa,GAAE,CAAC;QAEvC,gEAAgE;QAChE,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;QAClD,MAAM,aAAa,GAAG,IAAA,qCAAsB,EAAC,QAAQ,CAAC,CAAC;QAEvD,yBAAyB;QACzB,OAAO,CAAC,GAAG,CAAC,sDAAsD,CAAC,CAAC;QACpE,IAAA,wBAAS,EAAC,aAAa,EAAE,aAAa,EAAE,SAAS,CAAC,CAAC;QACnD,OAAO,CAAC,GAAG,CAAC,4BAA4B,CAAC,CAAC;QAE1C,gBAAgB;QAChB,MAAM,YAAY,GAAG,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,MAAM,CAAC;QACvD,MAAM,MAAM,GAAG,IAAI,GAAG,CAAC,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QACzE,OAAO,CAAC,GAAG,CAAC,qBAAqB,CAAC,CAAC;QACnC,OAAO,CAAC,GAAG,CAAC,gBAAgB,YAAY,EAAE,CAAC,CAAC;QAC5C,OAAO,CAAC,GAAG,CAAC,cAAc,MAAM,CAAC,IAAI,OAAO,IAAI,CAAC,GAAG,CAAC,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC;QAEpE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;IAC7B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,IAAA,iBAAO,EAAC,GAAG,CAAC,CAAC;QAC3B,OAAO,CAAC,KAAK,CAAC,4BAA4B,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAC3D,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Generate Executor\n *\n * Generates the architecture dependency graph and saves it to architecture/dependencies.json.\n *\n * Usage:\n * nx run architecture:generate\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { generateGraph } from '../../lib/graph-generator';\nimport { sortGraphTopologically } from '../../lib/graph-sorter';\nimport { saveGraph } from '../../lib/graph-loader';\nimport { toError } from '../../toError';\n\nexport interface GenerateExecutorOptions {\n    graphPath?: string;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\nexport default async function runExecutor(\n    options: GenerateExecutorOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const graphPath = options.graphPath;\n    const workspaceRoot = context.root;\n\n    console.log('\\n📊 Architecture Graph Generator\\n');\n\n    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n    try {\n        // Step 1: Generate current graph from project.json files\n        console.log('📊 Generating dependency graph from project.json files...');\n        const rawGraph = await generateGraph();\n\n        // Step 2: Topological sort (to assign levels for visualization)\n        console.log('🔄 Computing topological layers...');\n        const enhancedGraph = sortGraphTopologically(rawGraph);\n\n        // Step 3: Save the graph\n        console.log('💾 Saving graph to architecture/dependencies.json...');\n        saveGraph(enhancedGraph, workspaceRoot, graphPath);\n        console.log('✅ Graph saved successfully');\n\n        // Print summary\n        const projectCount = Object.keys(enhancedGraph).length;\n        const levels = new Set(Object.values(enhancedGraph).map((e) => e.level));\n        console.log(`\\n📈 Graph Summary:`);\n        console.log(`   Projects: ${projectCount}`);\n        console.log(`   Levels: ${levels.size} (0-${Math.max(...levels)})`);\n\n        return { success: true };\n    } catch (err: unknown) {\n        const error = toError(err);\n        console.error('❌ Graph generation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/nx-webpieces-rules/src/executors/generate/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;GAOG;;AAgBH,8BAqCC;AAlDD,+DAAiE;AACjE,yDAAgE;AAChE,yDAAmD;AACnD,2CAAwC;AAUzB,KAAK,UAAU,WAAW,CACrC,OAAgC,EAChC,OAAwB;IAExB,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC;IACpC,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IAEnC,OAAO,CAAC,GAAG,CAAC,qCAAqC,CAAC,CAAC;IAEnD,8DAA8D;IAC9D,IAAI,CAAC;QACD,gFAAgF;QAChF,OAAO,CAAC,GAAG,CAAC,2DAA2D,CAAC,CAAC;QACzE,MAAM,YAAY,GAAG,MAAM,IAAA,sCAAoB,GAAE,CAAC;QAElD,gEAAgE;QAChE,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;QAClD,MAAM,aAAa,GAAG,IAAA,qCAAsB,EAAC,YAAY,CAAC,CAAC;QAE3D,yBAAyB;QACzB,OAAO,CAAC,GAAG,CAAC,sDAAsD,CAAC,CAAC;QACpE,IAAA,wBAAS,EAAC,aAAa,EAAE,aAAa,EAAE,SAAS,CAAC,CAAC;QACnD,OAAO,CAAC,GAAG,CAAC,4BAA4B,CAAC,CAAC;QAE1C,gBAAgB;QAChB,MAAM,YAAY,GAAG,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,MAAM,CAAC;QACvD,MAAM,MAAM,GAAG,IAAI,GAAG,CAAC,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QACzE,OAAO,CAAC,GAAG,CAAC,qBAAqB,CAAC,CAAC;QACnC,OAAO,CAAC,GAAG,CAAC,gBAAgB,YAAY,EAAE,CAAC,CAAC;QAC5C,OAAO,CAAC,GAAG,CAAC,cAAc,MAAM,CAAC,IAAI,OAAO,IAAI,CAAC,GAAG,CAAC,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC;QAEpE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;IAC7B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,IAAA,iBAAO,EAAC,GAAG,CAAC,CAAC;QAC3B,OAAO,CAAC,KAAK,CAAC,4BAA4B,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAC3D,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Generate Executor\n *\n * Generates the architecture dependency graph and saves it to architecture/dependencies.json.\n *\n * Usage:\n * nx run architecture:generate\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { generateReducedGraph } from '../../lib/graph-generator';\nimport { sortGraphTopologically } from '../../lib/graph-sorter';\nimport { saveGraph } from '../../lib/graph-loader';\nimport { toError } from '../../toError';\n\nexport interface GenerateExecutorOptions {\n    graphPath?: string;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\nexport default async function runExecutor(\n    options: GenerateExecutorOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const graphPath = options.graphPath;\n    const workspaceRoot = context.root;\n\n    console.log('\\n📊 Architecture Graph Generator\\n');\n\n    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n    try {\n        // Step 1: Build the full graph from nx, then transitively reduce it to the view\n        console.log(\"📊 Generating dependency graph from nx's project graph...\");\n        const reducedGraph = await generateReducedGraph();\n\n        // Step 2: Topological sort (to assign levels for visualization)\n        console.log('🔄 Computing topological layers...');\n        const enhancedGraph = sortGraphTopologically(reducedGraph);\n\n        // Step 3: Save the graph\n        console.log('💾 Saving graph to architecture/dependencies.json...');\n        saveGraph(enhancedGraph, workspaceRoot, graphPath);\n        console.log('✅ Graph saved successfully');\n\n        // Print summary\n        const projectCount = Object.keys(enhancedGraph).length;\n        const levels = new Set(Object.values(enhancedGraph).map((e) => e.level));\n        console.log(`\\n📈 Graph Summary:`);\n        console.log(`   Projects: ${projectCount}`);\n        console.log(`   Levels: ${levels.size} (0-${Math.max(...levels)})`);\n\n        return { success: true };\n    } catch (err: unknown) {\n        const error = toError(err);\n        console.error('❌ Graph generation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}

package/src/executors/validate-architecture-unchanged/executor.js

@@ -42,12 +42,12 @@ async function runExecutor(options, context) {
             console.error('  4. Commit architecture/dependencies.json');
             return { success: false };
         }
-        // Step 1: Generate current graph from project.json files
+        // Step 1: Build the full graph from nx, then transitively reduce it
         console.log('📊 Generating current dependency graph...');
-        const rawGraph = await (0, graph_generator_1.generateGraph)();
+        const reducedGraph = await (0, graph_generator_1.generateReducedGraph)();
         // Step 2: Topological sort (to get enhanced graph with levels)
         console.log('🔄 Computing topological layers...');
-        const currentGraph = (0, graph_sorter_1.sortGraphTopologically)(rawGraph);
+        const currentGraph = (0, graph_sorter_1.sortGraphTopologically)(reducedGraph);
         // Step 3: Load saved graph
         console.log('📂 Loading saved graph...');
         const savedGraph = (0, graph_loader_1.loadBlessedGraph)(workspaceRoot, graphPath);

package/src/executors/validate-architecture-unchanged/executor.js.map

@@ -1 +1 @@
-{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/nx-webpieces-rules/src/executors/validate-architecture-unchanged/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;GAQG;;AA8BH,8BAoEC;AA/FD,0DAAwD;AACxD,+DAA0D;AAC1D,yDAAgE;AAChE,iEAA2D;AAC3D,yDAA2E;AAC3E,2CAAwC;AAUxC,MAAM,WAAW,GAAG,2BAA2B,CAAC;AAEhD;;;GAGG;AACH,SAAS,wBAAwB,CAAC,aAAqB;IACnD,MAAM,MAAM,GAAG,IAAA,4BAAa,EAAC,aAAa,EAAE,WAAW,CAAC,CAAC;IAEzD,OAAO,MAAM,CAAC;AAClB,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,OAA6C,EAC7C,OAAwB;IAExB,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC;IACpC,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IAEnC,OAAO,CAAC,GAAG,CAAC,0CAA0C,CAAC,CAAC;IAExD,8DAA8D;IAC9D,IAAI,CAAC;QACD,8BAA8B;QAC9B,IAAI,CAAC,IAAA,8BAAe,EAAC,aAAa,EAAE,SAAS,CAAC,EAAE,CAAC;YAC7C,OAAO,CAAC,KAAK,CAAC,0DAA0D,CAAC,CAAC;YAC1E,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAClB,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;YAChC,OAAO,CAAC,KAAK,CAAC,wCAAwC,CAAC,CAAC;YACxD,OAAO,CAAC,KAAK,CAAC,yCAAyC,CAAC,CAAC;YACzD,OAAO,CAAC,KAAK,CAAC,qFAAqF,CAAC,CAAC;YACrG,OAAO,CAAC,KAAK,CAAC,4CAA4C,CAAC,CAAC;YAC5D,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;QAC9B,CAAC;QAED,yDAAyD;QACzD,OAAO,CAAC,GAAG,CAAC,2CAA2C,CAAC,CAAC;QACzD,MAAM,QAAQ,GAAG,MAAM,IAAA,+BAAa,GAAE,CAAC;QAEvC,+DAA+D;QAC/D,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;QAClD,MAAM,YAAY,GAAG,IAAA,qCAAsB,EAAC,QAAQ,CAAC,CAAC;QAEtD,2BAA2B;QAC3B,OAAO,CAAC,GAAG,CAAC,2BAA2B,CAAC,CAAC;QACzC,MAAM,UAAU,GAAG,IAAA,+BAAgB,EAAC,aAAa,EAAE,SAAS,CAAC,CAAC;QAE9D,IAAI,CAAC,UAAU,EAAE,CAAC;YACd,OAAO,CAAC,KAAK,CAAC,8BAA8B,CAAC,CAAC;YAC9C,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;QAC9B,CAAC;QAED,yBAAyB;QACzB,OAAO,CAAC,GAAG,CAAC,8CAA8C,CAAC,CAAC;QAC5D,MAAM,UAAU,GAAG,IAAA,gCAAa,EAAC,YAAY,EAAE,UAAU,CAAC,CAAC;QAE3D,IAAI,UAAU,CAAC,SAAS,EAAE,CAAC;YACvB,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;YAC5E,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;aAAM,CAAC;YACJ,uCAAuC;YACvC,MAAM,MAAM,GAAG,wBAAwB,CAAC,aAAa,CAAC,CAAC;YAEvD,OAAO,CAAC,KAAK,CAAC,+CAA+C,CAAC,CAAC;YAC/D,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;YAChC,OAAO,CAAC,KAAK,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;YAClC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAClB,OAAO,CAAC,KAAK,CAAC,mBAAmB,GAAG,MAAM,GAAG,wCAAwC,CAAC,CAAC;YACvF,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAClB,OAAO,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;YACzB,OAAO,CAAC,KAAK,CAAC,+BAA+B,CAAC,CAAC;YAC/C,OAAO,CAAC,KAAK,CAAC,oGAAoG,CAAC,CAAC;YACpH,OAAO,CAAC,KAAK,CAAC,wDAAwD,CAAC,CAAC;YACxE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;QAC9B,CAAC;IACL,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,IAAA,iBAAO,EAAC,GAAG,CAAC,CAAC;QAC3B,OAAO,CAAC,KAAK,CAAC,mCAAmC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAClE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate Architecture Unchanged Executor\n *\n * Validates that the current architecture graph matches the saved blessed graph.\n * This ensures no unapproved architecture changes have been made.\n *\n * Usage:\n * nx run architecture:validate-architecture-unchanged\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { writeTemplate } from '@webpieces/rules-config';\nimport { generateGraph } from '../../lib/graph-generator';\nimport { sortGraphTopologically } from '../../lib/graph-sorter';\nimport { compareGraphs } from '../../lib/graph-comparator';\nimport { loadBlessedGraph, graphFileExists } from '../../lib/graph-loader';\nimport { toError } from '../../toError';\n\nexport interface ValidateArchitectureUnchangedOptions {\n    graphPath?: string;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\nconst TMP_MD_FILE = 'webpieces.dependencies.md';\n\n/**\n * Write the instructions documentation to .webpieces/instruct-ai/.\n * Sourced from @webpieces/rules-config.\n */\nfunction writeTmpInstructionsFile(workspaceRoot: string): string {\n    const mdPath = writeTemplate(workspaceRoot, TMP_MD_FILE);\n\n    return mdPath;\n}\n\nexport default async function runExecutor(\n    options: ValidateArchitectureUnchangedOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const graphPath = options.graphPath;\n    const workspaceRoot = context.root;\n\n    console.log('\\n🔍 Validating Architecture Unchanged\\n');\n\n    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n    try {\n        // Check if saved graph exists\n        if (!graphFileExists(workspaceRoot, graphPath)) {\n            console.error('❌ No saved graph found at architecture/dependencies.json');\n            console.error('');\n            console.error('To initialize:');\n            console.error('  1. Run: nx run architecture:generate');\n            console.error('  2. Run: nx run architecture:visualize');\n            console.error('  3. Manually inspect the generated graph to confirm it is the desired architecture');\n            console.error('  4. Commit architecture/dependencies.json');\n            return { success: false };\n        }\n\n        // Step 1: Generate current graph from project.json files\n        console.log('📊 Generating current dependency graph...');\n        const rawGraph = await generateGraph();\n\n        // Step 2: Topological sort (to get enhanced graph with levels)\n        console.log('🔄 Computing topological layers...');\n        const currentGraph = sortGraphTopologically(rawGraph);\n\n        // Step 3: Load saved graph\n        console.log('📂 Loading saved graph...');\n        const savedGraph = loadBlessedGraph(workspaceRoot, graphPath);\n\n        if (!savedGraph) {\n            console.error('❌ Could not load saved graph');\n            return { success: false };\n        }\n\n        // Step 4: Compare graphs\n        console.log('🔍 Comparing current graph to saved graph...');\n        const comparison = compareGraphs(currentGraph, savedGraph);\n\n        if (comparison.identical) {\n            console.log('✅ Architecture unchanged - current graph matches saved graph');\n            return { success: true };\n        } else {\n            // Write instructions file for AI agent\n            const mdPath = writeTmpInstructionsFile(workspaceRoot);\n\n            console.error('❌ Architecture has changed since last update!');\n            console.error('\\nDifferences:');\n            console.error(comparison.summary);\n            console.error('');\n            console.error('⚠️  *** Refer to ' + mdPath + ' for instructions on how to fix *** ⚠️');\n            console.error('');\n            console.error('To fix:');\n            console.error('  1. Review the changes above');\n            console.error('  2. If intentional, ASK USER to run: nx run architecture:generate since this is a critical change');\n            console.error('  3. Commit the updated architecture/dependencies.json');\n            return { success: false };\n        }\n    } catch (err: unknown) {\n        const error = toError(err);\n        console.error('❌ Architecture validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/nx-webpieces-rules/src/executors/validate-architecture-unchanged/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;GAQG;;AA8BH,8BAoEC;AA/FD,0DAAwD;AACxD,+DAAiE;AACjE,yDAAgE;AAChE,iEAA2D;AAC3D,yDAA2E;AAC3E,2CAAwC;AAUxC,MAAM,WAAW,GAAG,2BAA2B,CAAC;AAEhD;;;GAGG;AACH,SAAS,wBAAwB,CAAC,aAAqB;IACnD,MAAM,MAAM,GAAG,IAAA,4BAAa,EAAC,aAAa,EAAE,WAAW,CAAC,CAAC;IAEzD,OAAO,MAAM,CAAC;AAClB,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,OAA6C,EAC7C,OAAwB;IAExB,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC;IACpC,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IAEnC,OAAO,CAAC,GAAG,CAAC,0CAA0C,CAAC,CAAC;IAExD,8DAA8D;IAC9D,IAAI,CAAC;QACD,8BAA8B;QAC9B,IAAI,CAAC,IAAA,8BAAe,EAAC,aAAa,EAAE,SAAS,CAAC,EAAE,CAAC;YAC7C,OAAO,CAAC,KAAK,CAAC,0DAA0D,CAAC,CAAC;YAC1E,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAClB,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;YAChC,OAAO,CAAC,KAAK,CAAC,wCAAwC,CAAC,CAAC;YACxD,OAAO,CAAC,KAAK,CAAC,yCAAyC,CAAC,CAAC;YACzD,OAAO,CAAC,KAAK,CAAC,qFAAqF,CAAC,CAAC;YACrG,OAAO,CAAC,KAAK,CAAC,4CAA4C,CAAC,CAAC;YAC5D,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;QAC9B,CAAC;QAED,oEAAoE;QACpE,OAAO,CAAC,GAAG,CAAC,2CAA2C,CAAC,CAAC;QACzD,MAAM,YAAY,GAAG,MAAM,IAAA,sCAAoB,GAAE,CAAC;QAElD,+DAA+D;QAC/D,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;QAClD,MAAM,YAAY,GAAG,IAAA,qCAAsB,EAAC,YAAY,CAAC,CAAC;QAE1D,2BAA2B;QAC3B,OAAO,CAAC,GAAG,CAAC,2BAA2B,CAAC,CAAC;QACzC,MAAM,UAAU,GAAG,IAAA,+BAAgB,EAAC,aAAa,EAAE,SAAS,CAAC,CAAC;QAE9D,IAAI,CAAC,UAAU,EAAE,CAAC;YACd,OAAO,CAAC,KAAK,CAAC,8BAA8B,CAAC,CAAC;YAC9C,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;QAC9B,CAAC;QAED,yBAAyB;QACzB,OAAO,CAAC,GAAG,CAAC,8CAA8C,CAAC,CAAC;QAC5D,MAAM,UAAU,GAAG,IAAA,gCAAa,EAAC,YAAY,EAAE,UAAU,CAAC,CAAC;QAE3D,IAAI,UAAU,CAAC,SAAS,EAAE,CAAC;YACvB,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;YAC5E,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;aAAM,CAAC;YACJ,uCAAuC;YACvC,MAAM,MAAM,GAAG,wBAAwB,CAAC,aAAa,CAAC,CAAC;YAEvD,OAAO,CAAC,KAAK,CAAC,+CAA+C,CAAC,CAAC;YAC/D,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;YAChC,OAAO,CAAC,KAAK,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;YAClC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAClB,OAAO,CAAC,KAAK,CAAC,mBAAmB,GAAG,MAAM,GAAG,wCAAwC,CAAC,CAAC;YACvF,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;YAClB,OAAO,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;YACzB,OAAO,CAAC,KAAK,CAAC,+BAA+B,CAAC,CAAC;YAC/C,OAAO,CAAC,KAAK,CAAC,oGAAoG,CAAC,CAAC;YACpH,OAAO,CAAC,KAAK,CAAC,wDAAwD,CAAC,CAAC;YACxE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;QAC9B,CAAC;IACL,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,IAAA,iBAAO,EAAC,GAAG,CAAC,CAAC;QAC3B,OAAO,CAAC,KAAK,CAAC,mCAAmC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAClE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate Architecture Unchanged Executor\n *\n * Validates that the current architecture graph matches the saved blessed graph.\n * This ensures no unapproved architecture changes have been made.\n *\n * Usage:\n * nx run architecture:validate-architecture-unchanged\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { writeTemplate } from '@webpieces/rules-config';\nimport { generateReducedGraph } from '../../lib/graph-generator';\nimport { sortGraphTopologically } from '../../lib/graph-sorter';\nimport { compareGraphs } from '../../lib/graph-comparator';\nimport { loadBlessedGraph, graphFileExists } from '../../lib/graph-loader';\nimport { toError } from '../../toError';\n\nexport interface ValidateArchitectureUnchangedOptions {\n    graphPath?: string;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\nconst TMP_MD_FILE = 'webpieces.dependencies.md';\n\n/**\n * Write the instructions documentation to .webpieces/instruct-ai/.\n * Sourced from @webpieces/rules-config.\n */\nfunction writeTmpInstructionsFile(workspaceRoot: string): string {\n    const mdPath = writeTemplate(workspaceRoot, TMP_MD_FILE);\n\n    return mdPath;\n}\n\nexport default async function runExecutor(\n    options: ValidateArchitectureUnchangedOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const graphPath = options.graphPath;\n    const workspaceRoot = context.root;\n\n    console.log('\\n🔍 Validating Architecture Unchanged\\n');\n\n    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n    try {\n        // Check if saved graph exists\n        if (!graphFileExists(workspaceRoot, graphPath)) {\n            console.error('❌ No saved graph found at architecture/dependencies.json');\n            console.error('');\n            console.error('To initialize:');\n            console.error('  1. Run: nx run architecture:generate');\n            console.error('  2. Run: nx run architecture:visualize');\n            console.error('  3. Manually inspect the generated graph to confirm it is the desired architecture');\n            console.error('  4. Commit architecture/dependencies.json');\n            return { success: false };\n        }\n\n        // Step 1: Build the full graph from nx, then transitively reduce it\n        console.log('📊 Generating current dependency graph...');\n        const reducedGraph = await generateReducedGraph();\n\n        // Step 2: Topological sort (to get enhanced graph with levels)\n        console.log('🔄 Computing topological layers...');\n        const currentGraph = sortGraphTopologically(reducedGraph);\n\n        // Step 3: Load saved graph\n        console.log('📂 Loading saved graph...');\n        const savedGraph = loadBlessedGraph(workspaceRoot, graphPath);\n\n        if (!savedGraph) {\n            console.error('❌ Could not load saved graph');\n            return { success: false };\n        }\n\n        // Step 4: Compare graphs\n        console.log('🔍 Comparing current graph to saved graph...');\n        const comparison = compareGraphs(currentGraph, savedGraph);\n\n        if (comparison.identical) {\n            console.log('✅ Architecture unchanged - current graph matches saved graph');\n            return { success: true };\n        } else {\n            // Write instructions file for AI agent\n            const mdPath = writeTmpInstructionsFile(workspaceRoot);\n\n            console.error('❌ Architecture has changed since last update!');\n            console.error('\\nDifferences:');\n            console.error(comparison.summary);\n            console.error('');\n            console.error('⚠️  *** Refer to ' + mdPath + ' for instructions on how to fix *** ⚠️');\n            console.error('');\n            console.error('To fix:');\n            console.error('  1. Review the changes above');\n            console.error('  2. If intentional, ASK USER to run: nx run architecture:generate since this is a critical change');\n            console.error('  3. Commit the updated architecture/dependencies.json');\n            return { success: false };\n        }\n    } catch (err: unknown) {\n        const error = toError(err);\n        console.error('❌ Architecture validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}

package/src/executors/validate-no-skiplevel-deps/executor.d.ts

@@ -1,11 +1,17 @@
 /**
- * Validate No Skip-Level Dependencies Executor
+ * Validate No Skip-Level Dependencies Executor — RETIRED (no-op).
  *
- * Validates that no project has redundant transitive dependencies.
- * If project A depends on B, and B transitively brings in C, then A should NOT
- * also directly depend on C (it's redundant and clutters the dependency graph).
+ * Skip-level (redundant transitive) edges used to be an error here. That is no longer
+ * meaningful: `architecture:generate` now derives the graph from nx's project graph and
+ * applies transitive reduction, so the committed architecture/dependencies.json can never
+ * contain a redundant edge. The check is superseded by auto-reduction.
  *
- * This keeps the architecture graph clean for visualization and human understanding.
+ * Worse, its old remediation told users to remove "redundant" deps from package.json —
+ * which is exactly the runtime-validity trap (a transitively-reachable package.json entry
+ * can still be a real runtime dependency, e.g. a peerDependency or generated client).
+ *
+ * Defaults off (workspace.validations.noSkipLevelDeps=false). Kept as a no-op for one
+ * release so any explicit enablement does not error on now-expected skip-level edges.
  *
  * Usage:
  * nx run architecture:validate-no-skiplevel-deps
@@ -16,4 +22,4 @@ export interface ValidateNoSkipLevelDepsOptions {
 export interface ExecutorResult {
     success: boolean;
 }
-export default function runExecutor(_options: ValidateNoSkipLevelDepsOptions, context: ExecutorContext): Promise<ExecutorResult>;
+export default function runExecutor(_options: ValidateNoSkipLevelDepsOptions, _context: ExecutorContext): Promise<ExecutorResult>;

package/src/executors/validate-no-skiplevel-deps/executor.js

@@ -1,125 +1,28 @@
 "use strict";
 /**
- * Validate No Skip-Level Dependencies Executor
+ * Validate No Skip-Level Dependencies Executor — RETIRED (no-op).
  *
- * Validates that no project has redundant transitive dependencies.
- * If project A depends on B, and B transitively brings in C, then A should NOT
- * also directly depend on C (it's redundant and clutters the dependency graph).
+ * Skip-level (redundant transitive) edges used to be an error here. That is no longer
+ * meaningful: `architecture:generate` now derives the graph from nx's project graph and
+ * applies transitive reduction, so the committed architecture/dependencies.json can never
+ * contain a redundant edge. The check is superseded by auto-reduction.
  *
- * This keeps the architecture graph clean for visualization and human understanding.
+ * Worse, its old remediation told users to remove "redundant" deps from package.json —
+ * which is exactly the runtime-validity trap (a transitively-reachable package.json entry
+ * can still be a real runtime dependency, e.g. a peerDependency or generated client).
+ *
+ * Defaults off (workspace.validations.noSkipLevelDeps=false). Kept as a no-op for one
+ * release so any explicit enablement does not error on now-expected skip-level edges.
  *
  * Usage:
  * nx run architecture:validate-no-skiplevel-deps
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = runExecutor;
-const graph_generator_1 = require("../../lib/graph-generator");
-const rules_config_1 = require("@webpieces/rules-config");
-const toError_1 = require("../../toError");
-/**
- * Compute all transitive dependencies for a project
- */
-function computeTransitiveDeps(project, graph, visited = new Set()) {
-    const result = new Set();
-    if (visited.has(project)) {
-        return result;
-    }
-    visited.add(project);
-    const directDeps = graph[project] || [];
-    for (const dep of directDeps) {
-        result.add(dep);
-        // Recursively get transitive deps
-        const transitive = computeTransitiveDeps(dep, graph, visited);
-        for (const t of transitive) {
-            result.add(t);
-        }
-    }
-    return result;
-}
-/**
- * Find redundant dependencies for a project
- */
-function findRedundantDeps(project, graph) {
-    const redundant = [];
-    const directDeps = graph[project] || [];
-    // For each direct dependency, compute what it transitively brings in
-    const transitiveByDep = new Map();
-    for (const dep of directDeps) {
-        transitiveByDep.set(dep, computeTransitiveDeps(dep, graph));
-    }
-    // Check if any direct dependency is already brought in by another
-    const transitiveEntries = Array.from(transitiveByDep.entries());
-    for (const dep of directDeps) {
-        for (const entry of transitiveEntries) {
-            const otherDep = entry[0];
-            const otherTransitive = entry[1];
-            if (otherDep !== dep && otherTransitive.has(dep)) {
-                redundant.push({
-                    project,
-                    redundantDep: dep,
-                    alreadyBroughtInBy: otherDep,
-                });
-                break; // Only report once per redundant dep
-            }
-        }
-    }
-    return redundant;
-}
-/**
- * Write documentation file when violations are found
- */
-function writeDocFile(workspaceRoot) {
-    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions
-    try {
-        (0, rules_config_1.writeTemplate)(workspaceRoot, 'webpieces.transitivedeps.md');
-    }
-    catch (err) {
-        const error = (0, toError_1.toError)(err);
-        console.warn('Could not write webpieces.transitivedeps.md:', error.message);
-    }
-}
-async function runExecutor(_options, context) {
-    console.log('\n🔄 Validating No Skip-Level Dependencies\n');
-    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions
-    try {
-        // Step 1: Generate current graph from project.json files
-        console.log('📊 Generating dependency graph from project.json files...');
-        const graph = await (0, graph_generator_1.generateGraph)();
-        // Step 2: Find all redundant dependencies
-        console.log('🔍 Checking for redundant transitive dependencies...');
-        const allRedundant = [];
-        for (const project of Object.keys(graph)) {
-            const redundant = findRedundantDeps(project, graph);
-            allRedundant.push(...redundant);
-        }
-        if (allRedundant.length === 0) {
-            console.log('✅ No redundant transitive dependencies detected!');
-            console.log('\n📈 Graph is clean and minimal.');
-            return { success: true };
-        }
-        // Write documentation file
-        const workspaceRoot = context.root || process.cwd();
-        writeDocFile(workspaceRoot);
-        // Report violations
-        console.error('\n❌ Redundant transitive dependencies detected!\n');
-        console.error('⚠️  AI Agent: READ .webpieces/instruct-ai/webpieces.transitivedeps.md for fix instructions!\n');
-        for (const r of allRedundant) {
-            console.error(`  ${r.project}:`);
-            console.error(`    └─ "${r.redundantDep}" is REDUNDANT`);
-            console.error(`       (already brought in by "${r.alreadyBroughtInBy}")\n`);
-        }
-        console.error('\nTo fix:');
-        console.error('  1. READ .webpieces/instruct-ai/webpieces.transitivedeps.md');
-        console.error('  2. Remove redundant deps from project.json build.dependsOn');
-        console.error('  3. Remove redundant deps from package.json dependencies');
-        console.error('  4. Run: npx nx run architecture:generate');
-        console.error('  5. Run: npm run build-all');
-        return { success: false };
-    }
-    catch (err) {
-        const error = (0, toError_1.toError)(err);
-        console.error('❌ Skip-level validation failed:', error.message);
-        return { success: false };
-    }
+async function runExecutor(_options, _context) {
+    console.log('\n⏭️  validate-no-skiplevel-deps is retired (no-op).\n' +
+        '   Superseded by auto-reduction in `architecture:generate`: the committed graph is\n' +
+        '   transitively reduced, so skip-level edges cannot occur.\n');
+    return { success: true };
 }
 //# sourceMappingURL=executor.js.map

package/src/executors/validate-no-skiplevel-deps/executor.js.map

@@ -1 +1 @@
-{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/nx-webpieces-rules/src/executors/validate-no-skiplevel-deps/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;GAWG;;AAkGH,8BAsDC;AArJD,+DAA0D;AAC1D,0DAAwD;AACxD,2CAAwC;AAgBxC;;GAEG;AACH,SAAS,qBAAqB,CAC1B,OAAe,EACf,KAA+B,EAC/B,UAAuB,IAAI,GAAG,EAAE;IAEhC,MAAM,MAAM,GAAG,IAAI,GAAG,EAAU,CAAC;IAEjC,IAAI,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;QACvB,OAAO,MAAM,CAAC;IAClB,CAAC;IACD,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;IAErB,MAAM,UAAU,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;IACxC,KAAK,MAAM,GAAG,IAAI,UAAU,EAAE,CAAC;QAC3B,MAAM,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QAChB,kCAAkC;QAClC,MAAM,UAAU,GAAG,qBAAqB,CAAC,GAAG,EAAE,KAAK,EAAE,OAAO,CAAC,CAAC;QAC9D,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YACzB,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;QAClB,CAAC;IACL,CAAC;IAED,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;GAEG;AACH,SAAS,iBAAiB,CACtB,OAAe,EACf,KAA+B;IAE/B,MAAM,SAAS,GAAmB,EAAE,CAAC;IACrC,MAAM,UAAU,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;IAExC,qEAAqE;IACrE,MAAM,eAAe,GAAG,IAAI,GAAG,EAAuB,CAAC;IACvD,KAAK,MAAM,GAAG,IAAI,UAAU,EAAE,CAAC;QAC3B,eAAe,CAAC,GAAG,CAAC,GAAG,EAAE,qBAAqB,CAAC,GAAG,EAAE,KAAK,CAAC,CAAC,CAAC;IAChE,CAAC;IAED,kEAAkE;IAClE,MAAM,iBAAiB,GAAG,KAAK,CAAC,IAAI,CAAC,eAAe,CAAC,OAAO,EAAE,CAAC,CAAC;IAChE,KAAK,MAAM,GAAG,IAAI,UAAU,EAAE,CAAC;QAC3B,KAAK,MAAM,KAAK,IAAI,iBAAiB,EAAE,CAAC;YACpC,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAC1B,MAAM,eAAe,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YACjC,IAAI,QAAQ,KAAK,GAAG,IAAI,eAAe,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;gBAC/C,SAAS,CAAC,IAAI,CAAC;oBACX,OAAO;oBACP,YAAY,EAAE,GAAG;oBACjB,kBAAkB,EAAE,QAAQ;iBAC/B,CAAC,CAAC;gBACH,MAAM,CAAC,qCAAqC;YAChD,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,SAAS,CAAC;AACrB,CAAC;AAED;;GAEG;AACH,SAAS,YAAY,CAAC,aAAqB;IACvC,8DAA8D;IAC9D,IAAI,CAAC;QACD,IAAA,4BAAa,EAAC,aAAa,EAAE,6BAA6B,CAAC,CAAC;IAChE,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,IAAA,iBAAO,EAAC,GAAG,CAAC,CAAC;QAC3B,OAAO,CAAC,IAAI,CAAC,8CAA8C,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;IAChF,CAAC;AACL,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,QAAwC,EACxC,OAAwB;IAExB,OAAO,CAAC,GAAG,CAAC,8CAA8C,CAAC,CAAC;IAE5D,8DAA8D;IAC9D,IAAI,CAAC;QACD,yDAAyD;QACzD,OAAO,CAAC,GAAG,CAAC,2DAA2D,CAAC,CAAC;QACzE,MAAM,KAAK,GAAG,MAAM,IAAA,+BAAa,GAAE,CAAC;QAEpC,0CAA0C;QAC1C,OAAO,CAAC,GAAG,CAAC,sDAAsD,CAAC,CAAC;QACpE,MAAM,YAAY,GAAmB,EAAE,CAAC;QAExC,KAAK,MAAM,OAAO,IAAI,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;YACvC,MAAM,SAAS,GAAG,iBAAiB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;YACpD,YAAY,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;QACpC,CAAC;QAED,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,kDAAkD,CAAC,CAAC;YAChE,OAAO,CAAC,GAAG,CAAC,kCAAkC,CAAC,CAAC;YAChD,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,2BAA2B;QAC3B,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,IAAI,OAAO,CAAC,GAAG,EAAE,CAAC;QACpD,YAAY,CAAC,aAAa,CAAC,CAAC;QAE5B,oBAAoB;QACpB,OAAO,CAAC,KAAK,CAAC,mDAAmD,CAAC,CAAC;QACnE,OAAO,CAAC,KAAK,CAAC,+FAA+F,CAAC,CAAC;QAE/G,KAAK,MAAM,CAAC,IAAI,YAAY,EAAE,CAAC;YAC3B,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,OAAO,GAAG,CAAC,CAAC;YACjC,OAAO,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC,YAAY,gBAAgB,CAAC,CAAC;YACzD,OAAO,CAAC,KAAK,CAAC,kCAAkC,CAAC,CAAC,kBAAkB,MAAM,CAAC,CAAC;QAChF,CAAC;QAED,OAAO,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;QAC3B,OAAO,CAAC,KAAK,CAAC,8DAA8D,CAAC,CAAC;QAC9E,OAAO,CAAC,KAAK,CAAC,8DAA8D,CAAC,CAAC;QAC9E,OAAO,CAAC,KAAK,CAAC,2DAA2D,CAAC,CAAC;QAC3E,OAAO,CAAC,KAAK,CAAC,4CAA4C,CAAC,CAAC;QAC5D,OAAO,CAAC,KAAK,CAAC,6BAA6B,CAAC,CAAC;QAE7C,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,IAAA,iBAAO,EAAC,GAAG,CAAC,CAAC;QAC3B,OAAO,CAAC,KAAK,CAAC,iCAAiC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAChE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate No Skip-Level Dependencies Executor\n *\n * Validates that no project has redundant transitive dependencies.\n * If project A depends on B, and B transitively brings in C, then A should NOT\n * also directly depend on C (it's redundant and clutters the dependency graph).\n *\n * This keeps the architecture graph clean for visualization and human understanding.\n *\n * Usage:\n * nx run architecture:validate-no-skiplevel-deps\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { generateGraph } from '../../lib/graph-generator';\nimport { writeTemplate } from '@webpieces/rules-config';\nimport { toError } from '../../toError';\n\nexport interface ValidateNoSkipLevelDepsOptions {\n    // No options needed\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\ninterface RedundantDep {\n    project: string;\n    redundantDep: string;\n    alreadyBroughtInBy: string;\n}\n\n/**\n * Compute all transitive dependencies for a project\n */\nfunction computeTransitiveDeps(\n    project: string,\n    graph: Record<string, string[]>,\n    visited: Set<string> = new Set()\n): Set<string> {\n    const result = new Set<string>();\n\n    if (visited.has(project)) {\n        return result;\n    }\n    visited.add(project);\n\n    const directDeps = graph[project] || [];\n    for (const dep of directDeps) {\n        result.add(dep);\n        // Recursively get transitive deps\n        const transitive = computeTransitiveDeps(dep, graph, visited);\n        for (const t of transitive) {\n            result.add(t);\n        }\n    }\n\n    return result;\n}\n\n/**\n * Find redundant dependencies for a project\n */\nfunction findRedundantDeps(\n    project: string,\n    graph: Record<string, string[]>\n): RedundantDep[] {\n    const redundant: RedundantDep[] = [];\n    const directDeps = graph[project] || [];\n\n    // For each direct dependency, compute what it transitively brings in\n    const transitiveByDep = new Map<string, Set<string>>();\n    for (const dep of directDeps) {\n        transitiveByDep.set(dep, computeTransitiveDeps(dep, graph));\n    }\n\n    // Check if any direct dependency is already brought in by another\n    const transitiveEntries = Array.from(transitiveByDep.entries());\n    for (const dep of directDeps) {\n        for (const entry of transitiveEntries) {\n            const otherDep = entry[0];\n            const otherTransitive = entry[1];\n            if (otherDep !== dep && otherTransitive.has(dep)) {\n                redundant.push({\n                    project,\n                    redundantDep: dep,\n                    alreadyBroughtInBy: otherDep,\n                });\n                break; // Only report once per redundant dep\n            }\n        }\n    }\n\n    return redundant;\n}\n\n/**\n * Write documentation file when violations are found\n */\nfunction writeDocFile(workspaceRoot: string): void {\n    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n    try {\n        writeTemplate(workspaceRoot, 'webpieces.transitivedeps.md');\n    } catch (err: unknown) {\n        const error = toError(err);\n        console.warn('Could not write webpieces.transitivedeps.md:', error.message);\n    }\n}\n\nexport default async function runExecutor(\n    _options: ValidateNoSkipLevelDepsOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    console.log('\\n🔄 Validating No Skip-Level Dependencies\\n');\n\n    // eslint-disable-next-line @webpieces/no-unmanaged-exceptions\n    try {\n        // Step 1: Generate current graph from project.json files\n        console.log('📊 Generating dependency graph from project.json files...');\n        const graph = await generateGraph();\n\n        // Step 2: Find all redundant dependencies\n        console.log('🔍 Checking for redundant transitive dependencies...');\n        const allRedundant: RedundantDep[] = [];\n\n        for (const project of Object.keys(graph)) {\n            const redundant = findRedundantDeps(project, graph);\n            allRedundant.push(...redundant);\n        }\n\n        if (allRedundant.length === 0) {\n            console.log('✅ No redundant transitive dependencies detected!');\n            console.log('\\n📈 Graph is clean and minimal.');\n            return { success: true };\n        }\n\n        // Write documentation file\n        const workspaceRoot = context.root || process.cwd();\n        writeDocFile(workspaceRoot);\n\n        // Report violations\n        console.error('\\n❌ Redundant transitive dependencies detected!\\n');\n        console.error('⚠️  AI Agent: READ .webpieces/instruct-ai/webpieces.transitivedeps.md for fix instructions!\\n');\n\n        for (const r of allRedundant) {\n            console.error(`  ${r.project}:`);\n            console.error(`    └─ \"${r.redundantDep}\" is REDUNDANT`);\n            console.error(`       (already brought in by \"${r.alreadyBroughtInBy}\")\\n`);\n        }\n\n        console.error('\\nTo fix:');\n        console.error('  1. READ .webpieces/instruct-ai/webpieces.transitivedeps.md');\n        console.error('  2. Remove redundant deps from project.json build.dependsOn');\n        console.error('  3. Remove redundant deps from package.json dependencies');\n        console.error('  4. Run: npx nx run architecture:generate');\n        console.error('  5. Run: npm run build-all');\n\n        return { success: false };\n    } catch (err: unknown) {\n        const error = toError(err);\n        console.error('❌ Skip-level validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/nx-webpieces-rules/src/executors/validate-no-skiplevel-deps/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;;GAiBG;;AAYH,8BAUC;AAVc,KAAK,UAAU,WAAW,CACrC,QAAwC,EACxC,QAAyB;IAEzB,OAAO,CAAC,GAAG,CACP,wDAAwD;QACpD,sFAAsF;QACtF,8DAA8D,CACrE,CAAC;IACF,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;AAC7B,CAAC","sourcesContent":["/**\n * Validate No Skip-Level Dependencies Executor — RETIRED (no-op).\n *\n * Skip-level (redundant transitive) edges used to be an error here. That is no longer\n * meaningful: `architecture:generate` now derives the graph from nx's project graph and\n * applies transitive reduction, so the committed architecture/dependencies.json can never\n * contain a redundant edge. The check is superseded by auto-reduction.\n *\n * Worse, its old remediation told users to remove \"redundant\" deps from package.json —\n * which is exactly the runtime-validity trap (a transitively-reachable package.json entry\n * can still be a real runtime dependency, e.g. a peerDependency or generated client).\n *\n * Defaults off (workspace.validations.noSkipLevelDeps=false). Kept as a no-op for one\n * release so any explicit enablement does not error on now-expected skip-level edges.\n *\n * Usage:\n * nx run architecture:validate-no-skiplevel-deps\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\n\nexport interface ValidateNoSkipLevelDepsOptions {\n    // No options needed\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\nexport default async function runExecutor(\n    _options: ValidateNoSkipLevelDepsOptions,\n    _context: ExecutorContext\n): Promise<ExecutorResult> {\n    console.log(\n        '\\n⏭️  validate-no-skiplevel-deps is retired (no-op).\\n' +\n            '   Superseded by auto-reduction in `architecture:generate`: the committed graph is\\n' +\n            '   transitively reduced, so skip-level edges cannot occur.\\n'\n    );\n    return { success: true };\n}\n"]}

package/src/executors/validate-nx-wiring/executor.d.ts

@@ -1,24 +1,25 @@
 /**
  * Validate Nx Wiring Executor
  *
- * Enforces that the webpieces validators are actually wired into the build in
- * nx.json. The plugin auto-infers the validator targets (architecture:validate-complete,
- * per-project validate-no-file-import-cycles), but the load-bearing connection that
- * makes a build DEPEND on them lives in each repo's hand-edited nx.json:
+ * Enforces that the webpieces validators are actually wired into the build. Two checks:
  *
- *   "@nx/js:tsc": {
- *       "dependsOn": ["architecture:validate-complete", "validate-no-file-import-cycles", "^build"]
- *   }
+ * 1. nx.json targetDefaults — the compile executors (@nx/js:tsc, @angular/build:application)
+ *    must carry the load-bearing dependsOn:
+ *      ["architecture:validate-complete", "validate-no-file-import-cycles", "^build"]
  *
- * If that dependsOn is stripped, the validators exist but never run and a build stays
- * green while validating nothing. This executor fails when the wiring is missing.
+ * 2. Per-project override guard — a project that declares its OWN build.dependsOn OVERRIDES
+ *    the targetDefaults entirely (nx does not merge dependsOn). That silently drops `^build`
+ *    (→ upstream libs not built first, builds against an empty dist) AND the validator gates
+ *    (→ the project builds green while validating nothing). So we check each compile project's
+ *    RESOLVED build.dependsOn and fail if it is missing any required entry.
  *
- * Conservative by design: it only REQUIRES wiring on compile executors that are
- * actually used somewhere in the project graph (@nx/js:tsc, @angular/build:application).
- * A repo that uses neither has nothing to gate and passes.
+ * If either is stripped, validators exist but never run and the build stays green while
+ * validating nothing. This executor fails when the wiring is missing.
  *
- * Disable per validator in webpieces.config.json (rules[name].mode="OFF"), but the
- * wiring itself is governed by the "nx-wiring" rule (default on) so the build gate stays.
+ * Conservative by design: only REQUIRES wiring on compile executors actually in use
+ * (@nx/js:tsc, @angular/build:application). A repo that uses neither passes.
+ *
+ * Disable via webpieces.config.json rules["nx-wiring"].mode="OFF".
  *
  * Usage: nx run architecture:validate-nx-wiring
  */

package/src/executors/validate-nx-wiring/executor.js

@@ -2,24 +2,25 @@
 /**
  * Validate Nx Wiring Executor
  *
- * Enforces that the webpieces validators are actually wired into the build in
- * nx.json. The plugin auto-infers the validator targets (architecture:validate-complete,
- * per-project validate-no-file-import-cycles), but the load-bearing connection that
- * makes a build DEPEND on them lives in each repo's hand-edited nx.json:
+ * Enforces that the webpieces validators are actually wired into the build. Two checks:
  *
- *   "@nx/js:tsc": {
- *       "dependsOn": ["architecture:validate-complete", "validate-no-file-import-cycles", "^build"]
- *   }
+ * 1. nx.json targetDefaults — the compile executors (@nx/js:tsc, @angular/build:application)
+ *    must carry the load-bearing dependsOn:
+ *      ["architecture:validate-complete", "validate-no-file-import-cycles", "^build"]
  *
- * If that dependsOn is stripped, the validators exist but never run and a build stays
- * green while validating nothing. This executor fails when the wiring is missing.
+ * 2. Per-project override guard — a project that declares its OWN build.dependsOn OVERRIDES
+ *    the targetDefaults entirely (nx does not merge dependsOn). That silently drops `^build`
+ *    (→ upstream libs not built first, builds against an empty dist) AND the validator gates
+ *    (→ the project builds green while validating nothing). So we check each compile project's
+ *    RESOLVED build.dependsOn and fail if it is missing any required entry.
  *
- * Conservative by design: it only REQUIRES wiring on compile executors that are
- * actually used somewhere in the project graph (@nx/js:tsc, @angular/build:application).
- * A repo that uses neither has nothing to gate and passes.
+ * If either is stripped, validators exist but never run and the build stays green while
+ * validating nothing. This executor fails when the wiring is missing.
  *
- * Disable per validator in webpieces.config.json (rules[name].mode="OFF"), but the
- * wiring itself is governed by the "nx-wiring" rule (default on) so the build gate stays.
+ * Conservative by design: only REQUIRES wiring on compile executors actually in use
+ * (@nx/js:tsc, @angular/build:application). A repo that uses neither passes.
+ *
+ * Disable via webpieces.config.json rules["nx-wiring"].mode="OFF".
  *
  * Usage: nx run architecture:validate-nx-wiring
  */
@@ -34,6 +35,8 @@ const DEFAULT_REQUIRED_DEPS = [
     'architecture:validate-complete',
     'validate-no-file-import-cycles',
 ];
+// Per-project build targets must ALSO keep `^build` so build order follows nx's full graph.
+const BUILD_ORDER_DEP = '^build';
 const DEFAULT_COMPILE_EXECUTORS = [
     '@nx/js:tsc',
     '@angular/build:application',
@@ -45,6 +48,14 @@ class WiringProblem {
         this.found = found;
     }
 }
+class ProjectGateProblem {
+    constructor(project, executorName, missing, found) {
+        this.project = project;
+        this.executorName = executorName;
+        this.missing = missing;
+        this.found = found;
+    }
+}
 function readTargetDefaults(workspaceRoot) {
     const nxJsonPath = path.join(workspaceRoot, 'nx.json');
     if (!fs.existsSync(nxJsonPath))
@@ -62,9 +73,7 @@ function readTargetDefaults(workspaceRoot) {
         return {};
     }
 }
-async function findCompileExecutorsInUse(compileExecutors) {
-    const projectGraph = await (0, devkit_1.createProjectGraphAsync)();
-    const projectsConfig = (0, devkit_1.readProjectsConfigurationFromProjectGraph)(projectGraph);
+function findCompileExecutorsInUse(projectsConfig, compileExecutors) {
     const known = new Set(compileExecutors);
     const inUse = new Set();
     for (const cfg of Object.values(projectsConfig.projects)) {
@@ -90,8 +99,44 @@ function findProblems(relevantExecutors, targetDefaults, requiredDeps) {
     }
     return problems;
 }
+/**
+ * Normalize an nx dependsOn entry to a comparable string. The string form ("^build",
+ * "validate-complete") passes through; the object form is rendered the same way
+ * ({target:"build", dependencies:true} → "^build", {target:"build"} → "build").
+ */
+function normalizeDeps(deps) {
+    return deps.map((dep) => {
+        if (typeof dep === 'string')
+            return dep;
+        const target = dep.target ?? '';
+        return dep.dependencies ? `^${target}` : target;
+    });
+}
+/**
+ * Check each compile project's RESOLVED build.dependsOn (targetDefaults already merged in)
+ * for the required gates + `^build`. A project that overrode them away is flagged.
+ */
+function findProjectGateProblems(projectsConfig, compileExecutors, requiredPerProject) {
+    const problems = [];
+    for (const [name, cfg] of Object.entries(projectsConfig.projects)) {
+        // Tooling/foundation packages (type:tooling) BUILD the validators, so gating their own
+        // build on validate-complete would create a bootstrap cycle. They are exempt: they keep
+        // build-order ("^build") only. Application/library code is still fully gated.
+        if ((cfg.tags ?? []).includes('type:tooling'))
+            continue;
+        const build = cfg.targets?.['build'];
+        if (!build || !build.executor || !compileExecutors.has(build.executor))
+            continue;
+        const dependsOn = normalizeDeps(build.dependsOn ?? []);
+        const missing = requiredPerProject.filter((dep) => !dependsOn.includes(dep));
+        if (missing.length > 0) {
+            problems.push(new ProjectGateProblem(name, build.executor, missing, dependsOn));
+        }
+    }
+    return problems;
+}
 function reportFailure(problems, requiredDeps) {
-    console.error('\n❌ webpieces validators are not wired into your build.\n');
+    console.error('\n❌ webpieces validators are not wired into your build (nx.json).\n');
     console.error('The validators exist but no build depends on them, so they never run.');
     console.error('Add the missing dependsOn entries to nx.json targetDefaults:\n');
     const depsList = requiredDeps.map((dep) => `"${dep}"`).join(', ');
@@ -102,10 +147,23 @@ function reportFailure(problems, requiredDeps) {
         console.error('  }');
         console.error(`    missing: ${missingList}\n`);
     }
-    console.error('To disable an INDIVIDUAL validator, set rules[name].mode="OFF" in');
-    console.error('webpieces.config.json — but the wiring above must stay installed so the');
-    console.error('build gate keeps working. To turn this wiring check itself off, set');
-    console.error('rules["nx-wiring"].mode="OFF" in webpieces.config.json.\n');
+    console.error('To turn this wiring check off, set rules["nx-wiring"].mode="OFF" in');
+    console.error('webpieces.config.json.\n');
+}
+function reportProjectGateFailure(problems) {
+    console.error('\n❌ Some projects override away the build gates in their project.json.\n');
+    console.error('A project-level build.dependsOn OVERRIDES nx.json targetDefaults (nx does not');
+    console.error('merge dependsOn). That silently drops "^build" (upstreams not built first →');
+    console.error('builds against an empty dist) and/or the validators (build stays green while');
+    console.error('validating nothing).\n');
+    console.error('Fix: remove build.dependsOn from these project.json files so targetDefaults');
+    console.error('apply, OR include all required entries explicitly:\n');
+    for (const p of problems) {
+        const missingList = p.missing.map((dep) => `"${dep}"`).join(', ');
+        console.error(`  ${p.project} (${p.executorName}):`);
+        console.error(`    resolved build.dependsOn: ${JSON.stringify(p.found)}`);
+        console.error(`    missing: ${missingList}\n`);
+    }
 }
 async function runExecutor(options, context) {
     const shared = (0, rules_config_1.loadConfig)(context.root);
@@ -117,19 +175,28 @@ async function runExecutor(options, context) {
     const requiredDeps = options.requiredDeps ?? DEFAULT_REQUIRED_DEPS;
     const compileExecutors = options.compileExecutors ?? DEFAULT_COMPILE_EXECUTORS;
     console.log('\n🔌 Validating webpieces validators are wired into the build\n');
-    const inUse = await findCompileExecutorsInUse(compileExecutors);
+    const projectGraph = await (0, devkit_1.createProjectGraphAsync)();
+    const projectsConfig = (0, devkit_1.readProjectsConfigurationFromProjectGraph)(projectGraph);
+    const inUse = findCompileExecutorsInUse(projectsConfig, compileExecutors);
     const relevantExecutors = compileExecutors.filter((executorName) => inUse.has(executorName));
     if (relevantExecutors.length === 0) {
         console.log('✅ No known compile executors in use — nothing to gate\n');
         return { success: true };
     }
     const targetDefaults = readTargetDefaults(context.root);
-    const problems = findProblems(relevantExecutors, targetDefaults, requiredDeps);
-    if (problems.length === 0) {
-        console.log('✅ Validators are wired into the build\n');
+    const wiringProblems = findProblems(relevantExecutors, targetDefaults, requiredDeps);
+    const gateProblems = findProjectGateProblems(projectsConfig, inUse, [
+        ...requiredDeps,
+        BUILD_ORDER_DEP,
+    ]);
+    if (wiringProblems.length === 0 && gateProblems.length === 0) {
+        console.log('✅ Validators are wired into the build (targetDefaults + every project)\n');
         return { success: true };
     }
-    reportFailure(problems, requiredDeps);
+    if (wiringProblems.length > 0)
+        reportFailure(wiringProblems, requiredDeps);
+    if (gateProblems.length > 0)
+        reportProjectGateFailure(gateProblems);
     return { success: false };
 }
 //# sourceMappingURL=executor.js.map