@webpieces/dev-config 0.2.65 → 0.2.67

package/architecture/executors/validate-code/executor.d.ts

@@ -0,0 +1,13 @@
+import { ExecutorContext } from '@nx/devkit';
+export type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';
+export interface ValidateCodeOptions {
+    mode?: ValidationMode;
+    newMethodsMaxLines?: number;
+    strictNewMethodMaxLines?: number;
+    modifiedMethodsMaxLines?: number;
+    modifiedFilesMaxLines?: number;
+}
+export interface ExecutorResult {
+    success: boolean;
+}
+export default function runExecutor(options: ValidateCodeOptions, context: ExecutorContext): Promise<ExecutorResult>;

package/architecture/executors/validate-code/executor.js

@@ -0,0 +1,36 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = runExecutor;
+const tslib_1 = require("tslib");
+const executor_1 = tslib_1.__importDefault(require("../validate-new-methods/executor"));
+const executor_2 = tslib_1.__importDefault(require("../validate-modified-methods/executor"));
+const executor_3 = tslib_1.__importDefault(require("../validate-modified-files/executor"));
+async function runExecutor(options, context) {
+    const mode = options.mode ?? 'NORMAL';
+    if (mode === 'OFF') {
+        console.log('\n⏭️  Skipping all code validations (validationMode: OFF)\n');
+        return { success: true };
+    }
+    console.log('\n📏 Running Code Validations\n');
+    console.log(`   Validation mode: ${mode}${mode === 'STRICT' ? ' (disable comments ignored for modified code)' : ''}`);
+    console.log(`   New methods max: ${options.newMethodsMaxLines ?? 30} lines (soft limit)`);
+    if (options.strictNewMethodMaxLines) {
+        console.log(`   New methods max: ${options.strictNewMethodMaxLines} lines (hard limit, no escape)`);
+    }
+    console.log(`   Modified methods max: ${options.modifiedMethodsMaxLines ?? 80} lines`);
+    console.log(`   Modified files max: ${options.modifiedFilesMaxLines ?? 900} lines`);
+    console.log('');
+    // Run all three validators sequentially to avoid interleaved output
+    const newMethodsResult = await (0, executor_1.default)({ max: options.newMethodsMaxLines ?? 30, strictMax: options.strictNewMethodMaxLines, mode }, context);
+    const modifiedMethodsResult = await (0, executor_2.default)({ max: options.modifiedMethodsMaxLines ?? 80, mode }, context);
+    const modifiedFilesResult = await (0, executor_3.default)({ max: options.modifiedFilesMaxLines ?? 900, mode }, context);
+    const allSuccess = newMethodsResult.success && modifiedMethodsResult.success && modifiedFilesResult.success;
+    if (allSuccess) {
+        console.log('\n✅ All code validations passed\n');
+    }
+    else {
+        console.log('\n❌ Some code validations failed\n');
+    }
+    return { success: allSuccess };
+}
+//# sourceMappingURL=executor.js.map

package/architecture/executors/validate-code/executor.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/dev-config/architecture/executors/validate-code/executor.ts"],"names":[],"mappings":";;AAmBA,8BA8CC;;AAhED,wFAAqE;AACrE,6FAA+E;AAC/E,2FAA2E;AAgB5D,KAAK,UAAU,WAAW,CACrC,OAA4B,EAC5B,OAAwB;IAExB,MAAM,IAAI,GAAmB,OAAO,CAAC,IAAI,IAAI,QAAQ,CAAC;IAEtD,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;QACjB,OAAO,CAAC,GAAG,CAAC,6DAA6D,CAAC,CAAC;QAC3E,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;IAC7B,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,iCAAiC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,uBAAuB,IAAI,GAAG,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,+CAA+C,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IACtH,OAAO,CAAC,GAAG,CAAC,uBAAuB,OAAO,CAAC,kBAAkB,IAAI,EAAE,qBAAqB,CAAC,CAAC;IAC1F,IAAI,OAAO,CAAC,uBAAuB,EAAE,CAAC;QAClC,OAAO,CAAC,GAAG,CAAC,uBAAuB,OAAO,CAAC,uBAAuB,gCAAgC,CAAC,CAAC;IACxG,CAAC;IACD,OAAO,CAAC,GAAG,CAAC,4BAA4B,OAAO,CAAC,uBAAuB,IAAI,EAAE,QAAQ,CAAC,CAAC;IACvF,OAAO,CAAC,GAAG,CAAC,0BAA0B,OAAO,CAAC,qBAAqB,IAAI,GAAG,QAAQ,CAAC,CAAC;IACpF,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAEhB,oEAAoE;IACpE,MAAM,gBAAgB,GAAG,MAAM,IAAA,kBAAqB,EAChD,EAAE,GAAG,EAAE,OAAO,CAAC,kBAAkB,IAAI,EAAE,EAAE,SAAS,EAAE,OAAO,CAAC,uBAAuB,EAAE,IAAI,EAAE,EAC3F,OAAO,CACV,CAAC;IAEF,MAAM,qBAAqB,GAAG,MAAM,IAAA,kBAA0B,EAC1D,EAAE,GAAG,EAAE,OAAO,CAAC,uBAAuB,IAAI,EAAE,EAAE,IAAI,EAAE,EACpD,OAAO,CACV,CAAC;IAEF,MAAM,mBAAmB,GAAG,MAAM,IAAA,kBAAwB,EACtD,EAAE,GAAG,EAAE,OAAO,CAAC,qBAAqB,IAAI,GAAG,EAAE,IAAI,EAAE,EACnD,OAAO,CACV,CAAC;IAEF,MAAM,UAAU,GAAG,gBAAgB,CAAC,OAAO,IAAI,qBAAqB,CAAC,OAAO,IAAI,mBAAmB,CAAC,OAAO,CAAC;IAE5G,IAAI,UAAU,EAAE,CAAC;QACb,OAAO,CAAC,GAAG,CAAC,mCAAmC,CAAC,CAAC;IACrD,CAAC;SAAM,CAAC;QACJ,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;IACtD,CAAC;IAED,OAAO,EAAE,OAAO,EAAE,UAAU,EAAE,CAAC;AACnC,CAAC","sourcesContent":["import { ExecutorContext } from '@nx/devkit';\nimport runNewMethodsExecutor from '../validate-new-methods/executor';\nimport runModifiedMethodsExecutor from '../validate-modified-methods/executor';\nimport runModifiedFilesExecutor from '../validate-modified-files/executor';\n\nexport type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';\n\nexport interface ValidateCodeOptions {\n    mode?: ValidationMode;\n    newMethodsMaxLines?: number;\n    strictNewMethodMaxLines?: number;\n    modifiedMethodsMaxLines?: number;\n    modifiedFilesMaxLines?: number;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\nexport default async function runExecutor(\n    options: ValidateCodeOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const mode: ValidationMode = options.mode ?? 'NORMAL';\n\n    if (mode === 'OFF') {\n        console.log('\\n⏭️  Skipping all code validations (validationMode: OFF)\\n');\n        return { success: true };\n    }\n\n    console.log('\\n📏 Running Code Validations\\n');\n    console.log(`   Validation mode: ${mode}${mode === 'STRICT' ? ' (disable comments ignored for modified code)' : ''}`);\n    console.log(`   New methods max: ${options.newMethodsMaxLines ?? 30} lines (soft limit)`);\n    if (options.strictNewMethodMaxLines) {\n        console.log(`   New methods max: ${options.strictNewMethodMaxLines} lines (hard limit, no escape)`);\n    }\n    console.log(`   Modified methods max: ${options.modifiedMethodsMaxLines ?? 80} lines`);\n    console.log(`   Modified files max: ${options.modifiedFilesMaxLines ?? 900} lines`);\n    console.log('');\n\n    // Run all three validators sequentially to avoid interleaved output\n    const newMethodsResult = await runNewMethodsExecutor(\n        { max: options.newMethodsMaxLines ?? 30, strictMax: options.strictNewMethodMaxLines, mode },\n        context\n    );\n\n    const modifiedMethodsResult = await runModifiedMethodsExecutor(\n        { max: options.modifiedMethodsMaxLines ?? 80, mode },\n        context\n    );\n\n    const modifiedFilesResult = await runModifiedFilesExecutor(\n        { max: options.modifiedFilesMaxLines ?? 900, mode },\n        context\n    );\n\n    const allSuccess = newMethodsResult.success && modifiedMethodsResult.success && modifiedFilesResult.success;\n\n    if (allSuccess) {\n        console.log('\\n✅ All code validations passed\\n');\n    } else {\n        console.log('\\n❌ Some code validations failed\\n');\n    }\n\n    return { success: allSuccess };\n}\n"]}

package/architecture/executors/validate-code/executor.ts

@@ -0,0 +1,66 @@
+import { ExecutorContext } from '@nx/devkit';
+import runNewMethodsExecutor from '../validate-new-methods/executor';
+import runModifiedMethodsExecutor from '../validate-modified-methods/executor';
+import runModifiedFilesExecutor from '../validate-modified-files/executor';
+
+export type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';
+
+export interface ValidateCodeOptions {
+    mode?: ValidationMode;
+    newMethodsMaxLines?: number;
+    strictNewMethodMaxLines?: number;
+    modifiedMethodsMaxLines?: number;
+    modifiedFilesMaxLines?: number;
+}
+
+export interface ExecutorResult {
+    success: boolean;
+}
+
+export default async function runExecutor(
+    options: ValidateCodeOptions,
+    context: ExecutorContext
+): Promise<ExecutorResult> {
+    const mode: ValidationMode = options.mode ?? 'NORMAL';
+
+    if (mode === 'OFF') {
+        console.log('\n⏭️  Skipping all code validations (validationMode: OFF)\n');
+        return { success: true };
+    }
+
+    console.log('\n📏 Running Code Validations\n');
+    console.log(`   Validation mode: ${mode}${mode === 'STRICT' ? ' (disable comments ignored for modified code)' : ''}`);
+    console.log(`   New methods max: ${options.newMethodsMaxLines ?? 30} lines (soft limit)`);
+    if (options.strictNewMethodMaxLines) {
+        console.log(`   New methods max: ${options.strictNewMethodMaxLines} lines (hard limit, no escape)`);
+    }
+    console.log(`   Modified methods max: ${options.modifiedMethodsMaxLines ?? 80} lines`);
+    console.log(`   Modified files max: ${options.modifiedFilesMaxLines ?? 900} lines`);
+    console.log('');
+
+    // Run all three validators sequentially to avoid interleaved output
+    const newMethodsResult = await runNewMethodsExecutor(
+        { max: options.newMethodsMaxLines ?? 30, strictMax: options.strictNewMethodMaxLines, mode },
+        context
+    );
+
+    const modifiedMethodsResult = await runModifiedMethodsExecutor(
+        { max: options.modifiedMethodsMaxLines ?? 80, mode },
+        context
+    );
+
+    const modifiedFilesResult = await runModifiedFilesExecutor(
+        { max: options.modifiedFilesMaxLines ?? 900, mode },
+        context
+    );
+
+    const allSuccess = newMethodsResult.success && modifiedMethodsResult.success && modifiedFilesResult.success;
+
+    if (allSuccess) {
+        console.log('\n✅ All code validations passed\n');
+    } else {
+        console.log('\n❌ Some code validations failed\n');
+    }
+
+    return { success: allSuccess };
+}

package/architecture/executors/validate-code/schema.json

@@ -0,0 +1,34 @@
+{
+    "$schema": "http://json-schema.org/schema",
+    "title": "Validate Code Executor",
+    "description": "Combined validation for new methods, modified methods, and file sizes. Configure via targetDefaults in nx.json for runtime options (no cache issues).",
+    "type": "object",
+    "properties": {
+        "mode": {
+            "type": "string",
+            "enum": ["STRICT", "NORMAL", "OFF"],
+            "description": "OFF: skip all validations. NORMAL: enforce limits, disable comments work. STRICT: enforce limits, no disable comments for modified code.",
+            "default": "NORMAL"
+        },
+        "newMethodsMaxLines": {
+            "type": "number",
+            "description": "Soft limit: Maximum lines for NEW methods (can be bypassed with disable comment)",
+            "default": 30
+        },
+        "strictNewMethodMaxLines": {
+            "type": "number",
+            "description": "Hard limit: Absolute maximum lines for NEW methods (CANNOT be bypassed). If not set, no hard limit is enforced."
+        },
+        "modifiedMethodsMaxLines": {
+            "type": "number",
+            "description": "Maximum lines for MODIFIED methods",
+            "default": 80
+        },
+        "modifiedFilesMaxLines": {
+            "type": "number",
+            "description": "Maximum lines for MODIFIED files",
+            "default": 900
+        }
+    },
+    "required": []
+}

package/architecture/executors/validate-new-methods/executor.d.ts

@@ -19,6 +19,7 @@ import type { ExecutorContext } from '@nx/devkit';
 export type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';
 export interface ValidateNewMethodsOptions {
     max?: number;
+    strictMax?: number;
     mode?: ValidationMode;
 }
 export interface ExecutorResult {

package/architecture/executors/validate-new-methods/executor.js

@@ -304,7 +304,7 @@ function findMethodsInFile(filePath, workspaceRoot) {
 /**
  * Find new methods that exceed the line limit
  */
-function findViolations(workspaceRoot, changedFiles, base, maxLines) {
+function findViolations(workspaceRoot, changedFiles, base, maxLines, strictMaxLines) {
     const violations = [];
     for (const file of changedFiles) {
         // Get the diff to find which methods are NEW (not just modified)
@@ -315,14 +315,30 @@ function findViolations(workspaceRoot, changedFiles, base, maxLines) {
         // Parse the current file to get method line counts
         const methods = findMethodsInFile(file, workspaceRoot);
         for (const method of methods) {
-            // Only check NEW methods that don't have webpieces-disable comment
-            if (newMethodNames.has(method.name) && method.lines > maxLines && !method.hasDisableComment) {
+            if (!newMethodNames.has(method.name))
+                continue;
+            // Check hard limit first (if defined) - NO escape possible
+            if (strictMaxLines && method.lines > strictMaxLines) {
                 violations.push({
                     file,
                     methodName: method.name,
                     line: method.line,
                     lines: method.lines,
                     isNew: true,
+                    isHardLimit: true,
+                    limit: strictMaxLines,
+                });
+            }
+            // Check soft limit - can be escaped with disable comment
+            else if (method.lines > maxLines && !method.hasDisableComment) {
+                violations.push({
+                    file,
+                    methodName: method.name,
+                    line: method.line,
+                    lines: method.lines,
+                    isNew: true,
+                    isHardLimit: false,
+                    limit: maxLines,
                 });
             }
         }
@@ -366,9 +382,12 @@ function detectBase(workspaceRoot) {
 /**
  * Report violations to the user with helpful instructions
  */
-function reportViolations(violations, maxLines) {
+// webpieces-disable max-lines-new-methods -- Console output formatting requires distinct sections for hard/soft violations
+function reportViolations(violations, maxLines, strictMaxLines) {
+    const hardViolations = violations.filter((v) => v.isHardLimit);
+    const softViolations = violations.filter((v) => !v.isHardLimit);
     console.error('');
-    console.error('❌ New methods exceed ' + maxLines + ' lines!');
+    console.error('❌ New methods exceed line limits!');
     console.error('');
     console.error('📚 Methods should read like a "table of contents" - each method call');
     console.error('   describes a larger piece of work. You can refactor');
@@ -376,18 +395,37 @@ function reportViolations(violations, maxLines) {
     console.error('');
     console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
     console.error('');
-    for (const v of violations) {
-        console.error(`  ❌ ${v.file}:${v.line}`);
-        console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
+    if (hardViolations.length > 0) {
+        console.error('🚫 HARD LIMIT VIOLATIONS (cannot be bypassed with disable comment):');
+        console.error('');
+        for (const v of hardViolations) {
+            console.error(`  ❌ ${v.file}:${v.line}`);
+            console.error(`     Method: ${v.methodName} (${v.lines} lines, hard max: ${strictMaxLines})`);
+        }
+        console.error('');
+        console.error('   These methods MUST be refactored - no escape hatch available.');
+        console.error('');
+    }
+    if (softViolations.length > 0) {
+        console.error('⚠️  SOFT LIMIT VIOLATIONS (can be bypassed with disable comment):');
+        console.error('');
+        for (const v of softViolations) {
+            console.error(`  ❌ ${v.file}:${v.line}`);
+            console.error(`     Method: ${v.methodName} (${v.lines} lines, soft max: ${maxLines})`);
+        }
+        console.error('');
+        console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');
+        console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');
+        if (strictMaxLines) {
+            console.error(`   NOTE: Even with escape, you cannot exceed the hard limit of ${strictMaxLines} lines.`);
+        }
+        console.error('');
     }
-    console.error('');
-    console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');
-    console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');
-    console.error('');
 }
 async function runExecutor(options, context) {
     const workspaceRoot = context.root;
     const maxLines = options.max ?? 30;
+    const strictMaxLines = options.strictMax;
     const mode = options.mode ?? 'NORMAL';
     // Skip validation entirely if mode is OFF
     if (mode === 'OFF') {
@@ -415,7 +453,10 @@ async function runExecutor(options, context) {
     }
     console.log(`   Base: ${base}`);
     console.log(`   Comparing to: working tree (includes uncommitted changes)`);
-    console.log(`   Max lines for new methods: ${maxLines}`);
+    console.log(`   Soft limit for new methods: ${maxLines} lines (can escape with disable comment)`);
+    if (strictMaxLines) {
+        console.log(`   Hard limit for new methods: ${strictMaxLines} lines (NO escape possible)`);
+    }
     console.log('');
     try {
         // Get changed TypeScript files (base to working tree, like nx affected)
@@ -426,14 +467,17 @@ async function runExecutor(options, context) {
         }
         console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);
         // Find violations
-        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);
+        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines, strictMaxLines);
         if (violations.length === 0) {
-            console.log('✅ All new methods are under ' + maxLines + ' lines');
+            const limitMsg = strictMaxLines
+                ? `soft limit (${maxLines}) or hard limit (${strictMaxLines})`
+                : `${maxLines} lines`;
+            console.log('✅ All new methods are within ' + limitMsg);
             return { success: true };
         }
         // Write instructions file and report violations
         writeTmpInstructions(workspaceRoot);
-        reportViolations(violations, maxLines);
+        reportViolations(violations, maxLines, strictMaxLines);
         return { success: false };
     }
     catch (err) {

package/architecture/executors/validate-new-methods/executor.js.map

@@ -1 +1 @@
-{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/dev-config/architecture/executors/validate-new-methods/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;GAgBG;;AAoaH,8BAsEC;;AAveD,iDAAyC;AACzC,+CAAyB;AACzB,mDAA6B;AAC7B,uDAAiC;AAqBjC,MAAM,OAAO,GAAG,eAAe,CAAC;AAChC,MAAM,WAAW,GAAG,yBAAyB,CAAC;AAE9C,MAAM,sBAAsB,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAoH9B,CAAC;AAEF;;GAEG;AACH,SAAS,oBAAoB,CAAC,aAAqB;IAC/C,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,OAAO,CAAC,CAAC;IACjD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;IAE9C,EAAE,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC1C,EAAE,CAAC,aAAa,CAAC,MAAM,EAAE,sBAAsB,CAAC,CAAC;IAEjD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;;;GAIG;AACH,SAAS,yBAAyB,CAAC,aAAqB,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,MAAM,MAAM,GAAG,IAAA,wBAAQ,EAAC,wBAAwB,IAAI,oBAAoB,EAAE;YACtE,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;QACH,OAAO,MAAM;aACR,IAAI,EAAE;aACN,KAAK,CAAC,IAAI,CAAC;aACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC;IAChF,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;;;GAIG;AACH,SAAS,WAAW,CAAC,aAAqB,EAAE,IAAY,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,OAAO,IAAA,wBAAQ,EAAC,YAAY,IAAI,QAAQ,IAAI,GAAG,EAAE;YAC7C,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;IACP,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;GAEG;AACH,SAAS,6BAA6B,CAAC,WAAmB;IACtD,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAEtC,uCAAuC;IACvC,MAAM,QAAQ,GAAG;QACb,qEAAqE;QACrE,wDAAwD;QACxD,4CAA4C;QAC5C,iEAAiE;QACjE,mDAAmD;QACnD,uEAAuE;QACvE,gFAAgF;QAChF,+BAA+B;KAClC,CAAC;IAEF,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACvB,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAClD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;gBAC7B,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;gBAClC,IAAI,KAAK,EAAE,CAAC;oBACR,sDAAsD;oBACtD,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;oBAC5B,IAAI,UAAU,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,aAAa,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;wBAC/F,UAAU,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;oBAC/B,CAAC;oBACD,MAAM;gBACV,CAAC;YACL,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CAAC,KAAe,EAAE,UAAkB;IAC1D,iFAAiF;IACjF,0EAA0E;IAC1E,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,UAAU,GAAG,CAAC,CAAC,CAAC;IAC/C,KAAK,IAAI,CAAC,GAAG,UAAU,GAAG,CAAC,EAAE,CAAC,IAAI,UAAU,EAAE,CAAC,EAAE,EAAE,CAAC;QAChD,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QACpC,4CAA4C;QAC5C,IAAI,IAAI,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAClF,MAAM;QACV,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ,CAAC,mBAAmB,CAAC,EAAE,CAAC;YACrC,gEAAgE;YAChE,IAAI,IAAI,CAAC,QAAQ,CAAC,uBAAuB,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,oBAAoB,CAAC,EAAE,CAAC;gBAChF,OAAO,IAAI,CAAC;YAChB,CAAC;QACL,CAAC;IACL,CAAC;IACD,OAAO,KAAK,CAAC;AACjB,CAAC;AAED;;GAEG;AACH,SAAS,iBAAiB,CACtB,QAAgB,EAChB,aAAqB;IAErB,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,CAAC;IACpD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAExC,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,SAAS,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,UAAU,GAAG,EAAE,CAAC,gBAAgB,CAAC,QAAQ,EAAE,OAAO,EAAE,EAAE,CAAC,YAAY,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;IAExF,MAAM,OAAO,GAAqF,EAAE,CAAC;IAErG,SAAS,KAAK,CAAC,IAAa;QACxB,IAAI,UAA8B,CAAC;QACnC,IAAI,SAA6B,CAAC;QAClC,IAAI,OAA2B,CAAC;QAEhC,IAAI,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YAC5C,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YACrD,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,uCAAuC;YACvC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7E,UAAU,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;gBAClD,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;gBACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;gBACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;gBAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,CAAC;QACL,CAAC;QAED,IAAI,UAAU,IAAI,SAAS,KAAK,SAAS,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YACjE,OAAO,CAAC,IAAI,CAAC;gBACT,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,SAAS;gBACf,KAAK,EAAE,OAAO,GAAG,SAAS,GAAG,CAAC;gBAC9B,iBAAiB,EAAE,iBAAiB,CAAC,SAAS,EAAE,SAAS,CAAC;aAC7D,CAAC,CAAC;QACP,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IACjC,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,CAAC;IAClB,OAAO,OAAO,CAAC;AACnB,CAAC;AAED;;GAEG;AACH,SAAS,cAAc,CACnB,aAAqB,EACrB,YAAsB,EACtB,IAAY,EACZ,QAAgB;IAEhB,MAAM,UAAU,GAAsB,EAAE,CAAC;IAEzC,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;QAC9B,iEAAiE;QACjE,MAAM,IAAI,GAAG,WAAW,CAAC,aAAa,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;QACpD,MAAM,cAAc,GAAG,6BAA6B,CAAC,IAAI,CAAC,CAAC;QAE3D,IAAI,cAAc,CAAC,IAAI,KAAK,CAAC;YAAE,SAAS;QAExC,mDAAmD;QACnD,MAAM,OAAO,GAAG,iBAAiB,CAAC,IAAI,EAAE,aAAa,CAAC,CAAC;QAEvD,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC3B,mEAAmE;YACnE,IAAI,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,KAAK,GAAG,QAAQ,IAAI,CAAC,MAAM,CAAC,iBAAiB,EAAE,CAAC;gBAC1F,UAAU,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,UAAU,EAAE,MAAM,CAAC,IAAI;oBACvB,IAAI,EAAE,MAAM,CAAC,IAAI;oBACjB,KAAK,EAAE,MAAM,CAAC,KAAK;oBACnB,KAAK,EAAE,IAAI;iBACd,CAAC,CAAC;YACP,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;GAGG;AACH,SAAS,UAAU,CAAC,aAAqB;IACrC,IAAI,CAAC;QACD,gDAAgD;QAChD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,iCAAiC,EAAE;YAC1D,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;YACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;SAClC,CAAC,CAAC,IAAI,EAAE,CAAC;QAEV,IAAI,SAAS,EAAE,CAAC;YACZ,OAAO,SAAS,CAAC;QACrB,CAAC;IACL,CAAC;IAAC,MAAM,CAAC;QACL,wCAAwC;QACxC,IAAI,CAAC;YACD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,0BAA0B,EAAE;gBACnD,GAAG,EAAE,aAAa;gBAClB,QAAQ,EAAE,OAAO;gBACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;aAClC,CAAC,CAAC,IAAI,EAAE,CAAC;YAEV,IAAI,SAAS,EAAE,CAAC;gBACZ,OAAO,SAAS,CAAC;YACrB,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACL,4BAA4B;QAChC,CAAC;IACL,CAAC;IACD,OAAO,IAAI,CAAC;AAChB,CAAC;AAED;;GAEG;AACH,SAAS,gBAAgB,CAAC,UAA6B,EAAE,QAAgB;IACrE,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,uBAAuB,GAAG,QAAQ,GAAG,SAAS,CAAC,CAAC;IAC9D,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,sEAAsE,CAAC,CAAC;IACtF,OAAO,CAAC,KAAK,CAAC,uDAAuD,CAAC,CAAC;IACvE,OAAO,CAAC,KAAK,CAAC,mBAAmB,GAAG,QAAQ,GAAG,yBAAyB,CAAC,CAAC;IAC1E,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,2GAA2G,CAAC,CAAC;IAC3H,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAElB,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;QACzB,OAAO,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QACzC,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,KAAK,gBAAgB,QAAQ,GAAG,CAAC,CAAC;IACvF,CAAC;IACD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,yCAAyC,GAAG,QAAQ,GAAG,uCAAuC,CAAC,CAAC;IAC9G,OAAO,CAAC,KAAK,CAAC,+EAA+E,CAAC,CAAC;IAC/F,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;AACtB,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,OAAkC,EAClC,OAAwB;IAExB,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IACnC,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,IAAI,EAAE,CAAC;IACnC,MAAM,IAAI,GAAmB,OAAO,CAAC,IAAI,IAAI,QAAQ,CAAC;IAEtD,0CAA0C;IAC1C,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;QACjB,OAAO,CAAC,GAAG,CAAC,4DAA4D,CAAC,CAAC;QAC1E,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAChB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;IAC7B,CAAC;IAED,gEAAgE;IAChE,wEAAwE;IACxE,0EAA0E;IAC1E,IAAI,IAAI,GAAG,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;IAElC,IAAI,CAAC,IAAI,EAAE,CAAC;QACR,8CAA8C;QAC9C,IAAI,GAAG,UAAU,CAAC,aAAa,CAAC,IAAI,SAAS,CAAC;QAE9C,IAAI,CAAC,IAAI,EAAE,CAAC;YACR,OAAO,CAAC,GAAG,CAAC,qEAAqE,CAAC,CAAC;YACnF,OAAO,CAAC,GAAG,CAAC,oFAAoF,CAAC,CAAC;YAClG,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAChB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,yDAAyD,CAAC,CAAC;IAC3E,CAAC;SAAM,CAAC;QACJ,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;IACtD,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC;IAChC,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;IAC5E,OAAO,CAAC,GAAG,CAAC,iCAAiC,QAAQ,EAAE,CAAC,CAAC;IACzD,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAEhB,IAAI,CAAC;QACD,wEAAwE;QACxE,MAAM,YAAY,GAAG,yBAAyB,CAAC,aAAa,EAAE,IAAI,CAAC,CAAC;QAEpE,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,+BAA+B,CAAC,CAAC;YAC7C,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,eAAe,YAAY,CAAC,MAAM,qBAAqB,CAAC,CAAC;QAErE,kBAAkB;QAClB,MAAM,UAAU,GAAG,cAAc,CAAC,aAAa,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,CAAC,CAAC;QAE/E,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,8BAA8B,GAAG,QAAQ,GAAG,QAAQ,CAAC,CAAC;YAClE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,gDAAgD;QAChD,oBAAoB,CAAC,aAAa,CAAC,CAAC;QACpC,gBAAgB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAEvC,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC;QAClE,OAAO,CAAC,KAAK,CAAC,iCAAiC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAChE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate New Methods Executor\n *\n * Validates that newly added methods don't exceed a maximum line count.\n * Runs in affected mode when:\n *   1. NX_BASE environment variable is set (via nx affected), OR\n *   2. Auto-detects base by finding merge-base with origin/main\n *\n * This validator encourages writing methods that read like a \"table of contents\"\n * where each method call describes a larger piece of work.\n *\n * Usage:\n * nx affected --target=validate-new-methods --base=origin/main\n * OR: runs automatically via build's architecture:validate-complete dependency\n *\n * Escape hatch: Add webpieces-disable max-lines-new-methods comment with justification\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { execSync } from 'child_process';\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport * as ts from 'typescript';\n\nexport type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';\n\nexport interface ValidateNewMethodsOptions {\n    max?: number;\n    mode?: ValidationMode;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\ninterface MethodViolation {\n    file: string;\n    methodName: string;\n    line: number;\n    lines: number;\n    isNew: boolean;\n}\n\nconst TMP_DIR = 'tmp/webpieces';\nconst TMP_MD_FILE = 'webpieces.methodsize.md';\n\nconst METHODSIZE_DOC_CONTENT = `# Instructions: New Method Too Long\n\n## Requirement\n\n**~50% of the time**, you can stay under the \\`newMethodsMaxLines\\` limit from nx.json\nby extracting logical units into well-named methods.\n\n**~99% of the time**, you can stay under the \\`modifiedAndNewMethodsMaxLines\\` limit from nx.json.\nNearly all software can be written with methods under this size.\n\n## The \"Table of Contents\" Principle\n\nGood code reads like a book's table of contents:\n- Chapter titles (method names) tell you WHAT happens\n- Reading chapter titles gives you the full story\n- You can dive into chapters (implementations) for details\n\n## Why Limit New Methods?\n\nMethods under the limit are:\n- Easy to review in a single screen\n- Simple to understand without scrolling\n- Quick for AI to analyze and suggest improvements\n- More testable in isolation\n- Self-documenting through well-named extracted methods\n\nExtracting logical units into well-named methods makes code more readable for both\nAI and humans.\n\n## How to Refactor\n\nInstead of:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    // 50 lines of validation, transformation, saving, notifications...\n}\n\\`\\`\\`\n\nWrite:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    const validated = this.validateOrder(order);\n    const transformed = this.applyBusinessRules(validated);\n    const saved = await this.saveToDatabase(transformed);\n    await this.notifyStakeholders(saved);\n    return this.buildResult(saved);\n}\n\\`\\`\\`\n\nNow the main method is a \"table of contents\" - each line tells part of the story!\n\n## Patterns for Extraction\n\n### Pattern 1: Extract Loop Bodies\n\\`\\`\\`typescript\n// BEFORE\nfor (const item of items) {\n    // 20 lines of processing\n}\n\n// AFTER\nfor (const item of items) {\n    this.processItem(item);\n}\n\\`\\`\\`\n\n### Pattern 2: Extract Conditional Blocks\n\\`\\`\\`typescript\n// BEFORE\nif (isAdmin(user)) {\n    // 15 lines of admin logic\n}\n\n// AFTER\nif (isAdmin(user)) {\n    this.handleAdminUser(user);\n}\n\\`\\`\\`\n\n### Pattern 3: Extract Data Transformations\n\\`\\`\\`typescript\n// BEFORE\nconst result = {\n    // 10+ lines of object construction\n};\n\n// AFTER\nconst result = this.buildResultObject(data);\n\\`\\`\\`\n\n## If Refactoring Is Not Feasible\n\nSometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).\n\n**Escape hatch**: Add a webpieces-disable comment with justification:\n\n\\`\\`\\`typescript\n// webpieces-disable max-lines-new-methods -- Complex state machine, splitting reduces clarity\nasync complexStateMachine(): Promise<void> {\n    // ... longer method with justification\n}\n\\`\\`\\`\n\n## AI Agent Action Steps\n\n1. **READ** the method to understand its logical sections\n2. **IDENTIFY** logical units that can be extracted\n3. **EXTRACT** into well-named private methods\n4. **VERIFY** the main method now reads like a table of contents\n5. **IF NOT FEASIBLE**: Add webpieces-disable max-lines-new-methods comment with clear justification\n\n## Remember\n\n- Every method you write today will be read many times tomorrow\n- The best code explains itself through structure\n- When in doubt, extract and name it\n`;\n\n/**\n * Write the instructions documentation to tmp directory\n */\nfunction writeTmpInstructions(workspaceRoot: string): string {\n    const tmpDir = path.join(workspaceRoot, TMP_DIR);\n    const mdPath = path.join(tmpDir, TMP_MD_FILE);\n\n    fs.mkdirSync(tmpDir, { recursive: true });\n    fs.writeFileSync(mdPath, METHODSIZE_DOC_CONTENT);\n\n    return mdPath;\n}\n\n/**\n * Get changed TypeScript files between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getChangedTypeScriptFiles(workspaceRoot: string, base: string): string[] {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        const output = execSync(`git diff --name-only ${base} -- '*.ts' '*.tsx'`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n        return output\n            .trim()\n            .split('\\n')\n            .filter((f) => f && !f.includes('.spec.ts') && !f.includes('.test.ts'));\n    } catch {\n        return [];\n    }\n}\n\n/**\n * Get the diff content for a specific file between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getFileDiff(workspaceRoot: string, file: string, base: string): string {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        return execSync(`git diff ${base} -- \"${file}\"`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n    } catch {\n        return '';\n    }\n}\n\n/**\n * Parse diff to find newly added method signatures\n */\nfunction findNewMethodSignaturesInDiff(diffContent: string): Set<string> {\n    const newMethods = new Set<string>();\n    const lines = diffContent.split('\\n');\n\n    // Patterns to match method definitions\n    const patterns = [\n        // [export] [async] function methodName( - most explicit, check first\n        /^\\+\\s*(?:export\\s+)?(?:async\\s+)?function\\s+(\\w+)\\s*\\(/,\n        // [export] const/let methodName = [async] (\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s*)?\\(/,\n        // [export] const/let methodName = [async] function\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s+)?function/,\n        // class method: [async] methodName( - but NOT constructor, if, for, while, etc.\n        /^\\+\\s*(?:async\\s+)?(\\w+)\\s*\\(/,\n    ];\n\n    for (const line of lines) {\n        if (line.startsWith('+') && !line.startsWith('+++')) {\n            for (const pattern of patterns) {\n                const match = line.match(pattern);\n                if (match) {\n                    // Extract method name - now always in capture group 1\n                    const methodName = match[1];\n                    if (methodName && !['if', 'for', 'while', 'switch', 'catch', 'constructor'].includes(methodName)) {\n                        newMethods.add(methodName);\n                    }\n                    break;\n                }\n            }\n        }\n    }\n\n    return newMethods;\n}\n\n/**\n * Check if a line contains a webpieces-disable comment that exempts from new method validation.\n * Both max-lines-new-methods AND max-lines-modified are accepted here.\n * - max-lines-new-methods: Exempts from 30-line check, still checked by 80-line validator\n * - max-lines-modified: Exempts from both validators (ultimate escape hatch)\n */\nfunction hasDisableComment(lines: string[], lineNumber: number): boolean {\n    // Check the line before the method (lineNumber is 1-indexed, array is 0-indexed)\n    // We need to check a few lines before in case there's JSDoc or decorators\n    const startCheck = Math.max(0, lineNumber - 5);\n    for (let i = lineNumber - 2; i >= startCheck; i--) {\n        const line = lines[i]?.trim() ?? '';\n        // Stop if we hit another function/class/etc\n        if (line.startsWith('function ') || line.startsWith('class ') || line.endsWith('}')) {\n            break;\n        }\n        if (line.includes('webpieces-disable')) {\n            // Either escape hatch exempts from the 30-line new method check\n            if (line.includes('max-lines-new-methods') || line.includes('max-lines-modified')) {\n                return true;\n            }\n        }\n    }\n    return false;\n}\n\n/**\n * Parse a TypeScript file and find methods with their line counts\n */\nfunction findMethodsInFile(\n    filePath: string,\n    workspaceRoot: string\n): Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> {\n    const fullPath = path.join(workspaceRoot, filePath);\n    if (!fs.existsSync(fullPath)) return [];\n\n    const content = fs.readFileSync(fullPath, 'utf-8');\n    const fileLines = content.split('\\n');\n    const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);\n\n    const methods: Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> = [];\n\n    function visit(node: ts.Node): void {\n        let methodName: string | undefined;\n        let startLine: number | undefined;\n        let endLine: number | undefined;\n\n        if (ts.isMethodDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isFunctionDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isArrowFunction(node)) {\n            // Check if it's assigned to a variable\n            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {\n                methodName = node.parent.name.getText(sourceFile);\n                const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n                const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n                startLine = start.line + 1;\n                endLine = end.line + 1;\n            }\n        }\n\n        if (methodName && startLine !== undefined && endLine !== undefined) {\n            methods.push({\n                name: methodName,\n                line: startLine,\n                lines: endLine - startLine + 1,\n                hasDisableComment: hasDisableComment(fileLines, startLine),\n            });\n        }\n\n        ts.forEachChild(node, visit);\n    }\n\n    visit(sourceFile);\n    return methods;\n}\n\n/**\n * Find new methods that exceed the line limit\n */\nfunction findViolations(\n    workspaceRoot: string,\n    changedFiles: string[],\n    base: string,\n    maxLines: number\n): MethodViolation[] {\n    const violations: MethodViolation[] = [];\n\n    for (const file of changedFiles) {\n        // Get the diff to find which methods are NEW (not just modified)\n        const diff = getFileDiff(workspaceRoot, file, base);\n        const newMethodNames = findNewMethodSignaturesInDiff(diff);\n\n        if (newMethodNames.size === 0) continue;\n\n        // Parse the current file to get method line counts\n        const methods = findMethodsInFile(file, workspaceRoot);\n\n        for (const method of methods) {\n            // Only check NEW methods that don't have webpieces-disable comment\n            if (newMethodNames.has(method.name) && method.lines > maxLines && !method.hasDisableComment) {\n                violations.push({\n                    file,\n                    methodName: method.name,\n                    line: method.line,\n                    lines: method.lines,\n                    isNew: true,\n                });\n            }\n        }\n    }\n\n    return violations;\n}\n\n/**\n * Auto-detect the base branch by finding the merge-base with origin/main.\n * This allows the executor to run even when NX_BASE isn't set (e.g., via dependsOn).\n */\nfunction detectBase(workspaceRoot: string): string | null {\n    try {\n        // First, try to get merge-base with origin/main\n        const mergeBase = execSync('git merge-base HEAD origin/main', {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n            stdio: ['pipe', 'pipe', 'pipe'],\n        }).trim();\n\n        if (mergeBase) {\n            return mergeBase;\n        }\n    } catch {\n        // origin/main might not exist, try main\n        try {\n            const mergeBase = execSync('git merge-base HEAD main', {\n                cwd: workspaceRoot,\n                encoding: 'utf-8',\n                stdio: ['pipe', 'pipe', 'pipe'],\n            }).trim();\n\n            if (mergeBase) {\n                return mergeBase;\n            }\n        } catch {\n            // Ignore - will return null\n        }\n    }\n    return null;\n}\n\n/**\n * Report violations to the user with helpful instructions\n */\nfunction reportViolations(violations: MethodViolation[], maxLines: number): void {\n    console.error('');\n    console.error('❌ New methods exceed ' + maxLines + ' lines!');\n    console.error('');\n    console.error('📚 Methods should read like a \"table of contents\" - each method call');\n    console.error('   describes a larger piece of work. You can refactor');\n    console.error('   to stay under ' + maxLines + ' lines 50% of the time.');\n    console.error('');\n    console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');\n    console.error('');\n\n    for (const v of violations) {\n        console.error(`  ❌ ${v.file}:${v.line}`);\n        console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);\n    }\n    console.error('');\n    console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');\n    console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');\n    console.error('');\n}\n\nexport default async function runExecutor(\n    options: ValidateNewMethodsOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const workspaceRoot = context.root;\n    const maxLines = options.max ?? 30;\n    const mode: ValidationMode = options.mode ?? 'NORMAL';\n\n    // Skip validation entirely if mode is OFF\n    if (mode === 'OFF') {\n        console.log('\\n⏭️  Skipping new method validation (validationMode: OFF)');\n        console.log('');\n        return { success: true };\n    }\n\n    // Check if running in affected mode via NX_BASE, or auto-detect\n    // We use NX_BASE as the base, and compare to WORKING TREE (not NX_HEAD)\n    // This matches what `nx affected` does - it compares base to working tree\n    let base = process.env['NX_BASE'];\n\n    if (!base) {\n        // Try to auto-detect base from git merge-base\n        base = detectBase(workspaceRoot) ?? undefined;\n\n        if (!base) {\n            console.log('\\n⏭️  Skipping new method validation (could not detect base branch)');\n            console.log('   To run explicitly: nx affected --target=validate-new-methods --base=origin/main');\n            console.log('');\n            return { success: true };\n        }\n\n        console.log('\\n📏 Validating New Method Sizes (auto-detected base)\\n');\n    } else {\n        console.log('\\n📏 Validating New Method Sizes\\n');\n    }\n\n    console.log(`   Base: ${base}`);\n    console.log(`   Comparing to: working tree (includes uncommitted changes)`);\n    console.log(`   Max lines for new methods: ${maxLines}`);\n    console.log('');\n\n    try {\n        // Get changed TypeScript files (base to working tree, like nx affected)\n        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base);\n\n        if (changedFiles.length === 0) {\n            console.log('✅ No TypeScript files changed');\n            return { success: true };\n        }\n\n        console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);\n\n        // Find violations\n        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);\n\n        if (violations.length === 0) {\n            console.log('✅ All new methods are under ' + maxLines + ' lines');\n            return { success: true };\n        }\n\n        // Write instructions file and report violations\n        writeTmpInstructions(workspaceRoot);\n        reportViolations(violations, maxLines);\n\n        return { success: false };\n    } catch (err: unknown) {\n        const error = err instanceof Error ? err : new Error(String(err));\n        console.error('❌ New method validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/dev-config/architecture/executors/validate-new-methods/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;GAgBG;;AA+cH,8BA6EC;;AAzhBD,iDAAyC;AACzC,+CAAyB;AACzB,mDAA6B;AAC7B,uDAAiC;AAwBjC,MAAM,OAAO,GAAG,eAAe,CAAC;AAChC,MAAM,WAAW,GAAG,yBAAyB,CAAC;AAE9C,MAAM,sBAAsB,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAoH9B,CAAC;AAEF;;GAEG;AACH,SAAS,oBAAoB,CAAC,aAAqB;IAC/C,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,OAAO,CAAC,CAAC;IACjD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;IAE9C,EAAE,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC1C,EAAE,CAAC,aAAa,CAAC,MAAM,EAAE,sBAAsB,CAAC,CAAC;IAEjD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;;;GAIG;AACH,SAAS,yBAAyB,CAAC,aAAqB,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,MAAM,MAAM,GAAG,IAAA,wBAAQ,EAAC,wBAAwB,IAAI,oBAAoB,EAAE;YACtE,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;QACH,OAAO,MAAM;aACR,IAAI,EAAE;aACN,KAAK,CAAC,IAAI,CAAC;aACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC;IAChF,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;;;GAIG;AACH,SAAS,WAAW,CAAC,aAAqB,EAAE,IAAY,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,OAAO,IAAA,wBAAQ,EAAC,YAAY,IAAI,QAAQ,IAAI,GAAG,EAAE;YAC7C,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;IACP,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;GAEG;AACH,SAAS,6BAA6B,CAAC,WAAmB;IACtD,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAEtC,uCAAuC;IACvC,MAAM,QAAQ,GAAG;QACb,qEAAqE;QACrE,wDAAwD;QACxD,4CAA4C;QAC5C,iEAAiE;QACjE,mDAAmD;QACnD,uEAAuE;QACvE,gFAAgF;QAChF,+BAA+B;KAClC,CAAC;IAEF,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACvB,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAClD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;gBAC7B,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;gBAClC,IAAI,KAAK,EAAE,CAAC;oBACR,sDAAsD;oBACtD,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;oBAC5B,IAAI,UAAU,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,aAAa,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;wBAC/F,UAAU,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;oBAC/B,CAAC;oBACD,MAAM;gBACV,CAAC;YACL,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CAAC,KAAe,EAAE,UAAkB;IAC1D,iFAAiF;IACjF,0EAA0E;IAC1E,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,UAAU,GAAG,CAAC,CAAC,CAAC;IAC/C,KAAK,IAAI,CAAC,GAAG,UAAU,GAAG,CAAC,EAAE,CAAC,IAAI,UAAU,EAAE,CAAC,EAAE,EAAE,CAAC;QAChD,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QACpC,4CAA4C;QAC5C,IAAI,IAAI,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAClF,MAAM;QACV,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ,CAAC,mBAAmB,CAAC,EAAE,CAAC;YACrC,gEAAgE;YAChE,IAAI,IAAI,CAAC,QAAQ,CAAC,uBAAuB,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,oBAAoB,CAAC,EAAE,CAAC;gBAChF,OAAO,IAAI,CAAC;YAChB,CAAC;QACL,CAAC;IACL,CAAC;IACD,OAAO,KAAK,CAAC;AACjB,CAAC;AAED;;GAEG;AACH,SAAS,iBAAiB,CACtB,QAAgB,EAChB,aAAqB;IAErB,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,CAAC;IACpD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAExC,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,SAAS,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,UAAU,GAAG,EAAE,CAAC,gBAAgB,CAAC,QAAQ,EAAE,OAAO,EAAE,EAAE,CAAC,YAAY,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;IAExF,MAAM,OAAO,GAAqF,EAAE,CAAC;IAErG,SAAS,KAAK,CAAC,IAAa;QACxB,IAAI,UAA8B,CAAC;QACnC,IAAI,SAA6B,CAAC;QAClC,IAAI,OAA2B,CAAC;QAEhC,IAAI,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YAC5C,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YACrD,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,uCAAuC;YACvC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7E,UAAU,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;gBAClD,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;gBACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;gBACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;gBAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,CAAC;QACL,CAAC;QAED,IAAI,UAAU,IAAI,SAAS,KAAK,SAAS,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YACjE,OAAO,CAAC,IAAI,CAAC;gBACT,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,SAAS;gBACf,KAAK,EAAE,OAAO,GAAG,SAAS,GAAG,CAAC;gBAC9B,iBAAiB,EAAE,iBAAiB,CAAC,SAAS,EAAE,SAAS,CAAC;aAC7D,CAAC,CAAC;QACP,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IACjC,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,CAAC;IAClB,OAAO,OAAO,CAAC;AACnB,CAAC;AAED;;GAEG;AACH,SAAS,cAAc,CACnB,aAAqB,EACrB,YAAsB,EACtB,IAAY,EACZ,QAAgB,EAChB,cAAuB;IAEvB,MAAM,UAAU,GAAsB,EAAE,CAAC;IAEzC,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;QAC9B,iEAAiE;QACjE,MAAM,IAAI,GAAG,WAAW,CAAC,aAAa,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;QACpD,MAAM,cAAc,GAAG,6BAA6B,CAAC,IAAI,CAAC,CAAC;QAE3D,IAAI,cAAc,CAAC,IAAI,KAAK,CAAC;YAAE,SAAS;QAExC,mDAAmD;QACnD,MAAM,OAAO,GAAG,iBAAiB,CAAC,IAAI,EAAE,aAAa,CAAC,CAAC;QAEvD,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC3B,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC;gBAAE,SAAS;YAE/C,2DAA2D;YAC3D,IAAI,cAAc,IAAI,MAAM,CAAC,KAAK,GAAG,cAAc,EAAE,CAAC;gBAClD,UAAU,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,UAAU,EAAE,MAAM,CAAC,IAAI;oBACvB,IAAI,EAAE,MAAM,CAAC,IAAI;oBACjB,KAAK,EAAE,MAAM,CAAC,KAAK;oBACnB,KAAK,EAAE,IAAI;oBACX,WAAW,EAAE,IAAI;oBACjB,KAAK,EAAE,cAAc;iBACxB,CAAC,CAAC;YACP,CAAC;YACD,yDAAyD;iBACpD,IAAI,MAAM,CAAC,KAAK,GAAG,QAAQ,IAAI,CAAC,MAAM,CAAC,iBAAiB,EAAE,CAAC;gBAC5D,UAAU,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,UAAU,EAAE,MAAM,CAAC,IAAI;oBACvB,IAAI,EAAE,MAAM,CAAC,IAAI;oBACjB,KAAK,EAAE,MAAM,CAAC,KAAK;oBACnB,KAAK,EAAE,IAAI;oBACX,WAAW,EAAE,KAAK;oBAClB,KAAK,EAAE,QAAQ;iBAClB,CAAC,CAAC;YACP,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;GAGG;AACH,SAAS,UAAU,CAAC,aAAqB;IACrC,IAAI,CAAC;QACD,gDAAgD;QAChD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,iCAAiC,EAAE;YAC1D,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;YACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;SAClC,CAAC,CAAC,IAAI,EAAE,CAAC;QAEV,IAAI,SAAS,EAAE,CAAC;YACZ,OAAO,SAAS,CAAC;QACrB,CAAC;IACL,CAAC;IAAC,MAAM,CAAC;QACL,wCAAwC;QACxC,IAAI,CAAC;YACD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,0BAA0B,EAAE;gBACnD,GAAG,EAAE,aAAa;gBAClB,QAAQ,EAAE,OAAO;gBACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;aAClC,CAAC,CAAC,IAAI,EAAE,CAAC;YAEV,IAAI,SAAS,EAAE,CAAC;gBACZ,OAAO,SAAS,CAAC;YACrB,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACL,4BAA4B;QAChC,CAAC;IACL,CAAC;IACD,OAAO,IAAI,CAAC;AAChB,CAAC;AAED;;GAEG;AACH,2HAA2H;AAC3H,SAAS,gBAAgB,CAAC,UAA6B,EAAE,QAAgB,EAAE,cAAuB;IAC9F,MAAM,cAAc,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC;IAC/D,MAAM,cAAc,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC;IAEhE,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,mCAAmC,CAAC,CAAC;IACnD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,sEAAsE,CAAC,CAAC;IACtF,OAAO,CAAC,KAAK,CAAC,uDAAuD,CAAC,CAAC;IACvE,OAAO,CAAC,KAAK,CAAC,mBAAmB,GAAG,QAAQ,GAAG,yBAAyB,CAAC,CAAC;IAC1E,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,2GAA2G,CAAC,CAAC;IAC3H,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAElB,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5B,OAAO,CAAC,KAAK,CAAC,qEAAqE,CAAC,CAAC;QACrF,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,KAAK,MAAM,CAAC,IAAI,cAAc,EAAE,CAAC;YAC7B,OAAO,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;YACzC,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,KAAK,qBAAqB,cAAc,GAAG,CAAC,CAAC;QAClG,CAAC;QACD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CAAC,kEAAkE,CAAC,CAAC;QAClF,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IACtB,CAAC;IAED,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5B,OAAO,CAAC,KAAK,CAAC,mEAAmE,CAAC,CAAC;QACnF,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,KAAK,MAAM,CAAC,IAAI,cAAc,EAAE,CAAC;YAC7B,OAAO,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;YACzC,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,KAAK,qBAAqB,QAAQ,GAAG,CAAC,CAAC;QAC5F,CAAC;QACD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CAAC,yCAAyC,GAAG,QAAQ,GAAG,uCAAuC,CAAC,CAAC;QAC9G,OAAO,CAAC,KAAK,CAAC,+EAA+E,CAAC,CAAC;QAC/F,IAAI,cAAc,EAAE,CAAC;YACjB,OAAO,CAAC,KAAK,CAAC,kEAAkE,cAAc,SAAS,CAAC,CAAC;QAC7G,CAAC;QACD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IACtB,CAAC;AACL,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,OAAkC,EAClC,OAAwB;IAExB,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IACnC,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,IAAI,EAAE,CAAC;IACnC,MAAM,cAAc,GAAG,OAAO,CAAC,SAAS,CAAC;IACzC,MAAM,IAAI,GAAmB,OAAO,CAAC,IAAI,IAAI,QAAQ,CAAC;IAEtD,0CAA0C;IAC1C,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;QACjB,OAAO,CAAC,GAAG,CAAC,4DAA4D,CAAC,CAAC;QAC1E,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAChB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;IAC7B,CAAC;IAED,gEAAgE;IAChE,wEAAwE;IACxE,0EAA0E;IAC1E,IAAI,IAAI,GAAG,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;IAElC,IAAI,CAAC,IAAI,EAAE,CAAC;QACR,8CAA8C;QAC9C,IAAI,GAAG,UAAU,CAAC,aAAa,CAAC,IAAI,SAAS,CAAC;QAE9C,IAAI,CAAC,IAAI,EAAE,CAAC;YACR,OAAO,CAAC,GAAG,CAAC,qEAAqE,CAAC,CAAC;YACnF,OAAO,CAAC,GAAG,CAAC,oFAAoF,CAAC,CAAC;YAClG,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAChB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,yDAAyD,CAAC,CAAC;IAC3E,CAAC;SAAM,CAAC;QACJ,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;IACtD,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC;IAChC,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;IAC5E,OAAO,CAAC,GAAG,CAAC,kCAAkC,QAAQ,0CAA0C,CAAC,CAAC;IAClG,IAAI,cAAc,EAAE,CAAC;QACjB,OAAO,CAAC,GAAG,CAAC,kCAAkC,cAAc,6BAA6B,CAAC,CAAC;IAC/F,CAAC;IACD,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAEhB,IAAI,CAAC;QACD,wEAAwE;QACxE,MAAM,YAAY,GAAG,yBAAyB,CAAC,aAAa,EAAE,IAAI,CAAC,CAAC;QAEpE,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,+BAA+B,CAAC,CAAC;YAC7C,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,eAAe,YAAY,CAAC,MAAM,qBAAqB,CAAC,CAAC;QAErE,kBAAkB;QAClB,MAAM,UAAU,GAAG,cAAc,CAAC,aAAa,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,EAAE,cAAc,CAAC,CAAC;QAE/F,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC1B,MAAM,QAAQ,GAAG,cAAc;gBAC3B,CAAC,CAAC,eAAe,QAAQ,oBAAoB,cAAc,GAAG;gBAC9D,CAAC,CAAC,GAAG,QAAQ,QAAQ,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,+BAA+B,GAAG,QAAQ,CAAC,CAAC;YACxD,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,gDAAgD;QAChD,oBAAoB,CAAC,aAAa,CAAC,CAAC;QACpC,gBAAgB,CAAC,UAAU,EAAE,QAAQ,EAAE,cAAc,CAAC,CAAC;QAEvD,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC;QAClE,OAAO,CAAC,KAAK,CAAC,iCAAiC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAChE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate New Methods Executor\n *\n * Validates that newly added methods don't exceed a maximum line count.\n * Runs in affected mode when:\n *   1. NX_BASE environment variable is set (via nx affected), OR\n *   2. Auto-detects base by finding merge-base with origin/main\n *\n * This validator encourages writing methods that read like a \"table of contents\"\n * where each method call describes a larger piece of work.\n *\n * Usage:\n * nx affected --target=validate-new-methods --base=origin/main\n * OR: runs automatically via build's architecture:validate-complete dependency\n *\n * Escape hatch: Add webpieces-disable max-lines-new-methods comment with justification\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { execSync } from 'child_process';\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport * as ts from 'typescript';\n\nexport type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';\n\nexport interface ValidateNewMethodsOptions {\n    max?: number;\n    strictMax?: number;\n    mode?: ValidationMode;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\ninterface MethodViolation {\n    file: string;\n    methodName: string;\n    line: number;\n    lines: number;\n    isNew: boolean;\n    isHardLimit: boolean;\n    limit: number;\n}\n\nconst TMP_DIR = 'tmp/webpieces';\nconst TMP_MD_FILE = 'webpieces.methodsize.md';\n\nconst METHODSIZE_DOC_CONTENT = `# Instructions: New Method Too Long\n\n## Requirement\n\n**~50% of the time**, you can stay under the \\`newMethodsMaxLines\\` limit from nx.json\nby extracting logical units into well-named methods.\n\n**~99% of the time**, you can stay under the \\`modifiedAndNewMethodsMaxLines\\` limit from nx.json.\nNearly all software can be written with methods under this size.\n\n## The \"Table of Contents\" Principle\n\nGood code reads like a book's table of contents:\n- Chapter titles (method names) tell you WHAT happens\n- Reading chapter titles gives you the full story\n- You can dive into chapters (implementations) for details\n\n## Why Limit New Methods?\n\nMethods under the limit are:\n- Easy to review in a single screen\n- Simple to understand without scrolling\n- Quick for AI to analyze and suggest improvements\n- More testable in isolation\n- Self-documenting through well-named extracted methods\n\nExtracting logical units into well-named methods makes code more readable for both\nAI and humans.\n\n## How to Refactor\n\nInstead of:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    // 50 lines of validation, transformation, saving, notifications...\n}\n\\`\\`\\`\n\nWrite:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    const validated = this.validateOrder(order);\n    const transformed = this.applyBusinessRules(validated);\n    const saved = await this.saveToDatabase(transformed);\n    await this.notifyStakeholders(saved);\n    return this.buildResult(saved);\n}\n\\`\\`\\`\n\nNow the main method is a \"table of contents\" - each line tells part of the story!\n\n## Patterns for Extraction\n\n### Pattern 1: Extract Loop Bodies\n\\`\\`\\`typescript\n// BEFORE\nfor (const item of items) {\n    // 20 lines of processing\n}\n\n// AFTER\nfor (const item of items) {\n    this.processItem(item);\n}\n\\`\\`\\`\n\n### Pattern 2: Extract Conditional Blocks\n\\`\\`\\`typescript\n// BEFORE\nif (isAdmin(user)) {\n    // 15 lines of admin logic\n}\n\n// AFTER\nif (isAdmin(user)) {\n    this.handleAdminUser(user);\n}\n\\`\\`\\`\n\n### Pattern 3: Extract Data Transformations\n\\`\\`\\`typescript\n// BEFORE\nconst result = {\n    // 10+ lines of object construction\n};\n\n// AFTER\nconst result = this.buildResultObject(data);\n\\`\\`\\`\n\n## If Refactoring Is Not Feasible\n\nSometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).\n\n**Escape hatch**: Add a webpieces-disable comment with justification:\n\n\\`\\`\\`typescript\n// webpieces-disable max-lines-new-methods -- Complex state machine, splitting reduces clarity\nasync complexStateMachine(): Promise<void> {\n    // ... longer method with justification\n}\n\\`\\`\\`\n\n## AI Agent Action Steps\n\n1. **READ** the method to understand its logical sections\n2. **IDENTIFY** logical units that can be extracted\n3. **EXTRACT** into well-named private methods\n4. **VERIFY** the main method now reads like a table of contents\n5. **IF NOT FEASIBLE**: Add webpieces-disable max-lines-new-methods comment with clear justification\n\n## Remember\n\n- Every method you write today will be read many times tomorrow\n- The best code explains itself through structure\n- When in doubt, extract and name it\n`;\n\n/**\n * Write the instructions documentation to tmp directory\n */\nfunction writeTmpInstructions(workspaceRoot: string): string {\n    const tmpDir = path.join(workspaceRoot, TMP_DIR);\n    const mdPath = path.join(tmpDir, TMP_MD_FILE);\n\n    fs.mkdirSync(tmpDir, { recursive: true });\n    fs.writeFileSync(mdPath, METHODSIZE_DOC_CONTENT);\n\n    return mdPath;\n}\n\n/**\n * Get changed TypeScript files between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getChangedTypeScriptFiles(workspaceRoot: string, base: string): string[] {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        const output = execSync(`git diff --name-only ${base} -- '*.ts' '*.tsx'`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n        return output\n            .trim()\n            .split('\\n')\n            .filter((f) => f && !f.includes('.spec.ts') && !f.includes('.test.ts'));\n    } catch {\n        return [];\n    }\n}\n\n/**\n * Get the diff content for a specific file between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getFileDiff(workspaceRoot: string, file: string, base: string): string {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        return execSync(`git diff ${base} -- \"${file}\"`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n    } catch {\n        return '';\n    }\n}\n\n/**\n * Parse diff to find newly added method signatures\n */\nfunction findNewMethodSignaturesInDiff(diffContent: string): Set<string> {\n    const newMethods = new Set<string>();\n    const lines = diffContent.split('\\n');\n\n    // Patterns to match method definitions\n    const patterns = [\n        // [export] [async] function methodName( - most explicit, check first\n        /^\\+\\s*(?:export\\s+)?(?:async\\s+)?function\\s+(\\w+)\\s*\\(/,\n        // [export] const/let methodName = [async] (\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s*)?\\(/,\n        // [export] const/let methodName = [async] function\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s+)?function/,\n        // class method: [async] methodName( - but NOT constructor, if, for, while, etc.\n        /^\\+\\s*(?:async\\s+)?(\\w+)\\s*\\(/,\n    ];\n\n    for (const line of lines) {\n        if (line.startsWith('+') && !line.startsWith('+++')) {\n            for (const pattern of patterns) {\n                const match = line.match(pattern);\n                if (match) {\n                    // Extract method name - now always in capture group 1\n                    const methodName = match[1];\n                    if (methodName && !['if', 'for', 'while', 'switch', 'catch', 'constructor'].includes(methodName)) {\n                        newMethods.add(methodName);\n                    }\n                    break;\n                }\n            }\n        }\n    }\n\n    return newMethods;\n}\n\n/**\n * Check if a line contains a webpieces-disable comment that exempts from new method validation.\n * Both max-lines-new-methods AND max-lines-modified are accepted here.\n * - max-lines-new-methods: Exempts from 30-line check, still checked by 80-line validator\n * - max-lines-modified: Exempts from both validators (ultimate escape hatch)\n */\nfunction hasDisableComment(lines: string[], lineNumber: number): boolean {\n    // Check the line before the method (lineNumber is 1-indexed, array is 0-indexed)\n    // We need to check a few lines before in case there's JSDoc or decorators\n    const startCheck = Math.max(0, lineNumber - 5);\n    for (let i = lineNumber - 2; i >= startCheck; i--) {\n        const line = lines[i]?.trim() ?? '';\n        // Stop if we hit another function/class/etc\n        if (line.startsWith('function ') || line.startsWith('class ') || line.endsWith('}')) {\n            break;\n        }\n        if (line.includes('webpieces-disable')) {\n            // Either escape hatch exempts from the 30-line new method check\n            if (line.includes('max-lines-new-methods') || line.includes('max-lines-modified')) {\n                return true;\n            }\n        }\n    }\n    return false;\n}\n\n/**\n * Parse a TypeScript file and find methods with their line counts\n */\nfunction findMethodsInFile(\n    filePath: string,\n    workspaceRoot: string\n): Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> {\n    const fullPath = path.join(workspaceRoot, filePath);\n    if (!fs.existsSync(fullPath)) return [];\n\n    const content = fs.readFileSync(fullPath, 'utf-8');\n    const fileLines = content.split('\\n');\n    const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);\n\n    const methods: Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> = [];\n\n    function visit(node: ts.Node): void {\n        let methodName: string | undefined;\n        let startLine: number | undefined;\n        let endLine: number | undefined;\n\n        if (ts.isMethodDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isFunctionDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isArrowFunction(node)) {\n            // Check if it's assigned to a variable\n            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {\n                methodName = node.parent.name.getText(sourceFile);\n                const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n                const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n                startLine = start.line + 1;\n                endLine = end.line + 1;\n            }\n        }\n\n        if (methodName && startLine !== undefined && endLine !== undefined) {\n            methods.push({\n                name: methodName,\n                line: startLine,\n                lines: endLine - startLine + 1,\n                hasDisableComment: hasDisableComment(fileLines, startLine),\n            });\n        }\n\n        ts.forEachChild(node, visit);\n    }\n\n    visit(sourceFile);\n    return methods;\n}\n\n/**\n * Find new methods that exceed the line limit\n */\nfunction findViolations(\n    workspaceRoot: string,\n    changedFiles: string[],\n    base: string,\n    maxLines: number,\n    strictMaxLines?: number\n): MethodViolation[] {\n    const violations: MethodViolation[] = [];\n\n    for (const file of changedFiles) {\n        // Get the diff to find which methods are NEW (not just modified)\n        const diff = getFileDiff(workspaceRoot, file, base);\n        const newMethodNames = findNewMethodSignaturesInDiff(diff);\n\n        if (newMethodNames.size === 0) continue;\n\n        // Parse the current file to get method line counts\n        const methods = findMethodsInFile(file, workspaceRoot);\n\n        for (const method of methods) {\n            if (!newMethodNames.has(method.name)) continue;\n\n            // Check hard limit first (if defined) - NO escape possible\n            if (strictMaxLines && method.lines > strictMaxLines) {\n                violations.push({\n                    file,\n                    methodName: method.name,\n                    line: method.line,\n                    lines: method.lines,\n                    isNew: true,\n                    isHardLimit: true,\n                    limit: strictMaxLines,\n                });\n            }\n            // Check soft limit - can be escaped with disable comment\n            else if (method.lines > maxLines && !method.hasDisableComment) {\n                violations.push({\n                    file,\n                    methodName: method.name,\n                    line: method.line,\n                    lines: method.lines,\n                    isNew: true,\n                    isHardLimit: false,\n                    limit: maxLines,\n                });\n            }\n        }\n    }\n\n    return violations;\n}\n\n/**\n * Auto-detect the base branch by finding the merge-base with origin/main.\n * This allows the executor to run even when NX_BASE isn't set (e.g., via dependsOn).\n */\nfunction detectBase(workspaceRoot: string): string | null {\n    try {\n        // First, try to get merge-base with origin/main\n        const mergeBase = execSync('git merge-base HEAD origin/main', {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n            stdio: ['pipe', 'pipe', 'pipe'],\n        }).trim();\n\n        if (mergeBase) {\n            return mergeBase;\n        }\n    } catch {\n        // origin/main might not exist, try main\n        try {\n            const mergeBase = execSync('git merge-base HEAD main', {\n                cwd: workspaceRoot,\n                encoding: 'utf-8',\n                stdio: ['pipe', 'pipe', 'pipe'],\n            }).trim();\n\n            if (mergeBase) {\n                return mergeBase;\n            }\n        } catch {\n            // Ignore - will return null\n        }\n    }\n    return null;\n}\n\n/**\n * Report violations to the user with helpful instructions\n */\n// webpieces-disable max-lines-new-methods -- Console output formatting requires distinct sections for hard/soft violations\nfunction reportViolations(violations: MethodViolation[], maxLines: number, strictMaxLines?: number): void {\n    const hardViolations = violations.filter((v) => v.isHardLimit);\n    const softViolations = violations.filter((v) => !v.isHardLimit);\n\n    console.error('');\n    console.error('❌ New methods exceed line limits!');\n    console.error('');\n    console.error('📚 Methods should read like a \"table of contents\" - each method call');\n    console.error('   describes a larger piece of work. You can refactor');\n    console.error('   to stay under ' + maxLines + ' lines 50% of the time.');\n    console.error('');\n    console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');\n    console.error('');\n\n    if (hardViolations.length > 0) {\n        console.error('🚫 HARD LIMIT VIOLATIONS (cannot be bypassed with disable comment):');\n        console.error('');\n        for (const v of hardViolations) {\n            console.error(`  ❌ ${v.file}:${v.line}`);\n            console.error(`     Method: ${v.methodName} (${v.lines} lines, hard max: ${strictMaxLines})`);\n        }\n        console.error('');\n        console.error('   These methods MUST be refactored - no escape hatch available.');\n        console.error('');\n    }\n\n    if (softViolations.length > 0) {\n        console.error('⚠️  SOFT LIMIT VIOLATIONS (can be bypassed with disable comment):');\n        console.error('');\n        for (const v of softViolations) {\n            console.error(`  ❌ ${v.file}:${v.line}`);\n            console.error(`     Method: ${v.methodName} (${v.lines} lines, soft max: ${maxLines})`);\n        }\n        console.error('');\n        console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');\n        console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');\n        if (strictMaxLines) {\n            console.error(`   NOTE: Even with escape, you cannot exceed the hard limit of ${strictMaxLines} lines.`);\n        }\n        console.error('');\n    }\n}\n\nexport default async function runExecutor(\n    options: ValidateNewMethodsOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const workspaceRoot = context.root;\n    const maxLines = options.max ?? 30;\n    const strictMaxLines = options.strictMax;\n    const mode: ValidationMode = options.mode ?? 'NORMAL';\n\n    // Skip validation entirely if mode is OFF\n    if (mode === 'OFF') {\n        console.log('\\n⏭️  Skipping new method validation (validationMode: OFF)');\n        console.log('');\n        return { success: true };\n    }\n\n    // Check if running in affected mode via NX_BASE, or auto-detect\n    // We use NX_BASE as the base, and compare to WORKING TREE (not NX_HEAD)\n    // This matches what `nx affected` does - it compares base to working tree\n    let base = process.env['NX_BASE'];\n\n    if (!base) {\n        // Try to auto-detect base from git merge-base\n        base = detectBase(workspaceRoot) ?? undefined;\n\n        if (!base) {\n            console.log('\\n⏭️  Skipping new method validation (could not detect base branch)');\n            console.log('   To run explicitly: nx affected --target=validate-new-methods --base=origin/main');\n            console.log('');\n            return { success: true };\n        }\n\n        console.log('\\n📏 Validating New Method Sizes (auto-detected base)\\n');\n    } else {\n        console.log('\\n📏 Validating New Method Sizes\\n');\n    }\n\n    console.log(`   Base: ${base}`);\n    console.log(`   Comparing to: working tree (includes uncommitted changes)`);\n    console.log(`   Soft limit for new methods: ${maxLines} lines (can escape with disable comment)`);\n    if (strictMaxLines) {\n        console.log(`   Hard limit for new methods: ${strictMaxLines} lines (NO escape possible)`);\n    }\n    console.log('');\n\n    try {\n        // Get changed TypeScript files (base to working tree, like nx affected)\n        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base);\n\n        if (changedFiles.length === 0) {\n            console.log('✅ No TypeScript files changed');\n            return { success: true };\n        }\n\n        console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);\n\n        // Find violations\n        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines, strictMaxLines);\n\n        if (violations.length === 0) {\n            const limitMsg = strictMaxLines\n                ? `soft limit (${maxLines}) or hard limit (${strictMaxLines})`\n                : `${maxLines} lines`;\n            console.log('✅ All new methods are within ' + limitMsg);\n            return { success: true };\n        }\n\n        // Write instructions file and report violations\n        writeTmpInstructions(workspaceRoot);\n        reportViolations(violations, maxLines, strictMaxLines);\n\n        return { success: false };\n    } catch (err: unknown) {\n        const error = err instanceof Error ? err : new Error(String(err));\n        console.error('❌ New method validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}

package/architecture/executors/validate-new-methods/executor.ts

@@ -26,6 +26,7 @@ export type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';
 
 export interface ValidateNewMethodsOptions {
     max?: number;
+    strictMax?: number;
     mode?: ValidationMode;
 }
 
@@ -39,6 +40,8 @@ interface MethodViolation {
     line: number;
     lines: number;
     isNew: boolean;
+    isHardLimit: boolean;
+    limit: number;
 }
 
 const TMP_DIR = 'tmp/webpieces';
@@ -344,7 +347,8 @@ function findViolations(
     workspaceRoot: string,
     changedFiles: string[],
     base: string,
-    maxLines: number
+    maxLines: number,
+    strictMaxLines?: number
 ): MethodViolation[] {
     const violations: MethodViolation[] = [];
 
@@ -359,14 +363,30 @@ function findViolations(
         const methods = findMethodsInFile(file, workspaceRoot);
 
         for (const method of methods) {
-            // Only check NEW methods that don't have webpieces-disable comment
-            if (newMethodNames.has(method.name) && method.lines > maxLines && !method.hasDisableComment) {
+            if (!newMethodNames.has(method.name)) continue;
+
+            // Check hard limit first (if defined) - NO escape possible
+            if (strictMaxLines && method.lines > strictMaxLines) {
+                violations.push({
+                    file,
+                    methodName: method.name,
+                    line: method.line,
+                    lines: method.lines,
+                    isNew: true,
+                    isHardLimit: true,
+                    limit: strictMaxLines,
+                });
+            }
+            // Check soft limit - can be escaped with disable comment
+            else if (method.lines > maxLines && !method.hasDisableComment) {
                 violations.push({
                     file,
                     methodName: method.name,
                     line: method.line,
                     lines: method.lines,
                     isNew: true,
+                    isHardLimit: false,
+                    limit: maxLines,
                 });
             }
         }
@@ -413,9 +433,13 @@ function detectBase(workspaceRoot: string): string | null {
 /**
  * Report violations to the user with helpful instructions
  */
-function reportViolations(violations: MethodViolation[], maxLines: number): void {
+// webpieces-disable max-lines-new-methods -- Console output formatting requires distinct sections for hard/soft violations
+function reportViolations(violations: MethodViolation[], maxLines: number, strictMaxLines?: number): void {
+    const hardViolations = violations.filter((v) => v.isHardLimit);
+    const softViolations = violations.filter((v) => !v.isHardLimit);
+
     console.error('');
-    console.error('❌ New methods exceed ' + maxLines + ' lines!');
+    console.error('❌ New methods exceed line limits!');
     console.error('');
     console.error('📚 Methods should read like a "table of contents" - each method call');
     console.error('   describes a larger piece of work. You can refactor');
@@ -424,14 +448,33 @@ function reportViolations(violations: MethodViolation[], maxLines: number): void
     console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
     console.error('');
 
-    for (const v of violations) {
-        console.error(`  ❌ ${v.file}:${v.line}`);
-        console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
+    if (hardViolations.length > 0) {
+        console.error('🚫 HARD LIMIT VIOLATIONS (cannot be bypassed with disable comment):');
+        console.error('');
+        for (const v of hardViolations) {
+            console.error(`  ❌ ${v.file}:${v.line}`);
+            console.error(`     Method: ${v.methodName} (${v.lines} lines, hard max: ${strictMaxLines})`);
+        }
+        console.error('');
+        console.error('   These methods MUST be refactored - no escape hatch available.');
+        console.error('');
+    }
+
+    if (softViolations.length > 0) {
+        console.error('⚠️  SOFT LIMIT VIOLATIONS (can be bypassed with disable comment):');
+        console.error('');
+        for (const v of softViolations) {
+            console.error(`  ❌ ${v.file}:${v.line}`);
+            console.error(`     Method: ${v.methodName} (${v.lines} lines, soft max: ${maxLines})`);
+        }
+        console.error('');
+        console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');
+        console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');
+        if (strictMaxLines) {
+            console.error(`   NOTE: Even with escape, you cannot exceed the hard limit of ${strictMaxLines} lines.`);
+        }
+        console.error('');
     }
-    console.error('');
-    console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');
-    console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');
-    console.error('');
 }
 
 export default async function runExecutor(
@@ -440,6 +483,7 @@ export default async function runExecutor(
 ): Promise<ExecutorResult> {
     const workspaceRoot = context.root;
     const maxLines = options.max ?? 30;
+    const strictMaxLines = options.strictMax;
     const mode: ValidationMode = options.mode ?? 'NORMAL';
 
     // Skip validation entirely if mode is OFF
@@ -472,7 +516,10 @@ export default async function runExecutor(
 
     console.log(`   Base: ${base}`);
     console.log(`   Comparing to: working tree (includes uncommitted changes)`);
-    console.log(`   Max lines for new methods: ${maxLines}`);
+    console.log(`   Soft limit for new methods: ${maxLines} lines (can escape with disable comment)`);
+    if (strictMaxLines) {
+        console.log(`   Hard limit for new methods: ${strictMaxLines} lines (NO escape possible)`);
+    }
     console.log('');
 
     try {
@@ -487,16 +534,19 @@ export default async function runExecutor(
         console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);
 
         // Find violations
-        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);
+        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines, strictMaxLines);
 
         if (violations.length === 0) {
-            console.log('✅ All new methods are under ' + maxLines + ' lines');
+            const limitMsg = strictMaxLines
+                ? `soft limit (${maxLines}) or hard limit (${strictMaxLines})`
+                : `${maxLines} lines`;
+            console.log('✅ All new methods are within ' + limitMsg);
             return { success: true };
         }
 
         // Write instructions file and report violations
         writeTmpInstructions(workspaceRoot);
-        reportViolations(violations, maxLines);
+        reportViolations(violations, maxLines, strictMaxLines);
 
         return { success: false };
     } catch (err: unknown) {

package/architecture/executors/validate-new-methods/schema.json

@@ -6,13 +6,17 @@
     "properties": {
         "max": {
             "type": "number",
-            "description": "Maximum number of lines allowed for new methods",
+            "description": "Soft limit: Maximum lines for new methods (can be bypassed with disable comment)",
             "default": 30
         },
+        "strictMax": {
+            "type": "number",
+            "description": "Hard limit: Absolute maximum lines for new methods (CANNOT be bypassed with disable comment). If not set, no hard limit is enforced."
+        },
         "mode": {
             "type": "string",
             "enum": ["STRICT", "NORMAL", "OFF"],
-            "description": "OFF: skip validation. NORMAL/STRICT: validate (disable comments always work for new methods).",
+            "description": "OFF: skip validation. NORMAL/STRICT: validate (disable comments work for soft limit only).",
             "default": "NORMAL"
         }
     },

package/executors.json

@@ -59,6 +59,11 @@
             "implementation": "./architecture/executors/validate-modified-files/executor",
             "schema": "./architecture/executors/validate-modified-files/schema.json",
             "description": "Validate modified files don't exceed max line count"
+        },
+        "validate-code": {
+            "implementation": "./architecture/executors/validate-code/executor",
+            "schema": "./architecture/executors/validate-code/schema.json",
+            "description": "Combined validation for new methods, modified methods, and file sizes"
         }
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webpieces/dev-config",
-  "version": "0.2.65",
+  "version": "0.2.67",
   "description": "Development configuration, scripts, and patterns for WebPieces projects",
   "type": "commonjs",
   "bin": {

package/plugin.js

@@ -156,12 +156,10 @@ function buildValidationTargetsList(validations) {
         targets.push('validate-no-skiplevel-deps');
     if (validations.validatePackageJson)
         targets.push('validate-packagejson');
-    if (validations.validateNewMethods)
-        targets.push('validate-new-methods');
-    if (validations.validateModifiedMethods)
-        targets.push('validate-modified-methods');
-    if (validations.validateModifiedFiles)
-        targets.push('validate-modified-files');
+    // Use combined validate-code instead of 3 separate targets
+    if (validations.validateNewMethods || validations.validateModifiedMethods || validations.validateModifiedFiles) {
+        targets.push('validate-code');
+    }
     if (validations.validateVersionsLocked)
         targets.push('validate-versions-locked');
     return targets;
@@ -194,14 +192,10 @@ function createWorkspaceTargetsWithoutPrefix(opts) {
     if (validations.validatePackageJson) {
         targets['validate-packagejson'] = createValidatePackageJsonTarget();
     }
-    if (validations.validateNewMethods) {
-        targets['validate-new-methods'] = createValidateNewMethodsTarget(validations.newMethodsMaxLines, validations.validationMode);
-    }
-    if (validations.validateModifiedMethods) {
-        targets['validate-modified-methods'] = createValidateModifiedMethodsTarget(validations.modifiedAndNewMethodsMaxLines, validations.validationMode);
-    }
-    if (validations.validateModifiedFiles) {
-        targets['validate-modified-files'] = createValidateModifiedFilesTarget(validations.modifiedFilesMaxLines, validations.validationMode);
+    // Use combined validate-code instead of 3 separate targets
+    // Options come from targetDefaults in nx.json (applied at runtime, no cache issues)
+    if (validations.validateNewMethods || validations.validateModifiedMethods || validations.validateModifiedFiles) {
+        targets['validate-code'] = createValidateCodeTarget();
     }
     if (validations.validateVersionsLocked) {
         targets['validate-versions-locked'] = createValidateVersionsLockedTarget();
@@ -241,14 +235,10 @@ function createWorkspaceTargets(opts) {
     if (opts.workspace.validations.validatePackageJson) {
         targets[`${prefix}validate-packagejson`] = createValidatePackageJsonTarget();
     }
-    if (opts.workspace.validations.validateNewMethods) {
-        targets[`${prefix}validate-new-methods`] = createValidateNewMethodsTarget(opts.workspace.validations.newMethodsMaxLines, opts.workspace.validations.validationMode);
-    }
-    if (opts.workspace.validations.validateModifiedMethods) {
-        targets[`${prefix}validate-modified-methods`] = createValidateModifiedMethodsTarget(opts.workspace.validations.modifiedAndNewMethodsMaxLines, opts.workspace.validations.validationMode);
-    }
-    if (opts.workspace.validations.validateModifiedFiles) {
-        targets[`${prefix}validate-modified-files`] = createValidateModifiedFilesTarget(opts.workspace.validations.modifiedFilesMaxLines, opts.workspace.validations.validationMode);
+    // Use combined validate-code instead of 3 separate targets
+    // Options come from targetDefaults in nx.json (applied at runtime, no cache issues)
+    if (opts.workspace.validations.validateNewMethods || opts.workspace.validations.validateModifiedMethods || opts.workspace.validations.validateModifiedFiles) {
+        targets[`${prefix}validate-code`] = createValidateCodeTarget();
     }
     return targets;
 }
@@ -368,6 +358,22 @@ function createValidateModifiedFilesTarget(maxLines, mode) {
         },
     };
 }
+/**
+ * Create combined validate-code target
+ * Options come from targetDefaults in nx.json (applied at runtime, no cache issues)
+ */
+function createValidateCodeTarget() {
+    return {
+        executor: '@webpieces/dev-config:validate-code',
+        cache: false, // Don't cache - depends on git state
+        inputs: ['default'],
+        // No options here - they come from targetDefaults at runtime
+        metadata: {
+            technologies: ['nx'],
+            description: 'Combined validation for new methods, modified methods, and file sizes',
+        },
+    };
+}
 function createValidateVersionsLockedTarget() {
     return {
         executor: '@webpieces/dev-config:validate-versions-locked',