@webpieces/dev-config 0.2.65 → 0.2.66

package/architecture/executors/validate-code/executor.d.ts

@@ -0,0 +1,12 @@
+import { ExecutorContext } from '@nx/devkit';
+export type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';
+export interface ValidateCodeOptions {
+    mode?: ValidationMode;
+    newMethodsMaxLines?: number;
+    modifiedMethodsMaxLines?: number;
+    modifiedFilesMaxLines?: number;
+}
+export interface ExecutorResult {
+    success: boolean;
+}
+export default function runExecutor(options: ValidateCodeOptions, context: ExecutorContext): Promise<ExecutorResult>;

package/architecture/executors/validate-code/executor.js

@@ -0,0 +1,33 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = runExecutor;
+const tslib_1 = require("tslib");
+const executor_1 = tslib_1.__importDefault(require("../validate-new-methods/executor"));
+const executor_2 = tslib_1.__importDefault(require("../validate-modified-methods/executor"));
+const executor_3 = tslib_1.__importDefault(require("../validate-modified-files/executor"));
+async function runExecutor(options, context) {
+    const mode = options.mode ?? 'NORMAL';
+    if (mode === 'OFF') {
+        console.log('\n⏭️  Skipping all code validations (validationMode: OFF)\n');
+        return { success: true };
+    }
+    console.log('\n📏 Running Code Validations\n');
+    console.log(`   Validation mode: ${mode}${mode === 'STRICT' ? ' (disable comments ignored for modified code)' : ''}`);
+    console.log(`   New methods max: ${options.newMethodsMaxLines ?? 30} lines`);
+    console.log(`   Modified methods max: ${options.modifiedMethodsMaxLines ?? 80} lines`);
+    console.log(`   Modified files max: ${options.modifiedFilesMaxLines ?? 900} lines`);
+    console.log('');
+    // Run all three validators sequentially to avoid interleaved output
+    const newMethodsResult = await (0, executor_1.default)({ max: options.newMethodsMaxLines ?? 30, mode }, context);
+    const modifiedMethodsResult = await (0, executor_2.default)({ max: options.modifiedMethodsMaxLines ?? 80, mode }, context);
+    const modifiedFilesResult = await (0, executor_3.default)({ max: options.modifiedFilesMaxLines ?? 900, mode }, context);
+    const allSuccess = newMethodsResult.success && modifiedMethodsResult.success && modifiedFilesResult.success;
+    if (allSuccess) {
+        console.log('\n✅ All code validations passed\n');
+    }
+    else {
+        console.log('\n❌ Some code validations failed\n');
+    }
+    return { success: allSuccess };
+}
+//# sourceMappingURL=executor.js.map

package/architecture/executors/validate-code/executor.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/dev-config/architecture/executors/validate-code/executor.ts"],"names":[],"mappings":";;AAkBA,8BA2CC;;AA5DD,wFAAqE;AACrE,6FAA+E;AAC/E,2FAA2E;AAe5D,KAAK,UAAU,WAAW,CACrC,OAA4B,EAC5B,OAAwB;IAExB,MAAM,IAAI,GAAmB,OAAO,CAAC,IAAI,IAAI,QAAQ,CAAC;IAEtD,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;QACjB,OAAO,CAAC,GAAG,CAAC,6DAA6D,CAAC,CAAC;QAC3E,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;IAC7B,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,iCAAiC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,uBAAuB,IAAI,GAAG,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,+CAA+C,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IACtH,OAAO,CAAC,GAAG,CAAC,uBAAuB,OAAO,CAAC,kBAAkB,IAAI,EAAE,QAAQ,CAAC,CAAC;IAC7E,OAAO,CAAC,GAAG,CAAC,4BAA4B,OAAO,CAAC,uBAAuB,IAAI,EAAE,QAAQ,CAAC,CAAC;IACvF,OAAO,CAAC,GAAG,CAAC,0BAA0B,OAAO,CAAC,qBAAqB,IAAI,GAAG,QAAQ,CAAC,CAAC;IACpF,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAEhB,oEAAoE;IACpE,MAAM,gBAAgB,GAAG,MAAM,IAAA,kBAAqB,EAChD,EAAE,GAAG,EAAE,OAAO,CAAC,kBAAkB,IAAI,EAAE,EAAE,IAAI,EAAE,EAC/C,OAAO,CACV,CAAC;IAEF,MAAM,qBAAqB,GAAG,MAAM,IAAA,kBAA0B,EAC1D,EAAE,GAAG,EAAE,OAAO,CAAC,uBAAuB,IAAI,EAAE,EAAE,IAAI,EAAE,EACpD,OAAO,CACV,CAAC;IAEF,MAAM,mBAAmB,GAAG,MAAM,IAAA,kBAAwB,EACtD,EAAE,GAAG,EAAE,OAAO,CAAC,qBAAqB,IAAI,GAAG,EAAE,IAAI,EAAE,EACnD,OAAO,CACV,CAAC;IAEF,MAAM,UAAU,GAAG,gBAAgB,CAAC,OAAO,IAAI,qBAAqB,CAAC,OAAO,IAAI,mBAAmB,CAAC,OAAO,CAAC;IAE5G,IAAI,UAAU,EAAE,CAAC;QACb,OAAO,CAAC,GAAG,CAAC,mCAAmC,CAAC,CAAC;IACrD,CAAC;SAAM,CAAC;QACJ,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;IACtD,CAAC;IAED,OAAO,EAAE,OAAO,EAAE,UAAU,EAAE,CAAC;AACnC,CAAC","sourcesContent":["import { ExecutorContext } from '@nx/devkit';\nimport runNewMethodsExecutor from '../validate-new-methods/executor';\nimport runModifiedMethodsExecutor from '../validate-modified-methods/executor';\nimport runModifiedFilesExecutor from '../validate-modified-files/executor';\n\nexport type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';\n\nexport interface ValidateCodeOptions {\n    mode?: ValidationMode;\n    newMethodsMaxLines?: number;\n    modifiedMethodsMaxLines?: number;\n    modifiedFilesMaxLines?: number;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\nexport default async function runExecutor(\n    options: ValidateCodeOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const mode: ValidationMode = options.mode ?? 'NORMAL';\n\n    if (mode === 'OFF') {\n        console.log('\\n⏭️  Skipping all code validations (validationMode: OFF)\\n');\n        return { success: true };\n    }\n\n    console.log('\\n📏 Running Code Validations\\n');\n    console.log(`   Validation mode: ${mode}${mode === 'STRICT' ? ' (disable comments ignored for modified code)' : ''}`);\n    console.log(`   New methods max: ${options.newMethodsMaxLines ?? 30} lines`);\n    console.log(`   Modified methods max: ${options.modifiedMethodsMaxLines ?? 80} lines`);\n    console.log(`   Modified files max: ${options.modifiedFilesMaxLines ?? 900} lines`);\n    console.log('');\n\n    // Run all three validators sequentially to avoid interleaved output\n    const newMethodsResult = await runNewMethodsExecutor(\n        { max: options.newMethodsMaxLines ?? 30, mode },\n        context\n    );\n\n    const modifiedMethodsResult = await runModifiedMethodsExecutor(\n        { max: options.modifiedMethodsMaxLines ?? 80, mode },\n        context\n    );\n\n    const modifiedFilesResult = await runModifiedFilesExecutor(\n        { max: options.modifiedFilesMaxLines ?? 900, mode },\n        context\n    );\n\n    const allSuccess = newMethodsResult.success && modifiedMethodsResult.success && modifiedFilesResult.success;\n\n    if (allSuccess) {\n        console.log('\\n✅ All code validations passed\\n');\n    } else {\n        console.log('\\n❌ Some code validations failed\\n');\n    }\n\n    return { success: allSuccess };\n}\n"]}

package/architecture/executors/validate-code/executor.ts

@@ -0,0 +1,62 @@
+import { ExecutorContext } from '@nx/devkit';
+import runNewMethodsExecutor from '../validate-new-methods/executor';
+import runModifiedMethodsExecutor from '../validate-modified-methods/executor';
+import runModifiedFilesExecutor from '../validate-modified-files/executor';
+
+export type ValidationMode = 'STRICT' | 'NORMAL' | 'OFF';
+
+export interface ValidateCodeOptions {
+    mode?: ValidationMode;
+    newMethodsMaxLines?: number;
+    modifiedMethodsMaxLines?: number;
+    modifiedFilesMaxLines?: number;
+}
+
+export interface ExecutorResult {
+    success: boolean;
+}
+
+export default async function runExecutor(
+    options: ValidateCodeOptions,
+    context: ExecutorContext
+): Promise<ExecutorResult> {
+    const mode: ValidationMode = options.mode ?? 'NORMAL';
+
+    if (mode === 'OFF') {
+        console.log('\n⏭️  Skipping all code validations (validationMode: OFF)\n');
+        return { success: true };
+    }
+
+    console.log('\n📏 Running Code Validations\n');
+    console.log(`   Validation mode: ${mode}${mode === 'STRICT' ? ' (disable comments ignored for modified code)' : ''}`);
+    console.log(`   New methods max: ${options.newMethodsMaxLines ?? 30} lines`);
+    console.log(`   Modified methods max: ${options.modifiedMethodsMaxLines ?? 80} lines`);
+    console.log(`   Modified files max: ${options.modifiedFilesMaxLines ?? 900} lines`);
+    console.log('');
+
+    // Run all three validators sequentially to avoid interleaved output
+    const newMethodsResult = await runNewMethodsExecutor(
+        { max: options.newMethodsMaxLines ?? 30, mode },
+        context
+    );
+
+    const modifiedMethodsResult = await runModifiedMethodsExecutor(
+        { max: options.modifiedMethodsMaxLines ?? 80, mode },
+        context
+    );
+
+    const modifiedFilesResult = await runModifiedFilesExecutor(
+        { max: options.modifiedFilesMaxLines ?? 900, mode },
+        context
+    );
+
+    const allSuccess = newMethodsResult.success && modifiedMethodsResult.success && modifiedFilesResult.success;
+
+    if (allSuccess) {
+        console.log('\n✅ All code validations passed\n');
+    } else {
+        console.log('\n❌ Some code validations failed\n');
+    }
+
+    return { success: allSuccess };
+}

package/architecture/executors/validate-code/schema.json

@@ -0,0 +1,30 @@
+{
+    "$schema": "http://json-schema.org/schema",
+    "title": "Validate Code Executor",
+    "description": "Combined validation for new methods, modified methods, and file sizes. Configure via targetDefaults in nx.json for runtime options (no cache issues).",
+    "type": "object",
+    "properties": {
+        "mode": {
+            "type": "string",
+            "enum": ["STRICT", "NORMAL", "OFF"],
+            "description": "OFF: skip all validations. NORMAL: enforce limits, disable comments work. STRICT: enforce limits, no disable comments for modified code.",
+            "default": "NORMAL"
+        },
+        "newMethodsMaxLines": {
+            "type": "number",
+            "description": "Maximum lines for NEW methods (disable comments always allowed regardless of mode)",
+            "default": 30
+        },
+        "modifiedMethodsMaxLines": {
+            "type": "number",
+            "description": "Maximum lines for MODIFIED methods",
+            "default": 80
+        },
+        "modifiedFilesMaxLines": {
+            "type": "number",
+            "description": "Maximum lines for MODIFIED files",
+            "default": 900
+        }
+    },
+    "required": []
+}

package/executors.json

@@ -59,6 +59,11 @@
             "implementation": "./architecture/executors/validate-modified-files/executor",
             "schema": "./architecture/executors/validate-modified-files/schema.json",
             "description": "Validate modified files don't exceed max line count"
+        },
+        "validate-code": {
+            "implementation": "./architecture/executors/validate-code/executor",
+            "schema": "./architecture/executors/validate-code/schema.json",
+            "description": "Combined validation for new methods, modified methods, and file sizes"
         }
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webpieces/dev-config",
-  "version": "0.2.65",
+  "version": "0.2.66",
   "description": "Development configuration, scripts, and patterns for WebPieces projects",
   "type": "commonjs",
   "bin": {

package/plugin.js

@@ -156,12 +156,10 @@ function buildValidationTargetsList(validations) {
         targets.push('validate-no-skiplevel-deps');
     if (validations.validatePackageJson)
         targets.push('validate-packagejson');
-    if (validations.validateNewMethods)
-        targets.push('validate-new-methods');
-    if (validations.validateModifiedMethods)
-        targets.push('validate-modified-methods');
-    if (validations.validateModifiedFiles)
-        targets.push('validate-modified-files');
+    // Use combined validate-code instead of 3 separate targets
+    if (validations.validateNewMethods || validations.validateModifiedMethods || validations.validateModifiedFiles) {
+        targets.push('validate-code');
+    }
     if (validations.validateVersionsLocked)
         targets.push('validate-versions-locked');
     return targets;
@@ -194,14 +192,10 @@ function createWorkspaceTargetsWithoutPrefix(opts) {
     if (validations.validatePackageJson) {
         targets['validate-packagejson'] = createValidatePackageJsonTarget();
     }
-    if (validations.validateNewMethods) {
-        targets['validate-new-methods'] = createValidateNewMethodsTarget(validations.newMethodsMaxLines, validations.validationMode);
-    }
-    if (validations.validateModifiedMethods) {
-        targets['validate-modified-methods'] = createValidateModifiedMethodsTarget(validations.modifiedAndNewMethodsMaxLines, validations.validationMode);
-    }
-    if (validations.validateModifiedFiles) {
-        targets['validate-modified-files'] = createValidateModifiedFilesTarget(validations.modifiedFilesMaxLines, validations.validationMode);
+    // Use combined validate-code instead of 3 separate targets
+    // Options come from targetDefaults in nx.json (applied at runtime, no cache issues)
+    if (validations.validateNewMethods || validations.validateModifiedMethods || validations.validateModifiedFiles) {
+        targets['validate-code'] = createValidateCodeTarget();
     }
     if (validations.validateVersionsLocked) {
         targets['validate-versions-locked'] = createValidateVersionsLockedTarget();
@@ -241,14 +235,10 @@ function createWorkspaceTargets(opts) {
     if (opts.workspace.validations.validatePackageJson) {
         targets[`${prefix}validate-packagejson`] = createValidatePackageJsonTarget();
     }
-    if (opts.workspace.validations.validateNewMethods) {
-        targets[`${prefix}validate-new-methods`] = createValidateNewMethodsTarget(opts.workspace.validations.newMethodsMaxLines, opts.workspace.validations.validationMode);
-    }
-    if (opts.workspace.validations.validateModifiedMethods) {
-        targets[`${prefix}validate-modified-methods`] = createValidateModifiedMethodsTarget(opts.workspace.validations.modifiedAndNewMethodsMaxLines, opts.workspace.validations.validationMode);
-    }
-    if (opts.workspace.validations.validateModifiedFiles) {
-        targets[`${prefix}validate-modified-files`] = createValidateModifiedFilesTarget(opts.workspace.validations.modifiedFilesMaxLines, opts.workspace.validations.validationMode);
+    // Use combined validate-code instead of 3 separate targets
+    // Options come from targetDefaults in nx.json (applied at runtime, no cache issues)
+    if (opts.workspace.validations.validateNewMethods || opts.workspace.validations.validateModifiedMethods || opts.workspace.validations.validateModifiedFiles) {
+        targets[`${prefix}validate-code`] = createValidateCodeTarget();
     }
     return targets;
 }
@@ -368,6 +358,22 @@ function createValidateModifiedFilesTarget(maxLines, mode) {
         },
     };
 }
+/**
+ * Create combined validate-code target
+ * Options come from targetDefaults in nx.json (applied at runtime, no cache issues)
+ */
+function createValidateCodeTarget() {
+    return {
+        executor: '@webpieces/dev-config:validate-code',
+        cache: false, // Don't cache - depends on git state
+        inputs: ['default'],
+        // No options here - they come from targetDefaults at runtime
+        metadata: {
+            technologies: ['nx'],
+            description: 'Combined validation for new methods, modified methods, and file sizes',
+        },
+    };
+}
 function createValidateVersionsLockedTarget() {
     return {
         executor: '@webpieces/dev-config:validate-versions-locked',