@webpieces/dev-config 0.2.60 → 0.2.62

package/architecture/executors/validate-modified-methods/executor.ts

@@ -14,7 +14,9 @@
  * Usage:
  * nx affected --target=validate-modified-methods --base=origin/main
  *
- * Escape hatch: Add webpieces-disable max-lines-new-and-modified comment with justification
+ * Escape hatch: Add webpieces-disable max-lines-new-and-modified comment with date and justification
+ * Format: // webpieces-disable max-lines-new-and-modified 2025/01/15 -- [reason]
+ * The disable expires after 1 month from the date specified.
  */
 
 import type { ExecutorContext } from '@nx/devkit';
@@ -36,6 +38,8 @@ interface MethodViolation {
     methodName: string;
     line: number;
     lines: number;
+    expiredDisable?: boolean;
+    expiredDate?: string;
 }
 
 const TMP_DIR = 'tmp/webpieces';
@@ -140,15 +144,19 @@ const result = this.buildResultObject(data);
 
 Sometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).
 
-**Escape hatch**: Add a webpieces-disable comment with justification:
+**Escape hatch**: Add a webpieces-disable comment with DATE and justification:
 
 \`\`\`typescript
-// webpieces-disable max-lines-new-and-modified -- Complex state machine, splitting reduces clarity
+// webpieces-disable max-lines-new-and-modified 2025/01/15 -- Complex state machine, splitting reduces clarity
 async complexStateMachine(): Promise<void> {
     // ... longer method with justification
 }
 \`\`\`
 
+**IMPORTANT**: The date format is yyyy/mm/dd. The disable will EXPIRE after 1 month from this date.
+After expiration, you must either fix the method or update the date to get another month.
+This ensures that disable comments are reviewed periodically.
+
 ## AI Agent Action Steps
 
 1. **READ** the method to understand its logical sections
@@ -289,14 +297,64 @@ function getChangedLineNumbers(diffContent: string): Set<number> {
     return changedLines;
 }
 
+/**
+ * Parse a date string in yyyy/mm/dd format and return a Date object.
+ * Returns null if the format is invalid.
+ */
+function parseDisableDate(dateStr: string): Date | null {
+    // Match yyyy/mm/dd format
+    const match = dateStr.match(/^(\d{4})\/(\d{2})\/(\d{2})$/);
+    if (!match) return null;
+
+    const year = parseInt(match[1], 10);
+    const month = parseInt(match[2], 10) - 1; // JS months are 0-indexed
+    const day = parseInt(match[3], 10);
+
+    const date = new Date(year, month, day);
+
+    // Validate the date is valid (e.g., not Feb 30)
+    if (date.getFullYear() !== year || date.getMonth() !== month || date.getDate() !== day) {
+        return null;
+    }
+
+    return date;
+}
+
+/**
+ * Check if a date is within the last month (not expired).
+ */
+function isDateWithinMonth(date: Date): boolean {
+    const now = new Date();
+    const oneMonthAgo = new Date(now.getFullYear(), now.getMonth() - 1, now.getDate());
+    return date >= oneMonthAgo;
+}
+
+/**
+ * Get today's date in yyyy/mm/dd format for error messages
+ */
+function getTodayDateString(): string {
+    const now = new Date();
+    const year = now.getFullYear();
+    const month = String(now.getMonth() + 1).padStart(2, '0');
+    const day = String(now.getDate()).padStart(2, '0');
+    return `${year}/${month}/${day}`;
+}
+
+interface DisableInfo {
+    type: 'full' | 'new-only' | 'none';
+    isExpired: boolean;
+    date?: string;
+}
+
 /**
  * Check what kind of webpieces-disable comment is present for a method.
- * Returns: 'full' | 'new-only' | 'none'
+ * Returns: DisableInfo with type, expiration status, and date
  * - 'full': max-lines-new-and-modified (ultimate escape, skips both validators)
  * - 'new-only': max-lines-new-methods (escaped 30-line check, still needs 80-line check)
  * - 'none': no escape hatch
  */
-function getDisableType(lines: string[], lineNumber: number): 'full' | 'new-only' | 'none' {
+// webpieces-disable max-lines-new-methods -- Complex validation logic with multiple escape hatch types
+function getDisableInfo(lines: string[], lineNumber: number): DisableInfo {
     const startCheck = Math.max(0, lineNumber - 5);
     for (let i = lineNumber - 2; i >= startCheck; i--) {
         const line = lines[i]?.trim() ?? '';
@@ -305,24 +363,83 @@ function getDisableType(lines: string[], lineNumber: number): 'full' | 'new-only
         }
         if (line.includes('webpieces-disable')) {
             if (line.includes('max-lines-new-and-modified')) {
-                return 'full';
+                // Check for date in format: max-lines-new-and-modified yyyy/mm/dd
+                const dateMatch = line.match(/max-lines-new-and-modified\s+(\d{4}\/\d{2}\/\d{2}|XXXX\/XX\/XX)/);
+
+                if (!dateMatch) {
+                    // No date found - treat as expired (invalid)
+                    return { type: 'full', isExpired: true, date: undefined };
+                }
+
+                const dateStr = dateMatch[1];
+
+                // Secret permanent disable
+                if (dateStr === 'XXXX/XX/XX') {
+                    return { type: 'full', isExpired: false, date: dateStr };
+                }
+
+                const date = parseDisableDate(dateStr);
+                if (!date) {
+                    // Invalid date format - treat as expired
+                    return { type: 'full', isExpired: true, date: dateStr };
+                }
+
+                if (!isDateWithinMonth(date)) {
+                    // Date is expired (older than 1 month)
+                    return { type: 'full', isExpired: true, date: dateStr };
+                }
+
+                // Valid and not expired
+                return { type: 'full', isExpired: false, date: dateStr };
             }
             if (line.includes('max-lines-new-methods')) {
-                return 'new-only';
+                // Check for date in format: max-lines-new-methods yyyy/mm/dd
+                const dateMatch = line.match(/max-lines-new-methods\s+(\d{4}\/\d{2}\/\d{2}|XXXX\/XX\/XX)/);
+
+                if (!dateMatch) {
+                    // No date found - treat as expired (invalid)
+                    return { type: 'new-only', isExpired: true, date: undefined };
+                }
+
+                const dateStr = dateMatch[1];
+
+                // Secret permanent disable
+                if (dateStr === 'XXXX/XX/XX') {
+                    return { type: 'new-only', isExpired: false, date: dateStr };
+                }
+
+                const date = parseDisableDate(dateStr);
+                if (!date) {
+                    // Invalid date format - treat as expired
+                    return { type: 'new-only', isExpired: true, date: dateStr };
+                }
+
+                if (!isDateWithinMonth(date)) {
+                    // Date is expired (older than 1 month)
+                    return { type: 'new-only', isExpired: true, date: dateStr };
+                }
+
+                // Valid and not expired
+                return { type: 'new-only', isExpired: false, date: dateStr };
             }
         }
     }
-    return 'none';
+    return { type: 'none', isExpired: false };
+}
+
+interface MethodInfo {
+    name: string;
+    line: number;
+    endLine: number;
+    lines: number;
+    disableInfo: DisableInfo;
 }
 
 /**
  * Parse a TypeScript file and find methods with their line counts
  */
 // webpieces-disable max-lines-new-methods -- AST traversal requires inline visitor function
-function findMethodsInFile(
-    filePath: string,
-    workspaceRoot: string
-): Array<{ name: string; line: number; endLine: number; lines: number; disableType: 'full' | 'new-only' | 'none' }> {
+function findMethodsInFile(filePath: string, workspaceRoot: string): MethodInfo[] {
     const fullPath = path.join(workspaceRoot, filePath);
     if (!fs.existsSync(fullPath)) return [];
 
@@ -330,8 +447,7 @@ function findMethodsInFile(
     const fileLines = content.split('\n');
     const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);
 
-    const methods: Array<{ name: string; line: number; endLine: number; lines: number; disableType: 'full' | 'new-only' | 'none' }> =
-        [];
+    const methods: MethodInfo[] = [];
 
     // webpieces-disable max-lines-new-methods -- AST visitor pattern requires handling multiple node types
     function visit(node: ts.Node): void {
@@ -367,7 +483,7 @@ function findMethodsInFile(
                 line: startLine,
                 endLine: endLine,
                 lines: endLine - startLine + 1,
-                disableType: getDisableType(fileLines, startLine),
+                disableInfo: getDisableInfo(fileLines, startLine),
             });
         }
 
@@ -387,9 +503,9 @@ function findMethodsInFile(
  *
  * Skips:
  * - NEW methods without any escape (let validate-new-methods handle them first)
- * - Methods with `max-lines-new-and-modified` escape (ultimate escape hatch)
+ * - Methods with valid, non-expired `max-lines-new-and-modified` escape (ultimate escape hatch)
  */
-// webpieces-disable max-lines-new-methods -- Core validation logic with multiple file operations
+// webpieces-disable max-lines-new-and-modified 2025/12/20 -- Core validation logic with multiple file operations
 function findViolations(
     workspaceRoot: string,
     changedFiles: string[],
@@ -414,26 +530,52 @@ function findViolations(
 
         for (const method of methods) {
             const isNewMethod = newMethodNames.has(method.name);
+            const { type: disableType, isExpired, date: disableDate } = method.disableInfo;
 
-            // Skip methods with full escape (max-lines-new-and-modified)
-            if (method.disableType === 'full') continue;
+            // Skip methods with valid, non-expired full escape (max-lines-new-and-modified)
+            if (disableType === 'full' && !isExpired) continue;
 
             // Skip methods under the limit
             if (method.lines <= maxLines) continue;
 
             if (isNewMethod) {
                 // For NEW methods:
-                // - If has 'new-only' escape → check (they escaped 30-line, now need 80-line check)
+                // - If has 'new-only' escape (non-expired) → check (they escaped 30-line, now need 80-line check)
                 // - If has 'none' → skip (let validate-new-methods handle first)
-                if (method.disableType !== 'new-only') continue;
-
-                // New method with max-lines-new-methods escape - check against 80-line limit
-                violations.push({
-                    file,
-                    methodName: method.name,
-                    line: method.line,
-                    lines: method.lines,
-                });
+                // - If has expired disable → report as violation
+                if (disableType === 'full' && isExpired) {
+                    // Expired full disable - report with expired info
+                    violations.push({
+                        file,
+                        methodName: method.name,
+                        line: method.line,
+                        lines: method.lines,
+                        expiredDisable: true,
+                        expiredDate: disableDate,
+                    });
+                    continue;
+                }
+                if (disableType !== 'new-only') continue;
+
+                if (isExpired) {
+                    // Expired new-only disable - report with expired info
+                    violations.push({
+                        file,
+                        methodName: method.name,
+                        line: method.line,
+                        lines: method.lines,
+                        expiredDisable: true,
+                        expiredDate: disableDate,
+                    });
+                } else {
+                    // New method with valid max-lines-new-methods escape - check against 80-line limit
+                    violations.push({
+                        file,
+                        methodName: method.name,
+                        line: method.line,
+                        lines: method.lines,
+                    });
+                }
             } else {
                 // For MODIFIED methods: check if any changed line falls within method's range
                 let hasChanges = false;
@@ -445,12 +587,24 @@ function findViolations(
                 }
 
                 if (hasChanges) {
-                    violations.push({
-                        file,
-                        methodName: method.name,
-                        line: method.line,
-                        lines: method.lines,
-                    });
+                    if (disableType === 'full' && isExpired) {
+                        // Expired full disable - report with expired info
+                        violations.push({
+                            file,
+                            methodName: method.name,
+                            line: method.line,
+                            lines: method.lines,
+                            expiredDisable: true,
+                            expiredDate: disableDate,
+                        });
+                    } else {
+                        violations.push({
+                            file,
+                            methodName: method.name,
+                            line: method.line,
+                            lines: method.lines,
+                        });
+                    }
                 }
             }
         }
@@ -491,6 +645,46 @@ function detectBase(workspaceRoot: string): string | null {
     return null;
 }
 
+/**
+ * Report violations to console
+ */
+// webpieces-disable max-lines-new-methods -- Error output formatting with multiple message sections
+function reportViolations(violations: MethodViolation[], maxLines: number): void {
+    console.error('');
+    console.error('❌ Modified methods exceed ' + maxLines + ' lines!');
+    console.error('');
+    console.error('📚 When you modify a method, you must bring it under ' + maxLines + ' lines.');
+    console.error('   This rule encourages GRADUAL cleanup so even though you did not cause it,');
+    console.error('   you touched it, so you should fix now as part of your PR');
+    console.error('   (this is for vibe coding and AI to fix as it touches things).');
+    console.error('   You can refactor to stay under the limit 50% of the time. If not feasible, use the escape hatch.');
+    console.error('');
+    console.error(
+        '⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️'
+    );
+    console.error('');
+
+    for (const v of violations) {
+        if (v.expiredDisable) {
+            console.error(`  ❌ ${v.file}:${v.line}`);
+            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
+            console.error(`     ⏰ EXPIRED DISABLE: Your disable comment dated ${v.expiredDate ?? 'unknown'} has expired (>1 month old).`);
+            console.error(`        You must either FIX the method or UPDATE the date to get another month.`);
+        } else {
+            console.error(`  ❌ ${v.file}:${v.line}`);
+            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
+        }
+    }
+    console.error('');
+
+    console.error('   You can disable this error, but you will be forced to fix again in 1 month');
+    console.error('   since 99% of methods can be less than ' + maxLines + ' lines of code.');
+    console.error('');
+    console.error('   Use escape with DATE (expires in 1 month):');
+    console.error(`   // webpieces-disable max-lines-new-and-modified ${getTodayDateString()} -- [your reason]`);
+    console.error('');
+}
+
 export default async function runExecutor(
     options: ValidateModifiedMethodsOptions,
     context: ExecutorContext
@@ -537,30 +731,8 @@ export default async function runExecutor(
             return { success: true };
         }
 
-        // Write instructions file
         writeTmpInstructions(workspaceRoot);
-
-        // Report violations
-        console.error('');
-        console.error('❌ Modified methods exceed ' + maxLines + ' lines!');
-        console.error('');
-        console.error('📚 When you modify a method, you must bring it under ' + maxLines + ' lines.');
-        console.error('   This rule encourages GRADUAL cleanup so even though you did not cause it,');
-        console.error('   you touched it, so you should fix now as part of your PR');
-        console.error('   (this is for vibe coding and AI to fix as it touches things).');
-        console.error('   You can refactor to stay under the limit 50% of the time. If not feasible, use the escape hatch.');
-        console.error('');
-        console.error(
-            '⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️'
-        );
-        console.error('');
-
-        for (const v of violations) {
-            console.error(`  ❌ ${v.file}:${v.line}`);
-            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
-        }
-        console.error('');
-
+        reportViolations(violations, maxLines);
         return { success: false };
     } catch (err: unknown) {
         const error = err instanceof Error ? err : new Error(String(err));

package/architecture/executors/validate-new-methods/executor.js

@@ -363,6 +363,28 @@ function detectBase(workspaceRoot) {
     }
     return null;
 }
+/**
+ * Report violations to the user with helpful instructions
+ */
+function reportViolations(violations, maxLines) {
+    console.error('');
+    console.error('❌ New methods exceed ' + maxLines + ' lines!');
+    console.error('');
+    console.error('📚 Methods should read like a "table of contents" - each method call');
+    console.error('   describes a larger piece of work. You can refactor');
+    console.error('   to stay under ' + maxLines + ' lines 50% of the time.');
+    console.error('');
+    console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
+    console.error('');
+    for (const v of violations) {
+        console.error(`  ❌ ${v.file}:${v.line}`);
+        console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
+    }
+    console.error('');
+    console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');
+    console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');
+    console.error('');
+}
 async function runExecutor(options, context) {
     const workspaceRoot = context.root;
     const maxLines = options.max ?? 30;
@@ -402,23 +424,9 @@ async function runExecutor(options, context) {
             console.log('✅ All new methods are under ' + maxLines + ' lines');
             return { success: true };
         }
-        // Write instructions file
+        // Write instructions file and report violations
         writeTmpInstructions(workspaceRoot);
-        // Report violations
-        console.error('');
-        console.error('❌ New methods exceed ' + maxLines + ' lines!');
-        console.error('');
-        console.error('📚 Methods should read like a "table of contents" - each method call');
-        console.error('   describes a larger piece of work. You can refactor');
-        console.error('   to stay under ' + maxLines + ' lines 50% of the time. If not feasible, use the escape hatch.');
-        console.error('');
-        console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
-        console.error('');
-        for (const v of violations) {
-            console.error(`  ❌ ${v.file}:${v.line}`);
-            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
-        }
-        console.error('');
+        reportViolations(violations, maxLines);
         return { success: false };
     }
     catch (err) {

package/architecture/executors/validate-new-methods/executor.js.map

@@ -1 +1 @@
-{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/dev-config/architecture/executors/validate-new-methods/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;GAgBG;;AAyYH,8BA8EC;;AApdD,iDAAyC;AACzC,+CAAyB;AACzB,mDAA6B;AAC7B,uDAAiC;AAkBjC,MAAM,OAAO,GAAG,eAAe,CAAC;AAChC,MAAM,WAAW,GAAG,yBAAyB,CAAC;AAE9C,MAAM,sBAAsB,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAoH9B,CAAC;AAEF;;GAEG;AACH,SAAS,oBAAoB,CAAC,aAAqB;IAC/C,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,OAAO,CAAC,CAAC;IACjD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;IAE9C,EAAE,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC1C,EAAE,CAAC,aAAa,CAAC,MAAM,EAAE,sBAAsB,CAAC,CAAC;IAEjD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;;;GAIG;AACH,SAAS,yBAAyB,CAAC,aAAqB,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,MAAM,MAAM,GAAG,IAAA,wBAAQ,EAAC,wBAAwB,IAAI,oBAAoB,EAAE;YACtE,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;QACH,OAAO,MAAM;aACR,IAAI,EAAE;aACN,KAAK,CAAC,IAAI,CAAC;aACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC;IAChF,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;;;GAIG;AACH,SAAS,WAAW,CAAC,aAAqB,EAAE,IAAY,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,OAAO,IAAA,wBAAQ,EAAC,YAAY,IAAI,QAAQ,IAAI,GAAG,EAAE;YAC7C,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;IACP,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;GAEG;AACH,SAAS,6BAA6B,CAAC,WAAmB;IACtD,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAEtC,uCAAuC;IACvC,MAAM,QAAQ,GAAG;QACb,qEAAqE;QACrE,wDAAwD;QACxD,4CAA4C;QAC5C,iEAAiE;QACjE,mDAAmD;QACnD,uEAAuE;QACvE,gFAAgF;QAChF,+BAA+B;KAClC,CAAC;IAEF,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACvB,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAClD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;gBAC7B,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;gBAClC,IAAI,KAAK,EAAE,CAAC;oBACR,sDAAsD;oBACtD,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;oBAC5B,IAAI,UAAU,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,aAAa,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;wBAC/F,UAAU,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;oBAC/B,CAAC;oBACD,MAAM;gBACV,CAAC;YACL,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CAAC,KAAe,EAAE,UAAkB;IAC1D,iFAAiF;IACjF,0EAA0E;IAC1E,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,UAAU,GAAG,CAAC,CAAC,CAAC;IAC/C,KAAK,IAAI,CAAC,GAAG,UAAU,GAAG,CAAC,EAAE,CAAC,IAAI,UAAU,EAAE,CAAC,EAAE,EAAE,CAAC;QAChD,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QACpC,4CAA4C;QAC5C,IAAI,IAAI,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAClF,MAAM;QACV,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ,CAAC,mBAAmB,CAAC,EAAE,CAAC;YACrC,gEAAgE;YAChE,IAAI,IAAI,CAAC,QAAQ,CAAC,uBAAuB,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,4BAA4B,CAAC,EAAE,CAAC;gBACxF,OAAO,IAAI,CAAC;YAChB,CAAC;QACL,CAAC;IACL,CAAC;IACD,OAAO,KAAK,CAAC;AACjB,CAAC;AAED;;GAEG;AACH,SAAS,iBAAiB,CACtB,QAAgB,EAChB,aAAqB;IAErB,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,CAAC;IACpD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAExC,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,SAAS,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,UAAU,GAAG,EAAE,CAAC,gBAAgB,CAAC,QAAQ,EAAE,OAAO,EAAE,EAAE,CAAC,YAAY,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;IAExF,MAAM,OAAO,GAAqF,EAAE,CAAC;IAErG,SAAS,KAAK,CAAC,IAAa;QACxB,IAAI,UAA8B,CAAC;QACnC,IAAI,SAA6B,CAAC;QAClC,IAAI,OAA2B,CAAC;QAEhC,IAAI,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YAC5C,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YACrD,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,uCAAuC;YACvC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7E,UAAU,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;gBAClD,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;gBACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;gBACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;gBAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,CAAC;QACL,CAAC;QAED,IAAI,UAAU,IAAI,SAAS,KAAK,SAAS,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YACjE,OAAO,CAAC,IAAI,CAAC;gBACT,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,SAAS;gBACf,KAAK,EAAE,OAAO,GAAG,SAAS,GAAG,CAAC;gBAC9B,iBAAiB,EAAE,iBAAiB,CAAC,SAAS,EAAE,SAAS,CAAC;aAC7D,CAAC,CAAC;QACP,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IACjC,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,CAAC;IAClB,OAAO,OAAO,CAAC;AACnB,CAAC;AAED;;GAEG;AACH,SAAS,cAAc,CACnB,aAAqB,EACrB,YAAsB,EACtB,IAAY,EACZ,QAAgB;IAEhB,MAAM,UAAU,GAAsB,EAAE,CAAC;IAEzC,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;QAC9B,iEAAiE;QACjE,MAAM,IAAI,GAAG,WAAW,CAAC,aAAa,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;QACpD,MAAM,cAAc,GAAG,6BAA6B,CAAC,IAAI,CAAC,CAAC;QAE3D,IAAI,cAAc,CAAC,IAAI,KAAK,CAAC;YAAE,SAAS;QAExC,mDAAmD;QACnD,MAAM,OAAO,GAAG,iBAAiB,CAAC,IAAI,EAAE,aAAa,CAAC,CAAC;QAEvD,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC3B,mEAAmE;YACnE,IAAI,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,KAAK,GAAG,QAAQ,IAAI,CAAC,MAAM,CAAC,iBAAiB,EAAE,CAAC;gBAC1F,UAAU,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,UAAU,EAAE,MAAM,CAAC,IAAI;oBACvB,IAAI,EAAE,MAAM,CAAC,IAAI;oBACjB,KAAK,EAAE,MAAM,CAAC,KAAK;oBACnB,KAAK,EAAE,IAAI;iBACd,CAAC,CAAC;YACP,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;GAGG;AACH,SAAS,UAAU,CAAC,aAAqB;IACrC,IAAI,CAAC;QACD,gDAAgD;QAChD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,iCAAiC,EAAE;YAC1D,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;YACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;SAClC,CAAC,CAAC,IAAI,EAAE,CAAC;QAEV,IAAI,SAAS,EAAE,CAAC;YACZ,OAAO,SAAS,CAAC;QACrB,CAAC;IACL,CAAC;IAAC,MAAM,CAAC;QACL,wCAAwC;QACxC,IAAI,CAAC;YACD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,0BAA0B,EAAE;gBACnD,GAAG,EAAE,aAAa;gBAClB,QAAQ,EAAE,OAAO;gBACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;aAClC,CAAC,CAAC,IAAI,EAAE,CAAC;YAEV,IAAI,SAAS,EAAE,CAAC;gBACZ,OAAO,SAAS,CAAC;YACrB,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACL,4BAA4B;QAChC,CAAC;IACL,CAAC;IACD,OAAO,IAAI,CAAC;AAChB,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,OAAkC,EAClC,OAAwB;IAExB,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IACnC,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,IAAI,EAAE,CAAC;IAEnC,gEAAgE;IAChE,wEAAwE;IACxE,0EAA0E;IAC1E,IAAI,IAAI,GAAG,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;IAElC,IAAI,CAAC,IAAI,EAAE,CAAC;QACR,8CAA8C;QAC9C,IAAI,GAAG,UAAU,CAAC,aAAa,CAAC,IAAI,SAAS,CAAC;QAE9C,IAAI,CAAC,IAAI,EAAE,CAAC;YACR,OAAO,CAAC,GAAG,CAAC,qEAAqE,CAAC,CAAC;YACnF,OAAO,CAAC,GAAG,CAAC,oFAAoF,CAAC,CAAC;YAClG,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAChB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,yDAAyD,CAAC,CAAC;IAC3E,CAAC;SAAM,CAAC;QACJ,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;IACtD,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC;IAChC,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;IAC5E,OAAO,CAAC,GAAG,CAAC,iCAAiC,QAAQ,EAAE,CAAC,CAAC;IACzD,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAEhB,IAAI,CAAC;QACD,wEAAwE;QACxE,MAAM,YAAY,GAAG,yBAAyB,CAAC,aAAa,EAAE,IAAI,CAAC,CAAC;QAEpE,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,+BAA+B,CAAC,CAAC;YAC7C,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,eAAe,YAAY,CAAC,MAAM,qBAAqB,CAAC,CAAC;QAErE,kBAAkB;QAClB,MAAM,UAAU,GAAG,cAAc,CAAC,aAAa,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,CAAC,CAAC;QAE/E,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,8BAA8B,GAAG,QAAQ,GAAG,QAAQ,CAAC,CAAC;YAClE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,0BAA0B;QAC1B,oBAAoB,CAAC,aAAa,CAAC,CAAC;QAEpC,oBAAoB;QACpB,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CAAC,uBAAuB,GAAG,QAAQ,GAAG,SAAS,CAAC,CAAC;QAC9D,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CAAC,sEAAsE,CAAC,CAAC;QACtF,OAAO,CAAC,KAAK,CAAC,uDAAuD,CAAC,CAAC;QACvE,OAAO,CAAC,KAAK,CAAC,mBAAmB,GAAG,QAAQ,GAAG,gEAAgE,CAAC,CAAC;QACjH,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CAAC,2GAA2G,CAAC,CAAC;QAC3H,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAElB,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YACzB,OAAO,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;YACzC,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,KAAK,gBAAgB,QAAQ,GAAG,CAAC,CAAC;QACvF,CAAC;QACD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAElB,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC;QAClE,OAAO,CAAC,KAAK,CAAC,iCAAiC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAChE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate New Methods Executor\n *\n * Validates that newly added methods don't exceed a maximum line count.\n * Runs in affected mode when:\n *   1. NX_BASE environment variable is set (via nx affected), OR\n *   2. Auto-detects base by finding merge-base with origin/main\n *\n * This validator encourages writing methods that read like a \"table of contents\"\n * where each method call describes a larger piece of work.\n *\n * Usage:\n * nx affected --target=validate-new-methods --base=origin/main\n * OR: runs automatically via build's architecture:validate-complete dependency\n *\n * Escape hatch: Add webpieces-disable max-lines-new-methods comment with justification\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { execSync } from 'child_process';\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport * as ts from 'typescript';\n\nexport interface ValidateNewMethodsOptions {\n    max?: number;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\ninterface MethodViolation {\n    file: string;\n    methodName: string;\n    line: number;\n    lines: number;\n    isNew: boolean;\n}\n\nconst TMP_DIR = 'tmp/webpieces';\nconst TMP_MD_FILE = 'webpieces.methodsize.md';\n\nconst METHODSIZE_DOC_CONTENT = `# Instructions: New Method Too Long\n\n## Requirement\n\n**~50% of the time**, you can stay under the \\`newMethodsMaxLines\\` limit from nx.json\nby extracting logical units into well-named methods.\n\n**~99% of the time**, you can stay under the \\`modifiedAndNewMethodsMaxLines\\` limit from nx.json.\nNearly all software can be written with methods under this size.\n\n## The \"Table of Contents\" Principle\n\nGood code reads like a book's table of contents:\n- Chapter titles (method names) tell you WHAT happens\n- Reading chapter titles gives you the full story\n- You can dive into chapters (implementations) for details\n\n## Why Limit New Methods?\n\nMethods under the limit are:\n- Easy to review in a single screen\n- Simple to understand without scrolling\n- Quick for AI to analyze and suggest improvements\n- More testable in isolation\n- Self-documenting through well-named extracted methods\n\nExtracting logical units into well-named methods makes code more readable for both\nAI and humans.\n\n## How to Refactor\n\nInstead of:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    // 50 lines of validation, transformation, saving, notifications...\n}\n\\`\\`\\`\n\nWrite:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    const validated = this.validateOrder(order);\n    const transformed = this.applyBusinessRules(validated);\n    const saved = await this.saveToDatabase(transformed);\n    await this.notifyStakeholders(saved);\n    return this.buildResult(saved);\n}\n\\`\\`\\`\n\nNow the main method is a \"table of contents\" - each line tells part of the story!\n\n## Patterns for Extraction\n\n### Pattern 1: Extract Loop Bodies\n\\`\\`\\`typescript\n// BEFORE\nfor (const item of items) {\n    // 20 lines of processing\n}\n\n// AFTER\nfor (const item of items) {\n    this.processItem(item);\n}\n\\`\\`\\`\n\n### Pattern 2: Extract Conditional Blocks\n\\`\\`\\`typescript\n// BEFORE\nif (isAdmin(user)) {\n    // 15 lines of admin logic\n}\n\n// AFTER\nif (isAdmin(user)) {\n    this.handleAdminUser(user);\n}\n\\`\\`\\`\n\n### Pattern 3: Extract Data Transformations\n\\`\\`\\`typescript\n// BEFORE\nconst result = {\n    // 10+ lines of object construction\n};\n\n// AFTER\nconst result = this.buildResultObject(data);\n\\`\\`\\`\n\n## If Refactoring Is Not Feasible\n\nSometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).\n\n**Escape hatch**: Add a webpieces-disable comment with justification:\n\n\\`\\`\\`typescript\n// webpieces-disable max-lines-new-methods -- Complex state machine, splitting reduces clarity\nasync complexStateMachine(): Promise<void> {\n    // ... longer method with justification\n}\n\\`\\`\\`\n\n## AI Agent Action Steps\n\n1. **READ** the method to understand its logical sections\n2. **IDENTIFY** logical units that can be extracted\n3. **EXTRACT** into well-named private methods\n4. **VERIFY** the main method now reads like a table of contents\n5. **IF NOT FEASIBLE**: Add webpieces-disable max-lines-new-methods comment with clear justification\n\n## Remember\n\n- Every method you write today will be read many times tomorrow\n- The best code explains itself through structure\n- When in doubt, extract and name it\n`;\n\n/**\n * Write the instructions documentation to tmp directory\n */\nfunction writeTmpInstructions(workspaceRoot: string): string {\n    const tmpDir = path.join(workspaceRoot, TMP_DIR);\n    const mdPath = path.join(tmpDir, TMP_MD_FILE);\n\n    fs.mkdirSync(tmpDir, { recursive: true });\n    fs.writeFileSync(mdPath, METHODSIZE_DOC_CONTENT);\n\n    return mdPath;\n}\n\n/**\n * Get changed TypeScript files between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getChangedTypeScriptFiles(workspaceRoot: string, base: string): string[] {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        const output = execSync(`git diff --name-only ${base} -- '*.ts' '*.tsx'`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n        return output\n            .trim()\n            .split('\\n')\n            .filter((f) => f && !f.includes('.spec.ts') && !f.includes('.test.ts'));\n    } catch {\n        return [];\n    }\n}\n\n/**\n * Get the diff content for a specific file between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getFileDiff(workspaceRoot: string, file: string, base: string): string {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        return execSync(`git diff ${base} -- \"${file}\"`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n    } catch {\n        return '';\n    }\n}\n\n/**\n * Parse diff to find newly added method signatures\n */\nfunction findNewMethodSignaturesInDiff(diffContent: string): Set<string> {\n    const newMethods = new Set<string>();\n    const lines = diffContent.split('\\n');\n\n    // Patterns to match method definitions\n    const patterns = [\n        // [export] [async] function methodName( - most explicit, check first\n        /^\\+\\s*(?:export\\s+)?(?:async\\s+)?function\\s+(\\w+)\\s*\\(/,\n        // [export] const/let methodName = [async] (\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s*)?\\(/,\n        // [export] const/let methodName = [async] function\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s+)?function/,\n        // class method: [async] methodName( - but NOT constructor, if, for, while, etc.\n        /^\\+\\s*(?:async\\s+)?(\\w+)\\s*\\(/,\n    ];\n\n    for (const line of lines) {\n        if (line.startsWith('+') && !line.startsWith('+++')) {\n            for (const pattern of patterns) {\n                const match = line.match(pattern);\n                if (match) {\n                    // Extract method name - now always in capture group 1\n                    const methodName = match[1];\n                    if (methodName && !['if', 'for', 'while', 'switch', 'catch', 'constructor'].includes(methodName)) {\n                        newMethods.add(methodName);\n                    }\n                    break;\n                }\n            }\n        }\n    }\n\n    return newMethods;\n}\n\n/**\n * Check if a line contains a webpieces-disable comment that exempts from new method validation.\n * Both max-lines-new-methods AND max-lines-new-and-modified are accepted here.\n * - max-lines-new-methods: Exempts from 30-line check, still checked by 80-line validator\n * - max-lines-new-and-modified: Exempts from both validators (ultimate escape hatch)\n */\nfunction hasDisableComment(lines: string[], lineNumber: number): boolean {\n    // Check the line before the method (lineNumber is 1-indexed, array is 0-indexed)\n    // We need to check a few lines before in case there's JSDoc or decorators\n    const startCheck = Math.max(0, lineNumber - 5);\n    for (let i = lineNumber - 2; i >= startCheck; i--) {\n        const line = lines[i]?.trim() ?? '';\n        // Stop if we hit another function/class/etc\n        if (line.startsWith('function ') || line.startsWith('class ') || line.endsWith('}')) {\n            break;\n        }\n        if (line.includes('webpieces-disable')) {\n            // Either escape hatch exempts from the 30-line new method check\n            if (line.includes('max-lines-new-methods') || line.includes('max-lines-new-and-modified')) {\n                return true;\n            }\n        }\n    }\n    return false;\n}\n\n/**\n * Parse a TypeScript file and find methods with their line counts\n */\nfunction findMethodsInFile(\n    filePath: string,\n    workspaceRoot: string\n): Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> {\n    const fullPath = path.join(workspaceRoot, filePath);\n    if (!fs.existsSync(fullPath)) return [];\n\n    const content = fs.readFileSync(fullPath, 'utf-8');\n    const fileLines = content.split('\\n');\n    const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);\n\n    const methods: Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> = [];\n\n    function visit(node: ts.Node): void {\n        let methodName: string | undefined;\n        let startLine: number | undefined;\n        let endLine: number | undefined;\n\n        if (ts.isMethodDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isFunctionDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isArrowFunction(node)) {\n            // Check if it's assigned to a variable\n            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {\n                methodName = node.parent.name.getText(sourceFile);\n                const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n                const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n                startLine = start.line + 1;\n                endLine = end.line + 1;\n            }\n        }\n\n        if (methodName && startLine !== undefined && endLine !== undefined) {\n            methods.push({\n                name: methodName,\n                line: startLine,\n                lines: endLine - startLine + 1,\n                hasDisableComment: hasDisableComment(fileLines, startLine),\n            });\n        }\n\n        ts.forEachChild(node, visit);\n    }\n\n    visit(sourceFile);\n    return methods;\n}\n\n/**\n * Find new methods that exceed the line limit\n */\nfunction findViolations(\n    workspaceRoot: string,\n    changedFiles: string[],\n    base: string,\n    maxLines: number\n): MethodViolation[] {\n    const violations: MethodViolation[] = [];\n\n    for (const file of changedFiles) {\n        // Get the diff to find which methods are NEW (not just modified)\n        const diff = getFileDiff(workspaceRoot, file, base);\n        const newMethodNames = findNewMethodSignaturesInDiff(diff);\n\n        if (newMethodNames.size === 0) continue;\n\n        // Parse the current file to get method line counts\n        const methods = findMethodsInFile(file, workspaceRoot);\n\n        for (const method of methods) {\n            // Only check NEW methods that don't have webpieces-disable comment\n            if (newMethodNames.has(method.name) && method.lines > maxLines && !method.hasDisableComment) {\n                violations.push({\n                    file,\n                    methodName: method.name,\n                    line: method.line,\n                    lines: method.lines,\n                    isNew: true,\n                });\n            }\n        }\n    }\n\n    return violations;\n}\n\n/**\n * Auto-detect the base branch by finding the merge-base with origin/main.\n * This allows the executor to run even when NX_BASE isn't set (e.g., via dependsOn).\n */\nfunction detectBase(workspaceRoot: string): string | null {\n    try {\n        // First, try to get merge-base with origin/main\n        const mergeBase = execSync('git merge-base HEAD origin/main', {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n            stdio: ['pipe', 'pipe', 'pipe'],\n        }).trim();\n\n        if (mergeBase) {\n            return mergeBase;\n        }\n    } catch {\n        // origin/main might not exist, try main\n        try {\n            const mergeBase = execSync('git merge-base HEAD main', {\n                cwd: workspaceRoot,\n                encoding: 'utf-8',\n                stdio: ['pipe', 'pipe', 'pipe'],\n            }).trim();\n\n            if (mergeBase) {\n                return mergeBase;\n            }\n        } catch {\n            // Ignore - will return null\n        }\n    }\n    return null;\n}\n\nexport default async function runExecutor(\n    options: ValidateNewMethodsOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const workspaceRoot = context.root;\n    const maxLines = options.max ?? 30;\n\n    // Check if running in affected mode via NX_BASE, or auto-detect\n    // We use NX_BASE as the base, and compare to WORKING TREE (not NX_HEAD)\n    // This matches what `nx affected` does - it compares base to working tree\n    let base = process.env['NX_BASE'];\n\n    if (!base) {\n        // Try to auto-detect base from git merge-base\n        base = detectBase(workspaceRoot) ?? undefined;\n\n        if (!base) {\n            console.log('\\n⏭️  Skipping new method validation (could not detect base branch)');\n            console.log('   To run explicitly: nx affected --target=validate-new-methods --base=origin/main');\n            console.log('');\n            return { success: true };\n        }\n\n        console.log('\\n📏 Validating New Method Sizes (auto-detected base)\\n');\n    } else {\n        console.log('\\n📏 Validating New Method Sizes\\n');\n    }\n\n    console.log(`   Base: ${base}`);\n    console.log(`   Comparing to: working tree (includes uncommitted changes)`);\n    console.log(`   Max lines for new methods: ${maxLines}`);\n    console.log('');\n\n    try {\n        // Get changed TypeScript files (base to working tree, like nx affected)\n        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base);\n\n        if (changedFiles.length === 0) {\n            console.log('✅ No TypeScript files changed');\n            return { success: true };\n        }\n\n        console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);\n\n        // Find violations\n        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);\n\n        if (violations.length === 0) {\n            console.log('✅ All new methods are under ' + maxLines + ' lines');\n            return { success: true };\n        }\n\n        // Write instructions file\n        writeTmpInstructions(workspaceRoot);\n\n        // Report violations\n        console.error('');\n        console.error('❌ New methods exceed ' + maxLines + ' lines!');\n        console.error('');\n        console.error('📚 Methods should read like a \"table of contents\" - each method call');\n        console.error('   describes a larger piece of work. You can refactor');\n        console.error('   to stay under ' + maxLines + ' lines 50% of the time. If not feasible, use the escape hatch.');\n        console.error('');\n        console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');\n        console.error('');\n\n        for (const v of violations) {\n            console.error(`  ❌ ${v.file}:${v.line}`);\n            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);\n        }\n        console.error('');\n\n        return { success: false };\n    } catch (err: unknown) {\n        const error = err instanceof Error ? err : new Error(String(err));\n        console.error('❌ New method validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/dev-config/architecture/executors/validate-new-methods/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;GAgBG;;AAiaH,8BA8DC;;AA5dD,iDAAyC;AACzC,+CAAyB;AACzB,mDAA6B;AAC7B,uDAAiC;AAkBjC,MAAM,OAAO,GAAG,eAAe,CAAC;AAChC,MAAM,WAAW,GAAG,yBAAyB,CAAC;AAE9C,MAAM,sBAAsB,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAoH9B,CAAC;AAEF;;GAEG;AACH,SAAS,oBAAoB,CAAC,aAAqB;IAC/C,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,OAAO,CAAC,CAAC;IACjD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;IAE9C,EAAE,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC1C,EAAE,CAAC,aAAa,CAAC,MAAM,EAAE,sBAAsB,CAAC,CAAC;IAEjD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;;;GAIG;AACH,SAAS,yBAAyB,CAAC,aAAqB,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,MAAM,MAAM,GAAG,IAAA,wBAAQ,EAAC,wBAAwB,IAAI,oBAAoB,EAAE;YACtE,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;QACH,OAAO,MAAM;aACR,IAAI,EAAE;aACN,KAAK,CAAC,IAAI,CAAC;aACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC;IAChF,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;;;GAIG;AACH,SAAS,WAAW,CAAC,aAAqB,EAAE,IAAY,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,OAAO,IAAA,wBAAQ,EAAC,YAAY,IAAI,QAAQ,IAAI,GAAG,EAAE;YAC7C,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;IACP,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;GAEG;AACH,SAAS,6BAA6B,CAAC,WAAmB;IACtD,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAEtC,uCAAuC;IACvC,MAAM,QAAQ,GAAG;QACb,qEAAqE;QACrE,wDAAwD;QACxD,4CAA4C;QAC5C,iEAAiE;QACjE,mDAAmD;QACnD,uEAAuE;QACvE,gFAAgF;QAChF,+BAA+B;KAClC,CAAC;IAEF,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACvB,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAClD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;gBAC7B,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;gBAClC,IAAI,KAAK,EAAE,CAAC;oBACR,sDAAsD;oBACtD,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;oBAC5B,IAAI,UAAU,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,aAAa,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;wBAC/F,UAAU,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;oBAC/B,CAAC;oBACD,MAAM;gBACV,CAAC;YACL,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CAAC,KAAe,EAAE,UAAkB;IAC1D,iFAAiF;IACjF,0EAA0E;IAC1E,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,UAAU,GAAG,CAAC,CAAC,CAAC;IAC/C,KAAK,IAAI,CAAC,GAAG,UAAU,GAAG,CAAC,EAAE,CAAC,IAAI,UAAU,EAAE,CAAC,EAAE,EAAE,CAAC;QAChD,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QACpC,4CAA4C;QAC5C,IAAI,IAAI,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAClF,MAAM;QACV,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ,CAAC,mBAAmB,CAAC,EAAE,CAAC;YACrC,gEAAgE;YAChE,IAAI,IAAI,CAAC,QAAQ,CAAC,uBAAuB,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,4BAA4B,CAAC,EAAE,CAAC;gBACxF,OAAO,IAAI,CAAC;YAChB,CAAC;QACL,CAAC;IACL,CAAC;IACD,OAAO,KAAK,CAAC;AACjB,CAAC;AAED;;GAEG;AACH,SAAS,iBAAiB,CACtB,QAAgB,EAChB,aAAqB;IAErB,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,CAAC;IACpD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAExC,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,SAAS,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,UAAU,GAAG,EAAE,CAAC,gBAAgB,CAAC,QAAQ,EAAE,OAAO,EAAE,EAAE,CAAC,YAAY,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;IAExF,MAAM,OAAO,GAAqF,EAAE,CAAC;IAErG,SAAS,KAAK,CAAC,IAAa;QACxB,IAAI,UAA8B,CAAC;QACnC,IAAI,SAA6B,CAAC;QAClC,IAAI,OAA2B,CAAC;QAEhC,IAAI,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YAC5C,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YACrD,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,uCAAuC;YACvC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7E,UAAU,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;gBAClD,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;gBACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;gBACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;gBAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,CAAC;QACL,CAAC;QAED,IAAI,UAAU,IAAI,SAAS,KAAK,SAAS,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YACjE,OAAO,CAAC,IAAI,CAAC;gBACT,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,SAAS;gBACf,KAAK,EAAE,OAAO,GAAG,SAAS,GAAG,CAAC;gBAC9B,iBAAiB,EAAE,iBAAiB,CAAC,SAAS,EAAE,SAAS,CAAC;aAC7D,CAAC,CAAC;QACP,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IACjC,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,CAAC;IAClB,OAAO,OAAO,CAAC;AACnB,CAAC;AAED;;GAEG;AACH,SAAS,cAAc,CACnB,aAAqB,EACrB,YAAsB,EACtB,IAAY,EACZ,QAAgB;IAEhB,MAAM,UAAU,GAAsB,EAAE,CAAC;IAEzC,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;QAC9B,iEAAiE;QACjE,MAAM,IAAI,GAAG,WAAW,CAAC,aAAa,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;QACpD,MAAM,cAAc,GAAG,6BAA6B,CAAC,IAAI,CAAC,CAAC;QAE3D,IAAI,cAAc,CAAC,IAAI,KAAK,CAAC;YAAE,SAAS;QAExC,mDAAmD;QACnD,MAAM,OAAO,GAAG,iBAAiB,CAAC,IAAI,EAAE,aAAa,CAAC,CAAC;QAEvD,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC3B,mEAAmE;YACnE,IAAI,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,KAAK,GAAG,QAAQ,IAAI,CAAC,MAAM,CAAC,iBAAiB,EAAE,CAAC;gBAC1F,UAAU,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,UAAU,EAAE,MAAM,CAAC,IAAI;oBACvB,IAAI,EAAE,MAAM,CAAC,IAAI;oBACjB,KAAK,EAAE,MAAM,CAAC,KAAK;oBACnB,KAAK,EAAE,IAAI;iBACd,CAAC,CAAC;YACP,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;;GAGG;AACH,SAAS,UAAU,CAAC,aAAqB;IACrC,IAAI,CAAC;QACD,gDAAgD;QAChD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,iCAAiC,EAAE;YAC1D,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;YACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;SAClC,CAAC,CAAC,IAAI,EAAE,CAAC;QAEV,IAAI,SAAS,EAAE,CAAC;YACZ,OAAO,SAAS,CAAC;QACrB,CAAC;IACL,CAAC;IAAC,MAAM,CAAC;QACL,wCAAwC;QACxC,IAAI,CAAC;YACD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,0BAA0B,EAAE;gBACnD,GAAG,EAAE,aAAa;gBAClB,QAAQ,EAAE,OAAO;gBACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;aAClC,CAAC,CAAC,IAAI,EAAE,CAAC;YAEV,IAAI,SAAS,EAAE,CAAC;gBACZ,OAAO,SAAS,CAAC;YACrB,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACL,4BAA4B;QAChC,CAAC;IACL,CAAC;IACD,OAAO,IAAI,CAAC;AAChB,CAAC;AAED;;GAEG;AACH,SAAS,gBAAgB,CAAC,UAA6B,EAAE,QAAgB;IACrE,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,uBAAuB,GAAG,QAAQ,GAAG,SAAS,CAAC,CAAC;IAC9D,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,sEAAsE,CAAC,CAAC;IACtF,OAAO,CAAC,KAAK,CAAC,uDAAuD,CAAC,CAAC;IACvE,OAAO,CAAC,KAAK,CAAC,mBAAmB,GAAG,QAAQ,GAAG,yBAAyB,CAAC,CAAC;IAC1E,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,2GAA2G,CAAC,CAAC;IAC3H,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAElB,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;QACzB,OAAO,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QACzC,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,KAAK,gBAAgB,QAAQ,GAAG,CAAC,CAAC;IACvF,CAAC;IACD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAClB,OAAO,CAAC,KAAK,CAAC,yCAAyC,GAAG,QAAQ,GAAG,uCAAuC,CAAC,CAAC;IAC9G,OAAO,CAAC,KAAK,CAAC,+EAA+E,CAAC,CAAC;IAC/F,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;AACtB,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,OAAkC,EAClC,OAAwB;IAExB,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IACnC,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,IAAI,EAAE,CAAC;IAEnC,gEAAgE;IAChE,wEAAwE;IACxE,0EAA0E;IAC1E,IAAI,IAAI,GAAG,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;IAElC,IAAI,CAAC,IAAI,EAAE,CAAC;QACR,8CAA8C;QAC9C,IAAI,GAAG,UAAU,CAAC,aAAa,CAAC,IAAI,SAAS,CAAC;QAE9C,IAAI,CAAC,IAAI,EAAE,CAAC;YACR,OAAO,CAAC,GAAG,CAAC,qEAAqE,CAAC,CAAC;YACnF,OAAO,CAAC,GAAG,CAAC,oFAAoF,CAAC,CAAC;YAClG,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAChB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,yDAAyD,CAAC,CAAC;IAC3E,CAAC;SAAM,CAAC;QACJ,OAAO,CAAC,GAAG,CAAC,oCAAoC,CAAC,CAAC;IACtD,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC;IAChC,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;IAC5E,OAAO,CAAC,GAAG,CAAC,iCAAiC,QAAQ,EAAE,CAAC,CAAC;IACzD,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAEhB,IAAI,CAAC;QACD,wEAAwE;QACxE,MAAM,YAAY,GAAG,yBAAyB,CAAC,aAAa,EAAE,IAAI,CAAC,CAAC;QAEpE,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,+BAA+B,CAAC,CAAC;YAC7C,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,eAAe,YAAY,CAAC,MAAM,qBAAqB,CAAC,CAAC;QAErE,kBAAkB;QAClB,MAAM,UAAU,GAAG,cAAc,CAAC,aAAa,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,CAAC,CAAC;QAE/E,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,8BAA8B,GAAG,QAAQ,GAAG,QAAQ,CAAC,CAAC;YAClE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,gDAAgD;QAChD,oBAAoB,CAAC,aAAa,CAAC,CAAC;QACpC,gBAAgB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAEvC,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC;QAClE,OAAO,CAAC,KAAK,CAAC,iCAAiC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QAChE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate New Methods Executor\n *\n * Validates that newly added methods don't exceed a maximum line count.\n * Runs in affected mode when:\n *   1. NX_BASE environment variable is set (via nx affected), OR\n *   2. Auto-detects base by finding merge-base with origin/main\n *\n * This validator encourages writing methods that read like a \"table of contents\"\n * where each method call describes a larger piece of work.\n *\n * Usage:\n * nx affected --target=validate-new-methods --base=origin/main\n * OR: runs automatically via build's architecture:validate-complete dependency\n *\n * Escape hatch: Add webpieces-disable max-lines-new-methods comment with justification\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { execSync } from 'child_process';\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport * as ts from 'typescript';\n\nexport interface ValidateNewMethodsOptions {\n    max?: number;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\ninterface MethodViolation {\n    file: string;\n    methodName: string;\n    line: number;\n    lines: number;\n    isNew: boolean;\n}\n\nconst TMP_DIR = 'tmp/webpieces';\nconst TMP_MD_FILE = 'webpieces.methodsize.md';\n\nconst METHODSIZE_DOC_CONTENT = `# Instructions: New Method Too Long\n\n## Requirement\n\n**~50% of the time**, you can stay under the \\`newMethodsMaxLines\\` limit from nx.json\nby extracting logical units into well-named methods.\n\n**~99% of the time**, you can stay under the \\`modifiedAndNewMethodsMaxLines\\` limit from nx.json.\nNearly all software can be written with methods under this size.\n\n## The \"Table of Contents\" Principle\n\nGood code reads like a book's table of contents:\n- Chapter titles (method names) tell you WHAT happens\n- Reading chapter titles gives you the full story\n- You can dive into chapters (implementations) for details\n\n## Why Limit New Methods?\n\nMethods under the limit are:\n- Easy to review in a single screen\n- Simple to understand without scrolling\n- Quick for AI to analyze and suggest improvements\n- More testable in isolation\n- Self-documenting through well-named extracted methods\n\nExtracting logical units into well-named methods makes code more readable for both\nAI and humans.\n\n## How to Refactor\n\nInstead of:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    // 50 lines of validation, transformation, saving, notifications...\n}\n\\`\\`\\`\n\nWrite:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    const validated = this.validateOrder(order);\n    const transformed = this.applyBusinessRules(validated);\n    const saved = await this.saveToDatabase(transformed);\n    await this.notifyStakeholders(saved);\n    return this.buildResult(saved);\n}\n\\`\\`\\`\n\nNow the main method is a \"table of contents\" - each line tells part of the story!\n\n## Patterns for Extraction\n\n### Pattern 1: Extract Loop Bodies\n\\`\\`\\`typescript\n// BEFORE\nfor (const item of items) {\n    // 20 lines of processing\n}\n\n// AFTER\nfor (const item of items) {\n    this.processItem(item);\n}\n\\`\\`\\`\n\n### Pattern 2: Extract Conditional Blocks\n\\`\\`\\`typescript\n// BEFORE\nif (isAdmin(user)) {\n    // 15 lines of admin logic\n}\n\n// AFTER\nif (isAdmin(user)) {\n    this.handleAdminUser(user);\n}\n\\`\\`\\`\n\n### Pattern 3: Extract Data Transformations\n\\`\\`\\`typescript\n// BEFORE\nconst result = {\n    // 10+ lines of object construction\n};\n\n// AFTER\nconst result = this.buildResultObject(data);\n\\`\\`\\`\n\n## If Refactoring Is Not Feasible\n\nSometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).\n\n**Escape hatch**: Add a webpieces-disable comment with justification:\n\n\\`\\`\\`typescript\n// webpieces-disable max-lines-new-methods -- Complex state machine, splitting reduces clarity\nasync complexStateMachine(): Promise<void> {\n    // ... longer method with justification\n}\n\\`\\`\\`\n\n## AI Agent Action Steps\n\n1. **READ** the method to understand its logical sections\n2. **IDENTIFY** logical units that can be extracted\n3. **EXTRACT** into well-named private methods\n4. **VERIFY** the main method now reads like a table of contents\n5. **IF NOT FEASIBLE**: Add webpieces-disable max-lines-new-methods comment with clear justification\n\n## Remember\n\n- Every method you write today will be read many times tomorrow\n- The best code explains itself through structure\n- When in doubt, extract and name it\n`;\n\n/**\n * Write the instructions documentation to tmp directory\n */\nfunction writeTmpInstructions(workspaceRoot: string): string {\n    const tmpDir = path.join(workspaceRoot, TMP_DIR);\n    const mdPath = path.join(tmpDir, TMP_MD_FILE);\n\n    fs.mkdirSync(tmpDir, { recursive: true });\n    fs.writeFileSync(mdPath, METHODSIZE_DOC_CONTENT);\n\n    return mdPath;\n}\n\n/**\n * Get changed TypeScript files between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getChangedTypeScriptFiles(workspaceRoot: string, base: string): string[] {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        const output = execSync(`git diff --name-only ${base} -- '*.ts' '*.tsx'`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n        return output\n            .trim()\n            .split('\\n')\n            .filter((f) => f && !f.includes('.spec.ts') && !f.includes('.test.ts'));\n    } catch {\n        return [];\n    }\n}\n\n/**\n * Get the diff content for a specific file between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getFileDiff(workspaceRoot: string, file: string, base: string): string {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        return execSync(`git diff ${base} -- \"${file}\"`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n    } catch {\n        return '';\n    }\n}\n\n/**\n * Parse diff to find newly added method signatures\n */\nfunction findNewMethodSignaturesInDiff(diffContent: string): Set<string> {\n    const newMethods = new Set<string>();\n    const lines = diffContent.split('\\n');\n\n    // Patterns to match method definitions\n    const patterns = [\n        // [export] [async] function methodName( - most explicit, check first\n        /^\\+\\s*(?:export\\s+)?(?:async\\s+)?function\\s+(\\w+)\\s*\\(/,\n        // [export] const/let methodName = [async] (\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s*)?\\(/,\n        // [export] const/let methodName = [async] function\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s+)?function/,\n        // class method: [async] methodName( - but NOT constructor, if, for, while, etc.\n        /^\\+\\s*(?:async\\s+)?(\\w+)\\s*\\(/,\n    ];\n\n    for (const line of lines) {\n        if (line.startsWith('+') && !line.startsWith('+++')) {\n            for (const pattern of patterns) {\n                const match = line.match(pattern);\n                if (match) {\n                    // Extract method name - now always in capture group 1\n                    const methodName = match[1];\n                    if (methodName && !['if', 'for', 'while', 'switch', 'catch', 'constructor'].includes(methodName)) {\n                        newMethods.add(methodName);\n                    }\n                    break;\n                }\n            }\n        }\n    }\n\n    return newMethods;\n}\n\n/**\n * Check if a line contains a webpieces-disable comment that exempts from new method validation.\n * Both max-lines-new-methods AND max-lines-new-and-modified are accepted here.\n * - max-lines-new-methods: Exempts from 30-line check, still checked by 80-line validator\n * - max-lines-new-and-modified: Exempts from both validators (ultimate escape hatch)\n */\nfunction hasDisableComment(lines: string[], lineNumber: number): boolean {\n    // Check the line before the method (lineNumber is 1-indexed, array is 0-indexed)\n    // We need to check a few lines before in case there's JSDoc or decorators\n    const startCheck = Math.max(0, lineNumber - 5);\n    for (let i = lineNumber - 2; i >= startCheck; i--) {\n        const line = lines[i]?.trim() ?? '';\n        // Stop if we hit another function/class/etc\n        if (line.startsWith('function ') || line.startsWith('class ') || line.endsWith('}')) {\n            break;\n        }\n        if (line.includes('webpieces-disable')) {\n            // Either escape hatch exempts from the 30-line new method check\n            if (line.includes('max-lines-new-methods') || line.includes('max-lines-new-and-modified')) {\n                return true;\n            }\n        }\n    }\n    return false;\n}\n\n/**\n * Parse a TypeScript file and find methods with their line counts\n */\nfunction findMethodsInFile(\n    filePath: string,\n    workspaceRoot: string\n): Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> {\n    const fullPath = path.join(workspaceRoot, filePath);\n    if (!fs.existsSync(fullPath)) return [];\n\n    const content = fs.readFileSync(fullPath, 'utf-8');\n    const fileLines = content.split('\\n');\n    const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);\n\n    const methods: Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> = [];\n\n    function visit(node: ts.Node): void {\n        let methodName: string | undefined;\n        let startLine: number | undefined;\n        let endLine: number | undefined;\n\n        if (ts.isMethodDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isFunctionDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isArrowFunction(node)) {\n            // Check if it's assigned to a variable\n            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {\n                methodName = node.parent.name.getText(sourceFile);\n                const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n                const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n                startLine = start.line + 1;\n                endLine = end.line + 1;\n            }\n        }\n\n        if (methodName && startLine !== undefined && endLine !== undefined) {\n            methods.push({\n                name: methodName,\n                line: startLine,\n                lines: endLine - startLine + 1,\n                hasDisableComment: hasDisableComment(fileLines, startLine),\n            });\n        }\n\n        ts.forEachChild(node, visit);\n    }\n\n    visit(sourceFile);\n    return methods;\n}\n\n/**\n * Find new methods that exceed the line limit\n */\nfunction findViolations(\n    workspaceRoot: string,\n    changedFiles: string[],\n    base: string,\n    maxLines: number\n): MethodViolation[] {\n    const violations: MethodViolation[] = [];\n\n    for (const file of changedFiles) {\n        // Get the diff to find which methods are NEW (not just modified)\n        const diff = getFileDiff(workspaceRoot, file, base);\n        const newMethodNames = findNewMethodSignaturesInDiff(diff);\n\n        if (newMethodNames.size === 0) continue;\n\n        // Parse the current file to get method line counts\n        const methods = findMethodsInFile(file, workspaceRoot);\n\n        for (const method of methods) {\n            // Only check NEW methods that don't have webpieces-disable comment\n            if (newMethodNames.has(method.name) && method.lines > maxLines && !method.hasDisableComment) {\n                violations.push({\n                    file,\n                    methodName: method.name,\n                    line: method.line,\n                    lines: method.lines,\n                    isNew: true,\n                });\n            }\n        }\n    }\n\n    return violations;\n}\n\n/**\n * Auto-detect the base branch by finding the merge-base with origin/main.\n * This allows the executor to run even when NX_BASE isn't set (e.g., via dependsOn).\n */\nfunction detectBase(workspaceRoot: string): string | null {\n    try {\n        // First, try to get merge-base with origin/main\n        const mergeBase = execSync('git merge-base HEAD origin/main', {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n            stdio: ['pipe', 'pipe', 'pipe'],\n        }).trim();\n\n        if (mergeBase) {\n            return mergeBase;\n        }\n    } catch {\n        // origin/main might not exist, try main\n        try {\n            const mergeBase = execSync('git merge-base HEAD main', {\n                cwd: workspaceRoot,\n                encoding: 'utf-8',\n                stdio: ['pipe', 'pipe', 'pipe'],\n            }).trim();\n\n            if (mergeBase) {\n                return mergeBase;\n            }\n        } catch {\n            // Ignore - will return null\n        }\n    }\n    return null;\n}\n\n/**\n * Report violations to the user with helpful instructions\n */\nfunction reportViolations(violations: MethodViolation[], maxLines: number): void {\n    console.error('');\n    console.error('❌ New methods exceed ' + maxLines + ' lines!');\n    console.error('');\n    console.error('📚 Methods should read like a \"table of contents\" - each method call');\n    console.error('   describes a larger piece of work. You can refactor');\n    console.error('   to stay under ' + maxLines + ' lines 50% of the time.');\n    console.error('');\n    console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');\n    console.error('');\n\n    for (const v of violations) {\n        console.error(`  ❌ ${v.file}:${v.line}`);\n        console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);\n    }\n    console.error('');\n    console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');\n    console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');\n    console.error('');\n}\n\nexport default async function runExecutor(\n    options: ValidateNewMethodsOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const workspaceRoot = context.root;\n    const maxLines = options.max ?? 30;\n\n    // Check if running in affected mode via NX_BASE, or auto-detect\n    // We use NX_BASE as the base, and compare to WORKING TREE (not NX_HEAD)\n    // This matches what `nx affected` does - it compares base to working tree\n    let base = process.env['NX_BASE'];\n\n    if (!base) {\n        // Try to auto-detect base from git merge-base\n        base = detectBase(workspaceRoot) ?? undefined;\n\n        if (!base) {\n            console.log('\\n⏭️  Skipping new method validation (could not detect base branch)');\n            console.log('   To run explicitly: nx affected --target=validate-new-methods --base=origin/main');\n            console.log('');\n            return { success: true };\n        }\n\n        console.log('\\n📏 Validating New Method Sizes (auto-detected base)\\n');\n    } else {\n        console.log('\\n📏 Validating New Method Sizes\\n');\n    }\n\n    console.log(`   Base: ${base}`);\n    console.log(`   Comparing to: working tree (includes uncommitted changes)`);\n    console.log(`   Max lines for new methods: ${maxLines}`);\n    console.log('');\n\n    try {\n        // Get changed TypeScript files (base to working tree, like nx affected)\n        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base);\n\n        if (changedFiles.length === 0) {\n            console.log('✅ No TypeScript files changed');\n            return { success: true };\n        }\n\n        console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);\n\n        // Find violations\n        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);\n\n        if (violations.length === 0) {\n            console.log('✅ All new methods are under ' + maxLines + ' lines');\n            return { success: true };\n        }\n\n        // Write instructions file and report violations\n        writeTmpInstructions(workspaceRoot);\n        reportViolations(violations, maxLines);\n\n        return { success: false };\n    } catch (err: unknown) {\n        const error = err instanceof Error ? err : new Error(String(err));\n        console.error('❌ New method validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}

package/architecture/executors/validate-new-methods/executor.ts

@@ -407,6 +407,30 @@ function detectBase(workspaceRoot: string): string | null {
     return null;
 }
 
+/**
+ * Report violations to the user with helpful instructions
+ */
+function reportViolations(violations: MethodViolation[], maxLines: number): void {
+    console.error('');
+    console.error('❌ New methods exceed ' + maxLines + ' lines!');
+    console.error('');
+    console.error('📚 Methods should read like a "table of contents" - each method call');
+    console.error('   describes a larger piece of work. You can refactor');
+    console.error('   to stay under ' + maxLines + ' lines 50% of the time.');
+    console.error('');
+    console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
+    console.error('');
+
+    for (const v of violations) {
+        console.error(`  ❌ ${v.file}:${v.line}`);
+        console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
+    }
+    console.error('');
+    console.error('   If you REALLY REALLY need more than ' + maxLines + ' lines, this happens 50% of the time,');
+    console.error('   so use escape: // webpieces-disable max-lines-new-methods -- [your reason]');
+    console.error('');
+}
+
 export default async function runExecutor(
     options: ValidateNewMethodsOptions,
     context: ExecutorContext
@@ -459,25 +483,9 @@ export default async function runExecutor(
             return { success: true };
         }
 
-        // Write instructions file
+        // Write instructions file and report violations
         writeTmpInstructions(workspaceRoot);
-
-        // Report violations
-        console.error('');
-        console.error('❌ New methods exceed ' + maxLines + ' lines!');
-        console.error('');
-        console.error('📚 Methods should read like a "table of contents" - each method call');
-        console.error('   describes a larger piece of work. You can refactor');
-        console.error('   to stay under ' + maxLines + ' lines 50% of the time. If not feasible, use the escape hatch.');
-        console.error('');
-        console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
-        console.error('');
-
-        for (const v of violations) {
-            console.error(`  ❌ ${v.file}:${v.line}`);
-            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
-        }
-        console.error('');
+        reportViolations(violations, maxLines);
 
         return { success: false };
     } catch (err: unknown) {