@webpieces/ai-hook-rules 0.3.184 → 0.3.186

package/src/core/rules/no-symbol-di-tokens.js

@@ -1,6 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoSymbolDiTokensRule = void 0;
+const rules_config_1 = require("@webpieces/rules-config");
 const types_1 = require("../types");
+const rule_base_1 = require("../rule-base");
 const SYMBOL_DI_REGEX = /=\s*Symbol(?:\.for)?\(/;
 const TEST_PATHS = [/\.test\.ts$/, /\.spec\.ts$/, /__tests__\//];
 function globToRegex(pattern) {
@@ -40,20 +43,19 @@ function isAllowedPath(relativePath, allowedPaths) {
         return true;
     return allowedPaths.some((pattern) => globToRegex(pattern).test(relativePath));
 }
-const noSymbolDiTokensRule = {
-    name: 'no-symbol-di-tokens',
-    description: 'Disallow Symbol() DI tokens outside explicitly configured paths. Use @provideSingleton() + inject-by-type instead.',
-    scope: 'edit',
-    files: ['**/*.ts', '**/*.tsx'],
-    defaultOptions: { allowedPaths: [] },
-    fixHint: [
+class NoSymbolDiTokensRule extends rule_base_1.EditRuleBase {
+    constructor(config) { super(config, 'no-symbol-di-tokens'); }
+    description = 'Disallow Symbol() DI tokens outside explicitly configured paths. Use @provideSingleton() + inject-by-type instead.';
+    files = ['**/*.ts', '**/*.tsx'];
+    defaultOptions = { allowedPaths: [] };
+    fixHint = [
         'Option 1: Use @provideSingleton() on the class and inject by type — no Symbol needed.',
         'Option 2: Implement an API interface — import the Symbol from the API definition and use @provideSingletonAs(TOKEN).',
         'Option 3: External lib class (DataSource, Anthropic, etc.) — bind<Cls>(Cls).toDynamicValue(...).inSingletonScope() — no Symbol.',
         'Option 4 (last resort): // webpieces-disable no-symbol-di-tokens -- <reason>',
-    ],
+    ];
     check(ctx) {
-        const allowedPaths = ctx.options['allowedPaths'] ?? [];
+        const allowedPaths = this.config.allowedPaths ?? [];
         if (isAllowedPath(ctx.relativePath, allowedPaths))
             return [];
         const violations = [];
@@ -62,12 +64,12 @@ const noSymbolDiTokensRule = {
             if (!SYMBOL_DI_REGEX.test(stripped ?? ''))
                 continue;
             const lineNum = i + 1;
-            if (ctx.isLineDisabled(lineNum, 'no-symbol-di-tokens'))
+            if (ctx.isLineDisabled(lineNum, rules_config_1.RULE_NAMES.NO_SYMBOL_DI_TOKENS))
                 continue;
             violations.push(new types_1.Violation(lineNum, ctx.lines[i]?.trim() ?? '', 'Symbol() used as a DI token. Mostly we avoid Symbol if we can — see fix options below.'));
         }
         return violations;
-    },
-};
-exports.default = noSymbolDiTokensRule;
+    }
+}
+exports.NoSymbolDiTokensRule = NoSymbolDiTokensRule;
 //# sourceMappingURL=no-symbol-di-tokens.js.map

package/src/core/rules/no-symbol-di-tokens.js.map

@@ -1 +1 @@
-{"version":3,"file":"no-symbol-di-tokens.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/no-symbol-di-tokens.ts"],"names":[],"mappings":";;AACA,oCAA0C;AAE1C,MAAM,eAAe,GAAG,wBAAwB,CAAC;AAEjD,MAAM,UAAU,GAAa,CAAC,aAAa,EAAE,aAAa,EAAE,aAAa,CAAC,CAAC;AAE3E,SAAS,WAAW,CAAC,OAAe;IAChC,IAAI,EAAE,GAAG,EAAE,CAAC;IACZ,IAAI,CAAC,GAAG,CAAC,CAAC;IACV,OAAO,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC;QACxB,MAAM,EAAE,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;QACtB,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;YACb,IAAI,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC;gBACzB,EAAE,IAAI,IAAI,CAAC;gBACX,CAAC,IAAI,CAAC,CAAC;gBACP,IAAI,OAAO,CAAC,CAAC,CAAC,KAAK,GAAG;oBAAE,CAAC,IAAI,CAAC,CAAC;gBAC/B,SAAS;YACb,CAAC;YACD,EAAE,IAAI,OAAO,CAAC;YACd,CAAC,IAAI,CAAC,CAAC;YACP,SAAS;QACb,CAAC;QACD,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;YACb,EAAE,IAAI,MAAM,CAAC;YACb,CAAC,IAAI,CAAC,CAAC;YACP,SAAS;QACb,CAAC;QACD,IAAI,eAAe,CAAC,QAAQ,CAAC,EAAE,CAAC,EAAE,CAAC;YAC/B,EAAE,IAAI,IAAI,GAAG,EAAE,CAAC;YAChB,CAAC,IAAI,CAAC,CAAC;YACP,SAAS;QACb,CAAC;QACD,EAAE,IAAI,EAAE,CAAC;QACT,CAAC,IAAI,CAAC,CAAC;IACX,CAAC;IACD,OAAO,IAAI,MAAM,CAAC,GAAG,GAAG,EAAE,GAAG,GAAG,CAAC,CAAC;AACtC,CAAC;AAED,SAAS,aAAa,CAAC,YAAoB,EAAE,YAA+B;IACxE,IAAI,UAAU,CAAC,IAAI,CAAC,CAAC,EAAU,EAAE,EAAE,CAAC,EAAE,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IACxE,OAAO,YAAY,CAAC,IAAI,CAAC,CAAC,OAAe,EAAE,EAAE,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC;AAC3F,CAAC;AAED,MAAM,oBAAoB,GAAa;IACnC,IAAI,EAAE,qBAAqB;IAC3B,WAAW,EAAE,oHAAoH;IACjI,KAAK,EAAE,MAAM;IACb,KAAK,EAAE,CAAC,SAAS,EAAE,UAAU,CAAC;IAC9B,cAAc,EAAE,EAAE,YAAY,EAAE,EAAE,EAAE;IACpC,OAAO,EAAE;QACL,uFAAuF;QACvF,sHAAsH;QACtH,iIAAiI;QACjI,8EAA8E;KACjF;IAED,KAAK,CAAC,GAAgB;QAClB,MAAM,YAAY,GAAI,GAAG,CAAC,OAAO,CAAC,cAAc,CAA0B,IAAI,EAAE,CAAC;QACjF,IAAI,aAAa,CAAC,GAAG,CAAC,YAAY,EAAE,YAAY,CAAC;YAAE,OAAO,EAAE,CAAC;QAE7D,MAAM,UAAU,GAAQ,EAAE,CAAC;QAC3B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;YACnD,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,IAAI,EAAE,CAAC;gBAAE,SAAS;YACpD,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;YACtB,IAAI,GAAG,CAAC,cAAc,CAAC,OAAO,EAAE,qBAAqB,CAAC;gBAAE,SAAS;YACjE,UAAU,CAAC,IAAI,CAAC,IAAI,iBAAC,CACjB,OAAO,EACP,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,EAC1B,wFAAwF,CAC3F,CAAC,CAAC;QACP,CAAC;QACD,OAAO,UAAU,CAAC;IACtB,CAAC;CACJ,CAAC;AAEF,kBAAe,oBAAoB,CAAC","sourcesContent":["import type { EditRule, EditContext, Violation } from '../types';\nimport { Violation as V } from '../types';\n\nconst SYMBOL_DI_REGEX = /=\\s*Symbol(?:\\.for)?\\(/;\n\nconst TEST_PATHS: RegExp[] = [/\\.test\\.ts$/, /\\.spec\\.ts$/, /__tests__\\//];\n\nfunction globToRegex(pattern: string): RegExp {\n    let re = '';\n    let i = 0;\n    while (i < pattern.length) {\n        const ch = pattern[i];\n        if (ch === '*') {\n            if (pattern[i + 1] === '*') {\n                re += '.*';\n                i += 2;\n                if (pattern[i] === '/') i += 1;\n                continue;\n            }\n            re += '[^/]*';\n            i += 1;\n            continue;\n        }\n        if (ch === '?') {\n            re += '[^/]';\n            i += 1;\n            continue;\n        }\n        if ('.+^$(){}|[]\\\\'.includes(ch)) {\n            re += '\\\\' + ch;\n            i += 1;\n            continue;\n        }\n        re += ch;\n        i += 1;\n    }\n    return new RegExp('^' + re + '$');\n}\n\nfunction isAllowedPath(relativePath: string, allowedPaths: readonly string[]): boolean {\n    if (TEST_PATHS.some((re: RegExp) => re.test(relativePath))) return true;\n    return allowedPaths.some((pattern: string) => globToRegex(pattern).test(relativePath));\n}\n\nconst noSymbolDiTokensRule: EditRule = {\n    name: 'no-symbol-di-tokens',\n    description: 'Disallow Symbol() DI tokens outside explicitly configured paths. Use @provideSingleton() + inject-by-type instead.',\n    scope: 'edit',\n    files: ['**/*.ts', '**/*.tsx'],\n    defaultOptions: { allowedPaths: [] },\n    fixHint: [\n        'Option 1: Use @provideSingleton() on the class and inject by type — no Symbol needed.',\n        'Option 2: Implement an API interface — import the Symbol from the API definition and use @provideSingletonAs(TOKEN).',\n        'Option 3: External lib class (DataSource, Anthropic, etc.) — bind<Cls>(Cls).toDynamicValue(...).inSingletonScope() — no Symbol.',\n        'Option 4 (last resort): // webpieces-disable no-symbol-di-tokens -- <reason>',\n    ],\n\n    check(ctx: EditContext): readonly Violation[] {\n        const allowedPaths = (ctx.options['allowedPaths'] as string[] | undefined) ?? [];\n        if (isAllowedPath(ctx.relativePath, allowedPaths)) return [];\n\n        const violations: V[] = [];\n        for (let i = 0; i < ctx.strippedLines.length; i += 1) {\n            const stripped = ctx.strippedLines[i];\n            if (!SYMBOL_DI_REGEX.test(stripped ?? '')) continue;\n            const lineNum = i + 1;\n            if (ctx.isLineDisabled(lineNum, 'no-symbol-di-tokens')) continue;\n            violations.push(new V(\n                lineNum,\n                ctx.lines[i]?.trim() ?? '',\n                'Symbol() used as a DI token. Mostly we avoid Symbol if we can — see fix options below.',\n            ));\n        }\n        return violations;\n    },\n};\n\nexport default noSymbolDiTokensRule;\n"]}
+{"version":3,"file":"no-symbol-di-tokens.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/no-symbol-di-tokens.ts"],"names":[],"mappings":";;;AAAA,0DAA6E;AAG7E,oCAA0C;AAC1C,4CAA4C;AAE5C,MAAM,eAAe,GAAG,wBAAwB,CAAC;AAEjD,MAAM,UAAU,GAAa,CAAC,aAAa,EAAE,aAAa,EAAE,aAAa,CAAC,CAAC;AAE3E,SAAS,WAAW,CAAC,OAAe;IAChC,IAAI,EAAE,GAAG,EAAE,CAAC;IACZ,IAAI,CAAC,GAAG,CAAC,CAAC;IACV,OAAO,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC;QACxB,MAAM,EAAE,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;QACtB,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;YACb,IAAI,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC;gBACzB,EAAE,IAAI,IAAI,CAAC;gBACX,CAAC,IAAI,CAAC,CAAC;gBACP,IAAI,OAAO,CAAC,CAAC,CAAC,KAAK,GAAG;oBAAE,CAAC,IAAI,CAAC,CAAC;gBAC/B,SAAS;YACb,CAAC;YACD,EAAE,IAAI,OAAO,CAAC;YACd,CAAC,IAAI,CAAC,CAAC;YACP,SAAS;QACb,CAAC;QACD,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;YACb,EAAE,IAAI,MAAM,CAAC;YACb,CAAC,IAAI,CAAC,CAAC;YACP,SAAS;QACb,CAAC;QACD,IAAI,eAAe,CAAC,QAAQ,CAAC,EAAE,CAAC,EAAE,CAAC;YAC/B,EAAE,IAAI,IAAI,GAAG,EAAE,CAAC;YAChB,CAAC,IAAI,CAAC,CAAC;YACP,SAAS;QACb,CAAC;QACD,EAAE,IAAI,EAAE,CAAC;QACT,CAAC,IAAI,CAAC,CAAC;IACX,CAAC;IACD,OAAO,IAAI,MAAM,CAAC,GAAG,GAAG,EAAE,GAAG,GAAG,CAAC,CAAC;AACtC,CAAC;AAED,SAAS,aAAa,CAAC,YAAoB,EAAE,YAA+B;IACxE,IAAI,UAAU,CAAC,IAAI,CAAC,CAAC,EAAU,EAAE,EAAE,CAAC,EAAE,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IACxE,OAAO,YAAY,CAAC,IAAI,CAAC,CAAC,OAAe,EAAE,EAAE,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC;AAC3F,CAAC;AAED,MAAa,oBAAqB,SAAQ,wBAAoC;IAC1E,YAAY,MAA8B,IAAI,KAAK,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC,CAAC,CAAC;IAE5E,WAAW,GAAG,oHAAoH,CAAC;IAC1H,KAAK,GAAG,CAAC,SAAS,EAAE,UAAU,CAAC,CAAC;IAChC,cAAc,GAAG,EAAE,YAAY,EAAE,EAAE,EAAE,CAAC;IAC/C,OAAO,GAAG;QACf,uFAAuF;QACvF,sHAAsH;QACtH,iIAAiI;QACjI,8EAA8E;KACjF,CAAC;IAEF,KAAK,CAAC,GAAgB;QAClB,MAAM,YAAY,GAAG,IAAI,CAAC,MAAM,CAAC,YAAY,IAAI,EAAE,CAAC;QACpD,IAAI,aAAa,CAAC,GAAG,CAAC,YAAY,EAAE,YAAY,CAAC;YAAE,OAAO,EAAE,CAAC;QAE7D,MAAM,UAAU,GAAQ,EAAE,CAAC;QAC3B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;YACnD,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,IAAI,EAAE,CAAC;gBAAE,SAAS;YACpD,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;YACtB,IAAI,GAAG,CAAC,cAAc,CAAC,OAAO,EAAE,yBAAU,CAAC,mBAAmB,CAAC;gBAAE,SAAS;YAC1E,UAAU,CAAC,IAAI,CAAC,IAAI,iBAAC,CACjB,OAAO,EACP,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,EAC1B,wFAAwF,CAC3F,CAAC,CAAC;QACP,CAAC;QACD,OAAO,UAAU,CAAC;IACtB,CAAC;CACJ;AA/BD,oDA+BC","sourcesContent":["import { NoSymbolDiTokensConfig, RULE_NAMES } from '@webpieces/rules-config';\n\nimport type { EditContext, Violation } from '../types';\nimport { Violation as V } from '../types';\nimport { EditRuleBase } from '../rule-base';\n\nconst SYMBOL_DI_REGEX = /=\\s*Symbol(?:\\.for)?\\(/;\n\nconst TEST_PATHS: RegExp[] = [/\\.test\\.ts$/, /\\.spec\\.ts$/, /__tests__\\//];\n\nfunction globToRegex(pattern: string): RegExp {\n    let re = '';\n    let i = 0;\n    while (i < pattern.length) {\n        const ch = pattern[i];\n        if (ch === '*') {\n            if (pattern[i + 1] === '*') {\n                re += '.*';\n                i += 2;\n                if (pattern[i] === '/') i += 1;\n                continue;\n            }\n            re += '[^/]*';\n            i += 1;\n            continue;\n        }\n        if (ch === '?') {\n            re += '[^/]';\n            i += 1;\n            continue;\n        }\n        if ('.+^$(){}|[]\\\\'.includes(ch)) {\n            re += '\\\\' + ch;\n            i += 1;\n            continue;\n        }\n        re += ch;\n        i += 1;\n    }\n    return new RegExp('^' + re + '$');\n}\n\nfunction isAllowedPath(relativePath: string, allowedPaths: readonly string[]): boolean {\n    if (TEST_PATHS.some((re: RegExp) => re.test(relativePath))) return true;\n    return allowedPaths.some((pattern: string) => globToRegex(pattern).test(relativePath));\n}\n\nexport class NoSymbolDiTokensRule extends EditRuleBase<NoSymbolDiTokensConfig> {\n    constructor(config: NoSymbolDiTokensConfig) { super(config, 'no-symbol-di-tokens'); }\n\n    readonly description = 'Disallow Symbol() DI tokens outside explicitly configured paths. Use @provideSingleton() + inject-by-type instead.';\n    override readonly files = ['**/*.ts', '**/*.tsx'];\n    override readonly defaultOptions = { allowedPaths: [] };\n    readonly fixHint = [\n        'Option 1: Use @provideSingleton() on the class and inject by type — no Symbol needed.',\n        'Option 2: Implement an API interface — import the Symbol from the API definition and use @provideSingletonAs(TOKEN).',\n        'Option 3: External lib class (DataSource, Anthropic, etc.) — bind<Cls>(Cls).toDynamicValue(...).inSingletonScope() — no Symbol.',\n        'Option 4 (last resort): // webpieces-disable no-symbol-di-tokens -- <reason>',\n    ];\n\n    check(ctx: EditContext): readonly Violation[] {\n        const allowedPaths = this.config.allowedPaths ?? [];\n        if (isAllowedPath(ctx.relativePath, allowedPaths)) return [];\n\n        const violations: V[] = [];\n        for (let i = 0; i < ctx.strippedLines.length; i += 1) {\n            const stripped = ctx.strippedLines[i];\n            if (!SYMBOL_DI_REGEX.test(stripped ?? '')) continue;\n            const lineNum = i + 1;\n            if (ctx.isLineDisabled(lineNum, RULE_NAMES.NO_SYMBOL_DI_TOKENS)) continue;\n            violations.push(new V(\n                lineNum,\n                ctx.lines[i]?.trim() ?? '',\n                'Symbol() used as a DI token. Mostly we avoid Symbol if we can — see fix options below.',\n            ));\n        }\n        return violations;\n    }\n}\n"]}

package/src/core/rules/no-unmanaged-exceptions.d.ts

@@ -1,3 +1,10 @@
-import type { EditRule } from '../types';
-declare const noUnmanagedExceptionsRule: EditRule;
-export default noUnmanagedExceptionsRule;
+import { NoUnmanagedExceptionsConfig } from '@webpieces/rules-config';
+import type { EditContext, Violation } from '../types';
+import { EditRuleBase } from '../rule-base';
+export declare class NoUnmanagedExceptionsRule extends EditRuleBase<NoUnmanagedExceptionsConfig> {
+    constructor(config: NoUnmanagedExceptionsConfig);
+    readonly description = "try/catch is generally not allowed. Only allowed in chokepoints (filter, globalErrorHandler) or other rare locations.";
+    readonly files: string[];
+    readonly fixHint: string[];
+    check(ctx: EditContext): readonly Violation[];
+}

package/src/core/rules/no-unmanaged-exceptions.js

@@ -1,17 +1,24 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoUnmanagedExceptionsRule = void 0;
+const rules_config_1 = require("@webpieces/rules-config");
 const types_1 = require("../types");
+const rule_base_1 = require("../rule-base");
 const instruct_ai_writer_1 = require("../instruct-ai-writer");
 const TRY_PATTERN = /\btry\s*\{/;
 // Both webpieces-disable and the existing ESLint directive suppress this rule
 const DISABLE_PATTERN = /@webpieces\/no-unmanaged-exceptions|webpieces-disable\s+(?:[\w-]+,\s*)*no-unmanaged-exceptions/;
-const noUnmanagedExceptionsRule = {
-    name: 'no-unmanaged-exceptions',
-    description: 'try/catch is generally not allowed. Only allowed in chokepoints (filter, globalErrorHandler) or other rare locations.',
-    scope: 'edit',
-    files: ['**/*.ts', '**/*.tsx'],
-    defaultOptions: {},
-    fixHint: [
+function hasPrecedingDisable(lines, idx) {
+    if (idx === 0)
+        return false;
+    const prevLine = lines[idx - 1];
+    return DISABLE_PATTERN.test(prevLine);
+}
+class NoUnmanagedExceptionsRule extends rule_base_1.EditRuleBase {
+    constructor(config) { super(config, 'no-unmanaged-exceptions'); }
+    description = 'try/catch is generally not allowed. Only allowed in chokepoints (filter, globalErrorHandler) or other rare locations.';
+    files = ['**/*.ts', '**/*.tsx'];
+    fixHint = [
         'Fix Option 1 (preferred): Remove the try/catch — let the exception bubble to the top-level chokepoint (filter, globalErrorHandler) where it is already logged and handled.',
         'Fix Option 2 (ask the human first): If you genuinely believe this IS a chokepoint, STOP and tell the human:',
         '  - What exception could be thrown here',
@@ -20,7 +27,7 @@ const noUnmanagedExceptionsRule = {
         '  Then ask: "Should I add a disable comment or remove the try/catch?"',
         '  Only add // webpieces-disable no-unmanaged-exceptions -- <reason> if the human says yes.',
         'NOTE: If the code is calling an external process (execSync, fs, network), the correct answer is almost always Option 1 — let it throw. Hooks have a top-level runner that reports errors properly.',
-    ],
+    ];
     check(ctx) {
         const violations = [];
         for (let i = 0; i < ctx.strippedLines.length; i += 1) {
@@ -28,7 +35,7 @@ const noUnmanagedExceptionsRule = {
             if (!TRY_PATTERN.test(stripped))
                 continue;
             const lineNum = i + 1;
-            if (ctx.isLineDisabled(lineNum, 'no-unmanaged-exceptions'))
+            if (ctx.isLineDisabled(lineNum, rules_config_1.RULE_NAMES.NO_UNMANAGED_EXCEPTIONS))
                 continue;
             if (hasPrecedingDisable(ctx.lines, i))
                 continue;
@@ -37,13 +44,7 @@ const noUnmanagedExceptionsRule = {
         if (violations.length > 0)
             (0, instruct_ai_writer_1.writeTemplateIfMissing)(ctx.workspaceRoot, 'webpieces.exceptions.md');
         return violations;
-    },
-};
-function hasPrecedingDisable(lines, idx) {
-    if (idx === 0)
-        return false;
-    const prevLine = lines[idx - 1];
-    return DISABLE_PATTERN.test(prevLine);
+    }
 }
-exports.default = noUnmanagedExceptionsRule;
+exports.NoUnmanagedExceptionsRule = NoUnmanagedExceptionsRule;
 //# sourceMappingURL=no-unmanaged-exceptions.js.map

package/src/core/rules/no-unmanaged-exceptions.js.map

@@ -1 +1 @@
-{"version":3,"file":"no-unmanaged-exceptions.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/no-unmanaged-exceptions.ts"],"names":[],"mappings":";;AACA,oCAA0C;AAC1C,8DAA+D;AAE/D,MAAM,WAAW,GAAG,YAAY,CAAC;AAEjC,8EAA8E;AAC9E,MAAM,eAAe,GAAG,gGAAgG,CAAC;AAEzH,MAAM,yBAAyB,GAAa;IACxC,IAAI,EAAE,yBAAyB;IAC/B,WAAW,EAAE,uHAAuH;IACpI,KAAK,EAAE,MAAM;IACb,KAAK,EAAE,CAAC,SAAS,EAAE,UAAU,CAAC;IAC9B,cAAc,EAAE,EAAE;IAClB,OAAO,EAAE;QACL,4KAA4K;QAC5K,6GAA6G;QAC7G,yCAAyC;QACzC,2FAA2F;QAC3F,0EAA0E;QAC1E,uEAAuE;QACvE,4FAA4F;QAC5F,oMAAoM;KACvM;IAED,KAAK,CAAC,GAAgB;QAClB,MAAM,UAAU,GAAQ,EAAE,CAAC;QAC3B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;YACnD,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC;gBAAE,SAAS;YAC1C,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;YACtB,IAAI,GAAG,CAAC,cAAc,CAAC,OAAO,EAAE,yBAAyB,CAAC;gBAAE,SAAS;YACrE,IAAI,mBAAmB,CAAC,GAAG,CAAC,KAAK,EAAE,CAAC,CAAC;gBAAE,SAAS;YAChD,UAAU,CAAC,IAAI,CAAC,IAAI,iBAAC,CACjB,OAAO,EACP,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,EACnB,gLAAgL,CACnL,CAAC,CAAC;QACP,CAAC;QACD,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC;YAAE,IAAA,2CAAsB,EAAC,GAAG,CAAC,aAAa,EAAE,yBAAyB,CAAC,CAAC;QAChG,OAAO,UAAU,CAAC;IACtB,CAAC;CACJ,CAAC;AAEF,SAAS,mBAAmB,CAAC,KAAwB,EAAE,GAAW;IAC9D,IAAI,GAAG,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAC5B,MAAM,QAAQ,GAAG,KAAK,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC;IAChC,OAAO,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;AAC1C,CAAC;AAED,kBAAe,yBAAyB,CAAC","sourcesContent":["import type { EditRule, EditContext, Violation } from '../types';\nimport { Violation as V } from '../types';\nimport { writeTemplateIfMissing } from '../instruct-ai-writer';\n\nconst TRY_PATTERN = /\\btry\\s*\\{/;\n\n// Both webpieces-disable and the existing ESLint directive suppress this rule\nconst DISABLE_PATTERN = /@webpieces\\/no-unmanaged-exceptions|webpieces-disable\\s+(?:[\\w-]+,\\s*)*no-unmanaged-exceptions/;\n\nconst noUnmanagedExceptionsRule: EditRule = {\n    name: 'no-unmanaged-exceptions',\n    description: 'try/catch is generally not allowed. Only allowed in chokepoints (filter, globalErrorHandler) or other rare locations.',\n    scope: 'edit',\n    files: ['**/*.ts', '**/*.tsx'],\n    defaultOptions: {},\n    fixHint: [\n        'Fix Option 1 (preferred): Remove the try/catch — let the exception bubble to the top-level chokepoint (filter, globalErrorHandler) where it is already logged and handled.',\n        'Fix Option 2 (ask the human first): If you genuinely believe this IS a chokepoint, STOP and tell the human:',\n        '  - What exception could be thrown here',\n        '  - What the current top-level chokepoint is (the try/catch at the top of the call stack)',\n        '  - Why throwing to that chokepoint would be wrong in this specific case',\n        '  Then ask: \"Should I add a disable comment or remove the try/catch?\"',\n        '  Only add // webpieces-disable no-unmanaged-exceptions -- <reason> if the human says yes.',\n        'NOTE: If the code is calling an external process (execSync, fs, network), the correct answer is almost always Option 1 — let it throw. Hooks have a top-level runner that reports errors properly.',\n    ],\n\n    check(ctx: EditContext): readonly Violation[] {\n        const violations: V[] = [];\n        for (let i = 0; i < ctx.strippedLines.length; i += 1) {\n            const stripped = ctx.strippedLines[i];\n            if (!TRY_PATTERN.test(stripped)) continue;\n            const lineNum = i + 1;\n            if (ctx.isLineDisabled(lineNum, 'no-unmanaged-exceptions')) continue;\n            if (hasPrecedingDisable(ctx.lines, i)) continue;\n            violations.push(new V(\n                lineNum,\n                ctx.lines[i].trim(),\n                'try/catch is generally not allowed. READ .webpieces/instruct-ai/webpieces.exceptions.md to understand why. Only chokepoints (filter, globalErrorHandler) may catch exceptions.',\n            ));\n        }\n        if (violations.length > 0) writeTemplateIfMissing(ctx.workspaceRoot, 'webpieces.exceptions.md');\n        return violations;\n    },\n};\n\nfunction hasPrecedingDisable(lines: readonly string[], idx: number): boolean {\n    if (idx === 0) return false;\n    const prevLine = lines[idx - 1];\n    return DISABLE_PATTERN.test(prevLine);\n}\n\nexport default noUnmanagedExceptionsRule;\n"]}
+{"version":3,"file":"no-unmanaged-exceptions.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/no-unmanaged-exceptions.ts"],"names":[],"mappings":";;;AAAA,0DAAkF;AAGlF,oCAA0C;AAC1C,4CAA4C;AAC5C,8DAA+D;AAE/D,MAAM,WAAW,GAAG,YAAY,CAAC;AAEjC,8EAA8E;AAC9E,MAAM,eAAe,GAAG,gGAAgG,CAAC;AAEzH,SAAS,mBAAmB,CAAC,KAAwB,EAAE,GAAW;IAC9D,IAAI,GAAG,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAC5B,MAAM,QAAQ,GAAG,KAAK,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC;IAChC,OAAO,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;AAC1C,CAAC;AAED,MAAa,yBAA0B,SAAQ,wBAAyC;IACpF,YAAY,MAAmC,IAAI,KAAK,CAAC,MAAM,EAAE,yBAAyB,CAAC,CAAC,CAAC,CAAC;IAErF,WAAW,GAAG,uHAAuH,CAAC;IAC7H,KAAK,GAAG,CAAC,SAAS,EAAE,UAAU,CAAC,CAAC;IACzC,OAAO,GAAG;QACf,4KAA4K;QAC5K,6GAA6G;QAC7G,yCAAyC;QACzC,2FAA2F;QAC3F,0EAA0E;QAC1E,uEAAuE;QACvE,4FAA4F;QAC5F,oMAAoM;KACvM,CAAC;IAEF,KAAK,CAAC,GAAgB;QAClB,MAAM,UAAU,GAAQ,EAAE,CAAC;QAC3B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;YACnD,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC;gBAAE,SAAS;YAC1C,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;YACtB,IAAI,GAAG,CAAC,cAAc,CAAC,OAAO,EAAE,yBAAU,CAAC,uBAAuB,CAAC;gBAAE,SAAS;YAC9E,IAAI,mBAAmB,CAAC,GAAG,CAAC,KAAK,EAAE,CAAC,CAAC;gBAAE,SAAS;YAChD,UAAU,CAAC,IAAI,CAAC,IAAI,iBAAC,CACjB,OAAO,EACP,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,EACnB,gLAAgL,CACnL,CAAC,CAAC;QACP,CAAC;QACD,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC;YAAE,IAAA,2CAAsB,EAAC,GAAG,CAAC,aAAa,EAAE,yBAAyB,CAAC,CAAC;QAChG,OAAO,UAAU,CAAC;IACtB,CAAC;CACJ;AAjCD,8DAiCC","sourcesContent":["import { NoUnmanagedExceptionsConfig, RULE_NAMES } from '@webpieces/rules-config';\n\nimport type { EditContext, Violation } from '../types';\nimport { Violation as V } from '../types';\nimport { EditRuleBase } from '../rule-base';\nimport { writeTemplateIfMissing } from '../instruct-ai-writer';\n\nconst TRY_PATTERN = /\\btry\\s*\\{/;\n\n// Both webpieces-disable and the existing ESLint directive suppress this rule\nconst DISABLE_PATTERN = /@webpieces\\/no-unmanaged-exceptions|webpieces-disable\\s+(?:[\\w-]+,\\s*)*no-unmanaged-exceptions/;\n\nfunction hasPrecedingDisable(lines: readonly string[], idx: number): boolean {\n    if (idx === 0) return false;\n    const prevLine = lines[idx - 1];\n    return DISABLE_PATTERN.test(prevLine);\n}\n\nexport class NoUnmanagedExceptionsRule extends EditRuleBase<NoUnmanagedExceptionsConfig> {\n    constructor(config: NoUnmanagedExceptionsConfig) { super(config, 'no-unmanaged-exceptions'); }\n\n    readonly description = 'try/catch is generally not allowed. Only allowed in chokepoints (filter, globalErrorHandler) or other rare locations.';\n    override readonly files = ['**/*.ts', '**/*.tsx'];\n    readonly fixHint = [\n        'Fix Option 1 (preferred): Remove the try/catch — let the exception bubble to the top-level chokepoint (filter, globalErrorHandler) where it is already logged and handled.',\n        'Fix Option 2 (ask the human first): If you genuinely believe this IS a chokepoint, STOP and tell the human:',\n        '  - What exception could be thrown here',\n        '  - What the current top-level chokepoint is (the try/catch at the top of the call stack)',\n        '  - Why throwing to that chokepoint would be wrong in this specific case',\n        '  Then ask: \"Should I add a disable comment or remove the try/catch?\"',\n        '  Only add // webpieces-disable no-unmanaged-exceptions -- <reason> if the human says yes.',\n        'NOTE: If the code is calling an external process (execSync, fs, network), the correct answer is almost always Option 1 — let it throw. Hooks have a top-level runner that reports errors properly.',\n    ];\n\n    check(ctx: EditContext): readonly Violation[] {\n        const violations: V[] = [];\n        for (let i = 0; i < ctx.strippedLines.length; i += 1) {\n            const stripped = ctx.strippedLines[i];\n            if (!TRY_PATTERN.test(stripped)) continue;\n            const lineNum = i + 1;\n            if (ctx.isLineDisabled(lineNum, RULE_NAMES.NO_UNMANAGED_EXCEPTIONS)) continue;\n            if (hasPrecedingDisable(ctx.lines, i)) continue;\n            violations.push(new V(\n                lineNum,\n                ctx.lines[i].trim(),\n                'try/catch is generally not allowed. READ .webpieces/instruct-ai/webpieces.exceptions.md to understand why. Only chokepoints (filter, globalErrorHandler) may catch exceptions.',\n            ));\n        }\n        if (violations.length > 0) writeTemplateIfMissing(ctx.workspaceRoot, 'webpieces.exceptions.md');\n        return violations;\n    }\n}\n"]}

package/src/core/rules/pr-creation-guard.d.ts

@@ -1,4 +1,9 @@
-import type { BashRule } from '../types';
-declare const prCreationGuard: BashRule;
-export declare function extractPrBody(command: string, workspaceRoot: string): string | null;
-export default prCreationGuard;
+import { PrCreationGuardConfig } from '@webpieces/rules-config';
+import type { BashContext, Violation } from '../types';
+import { BashRuleBase } from '../rule-base';
+export declare class PrCreationGuardRule extends BashRuleBase<PrCreationGuardConfig> {
+    constructor(config: PrCreationGuardConfig);
+    readonly description = "Block direct PR creation/edit (gh pr / gh api / curl) so PRs go only through pnpm wp-upsert-pr.";
+    readonly fixHint: readonly string[];
+    check(ctx: BashContext): readonly Violation[];
+}

package/src/core/rules/pr-creation-guard.js

@@ -1,84 +1,48 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.extractPrBody = extractPrBody;
-const child_process_1 = require("child_process");
-const fs_1 = require("fs");
-const path_1 = require("path");
+exports.PrCreationGuardRule = void 0;
 const types_1 = require("../types");
+const rule_base_1 = require("../rule-base");
 const FIX_HINT = [
-    'Branch is not up-to-date with origin/main.',
-    'Run the squash-update process to sync with main first:',
-    '  pnpm wp-git-update',
-    'Then retry: gh pr create ...',
-    '',
-    'Do NOT use "git merge origin/main" or "git rebase" — these break the 3-point fork-point system.',
-    'See docs/git-workflow.md for the full squash-merge update process.',
+    'Direct PR creation is blocked. Create or update a PR ONLY via the gated command:',
+    '  pnpm wp-upsert-pr',
+    'It updates the branch from main (3-point merge), runs the real build (nx affected), and',
+    'assembles the PR dashboard — then creates/updates the PR itself. A failing build = no PR.',
+    'There is nothing to paste or attest to; the command does the work.',
 ];
-const prCreationGuard = {
-    name: 'pr-creation-guard',
-    description: 'Block PR creation when the branch has not been updated from origin/main via the squash-merge process.',
-    scope: 'bash',
-    files: [],
-    defaultOptions: { buildCommand: '', requireTextInPr: '' },
-    fixHint: FIX_HINT,
-    check(ctx) {
-        if (!/gh\s+pr\s+create/.test(ctx.command))
-            return [];
-        (0, child_process_1.execSync)('git fetch origin main --quiet', { cwd: ctx.workspaceRoot, encoding: 'utf8' });
-        // spawnSync is used here because exit code 1 means "not an ancestor" (not an error)
-        const result = (0, child_process_1.spawnSync)('git', ['merge-base', '--is-ancestor', 'origin/main', 'HEAD'], { cwd: ctx.workspaceRoot });
-        if (result.status !== 0) {
-            return [new types_1.Violation(1, truncate(ctx.command), [
-                    'Branch is not up-to-date with origin/main.',
-                    'Run the squash-update process first:',
-                    '  pnpm wp-git-update',
-                    'Do NOT use "git merge origin/main" or "git rebase" — these break the 3-point fork-point system.',
-                    'See docs/git-workflow.md for details.',
-                    'Then retry: gh pr create',
-                ].join('\n'))];
-        }
-        const buildCmd = ctx.options['buildCommand'];
-        const requireText = ctx.options['requireTextInPr'];
-        if (buildCmd && requireText) {
-            const body = extractPrBody(ctx.command, ctx.workspaceRoot);
-            if (body !== null && !body.includes(requireText)) {
-                return [new types_1.Violation(1, truncate(ctx.command), [
-                        'PR body is missing the required CI confirmation.',
-                        'Before creating a PR you must run:',
-                        `  ${buildCmd}`,
-                        'After it passes, add this exact phrase to your PR description:',
-                        `  "${requireText}"`,
-                    ].join('\n'))];
-            }
-        }
-        return [];
-    },
-};
-function extractPrBody(command, workspaceRoot) {
-    const fileMatch = /--body-file\s+(\S+)/.exec(command);
-    if (fileMatch) {
-        const resolved = (0, path_1.isAbsolute)(fileMatch[1]) ? fileMatch[1] : (0, path_1.join)(workspaceRoot, fileMatch[1]);
-        if (!(0, fs_1.existsSync)(resolved))
-            return null;
-        return (0, fs_1.readFileSync)(resolved, 'utf8');
+// Detect every way an agent could open/update a PR directly, so the ONLY path left is
+// `pnpm wp-upsert-pr` (whose internal `gh pr create` runs as a child process the hook
+// never sees). Read-only `gh pr list` / `gh api .../pulls` GET are intentionally allowed.
+function isDirectPrCreation(cmd) {
+    if (/\bgh\s+pr\s+(create|edit)\b/.test(cmd))
+        return true;
+    const ghApiPulls = /\bgh\s+api\b[^\n]*\/pulls\b/.test(cmd);
+    if (ghApiPulls && (/--method\s+POST/i.test(cmd) || /-X\s+POST/i.test(cmd) || /\s-f\b/.test(cmd) || /\s-F\b/.test(cmd) || /--field\b/.test(cmd))) {
+        return true;
     }
-    // Greedy + newline-spanning ([\s\S]*) so an inline body that itself contains
-    // quote characters (e.g. a `--body "$(cat <<EOF ... )"` heredoc with prose like
-    // "not installed") is captured in full up to the LAST quote, instead of being
-    // truncated at the first embedded quote. Truncation used to drop the required CI
-    // phrase and produce a false "missing CI confirmation" block. For bodies built by
-    // command substitution from a separate file, prefer --body-file (handled above).
-    const doubleQuoteMatch = /--body\s+"([\s\S]*)"/.exec(command);
-    if (doubleQuoteMatch)
-        return doubleQuoteMatch[1];
-    const singleQuoteMatch = /--body\s+'([\s\S]*)'/.exec(command);
-    if (singleQuoteMatch)
-        return singleQuoteMatch[1];
-    return null;
+    const curlPulls = /\bcurl\b[^\n]*api\.github\.com[^\n]*\/pulls\b/.test(cmd);
+    if (curlPulls && (/-X\s*POST/i.test(cmd) || /--request\s+POST/i.test(cmd) || /(\s-d\b|--data\b)/.test(cmd))) {
+        return true;
+    }
+    return false;
 }
 function truncate(s) {
     const MAX = 120;
     return s.length <= MAX ? s : s.slice(0, MAX) + '…';
 }
-exports.default = prCreationGuard;
+class PrCreationGuardRule extends rule_base_1.BashRuleBase {
+    constructor(config) { super(config, 'pr-creation-guard'); }
+    description = 'Block direct PR creation/edit (gh pr / gh api / curl) so PRs go only through pnpm wp-upsert-pr.';
+    fixHint = FIX_HINT;
+    check(ctx) {
+        if (!isDirectPrCreation(ctx.command))
+            return [];
+        return [new types_1.Violation(1, truncate(ctx.command), [
+                'Direct PR creation/update is blocked.',
+                'Use the gated command instead — it runs the build and builds the dashboard:',
+                '  pnpm wp-upsert-pr',
+            ].join('\n'))];
+    }
+}
+exports.PrCreationGuardRule = PrCreationGuardRule;
 //# sourceMappingURL=pr-creation-guard.js.map

package/src/core/rules/pr-creation-guard.js.map

@@ -1 +1 @@
-{"version":3,"file":"pr-creation-guard.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/pr-creation-guard.ts"],"names":[],"mappings":";;AAwEA,sCAkBC;AA1FD,iDAAoD;AACpD,2BAA8C;AAC9C,+BAAwC;AAExC,oCAA0C;AAE1C,MAAM,QAAQ,GAAsB;IAChC,4CAA4C;IAC5C,wDAAwD;IACxD,sBAAsB;IACtB,8BAA8B;IAC9B,EAAE;IACF,iGAAiG;IACjG,oEAAoE;CACvE,CAAC;AAEF,MAAM,eAAe,GAAa;IAC9B,IAAI,EAAE,mBAAmB;IACzB,WAAW,EAAE,uGAAuG;IACpH,KAAK,EAAE,MAAM;IACb,KAAK,EAAE,EAAE;IACT,cAAc,EAAE,EAAE,YAAY,EAAE,EAAE,EAAE,eAAe,EAAE,EAAE,EAAE;IACzD,OAAO,EAAE,QAAQ;IAEjB,KAAK,CAAC,GAAgB;QAClB,IAAI,CAAC,kBAAkB,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC;YAAE,OAAO,EAAE,CAAC;QAErD,IAAA,wBAAQ,EAAC,+BAA+B,EAAE,EAAE,GAAG,EAAE,GAAG,CAAC,aAAa,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QAExF,oFAAoF;QACpF,MAAM,MAAM,GAAG,IAAA,yBAAS,EACpB,KAAK,EAAE,CAAC,YAAY,EAAE,eAAe,EAAE,aAAa,EAAE,MAAM,CAAC,EAC7D,EAAE,GAAG,EAAE,GAAG,CAAC,aAAa,EAAE,CAC7B,CAAC;QAEF,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACtB,OAAO,CAAC,IAAI,iBAAC,CACT,CAAC,EACD,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,EACrB;oBACI,4CAA4C;oBAC5C,sCAAsC;oBACtC,sBAAsB;oBACtB,iGAAiG;oBACjG,uCAAuC;oBACvC,0BAA0B;iBAC7B,CAAC,IAAI,CAAC,IAAI,CAAC,CACf,CAAC,CAAC;QACP,CAAC;QAED,MAAM,QAAQ,GAAG,GAAG,CAAC,OAAO,CAAC,cAAc,CAAW,CAAC;QACvD,MAAM,WAAW,GAAG,GAAG,CAAC,OAAO,CAAC,iBAAiB,CAAW,CAAC;QAC7D,IAAI,QAAQ,IAAI,WAAW,EAAE,CAAC;YAC1B,MAAM,IAAI,GAAG,aAAa,CAAC,GAAG,CAAC,OAAO,EAAE,GAAG,CAAC,aAAa,CAAC,CAAC;YAC3D,IAAI,IAAI,KAAK,IAAI,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,CAAC;gBAC/C,OAAO,CAAC,IAAI,iBAAC,CACT,CAAC,EACD,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,EACrB;wBACI,kDAAkD;wBAClD,oCAAoC;wBACpC,KAAK,QAAQ,EAAE;wBACf,gEAAgE;wBAChE,MAAM,WAAW,GAAG;qBACvB,CAAC,IAAI,CAAC,IAAI,CAAC,CACf,CAAC,CAAC;YACP,CAAC;QACL,CAAC;QACD,OAAO,EAAE,CAAC;IACd,CAAC;CACJ,CAAC;AAEF,SAAgB,aAAa,CAAC,OAAe,EAAE,aAAqB;IAChE,MAAM,SAAS,GAAG,qBAAqB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACtD,IAAI,SAAS,EAAE,CAAC;QACZ,MAAM,QAAQ,GAAG,IAAA,iBAAU,EAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAA,WAAI,EAAC,aAAa,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;QAC7F,IAAI,CAAC,IAAA,eAAU,EAAC,QAAQ,CAAC;YAAE,OAAO,IAAI,CAAC;QACvC,OAAO,IAAA,iBAAY,EAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;IAC1C,CAAC;IACD,6EAA6E;IAC7E,gFAAgF;IAChF,8EAA8E;IAC9E,iFAAiF;IACjF,kFAAkF;IAClF,iFAAiF;IACjF,MAAM,gBAAgB,GAAG,sBAAsB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAC9D,IAAI,gBAAgB;QAAE,OAAO,gBAAgB,CAAC,CAAC,CAAC,CAAC;IACjD,MAAM,gBAAgB,GAAG,sBAAsB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAC9D,IAAI,gBAAgB;QAAE,OAAO,gBAAgB,CAAC,CAAC,CAAC,CAAC;IACjD,OAAO,IAAI,CAAC;AAChB,CAAC;AAED,SAAS,QAAQ,CAAC,CAAS;IACvB,MAAM,GAAG,GAAG,GAAG,CAAC;IAChB,OAAO,CAAC,CAAC,MAAM,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,GAAG,GAAG,CAAC;AACvD,CAAC;AAED,kBAAe,eAAe,CAAC","sourcesContent":["import { execSync, spawnSync } from 'child_process';\nimport { readFileSync, existsSync } from 'fs';\nimport { isAbsolute, join } from 'path';\nimport type { BashRule, BashContext, Violation } from '../types';\nimport { Violation as V } from '../types';\n\nconst FIX_HINT: readonly string[] = [\n    'Branch is not up-to-date with origin/main.',\n    'Run the squash-update process to sync with main first:',\n    '  pnpm wp-git-update',\n    'Then retry: gh pr create ...',\n    '',\n    'Do NOT use \"git merge origin/main\" or \"git rebase\" — these break the 3-point fork-point system.',\n    'See docs/git-workflow.md for the full squash-merge update process.',\n];\n\nconst prCreationGuard: BashRule = {\n    name: 'pr-creation-guard',\n    description: 'Block PR creation when the branch has not been updated from origin/main via the squash-merge process.',\n    scope: 'bash',\n    files: [],\n    defaultOptions: { buildCommand: '', requireTextInPr: '' },\n    fixHint: FIX_HINT,\n\n    check(ctx: BashContext): readonly Violation[] {\n        if (!/gh\\s+pr\\s+create/.test(ctx.command)) return [];\n\n        execSync('git fetch origin main --quiet', { cwd: ctx.workspaceRoot, encoding: 'utf8' });\n\n        // spawnSync is used here because exit code 1 means \"not an ancestor\" (not an error)\n        const result = spawnSync(\n            'git', ['merge-base', '--is-ancestor', 'origin/main', 'HEAD'],\n            { cwd: ctx.workspaceRoot },\n        );\n\n        if (result.status !== 0) {\n            return [new V(\n                1,\n                truncate(ctx.command),\n                [\n                    'Branch is not up-to-date with origin/main.',\n                    'Run the squash-update process first:',\n                    '  pnpm wp-git-update',\n                    'Do NOT use \"git merge origin/main\" or \"git rebase\" — these break the 3-point fork-point system.',\n                    'See docs/git-workflow.md for details.',\n                    'Then retry: gh pr create',\n                ].join('\\n'),\n            )];\n        }\n\n        const buildCmd = ctx.options['buildCommand'] as string;\n        const requireText = ctx.options['requireTextInPr'] as string;\n        if (buildCmd && requireText) {\n            const body = extractPrBody(ctx.command, ctx.workspaceRoot);\n            if (body !== null && !body.includes(requireText)) {\n                return [new V(\n                    1,\n                    truncate(ctx.command),\n                    [\n                        'PR body is missing the required CI confirmation.',\n                        'Before creating a PR you must run:',\n                        `  ${buildCmd}`,\n                        'After it passes, add this exact phrase to your PR description:',\n                        `  \"${requireText}\"`,\n                    ].join('\\n'),\n                )];\n            }\n        }\n        return [];\n    },\n};\n\nexport function extractPrBody(command: string, workspaceRoot: string): string | null {\n    const fileMatch = /--body-file\\s+(\\S+)/.exec(command);\n    if (fileMatch) {\n        const resolved = isAbsolute(fileMatch[1]) ? fileMatch[1] : join(workspaceRoot, fileMatch[1]);\n        if (!existsSync(resolved)) return null;\n        return readFileSync(resolved, 'utf8');\n    }\n    // Greedy + newline-spanning ([\\s\\S]*) so an inline body that itself contains\n    // quote characters (e.g. a `--body \"$(cat <<EOF ... )\"` heredoc with prose like\n    // \"not installed\") is captured in full up to the LAST quote, instead of being\n    // truncated at the first embedded quote. Truncation used to drop the required CI\n    // phrase and produce a false \"missing CI confirmation\" block. For bodies built by\n    // command substitution from a separate file, prefer --body-file (handled above).\n    const doubleQuoteMatch = /--body\\s+\"([\\s\\S]*)\"/.exec(command);\n    if (doubleQuoteMatch) return doubleQuoteMatch[1];\n    const singleQuoteMatch = /--body\\s+'([\\s\\S]*)'/.exec(command);\n    if (singleQuoteMatch) return singleQuoteMatch[1];\n    return null;\n}\n\nfunction truncate(s: string): string {\n    const MAX = 120;\n    return s.length <= MAX ? s : s.slice(0, MAX) + '…';\n}\n\nexport default prCreationGuard;\n"]}
+{"version":3,"file":"pr-creation-guard.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/pr-creation-guard.ts"],"names":[],"mappings":";;;AAGA,oCAA0C;AAC1C,4CAA4C;AAE5C,MAAM,QAAQ,GAAsB;IAChC,kFAAkF;IAClF,qBAAqB;IACrB,yFAAyF;IACzF,2FAA2F;IAC3F,oEAAoE;CACvE,CAAC;AAEF,sFAAsF;AACtF,sFAAsF;AACtF,0FAA0F;AAC1F,SAAS,kBAAkB,CAAC,GAAW;IACnC,IAAI,6BAA6B,CAAC,IAAI,CAAC,GAAG,CAAC;QAAE,OAAO,IAAI,CAAC;IAEzD,MAAM,UAAU,GAAG,6BAA6B,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAC3D,IAAI,UAAU,IAAI,CAAC,kBAAkB,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,YAAY,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,WAAW,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC;QAC9I,OAAO,IAAI,CAAC;IAChB,CAAC;IAED,MAAM,SAAS,GAAG,+CAA+C,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAC5E,IAAI,SAAS,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,mBAAmB,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,mBAAmB,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC;QAC1G,OAAO,IAAI,CAAC;IAChB,CAAC;IACD,OAAO,KAAK,CAAC;AACjB,CAAC;AAED,SAAS,QAAQ,CAAC,CAAS;IACvB,MAAM,GAAG,GAAG,GAAG,CAAC;IAChB,OAAO,CAAC,CAAC,MAAM,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,GAAG,GAAG,CAAC;AACvD,CAAC;AAED,MAAa,mBAAoB,SAAQ,wBAAmC;IACxE,YAAY,MAA6B,IAAI,KAAK,CAAC,MAAM,EAAE,mBAAmB,CAAC,CAAC,CAAC,CAAC;IAEzE,WAAW,GAAG,iGAAiG,CAAC;IAChH,OAAO,GAAG,QAAQ,CAAC;IAE5B,KAAK,CAAC,GAAgB;QAClB,IAAI,CAAC,kBAAkB,CAAC,GAAG,CAAC,OAAO,CAAC;YAAE,OAAO,EAAE,CAAC;QAChD,OAAO,CAAC,IAAI,iBAAC,CACT,CAAC,EACD,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,EACrB;gBACI,uCAAuC;gBACvC,6EAA6E;gBAC7E,qBAAqB;aACxB,CAAC,IAAI,CAAC,IAAI,CAAC,CACf,CAAC,CAAC;IACP,CAAC;CACJ;AAlBD,kDAkBC","sourcesContent":["import { PrCreationGuardConfig } from '@webpieces/rules-config';\n\nimport type { BashContext, Violation } from '../types';\nimport { Violation as V } from '../types';\nimport { BashRuleBase } from '../rule-base';\n\nconst FIX_HINT: readonly string[] = [\n    'Direct PR creation is blocked. Create or update a PR ONLY via the gated command:',\n    '  pnpm wp-upsert-pr',\n    'It updates the branch from main (3-point merge), runs the real build (nx affected), and',\n    'assembles the PR dashboard — then creates/updates the PR itself. A failing build = no PR.',\n    'There is nothing to paste or attest to; the command does the work.',\n];\n\n// Detect every way an agent could open/update a PR directly, so the ONLY path left is\n// `pnpm wp-upsert-pr` (whose internal `gh pr create` runs as a child process the hook\n// never sees). Read-only `gh pr list` / `gh api .../pulls` GET are intentionally allowed.\nfunction isDirectPrCreation(cmd: string): boolean {\n    if (/\\bgh\\s+pr\\s+(create|edit)\\b/.test(cmd)) return true;\n\n    const ghApiPulls = /\\bgh\\s+api\\b[^\\n]*\\/pulls\\b/.test(cmd);\n    if (ghApiPulls && (/--method\\s+POST/i.test(cmd) || /-X\\s+POST/i.test(cmd) || /\\s-f\\b/.test(cmd) || /\\s-F\\b/.test(cmd) || /--field\\b/.test(cmd))) {\n        return true;\n    }\n\n    const curlPulls = /\\bcurl\\b[^\\n]*api\\.github\\.com[^\\n]*\\/pulls\\b/.test(cmd);\n    if (curlPulls && (/-X\\s*POST/i.test(cmd) || /--request\\s+POST/i.test(cmd) || /(\\s-d\\b|--data\\b)/.test(cmd))) {\n        return true;\n    }\n    return false;\n}\n\nfunction truncate(s: string): string {\n    const MAX = 120;\n    return s.length <= MAX ? s : s.slice(0, MAX) + '…';\n}\n\nexport class PrCreationGuardRule extends BashRuleBase<PrCreationGuardConfig> {\n    constructor(config: PrCreationGuardConfig) { super(config, 'pr-creation-guard'); }\n\n    readonly description = 'Block direct PR creation/edit (gh pr / gh api / curl) so PRs go only through pnpm wp-upsert-pr.';\n    readonly fixHint = FIX_HINT;\n\n    check(ctx: BashContext): readonly Violation[] {\n        if (!isDirectPrCreation(ctx.command)) return [];\n        return [new V(\n            1,\n            truncate(ctx.command),\n            [\n                'Direct PR creation/update is blocked.',\n                'Use the gated command instead — it runs the build and builds the dashboard:',\n                '  pnpm wp-upsert-pr',\n            ].join('\\n'),\n        )];\n    }\n}\n"]}

package/src/core/rules/pr-merge-cleanup.d.ts

@@ -1,3 +1,9 @@
-import type { BashRule } from '../types';
-declare const prMergeCleanup: BashRule;
-export default prMergeCleanup;
+import { PrMergeCleanupConfig } from '@webpieces/rules-config';
+import type { BashContext, Violation } from '../types';
+import { BashRuleBase } from '../rule-base';
+export declare class PrMergeCleanupRule extends BashRuleBase<PrMergeCleanupConfig> {
+    constructor(config: PrMergeCleanupConfig);
+    readonly description = "After merging a PR, require switching to main, pulling, and deleting the local branch.";
+    readonly fixHint: string[];
+    check(ctx: BashContext): readonly Violation[];
+}

package/src/core/rules/pr-merge-cleanup.js

@@ -1,18 +1,21 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.PrMergeCleanupRule = void 0;
 const child_process_1 = require("child_process");
 const types_1 = require("../types");
-const prMergeCleanup = {
-    name: 'pr-merge-cleanup',
-    description: 'After merging a PR, require switching to main, pulling, and deleting the local branch.',
-    scope: 'bash',
-    files: [],
-    defaultOptions: {},
-    fixHint: [
+const rule_base_1 = require("../rule-base");
+function truncate(s) {
+    const MAX = 120;
+    return s.length <= MAX ? s : s.slice(0, MAX) + '…';
+}
+class PrMergeCleanupRule extends rule_base_1.BashRuleBase {
+    constructor(config) { super(config, 'pr-merge-cleanup'); }
+    description = 'After merging a PR, require switching to main, pulling, and deleting the local branch.';
+    fixHint = [
         'After merging a PR you must clean up the local branch.',
         'Run this combined command instead:',
         '  gh pr merge --squash && git checkout main && git pull && git branch -d <current-branch>',
-    ],
+    ];
     check(ctx) {
         if (!/gh\s+pr\s+merge/.test(ctx.command))
             return [];
@@ -29,11 +32,7 @@ const prMergeCleanup = {
                 'Run this combined command instead:',
                 `  gh pr merge --squash && git checkout main && git pull && git branch -d ${currentBranch}`,
             ].join('\n'))];
-    },
-};
-function truncate(s) {
-    const MAX = 120;
-    return s.length <= MAX ? s : s.slice(0, MAX) + '…';
+    }
 }
-exports.default = prMergeCleanup;
+exports.PrMergeCleanupRule = PrMergeCleanupRule;
 //# sourceMappingURL=pr-merge-cleanup.js.map

package/src/core/rules/pr-merge-cleanup.js.map

@@ -1 +1 @@
-{"version":3,"file":"pr-merge-cleanup.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/pr-merge-cleanup.ts"],"names":[],"mappings":";;AAAA,iDAAyC;AAEzC,oCAA0C;AAE1C,MAAM,cAAc,GAAa;IAC7B,IAAI,EAAE,kBAAkB;IACxB,WAAW,EAAE,wFAAwF;IACrG,KAAK,EAAE,MAAM;IACb,KAAK,EAAE,EAAE;IACT,cAAc,EAAE,EAAE;IAClB,OAAO,EAAE;QACL,wDAAwD;QACxD,oCAAoC;QACpC,2FAA2F;KAC9F;IAED,KAAK,CAAC,GAAgB;QAClB,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC;YAAE,OAAO,EAAE,CAAC;QAEpD,MAAM,WAAW,GAAG,gCAAgC,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QACvE,MAAM,SAAS,GAAG,sBAAsB,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAE3D,IAAI,WAAW,IAAI,SAAS;YAAE,OAAO,EAAE,CAAC;QAExC,MAAM,aAAa,GAAG,IAAA,wBAAQ,EAAC,iCAAiC,EAAE;YAC9D,GAAG,EAAE,GAAG,CAAC,aAAa;YACtB,QAAQ,EAAE,MAAM;SACnB,CAAC,CAAC,IAAI,EAAE,CAAC;QAEV,OAAO,CAAC,IAAI,iBAAC,CACT,CAAC,EACD,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,EACrB;gBACI,2EAA2E;gBAC3E,oCAAoC;gBACpC,4EAA4E,aAAa,EAAE;aAC9F,CAAC,IAAI,CAAC,IAAI,CAAC,CACf,CAAC,CAAC;IACP,CAAC;CACJ,CAAC;AAEF,SAAS,QAAQ,CAAC,CAAS;IACvB,MAAM,GAAG,GAAG,GAAG,CAAC;IAChB,OAAO,CAAC,CAAC,MAAM,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,GAAG,GAAG,CAAC;AACvD,CAAC;AAED,kBAAe,cAAc,CAAC","sourcesContent":["import { execSync } from 'child_process';\nimport type { BashRule, BashContext, Violation } from '../types';\nimport { Violation as V } from '../types';\n\nconst prMergeCleanup: BashRule = {\n    name: 'pr-merge-cleanup',\n    description: 'After merging a PR, require switching to main, pulling, and deleting the local branch.',\n    scope: 'bash',\n    files: [],\n    defaultOptions: {},\n    fixHint: [\n        'After merging a PR you must clean up the local branch.',\n        'Run this combined command instead:',\n        '  gh pr merge --squash && git checkout main && git pull && git branch -d <current-branch>',\n    ],\n\n    check(ctx: BashContext): readonly Violation[] {\n        if (!/gh\\s+pr\\s+merge/.test(ctx.command)) return [];\n\n        const hasCheckout = /git\\s+(checkout|switch)\\s+main/.test(ctx.command);\n        const hasDelete = /git\\s+branch\\s+-[dD]/.test(ctx.command);\n\n        if (hasCheckout && hasDelete) return [];\n\n        const currentBranch = execSync('git rev-parse --abbrev-ref HEAD', {\n            cwd: ctx.workspaceRoot,\n            encoding: 'utf8',\n        }).trim();\n\n        return [new V(\n            1,\n            truncate(ctx.command),\n            [\n                '[pr-merge-cleanup] After merging a PR you must clean up the local branch.',\n                'Run this combined command instead:',\n                `  gh pr merge --squash && git checkout main && git pull && git branch -d ${currentBranch}`,\n            ].join('\\n'),\n        )];\n    },\n};\n\nfunction truncate(s: string): string {\n    const MAX = 120;\n    return s.length <= MAX ? s : s.slice(0, MAX) + '…';\n}\n\nexport default prMergeCleanup;\n"]}
+{"version":3,"file":"pr-merge-cleanup.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/pr-merge-cleanup.ts"],"names":[],"mappings":";;;AAAA,iDAAyC;AAKzC,oCAA0C;AAC1C,4CAA4C;AAE5C,SAAS,QAAQ,CAAC,CAAS;IACvB,MAAM,GAAG,GAAG,GAAG,CAAC;IAChB,OAAO,CAAC,CAAC,MAAM,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,GAAG,GAAG,CAAC;AACvD,CAAC;AAED,MAAa,kBAAmB,SAAQ,wBAAkC;IACtE,YAAY,MAA4B,IAAI,KAAK,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC,CAAC,CAAC;IAEvE,WAAW,GAAG,wFAAwF,CAAC;IACvG,OAAO,GAAG;QACf,wDAAwD;QACxD,oCAAoC;QACpC,2FAA2F;KAC9F,CAAC;IAEF,KAAK,CAAC,GAAgB;QAClB,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC;YAAE,OAAO,EAAE,CAAC;QAEpD,MAAM,WAAW,GAAG,gCAAgC,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QACvE,MAAM,SAAS,GAAG,sBAAsB,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAE3D,IAAI,WAAW,IAAI,SAAS;YAAE,OAAO,EAAE,CAAC;QAExC,MAAM,aAAa,GAAG,IAAA,wBAAQ,EAAC,iCAAiC,EAAE;YAC9D,GAAG,EAAE,GAAG,CAAC,aAAa;YACtB,QAAQ,EAAE,MAAM;SACnB,CAAC,CAAC,IAAI,EAAE,CAAC;QAEV,OAAO,CAAC,IAAI,iBAAC,CACT,CAAC,EACD,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,EACrB;gBACI,2EAA2E;gBAC3E,oCAAoC;gBACpC,4EAA4E,aAAa,EAAE;aAC9F,CAAC,IAAI,CAAC,IAAI,CAAC,CACf,CAAC,CAAC;IACP,CAAC;CACJ;AAjCD,gDAiCC","sourcesContent":["import { execSync } from 'child_process';\n\nimport { PrMergeCleanupConfig } from '@webpieces/rules-config';\n\nimport type { BashContext, Violation } from '../types';\nimport { Violation as V } from '../types';\nimport { BashRuleBase } from '../rule-base';\n\nfunction truncate(s: string): string {\n    const MAX = 120;\n    return s.length <= MAX ? s : s.slice(0, MAX) + '…';\n}\n\nexport class PrMergeCleanupRule extends BashRuleBase<PrMergeCleanupConfig> {\n    constructor(config: PrMergeCleanupConfig) { super(config, 'pr-merge-cleanup'); }\n\n    readonly description = 'After merging a PR, require switching to main, pulling, and deleting the local branch.';\n    readonly fixHint = [\n        'After merging a PR you must clean up the local branch.',\n        'Run this combined command instead:',\n        '  gh pr merge --squash && git checkout main && git pull && git branch -d <current-branch>',\n    ];\n\n    check(ctx: BashContext): readonly Violation[] {\n        if (!/gh\\s+pr\\s+merge/.test(ctx.command)) return [];\n\n        const hasCheckout = /git\\s+(checkout|switch)\\s+main/.test(ctx.command);\n        const hasDelete = /git\\s+branch\\s+-[dD]/.test(ctx.command);\n\n        if (hasCheckout && hasDelete) return [];\n\n        const currentBranch = execSync('git rev-parse --abbrev-ref HEAD', {\n            cwd: ctx.workspaceRoot,\n            encoding: 'utf8',\n        }).trim();\n\n        return [new V(\n            1,\n            truncate(ctx.command),\n            [\n                '[pr-merge-cleanup] After merging a PR you must clean up the local branch.',\n                'Run this combined command instead:',\n                `  gh pr merge --squash && git checkout main && git pull && git branch -d ${currentBranch}`,\n            ].join('\\n'),\n        )];\n    }\n}\n"]}

package/src/core/rules/require-return-type.d.ts

@@ -1,3 +1,10 @@
-import type { EditRule } from '../types';
-declare const requireReturnTypeRule: EditRule;
-export default requireReturnTypeRule;
+import { RequireReturnTypeConfig } from '@webpieces/rules-config';
+import type { EditContext, Violation } from '../types';
+import { EditRuleBase } from '../rule-base';
+export declare class RequireReturnTypeRule extends EditRuleBase<RequireReturnTypeConfig> {
+    constructor(config: RequireReturnTypeConfig);
+    readonly description = "Every function and method must declare its return type.";
+    readonly files: string[];
+    readonly fixHint: string[];
+    check(ctx: EditContext): readonly Violation[];
+}

package/src/core/rules/require-return-type.js

@@ -1,6 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.RequireReturnTypeRule = void 0;
+const rules_config_1 = require("@webpieces/rules-config");
 const types_1 = require("../types");
+const rule_base_1 = require("../rule-base");
 // Matches function/method signatures that don't have `: ReturnType` before the `{` body opener.
 // Pattern: function name(<params>) { — missing `: Type` between `)` and `{`
 const FUNC_DECL_MISSING = /\bfunction\s+\w+\s*(?:<[^>]*>)?\s*\([^)]*\)\s*\{/;
@@ -12,16 +15,26 @@ const ARROW_MISSING = /\bconst\s+\w+\s*=\s*(?:async\s+)?(?:<[^>]*>)?\s*\([^)]*\)
 const HAS_RETURN_TYPE = /\)\s*:\s*\S/;
 // Skip constructors, getters, setters, and control flow keywords
 const SKIP_PATTERN = /\b(?:constructor|get\s+\w+|set\s+\w+|if|else|while|for|switch|catch|return)\s*\(/;
-const requireReturnTypeRule = {
-    name: 'require-return-type',
-    description: 'Every function and method must declare its return type.',
-    scope: 'edit',
-    files: ['**/*.ts', '**/*.tsx'],
-    defaultOptions: {},
-    fixHint: [
+function isMissingReturnType(line) {
+    if (SKIP_PATTERN.test(line))
+        return false;
+    const isFuncLike = FUNC_DECL_MISSING.test(line) ||
+        METHOD_MISSING.test(line) ||
+        ARROW_MISSING.test(line);
+    if (!isFuncLike)
+        return false;
+    if (HAS_RETURN_TYPE.test(line))
+        return false;
+    return true;
+}
+class RequireReturnTypeRule extends rule_base_1.EditRuleBase {
+    constructor(config) { super(config, 'require-return-type'); }
+    description = 'Every function and method must declare its return type.';
+    files = ['**/*.ts', '**/*.tsx'];
+    fixHint = [
         'Add return type: function foo(x: T): ReturnType { ... }',
         '// webpieces-disable require-return-type -- <reason>',
-    ],
+    ];
     check(ctx) {
         const violations = [];
         for (let i = 0; i < ctx.strippedLines.length; i += 1) {
@@ -29,24 +42,12 @@ const requireReturnTypeRule = {
             if (!isMissingReturnType(stripped))
                 continue;
             const lineNum = i + 1;
-            if (ctx.isLineDisabled(lineNum, 'require-return-type'))
+            if (ctx.isLineDisabled(lineNum, rules_config_1.RULE_NAMES.REQUIRE_RETURN_TYPE))
                 continue;
             violations.push(new types_1.Violation(lineNum, ctx.lines[i].trim(), 'Missing return type annotation.'));
         }
         return violations;
-    },
-};
-function isMissingReturnType(line) {
-    if (SKIP_PATTERN.test(line))
-        return false;
-    const isFuncLike = FUNC_DECL_MISSING.test(line) ||
-        METHOD_MISSING.test(line) ||
-        ARROW_MISSING.test(line);
-    if (!isFuncLike)
-        return false;
-    if (HAS_RETURN_TYPE.test(line))
-        return false;
-    return true;
+    }
 }
-exports.default = requireReturnTypeRule;
+exports.RequireReturnTypeRule = RequireReturnTypeRule;
 //# sourceMappingURL=require-return-type.js.map

package/src/core/rules/require-return-type.js.map

@@ -1 +1 @@
-{"version":3,"file":"require-return-type.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/require-return-type.ts"],"names":[],"mappings":";;AACA,oCAA0C;AAE1C,gGAAgG;AAChG,4EAA4E;AAC5E,MAAM,iBAAiB,GAAG,kDAAkD,CAAC;AAE7E,8EAA8E;AAC9E,MAAM,cAAc,GAAG,yDAAyD,CAAC;AAEjF,qFAAqF;AACrF,MAAM,aAAa,GAAG,gEAAgE,CAAC;AAEvF,qEAAqE;AACrE,MAAM,eAAe,GAAG,aAAa,CAAC;AAEtC,iEAAiE;AACjE,MAAM,YAAY,GAAG,kFAAkF,CAAC;AAExG,MAAM,qBAAqB,GAAa;IACpC,IAAI,EAAE,qBAAqB;IAC3B,WAAW,EAAE,yDAAyD;IACtE,KAAK,EAAE,MAAM;IACb,KAAK,EAAE,CAAC,SAAS,EAAE,UAAU,CAAC;IAC9B,cAAc,EAAE,EAAE;IAClB,OAAO,EAAE;QACL,yDAAyD;QACzD,sDAAsD;KACzD;IAED,KAAK,CAAC,GAAgB;QAClB,MAAM,UAAU,GAAQ,EAAE,CAAC;QAC3B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;YACnD,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtC,IAAI,CAAC,mBAAmB,CAAC,QAAQ,CAAC;gBAAE,SAAS;YAC7C,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;YACtB,IAAI,GAAG,CAAC,cAAc,CAAC,OAAO,EAAE,qBAAqB,CAAC;gBAAE,SAAS;YACjE,UAAU,CAAC,IAAI,CAAC,IAAI,iBAAC,CACjB,OAAO,EACP,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,EACnB,iCAAiC,CACpC,CAAC,CAAC;QACP,CAAC;QACD,OAAO,UAAU,CAAC;IACtB,CAAC;CACJ,CAAC;AAEF,SAAS,mBAAmB,CAAC,IAAY;IACrC,IAAI,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IAC1C,MAAM,UAAU,GACZ,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC;QAC5B,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC;QACzB,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC7B,IAAI,CAAC,UAAU;QAAE,OAAO,KAAK,CAAC;IAC9B,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IAC7C,OAAO,IAAI,CAAC;AAChB,CAAC;AAED,kBAAe,qBAAqB,CAAC","sourcesContent":["import type { EditRule, EditContext, Violation } from '../types';\nimport { Violation as V } from '../types';\n\n// Matches function/method signatures that don't have `: ReturnType` before the `{` body opener.\n// Pattern: function name(<params>) { — missing `: Type` between `)` and `{`\nconst FUNC_DECL_MISSING = /\\bfunction\\s+\\w+\\s*(?:<[^>]*>)?\\s*\\([^)]*\\)\\s*\\{/;\n\n// Matches class method signatures: indented, optional async, name(<params>) {\nconst METHOD_MISSING = /^\\s{2,}(?:async\\s+)?\\w+\\s*(?:<[^>]*>)?\\s*\\([^)]*\\)\\s*\\{/;\n\n// Arrow function: const name = (async)? (<params>) => — missing `: Type` before `=>`\nconst ARROW_MISSING = /\\bconst\\s+\\w+\\s*=\\s*(?:async\\s+)?(?:<[^>]*>)?\\s*\\([^)]*\\)\\s*=>/;\n\n// Lines that have ): ReturnType before { or => — these are COMPLIANT\nconst HAS_RETURN_TYPE = /\\)\\s*:\\s*\\S/;\n\n// Skip constructors, getters, setters, and control flow keywords\nconst SKIP_PATTERN = /\\b(?:constructor|get\\s+\\w+|set\\s+\\w+|if|else|while|for|switch|catch|return)\\s*\\(/;\n\nconst requireReturnTypeRule: EditRule = {\n    name: 'require-return-type',\n    description: 'Every function and method must declare its return type.',\n    scope: 'edit',\n    files: ['**/*.ts', '**/*.tsx'],\n    defaultOptions: {},\n    fixHint: [\n        'Add return type: function foo(x: T): ReturnType { ... }',\n        '// webpieces-disable require-return-type -- <reason>',\n    ],\n\n    check(ctx: EditContext): readonly Violation[] {\n        const violations: V[] = [];\n        for (let i = 0; i < ctx.strippedLines.length; i += 1) {\n            const stripped = ctx.strippedLines[i];\n            if (!isMissingReturnType(stripped)) continue;\n            const lineNum = i + 1;\n            if (ctx.isLineDisabled(lineNum, 'require-return-type')) continue;\n            violations.push(new V(\n                lineNum,\n                ctx.lines[i].trim(),\n                'Missing return type annotation.',\n            ));\n        }\n        return violations;\n    },\n};\n\nfunction isMissingReturnType(line: string): boolean {\n    if (SKIP_PATTERN.test(line)) return false;\n    const isFuncLike =\n        FUNC_DECL_MISSING.test(line) ||\n        METHOD_MISSING.test(line) ||\n        ARROW_MISSING.test(line);\n    if (!isFuncLike) return false;\n    if (HAS_RETURN_TYPE.test(line)) return false;\n    return true;\n}\n\nexport default requireReturnTypeRule;\n"]}
+{"version":3,"file":"require-return-type.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/ai-hook-rules/src/core/rules/require-return-type.ts"],"names":[],"mappings":";;;AAAA,0DAA8E;AAG9E,oCAA0C;AAC1C,4CAA4C;AAE5C,gGAAgG;AAChG,4EAA4E;AAC5E,MAAM,iBAAiB,GAAG,kDAAkD,CAAC;AAE7E,8EAA8E;AAC9E,MAAM,cAAc,GAAG,yDAAyD,CAAC;AAEjF,qFAAqF;AACrF,MAAM,aAAa,GAAG,gEAAgE,CAAC;AAEvF,qEAAqE;AACrE,MAAM,eAAe,GAAG,aAAa,CAAC;AAEtC,iEAAiE;AACjE,MAAM,YAAY,GAAG,kFAAkF,CAAC;AAExG,SAAS,mBAAmB,CAAC,IAAY;IACrC,IAAI,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IAC1C,MAAM,UAAU,GACZ,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC;QAC5B,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC;QACzB,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC7B,IAAI,CAAC,UAAU;QAAE,OAAO,KAAK,CAAC;IAC9B,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IAC7C,OAAO,IAAI,CAAC;AAChB,CAAC;AAED,MAAa,qBAAsB,SAAQ,wBAAqC;IAC5E,YAAY,MAA+B,IAAI,KAAK,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC,CAAC,CAAC;IAE7E,WAAW,GAAG,yDAAyD,CAAC;IAC/D,KAAK,GAAG,CAAC,SAAS,EAAE,UAAU,CAAC,CAAC;IACzC,OAAO,GAAG;QACf,yDAAyD;QACzD,sDAAsD;KACzD,CAAC;IAEF,KAAK,CAAC,GAAgB;QAClB,MAAM,UAAU,GAAQ,EAAE,CAAC;QAC3B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;YACnD,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtC,IAAI,CAAC,mBAAmB,CAAC,QAAQ,CAAC;gBAAE,SAAS;YAC7C,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;YACtB,IAAI,GAAG,CAAC,cAAc,CAAC,OAAO,EAAE,yBAAU,CAAC,mBAAmB,CAAC;gBAAE,SAAS;YAC1E,UAAU,CAAC,IAAI,CAAC,IAAI,iBAAC,CACjB,OAAO,EACP,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,EACnB,iCAAiC,CACpC,CAAC,CAAC;QACP,CAAC;QACD,OAAO,UAAU,CAAC;IACtB,CAAC;CACJ;AAzBD,sDAyBC","sourcesContent":["import { RequireReturnTypeConfig, RULE_NAMES } from '@webpieces/rules-config';\n\nimport type { EditContext, Violation } from '../types';\nimport { Violation as V } from '../types';\nimport { EditRuleBase } from '../rule-base';\n\n// Matches function/method signatures that don't have `: ReturnType` before the `{` body opener.\n// Pattern: function name(<params>) { — missing `: Type` between `)` and `{`\nconst FUNC_DECL_MISSING = /\\bfunction\\s+\\w+\\s*(?:<[^>]*>)?\\s*\\([^)]*\\)\\s*\\{/;\n\n// Matches class method signatures: indented, optional async, name(<params>) {\nconst METHOD_MISSING = /^\\s{2,}(?:async\\s+)?\\w+\\s*(?:<[^>]*>)?\\s*\\([^)]*\\)\\s*\\{/;\n\n// Arrow function: const name = (async)? (<params>) => — missing `: Type` before `=>`\nconst ARROW_MISSING = /\\bconst\\s+\\w+\\s*=\\s*(?:async\\s+)?(?:<[^>]*>)?\\s*\\([^)]*\\)\\s*=>/;\n\n// Lines that have ): ReturnType before { or => — these are COMPLIANT\nconst HAS_RETURN_TYPE = /\\)\\s*:\\s*\\S/;\n\n// Skip constructors, getters, setters, and control flow keywords\nconst SKIP_PATTERN = /\\b(?:constructor|get\\s+\\w+|set\\s+\\w+|if|else|while|for|switch|catch|return)\\s*\\(/;\n\nfunction isMissingReturnType(line: string): boolean {\n    if (SKIP_PATTERN.test(line)) return false;\n    const isFuncLike =\n        FUNC_DECL_MISSING.test(line) ||\n        METHOD_MISSING.test(line) ||\n        ARROW_MISSING.test(line);\n    if (!isFuncLike) return false;\n    if (HAS_RETURN_TYPE.test(line)) return false;\n    return true;\n}\n\nexport class RequireReturnTypeRule extends EditRuleBase<RequireReturnTypeConfig> {\n    constructor(config: RequireReturnTypeConfig) { super(config, 'require-return-type'); }\n\n    readonly description = 'Every function and method must declare its return type.';\n    override readonly files = ['**/*.ts', '**/*.tsx'];\n    readonly fixHint = [\n        'Add return type: function foo(x: T): ReturnType { ... }',\n        '// webpieces-disable require-return-type -- <reason>',\n    ];\n\n    check(ctx: EditContext): readonly Violation[] {\n        const violations: V[] = [];\n        for (let i = 0; i < ctx.strippedLines.length; i += 1) {\n            const stripped = ctx.strippedLines[i];\n            if (!isMissingReturnType(stripped)) continue;\n            const lineNum = i + 1;\n            if (ctx.isLineDisabled(lineNum, RULE_NAMES.REQUIRE_RETURN_TYPE)) continue;\n            violations.push(new V(\n                lineNum,\n                ctx.lines[i].trim(),\n                'Missing return type annotation.',\n            ));\n        }\n        return violations;\n    }\n}\n"]}

package/src/core/rules/throw-cause-required.d.ts

@@ -1,3 +1,10 @@
-import type { EditRule } from '../types';
-declare const throwCauseRequiredRule: EditRule;
-export default throwCauseRequiredRule;
+import { ThrowCauseRequiredConfig } from '@webpieces/rules-config';
+import type { EditContext, Violation } from '../types';
+import { EditRuleBase } from '../rule-base';
+export declare class ThrowCauseRequiredRule extends EditRuleBase<ThrowCauseRequiredConfig> {
+    constructor(config: ThrowCauseRequiredConfig);
+    readonly description = "When rethrowing with added context, chain the original exception: throw new Error(\"msg\", { cause: error })";
+    readonly files: string[];
+    readonly fixHint: string[];
+    check(ctx: EditContext): readonly Violation[];
+}