@webos-tools/cli 3.0.5 → 3.1.0

package/CHANGELOG.md

@@ -1,3 +1,27 @@
+## 3.1.0 (July 12, 2024)
+### ares-generate
+* Fixed a bug that can not generate without tample option
+
+### ares-setup-device
+* Enhance usability of --add option.
+* Enhance emulator remove usability
+* Change default device information of TV profile (user: prisoner, port:9922)
+* Change devie name validation logic that accept all of charactors except "$" & "%"
+
+### common
+* Upgrade node modules: shelljs(v0.8.5), async(v3.2.5), ssh2(v1.15.0), tar(v6.2.0).
+
+
+## 3.0.6 (April 04, 2024)
+### ares-log
+* Fixed a bug that invalid json format
+
+
+## 3.0.5 (April 01, 2024)
+### Common
+* Fixed a bug that can not install on window by CMD or Powershell
+
+
 ## 3.0.4 (March 30, 2024)
 ### Common
 * Fixed a bug that always requires sudo permission when exec ares commands

package/bin/ares-generate.js

@@ -170,6 +170,10 @@ function generate() {
     const gen = getGenerator();
     const templates = gen.getTmpl();
 
+    if(!options.tmplName){
+        options.tmplName = Object.keys(templates).find(t => templates[t].default === true);
+    }
+
     if (options.tmplName === "true") {
         return finish(errHndl.getErrMsg("EMPTY_VALUE", "TEMPLATE"));
     }

package/bin/ares-novacom.js

@@ -118,12 +118,9 @@ function getkey(next) {
                 }
                 process.stdin.resume();
                 process.stdin.setEncoding('utf8');
-                process.stdout.write('input passphrase [default: webos]:');
+                process.stdout.write('input passphrase:');
                 process.stdin.on('data', function(text) {
-                    let passphrase = text.toString().trim();
-                    if (passphrase === '') {
-                        passphrase = 'webos';
-                    }
+                    const passphrase = text.toString().trim();
                     log.info('registered passphrase is ', passphrase);
                     next(null, keyFileName, passphrase);
                 });

package/bin/ares-setup-device.js

@@ -186,9 +186,10 @@ function _queryAddRemove(ssdpDevices, next) {
                     if (ssdpDevice) {
                         if (ssdpDevice.op === 'modify') return inqChoices;
                         else return ['add'];
-                    } else {
-                        return totChoices;
-                    }
+                    } 
+                    if (deviceNames.length > 1) return totChoices;
+                    // deveice list has emulator only > unsupported remove option
+                    return inqChoices.concat(dfChoices);
                 },
                 filter: function(val) {
                     return val.toLowerCase();
@@ -221,12 +222,20 @@ function _queryAddRemove(ssdpDevices, next) {
                     return true;
                 }
             }, {
+                type: "list",
+                name: "device_name",
+                message: "Select a device",
+                choices: deviceNames.filter(dv => dv !== "emulator"),
+                when: function(answers) {
+                    return (["remove"].indexOf(answers.op) !== -1 && !ssdpDevice);
+                }
+            },{
                 type: "list",
                 name: "device_name",
                 message: "Select a device",
                 choices: deviceNames,
                 when: function(answers) {
-                    return (["modify", "remove", "set default"].indexOf(answers.op) !== -1 && !ssdpDevice);
+                    return (["modify", "set default"].indexOf(answers.op) !== -1 && !ssdpDevice);
                 }
             }];
             inquirer.prompt(questions)
@@ -250,14 +259,15 @@ function _queryAddRemove(ssdpDevices, next) {
 function _queryDeviceInfo(selDevice, next) {
     let mode = selDevice.mode;
     const deviceName = selDevice.name,
-        resolver = this.resolver || (this.resolver = new novacom.Resolver());
-
+        resolver = this.resolver || (this.resolver = new novacom.Resolver()),
+        defaultDeviceInfo = appdata.getConfig(true).defaultDeviceInfo;
+    
     questions = [{
         type: "input",
         name: "ip",
         message: "Enter Device IP address:",
         default: function() {
-            return selDevice.host || "127.0.0.1";
+            return selDevice.host || defaultDeviceInfo.ipAddress;
         },
         validate: function(answers) {
             if (!setupDevice.isValidIpv4(answers)) {
@@ -273,7 +283,7 @@ function _queryDeviceInfo(selDevice, next) {
         name: "port",
         message: "Enter Device Port:",
         default: function() {
-            return selDevice.port || "22";
+            return selDevice.port || defaultDeviceInfo.port;
         },
         validate: function(answers) {
             if (!setupDevice.isValidPort(answers)) {
@@ -289,7 +299,7 @@ function _queryDeviceInfo(selDevice, next) {
         name: "user",
         message: "Enter ssh user:",
         default: function() {
-            return selDevice.username || "root";
+            return selDevice.username || defaultDeviceInfo.user;
         },
         when: function() {
             return _needInq(mode)(inqChoices);
@@ -299,7 +309,7 @@ function _queryDeviceInfo(selDevice, next) {
         name: "description",
         message: "Enter description:",
         default: function() {
-            return selDevice.description || "new device";
+            return selDevice.description || defaultDeviceInfo.description;
         },
         when: function() {
             return _needInq(mode)(inqChoices);
@@ -316,8 +326,8 @@ function _queryDeviceInfo(selDevice, next) {
             }
             return idx;
         },
-        when: function() {
-            return _needInq(mode)(inqChoices);
+        when: function(answers) {
+            return _needInq(mode)(inqChoices) && answers.user === 'root';
         }
     }, {
         type: "password",
@@ -336,18 +346,8 @@ function _queryDeviceInfo(selDevice, next) {
         when: function(answers) {
             return _needInq(mode)(inqChoices) && (answers.auth_type === "ssh key");
         }
-    }, {
-        type: "input",
-        name: "ssh_passphrase",
-        message: "Enter key's passphrase:",
-        default: function() {
-            return selDevice.passphrase || undefined;
-        },
-        when: function(answers) {
-            return _needInq(mode)(inqChoices) && (answers.auth_type === "ssh key");
-
-        }
-    }, {
+    },
+    {
         type: "confirm",
         name: "default",
         message: "Set default ?",
@@ -381,16 +381,18 @@ function _queryDeviceInfo(selDevice, next) {
           default: answers.default
         };
 
-        if (mode === 'add' || mode === 'modify') {
+       
+        if (answers.
+            user !== 'prisoner' && ["add", "modify"].includes(mode)) {
             if (answers.auth_type && answers.auth_type === "password") {
                 inDevice.password = answers.password;
                 inDevice.privateKey = "@DELETE@";
                 inDevice.passphrase = "@DELETE@";
                 inDevice.privateKeyName = "@DELETE@";
-            } else if (answers.auth_type && answers.auth_type === "ssh key") {
+            } else if ((answers.auth_type && answers.auth_type === "ssh key") || answers.user === "developer") {
                 inDevice.password = "@DELETE@";
                 inDevice.privateKey = {
-                    "openSsh": answers.ssh_key
+                    "openSsh": answers.ssh_key || "webos_emul"
                 };
                 inDevice.passphrase = answers.ssh_passphrase || "@DELETE@";
                 inDevice.privateKeyName = "@DELETE@";
@@ -411,12 +413,18 @@ function _queryDeviceInfo(selDevice, next) {
         async.series([
             resolver.load.bind(resolver),
             resolver.modifyDeviceFile.bind(resolver, mode, inDevice),
-            setupDevice.showDeviceList.bind(this, finish)
+            setupDevice.showDeviceList.bind(this),
         ], function(err, results) {
             if (err) {
-                return next(err);
+                return next(err,);
+            }
+            if(results[2] && results[2].msg){
+                console.log(results[2].msg);
+            }
+            if(inDevice.username === 'prisoner' && mode === 'add'){
+                setupDevice.displayGetKeyGuide(inDevice.name);
             }
-            next(null, results[1]);
+            finish();
         });
     });
 }

package/bin/ares.js

@@ -119,7 +119,7 @@ function display (next) {
         for (const arg in argv) {
             if (Object.hasOwnProperty.call(commandsList, 'ares-'+ arg) && fs.existsSync(path.join(__dirname, 'ares-'+ arg + '.js'))) {
                 if (commandsList['ares-'+ arg].profile && !commandsList['ares-'+ arg].profile.includes(profile)) {
-                    next(errHndl.getErrMsg("NOT_SUPPORT_COMMOND", profile));
+                   return next(errHndl.getErrMsg("NOT_SUPPORT_COMMOND", profile));
                 } else {
                     help.display('ares-'+arg, appdata.getConfig(true).profile);
                     found = true;
@@ -127,9 +127,9 @@ function display (next) {
             }
 
             if (!found) {
-                next(errHndl.getErrMsg("INVALID_COMMAND"));
+                return next(errHndl.getErrMsg("INVALID_COMMAND"));
             } else {
-                next();
+                return next();
             }
         }
     } catch (err) {

package/files/conf/config.json

@@ -11,6 +11,15 @@
             "native": "executable"
         }
     },
+    "defaultDeviceInfo": {
+        "ipAddress": "127.0.0.1",
+        "port": "9922",
+        "user": "prisoner",
+        "description": "new device description",
+        "files": "stream",
+        "default": false,
+        "type": "starfish"
+    },
     "logFilePath": "/media/developer/log/devlog",
     "install": {
         "tempDirForIpk": "/media/developer/temp",

package/files/conf-base/profile/config-ose.json

@@ -10,6 +10,14 @@
             "native": "executable"
         }
     },
+    "defaultDeviceInfo":{
+        "ipAddress": "127.0.0.1",
+        "port": "22",
+        "user": "root",
+        "description": "new device description",
+        "files": "stream",
+        "default": false
+    },
     "logFilePath": "/media/developer/log/devlog",
     "install": {
         "tempDirForIpk": "/media/developer/temp",

package/files/conf-base/profile/config-tv.json

@@ -11,6 +11,15 @@
             "native": "executable"
         }
     },
+    "defaultDeviceInfo": {
+        "ipAddress": "127.0.0.1",
+        "port": "9922",
+        "user": "prisoner",
+        "description": "new device description",
+        "files": "stream",
+        "default": false,
+        "type": "starfish"
+    },
     "logFilePath": "/media/developer/log/devlog",
     "install": {
         "tempDirForIpk": "/media/developer/temp",

package/files/help/ares-setup-device.help

@@ -13,7 +13,8 @@
     },
     "description" : [
         {
-          "default": [
+          "default":[],
+          "ose": [
             "This command manages the information of the devices.",
             "",
               "** Attributes of DEVICE_INFO **",
@@ -23,7 +24,24 @@
               "  username    [string]   user name to connect ('developer')",
               "  privatekey  [string]   ssh private key file name",
               "                         ssh private key should exist under $HOME/.ssh/",
-              "  passphrase  [string]   passphrase used for generating ssh keys",
+              "  password    [string]   password for ssh connection",
+              "  default     [boolean]  set default device with 'add' option",
+            "",
+            "This command can set a default device.",
+            "If you don't specify a target device, the default device is used as the target device.",
+            "",
+            "LEVEL is priority of logs. (e.g., silly, verbose, info, warn, error)"
+          ],
+          "tv": [
+            "This command manages the information of the devices.",
+            "",
+              "** Attributes of DEVICE_INFO **",
+              "  description [string]   description of target device",
+              "  host        [string]   ip address",
+              "  port        [string]   port number",
+              "  username    [string]   user name to connect ('prisoner')",
+              "  privatekey  [string]   ssh private key file name",
+              "                         ssh private key should exist under $HOME/.ssh/",
               "  password    [string]   password for ssh connection",
               "  default     [boolean]  set default device with 'add' option",
             "",
@@ -36,7 +54,8 @@
     ],
     "examples" : [
       {
-        "default" : [
+        "default":[],
+        "ose" : [
             "",
             "# Add a DEVICE and set the username, host, port",
             "ares-setup-device -a DEVICE -i \"{'username':'root', 'host':'127.0.0.1','port':'22'}\"",
@@ -57,6 +76,28 @@
             "# Change the ssh password of the DEVICE as an empty value",
             "ares-setup-device -m DEVICE -i \"password=\"",
             ""
+          ],
+          "tv" : [
+            "",
+            "# Add a DEVICE and set the username, host, port",
+            "ares-setup-device -a DEVICE -i \"{'username':'prisoner', 'host':'127.0.0.1','port':'9922'}\"",
+            " Or",
+            "ares-setup-device -a DEVICE -i \"username=prisoner\" -i \"host=127.0.0.1\" -i \"port=9922\"",
+            "",
+            "# Modify the information of the DEVICE",
+            "ares-setup-device -m DEVICE -i \"{'username':'prisoner','host':'192.168.0.123'}\"",
+            " Or",
+            "ares-setup-device -m DEVICE -i \"username=prisoner\" -i \"host=192.168.0.123\"",
+            "",
+            "# Remove the DEVICE",
+            "ares-setup-device -r DEVICE",
+            "",
+            "# Set default the DEVICE",
+            "ares-setup-device -f DEVICE",
+            "",
+            "# Change the ssh password of the DEVICE as an empty value",
+            "ares-setup-device -m DEVICE -i \"password=\"",
+            ""
           ]
       }
     ],

package/files/templates/ose-sdk-templates/bootplate-web/index.html

@@ -41,7 +41,7 @@ window.onload = function() {
      *  In this case, the service name is used as default name "com.domain.app.service" is.
      *  If you change this service name, you need to change the service name of the following API.
      *
-     *  If you change the name to helloParmas as you want, the contents will be reflected on the screen.
+     *  If you change the name to helloParams as you want, the contents will be reflected on the screen.
      */
     var helloApi = 'luna://com.domain.app.service/hello';
     var helloParams = '{"name":"webOS"}';

package/lib/base/error-handler.js

@@ -80,7 +80,7 @@ const log = require('npmlog'),
             "INVALID_TEMPLATE": "Invalid template name",
             "INVALID_FILE": "Invalid file",
             "INVALID_VALUE": "Invalid value",
-            "INVALID_DEVICENAME": "Invalid device name. The device name should consist of letters, numbers, and special characters ('-','_','#') and should start with letters or '_'",
+            "INVALID_DEVICENAME": "Invalid device name. The device name should not start with '%' or '$'",
             "INVALID_OBJECT": "Object format error",
             "INVALID_MODE": "Please specify an option, either '--add' or '--modify'",
             "INVALID_REMOVE_MODE": "Please set remove option",
@@ -107,7 +107,7 @@ const log = require('npmlog'),
             "NOT_EXIST_SSHKEY_PASSWD": "Private key file or password does not exist",
             "NOT_EXIST_DISPLAY": "No existing displayId from getSessionList",
             "NOT_EXIST_SIMULATOR": "No existing simulator excutable file which name starting with",
-            "NOT_SUPPORT_COMMOND_DEPRECATED": "This command is deprecated. Please use \"ares-device\" instead of \"ares-device-info\"",
+            "NOT_SUPPORT_COMMOND_DEPRECATED": "This command is deprecated. Please use \"ares-device -i\" instead of \"ares-device-info\"",
             "NOT_SUPPORT_COMMOND": "This command is not supported by current profile\nIf you want to use this command, please change profile using \"ares-config\" command\nCurrent profile:",
             "NOT_SUPPORT_OPTION": "This option is not supported by current profile\nIf you want to use this command, please change profile using \"ares-config\" command\nCurrent profile:",
             "NOT_SUPPORT_SESSION": "This device does not support multiple sessions",

package/lib/base/novacom.js

@@ -593,7 +593,7 @@ const async = require('async'),
 
             if (!this.ssh) {
                 this.forwardedPorts = [];
-                this.ssh = new Ssh2();
+                this.ssh = new Ssh2.Client();
                 this.ssh.on('connect', function() {
                     log.info("novacom#Session()#begin()", "ssh session event: connected");
                 });
@@ -907,7 +907,7 @@ const async = require('async'),
                 log.silly("novacom#Session()#run()", "stdout: function");
                 write.stdout = stdout;
             } else {
-                setImmediate(next, errHndl.getErrMsg("INVALID_VALUE", "stdout", util.inspect(stdout)));
+                return setImmediate(next, errHndl.getErrMsg("INVALID_VALUE", "stdout", util.inspect(stdout)));
             }
 
             if (!stderr) {
@@ -921,7 +921,7 @@ const async = require('async'),
                 log.silly("novacom#Session()#run()", "stderr: function");
                 write.stderr = stderr;
             } else {
-                setImmediate(next, errHndl.getErrMsg("INVALID_VALUE", "stderr", util.inspect(stderr)));
+                return setImmediate(next, errHndl.getErrMsg("INVALID_VALUE", "stderr", util.inspect(stderr)));
             }
 
             // execute command
@@ -964,7 +964,7 @@ const async = require('async'),
                 chStream.on('close', function() {
                     log.silly("novacom#Session()#run()", "event close (cmd:" + cmd + ")");
                     if (err === undefined) {
-                        setImmediate(next);
+                       setImmediate(next);
                     }
                 });
 

package/lib/base/setup-device.js

@@ -19,18 +19,8 @@ const async = require('async'),
 
     const appdata = new Appdata(),
         devicetools = {},
-        defaultDeviceInfo = {
-            profile: appdata.getConfig(true).profile,
-            host: "127.0.0.1",
-            port: 22,
-            username: "root",
-            description: "new device description",
-            files: "stream",
-            default: false
-        };
-        if(defaultDeviceInfo.profile !== "ose"){
-            defaultDeviceInfo.type = "starfish";
-        }
+        defaultDeviceInfo = appdata.getConfig(true).defaultDeviceInfo;
+        defaultDeviceInfo.profile = appdata.getConfig(true).profile;
 
     if (typeof module !== 'undefined' && module.exports) {
         module.exports = devicetools;
@@ -38,11 +28,11 @@ const async = require('async'),
         module.exports.isValidIpv4 = isValidIpv4;
         module.exports.isValidPort =isValidPort;
         module.exports.replaceDefaultDeviceInfo = replaceDefaultDeviceInfo;
+        module.exports.displayGetKeyGuide = displayGetKeyGuide;
     }
 
     function isValidDeviceName(name) {
-        const re = new RegExp("^[_a-zA-Z][a-zA-Z0-9#_-]*");
-        return (name === String(name.match(re)));
+        return ['$', '%'].indexOf(name[0]) === -1;
     }
 
     function isValidIpv4(host) {
@@ -210,11 +200,17 @@ const async = require('async'),
             async.series([
                 resolver.load.bind(resolver),
                 resolver.modifyDeviceFile.bind(resolver, mode, inDevice),
-                this.showDeviceList.bind(this, next)
-            ], function(err) {
+                this.showDeviceList.bind(this),
+            ], function(err, results) {
                 if (err) {
                     return next(err);
                 }
+                if(results[2] && results[2].msg){
+                    console.log(results[2].msg);
+                }
+                if(inDevice.username === 'prisoner' && mode === 'add'){
+                    displayGetKeyGuide(inDevice.name);
+                }
                 next();
             });
         } catch (err) {
@@ -317,12 +313,23 @@ const async = require('async'),
         if (inDevice) {
             inDevice.profile = inDevice.profile || defaultDeviceInfo.profile;
             inDevice.type = inDevice.type || defaultDeviceInfo.type;
-            inDevice.host = inDevice.host || defaultDeviceInfo.host;
+            inDevice.host = inDevice.host || defaultDeviceInfo.ipAddress;
             inDevice.port = inDevice.port || defaultDeviceInfo.port;
-            inDevice.username = inDevice.username || defaultDeviceInfo.username;
+            inDevice.username = inDevice.username || defaultDeviceInfo.user;
             inDevice.files = inDevice.files || defaultDeviceInfo.files;
             inDevice.description = inDevice.description || defaultDeviceInfo.description;
             inDevice.default = inDevice.default || defaultDeviceInfo.default;
         }
     }
+
+    function displayGetKeyGuide(deviceName) {
+        const guideSteps = "** To connect to TV you need to do following steps:"
+                              + "\n 1. Turning on Developer Mode following this guide: https://webostv.developer.lge.com/develop/getting-started/developer-mode-app"
+                              + "\n 2. Launch the Developer Mode app and click the Key Server button in the Developer Mode app"
+                              + "\n 3. Get the ssh key file from your webOS TV with the following command on your PC"
+                              + "\n    > ares-novacom --device " + deviceName + " --getkey"
+                              + "\n    > Enter the passphrase displayed on the Developer Mode app";
+                    
+        console.log(guideSteps);
+    }
 }());

package/lib/inspect.js

@@ -425,7 +425,7 @@ let platformNodeVersion = "0";
                                 break;
                             }
                         }
-                        next();
+                        next(null, listFiles);
                     });
                 }
 
@@ -460,8 +460,8 @@ let platformNodeVersion = "0";
                     }
 
                     async.whilst(
-                        function() {
-                            return listFiles.length > 0;
+                        function(callBack) {
+                            callBack(null, listFiles && listFiles.length > 0);
                         },
                         _getDisplayUrl.bind(this),
                         function(err) {

package/lib/log.js

@@ -64,8 +64,8 @@ const util = require('util'),
 
             function _onData(data) {
                 log.info("log#show()#_onData()");
-                const str = (Buffer.isBuffer(data)) ? data.toString() : data;
-                console.log(str.trim()); // Do not remove
+                const strLogs = (Buffer.isBuffer(data)) ? data.toString() : data;
+                process.stdout.write(strLogs);
 
                 if (options.argv.save) {
                     fs.writeFileSync(savedFilePath, data, {encoding: 'utf8', flag:'a'});
@@ -569,13 +569,13 @@ const util = require('util'),
                 return next(errHndl.getErrMsg(err));
             }
             fs.closeSync(fd);
+            next();
         });
         // Defense code
         if (fs.existsSync(savedFilePath)) {
             fs.unlinkSync(savedFilePath);
         }
         log.verbose("log#createLogFile()", savedFilePath + " is exist: " + fs.existsSync(savedFilePath));
-        next();
     }
 
     if (typeof module !== 'undefined' && module.exports) {

package/lib/package.js

@@ -25,9 +25,8 @@ const ar = require('ar-async'),
     temp = require('temp'),
     uglify = require('terser'),
     util = require('util'),
-    zlib = require('zlib'),
-    tarFilterPack = require('./tar-filter-pack'),
-    errHndl = require('./base/error-handler');
+    errHndl = require('./base/error-handler'),
+    tar = require('tar');
 
 (function() {
     log.heading = 'packager';
@@ -1426,31 +1425,50 @@ const ar = require('ar-async'),
         const pkgServiceNames = this.pkgServiceNames;
         // @see https://github.com/isaacs/node-tar/issues/7
         // it is a workaround for packaged ipk on windows can set +x into directory
-        const fixupDirs = function(entry) {
+        const fixupDirs = function (filePath, entry) {
+            const fileOrFolderName = filePath.split("/").pop();
+            // opkg does not support Posix Tar fully
+            if (fileOrFolderName.length !== Buffer.byteLength(fileOrFolderName)) {
+                const errMsg = "Please use the file name in english letters. \n\t\t (" + filePath + ")",
+                    em = new (require('events').EventEmitter)();
+                em.emit('error', new Error(errMsg));
+            }
             // Make sure readable directories have execute permission
-            if (entry.props.type === "Directory") {
+            if (entry.isDirectory()) {
                 let maskingBits = 201; // 0311
                 // special case for service directory should have writable permission.
-                if (pkgServiceNames.indexOf(entry.props.basename) !== -1) {
+                if (pkgServiceNames.indexOf(fileOrFolderName) !== -1) {
                     maskingBits = 219; // 0333
                 }
-                entry.props.mode |= (entry.props.mode >>> 2) & maskingBits;
-            } else if (entry.props.type === "File") {
+                entry.mode |= (entry.mode >>> 2) & maskingBits;
+            } else if (entry.isFile()) {
                 // Add other user's readable permission to all files
-                entry.props.mode |= 4; // 04
+                entry.mode |= 4; // 04
+            }
+            if (entry.uid > 0o7777777) {
+                entry.uid = 0;
+            }
+
+            if (entry.gid > 0o7777777) {
+                entry.gid = 0;
             }
+            
             return true;
         };
 
-        // TODO: when this PR (https://github.com/npm/node-tar/pull/73) is merged, need to update node-tar
-        fstream
-            .Reader({path: srcDir, type: 'Directory', filter: fixupDirs })
-            .pipe(tarFilterPack({ noProprietary: true, fromBase: true, permission: this.packageProperties }))
-            // .pipe(tarFilterPack({ noProprietary: true, pathFilter: filter, permission: this.packageProperties }))
-            .pipe(zlib.createGzip())
-            .pipe(fs.createWriteStream(dstDir))
-            .on("close", next)
-            .on('error', next);
+        fs.readdir(srcDir, function (err, fileList) {
+            if (err) setImmediate(next, err);
+            else {
+                tar.c({
+                    file: dstDir,
+                    gzip: true,
+                    cwd: srcDir,
+                    filter: fixupDirs
+                }, fileList)
+                    .then(() => setImmediate(next))
+                    .catch(error => setImmediate(next, error));
+            }
+        });
     }
 
     function setIpkFileName(next) {
@@ -1601,7 +1619,7 @@ const ar = require('ar-async'),
             this.rscCount++;
             log.verbose("FOUND resourceinfo.json, rscCount " + this.rscCount);
             if (this.appCount > 0 || this.svcDir && this.svcDir.length > 0) {
-                callback(errHndl.getErrMsg("NOT_PACKAGE_WITH_RESOURCE"));
+               return callback(errHndl.getErrMsg("NOT_PACKAGE_WITH_RESOURCE"));
             }
             this.resources = this.resources || [];
             const rsc = {};
@@ -2078,7 +2096,7 @@ const ar = require('ar-async'),
             fs.writeFileSync(ivFilePath, encryptedIV, 'binary');
 
         } catch (err) {
-            setImmediate(next, errHndl.getErrMsg(err));
+            return setImmediate(next, errHndl.getErrMsg(err));
         }
         setImmediate(next);
     }