@webority/biome-config 0.89.0 → 0.90.0

package/README.md

@@ -50,12 +50,13 @@ fails every file in the repo at once, drowning any real violation (one repo's le
 - **`a11y` group: `warn`**, so an accessibility finding fails only under
   `biome check --error-on-warnings` (the standard `check` script). A product never raises or
   lowers it in its own `biome.json`; a lint script without that flag lets the findings through.
-- **`noArrayIndexKey: warn`** — kept on (catches real dynamic-list bugs); genuine
+- **`noArrayIndexKey` and `noDuplicateProperties`: `error`** — kept on (catches real dynamic-list bugs); genuine
   static-list exceptions get a documented per-line `biome-ignore`.
 - **`noConsole`** off for `scripts/**` + `logger.js`; CSS/SCSS not linted; the icon
   module's mixed export allowed.
 - **`StyleSheet.absoluteFillObject`** is an error, through the `no-absolute-fill-object` plugin
   (below).
+- **Five React Native plugins** (`mobile-grit-*`, below) are errors: `Alert.alert`, the Touchable family, an index from `keyExtractor`, `allowFontScaling={false}`, and a default import from `@react-native-firebase`.
 
 ## Plugins (GritQL)
 
@@ -64,6 +65,11 @@ The config ships lint plugins in `plugins/` and turns them on for every product
 | Plugin | Fails on | Why |
 |---|---|---|
 | `no-absolute-fill-object` | `StyleSheet.absoluteFillObject` | React Native 0.86 removed it. It is `undefined`, and spreading it silently leaves the view in the layout flow. Use `StyleSheet.absoluteFill` (spread it or use it directly). |
+| `mobile-grit-alert-alert` | `Alert.alert` | A confirm or alert is the mobile-ui `Dialog`, and a short message is a `toast`. |
+| `mobile-grit-touchable` | `TouchableOpacity`, `TouchableHighlight`, `TouchableWithoutFeedback` | Retired. Use a mobile-ui component, or `Pressable` with `accessibilityRole` and a label. |
+| `mobile-grit-index-key` | an inline `keyExtractor={(item, index) => ...}` whose body uses `index` | A key from the index breaks row state on a reorder or an insert. Return the record's stable id. |
+| `mobile-grit-font-scaling-off` | `allowFontScaling={false}` | Turns off text scaling for people who need larger text. Cap a dense row with `maxFontSizeMultiplier`. |
+| `mobile-grit-firebase-default-import` | `import x from "@react-native-firebase/..."` | `@react-native-firebase` 26 has no default export: the import is `undefined` and calling it crashes at launch. Import the modular functions by name. |
 
 A plugin finding is an error, so `biome check` and `biome lint` fail on it.
 

package/biome.jsonc

@@ -29,7 +29,19 @@
     // the product's biome.json must sit beside the node_modules that holds @webority/biome-config.
     // A plugin that cannot be read fails every lint run, so a wrong layout is never silent.
     // no-absolute-fill-object: StyleSheet.absoluteFillObject is gone in React Native 0.86 (undefined).
-    "plugins": ["./node_modules/@webority/biome-config/plugins/no-absolute-fill-object.grit"],
+    // mobile-grit-alert-alert: Alert.alert in app code; the mobile-ui Dialog or toast replaces it.
+    // mobile-grit-touchable: the retired Touchable family; mobile-ui components or Pressable replace it.
+    // mobile-grit-index-key: an inline keyExtractor that returns its index argument.
+    // mobile-grit-font-scaling-off: allowFontScaling={false}; maxFontSizeMultiplier caps a dense row instead.
+    // mobile-grit-firebase-default-import: a default import from @react-native-firebase, which is undefined.
+    "plugins": [
+        "./node_modules/@webority/biome-config/plugins/no-absolute-fill-object.grit",
+        "./node_modules/@webority/biome-config/plugins/mobile-grit-alert-alert.grit",
+        "./node_modules/@webority/biome-config/plugins/mobile-grit-touchable.grit",
+        "./node_modules/@webority/biome-config/plugins/mobile-grit-index-key.grit",
+        "./node_modules/@webority/biome-config/plugins/mobile-grit-font-scaling-off.grit",
+        "./node_modules/@webority/biome-config/plugins/mobile-grit-firebase-default-import.grit"
+    ],
     "linter": {
         "enabled": true,
         "rules": {
@@ -77,11 +89,11 @@
             "suspicious": {
                 // Valuable on dynamic lists (reorder/reconciliation bugs). Genuine
                 // static-list exceptions get a documented per-line biome-ignore.
-                "noArrayIndexKey": "warn",
+                "noArrayIndexKey": "error",
                 "useIterableCallbackReturn": "off",
                 "noGlobalIsNan": "off",
                 "noAssignInExpressions": "off",
-                "noDuplicateProperties": "warn",
+                "noDuplicateProperties": "error",
                 // Apps log through the web-core Logger, and a library through its one diagnostics
                 // module (devWarn and devError). Any other console call fails lint.
                 "noConsole": "error"

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@webority/biome-config",
-  "version": "0.89.0",
-  "description": "Shared Biome lint + format policy for Webority frontend products. Extend it from a product biome.json so every repo inherits one fleet-decided ruleset, bumped by version — no per-repo drift.",
+  "version": "0.90.0",
+  "description": "Shared Biome lint + format policy for Webority frontend products. Extend it from a product biome.json so every repo inherits one shared ruleset, bumped by version — no per-repo drift.",
   "license": "SEE LICENSE IN LICENSE",
   "publishConfig": {
     "access": "public",

package/plugins/mobile-grit-alert-alert.grit

@@ -0,0 +1,6 @@
+language js
+
+// react-native.md: a confirm or alert is the mobile-ui Dialog, and a short message is a toast.
+`Alert.alert` as $use where {
+    register_diagnostic(span=$use, message="Alert.alert is not used in app code. Use the mobile-ui Dialog for a confirm or alert, or toast for a short message.", severity="error")
+}

package/plugins/mobile-grit-firebase-default-import.grit

@@ -0,0 +1,8 @@
+language js
+
+// react-native-toolchain.md: @react-native-firebase 26 has no default export, so a default import is undefined.
+`import $name from $source` as $import where {
+    $name <: r"[A-Za-z_$][A-Za-z0-9_$]*",
+    $source <: r"[\"']@react-native-firebase/[^\"']+[\"']",
+    register_diagnostic(span=$import, message="@react-native-firebase has no default export, so this import is undefined and calling it crashes at launch. Import the modular functions by name, such as getCrashlytics.", severity="error")
+}

package/plugins/mobile-grit-font-scaling-off.grit

@@ -0,0 +1,6 @@
+language js
+
+// react-native.md: never turn off font scaling; maxFontSizeMultiplier caps a dense row.
+`allowFontScaling={false}` as $attr where {
+    register_diagnostic(span=$attr, message="allowFontScaling={false} turns off text scaling for people who need larger text. Cap a dense row with maxFontSizeMultiplier instead.", severity="error")
+}

package/plugins/mobile-grit-index-key.grit

@@ -0,0 +1,8 @@
+language js
+
+// react-native.md: keyExtractor returns the record's stable id, never the index.
+`keyExtractor={$extractor}` where {
+    $extractor <: `($item, $index) => $body`,
+    $body <: contains $index,
+    register_diagnostic(span=$extractor, message="keyExtractor returns the index. Return the record's stable id, so a reorder or an insert keeps each row's state.", severity="error")
+}

package/plugins/mobile-grit-touchable.grit

@@ -0,0 +1,10 @@
+language js
+
+// react-native.md: the Touchable family is retired for mobile-ui components and Pressable.
+or {
+    `TouchableOpacity`,
+    `TouchableHighlight`,
+    `TouchableWithoutFeedback`
+} as $use where {
+    register_diagnostic(span=$use, message="TouchableOpacity, TouchableHighlight and TouchableWithoutFeedback are retired. Use a mobile-ui component, or Pressable with accessibilityRole and a label.", severity="error")
+}