@webitel/api-services 26.8.62 → 26.8.64

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@webitel/api-services",
-	"version": "26.8.62",
+	"version": "26.8.64",
 	"private": false,
 	"repository": {
 		"type": "git",

package/src/utils/formatDate.ts

@@ -11,7 +11,8 @@ import type { FormatDateMode } from '../enums/FormatDateMode/FormatDateMode';
  */
 const TIMEZONE_STORAGE_KEY = 'user-timezone-setting';
 
-function getUserTimeZone(): string {
+/** The operator's chosen time zone, falling back to the browser's. */
+export function getUserTimeZone(): string {
 	return (
 		localStorage.getItem(TIMEZONE_STORAGE_KEY) ||
 		Intl.DateTimeFormat().resolvedOptions().timeZone

package/src/validations/case/__tests__/case.validations.spec.ts

@@ -0,0 +1,73 @@
+import { describe, expect, it } from 'vitest';
+import { z } from 'zod';
+
+import { filledLookupSchema } from '../../_shared/lookup.validations';
+import { caseCloseFieldsChecks, caseSchema } from '../case.validations';
+
+const schema = caseSchema
+	.extend({
+		source: filledLookupSchema,
+		service: filledLookupSchema,
+	})
+	.check(...caseCloseFieldsChecks);
+
+const issuePaths = (value: unknown) =>
+	schema.safeParse(value).error?.issues.map(({ path }) => path.join('.')) ?? [];
+
+describe('caseCloseFieldsChecks', () => {
+	const finalStatusCondition = {
+		id: '6',
+		name: 'Closed',
+		final: true,
+	};
+
+	it('requires close fields on a final case while other fields are still unset', () => {
+		const paths = issuePaths({
+			statusCondition: finalStatusCondition,
+			closeReason: null,
+			closeResult: '',
+		});
+
+		expect(paths).toEqual(
+			expect.arrayContaining([
+				'source',
+				'service',
+				'closeReason',
+				'closeResult',
+			]),
+		);
+	});
+
+	it('points an empty close reason object at its id', () => {
+		expect(
+			issuePaths({
+				statusCondition: finalStatusCondition,
+				closeReason: {},
+				closeResult: 'a result',
+			}),
+		).toContain('closeReason.id');
+	});
+
+	it('does not require close fields on a non-final case', () => {
+		const paths = issuePaths({
+			statusCondition: {
+				id: '5',
+				name: 'New',
+				initial: true,
+			},
+		});
+
+		expect(paths).not.toContain('closeReason');
+		expect(paths).not.toContain('closeResult');
+	});
+
+	it('does not throw when the parsed value is not an object', () => {
+		expect(() => schema.safeParse(undefined)).not.toThrow();
+		expect(() =>
+			z
+				.object({})
+				.check(...caseCloseFieldsChecks)
+				.safeParse(null),
+		).not.toThrow();
+	});
+});

package/src/validations/case/case.validations.ts

@@ -33,35 +33,42 @@ export const caseSchema = z.object({
 	closeResult: z.string().default(''),
 } satisfies Partial<Record<keyof WebitelCasesCase, z.ZodType>>);
 
-export const refineCaseCloseFields = (
-	data: Pick<
-		z.infer<typeof caseSchema>,
-		'statusCondition' | 'closeReason' | 'closeResult'
-	>,
-	ctx: z.RefinementCtx,
-) => {
-	if (!data.statusCondition?.final) return;
+type CaseCloseFields = Pick<
+	z.infer<typeof caseSchema>,
+	'statusCondition' | 'closeReason' | 'closeResult'
+>;
 
-	if (!data.closeReason?.id)
-		ctx.addIssue({
-			code: 'custom',
-			path: data.closeReason
-				? [
-						'closeReason',
-						'id',
-					]
-				: [
-						'closeReason',
-					],
+const requiredOnFinalCase = (
+	isFilled: (data: CaseCloseFields) => boolean,
+	path: string[],
+) =>
+	z.refine<CaseCloseFields>(
+		(data) => !data?.statusCondition?.final || isFilled(data),
+		{
+			path,
+			when: () => true,
 			...i18nIssue('required'),
-		});
+		},
+	);
 
-	if (!data.closeResult)
-		ctx.addIssue({
-			code: 'custom',
-			path: [
-				'closeResult',
-			],
-			...i18nIssue('required'),
-		});
-};
+export const caseCloseFieldsChecks = [
+	requiredOnFinalCase(
+		(data) => Boolean(data.closeReason),
+		[
+			'closeReason',
+		],
+	),
+	requiredOnFinalCase(
+		(data) => !data.closeReason || Boolean(data.closeReason.id),
+		[
+			'closeReason',
+			'id',
+		],
+	),
+	requiredOnFinalCase(
+		(data) => Boolean(data.closeResult),
+		[
+			'closeResult',
+		],
+	),
+];