@webitel/api-services 26.8.21 → 26.8.23

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@webitel/api-services",
-	"version": "26.8.21",
+	"version": "26.8.23",
 	"private": false,
 	"repository": {
 		"type": "git",

package/src/validations/queue/__tests__/queue.validations.spec.ts

@@ -118,6 +118,21 @@ describe('queueSchema', () => {
 		}
 	});
 
+	/** A message here would reach the ui untranslated. WTEL-10294 */
+	it('reports a below-minimum number as too_small, without a message', () => {
+		const queue = validQueueFor(QueueType.INBOUND_QUEUE);
+		queue.priority = -1;
+
+		const issue = queueSchema
+			.safeParse(queue)
+			.error?.issues.find((i) => i.path.join('.') === 'priority');
+
+		expect(issue).toMatchObject({
+			code: 'too_small',
+			minimum: 0,
+		});
+	});
+
 	/** Vuelidate's `required` treats 0 and false as filled; ours must too. */
 	it('treats a zero priority as filled rather than missing', () => {
 		const queue = validQueueFor(QueueType.INBOUND_QUEUE);
@@ -174,10 +189,20 @@ describe('queueSchema', () => {
 		});
 	});
 
-	/** Legacy required `maxAttempts` on six types; the backend never did. WTEL-10326 */
-	it.each(allQueueTypes)('lets type %i save without maxAttempts', (type) => {
+	/**
+	 * Dialing numbers the legacy switch required and the backend does not.
+	 * WTEL-10292, WTEL-10326
+	 */
+	const legacyRequiredNumbers = [
+		'payload.maxAttempts',
+		'payload.originateTimeout',
+		'payload.waitBetweenRetries',
+		'payload.maxWaitTime',
+	];
+
+	it.each(allQueueTypes)('lets type %i save with those cleared', (type) => {
 		const queue = validQueueFor(type);
-		set(queue, 'payload.maxAttempts', null);
+		for (const path of legacyRequiredNumbers) set(queue, path, null);
 
 		expect(issuePaths(queueSchema.safeParse(queue))).toEqual([]);
 	});

package/src/validations/queue/queue.rules.ts

@@ -19,10 +19,10 @@ export interface QueueTypeRule {
  *   queues that save fine today.
  * - `priority` and `payload.minOnlineAgents` carry `minValue(0)` for *all* ten
  *   types, including the ones whose form never shows `minOnlineAgents`.
- * - `payload.originateTimeout`, `payload.waitBetweenRetries` (WTEL-10292) and
- *   `payload.maxAttempts` (WTEL-10326) drop the legacy `required`: the backend
- *   takes a queue without them, so it only blocked saving a cleared field.
- *   Their `minValue` stays — it skips an empty value.
+ * - `payload.originateTimeout`, `payload.waitBetweenRetries`, `payload.maxWaitTime`
+ *   (WTEL-10292) and `payload.maxAttempts` (WTEL-10326) drop the legacy
+ *   `required`: the backend takes a queue without them, so it only blocked
+ *   saving a cleared field. Their `minValue` stays — it skips an empty value.
  */
 export const sharedQueueRules: QueueTypeRule = {
 	required: [
@@ -47,7 +47,6 @@ export const queueTypeRules: Record<number, QueueTypeRule> = {
 	[QueueType.INBOUND_QUEUE]: {
 		required: [
 			'payload.timeBaseScore',
-			'payload.maxWaitTime',
 		],
 		minValue: {
 			'payload.maxWaitTime': 0,
@@ -109,7 +108,6 @@ export const queueTypeRules: Record<number, QueueTypeRule> = {
 		required: [
 			'strategy',
 			'payload.timeBaseScore',
-			'payload.maxWaitTime',
 		],
 		minValue: {
 			'payload.maxWaitTime': 0,
@@ -121,7 +119,6 @@ export const queueTypeRules: Record<number, QueueTypeRule> = {
 		required: [
 			'strategy',
 			'payload.timeBaseScore',
-			'payload.maxWaitTime',
 		],
 		minValue: {
 			'payload.maxWaitTime': 0,
@@ -132,7 +129,6 @@ export const queueTypeRules: Record<number, QueueTypeRule> = {
 		required: [
 			'strategy',
 			'calendar',
-			'payload.waitBetweenRetries',
 		],
 		minValue: {
 			'payload.waitBetweenRetries': 0,

package/src/validations/queue/queue.validations.ts

@@ -88,10 +88,17 @@ export const queueSchema = queueSchemaBase.superRefine((queue, ctx) => {
 			// an absent optional field is the `required` rules' business, not this one
 			if (value === undefined || value === null || value === '') continue;
 			if (Number(value) < min) {
+				/**
+				 * `too_small`, not a message: a message wins over the app's error
+				 * map, the only thing that translates. WTEL-10294
+				 */
 				ctx.addIssue({
-					code: 'custom',
+					code: 'too_small',
+					origin: 'number',
+					minimum: min,
+					inclusive: true,
+					input: value,
 					path: path.split('.'),
-					message: `Value must be ${min} or greater`,
 				});
 			}
 		}