@webitel/api-services 26.8.10 → 26.8.12

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@webitel/api-services",
-	"version": "26.8.10",
+	"version": "26.8.12",
 	"private": false,
 	"repository": {
 		"type": "git",

package/src/api/clients/__tests__/wireParamsCoverage.spec.ts

@@ -214,6 +214,7 @@ const knownSortShape = new Set([
 	'listPhones',
 	'listVariables',
 	'searchData',
+	'searchDevice',
 	'searchOAuthService',
 	'searchType',
 	'searchTypes',

package/src/api/clients/caseLinks/__tests__/caseLinks.spec.ts

@@ -0,0 +1,45 @@
+import { describe, expect, it, vi } from 'vitest';
+
+const createLink = vi.fn(() =>
+	Promise.resolve({
+		data: {},
+	}),
+);
+
+vi.mock('../../../../gen-wire', async (importOriginal) => ({
+	...(await importOriginal<Record<string, unknown>>()),
+	getCaseLinks: () => ({
+		createLink,
+	}),
+}));
+
+const { CreateLinkQueryParams } = await import('../../../../gen-wire');
+const { CaseLinksAPI } = await import('../caseLinks');
+
+/**
+ * [WTEL-10338](https://webitel.atlassian.net/browse/WTEL-10338)
+ *
+ * `addLink` derived its field allowlist from `CreateLinkParams` — the schema
+ * for this endpoint's path param (`case_etag`) — instead of
+ * `CreateLinkQueryParams` (`input.url`, `input.name`, ...). `sanitizeToWire`
+ * then dropped every field, so the request always went out with no query
+ * params and the backend rejected it with "url is required".
+ */
+describe('CaseLinksAPI.add', () => {
+	it('sends url and name as query params', async () => {
+		await CaseLinksAPI.add({
+			parentId: '1354',
+			input: {
+				url: 'https://example.com',
+				name: 'Example link',
+			},
+		});
+
+		const [, params] = createLink.mock.calls[0];
+		expect(params).toMatchObject({
+			'input.url': 'https://example.com',
+			'input.name': 'Example link',
+		});
+		expect(CreateLinkQueryParams.strict().safeParse(params).success).toBe(true);
+	});
+});

package/src/api/clients/caseLinks/caseLinks.ts

@@ -1,6 +1,6 @@
 import { getShallowFieldsToSendFromZodSchema } from '@webitel/api-services/gen/utils';
 import {
-	CreateLinkParams,
+	CreateLinkQueryParams,
 	getCaseLinks,
 	ListLinksQueryParams,
 	UpdateLink2Body,
@@ -60,8 +60,11 @@ const getLinksList = async ({
 	}
 };
 
-const createLinkFieldsToSend =
-	getShallowFieldsToSendFromZodSchema(CreateLinkParams);
+// `CreateLinkParams` (the path-param schema, just `case_etag`) looks like the right
+// name here but isn't: the fields actually sent for this call are the query params.
+const createLinkFieldsToSend = getShallowFieldsToSendFromZodSchema(
+	CreateLinkQueryParams,
+);
 
 const addLink = async ({
 	parentId,

package/src/api/clients/cases/cases.ts

@@ -221,6 +221,13 @@ const updateCase = async ({ itemInstance }: AddItemParams) => {
 		const response = await casesService.updateCase(etag, item, {
 			fields: caseFieldsToSend,
 		});
+
+		if (!response.data?.case) {
+			return await getCase({
+				itemId: String(etag),
+			});
+		}
+
 		return applyTransform(response.data.case, [
 			snakeToCamel([
 				'custom',
@@ -274,6 +281,13 @@ const patchCase = async ({
 		const response = await casesService.updateCase2(String(etag), body, {
 			fields: caseFieldsToSend,
 		});
+
+		if (!response.data?.case) {
+			return await getCase({
+				itemId: String(etag),
+			});
+		}
+
 		return applyTransform(response.data.case, [
 			snakeToCamel([
 				'custom',

package/src/api/clients/devices/devices.ts

@@ -165,29 +165,27 @@ const getDevicesLookup = (params: Parameters<typeof getDevicesList>[0]) =>
 	});
 
 const getDeviceHistory = async ({ parentId, from, to, ...rest }: ApiParams) => {
+	// `SearchDeviceAuditQueryParams` (device audit history) declares neither a
+	// text search nor `time_to` — only `time_from`/`time_till`. Sending `search`
+	// (or its old `q` alias) and `timeTo` used to pass sanitize()'s allowlist and
+	// then get silently dropped by the backend: no error, filters just did nothing.
 	const historyFieldsToSend = [
 		'page',
 		'size',
-		'search',
 		'fields',
 		'id',
 		'timeFrom',
-		'timeTo',
+		'timeTill',
 	];
 
 	const requestParams = applyTransform(
 		{
 			...rest,
 			timeFrom: from,
-			timeTo: to,
+			timeTill: to,
 		},
 		[
 			merge(getDefaultGetParams()),
-			starToSearch('search'),
-			(params) => ({
-				...params,
-				q: params.search,
-			}),
 			sanitize(historyFieldsToSend),
 			camelToSnake(),
 		],

package/src/validations/queueBucket/queueBucket.validations.ts

@@ -5,6 +5,6 @@ import { filledLookupSchema } from '../_shared/lookup.validations';
 export const queueBucketSchema = z.object({
 	bucket: filledLookupSchema,
 	/** legacy: required + numeric + minValue(0) */
-	priority: z.number().min(0),
+	priority: z.number().min(0).default(0),
 	disabled: z.boolean().optional(),
 });