@webitel/api-services 0.1.70 → 0.1.71

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@webitel/api-services",
-	"version": "0.1.70",
+	"version": "0.1.71",
 	"private": false,
 	"repository": {
 		"type": "git",

package/src/api/clients/queues/defaults/__tests__/queueTypeDefaults.spec.ts

@@ -141,3 +141,49 @@ describe('getQueueDefaults', () => {
 		expect(hasQueueTypeDefaults(undefined)).toBe(false);
 	});
 });
+
+/**
+ * A lookup the user has not filled must be seeded as `undefined`, not `{}`.
+ *
+ * The key still has to be there — regle builds its `$fields` from the state
+ * keys — but an empty *object* makes regle treat the field as a collection and
+ * file a root-level `superRefine` issue for it under an index, where nothing
+ * reads it: the field shows no error, `r$.$error` stays false so the save
+ * button stays enabled, and the save then aborts silently on `$validate()`.
+ *
+ * [WTEL-10140](https://webitel.atlassian.net/browse/WTEL-10140)
+ */
+describe('lookup defaults', () => {
+	const lookupKeys = [
+		'calendar',
+		'dncList',
+		'team',
+		'ringtone',
+		'grantee',
+		'schema',
+		'doSchema',
+		'afterSchema',
+		'formSchema',
+	];
+
+	it('seeds unset lookups as undefined, keeping the key', () => {
+		for (const type of allQueueTypes) {
+			const defaults = getQueueDefaults(type) as Record<string, unknown>;
+
+			for (const key of lookupKeys) {
+				if (!(key in defaults)) continue;
+
+				expect(
+					defaults[key],
+					`${key} on queue type ${type} must be undefined, not an empty object`,
+				).toBeUndefined();
+			}
+		}
+	});
+
+	it('keeps taskProcessing.formSchema out of the empty-object shape too', () => {
+		const taskProcessing = processing() as Record<string, unknown>;
+
+		expect(taskProcessing.formSchema).toBeUndefined();
+	});
+});

package/src/api/clients/queues/defaults/amd.ts

@@ -2,7 +2,7 @@ export const amd = () => ({
 	enabled: false,
 	ai: false,
 	positive: [],
-	playback: {},
+	playback: undefined,
 	allowNotSure: false,
 	silenceNotSure: false,
 	maxWordLength: 5000,

package/src/api/clients/queues/defaults/defaultQueue.ts

@@ -3,7 +3,7 @@ export const defaultQueue = () => ({
 	description: '',
 	priority: 0,
 	tags: [],
-	dncList: {},
-	calendar: {},
+	dncList: undefined,
+	calendar: undefined,
 	variables: [],
 });

package/src/api/clients/queues/defaults/processing.ts

@@ -4,7 +4,7 @@ export const processing = (overrides = {}) =>
 	deepmerge(
 		{
 			enabled: false,
-			formSchema: {},
+			formSchema: undefined,
 			sec: 30,
 			renewalSec: 15,
 			prolongationOptions: {

package/src/api/clients/queues/defaults/queueTypeDefaults.ts

@@ -33,11 +33,11 @@ export interface QueueDefaults {
 const offlineQueue = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.OFFLINE_QUEUE,
-	team: {},
+	team: undefined,
 	strategy: QueueStrategy.FIFO,
-	doSchema: {},
-	afterSchema: {},
-	grantee: {},
+	doSchema: undefined,
+	afterSchema: undefined,
+	grantee: undefined,
 	taskProcessing: processing(),
 	payload: {
 		maxAttempts: 3,
@@ -54,9 +54,9 @@ const offlineQueue = (): QueueDefaults => ({
 const inboundQueue = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.INBOUND_QUEUE,
-	team: {},
-	ringtone: {},
-	grantee: {},
+	team: undefined,
+	ringtone: undefined,
+	grantee: undefined,
 	stickyAgent: false,
 	taskProcessing: processing(),
 	payload: {
@@ -80,10 +80,10 @@ const outboundIVRQueue = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.OUTBOUND_IVR_QUEUE,
 	strategy: QueueStrategy.FIFO,
-	schema: {},
-	doSchema: {},
-	afterSchema: {},
-	grantee: {},
+	schema: undefined,
+	doSchema: undefined,
+	afterSchema: undefined,
+	grantee: undefined,
 	payload: {
 		minDuration: 3,
 		maxAttempts: 3,
@@ -104,11 +104,11 @@ const outboundIVRQueue = (): QueueDefaults => ({
 const previewDialer = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.PREVIEW_DIALER,
-	team: {},
+	team: undefined,
 	strategy: QueueStrategy.FIFO,
-	doSchema: {},
-	afterSchema: {},
-	grantee: {},
+	doSchema: undefined,
+	afterSchema: undefined,
+	grantee: undefined,
 	stickyAgent: false,
 	taskProcessing: processing(),
 	payload: {
@@ -132,12 +132,12 @@ const previewDialer = (): QueueDefaults => ({
 const progressiveDialer = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.PROGRESSIVE_DIALER,
-	team: {},
+	team: undefined,
 	strategy: QueueStrategy.FIFO,
-	doSchema: {},
-	afterSchema: {},
-	ringtone: {},
-	grantee: {},
+	doSchema: undefined,
+	afterSchema: undefined,
+	ringtone: undefined,
+	grantee: undefined,
 	stickyAgent: false,
 	taskProcessing: processing(),
 	payload: {
@@ -165,11 +165,11 @@ const predictiveDialer = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.PREDICTIVE_DIALER,
 	strategy: QueueStrategy.FIFO,
-	team: {},
-	doSchema: {},
-	afterSchema: {},
-	ringtone: {},
-	grantee: {},
+	team: undefined,
+	doSchema: undefined,
+	afterSchema: undefined,
+	ringtone: undefined,
+	grantee: undefined,
 	stickyAgent: false,
 	taskProcessing: processing(),
 	payload: {
@@ -209,9 +209,9 @@ const predictiveDialer = (): QueueDefaults => ({
 const chatInboundQueue = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.CHAT_INBOUND_QUEUE,
-	team: {},
+	team: undefined,
 	strategy: QueueStrategy.FIFO,
-	formSchema: {},
+	formSchema: undefined,
 	stickyAgent: false,
 	taskProcessing: processing(),
 	payload: {
@@ -241,10 +241,10 @@ const imChatQueue = (): QueueDefaults => ({
 const inboundJobQueue = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.INBOUND_JOB_QUEUE,
-	team: {},
+	team: undefined,
 	strategy: QueueStrategy.FIFO,
-	doSchema: {},
-	afterSchema: {},
+	doSchema: undefined,
+	afterSchema: undefined,
 	stickyAgent: false,
 	taskProcessing: processing(),
 	payload: {
@@ -262,9 +262,9 @@ const outboundJobQueue = (): QueueDefaults => ({
 	...defaultQueue(),
 	type: QueueType.OUTBOUND_JOB_QUEUE,
 	strategy: QueueStrategy.FIFO,
-	schema: {},
-	doSchema: {},
-	afterSchema: {},
+	schema: undefined,
+	doSchema: undefined,
+	afterSchema: undefined,
 	payload: {
 		maxAttempts: 3,
 		originateTimeout: 60,