@webex/plugin-meetings 3.9.0 → 3.10.0

package/test/unit/spec/locus-info/index.js

@@ -772,7 +772,7 @@ describe('plugin-meetings', () => {
           },
         };
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateParticipants({});
+        locusInfo.updateParticipants({}, []);
 
         // if this assertion fails, double-check the attributes used in
         // the updateParticipants function in locus-info/index.js
@@ -790,6 +790,7 @@ describe('plugin-meetings', () => {
             selfId: '2',
             hostId: '3',
             isReplace: undefined,
+            removedParticipantIds: [],
           }
         );
         // note: in a real use case, recordingId, selfId, and hostId would all be the same
@@ -814,7 +815,7 @@ describe('plugin-meetings', () => {
         };
 
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateParticipants({}, true);
+        locusInfo.updateParticipants({}, [], true);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -830,6 +831,7 @@ describe('plugin-meetings', () => {
             selfId: '2',
             hostId: '3',
             isReplace: true,
+            removedParticipantIds: [],
           }
         );
       });
@@ -847,7 +849,7 @@ describe('plugin-meetings', () => {
         ];
 
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateParticipants(failureParticipant);
+        locusInfo.updateParticipants(failureParticipant, []);
         assert.calledWith(
           locusInfo.emitScoped,
           {
@@ -1641,6 +1643,28 @@ describe('plugin-meetings', () => {
         );
       });
 
+      it('should trigger MEETING_INFO_UPDATED even if the roles array is empty', () => {
+        const initialInfo = cloneDeep(meetingInfo);
+
+        const updateSelf = cloneDeep(self);
+        updateSelf.controls.role.roles = [];
+
+        locusInfo.emitScoped = sinon.stub();
+        locusInfo.updateMeetingInfo(initialInfo, updateSelf);
+
+        assert.calledWith(
+          locusInfo.emitScoped,
+          {
+            file: 'locus-info',
+            function: 'updateMeetingInfo',
+          },
+          LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
+          {
+            isInitializing: !self,
+          }
+          );
+        });
+
       const checkMeetingInfoUpdatedCalled = (expected, payload) => {
         const expectedArgs = [
           locusInfo.emitScoped,
@@ -2016,6 +2040,18 @@ describe('plugin-meetings', () => {
       });
     });
 
+    describe('#handleLocusAPIResponse', () => {
+      it('calls handleLocusDelta', () => {
+        const fakeLocus = {eventType: LOCUSEVENT.DIFFERENCE};
+
+        sinon.stub(locusInfo, 'handleLocusDelta');
+
+        locusInfo.handleLocusAPIResponse(mockMeeting, {locus: fakeLocus});
+
+        assert.calledWith(locusInfo.handleLocusDelta, fakeLocus, mockMeeting);
+      });
+    });
+
     describe('#LocusDeltaEvents', () => {
       const fakeMeeting = 'fakeMeeting';
       let sandbox = null;
@@ -2028,7 +2064,7 @@ describe('plugin-meetings', () => {
 
         fakeLocus = {
           meeting: true,
-          participants: true,
+          participants: [],
           url: 'newLocusUrl',
           syncUrl: 'newSyncUrl',
         };
@@ -2347,23 +2383,23 @@ describe('plugin-meetings', () => {
 
       it('applyLocusDeltaData handles LOCUS_URL_CHANGED action correctly', () => {
         const {LOCUS_URL_CHANGED} = LocusDeltaParser.loci;
-        const fakeDeltaLocus = {id: 'fake delta locus'};
+        const fakeFullLocus = {
+          url: 'new full loci url',
+        };
         const meeting = {
           meetingRequest: {
-            getLocusDTO: sandbox.stub().resolves({body: fakeDeltaLocus}),
+            getLocusDTO: sandbox.stub().resolves({body: fakeFullLocus}),
           },
           locusInfo: {
             handleLocusDelta: sandbox.stub(),
           },
-          locusUrl: 'current locus url',
+          locusUrl: 'current BO session locus url',
         };
 
-        locusInfo.locusParser.workingCopy = {
-          syncUrl: 'current sync url',
-        };
+        locusInfo.locusParser.workingCopy = null;
 
         locusInfo.applyLocusDeltaData(LOCUS_URL_CHANGED, fakeLocus, meeting);
-        assert.calledOnceWithExactly(meeting.meetingRequest.getLocusDTO, {url: 'current sync url'});
+        assert.calledOnceWithExactly(meeting.meetingRequest.getLocusDTO, {url: fakeLocus.url});
       });
 
       describe('edge cases for sync failing', () => {
@@ -2503,7 +2539,7 @@ describe('plugin-meetings', () => {
       });
 
       it('onDeltaLocus handle delta data', () => {
-        fakeLocus.participants = {};
+        fakeLocus.participants = [];
         const fakeBreakout = {
           sessionId: 'sessionId',
           groupId: 'groupId',
@@ -2520,11 +2556,11 @@ describe('plugin-meetings', () => {
         };
         locusInfo.updateParticipants = sinon.stub();
         locusInfo.onDeltaLocus(fakeLocus);
-        assert.calledWith(locusInfo.updateParticipants, {}, false);
+        assert.calledWith(locusInfo.updateParticipants, [], undefined, false);
 
         fakeLocus.controls.breakout.sessionId = 'sessionId2';
         locusInfo.onDeltaLocus(fakeLocus);
-        assert.calledWith(locusInfo.updateParticipants, {}, true);
+        assert.calledWith(locusInfo.updateParticipants, [], undefined, true);
       });
 
       it('onDeltaLocus merges delta participants with existing participants', () => {
@@ -2541,7 +2577,7 @@ describe('plugin-meetings', () => {
           existingParticipants,
           FAKE_DELTA_PARTICIPANTS
         );
-        assert.calledWith(locusInfo.updateParticipants, FAKE_DELTA_PARTICIPANTS, false);
+        assert.calledWith(locusInfo.updateParticipants, FAKE_DELTA_PARTICIPANTS, undefined, false);
       });
 
       [true, false].forEach((isDelta) =>
@@ -2984,6 +3020,45 @@ describe('plugin-meetings', () => {
       });
     });
 
+    describe('#updateLocusUrl', () => {
+      it('trigger LOCUS_INFO_UPDATE_URL event with isMainLocus is true as default', () => {
+        const fakeUrl = "https://fake.com/locus";
+        locusInfo.emitScoped = sinon.stub();
+        locusInfo.updateLocusUrl(fakeUrl);
+
+        assert.calledWith(
+          locusInfo.emitScoped,
+          {
+            file: 'locus-info',
+            function: 'updateLocusUrl',
+          },
+          EVENTS.LOCUS_INFO_UPDATE_URL,
+          {
+            url: fakeUrl,
+            isMainLocus: true
+          },
+        );
+      });
+      it('trigger LOCUS_INFO_UPDATE_URL event with isMainLocus is false', () => {
+        const fakeUrl = "https://fake.com/locus";
+        locusInfo.emitScoped = sinon.stub();
+        locusInfo.updateLocusUrl(fakeUrl, false);
+
+        assert.calledWith(
+          locusInfo.emitScoped,
+          {
+            file: 'locus-info',
+            function: 'updateLocusUrl',
+          },
+          EVENTS.LOCUS_INFO_UPDATE_URL,
+          {
+            url: fakeUrl,
+            isMainLocus: false
+          },
+        );
+      });
+    });
+
     // semi-integration tests that use real LocusInfo with real Parser
     // and test various scenarios related to handling out-of-order Locus delta events
     describe('handling of out-of-order Locus delta events', () => {
@@ -3052,6 +3127,7 @@ describe('plugin-meetings', () => {
               id: 'test person id',
             },
           },
+          participants: [],
         });
 
         updateLocusInfoStub.resetHistory();

package/test/unit/spec/locus-info/parser.js

@@ -253,7 +253,8 @@ describe('locus-info/parser', () => {
     });
     
     it('replaces current loci when the locus URL changes and incoming sequence is later, even when baseSequence doesn\'t match', () => {
-      const {USE_INCOMING} = LocusDeltaParser.loci;
+      const {LOCUS_URL_CHANGED} = LocusDeltaParser.loci;
+      sandbox.stub(LocusDeltaParser, 'compare').returns(LOCUS_URL_CHANGED);
 
       parser.queue.dequeue = sandbox.stub().returns(NEW_LOCI);
       parser.onDeltaAction = sandbox.stub();
@@ -262,7 +263,7 @@ describe('locus-info/parser', () => {
 
       parser.processDeltaEvent();
 
-      assert.equal(parser.workingCopy, NEW_LOCI);
+      assert.equal(parser.workingCopy, null);
     });
 
     it('does not replace current loci when the locus URL changes but incoming sequence is not later', () => {

package/test/unit/spec/media/properties.ts

@@ -6,6 +6,8 @@ import * as tsSdpModule from '@webex/ts-sdp';
 import MediaProperties from '@webex/plugin-meetings/src/media/properties';
 import {Defer} from '@webex/common';
 import MediaConnectionAwaiter from '../../../../src/media/MediaConnectionAwaiter';
+import Metrics from '../../../../src/metrics';
+import BEHAVIORAL_METRICS from '../../../../src/metrics/constants';
 
 describe('MediaProperties', () => {
   let mediaProperties;
@@ -389,4 +391,139 @@ describe('MediaProperties', () => {
       });
     });
   });
+
+  // issue types and subtypes used in these tests are just examples
+  // they don't reflect real issue types/subtypes used in production
+  describe('sendMediaIssueMetric', () => {
+    let sendBehavioralMetricStub;
+    let clock;
+
+    beforeEach(() => {
+      clock = sinon.useFakeTimers();
+      sendBehavioralMetricStub = sinon.stub(Metrics, 'sendBehavioralMetric');
+    });
+
+    afterEach(() => {
+      clock.restore();
+    });
+
+    it('should send a behavioral metric with correct parameters', () => {
+      const issueType = 'audio';
+      const issueSubType = 'packet-loss';
+      const correlationId = 'test-correlation-id-123';
+
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+
+      assert.calledOnce(sendBehavioralMetricStub);
+      assert.calledWith(sendBehavioralMetricStub, BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED, {
+        correlationId,
+        'audio_packet-loss': 1,
+      });
+    });
+
+    it('should increment count while being throttled and reset it once metric goes out', () => {
+      const issueType = 'video';
+      const issueSubType = 'freeze';
+      const correlationId = 'test-correlation-id';
+
+      // Call multiple times with same issue type/subtype
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+
+      // First call should go through immediately, subsequent calls are throttled
+      assert.calledOnce(sendBehavioralMetricStub);
+      assert.calledWith(sendBehavioralMetricStub, BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED, {
+        correlationId,
+        video_freeze: 1, // Only the first call goes through due to throttling
+      });
+      sendBehavioralMetricStub.resetHistory();
+
+      assert.equal(mediaProperties.mediaIssueCounters['video_freeze'], 2); // counter should be reset after the first metric goes out, hence only 2 not 3 here
+
+      clock.tick(5 * 60 * 1000); // Advance time by 5 minutes to expire throttle
+
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          video_freeze: 2,
+        }
+      );
+    });
+
+    it('should track different issue types separately in counters', () => {
+      const correlationId = 'test-correlation-id';
+
+      // Send different issue types
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('video', 'freeze', correlationId);
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('video', 'freeze', correlationId);
+
+      // First call should go through immediately, subsequent calls are throttled
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          'audio_packet-loss': 1,
+        }
+      );
+
+      // But the counters should be tracked separately
+      assert.equal(mediaProperties.mediaIssueCounters['audio_packet-loss'], 3);
+      assert.equal(mediaProperties.mediaIssueCounters['video_freeze'], 2);
+
+      sendBehavioralMetricStub.resetHistory();
+
+      clock.tick(5 * 60 * 1000); // Advance time by 5 minutes to expire throttle
+
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          video_freeze: 2,
+          'audio_packet-loss': 3,
+        }
+      );
+    });
+
+    it('should flush throttled metrics when unsetPeerConnection is called', () => {
+      const issueType = 'share';
+      const issueSubType = 'connection-lost';
+      const correlationId = 'test-correlation-id';
+
+      // Send metrics multiple times
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+
+      // First call should go through immediately
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          'share_connection-lost': 1,
+        }
+      );
+      sendBehavioralMetricStub.resetHistory();
+
+      // Call unsetPeerConnection which should flush throttled metrics
+      mediaProperties.unsetPeerConnection();
+
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          'share_connection-lost': 1,
+        }
+      );
+    });
+  });
 });

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -35,9 +35,12 @@ describe('plugin-meetings', () => {
         isLocalRecordingStarted: null,
         isLocalRecordingStopped: null,
         isLocalRecordingPaused: null,
+        isLocalStreamingStarted:null,
+        isLocalStreamingStopped:null,
         isManualCaptionActive: null,
         isPremiseRecordingEnabled: null,
         isSaveTranscriptsEnabled: null,
+        isSpokenLanguageAutoDetectionEnabled: null,
         isWebexAssistantActive: null,
         canViewCaptionPanel: null,
         isRealTimeTranslationEnabled: null,
@@ -85,6 +88,7 @@ describe('plugin-meetings', () => {
         canDoVideo: null,
         canAnnotate: null,
         canUseVoip: null,
+        showAutoEndMeetingWarning: null,
         supportHQV: null,
         supportHDV: null,
         canShareWhiteBoard: null,
@@ -135,6 +139,8 @@ describe('plugin-meetings', () => {
       'isLocalRecordingStarted',
       'isLocalRecordingStopped',
       'isLocalRecordingPaused',
+      'isLocalStreamingStarted',
+      'isLocalStreamingStopped',
       'canSetMuteOnEntry',
       'canUnsetMuteOnEntry',
       'canSetDisallowUnmute',
@@ -151,6 +157,7 @@ describe('plugin-meetings', () => {
       'isManualCaptionActive',
       'isPremiseRecordingEnabled',
       'isSaveTranscriptsEnabled',
+      'isSpokenLanguageAutoDetectionEnabled',
       'isWebexAssistantActive',
       'canViewCaptionPanel',
       'isRealTimeTranslationEnabled',
@@ -195,6 +202,7 @@ describe('plugin-meetings', () => {
       'canRealtimeCloseCaption',
       'canRealtimeCloseCaptionManual',
       'canChat',
+      'showAutoEndMeetingWarning',
       'canDoVideo',
       'canAnnotate',
       'canUseVoip',