@webex/plugin-meetings 3.9.0-next.2 → 3.9.0-next.21

package/test/unit/spec/meeting/muteState.js

@@ -12,7 +12,7 @@ describe('plugin-meetings', () => {
   let video;
   let originalRemoteUpdateAudioVideo;
 
-  const fakeLocus = {info: 'this is a fake locus'};
+  const fakeLocusResponse = {body: {locus: {info: 'this is a fake locus'}}};
 
   const createFakeLocalStream = (id, userMuted, systemMuted) => {
     return {
@@ -38,9 +38,6 @@ describe('plugin-meetings', () => {
       unmuteAllowed: true,
       remoteVideoMuted: false,
       unmuteVideoAllowed: true,
-      locusInfo: {
-        handleLocusDelta: sinon.stub(),
-      },
       members: {
         selfId: 'fake self id',
         muteMember: sinon.stub().resolves(),
@@ -49,7 +46,8 @@ describe('plugin-meetings', () => {
 
     originalRemoteUpdateAudioVideo = MeetingUtil.remoteUpdateAudioVideo;
 
-    MeetingUtil.remoteUpdateAudioVideo = sinon.stub().resolves(fakeLocus);
+    MeetingUtil.remoteUpdateAudioVideo = sinon.stub().resolves(fakeLocusResponse);
+    MeetingUtil.updateLocusFromApiResponse = sinon.stub();
 
     audio = createMuteState(AUDIO, meeting, true);
     video = createMuteState(VIDEO, meeting, true);
@@ -141,6 +139,7 @@ describe('plugin-meetings', () => {
       // and local unmute was sent to server
       assert.calledOnce(MeetingUtil.remoteUpdateAudioVideo);
       assert.calledWith(MeetingUtil.remoteUpdateAudioVideo, meeting, false, undefined);
+      assert.calledWith(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
 
       assert.isFalse(audio.isMuted());
     });
@@ -173,6 +172,7 @@ describe('plugin-meetings', () => {
 
       // system was muted so local unmute was not sent to server
       assert.notCalled(MeetingUtil.remoteUpdateAudioVideo);
+      assert.notCalled(MeetingUtil.updateLocusFromApiResponse);
 
       assert.isTrue(audio.isMuted());
     });
@@ -207,6 +207,7 @@ describe('plugin-meetings', () => {
       // and local unmute was sent to server
       assert.calledOnce(MeetingUtil.remoteUpdateAudioVideo);
       assert.calledWith(MeetingUtil.remoteUpdateAudioVideo, meeting, undefined, false);
+      assert.calledWith(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
 
       assert.isFalse(video.isMuted());
     });
@@ -219,7 +220,9 @@ describe('plugin-meetings', () => {
 
       assert.isTrue(video.isMuted());
 
+      await testUtils.flushPromises();
       MeetingUtil.remoteUpdateAudioVideo.resetHistory();
+      MeetingUtil.updateLocusFromApiResponse.resetHistory();
 
       // now simulate server requiring us to locally unmute
       // assuming setServerMuted succeeds at updating userMuted
@@ -239,6 +242,7 @@ describe('plugin-meetings', () => {
 
       // system was muted so local unmute was not sent to server
       assert.notCalled(MeetingUtil.remoteUpdateAudioVideo);
+      assert.notCalled(MeetingUtil.updateLocusFromApiResponse);
 
       assert.isTrue(video.isMuted());
     });
@@ -443,6 +447,7 @@ describe('plugin-meetings', () => {
 
         assert.calledOnce(MeetingUtil.remoteUpdateAudioVideo);
         assert.calledWith(MeetingUtil.remoteUpdateAudioVideo, meeting, true, undefined);
+        assert.calledWith(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
 
         // now allow the first request to complete
         serverResponseResolve();
@@ -559,6 +564,7 @@ describe('plugin-meetings', () => {
         await testUtils.flushPromises();
 
         MeetingUtil.remoteUpdateAudioVideo.resetHistory();
+        MeetingUtil.updateLocusFromApiResponse.resetHistory();
       };
 
       const setupSpies = (mediaType) => {
@@ -605,13 +611,15 @@ describe('plugin-meetings', () => {
         {mediaType: VIDEO, title: 'video'},
       ];
 
+      const fakeLocusResponse = {body: {locus: {info: 'fake locus'}}};
+
       tests.forEach(({mediaType, title}) =>
         describe(title, () => {
           let originalRemoteUpdateAudioVideo;
 
           beforeEach(() => {
             originalRemoteUpdateAudioVideo = MeetingUtil.remoteUpdateAudioVideo;
-            MeetingUtil.remoteUpdateAudioVideo = sinon.stub().resolves({info: 'fake locus'});
+            MeetingUtil.remoteUpdateAudioVideo = sinon.stub().resolves(fakeLocusResponse);
           });
 
           afterEach(() => {
@@ -660,6 +668,7 @@ describe('plugin-meetings', () => {
               assert.calledWith(setUnmuteAllowedSpy, muteState.state.server.unmuteAllowed);
               assert.notCalled(setServerMutedSpy);
               assert.notCalled(MeetingUtil.remoteUpdateAudioVideo);
+              assert.notCalled(MeetingUtil.updateLocusFromApiResponse);
               assert.isTrue(muteState.state.client.localMute);
             });
 
@@ -672,6 +681,7 @@ describe('plugin-meetings', () => {
               assert.calledWith(setUnmuteAllowedSpy, muteState.state.server.unmuteAllowed);
               assert.notCalled(setServerMutedSpy);
               assert.notCalled(MeetingUtil.remoteUpdateAudioVideo);
+              assert.notCalled(MeetingUtil.updateLocusFromApiResponse);
               assert.isTrue(muteState.state.client.localMute);
             });
 
@@ -681,9 +691,12 @@ describe('plugin-meetings', () => {
 
               muteState.init(meeting);
 
+              await testUtils.flushPromises();
+
               assert.calledWith(setUnmuteAllowedSpy, muteState.state.server.unmuteAllowed);
               assert.notCalled(setServerMutedSpy);
               assert.calledOnce(MeetingUtil.remoteUpdateAudioVideo);
+              assert.calledOnceWithExactly(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
               assert.isFalse(muteState.state.client.localMute);
             });
 
@@ -707,6 +720,7 @@ describe('plugin-meetings', () => {
               simulateUserMute(mediaType, true);
               muteState.handleLocalStreamMuteStateChange(meeting);
               assert.notCalled(MeetingUtil.remoteUpdateAudioVideo);
+              assert.notCalled(MeetingUtil.updateLocusFromApiResponse);
 
               assert.isFalse(muteState.state.client.localMute);
             });
@@ -716,8 +730,11 @@ describe('plugin-meetings', () => {
 
               simulateUserMute(mediaType, false);
               muteState.handleLocalStreamMuteStateChange(meeting);
+              await testUtils.flushPromises();
+
               assert.equal(muteState.state.client.localMute, false);
               assert.called(MeetingUtil.remoteUpdateAudioVideo);
+              assert.calledOnceWithExactly(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
             });
 
             it('tests localMute - user mute from false to true', async () => {
@@ -725,8 +742,11 @@ describe('plugin-meetings', () => {
 
               simulateUserMute(mediaType, true);
               muteState.handleLocalStreamMuteStateChange(meeting);
+              await testUtils.flushPromises();
+
               assert.equal(muteState.state.client.localMute, true);
               assert.called(MeetingUtil.remoteUpdateAudioVideo);
+              assert.calledOnceWithExactly(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
             });
 
             it('tests localMute - system mute from true to false', async () => {
@@ -734,8 +754,11 @@ describe('plugin-meetings', () => {
 
               simulateSystemMute(mediaType, false);
               muteState.handleLocalStreamMuteStateChange(meeting);
+              await testUtils.flushPromises();
+
               assert.equal(muteState.state.client.localMute, false);
               assert.called(MeetingUtil.remoteUpdateAudioVideo);
+              assert.calledOnceWithExactly(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
             });
 
             it('tests localMute - system mute from false to true', async () => {
@@ -743,8 +766,11 @@ describe('plugin-meetings', () => {
 
               simulateSystemMute(mediaType, true);
               muteState.handleLocalStreamMuteStateChange(meeting);
+              await testUtils.flushPromises();
+
               assert.equal(muteState.state.client.localMute, true);
               assert.called(MeetingUtil.remoteUpdateAudioVideo);
+              assert.calledOnceWithExactly(MeetingUtil.updateLocusFromApiResponse, meeting, fakeLocusResponse);
             });
           });
 

package/test/unit/spec/meeting/request.js

@@ -897,4 +897,25 @@ describe('plugin-meetings', () => {
       });
     });
   });
+
+  describe('#notifyHost', () => {
+    it('check locus status', async () => {
+      const siteFullUrl = 'ats062222cvg.webex.com';
+      const locusId = 'locusId';
+      const meetingUuid = 'meetingUuid';
+      const displayName = ['user1', 'user2'];
+      await meetingsRequest.notifyHost(siteFullUrl, locusId, meetingUuid, displayName);
+      assert.deepEqual(meetingsRequest.request.getCall(0).args[0], {
+        method: 'POST',
+        uri: `https://${siteFullUrl}/wbxappapi/v1/meetings/${meetingUuid}/notifyhost`,
+        body: {
+          displayName,
+          size: displayName?.length,
+        },
+        headers: {
+          locusId,
+        }
+      });
+    });
+  });
 });

package/test/unit/spec/meeting/utils.js

@@ -228,11 +228,11 @@ describe('plugin-meetings', () => {
       });
     });
 
-    describe('updateLocusWithDelta', () => {
-      it('should call handleLocusDelta with the new delta locus', () => {
+    describe('updateLocusFromApiResponse', () => {
+      it('should call handleLocusAPIResponse with the response body', () => {
         const meeting = {
           locusInfo: {
-            handleLocusDelta: sinon.stub(),
+            handleLocusAPIResponse: sinon.stub(),
           },
         };
 
@@ -242,16 +242,16 @@ describe('plugin-meetings', () => {
           },
         };
 
-        const response = MeetingUtil.updateLocusWithDelta(meeting, originalResponse);
+        const response = MeetingUtil.updateLocusFromApiResponse(meeting, originalResponse);
 
         assert.deepEqual(response, originalResponse);
-        assert.calledOnceWithExactly(meeting.locusInfo.handleLocusDelta, 'locus', meeting);
+        assert.calledOnceWithExactly(meeting.locusInfo.handleLocusAPIResponse, meeting, originalResponse.body);
       });
 
       it('should handle locus being missing from the response', () => {
         const meeting = {
           locusInfo: {
-            handleLocusDelta: sinon.stub(),
+            handleLocusAPIResponse: sinon.stub(),
           },
         };
 
@@ -259,10 +259,10 @@ describe('plugin-meetings', () => {
           body: {},
         };
 
-        const response = MeetingUtil.updateLocusWithDelta(meeting, originalResponse);
+        const response = MeetingUtil.updateLocusFromApiResponse(meeting, originalResponse);
 
         assert.deepEqual(response, originalResponse);
-        assert.notCalled(meeting.locusInfo.handleLocusDelta);
+        assert.notCalled(meeting.locusInfo.handleLocusAPIResponse);
       });
 
       it('should work with an undefined meeting', () => {
@@ -272,14 +272,14 @@ describe('plugin-meetings', () => {
           },
         };
 
-        const response = MeetingUtil.updateLocusWithDelta(undefined, originalResponse);
+        const response = MeetingUtil.updateLocusFromApiResponse(undefined, originalResponse);
         assert.deepEqual(response, originalResponse);
       });
     });
 
     describe('generateLocusDeltaRequest', () => {
       it('generates the correct wrapper function', async () => {
-        const updateLocusWithDeltaSpy = sinon.spy(MeetingUtil, 'updateLocusWithDelta');
+        const updateLocusFromApiResponseSpy = sinon.spy(MeetingUtil, 'updateLocusFromApiResponse');
         const addSequenceSpy = sinon.spy(MeetingUtil, 'addSequence');
 
         const meeting = {
@@ -296,16 +296,16 @@ describe('plugin-meetings', () => {
         let result = await locusDeltaRequest(options);
 
         assert.equal(result, 'result');
-        assert.calledOnceWithExactly(updateLocusWithDeltaSpy, meeting, 'result');
+        assert.calledOnceWithExactly(updateLocusFromApiResponseSpy, meeting, 'result');
         assert.calledOnceWithExactly(addSequenceSpy, meeting, options.body);
 
-        updateLocusWithDeltaSpy.resetHistory();
+        updateLocusFromApiResponseSpy.resetHistory();
         addSequenceSpy.resetHistory();
 
         // body missing from options
         result = await locusDeltaRequest({});
         assert.equal(result, 'result');
-        assert.calledOnceWithExactly(updateLocusWithDeltaSpy, meeting, 'result');
+        assert.calledOnceWithExactly(updateLocusFromApiResponseSpy, meeting, 'result');
         assert.calledOnceWithExactly(addSequenceSpy, meeting, options.body);
 
         // meeting disappears so the WeakRef returns undefined
@@ -359,7 +359,11 @@ describe('plugin-meetings', () => {
     });
 
     describe('remoteUpdateAudioVideo', () => {
-      it('#Should call meetingRequest.locusMediaRequest with correct parameters', async () => {
+      it('#Should call meetingRequest.locusMediaRequest with correct parameters and return the full response', async () => {
+        const fakeResponse = {
+          body: { locus: { url: 'locusUrl'}},
+          headers: { },
+        };
         const meeting = {
           id: 'meeting-id',
           mediaId: '12345',
@@ -368,13 +372,14 @@ describe('plugin-meetings', () => {
             sequence: {},
           },
           locusMediaRequest: {
-            send: sinon.stub().resolves({body: {}, headers: {}}),
+            send: sinon.stub().resolves(fakeResponse),
           },
           getWebexObject: sinon.stub().returns(webex),
         };
 
-        await MeetingUtil.remoteUpdateAudioVideo(meeting, true, false);
+        const result = await MeetingUtil.remoteUpdateAudioVideo(meeting, true, false);
 
+        assert.deepEqual(result, fakeResponse);
         assert.calledOnceWithExactly(meeting.locusMediaRequest.send, {
           mediaId: '12345',
           muteOptions: {
@@ -972,6 +977,9 @@ describe('plugin-meetings', () => {
       {functionName: 'isLocalRecordingPaused', displayHint: 'LOCAL_RECORDING_STATUS_PAUSED'},
 
       {functionName: 'isManualCaptionActive', displayHint: 'MANUAL_CAPTION_STATUS_ACTIVE'},
+
+      {functionName: 'isSpokenLanguageAutoDetectionEnabled', displayHint: 'SPOKEN_LANGUAGE_AUTO_DETECTION_ENABLED'},
+
       {functionName: 'isWebexAssistantActive', displayHint: 'WEBEX_ASSISTANT_STATUS_ACTIVE'},
       {functionName: 'canViewCaptionPanel', displayHint: 'ENABLE_CAPTION_PANEL'},
       {functionName: 'isRealTimeTranslationEnabled', displayHint: 'DISPLAY_REAL_TIME_TRANSLATION'},
@@ -1310,6 +1318,27 @@ describe('plugin-meetings', () => {
       });
     });
 
+    describe('getCaEventLabelsForIpVersion', () => {
+      [
+        {ipver: IP_VERSION.unknown, expectedLabels: undefined},
+        {ipver: IP_VERSION.only_ipv4, expectedLabels: ['hasIpv4_true']},
+        {ipver: IP_VERSION.only_ipv6, expectedLabels: ['hasIpv6_true']},
+        {
+          ipver: IP_VERSION.ipv4_and_ipv6,
+          expectedLabels: ['hasIpv4_true', 'hasIpv6_true'],
+        },
+      ].forEach(({ipver, expectedLabels}) => {
+        it(`returns expected labels when ipver=${ipver}`, () => {
+          sinon.stub(MeetingUtil, 'getIpVersion').returns(ipver);
+
+          const result = MeetingUtil.getCaEventLabelsForIpVersion(webex);
+
+          assert.calledOnceWithExactly(MeetingUtil.getIpVersion, webex);
+          assert.deepEqual(result, expectedLabels);
+        });
+      });
+    });
+
     describe('getChangeMeetingFloorErrorPayload', () => {
       [
         {

package/test/unit/spec/meeting-info/meetinginfov2.js

@@ -218,6 +218,7 @@ describe('plugin-meetings', () => {
             invitees: invitee,
             installedOrgID: undefined,
             schedule: true,
+            classificationId: undefined,
           },
         });
 
@@ -652,7 +653,8 @@ describe('plugin-meetings', () => {
         assert.calledOnceWithExactly(
           meetingInfo.createAdhocSpaceMeeting,
           'conversationUrl',
-          installedOrgID
+          installedOrgID,
+          null,
         );
         assert.notCalled(webex.request);
         meetingInfo.createAdhocSpaceMeeting.restore();
@@ -1148,6 +1150,7 @@ describe('plugin-meetings', () => {
     describe('createAdhocSpaceMeeting', () => {
       const conversationUrl = 'https://conversationUrl/xxx';
       const installedOrgID = '12345';
+      const classificationId = '123456';
 
       const setup = () => {
         const invitee = [];
@@ -1173,7 +1176,7 @@ describe('plugin-meetings', () => {
           body: conversation,
         });
 
-        const result = await meetingInfo.createAdhocSpaceMeeting(conversationUrl, installedOrgID);
+        const result = await meetingInfo.createAdhocSpaceMeeting(conversationUrl, installedOrgID, classificationId);
 
         assert.calledWith(webex.request, {
           uri: conversationUrl,
@@ -1192,6 +1195,7 @@ describe('plugin-meetings', () => {
             invitees: invitee,
             installedOrgID: installedOrgID,
             schedule: false,
+            classificationId,
           },
         });
         assert.calledOnce(Metrics.sendBehavioralMetric);
@@ -1206,7 +1210,7 @@ describe('plugin-meetings', () => {
         webex.request = sinon.stub().resolves({
           body: conversation,
         });
-        await meetingInfo.createAdhocSpaceMeeting(conversationUrl, installedOrgID);
+        await meetingInfo.createAdhocSpaceMeeting(conversationUrl, installedOrgID, classificationId);
 
         assert.calledWith(webex.request, {
           uri: conversationUrl,
@@ -1224,6 +1228,7 @@ describe('plugin-meetings', () => {
             invitees: invitee,
             installedOrgID,
             schedule: false,
+            classificationId,
           },
         });
         assert(Metrics.sendBehavioralMetric.calledOnce);

package/test/unit/spec/meetings/index.js

@@ -3,10 +3,6 @@
  */
 import 'jsdom-global/register';
 
-// Polyfill for crypto: https://github.com/jsdom/jsdom/issues/1612#issuecomment-663210638
-import {Crypto} from '@peculiar/webcrypto';
-global.crypto = new Crypto();
-
 import Device from '@webex/internal-plugin-device';
 import {CatalogDetails} from '@webex/internal-plugin-device';
 import Mercury from '@webex/internal-plugin-mercury';
@@ -1099,6 +1095,7 @@ describe('plugin-meetings', () => {
         const FAKE_USE_RANDOM_DELAY = true;
         const correlationId = 'my-correlationId';
         const sessionCorrelationId = 'my-session-correlationId';
+        const classificationId = 'my-classificationId';
         const callStateForMetrics = {
           sessionCorrelationId: 'my-session-correlationId2',
           correlationId: 'my-correlationId2',
@@ -1119,7 +1116,8 @@ describe('plugin-meetings', () => {
             callStateForMetrics,
             undefined,
             undefined,
-            sessionCorrelationId
+            sessionCorrelationId,
+            classificationId
           );
           assert.calledOnceWithExactly(fakeMeeting.updateCallStateForMetrics, {
             ...callStateForMetrics,
@@ -1201,6 +1199,13 @@ describe('plugin-meetings', () => {
           );
         });
 
+        it('calls createMeeting with classificationId and returns its promise', async () => {
+          await checkCallCreateMeeting(
+            [test1, test2, FAKE_USE_RANDOM_DELAY, {}, undefined, true, callStateForMetrics, undefined, undefined, undefined, classificationId],
+            [test1, test2, FAKE_USE_RANDOM_DELAY, {}, callStateForMetrics, true, undefined, undefined, classificationId],
+          );
+        });
+
         it('calls createMeeting with callStateForMetrics overwritten with correlationId and returns its promise', async () => {
           await checkCallCreateMeeting(
             [test1, test2, FAKE_USE_RANDOM_DELAY, {}, correlationId, true, callStateForMetrics],

package/test/unit/spec/members/collection.js

@@ -0,0 +1,120 @@
+const { default: MembersCollection } = require("../../../../src/members/collection");
+const { default: Member } = require("../../../../src/member");
+const { assert } = require('@webex/test-helper-chai');
+
+
+describe('plugin-meetings', () => {
+  describe('MembersCollection', () => {
+    let collection;
+    let member1;
+    let member2;
+    const participant1 = { controls: {}, status: {} };
+    const participant2 = { controls: {}, status: {} };
+
+    beforeEach(() => {
+      collection = new MembersCollection();
+      member1 = new Member(participant1);
+      member2 = new Member(participant2);
+    });
+
+    it('starts with no members', () => {
+      assert.equal(Object.keys(collection.getAll()).length, 0);
+    });
+
+    it('can add members', () => {      
+      collection.set('member1', member1);
+      assert.equal(Object.keys(collection.getAll()).length, 1);
+      assert.equal(collection.get('member1'), member1);
+
+      collection.set('member2', member2);
+      assert.equal(Object.keys(collection.getAll()).length, 2);
+      assert.equal(collection.get('member2'), member2);
+    });
+
+    it('can remove members', () => {
+      // Add some members first
+      collection.set('member1', member1);
+      collection.set('member2', member2);
+      assert.equal(Object.keys(collection.getAll()).length, 2);
+
+      // Remove one member
+      collection.remove('member1');
+      assert.equal(Object.keys(collection.getAll()).length, 1);
+      assert.equal(collection.get('member1'), undefined);
+      assert.equal(collection.get('member2'), member2);
+
+      // Remove another member
+      collection.remove('member2');
+      assert.equal(Object.keys(collection.getAll()).length, 0);
+      assert.equal(collection.get('member2'), undefined);
+
+      // Removing non-existent member should not cause errors
+      collection.remove('nonExistent');
+      assert.equal(Object.keys(collection.getAll()).length, 0);
+    });
+
+    describe('reset', () => {
+      it('removes all members', () => {
+        // Add some members first
+        collection.set('member1', member1);
+        collection.set('member2', member2);
+        assert.equal(Object.keys(collection.getAll()).length, 2);
+
+        // Reset should clear all members
+        collection.reset();
+        assert.equal(Object.keys(collection.getAll()).length, 0);
+        assert.equal(collection.get('member1'), undefined);
+        assert.equal(collection.get('member2'), undefined);
+      });
+    });
+
+    describe('setAll', () => {
+      it('replaces all members with new collection', () => {
+        // Add initial member
+        collection.set('member1', member1);
+        assert.equal(Object.keys(collection.getAll()).length, 1);
+
+        // Set all with new collection
+        const newMembers = {
+          'member2': member2,
+          'member3': new Member(participant1)
+        };
+        collection.setAll(newMembers);
+
+        assert.equal(Object.keys(collection.getAll()).length, 2);
+        assert.equal(collection.get('member1'), undefined);
+        assert.equal(collection.get('member2'), member2);
+        assert.exists(collection.get('member3'));
+      });
+    });
+
+    describe('get', () => {
+      it('returns undefined for non-existent members', () => {
+        assert.equal(collection.get('nonExistent'), undefined);
+      });
+
+      it('returns correct member for existing id', () => {
+        collection.set('member1', member1);
+        assert.equal(collection.get('member1'), member1);
+      });
+    });
+
+    describe('getAll', () => {
+      it('returns empty object when no members', () => {
+        const allMembers = collection.getAll();
+        assert.isObject(allMembers);
+        assert.equal(Object.keys(allMembers).length, 0);
+      });
+
+      it('returns all members', () => {
+        collection.set('member1', member1);
+        collection.set('member2', member2);
+        
+        const allMembers = collection.getAll();
+        assert.equal(Object.keys(allMembers).length, 2);
+        assert.equal(allMembers.member1, member1);
+        assert.equal(allMembers.member2, member2);
+      });
+    });
+  });
+});