@webex/plugin-meetings 3.9.0-next.14 → 3.9.0-next.16

package/test/unit/spec/meeting/utils.js

@@ -228,11 +228,11 @@ describe('plugin-meetings', () => {
       });
     });
 
-    describe('updateLocusWithDelta', () => {
-      it('should call handleLocusDelta with the new delta locus', () => {
+    describe('updateLocusFromApiResponse', () => {
+      it('should call handleLocusAPIResponse with the response body', () => {
         const meeting = {
           locusInfo: {
-            handleLocusDelta: sinon.stub(),
+            handleLocusAPIResponse: sinon.stub(),
           },
         };
 
@@ -242,16 +242,16 @@ describe('plugin-meetings', () => {
           },
         };
 
-        const response = MeetingUtil.updateLocusWithDelta(meeting, originalResponse);
+        const response = MeetingUtil.updateLocusFromApiResponse(meeting, originalResponse);
 
         assert.deepEqual(response, originalResponse);
-        assert.calledOnceWithExactly(meeting.locusInfo.handleLocusDelta, 'locus', meeting);
+        assert.calledOnceWithExactly(meeting.locusInfo.handleLocusAPIResponse, meeting, originalResponse.body);
       });
 
       it('should handle locus being missing from the response', () => {
         const meeting = {
           locusInfo: {
-            handleLocusDelta: sinon.stub(),
+            handleLocusAPIResponse: sinon.stub(),
           },
         };
 
@@ -259,10 +259,10 @@ describe('plugin-meetings', () => {
           body: {},
         };
 
-        const response = MeetingUtil.updateLocusWithDelta(meeting, originalResponse);
+        const response = MeetingUtil.updateLocusFromApiResponse(meeting, originalResponse);
 
         assert.deepEqual(response, originalResponse);
-        assert.notCalled(meeting.locusInfo.handleLocusDelta);
+        assert.notCalled(meeting.locusInfo.handleLocusAPIResponse);
       });
 
       it('should work with an undefined meeting', () => {
@@ -272,14 +272,14 @@ describe('plugin-meetings', () => {
           },
         };
 
-        const response = MeetingUtil.updateLocusWithDelta(undefined, originalResponse);
+        const response = MeetingUtil.updateLocusFromApiResponse(undefined, originalResponse);
         assert.deepEqual(response, originalResponse);
       });
     });
 
     describe('generateLocusDeltaRequest', () => {
       it('generates the correct wrapper function', async () => {
-        const updateLocusWithDeltaSpy = sinon.spy(MeetingUtil, 'updateLocusWithDelta');
+        const updateLocusFromApiResponseSpy = sinon.spy(MeetingUtil, 'updateLocusFromApiResponse');
         const addSequenceSpy = sinon.spy(MeetingUtil, 'addSequence');
 
         const meeting = {
@@ -296,16 +296,16 @@ describe('plugin-meetings', () => {
         let result = await locusDeltaRequest(options);
 
         assert.equal(result, 'result');
-        assert.calledOnceWithExactly(updateLocusWithDeltaSpy, meeting, 'result');
+        assert.calledOnceWithExactly(updateLocusFromApiResponseSpy, meeting, 'result');
         assert.calledOnceWithExactly(addSequenceSpy, meeting, options.body);
 
-        updateLocusWithDeltaSpy.resetHistory();
+        updateLocusFromApiResponseSpy.resetHistory();
         addSequenceSpy.resetHistory();
 
         // body missing from options
         result = await locusDeltaRequest({});
         assert.equal(result, 'result');
-        assert.calledOnceWithExactly(updateLocusWithDeltaSpy, meeting, 'result');
+        assert.calledOnceWithExactly(updateLocusFromApiResponseSpy, meeting, 'result');
         assert.calledOnceWithExactly(addSequenceSpy, meeting, options.body);
 
         // meeting disappears so the WeakRef returns undefined
@@ -359,7 +359,11 @@ describe('plugin-meetings', () => {
     });
 
     describe('remoteUpdateAudioVideo', () => {
-      it('#Should call meetingRequest.locusMediaRequest with correct parameters', async () => {
+      it('#Should call meetingRequest.locusMediaRequest with correct parameters and return the full response', async () => {
+        const fakeResponse = {
+          body: { locus: { url: 'locusUrl'}},
+          headers: { },
+        };
         const meeting = {
           id: 'meeting-id',
           mediaId: '12345',
@@ -368,13 +372,14 @@ describe('plugin-meetings', () => {
             sequence: {},
           },
           locusMediaRequest: {
-            send: sinon.stub().resolves({body: {}, headers: {}}),
+            send: sinon.stub().resolves(fakeResponse),
           },
           getWebexObject: sinon.stub().returns(webex),
         };
 
-        await MeetingUtil.remoteUpdateAudioVideo(meeting, true, false);
+        const result = await MeetingUtil.remoteUpdateAudioVideo(meeting, true, false);
 
+        assert.deepEqual(result, fakeResponse);
         assert.calledOnceWithExactly(meeting.locusMediaRequest.send, {
           mediaId: '12345',
           muteOptions: {

package/test/unit/spec/members/collection.js

@@ -0,0 +1,120 @@
+const { default: MembersCollection } = require("../../../../src/members/collection");
+const { default: Member } = require("../../../../src/member");
+const { assert } = require('@webex/test-helper-chai');
+
+
+describe('plugin-meetings', () => {
+  describe('MembersCollection', () => {
+    let collection;
+    let member1;
+    let member2;
+    const participant1 = { controls: {}, status: {} };
+    const participant2 = { controls: {}, status: {} };
+
+    beforeEach(() => {
+      collection = new MembersCollection();
+      member1 = new Member(participant1);
+      member2 = new Member(participant2);
+    });
+
+    it('starts with no members', () => {
+      assert.equal(Object.keys(collection.getAll()).length, 0);
+    });
+
+    it('can add members', () => {      
+      collection.set('member1', member1);
+      assert.equal(Object.keys(collection.getAll()).length, 1);
+      assert.equal(collection.get('member1'), member1);
+
+      collection.set('member2', member2);
+      assert.equal(Object.keys(collection.getAll()).length, 2);
+      assert.equal(collection.get('member2'), member2);
+    });
+
+    it('can remove members', () => {
+      // Add some members first
+      collection.set('member1', member1);
+      collection.set('member2', member2);
+      assert.equal(Object.keys(collection.getAll()).length, 2);
+
+      // Remove one member
+      collection.remove('member1');
+      assert.equal(Object.keys(collection.getAll()).length, 1);
+      assert.equal(collection.get('member1'), undefined);
+      assert.equal(collection.get('member2'), member2);
+
+      // Remove another member
+      collection.remove('member2');
+      assert.equal(Object.keys(collection.getAll()).length, 0);
+      assert.equal(collection.get('member2'), undefined);
+
+      // Removing non-existent member should not cause errors
+      collection.remove('nonExistent');
+      assert.equal(Object.keys(collection.getAll()).length, 0);
+    });
+
+    describe('reset', () => {
+      it('removes all members', () => {
+        // Add some members first
+        collection.set('member1', member1);
+        collection.set('member2', member2);
+        assert.equal(Object.keys(collection.getAll()).length, 2);
+
+        // Reset should clear all members
+        collection.reset();
+        assert.equal(Object.keys(collection.getAll()).length, 0);
+        assert.equal(collection.get('member1'), undefined);
+        assert.equal(collection.get('member2'), undefined);
+      });
+    });
+
+    describe('setAll', () => {
+      it('replaces all members with new collection', () => {
+        // Add initial member
+        collection.set('member1', member1);
+        assert.equal(Object.keys(collection.getAll()).length, 1);
+
+        // Set all with new collection
+        const newMembers = {
+          'member2': member2,
+          'member3': new Member(participant1)
+        };
+        collection.setAll(newMembers);
+
+        assert.equal(Object.keys(collection.getAll()).length, 2);
+        assert.equal(collection.get('member1'), undefined);
+        assert.equal(collection.get('member2'), member2);
+        assert.exists(collection.get('member3'));
+      });
+    });
+
+    describe('get', () => {
+      it('returns undefined for non-existent members', () => {
+        assert.equal(collection.get('nonExistent'), undefined);
+      });
+
+      it('returns correct member for existing id', () => {
+        collection.set('member1', member1);
+        assert.equal(collection.get('member1'), member1);
+      });
+    });
+
+    describe('getAll', () => {
+      it('returns empty object when no members', () => {
+        const allMembers = collection.getAll();
+        assert.isObject(allMembers);
+        assert.equal(Object.keys(allMembers).length, 0);
+      });
+
+      it('returns all members', () => {
+        collection.set('member1', member1);
+        collection.set('member2', member2);
+        
+        const allMembers = collection.getAll();
+        assert.equal(Object.keys(allMembers).length, 2);
+        assert.equal(allMembers.member1, member1);
+        assert.equal(allMembers.member2, member2);
+      });
+    });
+  });
+});

package/test/unit/spec/members/index.js

@@ -320,9 +320,18 @@ describe('plugin-meetings', () => {
           EVENT_TRIGGERS.MEMBERS_CLEAR,
           {}
         );
+        sinon.restore();
       });
     });
     describe('#locusParticipantsUpdate', () => {
+      beforeEach(() => {
+        sinon.stub(Trigger, 'trigger');
+      });
+
+      afterEach(() => {
+        sinon.restore();
+      });
+
       it('should send member update event with session info', () => {
         const members = createMembers({url: url1});
         const fakePayload = {
@@ -343,13 +352,45 @@ describe('plugin-meetings', () => {
           },
           EVENT_TRIGGERS.MEMBERS_UPDATE,
           {
-            delta: {added: [], updated: []},
+            delta: {added: [], updated: [], removedIds: []},
             full: {},
             isReplace: true,
           }
         );
       });
 
+      it('should handle participants being removed', () => {
+        const members = createMembers({url: url1});
+
+        // setup the collection with a fake member
+        members.membersCollection.setAll(fakeMembersCollection);
+        assert.equal(Object.keys(members.membersCollection.getAll()).length, 1);
+
+        // remove the member
+        members.locusParticipantsUpdate({
+          participants: [],
+          removedParticipantIds: ['test1'],
+        });
+
+        assert.equal(Object.keys(members.membersCollection.getAll()).length, 0);
+
+        // check that the event was emitted
+        assert.calledWith(
+          Trigger.trigger,
+          members,
+          {
+            file: 'members',
+            function: 'locusParticipantsUpdate',
+          },
+          EVENT_TRIGGERS.MEMBERS_UPDATE,
+          {
+            delta: {added: [], updated: [], removedIds: ['test1']},
+            full: {},
+            isReplace: false,
+          }
+        );
+      });
+
       describe('handles members with paired devices correctly', () => {
         const runCheck = (propsForUpdate, expectedPropsOnPairedMember) => {
           const members = createMembers({url: url1});