@webex/plugin-meetings 3.8.1 → 3.9.0-webinar5k.1

package/test/unit/spec/media/index.ts

@@ -137,6 +137,113 @@ describe('createMediaConnection', () => {
     );
   });
 
+  it('should set direction to sendonly for both audio and video when only send flags are true', () => {
+    const roapMediaConnectionConstructorStub = sinon
+      .stub(InternalMediaCoreModule, 'RoapMediaConnection')
+      .returns(fakeRoapMediaConnection);
+  
+    StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
+  
+    const ENABLE_EXTMAP = false;
+    const ENABLE_RTX = true;
+  
+    Media.createMediaConnection(false, 'sendonly-debug-id', 'meetingId', {
+      mediaProperties: {
+        mediaDirection: {
+          sendAudio: true,
+          receiveAudio: false,
+          sendVideo: true,
+          receiveVideo: false,
+          sendShare: false,
+          receiveShare: false,
+        },
+        audioStream: fakeAudioStream,
+        videoStream: fakeVideoStream,
+        shareVideoTrack: null,
+        shareAudioTrack: null,
+      },
+      remoteQualityLevel: 'HIGH',
+      enableRtx: ENABLE_RTX,
+      enableExtmap: ENABLE_EXTMAP,
+      turnServerInfo: undefined,
+      iceCandidatesTimeout: undefined,
+    });
+  
+    assert.calledWith(
+      roapMediaConnectionConstructorStub,
+      sinon.match.any,
+      {
+        localTracks: {
+          audio: fakeTrack,
+          video: fakeTrack,
+          screenShareVideo: undefined,
+          screenShareAudio: undefined,
+        },
+        direction: {
+          audio: 'sendonly',
+          video: 'sendonly',
+          screenShareVideo: 'inactive',
+        },
+        remoteQualityLevel: 'HIGH',
+      },
+      'sendonly-debug-id'
+    );
+  });
+
+  it('should set direction to recvonly for both audio and video when only receive flags are true', () => {
+    const roapMediaConnectionConstructorStub = sinon
+      .stub(InternalMediaCoreModule, 'RoapMediaConnection')
+      .returns(fakeRoapMediaConnection);
+  
+    StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
+  
+    const ENABLE_EXTMAP = true;
+    const ENABLE_RTX = false;
+  
+    Media.createMediaConnection(false, 'recvonly-debug-id', 'meetingId', {
+      mediaProperties: {
+        mediaDirection: {
+          sendAudio: false,
+          receiveAudio: true,
+          sendVideo: false,
+          receiveVideo: true,
+          sendShare: false,
+          receiveShare: false,
+        },
+        audioStream: fakeAudioStream,
+        videoStream: fakeVideoStream,
+        shareVideoTrack: null,
+        shareAudioTrack: null,
+      },
+      remoteQualityLevel: 'HIGH',
+      enableRtx: ENABLE_RTX,
+      enableExtmap: ENABLE_EXTMAP,
+      turnServerInfo: undefined,
+      iceCandidatesTimeout: undefined,
+    });
+  
+    assert.calledWith(
+      roapMediaConnectionConstructorStub,
+      sinon.match.any,
+      {
+        localTracks: {
+          audio: fakeTrack,
+          video: fakeTrack,
+          screenShareVideo: undefined,
+          screenShareAudio: undefined,
+        },
+        direction: {
+          audio: 'recvonly',
+          video: 'recvonly',
+          screenShareVideo: 'inactive',
+        },
+        remoteQualityLevel: 'HIGH',
+      },
+      'recvonly-debug-id'
+    );
+  });
+  
+
   it('creates a MultistreamRoapMediaConnection when multistream is enabled', () => {
     const multistreamRoapMediaConnectionConstructorStub = sinon
       .stub(InternalMediaCoreModule, 'MultistreamRoapMediaConnection')

package/test/unit/spec/meeting/brbState.ts

@@ -1,12 +1,14 @@
 import sinon from 'sinon';
-import {assert} from '@webex/test-helper-chai';
+import {assert, expect} from '@webex/test-helper-chai';
 
 import testUtils from '../../../utils/testUtils';
 import {BrbState, createBrbState} from '@webex/plugin-meetings/src/meeting/brbState';
+import {MediaType} from '@webex/internal-media-core';
 
 describe('plugin-meetings', () => {
   let meeting: any;
   let brbState: BrbState;
+  let setBrbStub: sinon.SinonStub;
 
   beforeEach(async () => {
     meeting = {
@@ -21,14 +23,20 @@ describe('plugin-meetings', () => {
         setSourceStateOverride: sinon.stub(),
       },
       meetingRequest: {
-        setBrb: sinon.stub().resolves(),
+        setBrb: () => {},
       },
     };
 
+    setBrbStub = sinon.stub(meeting.meetingRequest, 'setBrb').resolves();
+
     brbState = new BrbState(meeting, false);
     await testUtils.flushPromises();
   });
 
+  afterEach(() => {
+    sinon.restore();
+  });
+
   describe('brbState library', () => {
     it('takes into account current status when instantiated', async () => {
       // create a new BrbState instance
@@ -96,12 +104,12 @@ describe('plugin-meetings', () => {
       assert.isTrue(meeting.meetingRequest.setBrb.calledOnce);
     });
 
-    it('sets source state override when client state does not match server state', async () => {
+    it('updates source state override', async () => {
       brbState.enable(true, meeting.sendSlotManager);
       brbState.handleServerBrbUpdate(true);
       await testUtils.flushPromises();
 
-      assert.isTrue(meeting.sendSlotManager.setSourceStateOverride.calledOnce);
+      assert.isTrue(meeting.sendSlotManager.setSourceStateOverride.called);
     });
 
     it('handles server update', async () => {
@@ -129,5 +137,16 @@ describe('plugin-meetings', () => {
       sendLocalBrbStateToServerStub.restore();
       handleServerBrbUpdateSpy.restore();
     });
+
+    it('should reject when sendLocalBrbStateToServer fails', async () => {
+      const error = new Error('send failed');
+      setBrbStub.rejects(error);
+
+      const enablePromise = brbState.enable(true, meeting.sendSlotManager);
+      await expect(enablePromise).to.be.rejectedWith(error);
+
+      assert.isFalse(brbState.state.syncToServerInProgress);
+      expect(meeting.sendSlotManager.setSourceStateOverride.called).to.be.false;
+    });
   });
 });

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -102,6 +102,8 @@ describe('plugin-meetings', () => {
         canEnableRemoteDesktopControl: null,
         canDisableRemoteDesktopControl: null,
         canMoveToLobby: null,
+        canEnablePollingQA: null,
+        canDisablePollingQA: null,
 
         ...expected,
       };
@@ -210,6 +212,8 @@ describe('plugin-meetings', () => {
       'canEnableRemoteDesktopControl',
       'canDisableRemoteDesktopControl',
       'canMoveToLobby',
+      'canEnablePollingQA',
+      'canDisablePollingQA',
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();